[00:00:45] Fundraising Sprint William Shatner, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 3 others: Slow searches: Transaction by ID # using % and also Contribs by email address - https://phabricator.wikimedia.org/T117492#1775713 (awight) [00:01:10] Fundraising Sprint William Shatner, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 3 others: Slow searches: Transaction by ID # using % and also Contribs by email address - https://phabricator.wikimedia.org/T117492#1784255 (awight) a:Eileenmcnaughton [00:04:54] (CR) Ejegg: "recheck" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/250880 (https://phabricator.wikimedia.org/T107045) (owner: Ejegg) [00:05:59] ejegg: that thing is just not running any jobs or merging! [00:06:08] bah [00:08:39] (CR) Ejegg: [V: 2] Fix 'latest donation' logic [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/250880 (https://phabricator.wikimedia.org/T107045) (owner: Ejegg) [00:09:39] (PS1) Ejegg: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/251169 [00:10:14] awight: cool to merge those 'linter' patches to tools deploy branch? [00:11:31] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Sprint William Shatner, Fundraising Tech Backlog, and 4 others: Verify kafkatee use for fundraising logs on erbium - https://phabricator.wikimedia.org/T97676#1784279 (awight) I think we're prepared to make this change now. The... [00:11:35] ejegg: yah sure! [00:12:05] (CR) Ejegg: [C: 2 V: 2] Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/251169 (owner: Ejegg) [00:13:26] !log updated fundraising tools from e1b60fa2c258fd4ff55905b03a4d8886132278c1 to f2f571903d32ec73aeab73ce58c6bee71717213b [00:13:31] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [00:13:34] Fundraising-Backlog, Continuous-Integration-Config: wikimedia/fundraising/tools CI jobs are broken - https://phabricator.wikimedia.org/T117818#1784282 (awight) NEW [00:15:11] awight: have we scrutinized recurring since the upgrade? All good there? [00:15:43] ejegg: nobody has verified it yet [00:15:53] :~{ [00:16:01] k, i might take a look while I wait for sp export [00:16:27] good news is that the test Adyen donation made it all the way into Civi! [00:19:29] Fundraising-Backlog, FR-Adyen: Adyen donation messages missing payment submethod - https://phabricator.wikimedia.org/T117820#1784308 (Ejegg) NEW [00:20:10] wowza! [00:20:39] That sounds a lot better than tying cwd|afk to the nuclear train all winter [00:21:27] Fundraising Sprint Vengaboys, Fundraising Sprint William Shatner, Fundraising-Backlog, Patch-For-Review, WMF-deploy-2015-10-27_(1.27.0-wmf.4): SPIKE: assess the condition of adyen for english backup processing - https://phabricator.wikimedia.org/T114958#1784320 (Ejegg) Test donation made it all... [00:22:01] awight: anything but Worldpay! [00:22:28] * awight glares at their IPO [00:22:35] Serious Barnum and Bailey stuff, there [00:23:02] heh. Who was that Bailey character, anyway? [00:23:17] Oh huh, perhaps that's an apocryphal quote: https://en.wikipedia.org/wiki/There's_a_sucker_born_every_minute [00:23:27] good question! [00:23:35] PT didn't actually say that?? [00:23:57] https://en.wikipedia.org/wiki/Ringling_Bros._and_Barnum_%26_Bailey_Circus [00:24:02] hehe Mattel owned it for a decade [00:24:23] * awight sighs at all the mystery Wikipedia has dried up in the world [00:28:41] currently running the insert into temp_silverpop_export_latest [00:28:47] (query #9) [00:28:54] cool! [00:32:53] Fundraising Sprint Vengaboys, Fundraising Sprint William Shatner, Fundraising-Backlog, Patch-For-Review, WMF-deploy-2015-10-27_(1.27.0-wmf.4): SPIKE: assess the condition of adyen for english backup processing - https://phabricator.wikimedia.org/T114958#1784367 (atgo) wow! [00:39:28] dang, query 9 is going on 15 minutes. [00:39:49] but the recurring donations look good! [00:40:19] whew! Thanks for jumping on that, usually I wait a few months until there's an enormous mess [00:40:35] hehe [00:41:30] Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work, Patch-For-Review: Engage is unable to save donations in Civi - https://phabricator.wikimedia.org/T117573#1784387 (awight) Open>Resolved Confirmed working. [00:42:55] hmm, requeueing amazon messages with no completion message. [00:43:06] Ohh, that should be a refund, I think... [00:46:37] phooey, 22 minutes in abd q9 is still running [00:48:25] damn, my fault [00:48:37] try explaining that query perhaps? a filesort will kill us [00:52:19] ahh phooey, we're losing the correlation when the user lets their session time out on our side. [00:56:26] eh? [00:56:42] Fundraising-Backlog, FR-Amazon: Amazon donor details missing when they donate after session timeout - https://phabricator.wikimedia.org/T117827#1784418 (Ejegg) NEW [00:57:53] I think that's what happened anyway [00:59:09] eep, query 9 took 27 minutes. hope we save a bunch of time where we used to do the latest donation joins [01:00:10] awight: yeah, I'll set up the temp tables and try a couple variations, probably tomorrow [01:00:27] ok, gonna relocate [01:00:30] ejegg: rad. Yeah, explain is my only friend in the db world [10:15:18] Fundraising-Backlog, Continuous-Integration-Config: wikimedia/fundraising/tools CI jobs are broken - https://phabricator.wikimedia.org/T117818#1785044 (hashar) Open>Resolved a:hashar I fixed it with https://gerrit.wikimedia.org/r/#/c/251208/ , the reason is gate-and-submit only has the jobs `jsh... [14:54:58] the-wub: Hi! At Wikimedia Germany we are trying to setup a test campaign with big banners. We've created a big banner and we only want to show it once. Once user was displayed with a big banner than only small ones should be displayed. I've heard you are guys something like this. Could you point me to some example campaign with big+small banners so I could take a look how one achieves this? [14:58:13] Hi leszek_wmde! https://meta.wikimedia.org/w/index.php?title=Special:CentralNotice&subaction=noticeDetail¬ice=C1516_frFR_dsk_hi_FR is an example of such a campaign [14:59:39] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Sprint William Shatner, Fundraising Tech Backlog, and 4 others: Verify kafkatee use for fundraising logs on erbium - https://phabricator.wikimedia.org/T97676#1785481 (Jgreen) > Maybe we can doctor the last old files and the fir... [15:00:50] the-wub: thanks! I suspected this one might be it. Am I right in thinking that small banners from buckets C and D could be also shown to a user that hasn't seen a big banner yet? Or are there only "available" after banner from bucket A and B has been displayed? [15:01:38] the-wub: we were thinking of using more than two buckets but I am not sure how to achieve it that bucket A or B is always used first [15:02:06] users don't get buckets C&D naturally. there is a script in the A&B banners which places them into C&D. so yes, they have to see an A/B banner first [15:04:50] the-wub: now I get it. Thanks a lot. I have actually looked at this bucket changing script already twice today :) But only when you mentioned it it became clear to me how it works. Thank you! [15:05:16] no problem :) [15:14:22] the-wub: Me again :) One last question regarding the buckets. If we place a user into bucket C, and than set up a new campaign with only two buckets (so no C). Would this be a source of any problems (e.g. user not getting any banner as long as she doesn't get out of the bucket C?) [15:15:09] no, if a campaign only has 2 buckets then C counts as A, and D counts as B [15:15:35] note that buckets are per-campaign though. they don't carry over to different campaigns [15:16:35] the-wub: oh, that makes a lot of sense. sorry for asking. I was thinking the buckets are indeed living more than campaign. This is clear now. Thank you! [15:41:59] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Sprint William Shatner, Fundraising Tech Backlog, and 4 others: Verify kafkatee use for fundraising logs on erbium - https://phabricator.wikimedia.org/T97676#1785592 (Pcoombe) @awight Sounds like it would be safest to just take... [15:52:17] Hi leszek_wmde ! We're about to deploy a campaign mixin to deliver that banner switching script via ResourceLoader rather than on-wiki JavaScript. ( https://phabricator.wikimedia.org/T90919 ) [15:54:54] Fundraising-Backlog: Donation form error message: "No processors available" - https://phabricator.wikimedia.org/T117872#1785597 (MBeat33) NEW [16:00:54] ejegg: that looks really interesting! we'll have a look on this, probably once it is deployed. Not using tricks would be nice [16:01:28] Yep! I'll send out an email to the centralnotice-admins list once that's available. [16:02:15] ejegg: awesome! [17:17:49] (PS1) Eileen: CRM-17466 - Refine error message [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/251276 [17:17:51] (PS1) Eileen: Footer tpl cleanup [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/251277 [17:24:50] (PS1) Eileen: Add test for Fix thank_you to not use ported 4.2 custom api [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/251279 [17:26:51] (CR) jenkins-bot: [V: -1] Add test for Fix thank_you to not use ported 4.2 custom api [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/251279 (owner: Eileen) [17:29:22] (PS1) AndyRussG: Campaign categories using legacy: global config var and data property [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251284 (https://phabricator.wikimedia.org/T117650) [18:54:28] howdy ejegg [18:54:37] hi cwd [18:54:40] how's it going? [18:54:47] oh same old [18:54:49] you? [18:55:13] pretty good, finally decided to go to PT for the ankle [18:55:40] looks like I don't have too much to worry about, just need to do some exercises [18:55:55] hi awight [18:55:55] hurt?! [18:55:57] nice, how does it feel? [18:56:01] hey! [18:56:08] hello [18:56:29] oh, just the old ankle thing - i re-injured it in September but I'm finally wising up and doing PT [18:56:30] Lovely California morning! [18:56:43] ouch [18:56:45] ejegg: aww, nuts. Take it easy this time [18:56:51] How's the time adjustment treating you, eileen ? [18:57:00] = the "T" rather than your metal horse [18:57:43] heh, actually riding a bicycle is perfect exercise for it - all hinge motion, nothing sideways [18:57:57] jackpot [18:59:31] (PS2) Eileen: Add test for Fix thank_you to not use ported 4.2 custom api [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/251279 [18:59:55] Too bad you can't swim down the Charles [19:00:20] hehe, some people do these days! I'm not about to [19:00:25] ejegg: doing pretty well - it's an easy adjustment in this direction [19:00:43] ah, nice [19:00:50] awight, ejegg: i was hoping to get your opinions on this, i can't run composer update in crm without a ton of changes. have we been editing the lockfile by hand? [19:01:00] cwd: guilty as charged [19:01:25] but we could probably use some updating [19:02:09] cwd: We cheat, composer.lock should probably be on the deployment branch only [19:02:10] yeah meganhernandez!! [19:02:25] cool, that's what i thought [19:02:30] we run "install" to sync with deployment versions, but no reason to have then in master [19:02:32] ejegg: i have done that too [19:02:59] yeah, well just fiddling with the deploy script, getting that stuff in order seems like the best approach [19:03:04] rather than making it do something silly [19:03:31] so we should be able to run "composer update" pre deploy right? [19:03:56] don't we depend on some dev packages? [19:04:10] only for running tests [19:04:32] oh, there are 'dev-master' flavor packages amongst our dependencies [19:04:46] but those aren't in the dev-dependencies [19:04:59] aaah, so --no-dev won't filter those out? [19:05:08] correct [19:05:28] great [19:05:39] awight: I like having composer.lock in master [19:05:52] In fact, I think we need it to get the right versions of libs sometimes [19:07:37] i was able to get update to work in crm by changing dev-master to @dev which i think defers the stability of dependencies of children to the child...am i understanding that right? [19:08:27] oh, i never heard of that! [19:10:35] lemme just try pushing that up and we can see how close it is to deployable after update [19:14:13] Yeah it's great having composer.lock in master, and we're always free to update that as code can support it [19:16:57] so i think getting .lock syncd up to update can be run is going to take awhile [19:17:33] i better make a task [19:18:50] composer.lock | 1193 +++++++++++++------------------------------------------------------------------------------------------------------------------------------------------ [19:19:58] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Adyen: Fix CSS on Adyen form - https://phabricator.wikimedia.org/T117897#1786371 (Ejegg) NEW [19:21:14] Fundraising-Backlog: Get composer.json in crm deployable - https://phabricator.wikimedia.org/T117898#1786378 (cwdent) NEW [19:21:22] Fundraising-Backlog: Failing SmashPig job runner should not act like a mid-1980s photocopy machine - https://phabricator.wikimedia.org/T117447#1786386 (Ejegg) Spamizdat? [19:22:17] (Abandoned) Eileen: Add test for Fix thank_you to not use ported 4.2 custom api [wikimedia/fundraising/crm] (master-plus-4.6.9) - https://gerrit.wikimedia.org/r/249956 (owner: Eileen) [19:23:38] (Abandoned) Eileen: Fix thank_you to not use ported 4.2 custom api [wikimedia/fundraising/crm] (master-plus-4.6.9) - https://gerrit.wikimedia.org/r/249955 (owner: Eileen) [19:23:51] cwd: ooh yeah this should be a feature of the deployment scripts [19:24:08] I guess it's never run during deployment build though, it's a separate step [19:24:28] running composer update? definitely [19:24:43] Hope u r all tuned into the metrics meeting [19:25:05] i had it updating the lockfile manually but then i was like this is bad [19:27:23] awight: different forms of knowledge sounds promising [19:27:40] ;) I like a lot of what's happening [19:27:59] rhgh html5 youtube must not stream [19:28:32] * cwd opens chrome [19:38:18] (PS1) Ejegg: Move failed jobs to damage queue [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/251314 (https://phabricator.wikimedia.org/T117447) [19:38:37] Fundraising Sprint William Shatner, Fundraising-Backlog, Unplanned-Sprint-Work: Failing SmashPig job runner should not act like a mid-1980s photocopy machine - https://phabricator.wikimedia.org/T117447#1786418 (Ejegg) a:Ejegg [19:42:58] (CR) Ejegg: [C: 2] "good stuff!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251026 (https://phabricator.wikimedia.org/T117650) (owner: AndyRussG) [19:53:13] (PS1) Eileen: Add deprecation comments to 4.2 custom api [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/251318 [19:53:56] (Abandoned) Eileen: Add deprecation comments to 4.2 custom api [wikimedia/fundraising/crm/civicrm] (master-plus-4.6.9) - https://gerrit.wikimedia.org/r/249958 (owner: Eileen) [20:44:31] (CR) Awight: "Heck yeah! "damage" looks pretty intentional cos it's everywhere, but it bothers me that this label clashes with "-damaged"." (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/251314 (https://phabricator.wikimedia.org/T117447) (owner: Ejegg) [20:50:36] (PS2) Ejegg: Move failed jobs to damage queue [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/251314 (https://phabricator.wikimedia.org/T117447) [21:03:54] Fundraising Sprint William Shatner, Fundraising-Backlog, Unplanned-Sprint-Work: Failing SmashPig job runner should not act like a mid-1980s photocopy machine - https://phabricator.wikimedia.org/T117447#1786710 (atgo) We are seeing an error "PC load-letter". Not sure if that helps. [21:04:27] Fundraising Sprint Vengaboys, Fundraising Sprint William Shatner, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Create new civicrm repo - https://phabricator.wikimedia.org/T114831#1786711 (atgo) a:Eileenmcnaughton [21:07:38] Fundraising Sprint William Shatner, Fundraising-Backlog, Unplanned-Sprint-Work, FR-Amazon: Amazon donor details missing when they donate after session timeout - https://phabricator.wikimedia.org/T117827#1786735 (Ejegg) a:Ejegg [21:10:12] Fundraising Sprint William Shatner, Fundraising-Backlog, Patch-For-Review: Dedupe data in Silverpop file - https://phabricator.wikimedia.org/T107045#1786741 (CCogdill_WMF) Hey @Ejegg, you may know this but wanted to give you an FYI that the file was uploaded to Silverpop two times last night. [21:34:53] Wikimedia-Fundraising-CiviCRM: Apply CiviCRM security patches - https://phabricator.wikimedia.org/T117917#1786818 (Eileenmcnaughton) NEW a:Eileenmcnaughton [21:35:46] Fundraising Sprint William Shatner, Fundraising-Backlog, Patch-For-Review: Dedupe data in Silverpop file - https://phabricator.wikimedia.org/T107045#1786832 (CCogdill_WMF) Woohoo, thanks, @Ejegg! What was the solution you ended up using? Just sending the last donation, or did you merge contact records... [21:37:11] Fundraising Sprint William Shatner, Wikimedia-Fundraising-CiviCRM: Apply CiviCRM security patches - https://phabricator.wikimedia.org/T117917#1786837 (Eileenmcnaughton) [21:41:09] Fundraising Sprint William Shatner, Fundraising-Backlog, Patch-For-Review: Dedupe data in Silverpop file - https://phabricator.wikimedia.org/T107045#1786860 (Ejegg) I moved the 'latest donation' logic up earlier in the process, when we still have all of the contact IDs for a given email. Then I change... [21:42:10] Fundraising-Backlog: Add field data back into Silverpop export - https://phabricator.wikimedia.org/T105254#1786863 (Ejegg) [21:42:12] Fundraising Sprint William Shatner, Fundraising-Backlog, Patch-For-Review: Dedupe data in Silverpop file - https://phabricator.wikimedia.org/T107045#1786862 (Ejegg) Open>Resolved [21:44:03] Fundraising Sprint William Shatner, Fundraising-Backlog, Patch-For-Review: Dedupe data in Silverpop file - https://phabricator.wikimedia.org/T107045#1786867 (CCogdill_WMF) Great, that all sounds good. So tomorrow should be the first time the new file will be imported into Silverpop? Thank you for noti... [21:49:40] Fundraising Sprint William Shatner, Fundraising-Backlog, Patch-For-Review: Dedupe data in Silverpop file - https://phabricator.wikimedia.org/T107045#1786879 (Ejegg) This morning's export used the new logic. My plan was that if the test yesterday ended up with bad data, I'd just go back to the old code... [21:55:53] I'm feeling like some of the new post-4.6 issues are higher priority than the ones in this sprint - do I just pull them in? I have tasks in this sprint around the repo & tests but there is a slowness on dedupe & some wierdness on report save in the not-yet-triaged list [22:01:14] (PS1) AndyRussG: Make cookiesEnabled() a public mw.centralNotice function [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251419 (https://phabricator.wikimedia.org/T117650) [23:31:12] hi ejegg :) [23:31:22] hi ccogdill [23:31:27] how's it going? [23:31:27] quick question - did you already make a phab task for the refunds in the silverpop file? [23:31:41] oops, got distracted by something else! [23:31:43] I want to try to escalate this, so I’m happy to create the task if you haven’t already. [23:31:44] will do that right now [23:31:50] no don’t worry! I can make it [23:31:58] I can provide context for why it’s important anyway, if that helps [23:32:27] wasn’t trying to nudge you to do it, ejegg :D [23:33:06] Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Don't include refunded donations in Silverpop export - https://phabricator.wikimedia.org/T117931#1787196 (Ejegg) NEW a:Ejegg [23:33:17] ah, thank you! [23:33:34] sure thing! Feel free to add context to that ticket [23:33:42] will do [23:40:22] Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Don't include refunded donations in Silverpop export - https://phabricator.wikimedia.org/T117931#1787224 (CCogdill_WMF) [23:43:24] (PS1) Ejegg: Exclude refunded donations in 'latest' calculation [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/251433 (https://phabricator.wikimedia.org/T117931) [23:43:52] (PS1) Eileen: Fix report criteria not showing in output mode [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/251434 [23:44:23] Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Report criteria is not displayed in web results - https://phabricator.wikimedia.org/T117168#1787232 (Eileenmcnaughton) a:Eileenmcnaughton [23:44:52] Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Report criteria is not displayed in web results - https://phabricator.wikimedia.org/T117168#1768009 (Eileenmcnaughton) I just pulled this into the sprint & added a fix - also trying to get this into core upstream [23:47:48] (CR) Eileen: [C: 1] "This totally makes sense to me (although I don't feel confident to jump in & start +2ing yet)" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/251433 (https://phabricator.wikimedia.org/T117931) (owner: Ejegg) [23:48:02] thanks eileen ! [23:48:32] ejegg: I've been pretty shy of reviewing when I don't understand everything end to end - but I thought +1 had to pretty safe :-) [23:49:34] Fundraising Sprint William Shatner, Fundraising-Backlog, Unplanned-Sprint-Work, FR-Amazon: Amazon donor details missing when they donate after session timeout - https://phabricator.wikimedia.org/T117827#1784418 (Ejegg) Ah dang, we're not checking session tokens at all in the Amazon gateway. Needs... [23:50:33] heh, always nice to have the vote of confidence