[01:06:11] Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Reports "Save a Copy" is broken - https://phabricator.wikimedia.org/T117166#1787368 (Eileenmcnaughton) a:Eileenmcnaughton [01:07:03] (PS1) Eileen: Fix save a copy behaviour on report [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/251448 [05:46:10] (PS1) AndyRussG: impressionDiet: Use KV store instead of cookies for campaign categories using legacy [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251462 (https://phabricator.wikimedia.org/T117650) [11:01:39] (CR) Siebrand: [C: 1] "i18n/L10n reviewed." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251462 (https://phabricator.wikimedia.org/T117650) (owner: AndyRussG) [17:14:34] (PS1) Cdentinger: ran composer update [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/251529 [17:27:10] (CR) Ejegg: [C: 2] ran composer update [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/251529 (owner: Cdentinger) [17:34:39] (CR) Ejegg: [C: 2] CRM-17466 - Refine error message [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/251276 (owner: Eileen) [17:35:38] ty ejegg ! crm is next... [17:38:25] (CR) Ejegg: [C: 2] "Yep, seems like good sense to only advertise your vulnerabilities to actual users" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/251277 (owner: Eileen) [17:40:31] (CR) Ejegg: [C: 2] "Roll out the caution tape!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/251318 (owner: Eileen) [17:44:32] http://i.imgur.com/iLQ5k4i.gifv [17:46:16] Fundraising Tech Backlog, Continuous-Integration-Infrastructure, Browser-Tests: Create unit and integration tests for Fundraising extensions to identify breaking MediaWiki changes - https://phabricator.wikimedia.org/T89404#1788909 (zeljkofilipin) [17:55:13] (CR) Ejegg: [C: 2] "Looks good to me. Shows filters on print, PDF, and normal viewing results, but doesn't mess up CSV exports" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/251434 (owner: Eileen) [17:56:11] aww, poor drunk Chappie [18:02:48] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Sprint William Shatner, Fundraising Tech Backlog, and 4 others: Verify kafkatee use for fundraising logs on erbium - https://phabricator.wikimedia.org/T97676#1788998 (Jgreen) >>! In T97676#1785592, @Pcoombe wrote: > @awight Sou... [18:03:41] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Sprint William Shatner, Fundraising Tech Backlog, and 4 others: Verify kafkatee use for fundraising logs on erbium - https://phabricator.wikimedia.org/T97676#1789013 (Jgreen) [18:09:16] (PS2) AndyRussG: impressionDiet: Use KV store instead of cookies for campaign categories using legacy [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251462 (https://phabricator.wikimedia.org/T117650) [18:10:00] ejegg: cwd: XenoRyet: ^ if anyone has a hankering for CentralNotice codereview... :) [18:10:14] I know I can't get enuf of it myself :) [18:10:27] 'morning, BTW [18:10:36] heh [18:10:54] sure thing, i'll check it out in a little bit [18:11:07] ejegg: thanks a ton! [18:11:08] and good 'morning' to you too! [18:11:11] thanks! [18:12:14] Heh turned out to be significantly more complicated than I expected... Hopefully most of the edge case handling and expected operatoin is understandable [18:12:55] Fortunately no tests are failing... [18:13:05] that's the great thing about having no tests for a feature ;p [18:15:44] hehe [18:27:27] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Spot-check that all core and custom data is preserved during the migration - https://phabricator.wikimedia.org/T115427#1789205 (Eileenmcnaughton) Ope... [18:27:28] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Sprint William Shatner, Fundraising Tech Backlog, and 3 others: [epic] Install 4.6 to staging and test like hell - https://phabricator.wikimedia.org/T99842#1789208 (Eileenmcnaughton) [18:35:43] (CR) Ejegg: [C: 2] "Good catch!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/251448 (owner: Eileen) [18:45:30] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: All Civi hook code paths must be covered by PHPUnit tests - https://phabricator.wikimedia.org/T115426#1789341 (Eileenmcnaughton) [18:46:03] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: All Civi hook code paths must be covered by PHPUnit tests - https://phabricator.wikimedia.org/T115426#1723980 (Eileenmcnaughton) We are going to look at merge separately... [18:54:15] Fundraising Sprint William Shatner, Wikimedia-Fundraising-CiviCRM: Slow query on deduping 2 contacts - https://phabricator.wikimedia.org/T116886#1789399 (Eileenmcnaughton) p:Triage>High a:Eileenmcnaughton [18:55:03] Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising Sprint UB40, and 6 others: Triage what to do with civi-core patches: extensions, upstream, or abandon - https://phabricator.wikimedia.org/T99836#1789406 (Eileenmcnaughton) Open>R... [18:55:05] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Patch-For-Review: [epic] Upgrade Civi to 4.6 & integrate new reporting - https://phabricator.wikimedia.org/T77910#1789408 (Eileenmcnaughton) [18:56:21] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Patch-For-Review: [epic] Upgrade Civi to 4.6 & integrate new reporting - https://phabricator.wikimedia.org/T77910#831558 (Eileenmcnaughton) [18:56:22] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Patch-For-Review: [epic] Port our CiviCRM customizations to 4.6 upstream, and to extensions - https://phabricator.wikimedia.org/T99838#1300113 (Eileenmcnaughton) [18:56:24] Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising Sprint UB40, Fundraising Sprint Vengaboys, and 5 others: Prepare CiviCRM 4.6 upstream and Giant Rabbit branches - https://phabricator.wikimedia.org/T99837#1789414 (Eileenmcnaughton) Open>Resolved [18:59:39] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Sprint William Shatner, Fundraising Tech Backlog, and 3 others: [epic] Install 4.6 to staging and test like hell - https://phabricator.wikimedia.org/T99842#1789434 (Eileenmcnaughton) [18:59:41] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Patch-For-Review: [epic] Upgrade Civi to 4.6 & integrate new reporting - https://phabricator.wikimedia.org/T77910#1789435 (Eileenmcnaughton) [19:00:36] Fundraising Sprint William Shatner, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: [epic] Upgrade Civi to 4.6 & integrate new reporting - https://phabricator.wikimedia.org/T77910#1789458 (Eileenmcnaughton) Open>Resolved [19:00:37] Fundraising-Backlog, Recurring-Donations: Recurring Payments Reporting - https://phabricator.wikimedia.org/T90630#1789461 (Eileenmcnaughton) [19:01:56] Fundraising Sprint William Shatner, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: [epic] Upgrade Civi to 4.6 & integrate new reporting - https://phabricator.wikimedia.org/T77910#1789468 (Eileenmcnaughton) [19:05:39] (CR) Ejegg: [C: -1] "You can remove the mw.cookie dependency from Large Banner Limit module for now, also a trivial comment about test cookie value" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251419 (https://phabricator.wikimedia.org/T117650) (owner: AndyRussG) [19:10:02] (CR) Ejegg: "Trivial suggestion about display variable name" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251284 (https://phabricator.wikimedia.org/T117650) (owner: AndyRussG) [19:20:37] (PS2) AndyRussG: Campaign categories using legacy: global config var and data property [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251284 (https://phabricator.wikimedia.org/T117650) [19:20:48] (CR) AndyRussG: Campaign categories using legacy: global config var and data property (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251284 (https://phabricator.wikimedia.org/T117650) (owner: AndyRussG) [19:21:45] (PS2) AndyRussG: Make cookiesEnabled() a public mw.centralNotice function [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251419 (https://phabricator.wikimedia.org/T117650) [19:26:31] (PS3) AndyRussG: Make cookiesEnabled() a public mw.centralNotice function [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251419 (https://phabricator.wikimedia.org/T117650) [19:29:20] (CR) AndyRussG: "> You can remove the mw.cookie dependency from Large Banner Limit module for now" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251419 (https://phabricator.wikimedia.org/T117650) (owner: AndyRussG) [19:34:42] (PS3) AndyRussG: impressionDiet: Use KV store instead of cookies for campaign categories using legacy [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251462 (https://phabricator.wikimedia.org/T117650) [19:35:46] (CR) AndyRussG: "Rebased and updated data property name." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251462 (https://phabricator.wikimedia.org/T117650) (owner: AndyRussG) [19:38:14] (CR) Ejegg: "Looking good! Couple suggestions inline." (4 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251462 (https://phabricator.wikimedia.org/T117650) (owner: AndyRussG) [19:39:51] (CR) Ejegg: [C: 2] "Very proper! No hardcoding even for temporary fixes." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251284 (https://phabricator.wikimedia.org/T117650) (owner: AndyRussG) [19:42:10] (CR) Ejegg: [C: 2] "Oops, you're right! In that case, this looks good." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251419 (https://phabricator.wikimedia.org/T117650) (owner: AndyRussG) [19:49:15] (CR) Ejegg: [C: 2] "Smurftastic!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/251279 (owner: Eileen) [19:50:05] ejegg: Smurfed that you think so [19:50:45] we /definitely/ hired the right Civi coder! [19:51:04] :-) [19:52:09] It's Kevin a minion… perhaps that is the clue [19:52:24] only work with orgs with someone named after a minion [19:57:29] (PS2) Ejegg: New message classes for fredge queues [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/251161 (owner: Awight) [19:58:08] (CR) Ejegg: [C: 2] "Great to have these formats defined in code!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/251161 (owner: Awight) [20:01:19] (PS5) Ejegg: Add test message fixtures for the fredge queue [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/249334 (https://phabricator.wikimedia.org/T114466) (owner: Awight) [20:01:25] (Merged) jenkins-bot: New message classes for fredge queues [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/251161 (owner: Awight) [20:02:24] (CR) Ejegg: [C: 2] "Thanks!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/249334 (https://phabricator.wikimedia.org/T114466) (owner: Awight) [20:03:38] some sort of lapel mics for people in SF would be awesome [20:03:55] the audio pretty much shits when 2 people talk at once [20:05:59] (Merged) jenkins-bot: Add test message fixtures for the fredge queue [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/249334 (https://phabricator.wikimedia.org/T114466) (owner: Awight) [20:09:49] (PS4) AndyRussG: impressionDiet: Use KV store instead of cookies for campaign categories using legacy [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251462 (https://phabricator.wikimedia.org/T117650) [20:11:59] (PS5) AndyRussG: impressionDiet: Use KV store instead of cookies for campaign categories using legacy [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251462 (https://phabricator.wikimedia.org/T117650) [20:12:44] (CR) AndyRussG: "Thanks!! :)" (3 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251462 (https://phabricator.wikimedia.org/T117650) (owner: AndyRussG) [20:40:06] cwd: they'd look even cooler with blueteeth [20:40:10] bluetooths? [20:40:17] bluetooth headsets [20:40:23] and robot eyes [20:40:34] hehe [20:40:37] blueteeth [20:40:41] * cwd approves [21:10:33] Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Follow-up to EntityTag changes; test thank-you with tags - https://phabricator.wikimedia.org/T117160#1789869 (DStrine) a:Eileenmcnaughton [21:16:32] (PS1) Cdentinger: ran composer update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/251572 [21:18:16] (CR) jenkins-bot: [V: -1] ran composer update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/251572 (owner: Cdentinger) [21:19:56] Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, Unplanned-Sprint-Work: Email Templates Not Populating - https://phabricator.wikimedia.org/T117255#1789904 (DStrine) a:awight [21:27:28] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi can't find an email address that is in the database - https://phabricator.wikimedia.org/T118036#1789923 (CaitVirtue) NEW [21:31:11] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: UI Sillyness: Can't see all the fields when adding a new email address to a contact record - https://phabricator.wikimedia.org/T118037#1789943 (CaitVirtue) NEW [21:31:25] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: UI Sillyness: Can't see all the fields when adding a new email address to a contact record - https://phabricator.wikimedia.org/T118037#1789953 (CaitVirtue) [21:33:59] https://www.youtube.com/watch?v=yPGehzAZ_nE [21:45:40] Jeff_Green: Wanna look at the kafkatee switchover? [21:47:24] awight let's formulate the plan to implement early next week? I'm about to take off for the day [21:47:32] ok! [21:47:53] so here's what's happening... [21:48:16] right now we have 2 nfs mounts on barium, one for the netapp (/archive/udplog) and the other to the new collector [21:49:32] the actual switchover should be just a matter of changing the incoming log dir from /archive/udplogs/2015 to /archive/banner_logs/2015 [21:50:12] and once we switch I'll do one last rsync from /archive/udplogs/2015/ to /archive/banner_logs/2015/ which will backfill the new collection location [21:50:53] Jeff_Green: we have to prepare files to make a splice point, IMO [21:51:00] at that point the kafkatee collector won't be dropping logs in that location yet [21:51:20] it's collecting to /archive/banner_logs/kafkatee/2015 at the moment [21:52:29] so we splice and move the appropriate logs from kafkatee, and then switch the kafkatee collector to /archive/banner_logs/2015/ [21:52:29] I'm just talking about the point you were making earlier, that we want to be careful not to overcount or undercount any interval [21:52:34] ok cool [21:52:54] one question--does the collector consider every log in the dir? [21:53:10] yeah :( [21:53:13] i mean, say we leave a gap for a bit, switch kafkatee, and then deal with the splicing and moving [21:53:19] and there are creepy DB rows to track which files have been read [21:53:26] good plan [21:53:56] does it matter if they get processed out of sequence, as long as they're only processed once? [21:54:26] that's fine [21:54:34] gap is definitely a good plan [21:54:38] cool then it's really easy [21:54:55] unfortunately, we do have to hide the old files [21:55:02] which old files? [21:55:19] anything new logs before our switchover [21:55:24] * awight Englishes [21:55:33] i was thinking we'd just dump 'em [21:55:44] sure [21:55:50] we don't need them, they've served their purpose to validate that collection works [21:57:11] is this kind of blip something we can just do i.e. on monday, without causing calamity in fundraising? [21:59:46] I think we have to send out some emails. [21:59:55] I'm happy to do that, if we're committing to Monday? [22:00:10] I believe the-wub wanted to take campaigns down, which is a good call. [22:00:59] ok. let's do monday then, just not in the ops-mtg window which is i think 9-10AM pacific [22:01:44] cool [22:12:45] are the crm tests broken? [22:18:35] they should be all green. What are you seeing? [22:20:23] awight: https://integration.wikimedia.org/ci/job/wikimedia-fundraising-crm-jslint/161/console [22:20:26] & https://integration.wikimedia.org/ci/job/wikimedia-fundraising-civicrm/1329/console [22:20:40] musta been the composer update i guess [22:20:43] Is that voting? [22:20:56] not the jslint [22:21:02] oh good :) [22:22:07] the other one must be from a DI update [22:23:05] ooh yeah that's bad [22:23:38] i'll track it down [22:24:17] tough when the test relies on externals [22:24:27] to catch something like that [22:24:50] oh man, I think I was the last one to touch MessageUtils [22:26:07] yep, let's see where that call's coming from [22:27:28] cwd: I think you heard this sob story already--we've kludged a single code path through DonationInterface, which allows us to make recurring GlobalCollect charges from Drupal, by relying on the WmfFramework facade rather than calling MediaWiki functions directly. [22:27:31] cwd ahh, right, I added a call to that in the DonationData setup [22:27:47] Yeah, I need to make another wrapper fn in WmfFramework [22:27:49] We have issues when those code paths accidentally call MW stuff [22:27:52] it's horrible. [22:28:00] Next year... [22:28:14] We'll carve all the processor API stuff out and put it in SmashPig. [22:28:14] aah yeah i remember that [22:28:26] Not like we're gaining anything at all by playing in the MediaWiki pigpen [22:28:35] and that's the only reason DI has to be in crm? [22:28:40] DI should eventually just be the forms [22:29:02] cwd: yeah for now--but we'd eventually like to do refunds from Civi and stuff. [22:29:12] Hopefully, SmashPig will be the entry point by that time. [22:29:42] yep [22:29:46] the future is bright! [22:29:57] the future is always so far away [22:30:25] except when a giant meteor is barreling towards earth [22:30:53] * awight crosses self [22:31:17] * cwd puts on sunglasses [22:34:49] (PS1) Ejegg: Add sanitize wrapper fn to WmfFramework [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/251650 [22:35:00] That might do it cwd ^^^ [22:35:21] here's the drupal page on sanitization fns: https://api.drupal.org/api/drupal/includes!common.inc/group/sanitization/7 [22:35:26] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi can't find an email address that is in the database - https://phabricator.wikimedia.org/T118036#1790102 (atgo) Definitely weird and broken. Is this something that used to work? I vaguely remember that maybe email search was a known issue. [22:36:01] cool, i'll check it [22:36:04] thanks! [22:36:18] heh, I broke it, I bought it [22:37:30] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi can't find an email address that is in the database - https://phabricator.wikimedia.org/T118036#1790105 (awight) I think the issue is that the quicksearch bar defaults to "Name" only, but the label says "Name / Email". This is caused by an obscure... [22:37:53] awight: the second silverpop export run with the new code went faster than the first - think it's scheduled for a time with barely any civi use. It's only 3-4 min slower than the old incorrect logic. [22:38:13] So i'm going to leave that join to wmf_contribution_extra [22:38:43] there's one more change I want to make: https://gerrit.wikimedia.org/r/251433 [22:39:55] (CR) Awight: Add sanitize wrapper fn to WmfFramework (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/251650 (owner: Ejegg) [22:40:23] great! [22:40:55] (CR) Ejegg: Add sanitize wrapper fn to WmfFramework (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/251650 (owner: Ejegg) [22:41:28] CCogdill is pretty eager to have that refund filter [22:42:19] (CR) Awight: [C: 2] "/me cringes at cross-repo constant. It's possible to join on civicrm_option_group x value x contribution_status, but... yeah let's not." [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/251433 (https://phabricator.wikimedia.org/T117931) (owner: Ejegg) [22:42:27] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi can't find an email address that is in the database - https://phabricator.wikimedia.org/T118036#1790115 (atgo) If that's the case, we should at least change the labels on these fields to reflect reality. [22:42:54] heh, my thoughts exactly. It is a 'pseudoconstant' after all [22:43:05] it's so awful [22:43:26] Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work, Patch-For-Review: Don't include refunded donations in Silverpop export - https://phabricator.wikimedia.org/T117931#1787196 (Ejegg) [22:43:33] on that note... atgomez agreed, but the tradeoff is that we get to maintain a bunch of crazy low-value patches that we can never upstream [22:44:14] (Merged) jenkins-bot: Exclude refunded donations in 'latest' calculation [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/251433 (https://phabricator.wikimedia.org/T117931) (owner: Ejegg) [22:44:22] what did i do? [22:44:37] hehe [22:44:43] atgomez: you said something sane [22:45:07] weird [22:45:34] (CR) Ejegg: impressionDiet: Use KV store instead of cookies for campaign categories using legacy (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251462 (https://phabricator.wikimedia.org/T117650) (owner: AndyRussG) [22:53:02] (PS6) Ejegg: impressionDiet: Use KV store instead of cookies for campaign categories using legacy [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251462 (https://phabricator.wikimedia.org/T117650) (owner: AndyRussG) [22:53:36] (CR) Ejegg: [C: 2] "Updated help text is much clearer!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251462 (https://phabricator.wikimedia.org/T117650) (owner: AndyRussG) [22:55:05] (Merged) jenkins-bot: impressionDiet: Use KV store instead of cookies for campaign categories using legacy [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251462 (https://phabricator.wikimedia.org/T117650) (owner: AndyRussG) [22:58:29] ejegg: do you have the tests working for crm locally? i can't remember the last time i did [22:59:11] cwd let me check [22:59:37] i get Class 'BaseChecksFileTest' not found in /srv/crm/sites/all/modules/offline2civicrm/tests/ChecksFileTest.php on line 7 [22:59:58] sounds like some bootstrap not initializing [23:00:33] yeah...i've never really understood the composer autoloader [23:00:52] if that's even involved [23:00:55] no, i think this is a testing - specific thing [23:01:12] phpunit.xml lists sites/default/bootstrap-phpunit.php as a thing to bootstrap before testing [23:01:21] are you just running phpunit in the root crm dir? [23:01:30] any args? [23:01:40] yep, and nope [23:01:45] grr [23:02:08] seems weird to find checkfile but not the base class [23:02:30] hmm, right, even the bootstrap file doesn't mention that guy [23:03:14] it should be loaded as part of the offline2civicrm module though [23:03:23] let's see if it's deleted in the deploy branch [23:04:16] OK, maybe you need to drush cc all (or even disable/re-enable offline2civicrm ) while you're on master [23:05:15] kindof a pain, let's just require_once in the bootstrap [23:06:02] ejegg: check the submodule out to master? [23:06:06] the civi one? [23:07:37] nope, no need to do anything with civi [23:07:48] just the main repo has tests deleted in deployment [23:08:17] so if you last refreshed drupal's file/class cache with deployment checked out, it wouldn't include that file [23:08:43] wait [23:08:56] drupal is a submodule here...but is also in the civi submodule [23:09:00] my brain just broke [23:10:16] civicrm/drupal/ is glue, it's the Drupal module code that tells Drupal about CiviCRM. of course ;) [23:10:18] (PS1) Ejegg: Explicitly load BaseChecksFileTest in test bootstrap [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/251654 [23:10:30] heh, symlinks! [23:10:43] oh, right, that drupal folder... [23:10:55] who is the real hero here? [23:10:58] ejegg: What's that about ^? [23:11:15] I don't see how the deployment branch gets involved [23:11:17] cwd ^^^ that patch should make tests work without having to convince drupal to load that file [23:11:25] awight: say you check out deployment then cc all [23:11:40] it reads the info file with no tests/include/basewhatever [23:11:46] sure [23:11:48] then you check out master and run phpunit [23:11:56] and it crashes cause it can't find that [23:12:00] there are lots of ways to hose yr "registry", but I don't think we should code around that [23:12:11] hehe--what is this, *helpful*? [23:12:33] which drupal should i be running cc all in? [23:12:41] cwd: crm/drupal [23:12:50] that's like very unfortunate [23:12:52] sorry. [23:12:58] what is the difference between those two? [23:13:12] hehe it spit out a bunch of html [23:13:39] I'd still argue this is worthwhile. We're loading the other base test file in bootstrap-phpunit [23:13:57] in fact, we should take the base test file out of .info [23:14:06] That's true, why are we doing that? [23:14:20] amending... [23:15:19] (PS2) Ejegg: Explicitly load BaseChecksFileTest in test bootstrap [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/251654 [23:15:54] cwd cc all spitting out html is an unfun place to be :( [23:16:00]
DB Error: no such field
[23:16:04] ??? [23:16:07] heh [23:16:09] can you updatedb? [23:16:16] good idea [23:17:04] hrm, bunch of other errors [23:17:11] (CR) Ejegg: "Looks like this is the IE team's suggested workaround. With that try/catch, you could even get rid of the typeof check" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/250896 (https://phabricator.wikimedia.org/T113013) (owner: AndyRussG) [23:17:11] why do we have 2 drupals again? [23:17:12] ejegg: I see now--yeah we shouldn't list test files in .info unless we're willing to edit those out of the deployment branch [23:17:28] cwd: crm/drupal is the only one that matters [23:17:40] cwd: the top level one is the real drupal CMS [23:17:46] crm/civicrm/drupal is CiviCRM glue which contains the drupal module stuff for Civi [23:18:14] as opposed to running Civi on wordpress ( yep ) [23:18:44] welp [23:18:45] i'm confused [23:19:07] oh man, is your db still at 4.2? [23:19:23] http://localhost/civi/civicrm/upgrade [23:19:27] ha, yeah i'm sure it is [23:19:38] heh, that would explain things! [23:20:06] That url or your local equivalent should fix you up [23:21:02] (CR) Awight: "Missing the .info patch?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/251654 (owner: Ejegg) [23:21:02] it's been awhile since i've touched this [23:21:07] it's in rough shape [23:21:13] oops, thanks awight ! [23:21:39] (PS3) Ejegg: Explicitly load BaseChecksFileTest in test bootstrap [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/251654 [23:21:53] (PS4) Awight: Explicitly load BaseChecksFileTest in test bootstrap [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/251654 (owner: Ejegg) [23:22:04] (CR) Awight: [C: 2] "Thanks!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/251654 (owner: Ejegg) [23:22:05] cwd: yeah, I had to do some data repairs before it let me upgrade [23:22:45] (fresh install should work as well) [23:22:50] yep! [23:23:32] (PS3) Ejegg: Move failed jobs to damage queue [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/251314 (https://phabricator.wikimedia.org/T117447) [23:23:54] renamed variable and option to 'damaged' ^^ [23:24:08] heh, guess I could amend the commit msg too [23:24:24] (PS4) Ejegg: Move failed jobs to damaged message queue [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/251314 (https://phabricator.wikimedia.org/T117447) [23:24:37] (CR) Awight: [C: 2] "That should do it!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/251314 (https://phabricator.wikimedia.org/T117447) (owner: Ejegg) [23:24:39] (Merged) jenkins-bot: Explicitly load BaseChecksFileTest in test bootstrap [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/251654 (owner: Ejegg) [23:24:47] thanks! [23:25:05] (Merged) jenkins-bot: Move failed jobs to damaged message queue [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/251314 (https://phabricator.wikimedia.org/T117447) (owner: Ejegg) [23:26:11] Not gonna deploy just now, so I'll leave failmail pointed to myself over the weekend. Adyen is still sending us notifications of production reports, but we can't download them, so each notification has led to a failspam loop. [23:26:44] looks like a harmless deployment if you wish [23:27:00] let's see... [23:27:10] Fundraising Dash: X x Y widget doesn't seem to work - https://phabricator.wikimedia.org/T118046#1790225 (atgo) NEW [23:28:26] Fundraising Dash, Fundraising-Backlog: [epic] make Dash useful for December fundraising campaign - https://phabricator.wikimedia.org/T118048#1790239 (atgo) NEW [23:28:27] hmm, just that queue change and a couple of minor point release updates from Symphony [23:28:34] Fundraising Dash, Fundraising-Backlog: [epic] make Dash useful for December fundraising campaign - https://phabricator.wikimedia.org/T118048#1790246 (atgo) [23:28:36] Fundraising Dash: X x Y widget doesn't seem to work - https://phabricator.wikimedia.org/T118046#1790247 (atgo) [23:28:41] (CR) AndyRussG: "Hmmm...! I imagine we probably could get rid of the typeof check, but is there any harm in leaving it just in case...?" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/250896 (https://phabricator.wikimedia.org/T113013) (owner: AndyRussG) [23:28:50] Well, here goes! [23:28:54] :p [23:29:23] Fundraising Dash, Fundraising-Backlog: Update Big English widget to 2015 or make new one (to keep old version easy to reference) - https://phabricator.wikimedia.org/T118050#1790255 (atgo) NEW [23:29:53] (CR) Ejegg: "Oh, just a teensy bit less code - with the catch, is there any harm taking it ou?" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/250896 (https://phabricator.wikimedia.org/T113013) (owner: AndyRussG) [23:29:54] Fundraising Dash, Fundraising-Backlog: What is usefulness of Donations/Second? - https://phabricator.wikimedia.org/T118051#1790264 (atgo) NEW [23:31:56] cwd: oops, forgot to mention a SmashPig quirk. No deploy branch :( so we check vendor submodule updates into master [23:32:10] Fundraising Dash, Fundraising-Backlog: Add country & date filters to Fraud widget on Dash - https://phabricator.wikimedia.org/T89526#1790278 (atgo) [23:32:12] Fundraising Dash, Fundraising-Backlog: Rate Comparison Test - https://phabricator.wikimedia.org/T93117#1790277 (atgo) [23:32:14] Fundraising Dash, Fundraising-Backlog: [epic] make Dash useful for December fundraising campaign - https://phabricator.wikimedia.org/T118048#1790276 (atgo) [23:34:08] Fundraising Dash, Fundraising-Backlog: New Dash widget request: Rejections widget - https://phabricator.wikimedia.org/T89528#1790282 (atgo) [23:34:09] Fundraising Dash: Add date picker to Totals Earned widget - https://phabricator.wikimedia.org/T94110#1790281 (atgo) [23:34:11] Fundraising Dash, Fundraising Sprint Grandmaster Flash: Make additional filters for X-by-Y chart - https://phabricator.wikimedia.org/T86840#1790283 (atgo) [23:34:13] Fundraising Dash, Fundraising-Backlog: [epic] make Dash useful for December fundraising campaign - https://phabricator.wikimedia.org/T118048#1790239 (atgo) [23:34:39] hey cwd or ejegg - could we spend some time before shrimp next week to look at some Dash stuff? [23:34:51] sure! [23:34:55] just to get a ballpark on how things are working/how difficult it would be to even loosely get this up again [23:35:00] seems like most things kind of work [23:35:27] heh, yep [23:35:37] and there are some other features on the verge of working [23:35:39] atgomez: high five for yr triage spree! [23:36:02] yay! [23:36:21] if anyone else wants to join, let me know. i just added ejegg and cwd because they've been in that code before [23:37:42] hey awight - i'm assuming that everyone besides eileen has CN admin? [23:37:44] from fr-tech [23:37:58] They should. not sure where those requests landed, though. [23:38:07] ok. is there a way to confirm? [23:38:21] atgomez: for bookmarkng: https://meta.wikimedia.org/w/index.php?title=Special:ListUsers&group=centralnoticeadmin [23:38:21] (PS1) Ejegg: Follow composer.lock [wikimedia/fundraising/SmashPig/vendor] - https://gerrit.wikimedia.org/r/251659 [23:38:33] Yep, we're all in there. [23:38:38] yep that sounds like fun [23:38:44] cool! [23:38:46] thanks [23:40:19] ejegg: you want a +2 on that? or is that a valid self merge? [23:40:47] that's fine for self-merging [23:40:51] cos: no code [23:40:58] word [23:42:30] heh, was still looking at the changes to the symfony bits we use. mostly doc stuff [23:44:45] (CR) Ejegg: [C: 2 V: 2] Follow composer.lock [wikimedia/fundraising/SmashPig/vendor] - https://gerrit.wikimedia.org/r/251659 (owner: Ejegg) [23:45:15] (PS1) Ejegg: Follow composer.lock [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/251661 [23:45:39] (CR) Ejegg: [C: 2 V: 2] Follow composer.lock [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/251661 (owner: Ejegg) [23:48:05] !log updated SmashPig listener from afefccff0f8d5e0b37044adff964c6cd913e1d80 to ac9772765287e79178e07ddfcc7e532d2f82b6d0 and set failmail target back to fr-tech [23:48:10] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [23:48:27] ejegg: Hi! Just about the Object.defineProperty test... You're really sure that a try/catch block will never do something unexpected? I guess that makes sense... No such thing as an uncatchable error in JS [23:49:41] yeah, just feeling like we should do our part for the war^H^H^H minification effort [23:50:48] * awight snips edges off of ration cards [23:51:00] Ah K [23:51:02] So I should take out the JSON BSD logos? [23:51:07] hehe [23:51:24] No that's cultural heritage [23:51:39] :) 8-bit color FTW, then! [23:52:12] (PS2) AndyRussG: Stronger check for Object.defineProperty, to handle IE8 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/250896 (https://phabricator.wikimedia.org/T113013) [23:53:22] awight: digitized for archival records via a 16-megapixel photo of an old monitor [23:53:24] (PS3) Ejegg: Stronger check for Object.defineProperty, to handle IE8 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/250896 (https://phabricator.wikimedia.org/T113013) (owner: AndyRussG) [23:53:34] ;) seriously [23:53:54] (CR) Awight: "Mostly inconsequential comments... This looks great!" (7 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251462 (https://phabricator.wikimedia.org/T117650) (owner: AndyRussG) [23:54:14] hehe oops, I took way too long reviewing [23:54:43] there's always room for a follow-on patch! [23:55:21] AndyRussG: well, the only criticism I'll highlight is that the category language in the help text might need a little tweaking. [23:55:42] awight: that was updated some in PS6 [23:55:44] K I'll on-follow [23:55:46] I doubt anyone has any clue what Category={{{campaign}}} means--in the banner editor nonetheless [23:55:49] hehe ok then [23:56:10] awight: though it's surely still be imperfectuous [23:56:34] ah, yeah PS6 has the same flaw [23:56:47] I'm thinking--since nobody uses categories, they won't know wtf we're talking about [23:56:57] I just got 2 smashpig emails. Anything to be worried about? [23:57:05] oh, lemme see [23:57:09] dstrine: nah, it's Adyen [23:57:22] oh, that's annoying [23:57:25] derp, gotta create that queue [23:57:37] I guess I like the explicitness [23:57:39] yeah, I thought that happened automatically [23:57:46] it does on the queue server [23:57:49] so this must be config [23:58:12] gotta run, ttyl! [23:58:15] see ya [23:58:34] created... [23:58:59] * awight hrms loudly [23:59:02] it won't have acked the originals there, so it'll move 'em over next time [23:59:34] errr [23:59:41] did it ack the original? [23:59:59] ejegg: we're talking about config_default.php, right?