[00:00:11] I think that's where jobs-damaged needs to be defined [00:00:13] ah, phooey, that's right [00:00:24] fixing... [00:00:53] but I thought I was trying to enqueue it there before acking it from job-requests [00:01:03] oops! [00:01:38] sure does look like the code should do that. [00:02:21] It's an exception and stuff... [00:02:25] (PS1) Ejegg: Add default config for jobs-damaged queue [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/251665 (https://phabricator.wikimedia.org/T117447) [00:02:35] crap, maybe it's implicitly acking [00:02:41] aw jeez [00:02:52] (CR) Awight: [C: 2] "/me gains a hit point" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/251665 (https://phabricator.wikimedia.org/T117447) (owner: Ejegg) [00:03:22] (Merged) jenkins-bot: Add default config for jobs-damaged queue [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/251665 (https://phabricator.wikimedia.org/T117447) (owner: Ejegg) [00:04:32] gtg! [00:04:47] heh. first confirm message 't4to', second 'dduh' [00:05:01] !log updated SmashPig from ac9772765287e79178e07ddfcc7e532d2f82b6d0 to 5860ef47790010d65981822f30914679df06ae14 [00:05:07] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [00:08:05] oh, right, I'm instantiating the damaged queue connection before processing anything [00:08:13] not really necessary... [00:08:48] but it means we didn't just drop something on the floor [00:15:11] (PS1) Ejegg: More default config for damaged job queue [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/251668 (https://phabricator.wikimedia.org/T117447) [00:16:39] (CR) Ejegg: [C: 2] "Thanks! None will escape our nags..." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/250896 (https://phabricator.wikimedia.org/T113013) (owner: AndyRussG) [00:18:15] ejegg: hehehe :) it's OK, I'll pass the nag forward... (jk!!! didn't take it as a nag) [00:18:34] (CR) Ejegg: [C: -1] "needs 5d0ed3c28da63fbdd7caeff3ca0a2053011a089e merged to DonationInterface first" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/251572 (owner: Cdentinger) [00:19:01] heh, I meant that IE8 users will be nagged for cash next month! [00:20:35] OK, smashpig looks like it's running adyen jobs again [00:20:52] signing off for now. see ya all later! [00:24:29] I'm also off for about 1 1/2 hours for a flash kid outing, back later! [00:30:16] Fundraising research, Research management, Research-and-Data: Big English data analysis support - https://phabricator.wikimedia.org/T118054#1790390 (DarTar) NEW a:DarTar [00:43:10] Fundraising research, Research management, Research-and-Data: Big English data analysis support - https://phabricator.wikimedia.org/T118054#1790416 (DarTar) Ran a proposal past @deskana, will check back on Monday. [01:23:47] (CR) Awight: [C: 2] More default config for damaged job queue [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/251668 (https://phabricator.wikimedia.org/T117447) (owner: Ejegg) [01:24:15] (Merged) jenkins-bot: More default config for damaged job queue [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/251668 (https://phabricator.wikimedia.org/T117447) (owner: Ejegg) [15:12:59] (PS1) AndyRussG: impressionDiet: fix and minor improvements in use KV store feature [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251708 (https://phabricator.wikimedia.org/T117650) [15:22:18] (PS2) AndyRussG: impressionDiet: fix and minor improvements in use KV store feature [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251708 (https://phabricator.wikimedia.org/T117650) [15:40:36] (PS1) AndyRussG: largeBannerLimit: Use KV store instead of cookies for campaign categories using legacy [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251711 (https://phabricator.wikimedia.org/T117650) [15:48:26] (PS1) AndyRussG: BannerHistoryLogger: preserve inactive log up to 365 days [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251712 [15:56:17] (PS1) AndyRussG: AdminUi: fix minor mixin control hide issue [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251713 [17:29:06] holy failmail, adyen! [17:29:47] !log point SmashPig failmail at ejegg|away and awight [17:29:53] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [17:35:47] !log fix SmashPig failmail syntax [17:35:52] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [17:36:30] awight, atgomez taking a look [17:38:20] !log more syntax fixing [17:38:23] ejegg|away: hey! [17:38:24] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [17:38:27] I think I just got it. [17:38:36] Surprising syntax on the To: parameter... [17:38:46] oh? [17:39:08] I think we have to list all the addresses as an array--commas and spaces not parsed [17:41:18] Fundraising Sprint William Shatner, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work, Easy, JavaScript: mw.centralNotice.recordImpression causes exception when centralNotice banners for WLM 2015 are loaded (with Adblock Plus browser extens... - https://phabricator.wikimedia.org/T110182#1791276 [17:41:51] ejegg|away: Hey, that worked. Now I'm removing my addy :p [17:42:05] ah, weird [17:42:20] ok, I've got a try-catch in the stomp job runner if you want to take a look [17:42:44] sure--not a priority to fix now that you're getting the emails though ;) [17:43:24] (PS1) Ejegg: Handle exceptions in stomp job runner [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/251726 [17:44:36] (CR) Awight: [C: 2] "Ah! Yeah that would be necessary." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/251726 (owner: Ejegg) [17:45:11] (Merged) jenkins-bot: Handle exceptions in stomp job runner [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/251726 (owner: Ejegg) [17:45:15] thanks! [17:45:26] ejegg|away: please send a quick note about whatever happens here--it's equally disconcerting when failmails suddenly go away! [17:46:19] will do! [17:47:26] (PS1) Ejegg: Slight Stomp job runner loop refactor [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/251728 [17:47:43] awight|renting: ejegg|away: boo! awight, thanks for raising the priority of the adblock bug! [17:48:06] BTW I booked a deploy slot for early Monday :) [17:48:13] AndyRussG: yeah, sorry I hadn't taken that seriously either [17:48:17] (on the hopes you agree... np if not :) ) [17:48:21] I think those are just people who don't email us [17:48:41] awight|renting: it's a really simple thing, we could probably merge and get it out really soon [17:49:54] totes [17:51:11] * awight|renting discourages writing that over the weekend though :p [17:53:18] (PS2) Ejegg: Slight Stomp job runner loop refactor [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/251728 [17:54:55] !log updated SmashPig from 5860ef47790010d65981822f30914679df06ae14 to 55c2dbc8cd36cfb89d7e17b75b840ca2e023653e [17:55:02] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [18:03:51] (PS3) Ejegg: Stomp job runner fix and loop refactor [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/251728 [18:21:24] bye! [18:21:52] (PS1) AndyRussG: Wrap sendBeacon in try/catch to prevent AdBlock issue [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251732 (https://phabricator.wikimedia.org/T110182)