[14:46:38] Hey folks. My mom got a fundraising email with a bunch of links to mkt4477.com. Is that legitimate? [14:46:46] Or phishing? [17:31:08] (PS1) Zfilipin: Added Rakefile [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/252011 (https://phabricator.wikimedia.org/T117993) [17:37:26] (CR) Zfilipin: "check experimental" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/252011 (https://phabricator.wikimedia.org/T117993) (owner: Zfilipin) [17:38:33] (PS2) Ejegg: Wrap sendBeacon in try/catch to prevent AdBlock issue [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251732 (https://phabricator.wikimedia.org/T110182) (owner: AndyRussG) [17:38:42] (CR) Ejegg: [C: 2] Wrap sendBeacon in try/catch to prevent AdBlock issue [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251732 (https://phabricator.wikimedia.org/T110182) (owner: AndyRussG) [17:38:47] ejegg: hi! thx! [17:43:19] (Merged) jenkins-bot: Wrap sendBeacon in try/catch to prevent AdBlock issue [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251732 (https://phabricator.wikimedia.org/T110182) (owner: AndyRussG) [17:55:05] (CR) Ejegg: "Code looks good so far, but the commit message seems to be stating the opposite of the change" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251711 (https://phabricator.wikimedia.org/T117650) (owner: AndyRussG) [17:56:41] this is glorious http://boingboing.net/2015/11/08/the-economists-anti-ad-block.html [17:57:36] (CR) Ejegg: "Want to flip order of closing tags too?" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251713 (owner: AndyRussG) [18:08:06] (CR) AndyRussG: "Hmmm sorry I don't follow? (/me jostles brain...)" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251713 (owner: AndyRussG) [18:08:20] Fundraising-Backlog: Fill out SAQ A 3.1 for Adyen - https://phabricator.wikimedia.org/T118200#1794201 (atgo) NEW [18:09:01] Fundraising-Backlog: Fill out SAQ A 3.1 for Adyen - https://phabricator.wikimedia.org/T118200#1794201 (atgo) [18:09:46] hey ejegg - should the adyen tasks in the "analysis" column of the backlog be blockers for getting Adyen back up? [18:10:04] oh, let me check [18:11:36] atgomez: 'fix CSS' should be, but the missing submethod isn't breaking anything [18:12:00] ok, it's up to you [18:12:08] but if they are blockers we should associate them with the parent task [18:12:21] ah, you mean the spike in this sprint? [18:12:26] there's… hang on [18:12:36] https://phabricator.wikimedia.org/T90748 [18:12:38] ejegg: ^ [18:12:47] thanks! [18:14:10] (PS2) Ejegg: AdminUi: fix minor mixin control hide issue [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251713 (owner: AndyRussG) [18:14:45] (CR) Ejegg: [C: 2] "Please disregard previous comment" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251713 (owner: AndyRussG) [18:16:22] (Merged) jenkins-bot: AdminUi: fix minor mixin control hide issue [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251713 (owner: AndyRussG) [18:16:31] (PS1) Eileen: CRM-17536 fix quicksearch label for when email search is disabled [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/252016 (https://phabricator.wikimedia.org/T118036) [18:17:26] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Adyen: Fix CSS on Adyen form - https://phabricator.wikimedia.org/T117897#1794226 (Ejegg) [18:17:29] Fundraising-Backlog, Epic: [epic] Get Adyen back up - https://phabricator.wikimedia.org/T90748#1794225 (Ejegg) [18:18:00] ejegg: and atgomez can/should we structure adyen with the usual milestone? internal test, 1 hour, campaign ready? [18:18:57] dstrine: I think we've done the internal test already [18:19:13] but the other two make sense [18:19:18] ejegg: yeah re your email "Successful end to end test with sandbox credentials" [18:19:51] I'll make those and attach them to this higher level epic. [18:20:51] Fundraising-Backlog, Epic: [epic] Adyen 1 hour test - https://phabricator.wikimedia.org/T118201#1794232 (DStrine) NEW [18:21:20] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Edits to LYBUNT report - https://phabricator.wikimedia.org/T88819#1794239 (atgo) p:Normal>High This is becoming critical for Major Gifts. [18:21:22] Fundraising-Backlog, Epic: [epic] Get Adyen back up - https://phabricator.wikimedia.org/T90748#1794241 (DStrine) [18:22:07] Fundraising-Backlog, Epic: [epic] Adyen campaign ready - https://phabricator.wikimedia.org/T118202#1794246 (DStrine) NEW [18:22:23] Fundraising-Backlog, Epic: [epic] Adyen campaign ready - https://phabricator.wikimedia.org/T118202#1794246 (DStrine) [18:22:52] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Edits to LYBUNT report - https://phabricator.wikimedia.org/T88819#1794255 (Eileenmcnaughton) Dylan - let me know if there is anything I can help with o... [18:23:07] ejegg: I just added these^^^ can you move your previous tasks under the corresponding milestone? [18:23:49] will do [18:23:59] thanks! [18:24:44] also, since you will be OOO in the next sprint, are you able to bring someone else up to speed? [18:30:02] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Edits to LYBUNT report - https://phabricator.wikimedia.org/T88819#1794282 (XenoRyet) @CaitVirtue I got sidetracked off this by the Trilogy import bug,... [19:05:49] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Edits to LYBUNT report - https://phabricator.wikimedia.org/T88819#1794358 (CaitVirtue) awesome, thank you [19:16:44] wondering about permissions in crm/sites/default/files [19:16:49] i feel like i've been here before [19:17:08] cwd needs to be writeable by the web user [19:17:30] d????????? ? ? ? ? ? civicrm [19:17:33] ಠ_ಠ [19:17:48] i did the 4.6 upgrade, not sure how that ended up effed [19:18:02] cwd: yeah, if you ever run drush as your normal user, you'll need to chgrp -R www-data ; chmod -R g+w [19:18:38] sites/default/* ? [19:18:45] sites/default/dfiles [19:19:05] I usually also find . -type d -exec chmod g+s {} \; [19:19:23] setting your umask to 002 prevents this from ever happening again, but that's a personal decision ;) [19:19:36] ah ha [19:20:55] i can't seem to change anything about those files [19:20:57] with the ?s [19:21:08] wat [19:21:19] this this in vagrant? [19:21:23] Sounds like NFS fail [19:21:26] no just my local install [19:21:35] oooh sounds like chromebook fail :p [19:21:35] yeah it looks like a windows fs or something [19:21:41] nah mang [19:21:42] on my server [19:21:51] it's jessie [19:22:05] you got problems. [19:22:12] try fsck [19:22:16] scary [19:22:21] yeah... [19:22:44] i'm going to go find a place to get lunch and hole up for the all hands [19:22:52] back in a few [19:22:59] http://serverfault.com/questions/65616/question-marks-showing-in-ls-of-directory-io-errors-too [19:23:29] oh heh no exec for dir [19:23:44] that's a funny failure mode [19:24:32] thanks awight! [19:24:58] creepshow! glad it got better [19:25:56] the-wub: Sorry again to put you in a tough place wrt WMDE [19:26:29] feel free to CC us if that might help the conversation [19:28:29] (PS2) Awight: Added Rakefile [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/252011 (https://phabricator.wikimedia.org/T117993) (owner: Zfilipin) [19:28:43] (CR) Awight: [C: 2] Added Rakefile [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/252011 (https://phabricator.wikimedia.org/T117993) (owner: Zfilipin) [19:29:17] (CR) Awight: [C: 2] BannerHistoryLogger: preserve inactive log up to 365 days [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251712 (owner: AndyRussG) [19:30:13] (Merged) jenkins-bot: Added Rakefile [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/252011 (https://phabricator.wikimedia.org/T117993) (owner: Zfilipin) [19:30:59] (Merged) jenkins-bot: BannerHistoryLogger: preserve inactive log up to 365 days [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251712 (owner: AndyRussG) [19:31:05] awight: thx! [19:31:22] ejegg: cwd|afk: XenoRyet: Hi! question about impressionDiet feature... [19:31:40] yes? [19:32:19] Current help text for the restartCycleDelay param. Current help text sez: [19:32:19] How long to wait before restarting the cycle, in seconds (optional) [19:32:19] Defaults to 0, which means readers will experience a single cycle, and then we stop displaying banners. [19:32:45] ...however, the 0 default actually makes it start repeating right away [19:33:07] ooh, yep [19:34:04] that would be broken! [19:34:16] hmmm I wasn't sure if I was just imagining it [19:34:25] I might have been stuck in a time loop [19:36:45] awight: ejegg: which should it be? Should it work as described in the doc, I guess? [19:37:00] Yeah, definitely. [19:37:04] K cool! [19:37:29] +1 [19:37:48] It would be even nicer if there were a checkbox for "one shot" vs "cycle" [19:37:53] It would be cool if mixins used the same time units too, but that's another kettle of fish [19:38:02] I hate magic numbers, where 0 has special meaning [19:38:13] Also gentle ping on this patch https://gerrit.wikimedia.org/r/#/c/251708/ [19:39:23] (CR) Awight: [C: 2] "I like it--good catches!" (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251708 (https://phabricator.wikimedia.org/T117650) (owner: AndyRussG) [19:39:26] Just playing with it now! Had to wrangle my mediawiki installs up to date on the company laptop [19:42:16] ejegg: awight: cool! WRT checkbox, hmm that's ideal... WRT time units, maybe except when we're talking about very different things, such as milliseconds vs days for timeouts [19:46:23] (Merged) jenkins-bot: impressionDiet: fix and minor improvements in use KV store feature [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251708 (https://phabricator.wikimedia.org/T117650) (owner: AndyRussG) [20:01:21] (CR) Ejegg: [C: -1] "Looks good, just one problem with mw.cookie.get call" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251711 (https://phabricator.wikimedia.org/T117650) (owner: AndyRussG) [20:50:47] just saw K4-713 get in line [20:50:54] go K4 [20:56:52] (PS3) AndyRussG: largeBannerLimit: Use KV store instead of cookies for campaign categories not using legacy [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251711 (https://phabricator.wikimedia.org/T117650) [21:08:05] (PS1) Ejegg: Add IDs to more inputs, remove duplicate [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/252109 (https://phabricator.wikimedia.org/T117827) [21:08:07] (PS1) Ejegg: Make Amazon use standard handleDonationRequest [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/252110 (https://phabricator.wikimedia.org/T117827) [21:08:09] (PS1) Ejegg: Amazon: check CSRF token, preserve data after expiry [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/252111 (https://phabricator.wikimedia.org/T117827) [21:09:30] (CR) jenkins-bot: [V: -1] Make Amazon use standard handleDonationRequest [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/252110 (https://phabricator.wikimedia.org/T117827) (owner: Ejegg) [21:09:58] (CR) jenkins-bot: [V: -1] Amazon: check CSRF token, preserve data after expiry [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/252111 (https://phabricator.wikimedia.org/T117827) (owner: Ejegg) [21:16:25] (PS2) Ejegg: Make Amazon use standard handleDonationRequest [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/252110 (https://phabricator.wikimedia.org/T117827) [21:17:55] (PS2) Ejegg: Amazon: check CSRF token, preserve data after expiry [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/252111 (https://phabricator.wikimedia.org/T117827) [21:22:12] My stream glitched, I didn't hear the last part of what K4 said. [21:22:16] Anybody catch it? [21:24:36] I went full Admiral Ackbar. [21:24:55] IT'S A TRAP [21:25:09] Well... okay. Not full Ackbar. [21:29:14] Thanks to awight|afk K4-713 and atgomez for standing up and making good points!!! [21:30:36] +1 to that, but friendly reminder that this is the public channel :) [21:39:07] (PS1) AndyRussG: impressionDiet: correct help message for restartCycleDelay [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/252115 [21:46:59] (Abandoned) AndyRussG: impressionDiet: correct help message for restartCycleDelay [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/252115 (owner: AndyRussG) [21:55:50] hi [21:56:01] anybody from technical part of fundraising? [21:56:18] hi Base! what's up? [21:56:22] I have a question concerning https://payments.wikimedia.org/index.php?title=Special:GlobalCollectGateway i18n [21:56:23] i'm the product manager for fr-tech [21:56:49] what's your question? [21:57:02] where do I localize the piece which appears when I am to put my credit/debit card details [21:57:19] these messages aren't in https://translatewiki.net/w/i.php?title=Special%3ATranslate&taction=translate&group=ext-di-gc&language=uk&limit=100&task=view [21:57:45] that part is showing in Russian for Ukrainian interface and thus users get upset [21:57:48] base do you mean the parts that appaear below the credit card buttons? [21:58:51] lemmi make a screenshot so it's clear [21:59:24] thanks base! [21:59:25] atgomez Base: sounds like https://phabricator.wikimedia.org/T109064 [21:59:48] thanks the-wub [22:00:23] unfortunately we don't have control over that part of the form - it's an iframe hosted by our credit card processor. but we're working on getting some new stuff such that we can own the messages there. it's taking a lot of time because we have to jump through a bunch of hoops for compliance reasons [22:00:41] thank you so much for trying to update the translations though! [22:00:56] I hadn't realised we were running (at a low-level) in Ukrainian. I'll check with megan and jessica if we should pull until that's fixed [22:03:11] this http://imgur.com/boqaY3F [22:03:22] yeah it looks like the task [22:03:26] thanks Base [22:03:34] yes, thanks Base! [22:03:36] yeah unfortuantely it's a known issue… we are workign on it thought! [22:03:46] here's the discussion on https://uk.wikipedia.org/wiki/Вікіпедія:Кнайпа_%28різне%29#.D0.A2.D0.B5.D0.BF.D0.B5.D1.80_.D0.BC.D0.BE.D0.B2.D0.BE.D1.8E_.D0.BE.D0.BA.D1.83.D0.BF.D0.B0.D0.BD.D1.82.D0.B0_.D0.BF.D1.80.D0.BE.D1.85.D0.B0.D0.BD.D0.BD.D1.8F_.D0.BF.D1.80.D0.BE_.D0.BF.D0.BE.D0.B6.D0.B5.D1.80.D1.82.D0.B2.D1.83 ukwiki [22:03:55] let me clean up phab a bit to show the blockers tfor that [22:03:57] perhaps you can write there a note [22:04:22] i will do that, thanks base. but id on't speak either Russian or Ukrainian :/ [22:04:29] can you help me translate? [22:04:38] the user who reported it speaks English [22:04:44] but I can help with translation [22:04:50] great! i'll respond today. [22:04:55] Wikimedia-Fundraising: Untranslated GlobalCollect iframes - https://phabricator.wikimedia.org/T109064#1794655 (atgo) Note that this is being discussed on the Ukrainian wiki: https://uk.wikipedia.org/wiki/Вікіпедія:Кнайпа_(різне)#.D0.A2.D0.B5.D0.BF.D0.B5.D1.80_.D0.BC.D0.BE.D0.B2.D0.BE.D1.8E_.D0.BE.D0.BA.D1.83... [22:05:39] Wikimedia-Fundraising: Untranslated GlobalCollect iframes - https://phabricator.wikimedia.org/T109064#1794656 (atgo) [22:07:53] (PS1) AndyRussG: impressionDiet: don't restart cycle when restartCycleDelay is 0 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/252118 [22:09:41] Wikimedia-Fundraising: Untranslated GlobalCollect iframes - https://phabricator.wikimedia.org/T109064#1794664 (atgo) [22:09:56] Wikimedia-Fundraising: Untranslated Credit Card fields (GlobalCollect iframes) - https://phabricator.wikimedia.org/T109064#1794666 (atgo) [22:10:54] thanks again base. i responded [22:10:58] have to jump offline now! [22:21:25] thanks for responding, hope that it'll soothe people a little bit. many in the community are having old grudge on wmf for not wanting to disable russian fallback for ukrainian [22:22:57] yeah… sorry. we're working on it i swear! [22:23:37] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Adyen: Update Adyen adapter to use SHA-265 signature - https://phabricator.wikimedia.org/T116679#1794685 (Ejegg) [22:24:48] Fundraising-Backlog, Epic: [epic] Adyen 1 hour test - https://phabricator.wikimedia.org/T118201#1794691 (Ejegg) [22:24:50] Fundraising-Backlog: Fill out SAQ A 3.1 for Adyen - https://phabricator.wikimedia.org/T118200#1794692 (Ejegg) [22:25:22] yeah thanks for bringing it up Base, and for helping with the response. I've disabled banners in ukrainian for now. [22:25:50] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Adyen: Fix CSS on Adyen form - https://phabricator.wikimedia.org/T117897#1794695 (Ejegg) [22:25:52] Fundraising-Backlog, FR-Adyen: Adyen donation messages missing payment submethod - https://phabricator.wikimedia.org/T117820#1794696 (Ejegg) [22:25:54] Fundraising-Backlog, FR-Adyen: Adyen payments listener destroys donation info if capture fails - https://phabricator.wikimedia.org/T117816#1794697 (Ejegg) [22:25:56] Fundraising-Backlog, Epic: [epic] Adyen campaign ready - https://phabricator.wikimedia.org/T118202#1794694 (Ejegg) [22:26:27] the-wub, np, thank you [22:27:13] Fundraising-Backlog, FR-Adyen: Adyen payments listener destroys donation info if capture fails - https://phabricator.wikimedia.org/T117816#1784231 (Ejegg) [22:37:28] (PS4) Ejegg: largeBannerLimit: Use KV store instead of cookies for campaign categories not using legacy [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251711 (https://phabricator.wikimedia.org/T117650) (owner: AndyRussG) [22:37:39] (CR) Ejegg: [C: 2] largeBannerLimit: Use KV store instead of cookies for campaign categories not using legacy [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251711 (https://phabricator.wikimedia.org/T117650) (owner: AndyRussG) [22:42:13] (Merged) jenkins-bot: largeBannerLimit: Use KV store instead of cookies for campaign categories not using legacy [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/251711 (https://phabricator.wikimedia.org/T117650) (owner: AndyRussG) [22:48:00] ejegg: i'm back if you got time for a chat? [22:48:08] sure! [23:01:19] Fundraising Sprint William Shatner: Really slow when you search for Eileen's mum from quicksearch email + enter - https://phabricator.wikimedia.org/T118215#1794765 (Eileenmcnaughton) NEW a:Eileenmcnaughton [23:14:57] Fundraising Tech Backlog: Donation over $1000 throws error on comma in amount field (editing or creating) - https://phabricator.wikimedia.org/T118216#1794813 (Krenair) Assuming fundraising tech [23:17:36] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Donation over $1000 throws error on comma in amount field (editing or creating) - https://phabricator.wikimedia.org/T118216#1794815 (atgo) [23:27:26] hey ejegg, finally got civi upgraded but now when i run the tests first thing i see is: [23:27:48] Call to undefined method LargeDonationTest::setDisallowChangesToGlobalState() [23:28:01] huh, let's see what that's about [23:28:18] in /srv/crm/vendor/phpunit/phpunit/src/Framework/TestSuite.php on line 741 [23:28:52] oh weird, so that should be a method on tests [23:29:01] huh yeah... [23:29:02] ah, I bet it's a phpunit incompatibility [23:29:21] version in vendor? [23:29:33] maybe running system phpunit with vendor dir sources? [23:29:55] I generally do --no-dev, even for my dev box [23:30:12] to avoid stuff like that. I just run the system phpunit [23:30:12] i'll try that [23:30:19] yeah, me too [23:33:37] MBeat: hi [23:33:48] hi [23:34:22] I'm in SF this week - I've managed to catch up with Leanne & the Caitlins [23:34:35] But they suggested I maybe do a hangout with you too [23:34:45] sure thing! [23:35:01] to try to understand how you use Civi & what would be helpful [23:35:17] is it my Birthday? [23:35:30] :) let me know when works for you [23:35:31] I don't know - is that recorded in Civi….? [23:35:48] ejegg: the phpunit in vendor fares slightly better, the tests run but fail. how is that configured? i don't see suite.xml or anything [23:35:49] touche [23:35:52] so, maybe tomorrow? I have to figure out how the room booking works [23:36:15] but potentially something like 11am here 2pm there? [23:36:23] cwd huh, i thought there was a phpunit.xml right in the root dir [23:36:46] master branch? [23:36:49] oh, sorry yeah in crm [23:37:00] but wouldn't system phpunit run that the same? [23:37:01] oh yeah, just run from the root crm dir [23:37:14] sure eileen; 11 am-noon PST I’m booked but anything else is fine [23:37:22] yeah, I just type "phpunit" in crm/ and it's off to the races [23:37:40] ejegg: interesting, i wonder why i'd be getting diff behavior between the two [23:37:52] if it's versions of the phpunit binary i'm going to be sad [23:38:00] ok - let's pencil it in for then & I'll just check how it's supposed to work with rooms [23:38:23] Re phpunit Civi DOES ship with an old version of phpunit & may try to put it in your path.... [23:39:07] MBeat: the first line was to you in there :-) phpunit not so much [23:39:43] casey@homie:/srv/crm$ phpunit -v [23:39:45] PHPUnit 4.8.16 by Sebastian Bergmann and contributors. [23:39:56] casey@homie:/srv/crm$ phpunit --version [23:39:58] PHPUnit 4.2.6 by Sebastian Bergmann. [23:40:00] casey@homie:/srv/crm$ phpunit --version [23:40:02] PHPUnit 4.2.6 by Sebastian Bergmann. [23:40:04] wat [23:43:00] cwd: I'm guess whoa [23:43:13] derp