[00:10:31] (PS1) Eileen: CRM-17537 use name label only when search excludes email [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/252137 [00:31:29] Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Civi can't find an email address that is in the database - https://phabricator.wikimedia.org/T118036#1789923 (Eileenmcnaughton) [00:43:57] hmm I need to run drush make_exchange_rates but I can't find it [00:44:12] ie. doesn't run (even when civi drush commands DO work) [00:49:21] eileen: oh, let me see - it might be expecting some configuration [00:49:43] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Donation over $1000 throws error on comma in amount field (editing or creating) - https://phabricator.wikimedia.org/T118216#1794941 (Eileenmcnaughton) I checked this & it is coming from our validate hook - not core CiviCRM.... [00:49:59] ejegg: thanks - I just added my notes to that ticket… [00:50:02] it can fetch rates from a couple of providers, one of which needs a login [00:50:22] ok - I just want the class to exist so I can check out the validate function [00:54:42] eileen: oh, that CurrencyRates class is actually within DonationInterface. It should be installed as a composer dependency [00:55:14] should be someplace under crm/vendor/wikimedia/donation-interface [00:55:25] hmm - I ran composer up - I thought that would have done it [00:55:50] huh, let me see [00:56:34] did it install any version of donation-interface? [00:56:43] maybe it did fail - I saw wikimedia/smash-pig dev-master requires amzn/login-and-pay-with-amazon-sdk-php dev-master -> satisfiable by amzn/login-and-pay-with-amazon-sdk-php[dev-master] [00:56:56] & thought that was recoverable - but maybe not [00:57:59] hmm - ok also hitting it on re-install [00:58:34] Odd. The composer.lock from git should be correct. I just nuked vendor and ran "composer install --no-dev" and it seems to be fine. [00:58:44] let me try no-dev [01:00:26] Think we can solve the comma issue by just blanking the thousands separator in Administer->Localization->Language and Currency? [01:01:12] hmm - the error is actually coming from the WMF hook - but I haven't got my head fully around it [01:01:18] bah, 'Thousands Separator cannot be empty. use a space character instead' [01:01:42] :-) [01:02:08] it's coming from this line [01:02:25] $errors['total_amount'] = t( 'Amount must be a decimal number you ninny' ); [01:02:31] in wmf_civicrm_civicrm_validate [01:02:48] (actually I edited that line to confirm - the original message was different) [01:03:12] hehe [01:03:40] so easiest option is just to strip the comma before validating [01:03:52] but I don't know if there is any flow on there [01:04:02] yeah, we need the amount to be numeric for a bunch of the other hocus pocus we try to do with it [01:04:50] so, the question is can we just assume that if there is a comma it is legit input but undesirable [01:05:18] yeah, I'd imagine just stripping it out should be fine [01:06:44] (PS1) Eileen: Permit (and ingore) comma in amount data entry [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/252144 (https://phabricator.wikimedia.org/T118216) [01:07:08] hmm, looks like alterContent could keep it from automatically adding it back to the input. [01:07:42] ejegg: that patch above appears to work [01:08:28] it seems like a really constrained problem - only those few lines of code are engaged in this validation error [01:08:49] i think we need to make sure the comma doesn't hit the db either [01:09:07] Civi takes care of that I believe [01:09:09] There's some logic that gets befuddled by it later [01:09:15] oh, nice [01:09:17] we are at the form validation layer here [01:09:21] not deep down [01:09:35] this is a WMF hook adding extra validation on form submit [01:10:02] yeah, let me just remind myself why we added that in the first place [01:11:13] yeah that would be a good thing to know before we disable part of it :-) [01:12:24] dang, no phab/bugzilla ticket on the patch that introduced it... [01:13:53] :-( [01:14:13] the comment is // Amount field should be decimal [01:14:40] if which case the risk is implicitly that the comma could be mis-understood :-( [01:16:03] do we have data entry from euro countries? I should add these note on the ticket [01:16:29] & then perhaps go home & look again tomorrow [01:16:47] nope, don't need to worry about that. [01:17:42] OK, just verified that the separator is stripped before it hits the post_process hooks. That's the only concern I had with ignoring the comma [01:17:56] Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Civi can't find an email address that is in the database - https://phabricator.wikimedia.org/T118036#1794971 (Eileenmcnaughton) I have logged this as 2 upstream issues https://issues.civicrm.o... [01:19:01] well, I'm about done for the day. See you tomorrow! [01:19:02] ejegg: OK - so I feel like we should probably think about removing rather than changing that validation [01:19:09] cool [01:19:13] see you! [01:21:37] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Donation over $1000 throws error on comma in amount field (editing or creating) - https://phabricator.wikimedia.org/T118216#1794973 (Eileenmcnaughton) The validation is happening within a wmf hook (wmf_... [05:08:11] Wikimedia-Fundraising: Untranslated Credit Card fields (GlobalCollect iframes) - https://phabricator.wikimedia.org/T109064#1795106 (Mykola_Swarnyk) IMHO would be better to leave English language. If somebody can handle Master Card they can understand English. I can be wrong, but Russian instructions for paym... [05:55:17] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Donation over $1000 throws error on comma in amount field (editing or creating) - https://phabricator.wikimedia.org/T118216#1795125 (Ejegg) Also verified that the comma is removed by Civi before it hits... [06:03:56] Fundraising Sprint William Shatner, Fundraising-Backlog: Fill out SAQ A 3.1 for Adyen - https://phabricator.wikimedia.org/T118200#1795131 (Ejegg) a:Ejegg [06:12:15] (PS1) Ejegg: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/252163 [06:12:31] (CR) Ejegg: [C: 2 V: 2] Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/252163 (owner: Ejegg) [06:13:31] !log updated fundraising tools from f2f571903d32ec73aeab73ce58c6bee71717213b to 182f217ea20a496fe0f9737447d04ed9a3bccde8 [06:13:35] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [07:24:18] (CR) Awight: [C: -1] CRM-17536 fix quicksearch label for when email search is disabled (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/252016 (https://phabricator.wikimedia.org/T118036) (owner: Eileen) [07:26:01] (CR) Awight: [C: 2] "Very nice!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/252137 (owner: Eileen) [12:34:58] Wikimedia-Fundraising: Untranslated Credit Card fields (GlobalCollect iframes) - https://phabricator.wikimedia.org/T109064#1795544 (Pcoombe) @Mykola_Swarnyk Yes, we recognise that this is a sensitive issue. But this part of the content is controlled by our third-party payment processor, not us. We won't run... [15:41:57] howdy cwd ! [15:42:18] mornin! [15:43:04] Feel like perusing a few patches? I'm thinking it would be nice to deploy my DI stuff today if possible [15:43:31] yeah for sure [15:44:11] checking gerrit... [15:51:47] oh yeah, that wrapper function should fix the test fail you got in crm after updating libs [15:52:30] cool yeah, i had that checked out yesterday [15:52:39] but got some new errors and got sidetracked [15:55:13] (CR) Cdentinger: [C: 2] Amazon: check CSRF token, preserve data after expiry (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/252111 (https://phabricator.wikimedia.org/T117827) (owner: Ejegg) [15:55:25] Thanks! [15:56:03] That whole reload with qs params thing should eventually go in the base form js [15:57:21] yeah good idea [16:04:48] Jeff_Green, what's the best way to dump QS params from donatewiki into a db for CCogdill to peruse? It's for email clicks: https://phabricator.wikimedia.org/T114010 [16:05:35] I think we want to stash anything with a recipient_id param [16:06:29] Would this be another udp2log filter? [16:07:50] (CR) Cdentinger: Make Amazon use standard handleDonationRequest (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/252110 (https://phabricator.wikimedia.org/T117827) (owner: Ejegg) [16:09:27] ejegg: reading ticket [16:11:03] (CR) Ejegg: Make Amazon use standard handleDonationRequest (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/252110 (https://phabricator.wikimedia.org/T117827) (owner: Ejegg) [16:12:41] ejegg: yeah, I think it would just be another collector, but kafka and not udp2log since udp2log is being phased out [16:13:05] ah, cool! [16:13:21] Can you point me to an example of kafkatee configuration? [16:13:34] I'm not super familiar yet with how kafka collectors work on the Analytics cluster side, we should confirm everything with them [16:13:42] (CR) Cdentinger: [C: 2] Make Amazon use standard handleDonationRequest [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/252110 (https://phabricator.wikimedia.org/T117827) (owner: Ejegg) [16:13:54] sec, looking at kafkatee [16:14:27] I think awight had been talking about the same thing in regards to banner stats. I'll confirm with him when he signs on [16:15:02] honestly I have no idea what the kafkatee config I'm looking at means [16:15:13] it's two part, there's an input and output filter [16:15:39] ok, that makes sense [16:16:01] input filter tells it which lines to log, output filter tells it the format? [16:16:12] input filter example: [16:16:20] input [encoding=json] kafka topic webrequest_text partition 0-11 from stored [16:16:37] output filter example: [16:16:38] um, yeah [16:16:42] that's a little cryptic! [16:16:49] output pipe 10 /usr/bin/udp-filter -F ' ' -p beacon/impression >> /srv/kafkatee/beaconImpressions-sampled10.tsv.log [16:17:00] that one makes more sense to me [16:17:04] right [16:17:13] we can get ottomata's help [16:18:13] thanks! I'll see if I can dig up a doc on wiki or announcement in email, just for some basic orientation [16:18:51] ok, i just found ottomata online, can you add the question to T114010 and we can ask him to clarify/respond? [16:19:19] sure thing! [16:23:30] Fundraising Sprint William Shatner, Fundraising-Backlog: Track email clickthroughs on donate wiki - https://phabricator.wikimedia.org/T114010#1796132 (Ejegg) Sounds like we want a kafkatee consumer. The links will be in this format: https://donate.wikimedia.org/?utm_campaign=C15_Email1&utm_medium=email&u... [16:27:54] Fundraising Sprint William Shatner, Fundraising-Backlog: Track email clickthroughs on donate wiki - https://phabricator.wikimedia.org/T114010#1796145 (Ejegg) Ah, I guess https://wikitech.wikimedia.org/wiki/Analytics/Cluster/Kafka is a good place to start... [16:30:24] (CR) Cdentinger: [C: 2] Add IDs to more inputs, remove duplicate [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/252109 (https://phabricator.wikimedia.org/T117827) (owner: Ejegg) [16:31:16] (CR) Ejegg: Amazon: check CSRF token, preserve data after expiry (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/252111 (https://phabricator.wikimedia.org/T117827) (owner: Ejegg) [16:34:17] (Merged) jenkins-bot: Add IDs to more inputs, remove duplicate [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/252109 (https://phabricator.wikimedia.org/T117827) (owner: Ejegg) [16:34:20] (Merged) jenkins-bot: Make Amazon use standard handleDonationRequest [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/252110 (https://phabricator.wikimedia.org/T117827) (owner: Ejegg) [16:34:22] (Merged) jenkins-bot: Amazon: check CSRF token, preserve data after expiry [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/252111 (https://phabricator.wikimedia.org/T117827) (owner: Ejegg) [16:37:38] (CR) Cdentinger: [C: 2] Add sanitize wrapper fn to WmfFramework [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/251650 (owner: Ejegg) [16:40:03] Fundraising Sprint William Shatner, Fundraising-Backlog: Track email clickthroughs on donate wiki - https://phabricator.wikimedia.org/T114010#1796178 (Ottomata) @Ejegg, it might be easier for you to come ask us in realtime in #wikimedia-analytics. You can also get this info out of Hive. [16:49:42] (Merged) jenkins-bot: Add sanitize wrapper fn to WmfFramework [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/251650 (owner: Ejegg) [16:52:53] thanks cwd! relocating, but i'll do that deploy when i get home [16:53:35] sounds good! [16:54:14] (CR) Eileen: "I should note that I'm not 100% sure about this fix - I added some notes on the Phab - but basically I'm not clear enough about what this " [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/252144 (https://phabricator.wikimedia.org/T118216) (owner: Eileen) [17:15:59] Fundraising Sprint William Shatner, Fundraising-Backlog: Track email clickthroughs on donate wiki - https://phabricator.wikimedia.org/T114010#1796312 (Ottomata) https://wikitech.wikimedia.org/wiki/Analytics/Data/Webrequest https://wikitech.wikimedia.org/wiki/Analytics/Cluster/Hive/Queries [17:33:45] (PS2) Eileen: CRM-17536 fix quicksearch label for when email search is disabled [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/252016 (https://phabricator.wikimedia.org/T118036) [17:34:01] (CR) Eileen: "Adjustment made" (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/252016 (https://phabricator.wikimedia.org/T118036) (owner: Eileen) [17:40:09] Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Civi quick search by email doesn't work - remove label to alleviate confusion. - https://phabricator.wikimedia.org/T118036#1796372 (atgo) [17:40:48] Fundraising Sprint William Shatner, Fundraising-Backlog: Track email clickthroughs on donate wiki - https://phabricator.wikimedia.org/T114010#1796373 (Ejegg) a:Ejegg [17:41:33] Fundraising Sprint William Shatner, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 3 others: Slow searches: Transaction by ID # using % and also Contribs by email address - https://phabricator.wikimedia.org/T117492#1796376 (Eileenmcnaughton) @mbeat can you confir... [17:42:27] Fundraising Sprint William Shatner, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: [Epic] Followup tasks after Civi 4.6 upgrade - https://phabricator.wikimedia.org/T116416#1796379 (Eileenmcnaughton) [17:42:30] Fundraising Sprint Vengaboys, Fundraising Sprint William Shatner, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Create new civicrm repo - https://phabricator.wikimedia.org/T114831#1796378 (Eileenmcnaughton) Open>Resolved [17:43:21] Fundraising-Backlog: Get composer.json in crm deployable - https://phabricator.wikimedia.org/T117898#1796384 (cwdent) a:cwdent [17:44:16] Fundraising Sprint Vengaboys, Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 3 others: We are failing to send AstroPay stats to Ganglia - https://phabricator.wikimedia.org/T116817#1796389 (Eileenmcnaughton) Open>Resolved [17:44:44] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Sprint William Shatner, Fundraising Tech Backlog, and 3 others: Prepare queue messages for testing on upgraded Civi. Test them. - https://phabricator.wikimedia.org/T114466#1796392 (Eileenmcnaughton) Open>Resolved [17:44:46] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Sprint William Shatner, Fundraising Tech Backlog, and 3 others: [epic] Install 4.6 to staging and test like hell - https://phabricator.wikimedia.org/T99842#1796393 (Eileenmcnaughton) [17:45:26] Fundraising Sprint William Shatner, Fundraising-Backlog: Sprint W (10/28 - 11/11) goal: code freeze! - https://phabricator.wikimedia.org/T112816#1796399 (DStrine) Open>Resolved [17:45:44] Fundraising Sprint Vengaboys, Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Civi 4.6 date range fields are unusably annoying - https://phabricator.wikimedia.org/T116420#1796405 (Eileenmcnaughton) @awight - do we need to check this with... [17:47:10] Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Reports "Save a Copy" is broken - https://phabricator.wikimedia.org/T117166#1767992 (Eileenmcnaughton) I've moved this back to doing as I think there are still flows in here that aren't right. It might be in the up... [17:48:12] Fundraising Sprint William Shatner, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 3 others: Slow searches: Transaction by ID # using % and also Contribs by email address - https://phabricator.wikimedia.org/T117492#1796428 (MBeat33) @Eileenmcnaughton, the search... [17:58:37] Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work, Patch-For-Review: Don't include refunded donations in Silverpop export - https://phabricator.wikimedia.org/T117931#1796526 (Ejegg) Hi @CCogdill_WMF, I deployed this last night, and it'... [18:01:36] Fundraising-Backlog: Adyen: retest internally with real credit cards - https://phabricator.wikimedia.org/T118293#1796556 (DStrine) NEW [18:01:51] Fundraising-Backlog: Adyen: retest internally with real credit cards - https://phabricator.wikimedia.org/T118293#1796564 (DStrine) [18:01:52] Fundraising-Backlog, Epic: [epic] Adyen 1 hour test - https://phabricator.wikimedia.org/T118201#1796563 (DStrine) [18:04:02] Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work, Patch-For-Review: Don't include refunded donations in Silverpop export - https://phabricator.wikimedia.org/T117931#1796581 (CCogdill_WMF) Great, thank you, @Ejegg! I'm not sure what yo... [18:08:48] Fundraising Sprint X, Fundraising-Backlog: Adyen: retest internally with real credit cards - https://phabricator.wikimedia.org/T118293#1796629 (DStrine) [18:08:50] Fundraising Sprint William Shatner, Fundraising Sprint X, Fundraising-Backlog: Fill out SAQ A 3.1 for Adyen - https://phabricator.wikimedia.org/T118200#1796631 (DStrine) [18:08:52] Fundraising Sprint X, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Donation over $1000 throws error on comma in amount field (editing or creating) - https://phabricator.wikimedia.org/T118216#1796630 (DStrine) [18:08:54] Fundraising Sprint William Shatner, Fundraising Sprint X, Fundraising-Backlog, Unplanned-Sprint-Work, and 3 others: Amazon donor details missing when they donate after session timeout - https://phabricator.wikimedia.org/T117827#1796635 (DStrine) [18:08:56] Fundraising Sprint William Shatner, Fundraising Sprint X, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Don't include refunded donations in Silverpop export - https://phabricator.wikimedia.org/T117931#1796633 (DStrine) [18:08:58] Fundraising Sprint William Shatner, Fundraising Sprint X, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, and 3 others: CentralNotice: use KVStore instead of cookies for mixins that create cookies, except for Fundraising - https://phabricator.wikimedia.org/T117650#1796636 (DStrine) [18:09:01] Fundraising Sprint William Shatner, Fundraising Sprint X, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Civi quick search by email doesn't work - remove label to alleviate confusion. - https://phabricator.wikimedia.org/T118036#1796632 (DStrine) [18:09:35] Fundraising-Backlog: Clear up Amazon donations that got disconnected from CT ID - https://phabricator.wikimedia.org/T118296#1796671 (Ejegg) NEW [18:24:51] Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising-Backlog, FR-Adyen, Patch-For-Review: Fix or disable Adyen job runner - https://phabricator.wikimedia.org/T117451#1796747 (Ejegg) Open>Resolved [18:24:53] Fundraising-Backlog, Epic: [epic] Get Adyen back up - https://phabricator.wikimedia.org/T90748#1796748 (Ejegg) [18:29:24] ejegg: suppose i'll just work off that epic's block list then? [18:29:53] Fundraising Sprint X-Ray Spex, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Corrupt dashboard items are throwing warnings during Civi upgrade - https://phabricator.wikimedia.org/T116521#1796794 (Eileenmcnaughton) I feel like this is fixed? [18:31:58] cwd: sure, makes sense [18:32:11] I think the CSS would be a good one to start with [18:34:26] sounds good [18:34:34] swapping to mustache form might not be too bad, but state and zip inputs might need work [18:37:40] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Adyen: Fix CSS on Adyen form - https://phabricator.wikimedia.org/T117897#1796806 (Ejegg) p:Triage>High [18:58:24] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/252253 [19:19:32] Fundraising Sprint Vengaboys, Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising-Backlog, Patch-For-Review: SPIKE: assess the condition of adyen for english backup processing - https://phabricator.wikimedia.org/T114958#1796940 (atgo) @ejegg - seems like this is a bit... [19:19:52] Fundraising-Backlog, Epic: [epic] Adyen 1 hour test - https://phabricator.wikimedia.org/T118201#1796942 (atgo) [19:19:53] Fundraising-Backlog, Epic: [epic] Get Adyen back up - https://phabricator.wikimedia.org/T90748#1796943 (atgo) [19:19:55] Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising-Backlog: Fill out SAQ A 3.1 for Adyen - https://phabricator.wikimedia.org/T118200#1796941 (atgo) Open>Resolved [19:20:01] Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising-Backlog: Fill out SAQ A 3.1 for Adyen - https://phabricator.wikimedia.org/T118200#1794201 (atgo) Pats sent this 11/10 [19:21:13] Fundraising Sprint Vengaboys, Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising-Backlog, Patch-For-Review: SPIKE: assess the condition of adyen for english backup processing - https://phabricator.wikimedia.org/T114958#1796947 (Ejegg) Open>Resolved Sounds good... [19:29:44] Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Don't include refunded donations in Silverpop export - https://phabricator.wikimedia.org/T117931#1796978 (Ejegg) Oh, there should be no negative amounts left at all.... [19:33:40] Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Don't include refunded donations in Silverpop export - https://phabricator.wikimedia.org/T117931#1796997 (CCogdill_WMF) Got it, thanks for clarifying that, @Ejegg. W... [19:34:51] Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Don't include refunded donations in Silverpop export - https://phabricator.wikimedia.org/T117931#1797002 (CCogdill_WMF) Open>Resolved [20:17:37] cwd: I saw there was one of your patches in the deployment, so I thought I'd wait till you were back to push that stuff up to prod [20:18:31] ejegg: ah cool thanks, lemme check [20:18:53] it's the 'refresh on configurable timeout' patch [20:19:13] ah yes, thanks for waiting, that's one of those that might need an emergency plug pulled [20:19:33] is now good for you? [20:19:36] yep! [20:19:39] i'll watch the logs [20:19:44] rockin [20:20:41] Hmm, there's one of AndyRussG's too, but I think it'll be easy to see if anything goes wrong with that [20:21:01] ooh, it needs a schema update on a Civi table... [20:21:19] let me see if that went through [20:22:00] awight reception had already found it! false alarm [20:22:05] hah! [20:22:08] sorry for the distraction :D [20:23:18] hi awight! When you get a chance, could you please peek at https://gerrit.wikimedia.org/r/251728 so I can set the SmashPig failmail back to fr-tech? [20:26:12] dang, I need to enable a new Civi module and run updatedb before I can deploy AndyRussG's DI patch [20:30:13] very tempted to do that without taking Civi offline [20:30:44] but I'd want a vote of confidence from eileen or awight [20:37:59] cwd: sorry, going to wait a bit longer to deploy ^^^ [20:38:53] no problem! [20:53:42] dstrine: Are we still doing standup today, or did sprint planning cover it? [20:55:45] Does anyone want to meet? [20:56:03] I could, but I don't feel like I need to. [20:56:41] yeah sorry It amy be better to cancel this [20:57:21] awight|afk: ejegg cwd any thoughts?^^^^ [20:57:26] No worries, I was just checking to make sure I didn't miss something. [20:57:36] I'm down to cancel [20:58:02] yeah, i don't have much new to report yet [20:58:08] fine w me [20:58:28] yeah sorry I didn't clean everything up due to the weird wednesday [20:58:43] And consensus was reached that in leu of standup, we shal all remain sitting instead. [20:59:26] looks like I can't cancel the instance [20:59:30] I emailed everyone [20:59:34] Fundraising-Backlog: Recent iframe errors from up-to-date browsers - https://phabricator.wikimedia.org/T112181#1797417 (MBeat33) This iframe error is from a donor using the latest version of Firefox, Windows 8.1, and a donation link from a bulk email, http://links.wikimedia.mkt4477.com/ctt?kn=6&ms=NDk5ODE2ND... [21:01:56] looks like someone canceled the meeting [21:10:33] ejegg: hehe, yeah if you've eyeballed the updatedb migrations, then it's fine to run them "hot" [21:11:52] cool, it's just creating the banner history association table, not changing existing ones [21:11:57] here goes! [21:16:16] !log enabled banner_history module on CiviCRM [21:16:19] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:17:34] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/252253 (owner: Ejegg) [21:19:00] fundraising-tech-ops, operations: remove fundraising banner log related cruft from production puppet - https://phabricator.wikimedia.org/T118325#1797487 (Jgreen) NEW [21:19:58] fundraising-tech-ops, operations: remove fundraising banner log related cruft from production puppet - https://phabricator.wikimedia.org/T118325#1797494 (Jgreen) [21:30:21] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/252288 [21:30:38] (CR) Ejegg: [C: 2 V: 2] Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/252288 (owner: Ejegg) [21:31:07] cwd: ok, this time for realsies [21:31:37] do it! [21:32:55] Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Patch-For-Review: Offer contentlanguage targeting for CentralNotice banners - https://phabricator.wikimedia.org/T53475#1797548 (Whatamidoing-WMF) I think we need to separate **receiving** from **sending**. The problem is that the sender isn't... [21:33:03] !log updated paymentswiki from 4baa5a66a4510414d6b43b59f1b1cda2341c17fd to 3730cff201e314fc54ad76fbc54f33f5b032def5 [21:33:07] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:33:34] err, not quite yet [21:34:46] ok, now updated for real! [21:35:35] oh man, Amazon donors are having a hard time. [21:35:56] aargh, i bet i need more IP addys whitelisted [21:37:18] WP seems to be going through still [21:37:50] yeah, this Amazon problem was not the fault of this deploy [21:46:32] Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Coinbase import fails with database error - https://phabricator.wikimedia.org/T116445#1797569 (awight) Update: it turns out we don't have to open and re... [21:46:41] OK, I just gave successfully via Amazon. Hmm. [21:46:55] why so many 'cannot connect to host' errors in the logs, I wonder [21:50:10] (PS1) Awight: Yet another variation in the Coinbase naming scheme [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/252331 [21:52:48] Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Batch import fails on amount >= $1,000 - https://phabricator.wikimedia.org/T118333#1797600 (awight) NEW [21:53:58] Fundraising Sprint William Shatner, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Batch import fails on amount >= $1,000 - https://phabricator.wikimedia.org/T118333#1797608 (awight) [21:55:51] Fundraising-Backlog, Wikimedia-Fundraising, Analytics: Public dashboards for CentralNotice and Fundraising - https://phabricator.wikimedia.org/T88744#1797621 (awight) [21:56:36] dern it [21:56:45] how do i get load.php https? [21:56:57] assuming https wgServer [21:57:15] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CiviCRM 4.7: beware editable "net amount" - https://phabricator.wikimedia.org/T118334#1797623 (awight) NEW [22:00:08] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Put bgm's civicrm_bartik theme on staging for try-out - https://phabricator.wikimedia.org/T118335#1797633 (awight) NEW [22:00:30] hey ejegg cwd brt [22:00:32] need a minute [22:00:43] k, see you in a few [22:00:46] mmk [22:06:36] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Enable CiviCRM change logging on staging - https://phabricator.wikimedia.org/T118336#1797657 (awight) NEW [22:08:23] Fundraising Sprint X-Ray Spex, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Coinbase "mispaid" and "refunded" contributions not recorded correctly - https://phabricator.wikimedia.org/T118337#1797675 (awight) NEW [22:08:50] Fundraising Sprint X-Ray Spex, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Batch import fails on amount >= $1,000 - https://phabricator.wikimedia.org/T118333#1797685 (awight) [22:09:36] dstrine: new tag request: FR-Coinbase [22:11:33] Fundraising Sprint X-Ray Spex, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Coinbase "refunded" contributions not recorded correctly - https://phabricator.wikimedia.org/T118337#1797698 (awight) [22:11:35] Fundraising Dash, Fundraising-Backlog: [epic] make Dash useful for December fundraising campaign - https://phabricator.wikimedia.org/T118048#1797701 (atgo) [22:11:37] Fundraising Dash, Fundraising-Backlog: Rate Comparison Test - https://phabricator.wikimedia.org/T93117#1797702 (atgo) [22:13:30] awight I’m seeing lots of confused donors not sure if their GC contribs processed w/in last 15 minutes - did any settings change recently [22:14:07] Not that I'm aware of... [22:14:18] What are the symptoms? [22:14:56] Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Coinbase import fails with database error - https://phabricator.wikimedia.org/T116445#1797708 (CaitVirtue) @LeanneS can you document this in Collab and/... [22:15:16] donors not sure if contribs were successful; some making multiples w/out intending [22:15:26] ooh [22:15:31] So probably, no Thank-you page [22:15:41] GC output shows usual mix of 800s, 100s, etc but it seems like donors are in dark [22:16:33] There was a paymentswiki deployment about 45min ago, I'm looking at what was in there. [22:17:04] thank you, we have a spike of some kind of issue [22:17:19] ejegg: fyi ^ [22:24:19] awight ejegg it looks like donors are getting error msgs for successful contribs [22:24:57] ut-oh! GC donors in particular? [22:25:18] The only thing that jumps out from what was deployed is the new GatewayReady hook... [22:25:43] oh boy, is that causing problems? [22:25:48] donno yet! [22:26:27] Looks like we should take Amazon down? [22:27:00] I'll be the first to conjecture: freak week started early? [22:28:04] aargh, flood of amazon cannot connect errors continues [22:28:50] Disable? [22:28:53] Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising-Backlog: Track email clickthroughs on donate wiki - https://phabricator.wikimedia.org/T114010#1797773 (Ejegg) Notes: We can get daily (as frequent as hourly) data via hive queries. To accomplish that, someone needs to get... [22:29:05] i just got a donation through, dang it [22:30:31] Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Coinbase import fails with database error - https://phabricator.wikimedia.org/T116445#1797778 (awight) >>! In T116445#1797708, @CaitVirtue wrote: > @awi... [22:32:08] seems like mostly GC so far [22:32:57] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Long page load approx once per day, maybe more - https://phabricator.wikimedia.org/T118341#1797797 (awight) NEW [22:35:51] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: [Epic] Improve MG workflow for entering new contributions - https://phabricator.wikimedia.org/T118344#1797835 (awight) NEW [22:36:50] haha cwd just listened to the rest of that "jazz" piece [22:36:55] things got hairy for you guys at the end there huh? [22:37:18] hehe, yeah [22:37:48] it was "free day" -- annual event where all orders were free until we hit $100k [22:37:57] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Help Civi users configure their dashboards - https://phabricator.wikimedia.org/T118345#1797844 (awight) NEW [22:38:10] we would get a few orders of magnitude above normal load [22:38:29] fun day for metrics [22:38:58] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Verify that the contribution modified date trigger is installed - https://phabricator.wikimedia.org/T118346#1797852 (awight) NEW [22:46:21] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Regression: CentralNotice setting class=cn-undefined - https://phabricator.wikimedia.org/T118348#1797891 (atgo) [22:49:14] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Regression: CentralNotice setting class=cn-undefined - https://phabricator.wikimedia.org/T118348#1797894 (Krinkle) It means some part of CentralNotice frontend is broken. I don't know how severe. * It could mean that critical data such as bucke... [22:50:05] !log rolled back paymentswiki from 3730cff201e314fc54ad76fbc54f33f5b032def5 to 4baa5a66a4510414d6b43b59f1b1cda2341c17fd [22:50:08] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:50:20] hey awight ejedd cwd xenoryet - in andy's absence, could you help triage this one?   https://phabricator.wikimedia.org/T118348 [22:50:27] just want to know if it's critical or not [22:52:00] hrmm tough for me to say but any CN breakage sounds like a Bad Thing [22:52:43] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Regression: CentralNotice setting class=cn-undefined - https://phabricator.wikimedia.org/T118348#1797897 (atgo) Thank you @krinkle [22:53:14] it may just be a banner with no category set [22:54:22] could have a getter with a default [22:54:29] or make -undefined a class :P [22:55:25] thx ejegg [22:55:39] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Regression: CentralNotice setting class=cn-undefined - https://phabricator.wikimedia.org/T118348#1797902 (awight) p:Triage>Unbreak! All banners come with a default category of {{{campaign}}}, and we're using the category for an increasing... [22:56:31] Fundraising Sprint X-Ray Spex, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Coinbase "refunded" contributions not recorded correctly - https://phabricator.wikimedia.org/T118337#1797904 (awight) For example, 24GBZOTX -- the amount is showing up incorrect as well! [22:56:56] timing sucks, but I have to head out. I'll check back in tonight [22:57:55] Fundraising Sprint X-Ray Spex, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, FR-GlobalCollect: Determine what was breaking GlobalCollect in paymentswiki 3730cff20 - https://phabricator.wikimedia.org/T118349#1797908 (awight) NEW [22:58:16] ejegg|away: Thanks for the rollback! [23:06:34] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Amazon: Amazon IP changes screwed us - https://phabricator.wikimedia.org/T118352#1797946 (awight) NEW [23:12:16] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising-Backlog: Recharge minFraud account - https://phabricator.wikimedia.org/T113105#1797966 (K4-713) Queries Remaining still doesn't reflect the main... payload. Can... [23:22:38] Wikimedia-Fundraising-CiviCRM: Improvements to Contact page - https://phabricator.wikimedia.org/T118354#1797993 (atgo) NEW [23:22:55] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Improvements to Contact page - https://phabricator.wikimedia.org/T118354#1798000 (atgo) [23:27:26] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Figure out & fix the certificate issue that's not allowing civi users to have dashlets - https://phabricator.wikimedia.org/T118356#1798014 (atgo) NEW [23:39:20] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: [epic] Improvements to Contact page - https://phabricator.wikimedia.org/T118354#1798042 (atgo) [23:41:26] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Verify that the contact modified date trigger is installed - https://phabricator.wikimedia.org/T118346#1798045 (atgo) [23:42:10] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: UI Sillyness: Can't see all the fields when adding a new email address to a contact record - https://phabricator.wikimedia.org/T118037#1798051 (CaitVirtue)