[00:12:05] :-) [00:12:59] welp, i gotta go spend some time in the crawl space [00:29:10] (CR) Awight: [C: 2] "Great shortcut, thanks for explaining!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/253486 (owner: Cdentinger) [00:31:03] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Saving a donation is very slow for Engage - https://phabricator.wikimedia.org/T118415#1812589 (awight) [00:35:51] (Merged) jenkins-bot: add zip code field to addresses [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/253486 (owner: Cdentinger) [00:37:22] (PS1) Eileen: Change spacing to match surrounding rows [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/253796 [00:37:24] (PS1) Eileen: Add test for thousands separator in contribution import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/253797 [00:37:26] (PS1) Eileen: Remove commas from currency fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/253798 (https://phabricator.wikimedia.org/T118333) [00:40:50] (CR) jenkins-bot: [V: -1] Add test for thousands separator in contribution import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/253797 (owner: Eileen) [00:43:12] (CR) Eileen: "Note I deliberately added the test before the fix - so the fail at this point is good proof of the fix." (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/253797 (owner: Eileen) [00:45:55] (CR) Awight: [C: 2] Change spacing to match surrounding rows [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/253796 (owner: Eileen) [00:49:15] (CR) Awight: [C: 2] Add test for thousands separator in contribution import (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/253797 (owner: Eileen) [00:49:59] (CR) Awight: [C: 2] "This probably closes three different bugs 8D" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/253798 (https://phabricator.wikimedia.org/T118333) (owner: Eileen) [00:52:34] (Merged) jenkins-bot: Change spacing to match surrounding rows [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/253796 (owner: Eileen) [00:52:36] (CR) jenkins-bot: [V: -1] Add test for thousands separator in contribution import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/253797 (owner: Eileen) [00:52:38] (CR) jenkins-bot: [V: -1] Remove commas from currency fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/253798 (https://phabricator.wikimedia.org/T118333) (owner: Eileen) [00:54:09] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Sprint X-Ray Spex, Fundraising-Backlog, and 2 others: All Civi hook code paths must be covered by PHPUnit tests - https://phabricator.wikimedia.org/T115426#1812642 (Eileenmcnaughton) Open>Resolved I'm setting this to resolved... [00:54:10] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Sprint William Shatner, Fundraising Tech Backlog, and 3 others: [epic] Install 4.6 to staging and test like hell - https://phabricator.wikimedia.org/T99842#1812644 (Eileenmcnaughton) [00:56:24] Fundraising research, Analytics-Backlog, Research-and-Data: FR tech hadoop onboarding - https://phabricator.wikimedia.org/T118613#1812664 (Tbayer) > [ ] @Tbayer would you be able to give them a walkthrough of webrequest / pv data with example queries? @DarTar : @JKatzWMF and I think that's in the Ana... [00:59:02] awight: so I thought from my reading of the CI that if I submitted a test followed by a change that made it work it would follow the trail back & merge them - but it's not looking like it [01:04:16] unfortunately not [01:04:54] There's probably a way to commit and review changes on a feature branch, then only test the merge commit, but not really worth it for this [01:05:07] I guess we just force merge of the V-1 tests [01:07:45] awight: ok - I'll know not to try that again! [01:09:39] (CR) Eileen: [V: 2] "force-merging this as I added the fix to be redundant on the test instead of vice-cersa" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/253797 (owner: Eileen) [01:09:56] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/253798 (https://phabricator.wikimedia.org/T118333) (owner: Eileen) [01:10:51] (CR) Eileen: "retest" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/253798 (https://phabricator.wikimedia.org/T118333) (owner: Eileen) [01:11:44] Fundraising research, Analytics-Backlog, Research-and-Data: FR tech hadoop onboarding - https://phabricator.wikimedia.org/T118613#1812733 (madhuvishy) I'm around to help too - with access to stat1002/anything with regard to querying for the data. @DarTar as far as permits go, I see that andyrussg and a... [01:11:54] (CR) Eileen: [V: 2] "check" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/253798 (https://phabricator.wikimedia.org/T118333) (owner: Eileen) [01:14:23] (CR) Eileen: "forcing merge as committing tests before the fix seems to have caused unresolvable snaffu" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/253798 (https://phabricator.wikimedia.org/T118333) (owner: Eileen) [01:15:09] awight: ok - so I need to clarify with you a bit re deployment [01:15:22] I think getting this out is fairly important https://gerrit.wikimedia.org/r/#/c/253171/ [01:16:01] & I think there are a few other fixes in the civi dir which have not gone - not least because I don't think any submodule update commit has gone through [01:19:07] (PS1) XenoRyet: Make LYBUNT report work for calendar and fiscal year [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/253808 (https://phabricator.wikimedia.org/T88819) [01:21:03] (PS2) XenoRyet: Make LYBUNT report work for calendar and fiscal year [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/253808 (https://phabricator.wikimedia.org/T88819) [02:19:07] (CR) Eileen: [V: 1] "I plus one'd this but also a question about the data (to which I don't know the answer). I'll let someone else look too!" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/253808 (https://phabricator.wikimedia.org/T88819) (owner: XenoRyet) [02:22:03] (PS2) Awight: Fix slow email search [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/253171 (owner: Eileen) [02:22:42] (CR) Awight: [C: 2] "Thanks for pushing on this!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/253171 (owner: Eileen) [02:26:07] (Merged) jenkins-bot: Fix slow email search [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/253171 (owner: Eileen) [03:22:13] (CR) XenoRyet: Make LYBUNT report work for calendar and fiscal year (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/253808 (https://phabricator.wikimedia.org/T88819) (owner: XenoRyet) [03:33:03] Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising Tech Backlog, Fundraising-Backlog, and 4 others: Slow searches: Transaction by ID # using % and also Contribs by email address - https://phabricator.wikimedia.org/T117492#1812929 (Eileenmcnaughton) @mbeat33 I'm moving t... [03:44:32] (CR) Awight: [C: -1] Make LYBUNT report work for calendar and fiscal year (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/253808 (https://phabricator.wikimedia.org/T88819) (owner: XenoRyet) [05:27:50] (PS1) Eileen: Fix link to output report as print [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/253829 [05:27:52] (PS1) Eileen: Fix reports save a copy link pick 7ec422b Revert "Remove thousands separator on import" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/253830 [05:28:59] (PS2) Eileen: Fix reports save a copy link [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/253830 [05:31:44] Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Reports "Save a Copy" is broken - https://phabricator.wikimedia.org/T117166#1813019 (Eileenmcnaughton) A couple of commits added - I also noticed that when you choose 'update' fro... [07:06:30] Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising-Backlog: Track email clickthroughs on donate wiki - https://phabricator.wikimedia.org/T114010#1813128 (CCogdill_WMF) @awight I would prefer to wait until the data piece is ready. We're currently sending 200k - 400k emails a... [10:54:45] Fundraising-Backlog, Editing-Analysis: Investigate using Optimizely for UI A/B testing - https://phabricator.wikimedia.org/T76917#1813364 (Qgil) [13:15:04] Fundraising-Backlog: Other amount in WMF donation form: error message unclear - https://phabricator.wikimedia.org/T118741#1813530 (Pcoombe) Open>Resolved Okay, solved. We never had the code to strip out currency symbols in donatewiki that we had in banners. I've added it to make them both the same. I g... [13:19:47] Fundraising-Backlog: Other amount in WMF donation form: error message unclear - https://phabricator.wikimedia.org/T118741#1813535 (MBeat33) @Pcoombe that's great, many thanks. [13:33:22] Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising Tech Backlog, Fundraising-Backlog, and 4 others: Slow searches: Transaction by ID # using % and also Contribs by email address - https://phabricator.wikimedia.org/T117492#1813551 (MBeat33) Thank you, @Eileenmcnaughton.... [14:12:57] Fundraising Sprint X-Ray Spex, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, FR-GlobalCollect: Determine what was breaking GlobalCollect in paymentswiki 3730cff20 - https://phabricator.wikimedia.org/T118349#1813577 (AndyRussG) a:AndyRussG [14:21:37] Fundraising-Backlog: portions of CC#s in Civi donor name fields: possible to update DataValidator? - https://phabricator.wikimedia.org/T118943#1813588 (MBeat33) NEW [16:08:48] Fundraising research, Analytics-Backlog, Research-and-Data: FR tech hadoop onboarding - https://phabricator.wikimedia.org/T118613#1813841 (Nuria) @DarTar: Regarding hive tutorials, we can help as @madhuvishy said. Now, I would ask that before anything they read slides of our prior classes: http://commo... [16:26:11] Fundraising research, Research management, Research-and-Data: Hire FR data analysis contractor - https://phabricator.wikimedia.org/T118957#1813864 (DarTar) NEW a:ellery [16:32:58] Fundraising research, Analytics-Backlog, Research-and-Data: FR tech hadoop onboarding - https://phabricator.wikimedia.org/T118613#1813885 (DarTar) @atgo copying you as Katie is on vacation, see first item in the task description. [16:43:33] Hi AndyRussG! I'm going to be incommunicado at 1:30 - would you be able to give our team's update at Scrum-o-Scrums today? [16:50:31] cwd: if AndyRussG is unavailable, would you be able to represent us at Scrum of Scrums in 40 minutes? [16:50:53] lemme see... [16:51:10] sure i can do that [16:51:31] thanks! [16:51:48] i'll send you the invite [16:51:57] ejegg|travel: great! [17:15:20] * awight waves at ejegg|travel [17:15:37] ejegg|travel: don't give up on vacation! [17:16:50] hi awight! how's thangs? [17:18:27] Pretty good--I thought the WMF was going to devour itself over the weekend, but IMO people are actually talking through their differences [17:18:42] not sure I've seen that work ever before ;) [17:20:27] well /that's/ certainly good to hear! [17:21:40] * cwd crosses fingers [17:31:10] awight, XenoRyet anything for scrum of scrums? [17:33:45] doesn't seem like anyone is there, hope i have the right link [17:34:09] nothing unusual to mention, that I can think of [17:34:44] i must not have the right link, i see people typing in the etherpad but hangouts says i'm the first one there [17:37:09] Looks like it's from 10:30-11:00 Pacific? [17:37:13] (in an hour) [17:37:34] oh shoot, sorry! time zone fail [17:37:38] ooh, haha! [17:37:52] nice when problems can get solved like that [17:44:53] Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising-Backlog, Patch-For-Review: Dedupe data in Silverpop file - https://phabricator.wikimedia.org/T107045#1814198 (awight) @CCogdill_WMF I've deployed a fix which seems to have worked for donor cid=11324355... Please let us... [18:24:43] ejegg|travel: yes of course--I saw your e-mail, sorry for not replying before you left! [18:24:52] ejegg|travel: you're the one who added stuff to the etherpad? [18:25:00] awight: ? ^ [18:25:29] Also: awight ejegg|travel cwd XenoRyet atgomez dstrine: anything to bring up at Scrum-of-scrums? [18:25:57] AndyRussG: i just did actually [18:26:06] i was gonna go but feel free, i'm in the FR retro right now [18:27:12] Nothing from me [18:27:21] cwd: XenoRyet: k thanks! [18:27:36] cwd: looking forward to hearing how that goes, too! [19:03:07] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Engage Import Issue - https://phabricator.wikimedia.org/T118909#1814436 (LeanneS) p:Triage>Unbreak! [19:07:07] Fundraising Sprint X-Ray Spex, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Engage Import Issue - https://phabricator.wikimedia.org/T118909#1814458 (awight) gah! [19:08:43] AndyRussG: remind them fundraising is happening ;) [19:09:13] emails are already going out, etc.. if deployments are on the table for january they should check with fr-tech and greg g. If there's any front-end implication, should check with Megan. [19:09:21] but generally refer to Katie's email [19:17:12] atgomez: ooof too late to make the call in those terms... I did mention it and others mentioned code freezies [19:17:24] (meeting finish't) [19:20:45] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: JPMorgan Import Issue - https://phabricator.wikimedia.org/T118981#1814508 (LeanneS) NEW [19:23:44] Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising Tech Backlog, Fundraising-Backlog, and 4 others: Slow searches: Transaction by ID # using % and also Contribs by email address - https://phabricator.wikimedia.org/T117492#1814519 (Eileenmcnaughton) I think the code chan... [19:24:52] hey all Leanne added the JP morgan import issue to the backlog ^^^^ should this be in the sprint too? [19:26:15] sure [19:26:29] Fundraising Sprint X-Ray Spex, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: JPMorgan Import Issue - https://phabricator.wikimedia.org/T118981#1814521 (awight) [19:26:31] scary stuff [19:26:37] Those two import bugs are closely related [19:26:44] :( [19:26:44] assigning myself... [19:27:03] Fundraising Sprint X-Ray Spex, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: JPMorgan Import Issue - https://phabricator.wikimedia.org/T118981#1814524 (awight) a:awight [19:27:15] Fundraising Sprint X-Ray Spex, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Engage Import Issue - https://phabricator.wikimedia.org/T118909#1814525 (awight) a:awight [19:44:24] no worries AndyRussG. i think people know :P [19:44:38] atgomez: yeah that was totally the impression I got [20:07:51] (CR) XenoRyet: Make LYBUNT report work for calendar and fiscal year (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/253808 (https://phabricator.wikimedia.org/T88819) (owner: XenoRyet) [20:14:30] (CR) Awight: Make LYBUNT report work for calendar and fiscal year (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/253808 (https://phabricator.wikimedia.org/T88819) (owner: XenoRyet) [20:45:07] (PS1) Awight: Prevent PHP timeout when importing large files [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/253975 (https://phabricator.wikimedia.org/T118981) [20:45:24] Urgent and easy CR ^ [20:49:15] (CR) XenoRyet: [C: 2] Prevent PHP timeout when importing large files [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/253975 (https://phabricator.wikimedia.org/T118981) (owner: Awight) [20:49:42] awight: That'll do the trick. [20:58:41] XenoRyet: thanks! [21:00:13] (PS1) Awight: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/254018 [21:00:28] (CR) Awight: [C: 2] Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/254018 (owner: Awight) [21:02:56] (Merged) jenkins-bot: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/254018 (owner: Awight) [21:22:25] fundraising-tech-ops: Need a dev_fredge database on the staging server - https://phabricator.wikimedia.org/T116879#1815104 (Jgreen) a:Jgreen [21:52:51] Fundraising-Backlog, fundraising-tech-ops: Confirm that the production Civi box is compatible with SHA-256 certificates - https://phabricator.wikimedia.org/T117642#1815192 (Jgreen) a:Jgreen [21:56:42] Fundraising Tech Backlog, Fundraising-Backlog, fundraising-tech-ops: Orphan slayer cron should spam us with failmail if there are errors - https://phabricator.wikimedia.org/T109885#1815199 (Jgreen) FWIW we're invoking cron job like this, so it should mail to fr-software-engineers if there's output on... [21:59:08] Fundraising Tech Backlog, Fundraising-Backlog: Orphan slayer cron should spam us with failmail if there are errors - https://phabricator.wikimedia.org/T109885#1815209 (Jgreen) [22:03:33] Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Remove Engage Civi users and revoke SSL keys - https://phabricator.wikimedia.org/T114797#1815228 (Jgreen) Please let me know which users are being removed so I can revoke their certs. [22:09:15] fundraising-tech-ops: paypal gateway log messages should be bucketed - https://phabricator.wikimedia.org/T113308#1815247 (Jgreen) a:Jgreen [22:09:40] fundraising-tech-ops: payments-payflow* log files can be deprecated - https://phabricator.wikimedia.org/T113309#1815248 (Jgreen) a:Jgreen [22:11:29] Fundraising-Backlog, fundraising-tech-ops: Replicate silverpop export (barium) on lutetium - https://phabricator.wikimedia.org/T103740#1815257 (Jgreen) a:Jgreen [22:18:51] Fundraising-Backlog, fundraising-tech-ops: Replicate silverpop export (barium) on lutetium - https://phabricator.wikimedia.org/T103740#1815275 (Jgreen) I don't recall why we decided to make the silverpop database instances on lutetium vs fundraisingdb (db1025) independent. But bear in mind if we make lut... [22:20:41] Fundraising-Backlog, fundraising-tech-ops: Replicate silverpop export (barium) on lutetium - https://phabricator.wikimedia.org/T103740#1815276 (CCogdill_WMF) I think so... As long as I can still run queries off it, that's all I need. [22:23:05] adyen test mode works [22:23:19] i remain pretty impressed with them [22:25:30] woot! [22:44:07] !log Updating fundraising/crm from 230cebb4a3b46a75fef758d46f4db22de29286cb to 67b855cbce358d215b8025da6fe7031bf3d221d9 [22:44:13] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:49:49] Fundraising Sprint X-Ray Spex, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work, Patch-For-Review: JPMorgan Import Issue - https://phabricator.wikimedia.org/T118981#1814508 (awight) @LeanneS Thanks for making two separate bugs! I found that the JP Morgan import crashed... [22:52:37] Fundraising Sprint X-Ray Spex, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work, Patch-For-Review: JPMorgan Import Issue - https://phabricator.wikimedia.org/T118981#1815350 (LeanneS) Thank you, Adam! Can I attempt to import the same file again so that the rest of the do... [23:07:02] Fundraising Sprint X-Ray Spex, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work, Patch-For-Review: JPMorgan Import Issue - https://phabricator.wikimedia.org/T118981#1815406 (awight) That's supposed to be safe at all times, you can always import a file twice without crea... [23:16:20] Anyone else having trouble connecting to the Civi site? [23:16:47] checking [23:17:12] and it's back! [23:17:24] Looks like the db was locked up [23:17:48] Yea, I had trouble right at the start there, but back for me now too. [23:18:15] Fundraising Sprint X-Ray Spex, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work, Patch-For-Review: JPMorgan Import Issue - https://phabricator.wikimedia.org/T118981#1815438 (awight) That's supposed to be safe at all times, you can always import a file twice without crea... [23:56:54] (PS1) Awight: Fix undefined variable warning [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/254073 [23:57:18] Fundraising research, Analytics-Backlog, Research-and-Data: FR tech hadoop onboarding - https://phabricator.wikimedia.org/T118613#1815565 (atgo) Sure - the list of fr-tech engineers is: agreen, awight, cdentinger, dkozlowski, eeggleston. I'd also love any additional tutorials that are available. Who i... [23:59:40] (CR) jenkins-bot: [V: -1] Fix undefined variable warning [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/254073 (owner: Awight)