[00:00:11] No worries! LOL that would be a riot to have your mum in the boardroom [00:00:18] :-) [00:00:41] I actually have to go afk for about 15-20 mins. Can we do it when I get back? If not I'll just catch up next time. [00:00:51] works for me [00:00:56] I'll calendar it [00:00:56] Got a childcare interview real fast. [00:01:00] Cool [00:01:09] sorry I messed that timing up didn't I? [00:01:19] Na, not a big deal. [00:03:08] XenoRyet: have you not deployed to production yet? [00:04:04] Invited! [00:06:44] dang i have to run in a minute...i deployed civi once many moons ago [00:06:59] i feel like it was more or less the same as the other projects? [00:07:18] update submodule in crm [00:07:27] run the scripts [00:19:04] (PS1) Ejegg: Move default currency fallback to data normalization [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/254338 (https://phabricator.wikimedia.org/T119120) [00:26:01] cwd|afk: you got it! [00:27:05] Back now. [00:27:14] I have deployed DI before, never Civi though. [00:27:50] cool. Same deal [00:28:35] cool [00:34:26] (PS1) Awight: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/254341 [00:34:53] (CR) Awight: [C: 2] Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/254341 (owner: Awight) [00:35:29] (CR) Awight: [V: 2] Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/254341 (owner: Awight) [00:37:07] (PS1) Ejegg: Replace rubbish data in currency code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/254343 (https://phabricator.wikimedia.org/T119120) [00:37:32] !log Updating fundraising/crm from e486ba424092866cdd8a15d26aeb17a412cd631a to f867beecd3a4fb596e2d08c8d2b0e4173ad0b356 [00:37:38] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [00:37:41] think those last two commits should solve the thing awight found [00:43:52] ok, I'm signing off for now. If those things get merged I can try to deploy later [00:51:43] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, and 3 others: Edits to LYBUNT report - https://phabricator.wikimedia.org/T88819#1021048 (XenoRyet) @CaitVirtue This fix was just deployed to production. Let me know how it wo... [01:25:40] Fundraising Sprint X-Ray Spex, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CiviCRM upgrade: Donation Processing: no refund button after clicking Edit transaction - https://phabricator.wikimedia.org/T116317#1819671 (Eileenmcnaughton) a:Eileenmcnaughton [01:33:07] (PS1) Eileen: fix missing arg on upgrade [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/254356 (https://phabricator.wikimedia.org/T116877) [01:33:27] (PS1) Awight: WIP Another attempt at fixing the dedupe issue [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/254357 (https://phabricator.wikimedia.org/T107045) [01:33:58] Fundraising Sprint X-Ray Spex, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Civi error while running module schema upgrade - https://phabricator.wikimedia.org/T116877#1819678 (Eileenmcnaughton) [01:34:13] Fundraising Sprint X-Ray Spex, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Civi error while running module schema upgrade - https://phabricator.wikimedia.org/T116877#1760304 (Eileenmcnaughton) Looks like this was a trivial one so pushed up a fix on it [01:36:15] Fundraising Sprint William Shatner, Wikimedia-Fundraising-CiviCRM: Apply CiviCRM security patches - https://phabricator.wikimedia.org/T117917#1819684 (Eileenmcnaughton) Open>Resolved [01:39:31] (CR) Awight: "This is better! Fallback doesn't seem to work, though?" (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/254338 (https://phabricator.wikimedia.org/T119120) (owner: Ejegg) [01:44:39] (CR) Awight: [C: 2] "Ok, fallback works for known currencies." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/254338 (https://phabricator.wikimedia.org/T119120) (owner: Ejegg) [01:45:24] (Merged) jenkins-bot: Move default currency fallback to data normalization [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/254338 (https://phabricator.wikimedia.org/T119120) (owner: Ejegg) [01:50:18] (CR) Awight: [C: -1] "Fussing over deck chairs" (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/254343 (https://phabricator.wikimedia.org/T119120) (owner: Ejegg) [01:50:48] (CR) Awight: "Also: although my fallback currency is set to USD, I'm getting all garbage currencies repopulated as BRL and donno why." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/254343 (https://phabricator.wikimedia.org/T119120) (owner: Ejegg) [02:03:08] XenoRyet: can you fix file perms on staging at some point - I tried to switch back to master & there are a bunch of files you own that I don't have write access on [02:03:45] Oops, didn't know that had happened. Yea, I'll fix it. [02:04:29] ta [02:05:01] XenoRyet: I think we're standardizing on: umask 002 in yr profile [02:05:54] do you know anything about server "rigel" just going down and coming back? [02:18:28] eileen: I put staging back on master. My linux noobishness is showing though, I don't know how to set unmask 002 in my profile. [02:23:42] XenoRyet: I was going to say I had it set in ~/.profile [02:23:48] but what I see is … #umask 022 [02:25:13] I just removed the # & it seems to work [02:38:44] eileen: Ok, I think I've fixed it all. Can you get to what you need? [02:42:49] (PS1) Eileen: Add upgrade hook to remove duplicate 'Refunded' contribution status [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/254364 (https://phabricator.wikimedia.org/T116317) [02:43:15] XenoRyet1 yeah I'm all good [02:44:18] Cool. Sorry for the hassle [02:46:44] well actually I've just realised files owned by ejegg|away are now blocking a pull :-) [02:48:36] (CR) Eileen: "Note I want to test this on staging - I'm hitting some file permissions there are at the moment." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/254364 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [02:50:15] mutante: I do (pm) [02:51:41] Fundraising Sprint X-Ray Spex, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: CiviCRM upgrade: Donation Processing: no refund button after clicking Edit transaction - https://phabricator.wikimedia.org/T116317#1819752 (Eileenmcnaughton) I've added an upgrade hook to the delete... [03:38:49] Fundraising Sprint X-Ray Spex, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: CiviCRM upgrade: Donation Processing: no refund button after clicking Edit transaction - https://phabricator.wikimedia.org/T116317#1819798 (Eileenmcnaughton) My reservation with continuing to record... [05:07:13] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Criteria Sort in Advanced Search results doesn't work - https://phabricator.wikimedia.org/T118614#1819873 (Eileenmcnaughton) I did a little bit of digging on this and it is actually a search setting which WMF has deselected (presumably for performance).... [10:24:20] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Regression: CentralNotice setting class=cn-undefined - https://phabricator.wikimedia.org/T118348#1820261 (revi) [13:02:17] Fundraising Sprint X-Ray Spex, Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review: Silverpop import not importing entire database? - https://phabricator.wikimedia.org/T119105#1820423 (CCogdill_WMF) @awight looks like this didn't work. The file is back to importing ~5.4m rows (still about... [16:32:04] my home internet is bordering on useless today for some reason [16:32:30] up to 50% packet loss to about 50% of resources, seemingly unrelated [16:32:35] #centurylink [16:35:00] wow, according to speedof.me, 290k/30k @197ms latency [16:44:54] (CR) Ejegg: "d'oh - betting the BRL thing is some cross-test contamination due to dumb TestingGenericAdapter statics. I think this flow is good, but I" (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/254343 (https://phabricator.wikimedia.org/T119120) (owner: Ejegg) [16:49:09] Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Civi quick search by email doesn't work - remove label to alleviate confusion. - https://phabricator.wikimedia.org/T118036#1820841 (CaitVirtue) @eileenmcnaugh... [16:56:26] (PS2) Ejegg: Replace rubbish data in currency code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/254343 (https://phabricator.wikimedia.org/T119120) [17:00:23] (PS3) Ejegg: Replace rubbish data in currency code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/254343 (https://phabricator.wikimedia.org/T119120) [17:01:16] (CR) jenkins-bot: [V: -1] Replace rubbish data in currency code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/254343 (https://phabricator.wikimedia.org/T119120) (owner: Ejegg) [17:02:23] (CR) Ejegg: [C: 2] "Nice catch!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/253829 (owner: Eileen) [17:05:30] (PS3) Ejegg: Fix reports save a copy link [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/253830 (https://phabricator.wikimedia.org/T117166) (owner: Eileen) [17:05:48] Wikimedia-Fundraising: Back button breaks the banner form - https://phabricator.wikimedia.org/T114391#1820894 (Pcoombe) I can't reproduce this in Chrome, but can in Firefox. [17:16:39] ejegg: wrt getting adyen to point to our hosted stylesheet, have you confirmed that they will do that or should i add it to an email? [17:19:43] also wrt the iframe taking over the original payment form instead of tacking on to the bottom, i see this in the js: [17:19:49] >--->--->--->--->--->---// Empty the div; add the target iframe; then submit the request for the iframe contents [17:19:51] >--->--->--->--->--->---$payment.empty(); [17:20:05] so i'm guessing it was a design decision rather than a side effect? [17:20:07] Hi cwd [17:20:32] Oh, huh, I guess so! Sorry, didn't think I'd seen it do that before [17:20:43] morning! sorry to be all business [17:20:47] Or... was that a different div in the original form? [17:21:15] hrm, maybe? i think i remember it behaving the same way with the original [17:21:16] So, I think the way to use our hosted stylesheet is just to add a in the header.inc [17:21:50] and strip out as much of the adyen-hosted skin stylesheet as we can [17:22:31] aah, gotcha i see that now [17:22:52] sadly some of their css is "behavioral" in that it shows/hides stuff [17:23:06] makes the cvv tooltip float on top etc [17:30:57] (CR) Ejegg: "Couple of questions inline. Also, would it make sense to have the list action still allow them to change the name and parameters of the c" (3 comments) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/253830 (https://phabricator.wikimedia.org/T117166) (owner: Eileen) [17:31:39] cwd ah, ok. So just our custom stuff in the hosted file. If it's in header.inc, it'll be loaded after and override theirs. [17:33:40] ejegg: since there's no version history i can't really tell but i think some of it is ours but most of it is probably their css [17:33:51] if i remove the stylesheet entirely the iframe isn't really usable [17:36:16] cwd we could create a new skin and diff it? [17:36:41] ejegg: good idea [17:37:17] (CR) Ejegg: "could also initialize the one cdentinger suggests, but not necessary with the logic as is." (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/254073 (owner: Awight) [17:44:06] ejegg: compared to some other skins we already have, definitely appears that these are 90% boilerplate, but a bunch of that boilerplate has been hacked on [17:44:15] having it hosted here and in version control sounds like a big win [17:45:08] definitely! [17:46:02] You prefer blanking the whole adyen-hosted one and moving it all to git, or leaving a vanilla one on adyen and only hosting our overrides? [17:46:19] i wonder if we could just blank out their stylesheets and only use the one in the header. looks like they pass a reset stylesheet first, and seems like we'd basically want another reset before ours [17:46:56] Hmm, I don't think we can override their link tags in the head [17:47:22] I think self-hosting will have to add an extra http request [17:48:03] come to think of it that might not play nice with ad blockers and antivirus [17:48:42] you mean requesting css from our domain in an iframe on their domain? [17:48:49] yeah [17:49:30] huh, I hadn't thought of that. Does that really trigger such things? [17:49:47] at least they'd both be https [17:49:56] yeah, that's the biggest thing [17:50:07] but i've definitely seen it happen with aggressive browser plugins [17:50:43] like i think you can have privacy badger reject 3rd party content entirely [17:51:01] which probably breaks half the internet [17:51:22] also would be slightly annoying to develop css changes - we'd need to keep a second copy of the skin where devs could point the link at localhost [17:51:56] actually, nah, we can mess with the test copy and just not publish it [17:52:57] you looks like you can have a separate dev skin [17:54:07] maybe just hacking up screen.css is the easiest, but putting it in git [17:54:44] I think we do self-hosted css with GC or Worldpay [17:55:57] i asked worldpay about it and they said it would be out of PCI scope, but their workflow is email them a css file and pray so... [17:56:25] oh, huh [18:15:16] (PS1) Cdentinger: make iframe behave more like worldpay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/254437 [18:29:56] (PS1) Cdentinger: commit screen.css [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/254441 [18:37:13] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: iframe not appearing for some people (confirmed modern browsers) - https://phabricator.wikimedia.org/T112181#1821210 (Ejegg) I just reproduced screenshot #2 in an up-to-date version of Midori, a stripped-down version of Firefox. It looks like... [18:41:20] the ejegg for the update to T112181 - great stuff! [18:41:37] *thx [18:41:49] just stumbled across it, but it's great to have a lead! [18:42:58] If it is fixed in core, though, a major version upgrade right before big EN is going to be a hard sell :( [18:43:16] with luck, some tiny fix we can backport [18:44:54] even a little step fwd is awesome [19:16:26] Fundraising-Backlog, fundraising-tech-ops: Replicate silverpop export (barium) on lutetium - https://phabricator.wikimedia.org/T103740#1821384 (Jgreen) Can someone point me to the scripts that are in use? I want get a look at how they're using the databases. [19:21:47] Awight: is the data in drupal.contribution_source kosher? [19:31:09] Fundraising Sprint X-Ray Spex, Fundraising-Backlog, fundraising-tech-ops: Format Monolog messages to be easier to grep, bucket them - https://phabricator.wikimedia.org/T115746#1821442 (Jgreen) >>! In T115746#1818510, @awight wrote: > @Jgreen > The new message format is deployed. These errors are very... [19:39:22] ejegg: hi! how's it going? got a minute sometime to help me smoke test your GlobalCollect patch? I think I have all the info and permissions and setup now, but I'm not sure of how to use the power [19:41:28] Fundraising-Backlog, fundraising-tech-ops: Replicate silverpop export (barium) on lutetium - https://phabricator.wikimedia.org/T103740#1821476 (Ejegg) @Jgreen, here are the scripts: https://git.wikimedia.org/blob/wikimedia%2Ffundraising%2Ftools.git/master/silverpop_export%2Fupdate_table.sql We only cop... [19:41:36] Hi AndyRussG! [19:41:49] the currency_code thing, right? [19:42:10] ejegg: no, the error page one [19:42:11] https://phabricator.wikimedia.org/T118349 [19:42:21] ah, right [19:42:32] https://gerrit.wikimedia.org/r/#/c/254181/ [19:42:33] I really should have stuck to logging only :( [19:42:53] ejegg: well, those logs look like they might be error conditions, no? [19:43:33] Sure, but I think the logger calls are safe. Not as certain about adding that fallthrough redirect [19:44:10] Also, I still can't figure out how the log sequence in the ticket could have happened! [19:45:17] Hmm yeah worth figuring out, no? I mean, the redirect seems logical, unless the user would be notified of the error some other way? [19:46:49] It's just that after logging 'Displaying thank you page for final status complete', the page should immediate set $go to $adapter->getThankYouPage(), then a few lines down send them there. [20:13:48] ejegg cwd AndyRussG XenoRyet did you see that CC bounced this one back? https://phabricator.wikimedia.org/T119105 [20:13:50] still unbreak now [20:14:17] Will take a look in one sec! [20:14:17] dstrine-lunch: heads up ^ [20:14:25] thanks ejegg! [20:14:34] hmm, dang [20:15:18] dang indeed [20:15:29] dangdeed? [20:15:30] atgomez: OK, so awight undid his fix, which caused the big drop in numbers [20:15:45] we should probably figure out a better process for gettting "unbreak now" stuff into visibility, too [20:15:55] ejegg: yeah but it didn't actually solve the problem [20:16:00] but my earlier attempt at correcting the latest date is still in there and still wrong [20:16:00] if you see caitlin's last comment [20:16:19] So I can undo that as well, which would get us back to where we were a couple weeks ago [20:16:46] with a (presumably smaller) number of donors that have bad 'latest donation' stats [20:17:41] I'll prep that rollback just in case, but also look for a real fix [20:18:51] thanks ejegg, much appreciated [20:20:24] ejegg: atgomez: XenoRyet: cwd: dstrine-lunch: I'll just be on-and-offline on IRC for a bit while I turn on my full VPN [20:26:29] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: iframe not appearing for some people (confirmed modern browsers) - https://phabricator.wikimedia.org/T112181#1821676 (Ejegg) Testing a DonationInterface page in Midori locally in trunk gave the same error, but if I browse en.wikipedia.org with... [20:31:30] Fundraising Sprint X-Ray Spex, Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review: Silverpop import not importing entire database? - https://phabricator.wikimedia.org/T119105#1821691 (Ejegg) Sorry @CCogdill_WMF, we really should have been testing the data more than a few spot checks. At... [20:50:45] Fundraising research, Research management, Research-and-Data: Set up private project for FR analysis - https://phabricator.wikimedia.org/T119148#1821746 (DarTar) p:Normal>High [21:26:22] (CR) Cdentinger: [C: 2] Stomp job runner fix and loop refactor [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/251728 (owner: Ejegg) [21:26:52] i've been running away quickly to not impinge on BS time [21:26:54] (Merged) jenkins-bot: Stomp job runner fix and loop refactor [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/251728 (owner: Ejegg) [21:33:24] Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising-Backlog, Patch-For-Review: Dedupe data in Silverpop file - https://phabricator.wikimedia.org/T107045#1821854 (MBeat33) @awight, @ccogdill the bulk email complaint rate for this week is roughly 15%. We are seeing enough u... [21:33:42] dstrine: i actually do have a sump pump in the crawl space but there isn't any standing water, just literal tons of mud [21:34:03] ugh sorry dude [21:34:07] that sucks [21:34:14] heh, oh well [21:34:54] can you get someone to come in and grade the crawlspace so it drains out and away from the house? [21:35:23] it's dug about 4' below ground level [21:35:32] and i live on a steep hill [21:36:12] it was dry down there when i moved in, no mud whatsoever, but then this happened: https://en.wikipedia.org/wiki/2013_Colorado_floods [21:36:20] and i haven't been able to dry it out since [21:40:30] wow [22:36:09] (PS1) AndyRussG: WIP impressionDiet: handle deployed problem for campaign categories using legacy [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/254585 [22:37:11] Fundraising Sprint X-Ray Spex, Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review: Silverpop import not importing entire database? - https://phabricator.wikimedia.org/T119105#1821977 (CCogdill_WMF) Thanks, @Ejegg, and no worries about spot checking. This is new territory for all of us. I... [22:37:22] ejegg: cwd: XenoRyet: ^ It's marked "WIP" 'cause I still want to double-smoke-test all the possible circumstances, but if u'd like to start checking it out, that'd be hugely appreciate!!! :) [22:37:41] And apologies for this misstayck [22:37:52] dstrine: ^ [22:39:56] d [22:40:00] (the missing 'd') [22:40:46] ejegg: fyi, https://gerrit.wikimedia.org/r/#/c/254357/ [22:41:07] I let it run in my database on the staging server, lemme take a look at the results... [22:41:56] d'oh [22:42:11] final count: 666k rows in silverpop_export [22:42:31] But I think I'm on the threshold of cracking the "latest" nut [22:43:53] ah, awesome! [22:46:42] oof [22:46:57] I panicked and dropped all my tables before learning from what was missing [22:47:06] will run again now.... [22:48:10] rawCookie [22:48:13] e coli warning [22:55:57] cwd: heheheh it's got egg! [22:56:00] don't eat the batter! [22:57:13] but it's so delicious! [23:10:12] hey ejegg I know it's a bit later for you. Is there a call to fix or roll back on https://phabricator.wikimedia.org/T119105 [23:11:28] you sounded like you were way more in the roll back camp at standup [23:12:01] dstrine: awight has a wip and I'm playing with another - not giving up just yet! [23:12:32] next run of the exporter is early morning, so no need to rush to judgement [23:12:33] kk just thinking about your time.. on a friday...evening :) [23:12:54] heh, thanks! No plans for the night, still catching up on sleep from nola... [23:13:02] lol [23:13:04] cool [23:19:46] dstrine: We rolled back most of the way yesterday... ejegg: unless you were worried about the earlier "latest" fixes? [23:21:58] It sounded like the latter.. [23:26:29] awight|off: yeah, I think they still don't want to procede with my 'having' glich [23:26:48] I think that actually /increased/ the number of incorrect donations [23:26:56] I rolled that one back, eh? [23:27:27] nope. [23:27:36] sorry to leave you with a Friday mess! [23:28:13] I'm running my "fix" on lu now, currently at the climactic two queries. [23:28:22] #16 [23:28:38] after dedupe happens, I'll be able to say whether this version is garbage or not [23:33:08] oh shoot, I didn't realize1 [23:33:09] ! [23:36:09] awight|off: nope, my flawed "Fix 'latest donation' logic" is not reverted in deploy [23:36:50] Fundraising research, Project-Creators, Research-and-Data: Spaces request for Fundraising Research - https://phabricator.wikimedia.org/T119258#1822186 (DarTar) [23:37:03] ejegg: yes sorry I see that too [23:37:22] Fundraising research, Project-Creators, Research-and-Data: Spaces request for Fundraising Research - https://phabricator.wikimedia.org/T119258#1822196 (DarTar) p:Triage>High [23:38:19] Fundraising research, Project-Creators, Research-and-Data: Spaces request for Fundraising Research - https://phabricator.wikimedia.org/T119258#1822176 (DarTar) Flagging this as high priority/time sensitive as it's a requirement for coordinating data analysis for the Big English FR campaign which is sta... [23:52:18] Fundraising research, Research management, Research-and-Data: Set up private project for FR analysis - https://phabricator.wikimedia.org/T119148#1822235 (DarTar) Open>Invalid Closing as duplicate of T119258