[00:00:22] Fundraising research, Phabricator, Project-Creators, Research-and-Data: Spaces request for Fundraising Research - https://phabricator.wikimedia.org/T119258#1822270 (Krenair) [00:12:43] (PS2) AndyRussG: impressionDiet: handle deployed problem for campaign categories using legacy [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/254585 [00:14:40] cwd|afk: ejegg: XenoRyet: ^ Now out of WIP.... A wee nudge before Monday morning would help put this on the morning SWAT deploy ;) thx in advance!!! [00:14:51] atgomez: ^ [00:15:03] taking a look! [00:15:12] ejegg: weeeee thanks so much!!! [00:19:47] Fundraising research, Phabricator, Project-Creators, Research-and-Data: Spaces request for Fundraising Research - https://phabricator.wikimedia.org/T119258#1822335 (greg) I assume it should be separate from the normal fundraising space (I presume there is one)? If so (eg: not everyone in fund-resear... [00:23:15] (CR) Ejegg: "logic looks sound, just a missing semicolon" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/254585 (owner: AndyRussG) [00:23:15] Fundraising research, Phabricator, Project-Creators, Research-and-Data: Spaces request for Fundraising Research - https://phabricator.wikimedia.org/T119258#1822354 (Krenair) Weren't normal fundraising just using ad-hoc policies for everything? [00:24:49] thanks AndyRussG - can you please make sure to get an email out to fr-online about this today? [00:27:40] ejegg: too bad--the new query #16 is slooow [00:27:56] Fundraising research, Phabricator, Project-Creators, Research-and-Data: Spaces request for Fundraising Research - https://phabricator.wikimedia.org/T119258#1822363 (atgo) @krenair fundraising is using ad-hoc policies, displaying only to the #wmffr group. If there's a better workflow I'm open to chan... [00:28:28] awight|off: drat... [00:29:00] I don't actually have much of a variation [00:30:05] It's sort of mind-boggling that this is so difficult. Finding max(A) grouped by B seems like one of the most basic things you'd want to do [00:30:51] yeah... [00:33:36] trying a wacky thing with a compound key which is (email, index) where index is auto_increment [00:37:56] sounds interesting... [00:37:58] Fundraising research, Phabricator, Project-Creators, Research-and-Data: Spaces request for Fundraising Research - https://phabricator.wikimedia.org/T119258#1822405 (greg) (bad assumption by me, I didn't know the details, sorry for the confusion! I still think this is a good idea and should be done a... [00:38:14] Anyone else get atgomez's forward about the PayPal partnership? [00:38:20] I'm pretty sad about this. [00:39:24] Just read it myself [00:39:36] Doesn't seem like the kind of thing we should be doing. [00:40:29] yeah. Also really bad timing [00:45:12] atgomez: yes [00:45:17] ejegg: one sec, fixing... [00:48:01] (PS3) AndyRussG: impressionDiet: handle deployed problem for campaign categories using legacy [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/254585 [00:48:08] ejegg: ^ [00:48:30] atgomez: I'm just trying to get good data on the % affected [00:49:07] thanks AndyRussG [00:49:12] atgomez: likewise! [00:50:32] awight|off: which partnership? [01:05:38] (PS1) Ejegg: Fix 'latest donation' logic for real [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/254617 (https://phabricator.wikimedia.org/T107045) [01:06:16] awight|off: and ejegg how's T11905 going? [01:06:22] awight|off: That INSERT IGNORE was almost the right thing. Just needed an ORDER BY instead of the fancy stuff ^^^ [01:06:45] dstrine: I think that one should do it. I'm about to test on staging, unless awight|off is testing a different thing [01:06:54] cool! [01:10:41] ejegg: I'm in my own db, it's fine [01:11:02] wow, it's that simple? [01:11:05] k, i'm in ejegg. just worried about thrashing the db [01:11:32] awight|off: it's like I had two different ideas of how to do it and tried to bolt them both together... [01:13:00] ejegg: it's fine, that thing has 16 cpus and each of these jobs uses 1-2 cpus [01:13:30] disk & ram gonna be fine? Ehh, I can wait [01:16:21] ejegg: fwiw, http://ganglia.wikimedia.org/latest/?r=hour&cs=&ce=&c=Fundraising+eqiad&h=lutetium.frack.eqiad.wmnet&tab=m&vn=&hide-hf=false&m=cpu_report&sh=1&z=small&hc=4&host_regex=&max_graphs=0&s=by+name [01:16:31] oh, neat! [01:17:06] I've got a test to make sure we get the latest date right: https://phabricator.wikimedia.org/P2340 [01:17:28] fancy! [01:18:30] Just thinking what to do to check amounts and currency - would almost work to join on all and check counts, but duplicates may exist to throw that off [01:19:12] though I guess we can count the duplicates... [01:19:26] hrm, if we left the latest table, you could join on that [01:20:04] yeah, I'd like to compare the final product against the source data without assuming any of the work is correcy [01:20:07] *correct [01:29:05] yep [01:29:14] oof, I'm still on query #16 [01:29:18] I think that makes it 2 hours [01:29:53] wheee [01:54:17] how's it going? [01:58:40] ejegg: any news? [01:58:47] going slowly :P [01:58:52] but that's normal for this job [01:59:15] Think I'll watch a movie, then test the data some [02:00:10] wow ok.. wel..I'm not going stay on much longer. Are you able to email fr-online with the result? [02:00:28] per cogdil's comment they really need this for monday :/ [02:05:28] ejegg: ? ^ [02:16:34] ejegg: I'm going to run. Don't go too crazy this evening [02:20:36] OK, I'll email! [02:20:42] dstrine: ^^ [02:36:31] Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising-Backlog, Patch-For-Review: Dedupe data in Silverpop file - https://phabricator.wikimedia.org/T107045#1822543 (Ejegg) Some queries to test correctness of SilverPop export data are in P2340 [03:21:39] Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising-Backlog, Patch-For-Review: Dedupe data in Silverpop file - https://phabricator.wikimedia.org/T107045#1822569 (Ejegg) OK, ran the test queries on export generated by patch https://gerrit.wikimedia.org/r/254617. First one... [03:26:59] (PS2) Ejegg: Fix 'latest donation' logic for real [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/254617 (https://phabricator.wikimedia.org/T107045) [04:36:15] ejegg: hi! don't forget https://gerrit.wikimedia.org/r/#/c/254585/ :) [04:36:24] phew just finished filling out that survey.... [04:36:37] atgomez: good news, the problem affects only 0.06 % of users [04:36:48] about to write the e-mail now... [04:46:50] (PS1) Ejegg: Return from function after redirect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/254633 (https://phabricator.wikimedia.org/T118349) [04:48:15] Fundraising Sprint X-Ray Spex, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, and 2 others: Determine what was breaking GlobalCollect in paymentswiki 3730cff20 - https://phabricator.wikimedia.org/T118349#1822610 (Ejegg) Now 99% sure that fallthrough displayFail... [04:49:25] (CR) Ejegg: [C: 2] impressionDiet: handle deployed problem for campaign categories using legacy [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/254585 (owner: AndyRussG) [04:49:33] ejegg: weee thank!!! [04:55:11] ty for the fix AndyRussG [04:55:16] ejegg: np! [04:55:18] and have a good weekend [04:55:24] Thanks likewise!!! [16:40:07] Fundraising Sprint William Shatner, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work, Easy, and 2 others: mw.centralNotice.recordImpression causes exception when centralNotice banners are loaded (with Adblock Plus browser extension) - https://phabricator.wikimedia.org/T110182#1823100 (He7d... [16:50:26] Fundraising Sprint William Shatner, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work, Easy, and 2 others: mw.centralNotice.recordImpression causes exception when centralNotice banners are loaded (with Adblock Plus browser extension) - https://phabricator.wikimedia.org/T110182#1823108 (Andy... [16:50:40] Fundraising Sprint William Shatner, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work, Easy, and 2 others: mw.centralNotice.recordImpression causes exception when centralNotice banners are loaded (with Adblock Plus browser extension) - https://phabricator.wikimedia.org/T110182#1823109 (Andy... [18:10:11] (CR) Ejegg: "Yowza! Is there any discussion of making library dirs like bower_components and vendor into such modules?" [wikimedia/fundraising/crm/civicrm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/252462 (https://phabricator.wikimedia.org/T115925) (owner: Eileen) [18:11:18] (CR) Awight: [C: -1] "Looks good, but needs a manual rebase." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/235759 (https://phabricator.wikimedia.org/T111387) (owner: AndyRussG) [18:22:30] (CR) Awight: [C: 2] "I think it even works! Tested it on a tiny subset of known difficult cases. Thanks for solving!" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/254617 (https://phabricator.wikimedia.org/T107045) (owner: Ejegg) [18:22:48] (Merged) jenkins-bot: Fix 'latest donation' logic for real [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/254617 (https://phabricator.wikimedia.org/T107045) (owner: Ejegg) [18:22:53] (Abandoned) Awight: WIP Another attempt at fixing the dedupe issue [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/254357 (https://phabricator.wikimedia.org/T107045) (owner: Awight) [18:23:02] (CR) Awight: "Also: doesn't work ;-)" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/254357 (https://phabricator.wikimedia.org/T107045) (owner: Awight) [18:35:48] !log updated SmashPig from 55c2dbc8cd36cfb89d7e17b75b840ca2e023653e to d7534bde8c247a1e877a4bcd768b9963f89666d7 [18:35:54] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [18:43:01] !log rolled back SmashPig d7534bde8c247a1e877a4bcd768b9963f89666d7 --> 55c2dbc8cd36cfb89d7e17b75b840ca2e023653e [18:43:07] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [18:56:14] (PS1) Ejegg: Catch exceptions in LogEvent constructor [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/254658 [19:08:20] (PS1) Ejegg: Merge branch 'contrib' [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/254659 [19:11:10] (PS1) Ejegg: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/254660 [19:13:03] (CR) Ejegg: [C: 2 V: 2] Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/254660 (owner: Ejegg) [19:14:22] !log updated fundraising tools from d7253eb1c6c9478ce2cf8760279d2ad1b7f0a132 to ebed29c0eccf38c812b20a957b3487a15bfa9cbc [19:14:29] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [19:20:35] Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review: Failing SmashPig job runner should not act like a mid-1980s photocopy machine - https://phabricator.wikimedia.org/T117447#1823158 (Ejegg) Aargh. Latest patch sends a... [19:23:27] (PS1) Ejegg: Stop adding busted stuff to log context. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/254662 (https://phabricator.wikimedia.org/T117447)