[00:00:33] (Merged) jenkins-bot: CRM-17464 remove deadlock inducing query [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/255048 (https://phabricator.wikimedia.org/T119447) (owner: Eileen) [00:01:42] How on earth is $this->adapter not an object in tearDown? It's assigned to a TestingGenericAdapter in setUp and never re-assigned... [00:02:06] well, I'm going to try deploying the GC fix anyway [00:02:16] make sure that's OK [00:03:28] (CR) Ejegg: [C: 2 V: 2] Return from function after redirect [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/254920 (https://phabricator.wikimedia.org/T118349) (owner: Ejegg) [00:07:13] Fundraising-Backlog: Direct referral - Donate.wiki to Paypal - Donation flow of last resort - https://phabricator.wikimedia.org/T119472#1827168 (Jseddon) NEW a:awight [00:09:56] Fundraising-Backlog: Direct referral - Donate.wiki to Paypal - Donation flow of last resort - https://phabricator.wikimedia.org/T119472#1827179 (awight) a:awight>None Excellent idea! I believe @Jseddon says "donate.wiki" cos this came up in the context of a batch of bulk email which was impacted by a... [00:10:38] (PS2) Awight: Reset adapter account config in test setup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/248924 (owner: Ejegg) [00:11:01] (CR) Awight: [C: 2] Reset adapter account config in test setup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/248924 (owner: Ejegg) [00:11:23] ejegg: fwiw, ^ to see if other patches are affected. [00:11:27] thanks! [00:11:34] good candidate [00:12:10] ejegg: yeah really weird the tests are failing on that one, but i can reproduce [00:12:35] (Merged) jenkins-bot: Reset adapter account config in test setup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/248924 (owner: Ejegg) [00:12:42] cwd you can reproduce the failing tests? [00:12:50] yep [00:12:56] huh, I can't [00:12:57] and the clearglobalcache thing [00:13:09] i'll mess with it and figure out why [00:13:20] certainly none of the changes there look like they'd cause this [00:13:32] right? [00:13:32] Fundraising Sprint X-Ray Spex, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Look at porting patch to mitigate CiviCRM deadlocks - https://phabricator.wikimedia.org/T119447#1827189 (Eileenmcnaughton) a:Eileenmcnaughton [00:13:55] Fundraising Sprint X-Ray Spex, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Look at porting patch to mitigate CiviCRM deadlocks - https://phabricator.wikimedia.org/T119447#1826652 (Eileenmcnaughton) [00:15:24] awight, do we have phabricator cards for other SPOF? [00:15:25] wat [00:15:36] Seddon: yeah-- [00:16:15] hmm, full tunnel VPN may not be fully tunnelling [00:16:17] Seddon: https://phabricator.wikimedia.org/T108229 and https://phabricator.wikimedia.org/T86253 [00:19:37] gtg! [00:20:01] ditto [00:20:02] night all [00:21:05] see ya [00:35:16] (PS5) Ejegg: Replace rubbish data in currency code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/254343 (https://phabricator.wikimedia.org/T119120) [00:35:58] (CR) jenkins-bot: [V: -1] Replace rubbish data in currency code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/254343 (https://phabricator.wikimedia.org/T119120) (owner: Ejegg) [00:40:30] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/255056 [00:41:07] (CR) Ejegg: [C: 2 V: 2] Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/255056 (owner: Ejegg) [01:00:00] !log updated payments-wiki from ecbc49c63b259a4363c51491ddff273e3579f0e9 to 5358960d6857f589939c9b86ea37af168a4f8b0b [01:00:04] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [01:02:20] logs good so far [01:02:34] and I get the TY page on successful donation [01:03:45] Amazon's still good too [01:06:25] ejegg: this is an obscure one, if i change the line from DonationData back the tests pass but it's hard to debug phpunit [01:07:34] cwd: ??? so weird [01:09:22] AndyRussG: Oh, I see some lines in payments.debug that show the history log id processor is actually running [01:10:37] but I'm guessing all our traffic is from email right now, so there are no ids on the querystrings [01:10:43] ejegg: yeah i don't have a good way to get xdebug to catch that particular thread cause it's php calling php [01:11:13] I can't even reproduce the error [01:21:01] AndyRussG: I got a queue message to appear by faking the parameter [01:31:37] ejegg: wohoo! [01:32:50] ejegg: Hmmm I hadn't thought about e-mail traffic... what log messages are u seeing? [01:33:10] Ah in the debug log [01:33:13] just the debug one (Amazon is still at debug logging level) [01:37:13] AndyRussG: I don't see that param name in any of the scripts loaded with one random recent banner [01:38:59] Hmm.. Which banner? Do you see calls to ensureLogSent()? [01:41:20] yep, there's one of those [01:41:26] https://meta.wikimedia.org/wiki/MediaWiki:FR2013/Resources/BannerFormCore.js [01:41:34] Woops, looks like the param is different!!! Ohnoes [01:41:48] if ( mixins && mixins.bannerHistoryLogger ) { [01:41:48] params.banner_history_log_id = mw.centralNotice.bannerHistoryLogger.id; [01:41:48] } [01:41:55] oho! [01:42:02] I guess we can edit that pretty easily tho.... [01:42:04] well, that should be an easy fix! [01:42:08] yep! [01:42:23] would you like to do the honors? [01:44:09] (PS1) Cdentinger: WIP: publishing for visibility, don't merge this [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/255060 [01:44:22] Sure! [01:44:36] ejegg: ^ definitely not the right thing, but on the trail [01:44:55] (CR) jenkins-bot: [V: -1] WIP: publishing for visibility, don't merge this [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/255060 (owner: Cdentinger) [01:44:57] for the tests? Thanks for digging in to that! [01:45:23] you bet! i'll get to the bottom of it tomorrow, but i gotta go help with dinner [01:45:25] later! [01:45:40] thanks again! [01:47:16] ejegg: done! [01:47:25] nice! [01:47:50] There are low-level campaigns going on in a bunch of places, so we should start to see some real queue entries [01:48:47] (PS6) Ejegg: Replace rubbish data in currency code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/254343 (https://phabricator.wikimedia.org/T119120) [01:49:32] (CR) jenkins-bot: [V: -1] Replace rubbish data in currency code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/254343 (https://phabricator.wikimedia.org/T119120) (owner: Ejegg) [01:50:22] (PS7) Ejegg: Replace rubbish data in currency code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/254343 (https://phabricator.wikimedia.org/T119120) [01:51:27] cwd|afk: passing tests! thanks again [01:51:55] Funny when I saved the page on Meta, it said there were the script had errors [01:52:10] eek! [01:52:20] Probably some silly MW JS linter thing [01:52:30] didn't say what errors? [01:52:53] Ah yeah (just saw it clicking on edit again) it's just the