[00:00:06] ah, even better [00:00:08] which i fail to see how is in any way secure [00:00:34] heh, guess it's on the merchant to not be stupid [00:07:03] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Notifications for donations made on Major Gifts annual appeal landing page - https://phabricator.wikimedia.org/T119920#1840017 (CaitVirtue) [00:07:55] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add column to Engage Import: Direct Mail Appeal - https://phabricator.wikimedia.org/T119921#1840022 (CaitVirtue) [00:12:56] Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, fundraising-tech-ops, and 2 others: Format Monolog messages to be easier to grep, bucket them - https://phabricator.wikimedia.org/T115746#1840029 (awight) The only difference I see between my configuration and produ... [00:16:48] (PS1) Ejegg: Update filter dropdown values [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256145 [00:17:19] XenoRyet or cwd: another pretty trivial thing to increase relevance ^^^ [00:17:28] Looking [00:17:37] ty! [00:18:07] Really need to get those dynamically and cache them for a long while. But... not today [00:18:25] Agreed. That's a problem for another day. [00:18:53] (CR) XenoRyet: [C: 2] Update filter dropdown values [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256145 (owner: Ejegg) [00:21:08] ejegg: you have any qualms with me uploading new test skins for this bad boy? there's really no other way to test this unfortunately since element height gets calculated on page load and set by a script [00:21:27] nah, go right ahead! [00:21:49] that account can't touch any real money yet [00:22:21] oh hey, we can deploy DI too! [00:22:26] will get that prepped [00:22:36] great [00:23:01] still got awight's instacrash script deployed, but he can revert that later... [00:24:05] (Merged) jenkins-bot: Update filter dropdown values [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256145 (owner: Ejegg) [00:24:13] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/256146 [00:24:50] (CR) Ejegg: [C: 2 V: 2] "yee haw" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/256146 (owner: Ejegg) [00:26:25] * awight cowers behind the broken bottles [00:26:49] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/256147 [00:27:16] (CR) Ejegg: [C: 2 V: 2] Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/256147 (owner: Ejegg) [00:28:39] ooh, I see, awight, you only had the crashme deployed to staging [00:29:10] still testing the fatal error logging? [00:29:59] I am... it's not going so well [00:30:07] That code should be safe to keep, though [00:30:13] feel free to deploy to pay1-3 [00:30:25] thanks, will do! [00:31:50] err, you want me to leave staging alone for this deploy? nothing changing that should ever be running there [00:32:46] Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, fundraising-tech-ops, and 2 others: Format Monolog messages to be easier to grep, bucket them - https://phabricator.wikimedia.org/T115746#1840052 (awight) bd808 confirmed that PHP 5.3 is not able to catch these fata... [00:32:47] awight ^ ? [00:33:02] ejegg: might as well deploy them together [00:33:09] cool, ty [00:33:16] less stress for the next deployer... on that note, sorry to leave a mess! [00:33:39] no prob, this one's a pretty low-stress deployment [00:35:22] !log updated payments-wikifrom 7fb9d6599c3833f0a55500ab77abd2b7ffe74cfe to 02a3771cae6e4e74d9d754a8b075de20aa171adc [00:35:26] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [00:35:49] ok cwd, prod is now using sha256 [00:36:02] oh hey, I should point it to our new account/skin too [00:36:03] excellent, thanks! [00:36:45] i just uploaded the modified skin, setting the height of this div explicitly seems to get around that weird behavior [00:37:02] reeeeediculous [00:39:57] !log updated Adyen credentials on payments-wiki [00:40:01] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [00:40:04] cwd ^^ [00:41:04] ejegg: don't we need a new HMAC for prod? [00:41:35] we will [00:41:52] but I'd like to test the whole pipeline against their test system [00:42:06] which reminds me, I need to update credentials for SmashPig too [00:42:15] for the listener? [00:42:25] yep! [00:42:36] want to make it try the capture [00:44:47] righteous [00:45:08] !log updated Adyen credentials in SmashPig IPN listener [00:45:13] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [00:46:49] just looking at that new phab - how do we know if a donation came in through major gifts ?  https://phabricator.wikimedia.org/T119920 [00:49:35] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/256150 [00:50:14] (CR) Ejegg: [C: 2 V: 2] Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/256150 (owner: Ejegg) [00:50:49] Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising-Backlog: Donation form error message: "No processors available" - https://phabricator.wikimedia.org/T117872#1840088 (awight) I'm seeing this error every 10 seconds or so in the logs: > Nov 30 23:42:30 X globalcollect_gateway: 29... [00:51:46] !log updated fundraising dash from bc0ec4bb2427ebeb2d4cd60eda65e3d82d006937 to 2ee15180150c8b685b14abdbf7c6769736fb49a0 [00:51:50] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [00:53:22] I guess nothing is up with these ** PROBLEM alert - db1008/check_disk is CRITICAL ** alerts? [00:53:42] Fundraising Dash, Fundraising-Backlog: [epic] make Dash useful for December fundraising campaign - https://phabricator.wikimedia.org/T118048#1840092 (Ejegg) [00:53:43] Fundraising Dash, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Patch-For-Review: Update Big English widget to 2015 or make new one (to keep old version easy to reference) - https://phabricator.wikimedia.org/T118050#1840091 (Ejegg) Open>Resolved [00:53:46] (PS1) Eileen: CRM-17394 - Initialize DB slightly later. Fix query-log and redundant SET NAMES. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256151 [00:53:48] (PS1) Eileen: CRM-17394 backport Civi class to support utf names fix [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256152 (https://phabricator.wikimedia.org/T116724) [00:54:05] Also, am I the only one who gets these every 5 minutes? "Cron /usr/bin/php /srv/www/org/wikimedia/listeners/SmashPig/Maintenance/StompJobRunner.php --config-file /srv/www/org/wikimedia/listeners/SmashPig/config.php --config-node adyen" [00:54:42] awight: ejegg: cwd: XenoRyet: ^ ? [00:54:58] Fundraising Dash, Fundraising Sprint Grandmaster Flash, Fundraising Sprint Yo La Tengo: Make additional filters for X-by-Y chart - https://phabricator.wikimedia.org/T86840#1840102 (Ejegg) Open>Resolved [00:54:59] **wide-angle ping** [00:54:59] Fundraising Dash, § Fundraising Sprint Abba, § Fundraising Sprint Beastie Boys: Dash: breakdown bars - https://phabricator.wikimedia.org/T86094#1840104 (Ejegg) [00:55:02] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Performance: Civi: don't be so crazy about "SET NAMES utf8" - https://phabricator.wikimedia.org/T116724#1840105 (Eileenmcnaughton) I've added a backport of Tim's commit on this in case we want to try to speed up queue speed in th... [00:55:16] AndyRussG: do you not get all the other cron spam? [00:55:19] AndyRussG: i filter all cronmail :P [00:55:26] AndyRussG: thanks, I still haven't done that mail filter tweaking I recommended everyone do [00:55:45] I do filter those, and like a zillion other things... [00:55:57] Maybe I should filter some things more than others, tho? [00:57:08] yeah, cron alternately sends me those smashpigjob runner things and orphan slayer logs [01:01:22] Fundraising Dash, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work: Fix dash minification script - https://phabricator.wikimedia.org/T119924#1840183 (Ejegg) NEW a:Ejegg [01:01:43] Fundraising Dash, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work: Fix dash minification script - https://phabricator.wikimedia.org/T119924#1840192 (Ejegg) [01:04:19] dstrine: current sprint needs updating on your phab welcome panel [01:04:49] How's the butter churning? [01:05:05] So I guess the smashpigjob runner stuff is irrelevant? [01:05:24] AndyRussG: it's actually successful, but cron has this annoying habit of emailing any stdout [01:06:08] (CR) Awight: [C: 2] fix missing arg on upgrade [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/254356 (https://phabricator.wikimedia.org/T116877) (owner: Eileen) [01:06:14] yep. I see you made a phab task to shut cron up [01:06:29] awight: Ah I see now it is, not many days ago it was all errorful, th [01:06:30] tho [01:06:46] I wish I could paint the edge of the phab task with frog venom [01:07:03] AndyRussG: That's the scary part! we only want email when fail :( [01:07:51] Hmmm frog venom helps with that? [01:08:20] (CR) jenkins-bot: [V: -1] CRM-17394 - Initialize DB slightly later. Fix query-log and redundant SET NAMES. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256151 (owner: Eileen) [01:08:23] Fundraising Dash: X x Y widget doesn't seem to work - https://phabricator.wikimedia.org/T118046#1840207 (Ejegg) Works on my dash. If it's still broken, want to try deleting and re-adding to your board? [01:11:37] (CR) Awight: [C: -1] "Don't u need to add the new dependencies to package.json?" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256041 (owner: Ejegg) [01:12:29] (CR) Ejegg: "sure do! thanks for catching that." [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256041 (owner: Ejegg) [01:16:29] (CR) Awight: [C: -1] "I think you need to put this after the patch that backports Civi.php?" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256151 (owner: Eileen) [01:18:27] Fundraising-Backlog, Epic: [epic] Get Adyen back up - https://phabricator.wikimedia.org/T90748#1840231 (awight) [01:18:29] Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising-Backlog, FR-Adyen, Patch-For-Review: Fix or disable Adyen job runner - https://phabricator.wikimedia.org/T117451#1840229 (awight) Resolved>Open Reopening cos this is still happening. [01:19:44] (PS4) Ejegg: Add new components and CSS URL fixes to gulpfile [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256041 [01:22:35] ejegg: Remind me what we're doing with contrib libraries in the dash repo... [01:22:37] (CR) jenkins-bot: [V: -1] CRM-17394 backport Civi class to support utf names fix [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256152 (https://phabricator.wikimedia.org/T116724) (owner: Eileen) [01:22:50] Has that not gotten the "deploy-only" treatment yet? [01:24:03] (CR) Eileen: "Dang - OK I'll figure that out. I want to get the pair of them up on github so Tim can tell me if he thinks I have all bases covered (sinc" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256151 (owner: Eileen) [01:26:28] (CR) Awight: [C: 2] "(TODO: upstream our namespace support, or document stubbornness)" [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/254659 (owner: Ejegg) [01:26:34] (PS2) Awight: make adyen use test url like other adapters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/255297 (owner: Cdentinger) [01:26:48] (CR) Awight: [C: 2] "win!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/255297 (owner: Cdentinger) [01:27:26] eileen: You mentioned some file permission issues on staging--can I help? [01:27:29] awight: not yet deploy-only, but it really should be. We're dploying our dev-dependencies :S [01:27:36] ok cool [01:27:54] (PS5) Awight: Add new components and CSS URL fixes to gulpfile [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256041 (owner: Ejegg) [01:28:03] (CR) Awight: [C: 2 V: 1] "As seen on IRC!" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256041 (owner: Ejegg) [01:28:13] heh [01:32:51] (CR) Ejegg: "ah phooey, I forgot the a/b testing widget. it needs a db insert to deploy, anyway" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256041 (owner: Ejegg) [01:35:50] (PS1) Cdentinger: pared down iframe stylesheet [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/256157 [01:36:39] (CR) jenkins-bot: [V: -1] fix missing arg on upgrade [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/254356 (https://phabricator.wikimedia.org/T116877) (owner: Eileen) [01:38:41] ok friends, dash and DI look good, and I'm signing off for the night. Here's hoping for a nice smooth start to the fundraiser! [01:39:00] see ya! [01:40:16] (PS2) Cdentinger: pared down iframe stylesheet [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/256157 [01:41:16] bye! [01:41:30] * cwd hopes the live adyen scripts resemble the test ones [01:41:45] brb (rebooting) [01:43:31] CR for that CSS is purely academic anyhow, it's "deployed" as much as i upload a zip file with each change [01:43:43] * cwd nostalgias about web dev in 2002 [01:43:53] (PS3) Awight: Subscribing RL modules: Whitespace style for function declarations [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/235759 (https://phabricator.wikimedia.org/T111387) (owner: AndyRussG) [01:44:23] (CR) Awight: "PS3: manual rebase" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/235759 (https://phabricator.wikimedia.org/T111387) (owner: AndyRussG) [01:50:39] (CR) jenkins-bot: [V: -1] Merge branch 'contrib' [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/254659 (owner: Ejegg) [01:51:14] (Merged) jenkins-bot: make adyen use test url like other adapters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/255297 (owner: Cdentinger) [01:51:55] (Merged) jenkins-bot: Add new components and CSS URL fixes to gulpfile [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256041 (owner: Ejegg) [01:58:48] AndyRussG: you mind if I merge https://gerrit.wikimedia.org/r/235759 ? [01:59:54] We could even turn on the lint jobs as non-voting, if you plan to fix all that stuff [01:59:56] awight: sure! do you want me to look at it again and maybe comment on Gerrit? [02:00:02] if you wish! [02:02:52] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/254356 (https://phabricator.wikimedia.org/T116877) (owner: Eileen) [02:03:07] awight: yeah! I think there was also some even more advanced js lint/style checking we have available [02:03:17] Pretty sure there's a Phab task about that [02:05:41] K meld with text filter to ignore whitespace differences sez all the files are the same, so that's a good sign :) [02:06:43] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work, FR-GlobalCollect: WR1 audit parser emitting multiple bad refund lines - https://phabricator.wikimedia.org/T119927#1840297 (awight) NEW [02:09:36] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work, FR-GlobalCollect: WR1 audit parser emitting multiple bad refund lines - https://phabricator.wikimedia.org/T119927#1840304 (awight) This was fraud, and the GC console says $1 / -$1. We still need to figure out why the amoun... [02:15:02] buh bye! [02:17:08] me2 [02:17:39] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Performance: Civi: don't be so crazy about "SET NAMES utf8" - https://phabricator.wikimedia.org/T116724#1840316 (Eileenmcnaughton) NB - I have put the backport of the Civi class into a separate JIRA https://issues.civicrm.org/ji... [02:19:51] (CR) AndyRussG: "This PS: LGTM! :)" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/235759 (https://phabricator.wikimedia.org/T111387) (owner: AndyRussG) [02:32:48] hey eileen [02:32:50] yt? [02:33:00] atgomez: hi! [02:33:02] any chance you can drop me my civi username? i always forget :P [02:39:36] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work, FR-GlobalCollect: WR1 audit parser emitting multiple bad refund lines - https://phabricator.wikimedia.org/T119927#1840339 (atgo) We really should finish the move to wx... T86090 *after december* [02:40:22] Fundraising Dash: X x Y widget doesn't seem to work - https://phabricator.wikimedia.org/T118046#1840341 (atgo) Open>Invalid a:atgo [02:40:41] Fundraising Dash: X x Y widget doesn't seem to work - https://phabricator.wikimedia.org/T118046#1840343 (atgo) Looks good! Not sure what was happening there. Closing this one but making a new task to collapse the filters when not in use. [02:42:26] Fundraising Dash, Fundraising-Backlog: Collapse filters on XxY widget when not in use - https://phabricator.wikimedia.org/T119931#1840344 (atgo) NEW [02:45:25] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add column to Engage Import: Direct Mail Appeal - https://phabricator.wikimedia.org/T119921#1840352 (atgo) @caitvirtue is this urgent, given volume right now? [03:04:16] (PS1) Eileen: CRM-17641 backport Civi class in order to support other backports [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256162 (https://phabricator.wikimedia.org/T116724) [03:04:18] (PS1) Eileen: CRM-17394 - Initialize DB slightly later. Fix query-log and redundant SET NAMES. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256163 [03:05:40] (Abandoned) Eileen: CRM-17394 - Initialize DB slightly later. Fix query-log and redundant SET NAMES. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256151 (owner: Eileen) [03:05:58] (Abandoned) Eileen: CRM-17394 backport Civi class to support utf names fix [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256152 (https://phabricator.wikimedia.org/T116724) (owner: Eileen) [03:18:42] (CR) jenkins-bot: [V: -1] CRM-17641 backport Civi class in order to support other backports [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256162 (https://phabricator.wikimedia.org/T116724) (owner: Eileen) [03:32:41] (CR) jenkins-bot: [V: -1] CRM-17394 - Initialize DB slightly later. Fix query-log and redundant SET NAMES. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256163 (owner: Eileen) [03:38:06] Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: CiviCRM upgrade: Donation Processing: no refund button after clicking Edit transaction - https://phabricator.wikimedia.org/T116317#1840374 (Eileenmcnaughton) So up... [04:12:39] (PS1) Eileen: CRM-17620 expose payment data for contributions in the UI [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256168 (https://phabricator.wikimedia.org/T116317) [04:26:54] (CR) jenkins-bot: [V: -1] CRM-17620 expose payment data for contributions in the UI [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256168 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [10:53:39] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Remove "whitebox" template from payments forms - https://phabricator.wikimedia.org/T119586#1840897 (Pcoombe) Open>Resolved a:Pcoombe Thanks! [13:43:56] (PS1) Ejegg: Don't double-dispose charts [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256214 [15:16:44] (PS1) Ejegg: Add A/B testing widget to gulpfile [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256227 [15:17:54] cwd: couple of little bugfixes for the dash - one fixes an error switching boards after you modify a chart, the other adds your A/B widget to the minified code [15:19:01] word, i'll check it out in one sec [15:30:51] !log changed donation qc time limit from 90 to 100 sec [15:30:55] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [15:37:49] (CR) Cdentinger: [C: 2] Don't double-dispose charts [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256214 (owner: Ejegg) [15:38:11] (CR) Cdentinger: [C: 2] "ye olde a/b widget -- don't think i ever got it to actually do something" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256227 (owner: Ejegg) [16:32:04] (PS1) Eileen: CRM-17640 Update contribution api to do a sensible query when getcount is being invoked [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256241 (https://phabricator.wikimedia.org/T116317) [16:46:37] (CR) jenkins-bot: [V: -1] CRM-17640 Update contribution api to do a sensible query when getcount is being invoked [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256241 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [16:47:11] hi friends! [16:48:37] hi atgomez [16:48:56] it's raining in boston! brr [16:49:14] we have the cold part, but not the rain [16:51:21] Fundraising Dash, Fundraising Sprint Grandmaster Flash, Fundraising Sprint Yo La Tengo, Fundraising-Backlog: Make additional filters for X-by-Y chart - https://phabricator.wikimedia.org/T86840#1841801 (DStrine) [17:31:55] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: UI Sillyness: Prospect Tab - Extra spacing between hard returns in text fields - https://phabricator.wikimedia.org/T119983#1841932 (CaitVirtue) NEW [17:39:57] Wikimedia-Fundraising-CiviCRM: Speed up CiviCRM queue processing - https://phabricator.wikimedia.org/T119986#1841980 (Eileenmcnaughton) NEW [17:42:39] (PS1) Eileen: CRM-17644 fix caching on tax rates to still cache if none set [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256257 (https://phabricator.wikimedia.org/T119986) [17:44:15] hey dstrine what's the software you use for screen captures? [17:44:23] Jing [17:44:42] https://www.techsmith.com/jing.html [17:57:02] (CR) jenkins-bot: [V: -1] CRM-17644 fix caching on tax rates to still cache if none set [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256257 (https://phabricator.wikimedia.org/T119986) (owner: Eileen) [17:58:24] hey fundraising folks .. so, when I go to donate.wikimedia.org, i get ( Donation amount (en pesos): ) ... and the selected amount does indicate MXN .. [17:58:42] ^ i went to stat1002 to check on that , and ran "geoiplookup" on subbu's IP [17:58:44] and mutante has verified that my IP in minneapolis does geo tag to minnesota. [17:58:48] which uses the maxmind database [17:58:55] and yea, not Mexico [17:59:24] so that sounds like a possible bug in donate.wm code [18:00:13] unless i need to clear some cookies in my browser and/or there is something in my user preferences that indicates mexico .. after all i was in mexico for wikimania .. [18:02:31] hi [18:04:37] subbu: good point about cookies and wikimania! yea [18:05:04] subbu: interesting! could totally be a cookie. i get USD correctly [18:05:51] though that sounds like a pretty long lifespan for a cookie [18:06:12] i could try clearing wikimedia.org cookies and see if it helps unless you want me to hold on for any debugging. [18:06:17] i don't know off the top of my head what the expiry would be [18:06:34] maybe you have a second browser to try? [18:06:41] i do [18:07:03] cool yeah, we should be able to hunt it down in the log too [18:07:13] although they are gonna be hella noisy today [18:07:25] yup .. yes, it does show USD in google-chrome by non-default browser [18:07:29] *my [18:09:50] Wikimedia-Fundraising-CiviCRM: Civi login for new contractor: Janelle Chojnacki - https://phabricator.wikimedia.org/T119992#1842119 (CaitVirtue) NEW [18:13:41] subbu: you could check for the GeoIP cookie from wikimedia.org? see if it says mexico [18:15:07] yes, it does [18:16:03] and "Expires: At end of session" .. I guess that is one long session .. :) [18:16:59] i was just looking at that...have you had your browser open since july? [18:17:06] because that's gotta be some sort of stability record [18:17:57] nope. i've rebooted my laptop a few times in between as well. [18:18:15] If you keep restoring previous session it might stay [18:18:25] ah, yes, that i have been doing. [18:18:43] subbu: K sounds like that's it :) [18:19:12] alright then. let me clear the cookie and that should be it. [18:19:46] subbu: K sounds good :) hopefully it'll work! [18:20:13] The GeoIP stuff is not as straightforward as one might think, it also gets funky if you use IPv6 [18:20:26] yup, clearing the geoip cookie did it. [18:20:34] cool! [18:20:36] but, i wonder if others might be bitten by this as well. [18:21:04] i got a fraud alert from my credit card as well .. good to know that my credit card company is looking out for me. :) [18:21:34] thanks. off now. [18:21:41] subbu: it's sure possible. Maybe we should think about changing how that cookie works? [18:21:46] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add column to Engage Import: Direct Mail Appeal - https://phabricator.wikimedia.org/T119921#1842171 (CaitVirtue) Yes [18:21:47] cya! [18:22:30] AndyRussG, maybe .. worth a phab task at least. [18:22:39] yeah [18:22:54] It's actually used a lot outside FR and CentralNotice, so we're trying to farm the code out [18:33:39] cwd: atgomez1: K4-713: ejegg: cwd: the-wub: ejegg: It looks like we're not getting correct impression numbers for users who had a fullscreen cookie [18:33:56] I thought that cookie name was going to change, also? [18:34:05] how so? [18:34:31] AndyRussG: impression numbers where? pgehres database? [18:34:42] the-wub: from Special:RecordImpression [18:35:00] It says the banner was shown even when it's hidden by fullscreen cookie [18:35:41] That's unfortunate. [18:35:57] What would cause that cookie name to change, other than a config change? [18:36:13] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Add column to Engage Import: Direct Mail Appeal - https://phabricator.wikimedia.org/T119921#1842275 (atgo) p:High>Unbreak! [18:36:42] Uh-oh. [18:36:46] eileen awight cwd XenoRyet ejegg - hot (civi) potato: https://phabricator.wikimedia.org/T119921 [18:37:03] not actually broken, but major gifts needs urgently [18:37:05] I understood it would be a new cookie name, since it's set using in-banner JS it needs to be set on-wiki [18:37:14] hmmm [18:37:23] S:RI says It says also alterFunctionMissing:"true", which means the hook that is meant to deal with in-banner JS hiding isn't being called [18:37:40] engage thing is probably just a custom field right? ejegg XenoRyet ? [18:37:48] AndyRussG: we are using the same cookie name as before, 'centralnotice-frbanner-seen-fullscreen' [18:38:02] atgomez1: Direct Mail Appeal has to match one of the configured option values is the only complicated bit [18:38:06] cwd ^^ [18:38:21] since it's a select, not freeform [18:38:29] but we have other columns like that in imports [18:38:33] the-wub: OK that is coherent with the behaviour I saw... I guess hopefully not a lot of folks would have that cookie [18:39:19] ejegg: ah ha, does that mean we need to normalize it first? [18:39:41] AndyRussG: Is there a bug for this, or are you putting that together? [18:39:43] AndyRussG: ah, so do we need to include the alterImpressionData function? I thought that was included in the "Banners might not display, as determined by in-banner JavaScript" thing now [18:39:54] errr, either that or reject lines with bad values [18:40:19] K4-713: it's a banner config thing, I think it can be fixed right away and bug made for any cleanup [18:40:36] Okay. Carry on. [18:40:41] K4-713: :) [18:41:35] ejegg: atgomez1 I don't have much context for that Phab - I can look at it - but someone would need to brief me…. [18:42:01] or else if you have it under control then I will continue in ignorance [18:42:14] the-wub: no, we still need the alterImpressionData thing too. The "banners might not display" is in anticipation of when we start using Special:BannerLoader instead of S:RI [18:42:55] eileen: it's a civi module, offline2civicrm [18:43:12] i will take a look! [18:44:04] ejegg: hrm so i see that field on the engage importer already [18:44:04] oh hey, looks like TrilogyFile already has it [18:44:12] cwd and doesn't do anything special [18:44:36] can probably just add it to getRequiredColumns and getFieldMapping [18:44:45] maybe give it a default value if that makes sense [18:45:40] ejegg: i see it in getRequiredColumns for engage [18:46:08] and in the parent class getFieldMapping [18:46:25] hmm, ok. Maybe someone should just try it out and see if it works! [18:46:43] heh, i'll post on the ticket! [18:47:30] AndyRussG: okay, I'll start adding the alterImpressionData back to the banners where it's missing [18:47:50] the-wub: K yes I was about say, thanks!! [18:48:19] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Add column to Engage Import: Direct Mail Appeal - https://phabricator.wikimedia.org/T119921#1842361 (cwdent) @CaitVirtue -- I just cracked open the Engage importer and see that field there al... [18:48:54] the-wub: at least we can detect the impression records where this was a problem by looking for alterFunctionMissing:"true" [18:49:03] (on S:RI) [18:50:09] AndyRussG: I don't think it would affect many people. they should have been moved into bucket C/D immediately after seeing the 'fullscreen' banner, so shouldn't have run across that code again [18:50:36] thanks cwd ejegg for investigating so quickly! [18:50:54] the-wub: true, it'd only be people who already had the fullscreen cookie from having seen a previous campaign [18:51:36] the-wub: basically, any in-banner JS that can hide banners needs the alterImpressionData function to make sure that event is recorded by Special:RecordImpression [18:52:08] AndyRussG: but we don't need it when only using the impression diet mixin, right? [18:52:16] Yeah exactly [18:52:18] atgomez1: if it already works it will be my favorite card of the week [18:52:20] the-wub: sorry if this wasn't clear!! [18:52:33] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Add column to Engage Import: Direct Mail Appeal - https://phabricator.wikimedia.org/T119921#1842379 (CaitVirtue) @LeanneS - kicking this over to you. [18:52:57] AndyRussG: no problem, I just got over ambitious in my code cleanup! [18:53:30] Heh usually a good approach, fer sure! [18:56:27] the-wub: banners that don't contain any JS that would do any hiding don't need the alterImpressionData tho [18:59:27] Fundraising Dash, Fundraising-Backlog: Use URL fragments to indicate which board you're on - https://phabricator.wikimedia.org/T120000#1842401 (Ejegg) NEW [19:02:04] Fundraising Dash, Fundraising-Backlog: Use URL fragments to indicate which board you're on - https://phabricator.wikimedia.org/T120000#1842413 (atgo) Agreed! [19:04:21] cccccceddevinuihkfrrjlcknkinujthreetklnbhchd [19:04:43] ejegg: AndyRussG: Hi! Thanks, early shift! [19:04:55] awight: hi! [19:05:25] Fundraising Dash, Fundraising Sprint Yo La Tengo, Unplanned-Sprint-Work: Make major donation cutoff configurable - https://phabricator.wikimedia.org/T120001#1842423 (Ejegg) NEW a:Ejegg [19:05:30] hi awight! [19:05:38] AndyRussG: Okay, the alterImpressionData fucntion should be back in all our current banners where it's needed [19:05:57] btw, you might start seeing a new hide reason occasionally: 'namespace' [19:05:58] the-wub: cool! basically, all the large banners, no? [19:06:12] the-wub: huh, where does that come from? [19:06:14] (PS1) Ejegg: Make major donation cutoff configurable [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256271 (https://phabricator.wikimedia.org/T120001) [19:06:44] That's about not showing on certain types of pages? [19:06:45] AndyRussG: we are starting to hide banners when people aren't looking at article pages [19:07:16] the-wub: K... Any banners that do that also need the alterImpressionData function then... [19:07:19] e.g. Talk pages [19:08:08] yep, I've put it on all the banners again [19:10:39] the-wub: That's fine for now, but we should move that code into CentralNotice. There's already some logic to hide banners on the Special: namespace... [19:11:21] awight: I was thinking the same thing. but if RecordImpression is meant to go away eventually, then maybe it's not worth it [19:13:05] Mostly cos there should be no burden on banner code to DTRT... like, any first-time community banner should have the same behaviors. [19:13:44] agreed [19:14:17] the-wub: where is the namespace code? [19:14:27] Thank you for thinking of this important hide reason! [19:14:38] yeah also! ^ :) [19:15:09] the-wub: Also: what you're saying about RecordImpression is that we don't actually care about this particular statistic, right? Or do we? [19:15:33] Fundraising Dash, Fundraising-Backlog: Dash widget to measure donations queue lag - https://phabricator.wikimedia.org/T120002#1842444 (awight) NEW [19:15:35] AndyRussG: it's just in each banner right at the bottom e.g. https://meta.wikimedia.org/wiki/Special:CentralNoticeBanners/edit/B1516_en6C_dsk_p1_lg_template [19:15:49] awight AndyRussG: credit Liam for the suggestion! [19:16:02] the-wub: cool thx! [19:16:17] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Record timestamp when contribution is stored in Civi - https://phabricator.wikimedia.org/T120003#1842451 (awight) NEW [19:16:18] awight: which stat? [19:16:22] awight: which statistic? [19:16:28] jinx! [19:16:40] sorry--the number of people who don't see banners cos they're on a Talk: page. [19:16:53] Ah I think we do care about that [19:16:58] I believe we currently throw away the count of people who don't see a banner cos of Special:, eh? [19:17:03] should we be counting that? [19:17:47] awight: correct, but since this is in-banner code, it will trigger a S:RI call, and we need to at least know that those people didn't see a banner, and separate it from any other in-banner-JS-generated hide reasons [19:18:04] awight: it might be interesting to look at, but not super important. thought it would be good to collect the info under a separate reason tho [19:18:26] as in, correct, we don't count that, and generally wouldn't otherwise case, except to know that no banner was shown and why (^) [19:19:20] anyway, I need to go find some food and then squeeze myself onto a train. hopefully will be back in time for $1m! [19:20:02] Fundraising-Backlog, FR-Amazon: Amazon listener should queue fewer duplicate contribution messages - https://phabricator.wikimedia.org/T120006#1842488 (Ejegg) NEW [19:33:52] (PS1) Ejegg: Add page title [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256277 [19:35:33] Fundraising Dash, Fundraising-Backlog: Dash widget to measure donations queue lag - https://phabricator.wikimedia.org/T120002#1842584 (atgo) What about if it was something like this? https://docs.google.com/a/wikimedia.org/drawings/d/1y3pHqSg-_KHRXWM_F4FbGAS9vB0X8Ah5t0zVlNhnApM/edit?usp=sharing [19:37:26] I got high praise for my upstream version of the fix I did on contribution.getcount api slowness https://github.com/civicrm/civicrm-core/pull/7346 [19:40:12] hahaha /me looks for the comments that were praised [19:40:23] Fundraising Sprint Yo La Tengo, Fundraising Tech Backlog, Fundraising-Backlog, QuickSurveys, Reading Web Sprint 62 - D________________: Spike: QuickSurveys deployment process - https://phabricator.wikimedia.org/T119632#1842628 (Jdlrobson) [19:40:50] jdlrobson: atgomez1: ^ eh? [19:40:57] ooh I see [19:41:12] Cool, looking forward to discussing! [19:41:58] https://github.com/eileenmcnaughton/civicrm-core/commit/5928ea726bdcebb74374ace0a89a6d48bf5bcd9f [19:43:04] Katie: AndyRussG cwd|afk ejegg XenoRyet ^ [19:43:09] grr [19:43:12] K4-713: ^ [19:43:18] s/Katie/K4-713/g [19:44:05] awight: not the small kittens! [19:44:09] Heheheh [19:44:17] * K4-713 blinks [19:44:20] (apparently in Denver last year a whole group of people discovered they read my code comments in a kiwi accent) [19:44:33] haaa [19:44:50] I was apparently one of those 'you too' moments [19:45:30] :D [19:45:35] lol [19:45:46] amazing commit [19:46:20] There was actually a practical reason too - I didn't want it to be missed if it was at the top or bottom [19:46:36] Excellent. [19:47:57] this was the JIRA that made me decide to spell it out https://issues.civicrm.org/jira/browse/CRM-16713 - they needed the field for one screen from what I can tell [19:49:54] Fundraising Dash, Fundraising-Backlog: Dash widget to measure donations queue lag - https://phabricator.wikimedia.org/T120002#1842669 (awight) Ooh, we already have the information we need: it's just now() - source_enqueued_time of the top few donations in Civi. [19:50:13] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Record timestamp when contribution is stored in Civi - https://phabricator.wikimedia.org/T120003#1842670 (awight) Open>Invalid a:awight At least, not needed for this project. [19:50:14] Fundraising Dash, Fundraising-Backlog: Dash widget to measure donations queue lag - https://phabricator.wikimedia.org/T120002#1842673 (awight) [20:12:50] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CiviCRM: Simple Way to convert an Individual record into an Org record - https://phabricator.wikimedia.org/T120014#1842756 (CaitVirtue) NEW [20:31:50] Fundraising-Backlog: banner data and missing alterImpressionData(): Determine exact impact on data and coping mechanisms - https://phabricator.wikimedia.org/T120017#1842830 (AndyRussG) NEW [20:50:57] hey AndyRussG did you check with meganhernandez and jessicarobell about how urgent this one is? https://phabricator.wikimedia.org/T120017 [20:51:17] atgomez1: nope [20:51:51] (PS1) Ejegg: Add donation age widget [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256341 (https://phabricator.wikimedia.org/T120002) [20:52:30] AndyRussG: pinged them elsewhere to see if they'll comment on the task. i'm assuming this is high priorty for them and we may want to pull it in [20:53:16] atgomez1: K... It was the issue I just mentioned in standup. Peter did the actual fix (it involved changing stuff in the banners) [20:54:23] ah ok. so they're in the loop [20:54:32] yeah i know you mentioned it in the standup, just want to make sure that online knows about it [20:54:39] Thanks for the ping AndyRussG. So it seems this is already fixed the-wub? [20:55:19] cwd / awight / XenoRyet: queue lag approximation widget: https://gerrit.wikimedia.org/r/256341 [20:55:20] It's fixed... The task is just about making sure we look into how to deal with it datawise, in case that's necessary [20:56:02] jessicarobell: yes, I fixed it in the banners. the impact on numbers should have been v small [20:56:26] (CR) Awight: [C: 2] "I like it! Trixy boilerplate, interesting to see the bare framework." [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256341 (https://phabricator.wikimedia.org/T120002) (owner: Ejegg) [20:56:54] w00t! TY awight [20:58:14] (Merged) jenkins-bot: Add donation age widget [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256341 (https://phabricator.wikimedia.org/T120002) (owner: Ejegg) [21:01:48] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/256342 [21:02:11] (CR) Ejegg: [C: 2 V: 2] Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/256342 (owner: Ejegg) [21:04:42] !log updated fundraising from 2ee15180150c8b685b14abdbf7c6769736fb49a0 to 01a82b5e4909075e3190496e7fcda2b60f8d5d3c [21:04:46] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/253830 (https://phabricator.wikimedia.org/T117166) (owner: Eileen) [21:04:46] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:24:28] (CR) Eileen: "hmm whatever is messing with the tests is not going to clear itself" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/253830 (https://phabricator.wikimedia.org/T117166) (owner: Eileen) [21:38:31] Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising-Backlog: Donation form error message: "No processors available" - https://phabricator.wikimedia.org/T117872#1842983 (MBeat33) We sent the above error message to Sal at GC, and here is his reply: This order was already processe... [21:44:09] Fundraising Sprint Yo La Tengo, Wikimedia-Fundraising-CiviCRM: Add default order for Lybunt report to sort descending by greatest 2014 amount - https://phabricator.wikimedia.org/T119911#1842985 (XenoRyet) [21:44:44] Fundraising Sprint Yo La Tengo, Wikimedia-Fundraising-CiviCRM: Add default order for Lybunt report to sort descending by greatest 2014 amount - https://phabricator.wikimedia.org/T119911#1842989 (XenoRyet) a:XenoRyet [22:42:41] cwd: is your pared down stylesheet uploaded to adyen? [22:43:02] ejegg: yep [22:43:11] for the test account anyway...is it different? [22:43:35] Fundraising Sprint Yo La Tengo, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: CentralNotice: add 'namespace' hide reason - https://phabricator.wikimedia.org/T120029#1843098 (AndyRussG) NEW a:AndyRussG [22:43:49] Fundraising Sprint Yo La Tengo, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: CentralNotice: add 'namespace' hide reason - https://phabricator.wikimedia.org/T120029#1843107 (AndyRussG) [22:44:11] (PS1) AndyRussG: ext.centralNotice.display: add 'namespace' hide reason [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/256349 (https://phabricator.wikimedia.org/T120029) [22:44:42] cwd just wanted to see it in action, test is fine [22:45:10] I think the workflow is upload it to test, then click a button to publish skin to live [22:45:26] ah yeah that sounds right [22:50:50] (CR) Awight: [C: 2] "easy" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/256349 (https://phabricator.wikimedia.org/T120029) (owner: AndyRussG) [22:52:25] (Merged) jenkins-bot: ext.centralNotice.display: add 'namespace' hide reason [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/256349 (https://phabricator.wikimedia.org/T120029) (owner: AndyRussG) [22:52:54] ewulczyn: ... [22:52:57] meep. [22:55:44] (CR) Cdentinger: [C: 2] "Now that's what I call a page title." [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256277 (owner: Ejegg) [22:55:54] :P [22:56:28] i'm still trying to get muh dash working locally to test the operational stuff [22:58:43] Hey--is the dash supposed to refresh itself? [22:58:52] Shall we add a meta-refresh? [23:00:16] awight: thx! [23:01:51] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-GlobalCollect: Globalcollect Status 25/404 errors - https://phabricator.wikimedia.org/T120030#1843165 (awight) [23:04:22] awight: auto refresh sounds familiar...but doesn't knockout do some sort of "active" elements you can push to? [23:06:06] I'm fine with a full-page refresh as a workaround... [23:06:31] oh hold on, it might *be* refreshing [23:16:58] cwd: It refreshes every 10 minutes... [23:17:43] ah ha [23:33:41] (CR) Ejegg: "Let's hide the card logos too and see if we can prevent the iframe from scrolling" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/256157 (owner: Cdentinger) [23:40:00] awight: only certain widgets autorefresh [23:40:16] the totals earned, and now the queue lag indicator [23:41:04] ooh [23:41:44] wanna add the queue lag widget to the BE board? [23:42:00] awight: sure, can do [23:42:09] good place for it [23:55:59] eileen: I'm staring dumbly transfixed at the CRM test failure now... [23:56:45] awight: I did that for a bit earlier on [23:57:02] and then I went looking for coffee [23:57:27] Friends: This is extremely bad luck, but let me pass around the cigars anyway, *there were no failmails today* [23:57:30] wat. [23:58:01] hmm - that seems unlikely…? [23:59:34] awight: last successful drupal patch was a drupal core upgrade .. Upgrade to Drupal 7.39 upstream [23:59:59] scrub that!