[00:00:38] hrm [00:00:41] I don't like it [00:01:13] the failmails? they normally come off the audit don't they? [00:01:22] They come from every angle [00:01:51] well, from queue consumers, realtime listeners, audit processing, other cronjobs [00:01:54] not from DI actually [00:03:02] queue is falling 'fairly' fast now [00:03:39] (PS1) Ejegg: Add donation age widget to Big English board [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256362 (https://phabricator.wikimedia.org/T120002) [00:03:49] Whee, subselects! [00:04:37] awight: I think that'll get it on all the BE boards ^^ [00:06:14] I'mma head out for now, might check on things later! [00:07:42] PR tests on jenkins haven't actually passed since 26 Nov [00:10:17] hmm only civi changes that I can see since then - but they don't seem to relate to the error [00:10:39] (CR) Awight: [C: 2] "WOW. ow. /me squeezes eyes shut real hard..." [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256362 (https://phabricator.wikimedia.org/T120002) (owner: Ejegg) [00:11:12] eileen: The error is still a web thing. I'm imagining the drush version got bumped upstream? [00:11:37] yeah I suppose it must be [00:11:41] hey, quick question: are fundraising banners ever shown to people who are logged in automatically? [00:12:00] (Merged) jenkins-bot: Add donation age widget to Big English board [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256362 (https://phabricator.wikimedia.org/T120002) (owner: Ejegg) [00:13:04] awight: we are using an old version of drush? [00:13:58] I think it comes from civicrm-buildkit/vendor? [00:14:32] hmm [00:17:11] I can reproduce the error, at least: [00:17:11] awight@integration-slave-trusty-1012:/mnt/jenkins-workspace/workspace/wikimedia-fundraising-civicrm/src/wikimedia/fundraising/crm/drupal$ ../../civicrm-buildkit/bin/drush [00:19:30] better yet, [00:19:30] jenkins-deploy@integration-slave-trusty-1012:~$ /mnt/jenkins-workspace/workspace/wikimedia-fundraising-civicrm/src/wikimedia/fundraising/civicrm-buildkit/bin/drush [00:22:19] awight: where does it grab buildkit from? I can see your repo on github but not one in gerrit [00:22:21] completely stalled [00:22:36] eileen: https://gerrit.wikimedia.org/r/wikimedia/fundraising/civicrm-buildkit [00:22:57] hmm - why didn't I see that... [00:23:39] Looks like download.pear.php.net is dead [00:24:03] yeah [00:24:24] & presumably we have an old drush version (appropos d6 support) [00:25:30] Pretty certain we can use the latest drush, it's still d6 compatible? [00:26:19] http://www.drush.org/en/master/install/#drupal-compatibility [00:26:33] But I doubt it will solve this issue. Checking... [00:27:15] Fundraising-Backlog: GC 12/1 donor received 'Forbidden' error for successful donation - https://phabricator.wikimedia.org/T120038#1843385 (Krenair) sounds fundraising-related [00:28:32] yeah we're locked to a 2013 version [00:28:37] (of drush) [00:29:16] The new one doesn't reference that bad site. Okay, trying to update now. [00:38:34] (PS1) Awight: Update Drush to ^8.0.1 [wikimedia/fundraising/civicrm-buildkit] - https://gerrit.wikimedia.org/r/256369 [00:38:41] eileen: ^ wanna try it? [00:41:00] awight: ejegg|away: cwd: XenoRyet: K4-713: atgomez: any objections to deploying out 2 small pending CN patches tomorow on SWAT (https://phabricator.wikimedia.org/T120029 and https://phabricator.wikimedia.org/T119538) ? [00:41:18] doit [00:42:01] awight: I'm pulling that patch into my local - but it's set up off stock & a bit non-standards so might take me a little bit to do any sort of valid test [00:42:20] eileen: Well to share the answers, I did verify that Drush 8.0.1 works locally for me [00:42:48] awight: cool! [00:44:04] rats, we don't have CI wired up to that repo [00:44:52] looks like that drush was deliberately selected due to - whatever test-debian6-1 is https://github.com/civicrm/civicrm-buildkit/commit/f8b94204d76d00017b100f2399749a0de3a179dc [00:45:20] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Continuous-Integration-Config: Continuous integration for wikimedia/fundraising/civicrm-buildkit - https://phabricator.wikimedia.org/T120044#1843450 (awight) NEW [00:45:28] oh blah [00:45:33] we don't need that IMO [00:45:35] <_< [00:45:36] >_> [00:45:44] * awight rushes to test on CI server [00:46:20] :-) [00:49:03] eileen: okay it checks out there, too. [00:49:17] awight: ok - so I can approve it then [00:49:26] who knew--updating software actually helping with a problem rather than making it worse O_o [00:49:41] :-) [00:50:04] awight: tim found the answer … http://pear.php.net/ [00:50:16] HAH [00:50:17] thx [00:51:16] (CR) Eileen: [C: 2] "The reason core buildkit doesn't use latest drush is to support d6 - not an issue for us" [wikimedia/fundraising/civicrm-buildkit] - https://gerrit.wikimedia.org/r/256369 (owner: Awight) [00:51:33] eileen: uh... that comment might be a bit off [00:51:44] oh is it? [00:51:45] d6 is totally supported by drush 8 [00:51:48] http://www.drush.org/en/master/install/#drupal-compatibility [00:52:01] Wikimedia-Fundraising-CiviCRM: Civi login for new contractor: Janelle Chojnacki - https://phabricator.wikimedia.org/T119992#1843483 (CaitVirtue) Janelle's first day is Tuesday, ie tomorrow. [00:52:12] (CR) Awight: [V: 2] Update Drush to ^8.0.1 [wikimedia/fundraising/civicrm-buildkit] - https://gerrit.wikimedia.org/r/256369 (owner: Awight) [00:52:19] hmm- ok so whatever this refers to https://github.com/civicrm/civicrm-buildkit/commit/f8b94204d76d00017b100f2399749a0de3a179dc [00:52:23] is something else [00:53:16] hrm. that's scary [00:53:19] we'll see... [00:54:03] (CR) Awight: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/253830 (https://phabricator.wikimedia.org/T117166) (owner: Eileen) [00:54:10] (CR) Eileen: "actually the thing core supports might not be d6 - it's a bit unclear" [wikimedia/fundraising/civicrm-buildkit] - https://gerrit.wikimedia.org/r/256369 (owner: Awight) [00:54:31] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/254356 (https://phabricator.wikimedia.org/T116877) (owner: Eileen) [00:55:23] :( A good and quick project for this month: https://phabricator.wikimedia.org/T91911 [00:55:35] until then, we're stuck with a single CRM CI job [00:58:25] eileen: Wheee, green lights again! [00:58:33] (PS2) Awight: fix missing arg on upgrade [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/254356 (https://phabricator.wikimedia.org/T116877) (owner: Eileen) [00:58:50] awight: yay [01:00:41] (CR) Awight: [C: 2] Fix reports save a copy link (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/253830 (https://phabricator.wikimedia.org/T117166) (owner: Eileen) [01:01:53] (CR) Awight: [C: 2] CRM-17644 fix caching on tax rates to still cache if none set [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256257 (https://phabricator.wikimedia.org/T119986) (owner: Eileen) [01:02:07] (CR) Awight: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256257 (https://phabricator.wikimedia.org/T119986) (owner: Eileen) [01:03:13] AndyRussG: i leave it up to you. if it's better to do it than not, let's :) [01:03:21] (PS1) Cdentinger: correct iframe target [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/256371 [01:03:22] if it's super effing risky for low payoff, then no. i think the answer is yes :) [01:03:37] (Merged) jenkins-bot: Fix reports save a copy link [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/253830 (https://phabricator.wikimedia.org/T117166) (owner: Eileen) [01:04:12] (CR) jenkins-bot: [V: -1] correct iframe target [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/256371 (owner: Cdentinger) [01:05:09] wtf [01:05:21] i got globals orbiting my head [01:05:59] * awight bonks halo with a rubber mallet [01:06:03] (Merged) jenkins-bot: CRM-17644 fix caching on tax rates to still cache if none set [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256257 (https://phabricator.wikimedia.org/T119986) (owner: Eileen) [01:06:25] (CR) Awight: [C: 2] CRM-17640 Update contribution api to do a sensible query when getcount is being invoked (4 comments) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256241 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [01:06:39] (PS2) Awight: CRM-17640 Update contribution api to do a sensible query when getcount is being invoked [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256241 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [01:06:52] (PS2) Awight: CRM-17620 expose payment data for contributions in the UI [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256168 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [01:08:49] (PS3) Awight: fix missing arg on upgrade [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/254356 (https://phabricator.wikimedia.org/T116877) (owner: Eileen) [01:10:16] atgomez: they're very minimal, especially the second one. And the second is important for getting good data in banner history logs [01:10:48] yay! [01:12:17] atgomez: K let's do it [01:12:29] I'll book a deploy slot tomorrow [01:14:44] (CR) Awight: [C: 2] CRM-17620 expose payment data for contributions in the UI (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256168 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [01:16:07] Bahaha: http://i.imgur.com/SXt1O2Q.gifv [01:18:03] nice [01:18:06] that video was great [01:18:11] i laughed [01:18:19] Yea, pretty damn funny. [01:18:52] (Merged) jenkins-bot: CRM-17620 expose payment data for contributions in the UI [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256168 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [01:21:34] (PS2) Cdentinger: correct iframe target [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/256371 [01:22:18] (CR) Awight: "I actually like how you can expand single line item contributions..." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256168 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [01:22:29] (CR) jenkins-bot: [V: -1] correct iframe target [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/256371 (owner: Cdentinger) [01:23:13] idgi [01:23:17] all the tests pass locally [01:24:14] Found alias defined for Mytalk when searching for special page aliases for MyTalk. Case mismatch? [01:25:32] (CR) Awight: [C: 2] CRM-17641 backport Civi class in order to support other backports (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256162 (https://phabricator.wikimedia.org/T116724) (owner: Eileen) [01:26:13] awight: does that ring any bells? [01:26:37] cwd apparently one should have rung about $16k ago... [01:26:52] haha [01:27:21] wat are those failures [01:27:28] gtg, but tomorrow... [01:27:54] (PS2) Awight: CRM-17641 backport Civi class in order to support other backports [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256162 (https://phabricator.wikimedia.org/T116724) (owner: Eileen) [01:28:50] there needs to be a ringing-a-bell-as-a-service startup [01:28:59] ring.io [01:32:38] (CR) Eileen: CRM-17641 backport Civi class in order to support other backports (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256162 (https://phabricator.wikimedia.org/T116724) (owner: Eileen) [01:34:01] (CR) Eileen: "It's actually exposing payment data not line items - I'd like to expose both - but line items are probably not a priority for wmf." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256168 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [01:43:32] (PS1) Eileen: Add option to define a separate path for the amp app [wikimedia/fundraising/civicrm-buildkit/vendor/totten/amp] - https://gerrit.wikimedia.org/r/256377 (https://phabricator.wikimedia.org/T91911) [01:45:23] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Easy, and 2 others: Point amp cache to $WORKSPACE - https://phabricator.wikimedia.org/T91911#1843631 (Eileenmcnaughton) @awight per your comment A good and quick project for this month: https://phabricator.wikimedia.org/... [01:46:28] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Easy, and 2 others: Point amp cache to $WORKSPACE - https://phabricator.wikimedia.org/T91911#1843634 (Eileenmcnaughton) NB - one this is merged only composer.lock should need updating in main branch as composer.json poin... [01:47:37] Good news, we haven't brought down the EventLogging infrastructure w/ banner history [01:47:55] AndyRussG: yay [01:48:00] :) [01:48:20] In fact we're only putting out 11% of all EventLogging requests [01:48:27] https://grafana.wikimedia.org/dashboard/db/eventlogging [01:51:24] cool [01:56:21] eileen: I wonder what that sudden dip in events at 20:21 UTC was [01:57:37] That would have been 12:21 PM SF time [01:58:13] K4-713: XenoRyet: eileen ^ Any idea about what caused a short dip in BannerHistory log data today? [01:58:48] Nothing that I know of. [01:59:27] Hmmm [01:59:57] I mean, I'm not sure I would even know what to suspect, but nothing comes to mind. [02:00:23] It doesn't seem to be any general outage or EventLogging outage, other EventLogging events were fine [02:00:37] AndyRussG: Interesting. [02:00:57] K4-713: XenoRyet: so no brief temporary take-down of campaigns flew by without me noticing? [02:01:02] I was going to say we should ask the EventLogging people. [02:01:09] AFAIK, we didn't do anything. [02:01:16] Like, to anything. At all. [02:01:22] Hmmm [02:01:24] (PS3) Eileen: CRM-17640 Update contribution api to do a sensible query when getcount is being invoked [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256241 (https://phabricator.wikimedia.org/T116317) [02:01:25] Yea, I didn't see anything get taken down either. [02:02:01] Here's another dash that you can adjust to only show our schema (set the Schema dropdown to CentralNoticeBannerHistory) [02:02:03] https://grafana.wikimedia.org/dashboard/db/eventlogging-schema [02:02:06] Hour 20 UTC? [02:02:11] I think so... [02:02:48] 20:21 UTC [02:02:55] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Add column to Engage Import: Direct Mail Appeal - https://phabricator.wikimedia.org/T119921#1843654 (LeanneS) @cwdent You're right! Engage had been utilizing the field with their own internal... [02:03:18] AndyRussG: The curve in that hour doesn't look interrupted. [02:04:00] No CN schema errors around that time, or anything (wait a sec for the errors panel to refresh after setting the drop-down) [02:04:24] If there was an unnatural dropoff in actual banners served, it would be visible in the donation curve. [02:04:35] Ah right [02:04:46] Strange [02:05:33] (asking for input on #wikimedia-analytics) [02:06:42] I think I'm going to go into standby mode. [02:07:57] AndyRussG: How big of a dip are we talking about? [02:08:32] It's here in the first link I sent, https://grafana.wikimedia.org/dashboard/db/eventlogging [02:09:56] K4-713: at the lowest point it goes to 370 events logged per second, vs a stable ~ 1000 per second on eithers side [02:10:12] urgh [02:10:17] That's not good. [02:10:38] How long? [02:10:51] It may look gradual just because of how they're calculating rate on the graph. If I pull the actual data, maybe I could see exactly whether it stops and starts or what [02:12:52] K4-713: I guess I should make a Phab card and check it out in detail? Could also compare w/ impression numbers [02:13:42] AndyRussG: For tonight, I'd just document the phenomenon in phab and come back tomorrow. [02:14:02] K4-713: OK :) [02:14:17] I'm sure the mystery will keep, and it doesn't seem to be messing with the actual donation flow. [02:16:03] (PS4) Eileen: CRM-17640 Update contribution api to do a sensible query when getcount is being invoked [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256241 (https://phabricator.wikimedia.org/T116317) [02:16:19] Yeah thankfully! [02:17:07] Maybe banners really did stop being shown, but there was such a tidal wave of collective thought surrounding banners and Wikimedia donations that people just kept imagining they were seeing banners for a bit [02:17:17] Kinda like collective brain-lag [02:19:41] (CR) Eileen: "I've pushed a fix to the comment & also up to core - https://github.com/civicrm/civicrm-core/pull/7353" (4 comments) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256241 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [02:36:40] Fundraising-Backlog: mobile donation form: expiration date error - https://phabricator.wikimedia.org/T120053#1843717 (MBeat33) NEW [02:39:54] dstrine: XenoRyet: eileen: did anyone discuss banners showing over images in mediaviewer? [02:40:47] For example, https://en.wikipedia.org/wiki/Fire_ant#/media/File:Fire_ants_01.jpg [02:42:13] I hate fire ants - I've been bitten - much prefer the coffee image! [02:42:27] (but not afaik) [02:43:06] https://en.wikipedia.org/wiki/Coffee#/media/File:A_small_cup_of_coffee.JPG [02:43:20] Huh, can't even close mediaviewer without closing the banner [02:43:44] Ah right, that coffee image [02:50:25] (CR) Eileen: "I made some notes on performance impact over on the upstream pr" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256257 (https://phabricator.wikimedia.org/T119986) (owner: Eileen) [02:59:34] (CR) Eileen: Fix reports save a copy link (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/253830 (https://phabricator.wikimedia.org/T117166) (owner: Eileen) [03:02:05] (CR) Eileen: "Is the fact this is reviewed & verified but not merged deliberate - or just CI getting there." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/254356 (https://phabricator.wikimedia.org/T116877) (owner: Eileen) [03:06:17] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: UI Sillyness: Can't see all the fields when adding a new email address to a contact record - https://phabricator.wikimedia.org/T118037#1843758 (Eileenmcnaughton) @awight since you are sharing a room with Caitlin, Lea... [03:07:02] ding ding ding ding ding ding ding [03:34:18] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Add API for custom hide cookie reasons and durations, to support a "Remind me later" banner clickable - https://phabricator.wikimedia.org/T120056#1843788 (AndyRussG) NEW [03:38:01] Fundraising-Backlog: Spike: Consider some initial steps for infrastructure for banner history data crunching - https://phabricator.wikimedia.org/T120057#1843798 (AndyRussG) NEW [03:45:09] Fundraising Sprint Yo La Tengo, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: Investigate possible brief drop in banner history log rate on 2015-12-01 at 20:21 UTC - https://phabricator.wikimedia.org/T120058#1843809 (AndyRussG) NEW [03:45:28] Fundraising Sprint Yo La Tengo, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: Investigate possible brief drop in banner history log rate on 2015-12-01 at 20:21 UTC - https://phabricator.wikimedia.org/T120058#1843818 (AndyRussG) a:AndyRussG [04:26:37] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Add column to Engage Import: Direct Mail Appeal - https://phabricator.wikimedia.org/T119921#1843840 (CaitVirtue) Open>Resolved a:CaitVirtue [10:25:57] Fundraising-Backlog: mobile donation form: expiration date error - https://phabricator.wikimedia.org/T120053#1844233 (Pcoombe) @atgo This looks like a tech/GC thing. [11:57:16] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Add API for custom hide cookie reasons and durations, to support a "Remind me later" banner clickable - https://phabricator.wikimedia.org/T120056#1844424 (Pcoombe) [13:38:37] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Add API for custom hide cookie reasons and durations, to support a "Remind me later" banner clickable - https://phabricator.wikimedia.org/T120056#1844581 (MeganHernandez_WMF) Hey @AndyRussG, @Pcoombe & @atgo Thanks for looking into... [13:44:05] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Add API for custom hide cookie reasons and durations, to support a "Remind me later" banner clickable - https://phabricator.wikimedia.org/T120056#1844583 (AndyRussG) >>! In T120056#1844581, @MeganHernandez_WMF wrote: > Do you have an... [13:56:42] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Add API for custom hide cookie reasons and durations, to support a "Remind me later" banner clickable - https://phabricator.wikimedia.org/T120056#1844597 (MeganHernandez_WMF) Quick, simple, safe!? That's great to hear. Wow. Need any... [14:10:56] Fundraising-Backlog: mobile donation form: expiration date error - https://phabricator.wikimedia.org/T120053#1844615 (atgo) I think we probably need to throw this one back to GC, but let's get Tech online to confirm. [14:25:49] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice impressions beacon corrupts 'mixins' property - https://phabricator.wikimedia.org/T120082#1844640 (AndyRussG) [14:48:08] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Add API for custom hide cookie reasons and durations, to support a "Remind me later" banner clickable - https://phabricator.wikimedia.org/T120056#1844703 (atgo) @andyrussg can you put an estimate on this? [15:19:20] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice impressions beacon corrupts 'mixins' property - https://phabricator.wikimedia.org/T120082#1844829 (atgo) @andyrussg @krinkle is this critical or can we wait until things settle down a bit? [15:20:29] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Technical-Debt: Fundraising scripts should not use global scope - https://phabricator.wikimedia.org/T120084#1844835 (atgo) @andyrussg let's talk about this today to triage how urgent/safe it is. [15:21:04] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Performance: Fundraising stylesheets and scripts should be minified - https://phabricator.wikimedia.org/T120083#1844838 (atgo) [15:28:06] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Notifications for donations made on Major Gifts annual appeal landing page - https://phabricator.wikimedia.org/T119920#1844851 (atgo) @eileenmcnaughton @awight @cwdent @ejegg heads up [16:43:23] is that coffee cup photo is really from a stock photo and nonfree? [17:48:14] haaaaaay ejegg ! [17:48:57] i am pretty sure that if we deployed DI right now we'd break adyen, this change should fix it: https://gerrit.wikimedia.org/r/#/c/256371/ -- but i can't figure out why the tests are failing! they pass for me. [17:48:58] hi! [17:49:18] i've never seen that error before, look familiar at all to you? [17:49:41] ooh, will look in 1 min [17:49:57] no hurry! thanks [18:19:24] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Notifications for donations made on Major Gifts annual appeal landing page - https://phabricator.wikimedia.org/T119920#1845330 (Ejegg) @CaitVirtue can you provide some more context? What is... [18:27:24] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: Investigate possible brief drop in banner history log rate on 2015-12-01 at 20:21 UTC - https://phabricator.wikimedia.org/T120058#1845367 (DStrine) [18:27:35] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add default order for Lybunt report to sort descending by greatest 2014 amount - https://phabricator.wikimedia.org/T119911#1845368 (DStrine) [18:27:46] Fundraising Dash, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review: Make major donation cutoff configurable - https://phabricator.wikimedia.org/T120001#1845369 (DStrine) [18:28:00] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work, Patch-For-Review: CentralNotice: add 'namespace' hide reason - https://phabricator.wikimedia.org/T120029#1845372 (DStrine) [18:28:53] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: LYBUNT: Change "lifetime total" to "Last year total" - https://phabricator.wikimedia.org/T119909#1845379 (XenoRyet) a:XenoRyet [18:29:10] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Notifications for donations made on Major Gifts annual appeal landing page - https://phabricator.wikimedia.org/T119920#1845382 (CaitVirtue) https://donate.wikimedia.org/w/index.php?title=Spec... [18:30:45] anyone got anything for scrum of scrums? [18:31:13] cwd: Just tell them "It's On." [18:31:17] That's all. :p [18:31:23] :D [18:31:27] you got it [18:31:56] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Notifications for donations made on Major Gifts annual appeal landing page - https://phabricator.wikimedia.org/T119920#1845394 (CaitVirtue) Hold up. @CCogdill_WMF is going to change it for t... [18:32:10] ejegg: You have Line of Sight on atgo? [18:34:36] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Notifications for donations made on Major Gifts annual appeal landing page - https://phabricator.wikimedia.org/T119920#1845403 (CCogdill_WMF) I'm changing the utm_source to =MG%%MAILING_ID%%.... [18:50:39] https://meta.wikimedia.org/w/index.php?title=Special:CentralNotice&subaction=noticeDetail¬ice=C1516_enWW_dsk_lw_FR – dunno what this means but it says "Bucket "A" has too many banners assigned." [18:50:56] Fundraising-Backlog, fundraising-tech-ops: Don't send us all the cron spam - https://phabricator.wikimedia.org/T119452#1845449 (Jgreen) Can you clarify the desired outcome? In short, cron will send mail if there's any output on STDOUT or STDERR. This is probably desireable because it spams for shell run... [18:50:57] AndyRussG: ^^ [18:53:15] Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, fundraising-tech-ops, and 2 others: Format Monolog messages to be easier to grep, bucket them - https://phabricator.wikimedia.org/T115746#1845472 (Jgreen) a:awight>Jgreen [18:53:32] hi K4-713 , sorry i didn't indicate |food. what's up? [18:53:48] Oh, ha. [18:53:50] Krinkle: hi! thanks! Yeah that's a known issue. But it's fine. [18:54:14] AndyRussG: okay :) [18:54:52] It's a warning that's given out when more than one banner assigned to a given bucket, which was expected to be an error case, though it is handled by CN, and FR decided they do want to use what CN does in that case [18:54:57] ejegg: I wanted to talk to [somebody] about the fraud widget in the dash being "wrong". [18:55:11] Krinkle: K4-713: thanks 4 the headsup! [18:55:18] A fraudy fraud widget? [18:55:25] Not really. :p [18:55:32] fundraising-tech-ops: monitor mail queues on fundraising servers - https://phabricator.wikimedia.org/T120118#1845489 (Jgreen) NEW a:Jgreen [18:55:35] fraud of a widget? [18:55:58] ejegg: Basically, when it's "wrong" with us, it can be an indication that single transactions are being retried multiple times for bad reasons. [18:56:28] ahh, got it. [18:56:44] Unfortunately, I think the way it's wired up now, makes perfect sense to us (well, okay. Me.) but is continuously damaging others' trust in our dash. [18:56:59] I'd blame p1004. [18:57:05] Almost entirely. [18:57:22] atgo asks if theres a phab task :P [18:57:38] This was the thing PPena brought up in standup an hour ago. [18:57:42] So, if there is, it's not mine. [18:58:39] I wanted to intervene early because this keeps happening, and I think it's destroying our future ability to get time to work on the dash. [18:58:50] Like, with this specific widget. [18:59:01] I'm sure there's a phab task from, like, last year. [18:59:30] can we chat in like 20 min? [18:59:34] Maybe. [18:59:37] Probably not. [18:59:40] But that's all I have. :p [19:00:29] k. ill take a look a the query [19:00:42] To re-nutshell: I think the widget is written from a "system performance" perspective, and it's being compared to another system that's built to unique the transactions first. [19:00:51] Make sense? [19:01:21] yeah, and seems doable to fix [19:01:27] Rad. [19:01:37] I'll be around at some point later once all the lunching stops. [19:17:43] jessicarobell: hi! quick question: are banners supposed to show over the media viewer? For example, https://en.wikipedia.org/wiki/Coffee#/media/File:A_small_cup_of_coffee.JPG (or go to any article with a banner showing and click on an image) [19:18:12] When that happens you can't close the media viewer and go back to the article without closing the banner [19:25:35] "unbreak now!"! [19:28:00] +1 awight [19:28:13] Also... [19:28:20] awight: I assume you're not in the office today? [19:29:12] I'm basing this assumption on you being on IRC and not at your desk. [19:30:05] hi AndyRussG. Sorry, on a call. Will get back to you asap [19:30:33] K4-713: iam [19:30:35] in the bat cave [19:30:45] orly [19:30:51] I snuck in at... 11 [19:35:33] jessicarobell: K thanks! [19:36:51] (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/256371 (owner: Cdentinger) [19:44:52] ejegg: Remind me whether I need a new database for the dash? [19:45:27] Where (and how) am I supposed run the stuff in schema? [19:46:38] awight: ejegg: cwd|afk: XenoRyet: any thoughts on the relevance of this CentralNotice config-based hide-cookie expiry mechanism? https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FCentralNotice/e179c69431ce23667f9551187899688cf2e8fd7a/CentralNotice.php#L120 [19:47:25] I want to add an API that lets JS set hide cookies w/ arbitrary durations (see https://phabricator.wikimedia.org/T120056) [19:48:10] AndyRussG: my only thought is that we still want to discourage too much experimentation with cookie lifetimes [19:48:12] ...but I'm willing to be persuaded it's a bad idea and that we should always have a config-based means of controlling (really, just shortening) expiry of existing times, which is what the PHP-side actually provides [19:48:39] Hmmm [19:49:02] Perhaps banners could include metadata describing special hide behaviors and durations [19:49:15] awight: in XML maybe? [19:49:23] err, "include metadata" meaning banners would use the API you're describing [19:50:06] but I'm thinking that we shouldn't mess with cookie expiry directly, instead this data will be kept as encoded K/V stuff, like banner diet does currently [19:50:40] awight: this is for a "Remind me later" button that would potentially go live in the coming days/weeks, i.e. before any FR stuff goes KV store [19:51:12] KV store in the most generic sense. [19:51:15] It wouldn't be a new cookie, just allow JS flexibility for setting hide reasons and durations [19:51:34] Hmmm [19:52:03] How about a hard-coded maximum duration of 1 month for non-predefined hide reasons (which are 'close' and 'donate') [19:52:20] In this case the idea is a shorter close time than the normal close (1 day vs. 1 week) [19:52:24] My concern is that cookies are forever ;) So we lose the ability to interpret "remind me later" data down the road [19:52:54] ? [19:54:06] Maybe that's not true. Cos we'll be using the hide cookies, which include a reason [19:54:09] I think we need this for anything to get through CI: https://gerrit.wikimedia.org/r/256479 [19:54:22] core change broke a bunch of extension tests [19:54:32] awight / AndyRussG ^^ [19:55:48] Hmmm! [19:56:21] awight: yeah a reason'll be there. We'd have to make sure we have all required reason codes for BH log minifier, that's all [19:56:31] ejegg: example of failing tests? [19:56:34] Hi AndyRussG. hmm, I want to say that they shouldn't but I cannot tell you for sure. This is a question for the-wub. Or maybe Seddon. Seddon, do you have any insight on this? [19:57:17] Seddon: ^ banners showing up over mediaviewer images [19:57:35] AndyRussG: Okay, I guess there's no problem setting shorter hide cookies. [19:58:30] awight: I'll send up the patch, I'm surely overlooking stuff 8p [20:01:46] AndyRussG: https://integration.wikimedia.org/ci/job/mwext-DonationInterface-testextension-zend/2097/consoleFull [20:02:09] We capture the whole page output for a few of our not-so-unit tests [20:02:57] lots of Found alias defined for Mytalk when searching for special page aliases for MyTalk. Case mismatch? [20:03:37] ejegg: K thx [20:04:40] maybe core needs some integration tests like that in the CI suite [20:07:14] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Notifications for donations made on Major Gifts annual appeal landing page - https://phabricator.wikimedia.org/T119920#1845689 (Ejegg) OK, so it sounds like we should notify on specific utm s... [20:13:23] (PS1) Awight: Fix issues with installation schema [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256488 [20:21:15] ejegg: aargh. right, so we're testing DI against a master mw-core [20:21:40] yeah [20:22:02] and that thing that got merged to master throws a couple warnings every time it renders an anon page view [20:22:08] which should be fixed in any case [20:22:19] Can we fix it in master? [20:22:20] but really messes with us since we have tests that render the full page [20:22:26] yep, that patch is against master [20:22:42] but. but [20:22:46] ?? [20:24:08] awight: ejegg: if u follow the code path of where that MyTalk string goes, it looks like switching to the cannonical Mytalk should have no ill side effects [20:24:54] yeah, and the non-canonical case will spam the logs with warnings [20:26:14] Is it so urgent we shouldn't wait for a core dev to weigh in tho? [20:26:20] Bassoon! [20:26:53] thanks awight! [20:27:02] AndyRussG|school: We need to get some Adyen fixes up [20:31:38] (CR) Ejegg: [C: 2] "Thanks for the cleanup!" (2 comments) [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256488 (owner: Awight) [20:32:58] (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/256371 (owner: Cdentinger) [20:37:09] (CR) Ejegg: [C: 2] "Tests were failing due to a recently-merged core commit. Broken in I6f44e3e5d97ea917e4a03af47f3795792e4ca122, fixed in Ica66b314088275d43" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/256371 (owner: Cdentinger) [20:39:10] Fundraising Dash, Fundraising-Backlog: [epic] make Dash useful for December fundraising campaign - https://phabricator.wikimedia.org/T118048#1845749 (atgo) Open>Resolved [20:45:46] ejegg: thanks for tracking that down! [20:46:03] testing against mw-core, didn't even think of that [20:46:17] heh, nice to dive into the main project once in a while [20:46:25] for sure [20:46:30] interact with other people... [20:47:04] cwd did you see the suggestion on the css patch: https://gerrit.wikimedia.org/r/#/c/256157/ [20:47:36] ejegg: yep totally, was just striking out to do that when i hit those failing tests [20:47:55] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Notifications for donations made on Major Gifts annual appeal landing page - https://phabricator.wikimedia.org/T119920#1845791 (Ejegg) a:Ejegg [20:48:03] it's funny, that was totally rendering differently yesterday and not overflowing the div [20:48:21] rockin [20:48:26] oh weird [20:48:41] but yeah we can set height manually, even though there's a weird script that resets it [20:53:09] (Merged) jenkins-bot: correct iframe target [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/256371 (owner: Cdentinger) [20:54:57] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work, FR-GlobalCollect: WR1 audit parser emitting multiple bad refund lines - https://phabricator.wikimedia.org/T119927#1845819 (atgo) @awight do you think we can punt this to after big-en cleanup? [20:55:49] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Saving a donation is very slow for Engage - https://phabricator.wikimedia.org/T118415#1845822 (atgo) @awight @leannes is this resolved? I'd like to close. [20:56:08] (PS2) Awight: Make major donation cutoff configurable [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256271 (https://phabricator.wikimedia.org/T120001) (owner: Ejegg) [20:56:14] (CR) Awight: [C: 2] Make major donation cutoff configurable [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256271 (https://phabricator.wikimedia.org/T120001) (owner: Ejegg) [20:56:40] (PS4) Awight: fix missing arg on upgrade [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/254356 (https://phabricator.wikimedia.org/T116877) (owner: Eileen) [20:56:54] thanks again awight! Definitely a short-term fix there - that settings box is wack [20:58:09] Fundraising Sprint Vengaboys, Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, and 2 others: Custom group on specific contribution types not working - https://phabricator.wikimedia.org/T116682#1845828 (atgo) Open>Resolved Resolving since it w... [20:59:29] Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, and 4 others: Amazon donor details missing when they donate after session timeout - https://phabricator.wikimedia.org/T117827#1845848 (atgo) Open>Resolved This is probably... [21:00:28] (Merged) jenkins-bot: Make major donation cutoff configurable [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256271 (https://phabricator.wikimedia.org/T120001) (owner: Ejegg) [21:16:01] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Add API for custom hide cookie reasons and durations, to support a "Remind me later" banner clickable - https://phabricator.wikimedia.org/T120056#1845876 (AndyRussG) a:AndyRussG [21:19:46] fundraising-tech-ops: monitor mail queues on fundraising servers - https://phabricator.wikimedia.org/T120118#1845896 (Jgreen) Open>Resolved this is done [21:20:05] fundraising-tech-ops: monitor mail queues on fundraising civicrm servers - https://phabricator.wikimedia.org/T120118#1845898 (Jgreen) [21:22:30] Fundraising Sprint Yo La Tengo, Wikimedia-Fundraising, Unplanned-Sprint-Work: Make FR banners not display over Mediaviewer - https://phabricator.wikimedia.org/T120130#1845900 (AndyRussG) NEW a:AndyRussG [21:23:06] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: CentralNotice: Add API for custom hide cookie reasons and durations, to support a "Remind me later" banner clickable - https://phabricator.wikimedia.org/T120056#1845909 (AndyRussG) [21:23:48] Fundraising-Backlog: mobile donation form: expiration date error - https://phabricator.wikimedia.org/T120053#1845922 (DStrine) @awight is sure that this is on GC [21:25:57] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, FR-GlobalCollect: Globalcollect Status 25/404 errors - https://phabricator.wikimedia.org/T120030#1845925 (DStrine) p:Triage>High [21:27:42] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice impressions beacon corrupts 'mixins' property - https://phabricator.wikimedia.org/T120082#1845937 (AndyRussG) Not at all critical, also easy to fix. :) [21:49:54] Fundraising Sprint Yo La Tengo, Wikimedia-Fundraising, Unplanned-Sprint-Work: Make FR banners not display over Mediaviewer - https://phabricator.wikimedia.org/T120130#1846048 (AndyRussG) Fixed for the current [[ https://meta.wikimedia.org/w/index.php?title=Special:CentralNotice&subaction=noticeDetail&... [21:51:37] Lame, just got kicked from the hangout. [21:54:46] yeah i got that too [21:57:00] Guess google decided the meeting was over [22:01:01] Fundraising Sprint Yo La Tengo, Fundraising Tech Backlog, Fundraising-Backlog, Unplanned-Sprint-Work, Documentation: Document IP and Session velocity filters - https://phabricator.wikimedia.org/T92054#1846075 (awight) [22:03:06] following cache clearing, banners on the big English campaign no longer overlay Mediaviewer. So far all other banner functionality (like the yellow reminder band) seems to work :) [22:03:40] cya soon! [22:03:44] awesome! [22:09:10] Fundraising Sprint Yo La Tengo, Wikimedia-Fundraising, Unplanned-Sprint-Work: Make FR banners not display over Mediaviewer - https://phabricator.wikimedia.org/T120130#1846089 (Pcoombe) @AndyRussG What did you do to fix this? [22:09:26] Fundraising-Backlog: mobile donation form: expiration date error - https://phabricator.wikimedia.org/T120053#1846090 (Ppena) I will send it off to GC [22:18:09] (PS1) Ejegg: Let user add rows to wmf_campaigns_campaign [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/256590 (https://phabricator.wikimedia.org/T119920) [22:18:26] awight: thanks for the tip re: wmf_campaigns! [22:18:58] I think that tiny patch ^^^ should let users do it all through the UI with no db fiddling required. [22:21:30] no worries, I'm sure you would have rewritten it in an hour ;) [22:23:21] ejegg: I don't understand what's going on in that patch... [22:23:48] that warning was a silly thing I added to catch when campaigns are added through the Civi option value dialog rather than the wmf_campaigns one [22:24:11] oh, where do you add them in wmf_campaigns? [22:24:45] aaah, wait I think I see where you're going [22:25:00] The edit form adds it fine if the key doesn't exist already [22:25:38] (looking) [22:26:55] https://en.wikipedia.org/wiki/List_of_numbers [22:26:58] ejegg: Maybe I'm way off there: https://collab.wikimedia.org/wiki/Fundraising/MajorGiftsandFoundations#Direct_Mail_Appeal_-_Campaign_Management [22:27:39] awight: yeah, that's the way to add 'em [22:27:47] But without the patch you can't add notifications [22:27:55] unless you hand craft the edit URL [22:28:20] That's reediculous [22:28:31] I'm trying to understand how this can be so borken [22:29:53] awight: do you know the civi function to generate an intra-civi URL? I'd like to add a link to that multiple choice options page at the top of the campaigns config [22:30:22] (PS1) Cdentinger: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/256591 [22:30:31] yaaay IRC [22:30:50] same link as comes out of CRM/Custom/Page/Field.php line 79-80 [22:30:56] (CR) Cdentinger: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/256591 (owner: Cdentinger) [22:32:21] (CR) Awight: [C: 2] "Elegant!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/256590 (https://phabricator.wikimedia.org/T119920) (owner: Ejegg) [22:33:08] aha, CRM_Utils_System::url [22:34:36] one step ahead of me! yep [22:35:07] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/256591 (owner: Cdentinger) [22:35:09] (CR) jenkins-bot: [V: -1] Let user add rows to wmf_campaigns_campaign [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/256590 (https://phabricator.wikimedia.org/T119920) (owner: Ejegg) [22:35:53] (CR) Awight: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/256590 (https://phabricator.wikimedia.org/T119920) (owner: Ejegg) [22:36:02] fnord? [22:36:10] cross-repo dependencies? [22:37:40] (CR) Awight: Let user add rows to wmf_campaigns_campaign [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/256590 (https://phabricator.wikimedia.org/T119920) (owner: Ejegg) [22:37:47] (CR) Awight: [C: 2] Let user add rows to wmf_campaigns_campaign [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/256590 (https://phabricator.wikimedia.org/T119920) (owner: Ejegg) [22:38:17] gotta find me an outlet, brb [22:40:06] *gasp* we're showing readers 1,000 banner impressions? [22:41:48] (Merged) jenkins-bot: Let user add rows to wmf_campaigns_campaign [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/256590 (https://phabricator.wikimedia.org/T119920) (owner: Ejegg) [22:45:37] (PS1) Cdentinger: update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/256594 [22:46:33] awight: i haven't deployed in a minute and really don't want to nuke DI right now, would you mind just giving a quick look? ^^ [22:50:13] cwd: shore [22:50:25] Fundraising Sprint Yo La Tengo, Wikimedia-Fundraising, Unplanned-Sprint-Work: Make FR banners not display over Mediaviewer - https://phabricator.wikimedia.org/T120130#1846243 (AndyRussG) >>! In T120130#1846089, @Pcoombe wrote: > @AndyRussG What did you do to fix this? Changed the z-index property of... [22:51:08] cwd: looks correct! [22:51:52] thanks! [22:53:51] (CR) Cdentinger: [C: 2] update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/256594 (owner: Cdentinger) [22:55:34] Fundraising Sprint Yo La Tengo, Wikimedia-Fundraising, Unplanned-Sprint-Work: Make FR banners not display over Mediaviewer - https://phabricator.wikimedia.org/T120130#1846268 (Pcoombe) @AndyRussG Cool, I see your changes now. Can you ping me on any in-banner fixes in future, so that I can make sure th... [22:59:40] Fundraising Sprint Yo La Tengo, Wikimedia-Fundraising, Unplanned-Sprint-Work: Make FR banners not display over Mediaviewer - https://phabricator.wikimedia.org/T120130#1846282 (awight) @pcoombe: Sorry, I totally rubber stamped this fix. We thought you had gone to sleep, and decided this was urgent. [23:00:37] Fundraising Dash, Fundraising-Backlog: Make "Chart Loading" overlay non-modal - https://phabricator.wikimedia.org/T120142#1846287 (awight) NEW [23:01:24] 503 from gerrit? [23:01:30] gah [23:02:23] back [23:02:25] whew [23:07:50] !log updated payments from 02a3771cae6e4e74d9d754a8b075de20aa171adc to ff7a706219e72f7362f4e06386e6732933a40478 [23:07:53] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [23:09:59] Fundraising Sprint Yo La Tengo, Wikimedia-Fundraising, Unplanned-Sprint-Work: Make FR banners not display over Mediaviewer - https://phabricator.wikimedia.org/T120130#1846330 (Pcoombe) No problem. The fix was great, thanks for doing it so quickly! But banners come and go frequently and we're lacking i... [23:11:32] nothing appears to have fallen over [23:16:04] (PS1) Ejegg: Add link to edit campaign option values [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/256600 (https://phabricator.wikimedia.org/T119920) [23:18:53] (PS1) Ejegg: Sort disabled campaigns at the bottom [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/256603 (https://phabricator.wikimedia.org/T119920) [23:19:08] (CR) jenkins-bot: [V: -1] Sort disabled campaigns at the bottom [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/256603 (https://phabricator.wikimedia.org/T119920) (owner: Ejegg) [23:21:11] Fundraising Sprint Yo La Tengo, Fundraising Tech Backlog, Fundraising-Backlog, Unplanned-Sprint-Work, Documentation: Document IP and Session velocity filters - https://phabricator.wikimedia.org/T92054#1846373 (awight) a:K4-713 [23:22:29] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/256603 (https://phabricator.wikimedia.org/T119920) (owner: Ejegg) [23:25:12] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work, Patch-For-Review: Notifications for donations made on Major Gifts annual appeal landing page - https://phabricator.wikimedia.org/T119920#1846375 (Ejegg) a:Ejegg>CaitVirtue Good news... [23:29:58] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/256604 [23:31:47] (CR) Ejegg: [C: 2 V: 2] Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/256604 (owner: Ejegg) [23:32:22] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work, Patch-For-Review: Notifications for donations made on Major Gifts annual appeal landing page - https://phabricator.wikimedia.org/T119920#1846396 (CaitVirtue) @ejegg I added my email addres... [23:32:58] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work, Patch-For-Review: Notifications for donations made on Major Gifts annual appeal landing page - https://phabricator.wikimedia.org/T119920#1846397 (CaitVirtue) @LeanneS I'll add you and I an... [23:36:35] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work, Patch-For-Review: Notifications for donations made on Major Gifts annual appeal landing page - https://phabricator.wikimedia.org/T119920#1846398 (Ejegg) Sorry @CaitVirtue, that warning box... [23:37:33] (PS2) Awight: Sort disabled campaigns at the bottom [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/256603 (https://phabricator.wikimedia.org/T119920) (owner: Ejegg) [23:37:45] (CR) Awight: "PS2: manual rebase" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/256603 (https://phabricator.wikimedia.org/T119920) (owner: Ejegg) [23:37:59] i blew it on the live adyen test today [23:38:21] there is a bunch of config that needs to get generated on their site and plumbed into localsettings [23:38:46] ejegg|powerquest: Seems that greg-g just solved our problem, gerrit wanted a manual rebase but for some reason didn't show the button [23:39:10] (PS1) Ejegg: Fix jshint nitpick [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256606 [23:39:21] h/t to twentyafterfour, actually [23:39:23] awight: ahh, odd [23:39:32] 23:30 <+twentyaft> I've seen that before, the only solution was to rebase the patch locally [23:39:41] thanks! [23:40:02] cool [23:43:07] Fundraising-Backlog, fundraising-tech-ops: Don't send us all the cron spam - https://phabricator.wikimedia.org/T119452#1846411 (awight) Agreed. I'm not totally sure what we want, but something like: * SmashPig continues to log verbosely to syslog. * SmashPig only logs to stdout if it's run from an inter... [23:44:30] MBeat: Did you happen to email GC about the 404s? [23:44:53] yes, let me check for a reply [23:44:58] :) [23:45:17] thanks--please CC fr-tech when continuing that thread... [23:45:19] Fundraising-Backlog: mobile donation form: expiration date error - https://phabricator.wikimedia.org/T120053#1846420 (Ejegg) Oh hey, at least this seems like an improvement over sending the user back to us and only giving the validation message in the GET_ORDERSTATUS results! That was really annoying. [23:47:07] !log updated fundraising dashboard from 01a82b5e4909075e3190496e7fcda2b60f8d5d3c to 8412a2f5f91bb3a9f7873d6ac9fd5d7884eb988c [23:47:11] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [23:47:58] done awight. Sal said it’s difficult track the status 25’s but they’re looking into it [23:48:15] cwd: need any help with the Adyen testing? [23:48:33] MBeat: great! yeah I bet the 404 archaeology will be tough for them [23:48:53] ejegg: i was just gonna generate the live hash keys [23:49:07] nice! [23:49:14] they said not to go live on friday...but what about thursday? [23:50:41] i gotta roll soon, don't super wanna rush the config changes [23:50:53] got bad plus tickets tonight [23:51:20] well, I think we can go 'live' whenever, since we're not sending real donors through unless GC falls over [23:51:57] yeah, cool [23:53:21] Fundraising Dash, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi oauth screen confuses users - https://phabricator.wikimedia.org/T120149#1846450 (awight) NEW [23:53:56] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Help please: Sending email from CiviCRM: How do I check what my signature says? - https://phabricator.wikimedia.org/T120150#1846457 (CaitVirtue) NEW a:Eileenmcnaughton [23:54:01] Fundraising Dash, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi oauth screen confuses users - https://phabricator.wikimedia.org/T120149#1846465 (awight) [23:54:04] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Help please: Sending email from CiviCRM: How do I check what my signature says? - https://phabricator.wikimedia.org/T120150#1846467 (CaitVirtue) p:Triage>High [23:54:43] (PS1) XenoRyet: Add Default Order to WMF LYBUNT template. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/256607 (https://phabricator.wikimedia.org/T119911) [23:58:55] ok gotta bounce, i will get the rest of that dialed in tomorrow