[00:01:48] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: iframe not appearing for some people (confirmed modern browsers) - https://phabricator.wikimedia.org/T112181#1846502 (awight) I was able to reproduce the bug with Midori in private browsing mode, but not regul... [00:10:25] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: iframe not appearing for some people (confirmed modern browsers) - https://phabricator.wikimedia.org/T112181#1846522 (awight) Looks like one config difference is that paymentswiki is using the default `$wgReso... [00:10:47] ejegg: ^ I'm gonna try deploying that config, if you agree? [00:13:40] nice find! Let me look at it for a bit [00:14:18] (CR) Awight: [C: 2] "Great! It's nothing compared to the Civi api though..." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/256600 (https://phabricator.wikimedia.org/T119920) (owner: Ejegg) [00:15:09] ejegg: here's the evil magick code path: resources/src/mediawiki/mediawiki.js: if ( !mw.config.get( 'wgResourceLoaderStorageEnabled' ) ) { [00:15:15] awight: sure, let's turn RL storage on. Looks good to me. [00:15:22] ok. /me aims from hip [00:15:26] hehe [00:16:06] (Merged) jenkins-bot: Add link to edit campaign option values [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/256600 (https://phabricator.wikimedia.org/T119920) (owner: Ejegg) [00:18:21] !log Deploy paymentswiki config for T112181 [00:18:25] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [00:18:37] Fundraising Dash, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review: Dash widget to measure donations queue lag - https://phabricator.wikimedia.org/T120002#1846536 (Ejegg) a:Ejegg [00:18:48] MBeat: noting that I made a config change to paymentswiki just now. [00:18:57] I expect nothing to happen, though. [00:19:11] thanks for the alert [00:19:23] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: iframe not appearing for some people (confirmed modern browsers) - https://phabricator.wikimedia.org/T112181#1846541 (awight) Looks good now! [00:20:21] (PS1) Ejegg: Fix more problems with donation age / BE SQL [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256613 (https://phabricator.wikimedia.org/T120002) [00:20:35] Fundraising Sprint Vengaboys, Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Changing card type sometimes results in bad order_id reuse - https://phabricator.wikimedia.org/T116089#1846545 (awight) [00:22:18] (CR) Awight: [C: 2] Fix more problems with donation age / BE SQL (1 comment) [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256613 (https://phabricator.wikimedia.org/T120002) (owner: Ejegg) [00:22:47] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work, Patch-For-Review: Notifications for donations made on Major Gifts annual appeal landing page - https://phabricator.wikimedia.org/T119920#1846547 (awight) a:CaitVirtue>Ejegg Looks goo... [00:23:39] (Merged) jenkins-bot: Fix more problems with donation age / BE SQL [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256613 (https://phabricator.wikimedia.org/T120002) (owner: Ejegg) [00:31:10] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: iframe not appearing for some people (confirmed modern browsers) - https://phabricator.wikimedia.org/T112181#1846603 (Ejegg) Also working for me now in Midori! [00:31:51] Gonna skedaddle for a bit, will check in again later! [00:32:15] Fundraising-Backlog: [BUG] Spike: Why is Donation form stuck with 0 as donation amount; donors can't modify it. Fix why. - https://phabricator.wikimedia.org/T113530#1846607 (MBeat33) A donor using Chrome got the 0 error today at the following URL: https://payments.wikimedia.org/index.php?title=Special:Globa... [00:38:51] (CR) Awight: [C: 2] Sort disabled campaigns at the bottom (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/256603 (https://phabricator.wikimedia.org/T119920) (owner: Ejegg) [00:40:27] (Merged) jenkins-bot: Sort disabled campaigns at the bottom [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/256603 (https://phabricator.wikimedia.org/T119920) (owner: Ejegg) [00:41:34] Fundraising Sprint Yo La Tengo, Wikimedia-Fundraising, Unplanned-Sprint-Work: Make FR banners not display over Mediaviewer - https://phabricator.wikimedia.org/T120130#1846655 (AndyRussG) I also updated banners in the [[ https://meta.wikimedia.org/w/index.php?title=Special:CentralNotice&subaction=notic... [01:01:46] (PS1) AndyRussG: ext.centralNotice.display: Add API for custom hide cookie reasons and durations [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/256615 (https://phabricator.wikimedia.org/T120056) [02:30:07] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/256622 [02:30:24] (CR) Ejegg: [C: 2 V: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/256622 (owner: Ejegg) [02:32:19] !log updated CiviCRM from d5afa10383cfd41adbe798c3ed2aa97839be8bc2 to 8a3deedc04e4d3d1c1f78cb5b7ace7d8670f307a [02:32:24] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [02:37:02] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work, Patch-For-Review: Notifications for donations made on Major Gifts annual appeal landing page - https://phabricator.wikimedia.org/T119920#1846856 (Ejegg) Open>Resolved [02:37:20] Fundraising Dash, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review: Make major donation cutoff configurable - https://phabricator.wikimedia.org/T120001#1846859 (Ejegg) Open>Resolved [02:37:33] Fundraising Dash, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review: Dash widget to measure donations queue lag - https://phabricator.wikimedia.org/T120002#1846861 (Ejegg) Open>Resolved [02:37:45] Fundraising Dash, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work: Fix dash minification script - https://phabricator.wikimedia.org/T119924#1846862 (Ejegg) Open>Resolved [02:42:22] Fundraising-Backlog: [BUG] Spike: Why is Donation form stuck with 0 as donation amount; donors can't modify it. Fix why. - https://phabricator.wikimedia.org/T113530#1846866 (MBeat33) Also #175337: donor says they specified $50 but the next screen was an uneditable 0; will add their technical specs if they p... [02:51:06] Wikimedia-Fundraising: Clean up fundraising code (extra skins and allowed templates for foundationwiki) in CommonSettings.php - https://phabricator.wikimedia.org/T50493#1846873 (Peachey88) [05:49:08] Fundraising Dash, Fundraising Sprint Yo La Tengo, Unplanned-Sprint-Work: Fraud gauge widget is over-reporting fraud rates. - https://phabricator.wikimedia.org/T120169#1847081 (Ejegg) NEW a:Ejegg [05:50:09] (PS1) Ejegg: Don't count repeated attempts in fraud gauge [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256629 (https://phabricator.wikimedia.org/T120169) [06:29:55] (PS1) Ejegg: WIP use common filter component in fraud gauge [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256633 (https://phabricator.wikimedia.org/T89526) [06:32:50] Fundraising Dash, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Patch-For-Review: Add country & date filters to Fraud widget on Dash - https://phabricator.wikimedia.org/T89526#1847153 (Ejegg) a:Ejegg [06:38:09] Fundraising Dash: Add date filters to common filter component - https://phabricator.wikimedia.org/T120174#1847171 (Ejegg) NEW a:Ejegg [06:38:42] Fundraising Dash: Add date filters to common filter component - https://phabricator.wikimedia.org/T120174#1847183 (Ejegg) [06:38:43] Fundraising Dash, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Patch-For-Review: Add country & date filters to Fraud widget on Dash - https://phabricator.wikimedia.org/T89526#1847182 (Ejegg) [06:39:00] Fundraising Dash, Fundraising Sprint Yo La Tengo, Unplanned-Sprint-Work, Patch-For-Review: Fraud gauge widget is over-reporting fraud rates. - https://phabricator.wikimedia.org/T120169#1847184 (Ejegg) [07:20:26] (PS1) Spage: 'wikpedia' typo in API example [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/256637 [09:33:57] Wikimedia-Fundraising: Fundraising banner doesn't seem legitimate to some users - https://phabricator.wikimedia.org/T120190#1847460 (Sjoerddebruin) NEW [13:25:54] Fundraising-Backlog: Emails refer to out-of-date/inappropriate donation amounts - https://phabricator.wikimedia.org/T120214#1847943 (Wittylama) NEW [13:35:35] Fundraising-Backlog, fundraising-tech-ops: Don't send us all the cron spam - https://phabricator.wikimedia.org/T119452#1847962 (Jgreen) For "cron only mails us if there's an error" I can tweak the cron job to redirect STDOUT to /dev/null, leaving cron to spam for STDERR. Does that sound good? [13:42:47] Fundraising-Backlog: Emails refer to out-of-date/inappropriate donation amounts - https://phabricator.wikimedia.org/T120214#1847967 (Wittylama) [13:46:44] Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, fundraising-tech-ops, and 2 others: Format Monolog messages to be easier to grep, bucket them - https://phabricator.wikimedia.org/T115746#1847972 (Jgreen) > Perhaps we can just bucket the line that PHP emits, by ma... [13:51:56] Fundraising Sprint Yo La Tengo, Wikimedia-Fundraising, Unplanned-Sprint-Work: Make FR banners not display over Mediaviewer - https://phabricator.wikimedia.org/T120130#1847976 (AndyRussG) [13:55:16] Fundraising Sprint Yo La Tengo, Wikimedia-Fundraising, Unplanned-Sprint-Work: Make FR banners not display over Mediaviewer - https://phabricator.wikimedia.org/T120130#1847983 (AndyRussG) Following changes to banners in the Big English campaign, I also updated [[ https://meta.wikimedia.org/w/index.php?... [14:28:47] Fundraising-Backlog: Emails refer to out-of-date/inappropriate donation amounts - https://phabricator.wikimedia.org/T120214#1848072 (Wittylama) [15:21:59] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work, Patch-For-Review: CentralNotice: Add API for custom hide cookie reasons and durations, to support a "Remind me later" banner clickable - https://phabricator.wikimedia.org/T120056#1848235... [15:53:14] Fundraising-Backlog: Emails refer to out-of-date/inappropriate donation amounts - https://phabricator.wikimedia.org/T120214#1848392 (Wittylama) [16:02:45] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Give donors better message when error occurs after successful payment - https://phabricator.wikimedia.org/T120228#1848436 (Ejegg) NEW [16:09:47] Fundraising-Backlog: Emails refer to out-of-date/inappropriate donation amounts - https://phabricator.wikimedia.org/T120214#1848450 (atgo) @wittylama thanks for the report. We definitely tailor our emails, though some of what you're suggesting may be beyond our current technical feasibility because of the st... [16:10:24] Fundraising-Backlog: Emails refer to out-of-date/inappropriate donation amounts - https://phabricator.wikimedia.org/T120214#1848456 (Ejegg) We definitely had a problem with the 'last donation date' and 'last donation amount' fields used in the mail merge, but I thought we fixed that on 11/23. The email pict... [16:17:59] Fundraising-Backlog: Emails refer to out-of-date/inappropriate donation amounts - https://phabricator.wikimedia.org/T120214#1848485 (Wittylama) >>! In T120214#1848456, @Ejegg wrote: > @Wittylama, do you know of any bad emails since then? No. Apart from the other email problem regarding the French translat... [17:10:42] cwd: I tried to fix the fraud rate calculation with https://gerrit.wikimedia.org/r/#/c/256629/1 [17:11:02] (in the dash widget) [17:14:45] nice! [17:14:59] (CR) Cdentinger: [C: 2] Don't count repeated attempts in fraud gauge [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256629 (https://phabricator.wikimedia.org/T120169) (owner: Ejegg) [17:16:32] (Merged) jenkins-bot: Don't count repeated attempts in fraud gauge [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256629 (https://phabricator.wikimedia.org/T120169) (owner: Ejegg) [17:17:00] thanks cwd! K4 thinks ppl will trust the dash more if they see a fraud rate that matches the rate as measured elsewhere [17:17:57] yeah i think i heard that mentioned yesterday. good to see dash getting whipped back into shape! [17:21:50] I'd like to take a crack at the stream graph awight proposed in his email yesterday morning [17:24:37] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/256720 [17:24:55] (CR) Ejegg: [C: 2 V: 2] Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/256720 (owner: Ejegg) [17:26:25] !log updated fundraising dashboard from 8412a2f5f91bb3a9f7873d6ac9fd5d7884eb988c to bed9895563fc0f5d3b96791fae6ed104b7778f0d [17:26:30] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [17:40:23] Jeff_Green: Looks like some fun was had today. [17:40:33] just a little [17:40:57] Thanks for taking care of it. :) [17:41:55] no problem, it was a barrel of monkeys fun [17:42:45] Wow, a whole barrel? [17:42:53] I have but one question. [17:43:07] yeahhhh [17:43:07] When amq came back up, was it with empty queues? [17:43:36] no, it looked sorta like it picked up where it left off [17:43:48] That's good news. [17:44:04] Though, we're in a place now where the audit scripts would fill it all back in in about a day anyway. [17:44:19] yeah [17:44:34] If this were 2011, we'd be in trouble. [17:44:35] :D [17:44:48] indeed [17:45:17] So... any theories about why 6:30something AM? [17:45:19] Because I have one. [17:45:32] Totally unsubstantiated. [17:45:49] Fundraising-Backlog: GC 12/1 donor received 'Forbidden' error for successful donation - https://phabricator.wikimedia.org/T120038#1848906 (atgo) [17:46:09] why? [17:47:11] Fundraising-Backlog: PayPal recurring annual donation did not reach Civi - https://phabricator.wikimedia.org/T119518#1848927 (atgo) [17:47:58] K4-713: have you had a look at the ganglia graphs? there's a lot of detail re. mq [17:48:02] Fundraising-Backlog: GC 12/1 donor received 'Forbidden' error for successful donation - https://phabricator.wikimedia.org/T120038#1848936 (K4-713) Bread Crumb #1 - This can happen on the payments cluster if something happens to the user's session between the time they leave for GC, and the time they come bac... [17:48:12] Jeff_Green: Ha, no. [17:48:21] I miss looking at ganglia graphs. [17:48:33] * K4-713 goes to look at happy graphs [17:48:40] the donations queue size is bizarre [17:49:14] its as though we're suddenly processing them much faster [17:49:31] Fundraising-Backlog: GC 12/1 donor received 'Forbidden' error for successful donation - https://phabricator.wikimedia.org/T120038#1848959 (K4-713) Also: We can absolutely grep for the forbidden log message in our logs. So, we totally have a way of finding out how many people are getting this. [17:49:48] er [17:50:01] Oh. Wait. That begins to substantiate my theory. [17:50:08] orlly [17:50:11] My theory is: Audit job ran. [17:50:19] And blew up the queue. [17:50:32] does that not run regularly? [17:50:34] I wish awight were here to see this. [17:50:35] But... [17:50:39] Nah, nightly. [17:50:46] But, yesterday was kind of freaking huge. [17:50:56] So, that's unusual thing #1. [17:51:07] you're looking at the queue size graphs? [17:51:37] Also, I used to mandate that before we add "new" donations to the donations queue via an audit script, we look to see if they are already in the db. I think at some point, it was decided that the queue consumer should do that check. [17:51:47] That would lead to this. [17:51:57] ...particularly the quick ack. [17:52:13] a queue query storm? [17:52:13] "Already recorded" gets tossed early. [17:52:25] yep [17:52:28] Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice: Back button breaks the banner form in Firefox - https://phabricator.wikimedia.org/T114391#1849002 (DStrine) [17:52:50] Still just a theory, though, but it sounds good so far. [17:53:08] do we have debug information for the audit job? [17:53:18] All of them, yes. [17:53:19] i.e. can we see where it got before things went kabloey? [17:53:33] Well... so... that might not tell us anything. [17:54:14] But, if something was in the process of stuffing the hell out of the queue when it blew, it should be visible in the Jenkins logs. [17:54:23] All the audit jobs go through fundraising jenkins. [17:55:01] The harder case would be if an audit job successfully stuffed the hell out of the queue and then a regular donation was the last straw. [17:55:28] ejegg: Hey. Fun morning? :) [17:55:44] Fundraising Dash, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review: Fraud gauge widget is over-reporting fraud rates. - https://phabricator.wikimedia.org/T120169#1849039 (DStrine) [17:55:53] K4-713: shouldn't we be able to see the hell-stuffing of a queue in the amq queue size graphs? [17:55:55] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising, Unplanned-Sprint-Work: Make FR banners not display over Mediaviewer - https://phabricator.wikimedia.org/T120130#1849040 (DStrine) [17:55:57] which queue would bloat? [17:56:05] K4-713: yeah, exciting wake-up call! [17:56:06] donations. [17:56:50] K4-713: ah ha! so it could have been the audit queue that filled up, not the donations queue? [17:56:55] K4-713: got this fraud rate recalc out btw: https://gerrit.wikimedia.org/r/#q,e566324,n,z [17:57:02] audit queue = donations queue. [17:57:15] ejegg: hi! i was just commenting on that task - when will that go to prod? [17:57:15] oh...right [17:57:22] hrm [17:57:26] Oh. But. [17:57:27] K4-713: the donations queue size rampup seems to have started in earnest around 15:25-15:30 [17:57:37] UTC, yeah? [17:57:39] K4-713: don't most audit processors insert directly into db? [17:57:45] utc [17:57:47] ejegg: hahahaha, no. [17:57:55] oh, huh [17:58:23] ejegg: They just file everything directly into the donations queue, and these days I don't think it even checks to make sure it's new information first. [17:59:03] Jeff_Green: Isn't there something insane with memory allocation in amq, in which a large number of messages fill up a block that isn't released until *all* the messages in that block are ack'd? [17:59:20] And... the message blocks contain messages across all queues? [17:59:29] K4-713: there's another interesting data point which is that the job that polls activemq to report to ganglia stopped getting responses from activemq after 14:01 [17:59:58] hummm [18:00:05] Well, crap. Standup time. [18:00:13] Must stop doing the work to talk about the work. [18:00:21] wait a minute. something re. that ganglia thing doesn't add up. [18:00:30] Please carry on without me. [18:00:35] you should work on talking about work [18:00:40] I'll tell them you're all champions. [18:09:04] AndyRussG|thnrgx: you just got a round of applause in the standup, fyi :D [18:10:36] Fundraising-Backlog: Emails refer to out-of-date/inappropriate donation amounts - https://phabricator.wikimedia.org/T120214#1849095 (CCogdill_WMF) Thanks for the report, @Wittylama. @atgo hit it pretty spot on: > Example 1) That 0 amount email is definitely a problem - @CCogdill_WMF do you think this was... [18:14:18] ejegg: would you mind throwing those updates into a quick email to fr-all so that they have something to refer to? [18:14:25] will do! [18:14:29] danke [18:14:40] Hoping to get the country filter for the fraud widget out soon too [18:15:00] rad!! [18:16:07] Fundraising-Backlog: Emails refer to out-of-date/inappropriate donation amounts - https://phabricator.wikimedia.org/T120214#1849151 (Wittylama) Thank you @CCogdill_WMF! [18:16:49] cwd: nice ceiling! [18:17:47] i put quilts up there to quiet this room down [18:18:33] Fundraising Dash, Fundraising-Backlog: Make "Chart Loading" overlay non-modal - https://phabricator.wikimedia.org/T120142#1849164 (atgo) p:Triage>Lowest [18:18:42] Fundraising Dash, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi oauth screen confuses users - https://phabricator.wikimedia.org/T120149#1849166 (atgo) p:Triage>Low [18:19:11] MBeat: https://phabricator.wikimedia.org/T120228 [18:20:14] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Give donors better message when error occurs after successful payment - https://phabricator.wikimedia.org/T120228#1849179 (Ejegg) per @K4-713 in standup, let's send donors to TY page and just make noise internally [18:24:37] ejegg: am i reading correctly that the dash fraud logic has been updated? [18:24:49] atgomez: yep, just deployed an hr ago [18:25:05] Will send that email out soon [18:30:45] brt for standup, my mic is being weird. [18:43:51] Fundraising-Backlog: Emails refer to out-of-date/inappropriate donation amounts - https://phabricator.wikimedia.org/T120214#1849322 (atgo) Open>Resolved a:atgo Closing this one and noting this task as a symptom in the dedupe task: T77938 Thanks again, @wittylama [18:44:25] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: [epic] Dedupe CiviCRM - https://phabricator.wikimedia.org/T77938#1849328 (atgo) Noting a symptom of this problem: T120214 [18:44:52] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Don't show donors error messages when error occurs after successful payment - https://phabricator.wikimedia.org/T120228#1849331 (Ejegg) [18:45:41] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work, FR-GlobalCollect: WR1 audit parser emitting multiple bad refund lines - https://phabricator.wikimedia.org/T119927#1849341 (atgo) p:Triage>Normal [18:46:08] Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, and 2 others: Build Frig: tools to help update our deployment branches - https://phabricator.wikimedia.org/T116820#1849347 (atgo) p:Triage>Normal [18:46:18] Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising-Backlog: Donation form error message: "No processors available" - https://phabricator.wikimedia.org/T117872#1849349 (atgo) p:Triage>High [19:06:35] (PS1) Ejegg: Catch error queueing final status message [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/256737 (https://phabricator.wikimedia.org/T120228) [19:21:55] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Help please: Sending email from CiviCRM: How do I check what my signature says? - https://phabricator.wikimedia.org/T120150#1849523 (atgo) After a little digging, it seems like this is something that you can do, but I'm not totally sure how. Maybe when... [19:30:53] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Help please: Sending email from CiviCRM: How do I check what my signature says? - https://phabricator.wikimedia.org/T120150#1849572 (CaitVirtue) Open>Resolved Mystery solved: there are no email signature on CiviCRM. You have to add them manually... [19:32:00] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Help please: Sending email from CiviCRM: How do I check what my signature says? - https://phabricator.wikimedia.org/T120150#1849580 (atgo) Resolved>Invalid [19:32:55] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Create email signature functionality - https://phabricator.wikimedia.org/T120261#1849582 (CaitVirtue) NEW [19:38:23] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Create email signature functionality - https://phabricator.wikimedia.org/T120261#1849626 (Eileenmcnaughton) Is this something where having a token {signature} that you could add would work - or would you always want it added without you having to do that? [19:44:54] Fundraising-Backlog, Epic, FR-Fraud: Fraud and Chargebacks - https://phabricator.wikimedia.org/T88766#1849658 (atgo) [19:55:39] (PS1) Ejegg: Add ganglia link to donation age widget [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256744 (https://phabricator.wikimedia.org/T120002) [20:17:00] (CR) Cdentinger: [C: 2] "Could put the URL in config, maybe if we start talking about templates again" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256744 (https://phabricator.wikimedia.org/T120002) (owner: Ejegg) [20:18:20] (Merged) jenkins-bot: Add ganglia link to donation age widget [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256744 (https://phabricator.wikimedia.org/T120002) (owner: Ejegg) [20:24:49] https://letsencrypt.org/2015/12/03/entering-public-beta.html [20:24:54] hooray! [20:25:04] green bars, green bars all around [20:29:23] (PS1) Ejegg: Tighten up whitespace in X-by-Y settings [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256748 [20:32:29] I have my bell ready [20:35:22] Oh, it is close to bell time. [20:36:35] ding ding ding ding [20:36:36] eileen: I had a quick question about this report in Civi, if you've got a minute. [20:36:42] XenoRyet: sure! [20:37:33] It looks like if you want to do sorting, you just add in an orderBy() function and set _orderBy to some SQL to do what you want. I've done that, but it's not doing any actual ordering. [20:37:48] Am I missing something? [20:38:39] sounds right-ish - is there somewhere I can see the code? [20:39:24] XenoRyet: have you seen the tab that can show you the sql btw? [20:39:39] I've got a sandbox patch on staging right now. Also this patch https://gerrit.wikimedia.org/r/#/c/256607/ [20:40:02] Yea, I did see that. My other changes are showing up in the SQL, but no order by clause ever seems to. [20:40:41] report instance = 50? [20:41:46] I was just generating stuff from the template, I don't think I ever saved anything. [20:42:25] the issue is that report extends the core lybunt [20:42:33] which overrides the upstream report class [20:42:40] & skips calling orderBy [20:42:43] Would you like coffee while you wait sir? [20:42:54] opps - where did that come from [20:42:59] hehe [20:43:03] https://github.com/civicrm/civicrm-core/blob/master/CRM/Report/Form/Contribute/Lybunt.php#L421 [20:44:32] Huh, so have to override postProcess too then I guess. Pull the orderby back in. [20:45:16] Cool, that's probably all I need. Thanks for the help [20:45:48] I would argue that the core lybunt should be patched to call $this->buildQuery(); [20:46:04] but I can see that overriding postProcess is easier! [20:46:42] Yea, might just stay quick and dirty. There's already a whole mess of todos for this thing when we have more time. [20:46:57] actually that core one gets scary pretty quickly [20:47:15] so I probably would not go near it with a barge pole [20:47:31] Peeked around in there a bit, it is kind of a beast. [20:47:38] :-) [20:47:55] cwd: You should like this article http://insights.dice.com/2015/12/03/choosing-postgresql-over-mysql-mariadb/ [20:49:40] eileen: One more thing that I was going to track down but you might just know off the top of your head. That total LifeTime donations field they wanted to change. Where's that get generated? [20:49:54] If you don't know off the top of your head, don't worry, it shouldn't be hard for me to track down. [20:50:47] https://github.com/civicrm/civicrm-core/blob/master/CRM/Report/Form/Contribute/Lybunt.php#L400 [20:50:59] Rad, thanks [20:51:28] AndyRussG: eminently reasonable :) [20:51:45] ;) [20:56:00] man, lots of nerd news today https://secure.php.net/archive/2015.php#id2015-12-03-1 [20:56:20] also https://github.com/apple [20:56:40] "The null coalescing operator (??)" [20:57:21] OSX now GPL'd? [20:57:50] AndyRussG: well just the swift language afaik, but it's still pretty un-apple [20:58:00] Yay! [20:58:12] Indeed [20:58:48] giving something back to the community they stole their OS from [20:58:51] * cwd ducks [20:59:09] indeed [21:00:51] cwd: XenoRyet: ejegg: atgomez: opinions about a CentralNotice deploy (via the evening SWAT at 0:00 UTC, 16:00 Pacific Time)? If possible, and if u agree, I'd hope to get this out (+ other undeployed patches in master): https://gerrit.wikimedia.org/r/#/c/256615/ [21:01:35] I don't think I have any objections [21:01:42] :) [21:02:17] heh i really don't know enough to say but i trust your judgment [21:03:45] There are 3 minor un-deployed CiviCRM patches in there too [21:04:56] ah - I didn't realise stand-up was earlier now [21:05:51] Hmm I'm pretty sure it's fine but that patch ^ does need CR. awight was concerned about making easy to create longlasting cookies again, so I added a hard-coded maximum duration for hide cookie reasons not described in config [21:06:02] eileen: yeah I missed it too [21:06:16] I think next week it's back to the other time? [21:14:20] AndyRussG: looking at changes [21:14:26] ejegg: thanks! [21:17:57] ejegg: if you have an explanation for why the old (and for the most part, the new) code didn't trust cookie expiry times to expire hide cookies (maybe so we could manually expire them via config?) in ext.centralNotice.display.hide.js that'd be cool. (I'm sure the code I put in that file was just following legacy BTW.) NEway, that's the only bit that perturbs me a little... [21:18:18] AndyRussG: just writing that comment now! [21:18:24] Woohoo! [21:24:21] atgomez: I think it might be worth showing the fr team the ui on staging - but am also aware they might be too busy to care! [21:27:23] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Saving a donation is very slow for Engage - https://phabricator.wikimedia.org/T118415#1850107 (LeanneS) @atgo Yes, haven't heard of slowness recently so I think it's fine to close. [21:28:34] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Saving a donation is very slow for Engage - https://phabricator.wikimedia.org/T118415#1850108 (atgo) Open>Resolved [21:31:39] eileen: caitlin's not in the room right now… but i'll check in with them later [21:31:48] cool [21:44:16] whatever happened to our gerrit pinger? [21:51:20] eileen: they would be happy to look at it - can you set up a time with them? [21:51:39] also, eileen and ejegg, leanne is going to make a phab task about adding janelle to some of those emails [21:51:59] which emails? I guess the phab task will say [21:52:15] I should set up a time with Catilin + leanne? [21:52:35] atgomez: If it's amount or campaign alerts, they should be able to do it through the UI [21:52:45] I'm happy to show her how to do that! [22:10:57] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Large Donation Bot Emails Sent to Janelle - https://phabricator.wikimedia.org/T120301#1850469 (LeanneS) NEW [22:15:39] !log updated paymentswiki configuration [22:15:43] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:34:48] Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: CiviCRM upgrade: Donation Processing: no refund button after clicking Edit transaction - https://phabricator.wikimedia.org/T116317#1850699 (Eileenmcnaughton) One... [22:35:15] !log updated paymentswiki configuration [redux] [22:35:20] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:35:50] dope [22:35:57] iframe works...still need those couple css changes [22:36:00] (PS2) Ejegg: Use common filter component in fraud gauge [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256633 (https://phabricator.wikimedia.org/T89526) [22:36:18] i'm gonna just try w/ my cc [22:38:38] (PS1) Ejegg: Fix issue with saved filters [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256845 (https://phabricator.wikimedia.org/T89526) [22:38:45] nice! [22:38:52] hrm, it appears to not take visa? [22:39:10] uhh [22:39:27] i don't see the logo, and it told me invalid card # [22:39:54] Isn't that the most popular card type in the world? [22:40:19] at least in my wallet! [22:41:21] The most popular card type in my whooooole wallet. [22:52:35] (CR) AndyRussG: ext.centralNotice.display: Add API for custom hide cookie reasons and durations (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/256615 (https://phabricator.wikimedia.org/T120056) (owner: AndyRussG) [22:55:27] books aren't a valid CSS entity [23:06:12] atgomez: ejegg: we should really update the server-based hide cookie expiry switch mechanism, but that'll be for a different day, methinks... [23:11:25] Wikimedia-Fundraising, Wikimedia-Site-Requests: Clean up fundraising code (extra skins and allowed templates for foundationwiki) in CommonSettings.php - https://phabricator.wikimedia.org/T50493#1850821 (Krenair) Just going to go ahead and do this, seeing as #Wikimedia-Fundraising doesn't seem to care (th... [23:12:23] Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: CiviCRM upgrade: Donation Processing: no refund button after clicking Edit transaction - https://phabricator.wikimedia.org/T116317#1850827 (MBeat33) We never issu... [23:15:34] (PS2) AndyRussG: ext.centralNotice.display: Add API for custom hide cookie reasons and durations [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/256615 (https://phabricator.wikimedia.org/T120056) [23:15:41] ejegg: ^ :) [23:16:02] checking it out! [23:16:06] ty! [23:16:20] Aarrrgg where was my brain on that first patch! [23:16:40] * AndyRussG searches... Ctrl-F... Ctrl-F... [23:24:21] aww, don't be hard on yourself! That's what CR is for... [23:28:16] Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: CiviCRM upgrade: Donation Processing: no refund button after clicking Edit transaction - https://phabricator.wikimedia.org/T116317#1850868 (atgo) @eileenmcnaughto... [23:28:20] (PS3) Ejegg: ext.centralNotice.display: Add API for custom hide cookie reasons and durations [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/256615 (https://phabricator.wikimedia.org/T120056) (owner: AndyRussG) [23:28:39] (CR) Ejegg: [C: 2] "Lookin' good!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/256615 (https://phabricator.wikimedia.org/T120056) (owner: AndyRussG) [23:28:48] ejegg: thanks a bunch!! [23:30:01] ejegg: cwd: XenoRyet: ^ K I'll keep smoke testing then request the deploy, that'd be in 1/2 an hour [23:30:25] (Merged) jenkins-bot: ext.centralNotice.display: Add API for custom hide cookie reasons and durations [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/256615 (https://phabricator.wikimedia.org/T120056) (owner: AndyRussG) [23:30:44] sounds good AndyRussG [23:31:31] ejegg: aaargh woops just notices a silliness [23:32:13] just a public API detail [23:34:56] Aaarg where o where is that brain 'o mine? Escaped, now has it? [23:38:01] (PS1) AndyRussG: ext.centralNotice.display.customHideBanner(): fix var name and actually hide [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/256856 [23:38:11] ejegg: ^ [23:38:25] (I was testing using the internall API call....) [23:43:31] (CR) Ejegg: [C: 2] "oof, sorry I missed this in the last CR!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/256856 (owner: AndyRussG) [23:47:02] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: UI Sillyness: Can't see all the fields when adding a new email address to a contact record - https://phabricator.wikimedia.org/T118037#1850937 (Eileenmcnaughton) On skype with Catilin & Leanne just now we chose the gar... [23:47:43] Does anyone have an opinion on my last comment on the ticket above - ie. fix urls vs give out extra permission [23:49:02] Fundraising-Backlog: donate.wikimedia.org needs an MX record - https://phabricator.wikimedia.org/T120322#1850952 (CCogdill_WMF) NEW [23:49:39] Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: CiviCRM upgrade: Donation Processing: no refund button after clicking Edit transaction - https://phabricator.wikimedia.org/T116317#1850960 (Eileenmcnaughton) The... [23:50:24] Fundraising-Backlog: donate.wikimedia.org needs an MX record - https://phabricator.wikimedia.org/T120322#1850962 (CCogdill_WMF) [23:53:17] ejegg: where do the large donation bot emails come from? I thought it was a sched reminder but looks like it isn't [23:54:34] dstrine: do you know about K4 being in the office today? [23:56:31] eileen: It's some kind of hook, lemme see