[00:01:36] !log pointed SmashPig IPN listener to live Adyen account [00:01:42] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [00:05:51] (PS1) AndyRussG: impressionDiet: default hide banners if no storage is available [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/256860 (https://phabricator.wikimedia.org/T119538) [00:06:24] (CR) AndyRussG: [C: 2] impressionDiet: default hide banners if no storage is available [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/256860 (https://phabricator.wikimedia.org/T119538) (owner: AndyRussG) [00:07:40] (PS1) AndyRussG: ext.centralNotice.display: add 'namespace' hide reason [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/256861 (https://phabricator.wikimedia.org/T120029) [00:07:46] (PS1) Ejegg: Serious functional upgrade to Big English board [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256862 [00:08:03] (Merged) jenkins-bot: impressionDiet: default hide banners if no storage is available [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/256860 (https://phabricator.wikimedia.org/T119538) (owner: AndyRussG) [00:08:09] (CR) AndyRussG: [C: 2] ext.centralNotice.display: add 'namespace' hide reason [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/256861 (https://phabricator.wikimedia.org/T120029) (owner: AndyRussG) [00:09:07] ejegg: sorry was away for a bit [00:09:08] (PS1) AndyRussG: ext.centralNotice.display: Add API for custom hide cookie reasons and durations [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/256863 (https://phabricator.wikimedia.org/T120056) [00:09:21] np, got distracted with an Adyen thing anyway [00:09:30] now let's see where that magic happens... [00:09:34] (Merged) jenkins-bot: ext.centralNotice.display: add 'namespace' hide reason [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/256861 (https://phabricator.wikimedia.org/T120029) (owner: AndyRussG) [00:09:41] (CR) AndyRussG: [C: 2] ext.centralNotice.display: Add API for custom hide cookie reasons and durations [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/256863 (https://phabricator.wikimedia.org/T120056) (owner: AndyRussG) [00:10:44] eileen: large_donation.module 161: function large_donation_civicrm_post(... [00:11:19] (Merged) jenkins-bot: ext.centralNotice.display: Add API for custom hide cookie reasons and durations [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/256863 (https://phabricator.wikimedia.org/T120056) (owner: AndyRussG) [00:11:34] large_donation_notification_send just uses the default mailer to send emails [00:12:00] (PS1) AndyRussG: ext.centralNotice.display.customHideBanner(): fix var name and actually hide [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/256866 [00:12:20] (CR) AndyRussG: [C: 2] ext.centralNotice.display.customHideBanner(): fix var name and actually hide [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/256866 (owner: AndyRussG) [00:12:26] wmf_campaigns.module does something similar in wmf_campaigns_civicrm_custom [00:12:31] should really unify those [00:13:15] ejegg: ah - so add at this url admin/config/large_donation/configure [00:13:46] eileen: yep, that's where you add new alerts [00:13:57] (Merged) jenkins-bot: ext.centralNotice.display.customHideBanner(): fix var name and actually hide [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/256866 (owner: AndyRussG) [00:14:06] & also who gets notified I guess [00:14:11] yah [00:14:51] so, actually caitlin et al can edit that page [00:14:53] ejegg: cwd|afk: XenoRyet: eileen: anyone interested in having a final peek at what's about to deploy for CentralNotice, if u like, update ur wmf_deploy branch and say "git difftool -d dac9dd324e22eb67a0ada98fa84d6cdc1f2cd065 wmf_deploy" [00:15:39] ok, lemme take a look [00:15:40] & it kinda ties in with what I was looking at … we could add a link to the nav menu - but they wouldn't see it unless we take steps per last comment here https://phabricator.wikimedia.org/T118037 [00:16:13] AndyRussG: OK - I'll try to understand what you have been workign on :-) [00:16:35] eileen: thx! yeah LMK if u see anything horrible that we overlooked! [00:17:27] eileen: ooh, I see. Yeah, if that url root is filtered out, maybe just change the path like you suggest. [00:18:03] ejegg: yeah they can access the urls - but they don't show in the menu [00:18:21] AndyRussG: wow, been a while since I deployed CN! Your branch is behind 'origin/wmf_deploy' by 356 commits... [00:18:35] only thing is - if you go to admin then having them under that root makes them show on that page [00:18:56] (which might be an argument for giving the extra perm) [00:20:05] Wikimedia-Fundraising, Wikimedia-Site-Requests, Patch-For-Review: Clean up fundraising code (extra skins and allowed templates for foundationwiki) in CommonSettings.php - https://phabricator.wikimedia.org/T50493#1851066 (Krenair) ```krenair@tin:~$ grep wgAllowed /srv/mediawiki-staging/* -R 2>&1 | grep... [00:22:08] AndyRussG: I realise I'm not even sure which repo you are on! [00:22:22] eileen: CentralNotice [00:22:39] eileen: https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/CentralNotice [00:22:46] It's what shows the banners :) [00:23:35] http://git.wikimedia.org/summary/?r=mediawiki/extensions/CentralNotice.git ? [00:24:07] yep! [00:24:43] ah no way! I thought your last name was Russ - I hadn't realised 'Andrew Green' is you! [00:26:20] so this … http://git.wikimedia.org/compare/mediawiki%2Fextensions%2FCentralNotice.git/refs%2Fheads%2Fmaster..refs%2Fheads%2Fwmf_deploy [00:29:34] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Large Donation Bot Emails Sent to Janelle - https://phabricator.wikimedia.org/T120301#1851090 (Eileenmcnaughton) The place where this is configured is admin/config/large_donation/configure [00:30:12] well, my dumb diff tool is detecting more changes than actually exist in impressionDiet, but it all looks good to me [00:30:37] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Large Donation Bot Emails Sent to Janelle - https://phabricator.wikimedia.org/T120301#1851093 (Eileenmcnaughton) (note once we resolve the admin links issue here https://phabricator.wikimedia.org/T118037 we might want to add that link to the navigation... [00:30:38] eileen: yeah... Russ is an abbreviation of my middle name, Russell... Not to many nicks and usernames available for my real name [00:30:46] ejegg: cool thanks! Yeah deploy is going ahead [00:31:16] ejegg: which tool do you use? I have lots of fun with meld, specially the useful-but-well-hidden whitespace-only-diff filter [00:31:55] AndyRussG: yeah - your parents didn't think about that huh? [00:32:00] Yeah impressionDiet was mainly just moving code around, but some indentation changed [00:32:20] So behind the times... [00:33:13] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Large Donation Bot Emails Sent to Janelle - https://phabricator.wikimedia.org/T120301#1851110 (Eileenmcnaughton) @leannes There are 3 different notifications at that url above - do you want her added to all? (you should be able to edit directly in there... [00:33:25] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Large Donation Bot Emails Sent to Janelle - https://phabricator.wikimedia.org/T120301#1851112 (Eileenmcnaughton) a:Eileenmcnaughton [00:33:44] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Large Donation Bot Emails Sent to Janelle - https://phabricator.wikimedia.org/T120301#1850469 (Eileenmcnaughton) [00:33:55] Eileen is a cool name [00:34:17] Yeah - it peaked in popularity around 90 years before I was born tho.... [00:34:25] (PS2) Ejegg: Serious functional upgrade to Big English board [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256862 [00:44:19] AndyRussG: thanks for the settings tip! I'm also using meld [00:44:50] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Large Donation Bot Emails Sent to Janelle - https://phabricator.wikimedia.org/T120301#1851126 (LeanneS) @Eileenmcnaughton Where can I see these 3 notifications within that link? [00:46:38] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Large Donation Bot Emails Sent to Janelle - https://phabricator.wikimedia.org/T120301#1851128 (Eileenmcnaughton) does the link work? is it easier over hangout? [00:51:49] ejegg: cwd|afk: eileen: XenoRyet: CentralNotice updates are now live on production, so far no issuez :) [00:51:59] NIce [00:52:01] yay [00:52:04] w00t! [00:52:22] "Remind me later" button, here we come! [00:52:47] Thanks so much 4 the help!!!! :D [00:54:14] ejegg: it took me so long to find the config for that on meld, and then a long time later I couldn't find it again and it took me a long time again. You have to go to the button with the name of the application (i.e., Meld) in your Gnome Shell title bar, click on that, and the click on preferences, and go to the "Text Filters" tab [00:54:32] But it works well, for me so far NEway [00:57:26] yep, I managed to dig it up [00:57:43] and it works great! I redid the git diff and it was nice and clean [01:02:56] cool! Yeah just wish it was easier to toggle [01:03:24] Showed no differences on an all-whitespace change which was also nice to check [01:15:42] ok, going to head out for now. I'll probably check back in later! [01:28:10] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: iframe not appearing for some people (confirmed modern browsers) - https://phabricator.wikimedia.org/T112181#1851214 (MBeat33) We are still seeing donors with modern browsers encounter forms that don't process... [01:41:38] Fundraising-Backlog, Wikimedia-DNS, operations: donate.wikimedia.org needs an MX record - https://phabricator.wikimedia.org/T120322#1851233 (Peachey88) [01:43:38] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work, Patch-For-Review: CentralNotice: Add API for custom hide cookie reasons and durations, to support a "Remind me later" banner clickable - https://phabricator.wikimedia.org/T120056#1851240... [01:44:25] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work, Patch-For-Review: CentralNotice: Add API for custom hide cookie reasons and durations, to support a "Remind me later" banner clickable - https://phabricator.wikimedia.org/T120056#1843788... [01:46:24] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work, Patch-For-Review: CentralNotice: Add API for custom hide cookie reasons and durations, to support a "Remind me later" banner clickable - https://phabricator.wikimedia.org/T120056#1851244... [01:55:49] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: UI Annoyance: Move "Display Contacts As" back to the top of the Advanced Search - https://phabricator.wikimedia.org/T120332#1851253 (CaitVirtue) NEW [02:30:22] XenoRyet: ejegg|away: cwd|afk: yt? [02:34:34] AndyRussG: what's up? [02:35:05] ejegg|away: aaaarg sorry to bother you, we have a banner issue not affecting users, but affecting our data [02:35:32] I have a fix in mind but I'm hesitant to throw it out there w/out any feedback at all [02:35:40] Have 10 min to check it out? [02:35:40] what's the issue? [02:36:43] I'm not near a computer right now, but i can check gerrit from my phone [02:36:44] The new in-banner JS that prevents banners showing on non-article pages is sending the wrong info to S:RI and banner history [02:37:11] It does hide the banner correctly, but that is getting recorded as a banner shown, not hidden [02:37:19] It's a JS order of execution issue [02:37:23] d'oh! [02:37:34] Yeah, fun eh? [02:37:35] link to script? [02:37:52] https://meta.wikimedia.org/wiki/Special:CentralNoticeBanners/edit/B1516_120321_en6C_dsk_p1_lg_cnt [02:38:05] Check out the script at the very end [02:38:31] It's wrapped in a $(document).ready(function() [02:38:48] What is that global collect jenkins email - an issue? [02:39:03] That includes the code that sets mw.centralNotice.bannerData.hideResult = true; [02:39:28] eileen: hi! ^ checking out a banner issue, if you'd like to have a look too :) [02:39:51] (hmmm I have no idea about global collect...) [02:39:59] ok, so it's waiting for doc ready [02:40:33] ejegg|ish: yeah, and the function that checks mw.centralNotice.bannerData for the banner hidden flag runs immediately after the banner is injected into the DOM [02:40:54] So basically, it never hears about the banner actually being hidden [02:40:55] eileen: i'd guess the audit parser is timing out on a huge file like last night [02:41:07] is that a problem? [02:41:17] i dunno why we even have a time limit on audit parsing [02:43:39] ejegg|ish: so my plan is just to move the 4 lines following '/* Hide banner outside of main namespace...' out of the $(document).ready function, and put it just above that instead [02:43:56] I'd leave the other stuff that's in that block in there, though [02:44:42] ok, let me check [02:46:54] ejegg|ish: thx! [02:47:45] yeah, i don't see any issues with executing that as soon as the banner loads [02:47:50] There's lots of other code running outside the document ready block... At the top of the banner content, are lots of transcluded templates that contain scripts that run as soon as the thing is injected (i.e., straight in a script block) [02:48:16] mw.config and cn stuff are guaranteed to be there [02:48:49] ejegg|ish: yeah! It can't not be there, it's what injects the code [02:48:55] go for it! [02:49:27] ejegg|ish: K cool! thx! [02:49:47] I'm gonna make a Phab task, try it out on one banner, then change all of 'em if it works [02:50:12] aight, lmk how it goes? [02:51:15] ejegg|away: u bet, thanks a ton! [03:01:24] Fundraising Sprint Yo La Tengo, Unplanned-Sprint-Work: Special:RecordImpression and banner history not correctly registering when banners are hidden on non-article namespaces. - https://phabricator.wikimedia.org/T120338#1851332 (AndyRussG) NEW a:AndyRussG [03:02:48] Fundraising Sprint Yo La Tengo, Unplanned-Sprint-Work: Special:RecordImpression and banner history not correctly registering when banners are hidden on non-article namespaces. - https://phabricator.wikimedia.org/T120338#1851341 (AndyRussG) [03:03:21] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: UI Annoyance: Move "Display Contacts As" back to the top of the Advanced Search - https://phabricator.wikimedia.org/T120332#1851346 (Eileenmcnaughton) Looks like there is an issue open on CiviCRM relevant to this https://issues.civicrm.org/jira/browse/C... [03:12:08] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: UI Annoyance: Move "Display Contacts As" back to the top of the Advanced Search - https://phabricator.wikimedia.org/T120332#1851364 (Eileenmcnaughton) Note that I'm not sure if Jamie is actively working on this - I can check with him & assuming a chocol... [03:15:47] (PS1) Ejegg: Sort filters by type then display name [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256886 [03:19:36] ejegg|away: I feel sure you should really be away & not submitting patches. If it's almost the end of the day for me... [03:19:53] heh [03:20:17] hey, I took a couple hours to go to a beer event! [03:20:27] that's OK then! [03:20:34] I feel a beer event coming up! [03:20:41] And I never get time to work on the dash outside of December... [03:20:46] :-) [03:20:53] Man, NZ has some awesome hops [03:21:05] I could drink Nelson Sauvin beers for days [03:21:15] ejegg: eileen: fix works on one banner ( https://meta.wikimedia.org/wiki/Special:CentralNoticeBanners/edit/B1516_120321_en6C_dsk_p1_lg_cnt ) [03:21:16] yeah - although I had some pretty good beers in SF too [03:21:25] yay the craft-beer movement [03:21:33] true, the USA is in a renaissance [03:21:41] https://phabricator.wikimedia.org/T120338 [03:21:52] but now all the big corps are snapping up craft breweries [03:21:57] here too [03:22:06] but the craft breweries keep popping up [03:22:16] In the summer Mariana and I took a trip north along the St. Laurence river, had some amazing beer in this little town [03:22:17] the owners of corona just bought a san diego craft brewery for $1 billion! [03:22:23] cos I think it's a fairly low barrier to entry [03:22:26] Where was that AndyRussG ? [03:22:28] No idea how local it was [03:22:32] It was... Adams... something [03:22:40] Could be totally improted for all I know [03:22:41] Heh, not Sam Adams! [03:22:48] Oh yeah that was it, I think [03:22:57] Probably some big name that I actually just hadn't heard of [03:23:20] my partner has taken to making home-brew & that can be surprisingly palateable these days [03:23:29] Oh man, they're the brewery that keeps lobbying congress to expand the definition of 'craft' brewery to however many barrels they produce [03:23:29] they have kits to make IPA & stuff [03:23:44] like Disney extending copyright to however old Mickey is [03:23:48] :-) [03:23:52] lol [03:23:56] It was a little town called Nicolet, just outside Trois Rivières [03:23:56] eileen: awesome! [03:24:05] ejegg: oh no, I was duped! [03:24:12] AndyRussG: have you ever had anything from Unibroue? [03:24:18] No... [03:24:23] Don't think so... [03:24:26] They do some really fizzy beers [03:24:34] I think they're in Quebec [03:24:39] Hmmm sounds hiccup-inducing [03:24:41] yeah - it's not like it used to be - when you only agreed to drink someone's homebrew if you were really polite or really wanted to get drunk :-) [03:24:48] fin du monde [03:24:57] yeah, hiccups happen with their stuff [03:25:14] I know there are some brewpubs around [03:25:20] eileen: do you like the Moa stuff? [03:25:30] yeah - you get that over there? [03:25:41] yep, but of course at a premium [03:25:47] it's a fairly recent one I think - might be a big brewery behind it? [03:26:09] nope a small one [03:26:10] http://www.moabeer.com/ [03:26:21] actually I think they listed on the stock exchange recently [03:26:46] whoa, nice! [03:27:47] I met a New Zealander in Europe whose business was to organize beer tours of different continents for NZ folks [03:27:58] so I guess you guys take beer seriously [03:29:05] I think we have been ahead of the game on craft beer - I read a reviewer promote NZ on the basis you could get craft beer at the airport [03:29:12] but I think that's pretty standard now [03:29:26] I'm sure SF airport had craft beer [03:30:12] I know I kind of expect bars to have craft beer on tap these days & feel annoyed when they don't [03:30:13] hehe, yeah, i've had some pretty exotic beers in US airports [03:30:35] me too! We're getting spoiled [03:30:44] don't complain! [03:31:02] oh, i love it [03:31:05] you won't really be spoiled until you stop calling that stuff they server at Starbucks coffee…. [03:31:44] ehh, i worked at a little independent coffee shop, so i've been snobby about starbucks since forever... [03:31:53] :-) [03:32:23] I understand they have power outlets at every table though so there is some reason to go there [03:32:26] I am impressed that they managed to expand into Italy though [03:32:33] really!! [03:32:34] wireless chargers even [03:33:07] yeah, the founder's idea was to bring italian coffee culture to america [03:33:21] so, I tend to believe that the quality of coffee is reverse relative to the size of the cups it is served in [03:33:32] and now he's exporting the americanized version of it back to its country of origin [03:34:17] At google they have baristas & they suggest you order 'baristas choice'. But when I said I didn't want it sweet he got all disappointed [03:34:28] yeah, dunkin' donuts is the dominant chain in the northeast. huge cups, watery coffee [03:34:36] erg [03:36:03] I was a bit disappointedin SF. I ordered a coffee & they asked if I wanted a double so of course I said yes - but they didn't just give me a double shot - they increased everything else too (water, milk, cup size) - kinda defeated the point [03:36:24] (PS2) Ejegg: 'wikpedia' typo in API example [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/256637 (owner: Spage) [03:36:40] aww man, that's a bummer [03:37:01] Where was that? [03:37:13] I was pretty impressed with blue bottle coffee out there [03:37:26] some nifty apparatus at the very least [03:37:55] (CR) Ejegg: [C: 2] "Thanks, good catch!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/256637 (owner: Spage) [03:37:56] it was actually good coffee - right outside the SF office [03:37:59] ejegg: eileen: just updated all the banners, it'll take 10 min or so for the changes to show up [03:38:12] but, obviously a double meant something different to what I thought [03:38:17] yay AndyRussG [03:38:30] eileen: :) still have to fully test it! [03:38:39] (w/ all the banners, I mean...) [03:38:40] nice, AndyRussG! [03:38:56] Rrrg thx, /me beats self up for not having noticed this sooner [03:39:13] why beat yourself up - you have kids to do that for you [03:39:22] Hahahahaha too true [03:39:57] Or at least do things that also make one beat oneself up [03:40:09] So creative in their mischief! [03:40:09] :-) [03:40:14] yep! [03:40:56] (PS2) Ejegg: Add Default Order to WMF LYBUNT template. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/256607 (https://phabricator.wikimedia.org/T119911) (owner: XenoRyet) [03:41:28] They have this cheap little digital camera... So recently they used it to secretly film the only 1/2 hour of TV they're allowed to watch on school nights, and snuck it into their bedroom to re-watch it after they were supposedly already asleep!!!! [03:41:43] Pirates! [03:42:55] * AndyRussG is not tooooooooooo strict of a parent.... [03:46:45] creative! [03:48:25] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Figure out & fix the certificate issue that's not allowing civi users to have dashlets - https://phabricator.wikimedia.org/T118356#1851424 (Eileenmcnaughton) I had a long conversation with Tim & Coleman on IRC about the approach to this & to caching rep... [04:18:28] eileen: ejegg: seems all good :) [04:18:44] AndyRussG: yay [04:18:50] :) [04:19:21] AndyRussG: gonna ding a new bell soon too [04:19:26] Cool! [04:19:48] Heh "seems"... somehow having trouble getting true randomness where we're supposed to, I hope it's just a thing in my browser [04:19:56] Arrrg time to sleep! [04:20:14] cya! [04:27:23] (CR) Ejegg: [C: -1] "Sorry, I shouldn't have rebased. This function never gets called. I think the sorting would need to happen in the SQL that's generated i" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/256607 (https://phabricator.wikimedia.org/T119911) (owner: XenoRyet) [04:37:35] Fundraising Sprint Yo La Tengo, Unplanned-Sprint-Work: Special:RecordImpression and banner history not correctly registering when banners are hidden on non-article namespaces. - https://phabricator.wikimedia.org/T120338#1851465 (AndyRussG) Fixed for banners on [[ https://meta.wikimedia.org/w/index.php?tit... [04:40:22] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Figure out & fix the certificate issue that's not allowing civi users to have dashlets - https://phabricator.wikimedia.org/T118356#1851467 (Eileenmcnaughton) OK - I've translated that conversation into 2 separate JIRA for when we are ready to prioritise... [04:41:16] Fundraising-Backlog, Wikimedia-DNS, operations: donate.wikimedia.org needs an MX record - https://phabricator.wikimedia.org/T120322#1851468 (Jgreen) a:Jgreen [04:44:52] Fundraising-Backlog, Wikimedia-DNS, operations: donate.wikimedia.org needs an MX record - https://phabricator.wikimedia.org/T120322#1851470 (Jgreen) @BBlack the DNS record for donate.wikimedia.org uses geodns, which used to be a blocker for adding MX records. IIRC that is no longer an issue, is there... [05:59:48] (CR) XenoRyet: "Yea, I pushed this up before I was really done, have been working in a sandbox branch since. It's turning out to be even more complicated" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/256607 (https://phabricator.wikimedia.org/T119911) (owner: XenoRyet) [14:02:52] Fundraising Sprint Yo La Tengo, Unplanned-Sprint-Work: Special:RecordImpression and banner history not correctly registering when banners are hidden on non-article namespaces. - https://phabricator.wikimedia.org/T120338#1852213 (Pcoombe) Open>Resolved Great, thanks @AndyRussG. I've fixed it for our... [14:12:03] Fundraising Sprint Yo La Tengo, Unplanned-Sprint-Work: Special:RecordImpression and banner history not correctly registering when banners are hidden on non-article namespaces. - https://phabricator.wikimedia.org/T120338#1852225 (AndyRussG) Cool! :D [15:50:15] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work, Patch-For-Review: CentralNotice: add 'namespace' hide reason - https://phabricator.wikimedia.org/T120029#1852453 (AndyRussG) Open>Resolved [15:53:47] Fundraising-Backlog, Wikimedia-DNS, operations: donate.wikimedia.org needs an MX record - https://phabricator.wikimedia.org/T120322#1852467 (Jgreen) Open>Resolved Done! ~> dig mx donate.wikimedia.org ; ANSWER SECTION: donate.wikimedia.org. 3600 IN MX 10 mx1001.wikimedia.org. donate.wikimedia.or... [16:04:04] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: wrap LocalStorage access in try/catch to prevent errors on Chrome w/ cookies & LS disabled - https://phabricator.wikimedia.org/T120384#1852508 (AndyRussG) NEW [16:28:17] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: wrap LocalStorage access in try/catch to prevent errors on w/ cookies (& LS) disabled - https://phabricator.wikimedia.org/T120384#1852567 (AndyRussG) [16:29:00] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: wrap LocalStorage access in try/catch to prevent errors on w/ cookies (& LS) disabled - https://phabricator.wikimedia.org/T120384#1852508 (AndyRussG) [16:40:26] (CR) Pcoombe: ext.centralNotice.display: Add API for custom hide cookie reasons and durations (1 comment) [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/256863 (https://phabricator.wikimedia.org/T120056) (owner: AndyRussG) [16:41:05] AndyRussG: see above. that's not deployed yet is it? [16:42:51] (CR) AndyRussG: ext.centralNotice.display: Add API for custom hide cookie reasons and durations (1 comment) [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/256863 (https://phabricator.wikimedia.org/T120056) (owner: AndyRussG) [16:43:24] the-wub: yes it's deployed, as is the follow on patch that fixed that... Thanks for checking!!! :D [16:43:43] https://gerrit.wikimedia.org/r/#/c/256866/ [16:44:17] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice: change impression diet fallback for no storage (cookies or LocalStorage) available - https://phabricator.wikimedia.org/T119538#1852596 (AndyRussG) O... [16:44:44] AndyRussG: oh cool, thanks. didn't see the followup in phabricator. [16:44:59] the-wub: Ah woops yeah lemme add that, sorry ;p [16:45:41] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice: change impression diet fallback for no storage (cookies or LocalStorage) available - https://phabricator.wikimedia.org/T119538#1828765 (AndyRussG) Thi... [16:48:50] AndyRussG: hmm... still a problem though. I see mw.centralNotice.customHideBanner() available on meta, but not on en.wikpedia [16:55:18] is there a youtube option for the upcoming meeting? [16:56:12] the-wub: huh I saw it on enwiki yesterday... checking.. [16:56:58] the-wub: I'm getting it on enwiki! Maybe you're using the debug option, which doesn't work right anymore? [16:57:50] oh, that was exactly it. thanks AndyRussG ! [16:58:02] will debug work properly at some point in the future? [16:58:51] no it's being deprecated... 8p [16:59:00] which is indeed something we may need to deal with... [17:01:31] AndyRussG: ah nuts. we've been using it a lot recently to avoid banner caching delays. is the deprecation being discussed somewhere? [17:02:20] Hmmm not sure... The main direction for now is just to use the browser's pretty-print function, and then eventually use a thing called source maps [17:02:33] We can find a way to compensate in CentralNotice, perhaps [17:06:27] the-wub: I can also bring it up in the front-end standards group meetings that I've been going to (also open to anyone who would like to attend, BTW :) ) [17:08:21] AndyRussG: it's not the formatting which is an issue. it's that it avoids loading outdated banner stuff. which may well be an unintentional side effect, but is very useful! [17:08:38] the-wub: right! [17:15:39] (PS1) Cdentinger: break out of iframe with liberated request var [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/256961 [17:42:07] (PS3) Cdentinger: pared down iframe stylesheet [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/256157 [17:53:56] cwd: is the PS3 version of the stylesheet up on Adyen? [17:54:17] Also, have we gotten a successful donation through yet? [17:54:46] ejegg: just put the skin up, but i think it's only for test until i publish? [17:55:01] yah [17:55:05] and no i haven't tried another yet, wanted to get these couple fixes in quick [17:55:08] just wanted to review it in context [17:55:16] wanna publish? [17:55:25] ah, one moment [17:55:41] was just commenting on the ticket too [18:05:43] (CR) Cdentinger: "Card logos are hidden but because of the way the inner div needs its height set it's really hard to prevent the iframe from getting scroll" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/256157 (owner: Cdentinger) [18:32:49] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work, FR-GlobalCollect: GC audit failed twice - https://phabricator.wikimedia.org/T120397#1852866 (atgo) NEW a:awight [18:54:54] Fundraising-Backlog: Zendesk accounts for fr-techsen - https://phabricator.wikimedia.org/T118611#1852951 (MBeat33) I created accts for Casey, Eileen, Adam, Katie, Dylan, Elliott - let me know if I can add anyone else. [19:11:24] Fundraising-Backlog, fundraising-tech-ops: Give Mikhail Access to Collab - https://phabricator.wikimedia.org/T120403#1852994 (ellery) NEW [19:11:58] Fundraising-Backlog, fundraising-tech-ops: Give Mikhail Access to Collab - https://phabricator.wikimedia.org/T120403#1853002 (ellery) a:atgo [19:20:31] Fundraising-Backlog: Silverpop job failed 12/4 - https://phabricator.wikimedia.org/T120405#1853024 (CCogdill_WMF) NEW [19:32:31] Fundraising-Backlog: Silverpop job failed 12/4 - https://phabricator.wikimedia.org/T120405#1853066 (awight) The export job completed normally on our end, so maybe just the upload failed? @CCogdill_WMF, is it helpful if I try the upload again? [19:34:15] Fundraising-Backlog: Silverpop job failed 12/4 - https://phabricator.wikimedia.org/T120405#1853084 (CCogdill_WMF) Sure, let's just double check that's working fine. Thanks! [19:34:44] ccogdill: I'm not clear on what you mean by ^ [19:34:52] What should we double-check? [19:34:56] the upload? [19:35:09] Is there anything I should do other than just try it again? [19:35:20] no [19:35:23] ok :) [19:35:25] I was just affirming your suggestion [19:35:26] here goes... [19:36:27] odd, the job finished without errors this morning [19:36:53] says it uploaded and everything [19:37:13] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work: Silverpop job failed 12/4 - https://phabricator.wikimedia.org/T120405#1853087 (atgo) [19:37:18] * ejegg|vps reads backscroll [19:37:25] right, what awight said [19:37:39] ejegg|vps: hehe [19:38:01] ejegg|vps: ccogdill: I just started a new export job, it should take about 15 minutes. [19:38:24] okay thanks awight [19:38:42] I’m double checking everything is okay on the silverpop side, and we’ll retry the import [19:39:03] Fundraising-Backlog, fundraising-tech-ops: Give Mikhail Access to Collab - https://phabricator.wikimedia.org/T120403#1853091 (atgo) I have no idea how to route this request... I do not have collab admin. Is this perhaps an IT thing? [19:48:25] Fundraising-Backlog, fundraising-tech-ops: Give Mikhail Access to Collab - https://phabricator.wikimedia.org/T120403#1853123 (K4-713) Definitely a techsupport ticket thing. [19:50:50] Here's the thing to make queue failures not send donors to fail page after they gave us money: https://gerrit.wikimedia.org/r/256737 [19:51:37] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work: Silverpop job failed 12/4 - https://phabricator.wikimedia.org/T120405#1853125 (CCogdill_WMF) Open>Resolved a:CCogdill_WMF Turns out this is on the Silverpop side, so I will work on fixing it. Thanks for helping me fig... [19:53:20] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work: Silverpop job failed 12/4 - https://phabricator.wikimedia.org/T120405#1853134 (awight) a:CCogdill_WMF>awight [19:55:52] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work: Silverpop job failed 12/4 - https://phabricator.wikimedia.org/T120405#1853141 (awight) Great (sort of)! Be aware that the special export job I kicked off is currently re-uploading this morning's data to Silverpop, so those fi... [19:58:23] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work: Silverpop job failed 12/4 - https://phabricator.wikimedia.org/T120405#1853157 (awight) @CCogdill_WMF Okay, the export finished so those files should be stable again. [20:03:35] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising: Donatewiki form is displaying with low dollar amount and then changing quickly. Also showing Amazon and then hiding. - https://phabricator.wikimedia.org/T119678#1853179 (MBeat33) The donor in ZD #179605 reports that: "//follow... [20:07:02] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work, FR-GlobalCollect: Fix error when processing refunds in GlobalCollect WR1 audit script - https://phabricator.wikimedia.org/T120411#1853192 (awight) NEW [20:14:57] (PS1) Awight: Update contribution_type -> financial_type in audit script [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/256978 (https://phabricator.wikimedia.org/T120411) [20:15:12] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work, FR-GlobalCollect, Patch-For-Review: Fix error when processing refunds in GlobalCollect WR1 audit script - https://phabricator.wikimedia.org/T120411#1853214 (awight) a:awight [20:18:00] green civi! [20:24:58] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/254659 (owner: Ejegg) [20:25:52] (Abandoned) XenoRyet: Add Default Order to WMF LYBUNT template. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/256607 (https://phabricator.wikimedia.org/T119911) (owner: XenoRyet) [20:26:08] ejegg: that CI failure should have been fixed by https://gerrit.wikimedia.org/r/#/c/256369/ [20:26:11] grrr [20:26:12] (PS4) Ejegg: pared down iframe stylesheet [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/256157 (owner: Cdentinger) [20:26:57] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Add default order for Lybunt report to sort descending by greatest 2014 amount - https://phabricator.wikimedia.org/T119911#1853354 (XenoRyet) a:XenoRyet>None [20:27:04] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: LYBUNT: Change "lifetime total" to "Last year total" - https://phabricator.wikimedia.org/T119909#1853356 (XenoRyet) a:XenoRyet>None [20:27:20] awight: nice! Looks like that last failure was before your thing got merged [20:28:01] aaah whew [20:28:14] verified [20:29:05] and merged [20:29:42] Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Documentation for civicrm, drupal and pgehres MYSQL Tables - https://phabricator.wikimedia.org/T119481#1853428 (ellery) @AndyRussG Is there a place where you are documenting... [20:34:19] (CR) Awight: Serious functional upgrade to Big English board (1 comment) [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256862 (owner: Ejegg) [20:40:46] K4|lunch: have you written any wiki docs about the WR1 parser? [20:42:43] Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Documentation for civicrm, drupal and pgehres MYSQL Tables - https://phabricator.wikimedia.org/T119481#1853497 (AndyRussG) OK, great idea! Will do :) [20:50:43] For the record: Nope! [20:54:45] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work, FR-GlobalCollect: GC audit failed twice - https://phabricator.wikimedia.org/T120397#1853528 (awight) Taking some notes on the audit job: https://www.mediawiki.org/wiki/Fundraising_tech/WR1_auditor [20:55:25] Fundraising-Backlog: [BUG] Spike: Why is Donation form stuck with 0 as donation amount; donors can't modify it. Fix why. - https://phabricator.wikimedia.org/T113530#1853530 (MBeat33) The donor in #177717 got this error using Windows 7 and Firefox. [20:57:42] Hey. anyone have a second for https://gerrit.wikimedia.org/r/#/c/256978/ ? [21:10:58] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising: Donatewiki form is displaying with low dollar amount and then changing quickly. Also showing Amazon and then hiding. - https://phabricator.wikimedia.org/T119678#1853596 (Pcoombe) Thanks Michael. If we could get the url which i... [21:14:04] ejegg: want to https://gerrit.wikimedia.org/r/#/c/256978/ ? [21:14:19] will do [21:16:09] awight: is that the only place we need to make that change? [21:16:21] I see contribution_type_id used in a bunch of other modules [21:16:30] There are more. but I'm taking it one step at a time ;) [21:16:45] k [21:17:14] (CR) Ejegg: [C: 2] "That should do it for this module!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/256978 (https://phabricator.wikimedia.org/T120411) (owner: Awight) [21:17:22] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Fix remaining uses of "contribution_type"* - https://phabricator.wikimedia.org/T120424#1853656 (awight) NEW [21:17:25] ejegg: ^! [21:18:38] (PS1) Awight: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/257001 [21:18:42] (CR) Awight: [C: 2] Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/257001 (owner: Awight) [21:18:54] nice [21:19:21] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising: Donatewiki form is displaying with low dollar amount and then changing quickly. Also showing Amazon and then hiding. - https://phabricator.wikimedia.org/T119678#1853663 (MBeat33) I've asked them to confirm. The renew at $3 lin... [21:21:30] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Deadlock should result in requeueing the message - https://phabricator.wikimedia.org/T118487#1853671 (awight) Open>declined a:awight I hate to say this, but I think we're through with deadlocks! [21:22:22] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Put bgm's civicrm_bartik theme on staging for try-out - https://phabricator.wikimedia.org/T118335#1853681 (awight) @eileenmcnaughton This is completed, right? [21:23:21] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, MediaWiki-extensions-DonationInterface: [Epic] SPOF: Replace ActiveMQ donation queues with Redis - https://phabricator.wikimedia.org/T108229#1853687 (awight) [21:24:56] (CR) Awight: [V: 2] Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/257001 (owner: Awight) [21:26:44] !log Update fundraising CRM from 8a3deedc04e4d3d1c1f78cb5b7ace7d8670f307a to f0ef0dab1fa7a85426a000c35750093d541fe4f5 [21:26:48] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:27:57] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work, FR-GlobalCollect: GC audit failed twice - https://phabricator.wikimedia.org/T120397#1853709 (awight) I've moved WR1 files older than December out of the `incoming` directory and started a new job run. [21:34:04] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work, FR-GlobalCollect: GC audit failed two days in a row: timing out after 90 minutes - https://phabricator.wikimedia.org/T120397#1853742 (awight) [21:36:15] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-GlobalCollect: GlobalCollect audit should eventually give up on missing transactions - https://phabricator.wikimedia.org/T120428#1853747 (awight) NEW [21:39:52] (PS1) Ejegg: Make darn sure the modal goes away [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257004 [21:40:11] (PS3) Ejegg: Serious functional upgrade to Big English board [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256862 [21:40:33] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-GlobalCollect: GlobalCollect audit: lots of "impossible" errors for refunds - https://phabricator.wikimedia.org/T120430#1853782 (awight) NEW [21:41:48] (CR) Awight: [C: 2] "/me rubs hands" (1 comment) [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256862 (owner: Ejegg) [21:42:44] awight: the filters for the fraud widget are ready too, if we want to deploy some actual functionality! [21:43:01] https://gerrit.wikimedia.org/r/256633 and https://gerrit.wikimedia.org/r/256845 [21:43:07] sure! [21:43:52] oops, let me just delete that markup I commented out [21:44:07] ejegg: How do we escape the SQL? [21:44:42] awight: Emergency exit? :P [21:44:46] we're using a couple of things: odata-parser to break the and / or conditions into trees [21:44:48] <_< [21:44:54] (Merged) jenkins-bot: Serious functional upgrade to Big English board [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256862 (owner: Ejegg) [21:44:57] * K4-713 dives out the window [21:44:58] ooh fancy [21:45:05] nooooo [21:45:18] then we can make parameterized queries on the backend [21:45:46] Hey: Self-defenestration has always been an underlying theme in fr-tech. [21:46:02] Remember Prague! [21:46:11] also, we only allow you to use known filter properties (as defined in node in the top-level widgets folder) [21:46:36] ejegg: thanks! [21:46:46] , only operators and values that make sense for that type of filter, and for dropdowns, we make sure the value is in the list [21:47:21] the only annoying bit of that is we can't use IN (...) with the odata parser we've got [21:47:35] so we build a whole bunch of ORed comparisons [21:48:02] (PS3) Awight: Use common filter component in fraud gauge [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256633 (https://phabricator.wikimedia.org/T89526) (owner: Ejegg) [21:48:13] (CR) Awight: [C: 2] Use common filter component in fraud gauge [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256633 (https://phabricator.wikimedia.org/T89526) (owner: Ejegg) [21:48:49] (CR) Awight: [C: 2] Fix issue with saved filters [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256845 (https://phabricator.wikimedia.org/T89526) (owner: Ejegg) [21:49:11] thanks! [21:49:14] (CR) Awight: [C: 2] Sort filters by type then display name [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256886 (owner: Ejegg) [21:49:24] (PS2) Awight: Fix issue with saved filters [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256845 (https://phabricator.wikimedia.org/T89526) (owner: Ejegg) [21:49:29] (PS2) Awight: Sort filters by type then display name [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256886 (owner: Ejegg) [21:49:29] Will submit a followon patch to clean up old commented-out markup [21:49:36] (Merged) jenkins-bot: Use common filter component in fraud gauge [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256633 (https://phabricator.wikimedia.org/T89526) (owner: Ejegg) [21:49:59] (CR) jenkins-bot: [V: -1] Sort filters by type then display name [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256886 (owner: Ejegg) [21:52:08] (PS3) Ejegg: Fix issue with saved filters [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256845 (https://phabricator.wikimedia.org/T89526) [21:53:39] ejegg: Might be time to start some docs on how the Dash works... it's getting quite baroque! [21:53:50] (PS3) Awight: Sort filters by type then display name [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256886 (owner: Ejegg) [21:55:50] awight: sure, sounds good! [21:56:00] u mean user-facing? [21:58:44] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/257008 [22:00:13] ejegg: That's a good idea, too! I was thinking more along the lines of code architecture. [22:01:41] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add Do Not Solicit column to custom LYBUNT report - https://phabricator.wikimedia.org/T117171#1853923 (awight) [22:06:58] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add Do Not Solicit column to custom LYBUNT report - https://phabricator.wikimedia.org/T117171#1853977 (XenoRyet) I think it's already in there. Down at the end between LifeTime and Lifetime donations (USD). [22:10:07] (PS2) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/257008 [22:10:31] (CR) Ejegg: [C: 2 V: 2] Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/257008 (owner: Ejegg) [22:12:17] ejegg: thanks for the CR and hopping on the adyen thread! [22:12:46] fo sho! [22:12:51] i see you're deploying dash, does that mean your outstanding patches are accounted for? [22:12:57] most of em [22:13:07] happy to look over stuff if you have needs [22:13:20] There's still this one for DI: https://gerrit.wikimedia.org/r/256737 [22:13:35] cool yeah [22:14:20] (CR) Ejegg: [C: 2] "Still some scrolling, but definitely an improvement!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/256157 (owner: Cdentinger) [22:15:05] (Merged) jenkins-bot: pared down iframe stylesheet [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/256157 (owner: Cdentinger) [22:16:33] adyen seems to be a good business and i could see using them for a lot of stuff but that iframe markup is kind of a horror show [22:16:51] maybe we can be like "html a la carte please" [22:16:52] yah, tell me about it! [22:17:14] they were definitely discouraging us from using an iframe - wanted a full redirect [22:17:40] somehow paypal convinced humanity that's an acceptable workflow [22:17:48] ack [22:19:11] just a quick PSA, 15m from launch: http://www.nasa.gov/multimedia/nasatv/ [22:19:48] oh cool! [22:20:10] Rad, thanks for the heads up. [22:20:21] :) [22:20:50] !log updated dash from bed9895563fc0f5d3b96791fae6ed104b7778f0d to 9f0a4d98586f1281716e39b34d924de524458177 [22:20:55] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:21:24] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work, FR-GlobalCollect: GC audit failed two days in a row: timing out after 90 minutes - https://phabricator.wikimedia.org/T120397#1854069 (awight) Open>Resolved fixed (for now)! [22:37:28] (PS2) Cdentinger: Catch error queueing final status message [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/256737 (https://phabricator.wikimedia.org/T120228) (owner: Ejegg) [22:38:23] (CR) Cdentinger: [C: 2] Catch error queueing final status message [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/256737 (https://phabricator.wikimedia.org/T120228) (owner: Ejegg) [22:39:09] (Merged) jenkins-bot: Catch error queueing final status message [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/256737 (https://phabricator.wikimedia.org/T120228) (owner: Ejegg) [22:39:16] thanks cwd ! [22:50:06] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, MediaWiki-extensions-ContributionTracking, MediaWiki-extensions-DonationInterface: Deploy Redis 3 to frack - https://phabricator.wikimedia.org/T120464#1854257 (awight) NEW [22:52:08] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, MediaWiki-extensions-ContributionTracking, MediaWiki-extensions-DonationInterface: Deploy Redis 3 to frack - https://phabricator.wikimedia.org/T120464#1854266 (awight) p:High>Triage [22:53:38] Fundraising-Backlog, fundraising-tech-ops: Provision Redis nodes on staging server - https://phabricator.wikimedia.org/T120465#1854270 (awight) NEW [22:59:54] Fundraising-Backlog: CRM consumers should be able to read from and write to Redis - https://phabricator.wikimedia.org/T112832#1854284 (awight) [23:00:10] Fundraising-Backlog: CRM consumers should be able to read from and write to Redis - https://phabricator.wikimedia.org/T112832#1647403 (awight) [23:02:28] "HOLD and SCRUB. Ground winds went out of limits and the launch window now closed." [23:05:26] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising, Unplanned-Sprint-Work: Make FR banners not display over Mediaviewer - https://phabricator.wikimedia.org/T120130#1854300 (AndyRussG) If all WMF campaigns are now fixed on this point, maybe we can close this card? Off-topic... [23:05:33] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, MediaWiki-extensions-ContributionTracking, MediaWiki-extensions-DonationInterface: Consolidate contribution_tracking code into a single library - https://phabricator.wikimedia.org/T120466#1854302 (awight) NEW [23:06:39] cwd: ejegg|food: awight: XenoRyet: any non-CN CR hanging about that maybe I could confuse myself and others with? [23:07:10] None from me just now. [23:07:15] couple of trivial dash patches [23:07:25] https://gerrit.wikimedia.org/r/257004 [23:07:44] https://gerrit.wikimedia.org/r/256748 [23:07:51] https://gerrit.wikimedia.org/r/256606 [23:07:58] in order of increasing triviality [23:08:21] whee, K, I'm a total dash virgin [23:08:36] ejegg|food: what setup do I create in order to test? [23:09:55] AndyRussG: it's kind of a pain - you need a specific version of nodejs [23:10:13] Where'd I get test data from? [23:10:44] there's some setup info in the readme [23:11:22] ejegg|food: K cool! I'll dig into that :) thx! [23:11:30] brb, going vpn [23:11:37] ah, but nothing about test data [23:18:33] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add Do Not Solicit column to custom LYBUNT report - https://phabricator.wikimedia.org/T117171#1854325 (awight) Open>Resolved a:awight Thank you! [23:25:22] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Adyen: Fix CSS on Adyen form - https://phabricator.wikimedia.org/T117897#1854335 (cwdent) For the purposes of the ticket this is accomplished (https://gerrit.wikimedia.org/r/#/c/256157/). The markup sit... [23:25:34] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CRM consumers should use the PHPQueue library - https://phabricator.wikimedia.org/T112832#1854336 (awight) [23:33:04] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Ask Coinbase to export CSVs in an encoding that is compatible with Excel - https://phabricator.wikimedia.org/T119913#1854369 (awight) Files for testing Excel import: UTF-8: {F3048594} UTF-16: {F3048592} [23:33:58] ejegg|food: so Dash is JS through-and-through? [23:35:11] AndyRussG: you got it [23:35:14] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Ask Coinbase to export CSVs in an encoding that is compatible with Excel - https://phabricator.wikimedia.org/T119913#1854377 (awight) @LeanneS No rush on this, but I'm curious what your Excel will do with the above three files. I'm hoping that the UTF-... [23:36:23] K I've never poked at one of those before [23:36:38] Hope they don't bite... [23:37:57] Fundraising Sprint Yo La Tengo, Fundraising Tech Backlog, Fundraising-Backlog, Unplanned-Sprint-Work, Documentation: Document IP and Session velocity filters - https://phabricator.wikimedia.org/T92054#1854382 (awight) Open>Resolved [23:38:16] AndyRussG: as in, server side js? i think all the principles you're used to still apply [23:38:42] Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Documentation for civicrm, drupal and pgehres MYSQL Tables - https://phabricator.wikimedia.org/T119481#1854390 (awight) [23:39:09] cwd: hmmm yeah I hope... 8p Yeah the most non-browserly JS I've worked with is some tweaks made to Gnome Shell and a Gnome Shell extension [23:39:37] AndyRussG: there is nodejs in gnome shell?? [23:39:40] i had no idea [23:39:45] No, but there is JS [23:39:48] It's made of JS [23:39:56] oh wow, TIL [23:40:02] Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, fundraising-tech-ops, and 2 others: Format Monolog messages to be easier to grep, bucket them - https://phabricator.wikimedia.org/T115746#1854391 (awight) @Jgreen maybe `payments.fatal`? [23:40:12] maybe u were better off ignorant of that one? [23:40:41] I'd prefer it were in Java [23:40:41] jk [23:41:08] Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, fundraising-tech-ops, and 2 others: Format Monolog messages to be easier to grep, bucket them - https://phabricator.wikimedia.org/T115746#1854393 (awight) Looks like we could use a bucket for "PHP Warning:" as well... [23:41:11] * AndyRussG represses his memory of coding a Java desktop app [23:43:05] hehe [23:43:19] AndyRussG: this is a fascinating thing for me to learn as a gnome shell user [23:43:32] it's a great desktop! [23:43:32] Come to think of it, I'm not sure what I'd prefer Gnome Shell _were_ written in... [23:44:02] Heh I've made it work generally [23:44:14] i have a theory that javascript will eventually absorb every other language and be the only one [23:44:22] it's not my main theory, but it's one of them [23:44:27] heh [23:44:39] I wish I hadn't had to turn off all the animations, but with all the windows I keep, it just gets way too choppy [23:44:46] Not JS's fault of course [23:44:47] AndyRussG: just trying to add to setup docs, will have something in a sec [23:44:56] ejegg: ah cool thx! [23:45:00] awight: Did we ever get clean runs of the December nightlies? [23:45:05] animations are not a thing i need [23:45:20] my computers always end up running xmonad [23:45:24] but sometimes it takes a year or so [23:45:46] cwd: yeah I think we talked about xmonad once? I ran i3, also a tiling wm, for like a year.. [23:45:53] the up front costs are significant [23:46:24] but long term it's the only desktop that doesn't make me twitch [23:46:39] With Gnome Shell, I use a hoteky extension, so I have specific key combinations I've memorized for certain apps [23:47:46] My beef w/ i3 was just that the extras... Like volume controls, network icon on the title bar, batter icon... were just a pain to get working and keep working through updates... [23:51:12] Also in the end I found the window control with the lowest cognitive overhead is thought-about-application->hotkey rather than thought-about-which-desktop->hotkey->go-to-application-on-that-desktop [23:51:29] At least for me, I'm sure everyone's unique on that kinda stuff [23:52:16] AndyRussG: Oh, one crm patch will make it much easier to import test data: https://gerrit.wikimedia.org/r/247765 [23:53:11] AndyRussG: yeah the fiddling is why i always put off setting up xmonad until i reach peak anger at whatever gnome desktop [23:53:39] ejegg: so I should try to grab real data from crm? [23:53:54] cwd: so for you, anger (rather than need) has been the mother of invention? [23:54:01] AndyRussG: There are a couple schemas defined on Mockaroo [23:54:07] hehe, i guess so [23:54:09] I'm pointing to them in the docs [23:54:10] Mocka -what? [23:54:13] Ah K [23:54:17] test data generator! [23:54:25] Ah hhmmmmm [23:55:46] ejegg: do we have an fr tech account there yet? [23:56:05] nope [23:56:10] but I guess we should! [23:58:56] wouldn't be bad, as long as we're careful with our details [23:59:07] after all i think they're a funded startup [23:59:38] and we don't need a16z owning our schema