[00:14:35] (PS1) Eileen: CRM-17675 set date AND time to 'now' when refunding contributions [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/257269 (https://phabricator.wikimedia.org/T116317) [00:51:43] Fundraising Tech Backlog, MediaWiki-Vagrant, User-bd808: Multiwiki settings are not loaded correctly - https://phabricator.wikimedia.org/T98632#1857031 (bd808) [01:24:54] (PS1) Eileen: CRM-17627 Set transaction date correctly for refunds [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/257271 (https://phabricator.wikimedia.org/T116317) [01:45:52] (PS2) Eileen: CRM-17627 Set transaction date correctly for refunds [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/257271 (https://phabricator.wikimedia.org/T116317) [03:55:54] Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: CiviCRM upgrade: Donation Processing: no refund button after clicking Edit transaction - https://phabricator.wikimedia.org/T116317#1857517 (Eileenmcnaughton) I id... [05:56:48] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Add default order for Lybunt report to sort descending by greatest 2014 amount - https://phabricator.wikimedia.org/T119911#1857608 (Eileenmcnaughton) a:Eileenmcnaughton [09:42:12] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Add default order for Lybunt report to sort descending by greatest 2014 amount - https://phabricator.wikimedia.org/T119911#1857757 (Eileenmcnaughton) argh - I changed the description when I grabbed... [09:47:50] (PS1) Eileen: CRM-17680 remove custom fields from Lybunt for now since they turn out not to work [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/257284 (https://phabricator.wikimedia.org/T119911) [09:48:40] (PS1) Eileen: CRM-17680 fix core Lybunt to sort by the sort field (and add last year field to the list) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/257285 (https://phabricator.wikimedia.org/T119911) [09:51:41] (PS1) Eileen: CRM-17680 fix wmf_lybunt to order by last year's total [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/257286 (https://phabricator.wikimedia.org/T119911) [09:53:07] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Add default order for Lybunt report to sort descending by greatest 2014 amount - https://phabricator.wikimedia.org/T119911#1857763 (Eileenmcnaughton) I put through a few gerrit here - but I need to... [09:53:36] (CR) Eileen: "Note I still need to give this another once-over myself" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/257286 (https://phabricator.wikimedia.org/T119911) (owner: Eileen) [16:11:03] Fundraising-Backlog, fundraising-tech-ops: Give Mikhail Access to Collab - https://phabricator.wikimedia.org/T120403#1858434 (mpopov) Email sent. Is there a link to the documentation page I can try viewing once I have access? [16:49:07] Fundraising-Backlog: mobile donation form: expiration date error - https://phabricator.wikimedia.org/T120053#1858642 (MBeat33) Sal at Globalcollect suggests that "//the donor is getting this error because they haven't entered 2 digits for the month yet//". We have seen three more of these, and I am following... [16:54:59] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, FR-GlobalCollect: Globalcollect Status 25/404 errors - https://phabricator.wikimedia.org/T120030#1858672 (MBeat33) We are seeing enough of these that it might be worth making this... [17:01:51] Fundraising Dash, Fundraising Sprint Yo La Tengo, Unplanned-Sprint-Work: Allow user to create and add widgets to multiple boards - https://phabricator.wikimedia.org/T120673#1858711 (Ejegg) NEW a:Ejegg [17:02:23] (PS2) Ejegg: Add new boards, add widgets to any board [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257079 (https://phabricator.wikimedia.org/T120673) [17:08:46] Fundraising Dash, Fundraising Sprint Yo La Tengo, Unplanned-Sprint-Work, Patch-For-Review: Allow user to create and add widgets to multiple boards - https://phabricator.wikimedia.org/T120673#1858731 (Ejegg) [17:09:04] Fundraising-Backlog: Donation form stops at "Loading: Where Your Donation Goes" - https://phabricator.wikimedia.org/T120675#1858738 (MBeat33) NEW [17:11:01] (PS3) Ejegg: Groupings and stacked bar charts for X-by-Y [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257078 (https://phabricator.wikimedia.org/T86094) [17:11:31] Fundraising Dash, Fundraising Sprint Yo La Tengo, § Fundraising Sprint Abba, § Fundraising Sprint Beastie Boys, and 2 others: Dash: breakdown bars - https://phabricator.wikimedia.org/T86094#1858763 (Ejegg) a:Ejegg [17:12:10] Fundraising Dash: Handle time ranges for chart data client-side - https://phabricator.wikimedia.org/T86841#1858780 (Ejegg) [17:14:26] Fundraising Dash, Fundraising Sprint Yo La Tengo, Unplanned-Sprint-Work: Add numeric filters to common filter component - https://phabricator.wikimedia.org/T120678#1858797 (Ejegg) NEW a:Ejegg [17:18:06] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, MediaWiki-extensions-DonationInterface: [Epic] SPOF: Replace ActiveMQ donation queues with Redis - https://phabricator.wikimedia.org/T108229#1858823 (Jgreen) (12:14:26 PM) _joe_: I'd suggest kafka warmly if you can't lose m... [17:24:14] Fundraising-Backlog: Amazon "session expired" donation error when logging in - https://phabricator.wikimedia.org/T120680#1858842 (MBeat33) NEW [17:25:27] (PS4) Ejegg: Hide filters not intended for user selection [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257204 [17:25:29] (PS4) Ejegg: Add numeric filters [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257203 (https://phabricator.wikimedia.org/T120678) [17:25:55] Fundraising Dash, Fundraising Sprint Yo La Tengo, Unplanned-Sprint-Work, Patch-For-Review: Add numeric filters to common filter component - https://phabricator.wikimedia.org/T120678#1858797 (Ejegg) [17:30:45] Fundraising-Backlog: mobile donation form: expiration date error - https://phabricator.wikimedia.org/T120053#1858905 (atgo) @mbeat33 that's reasonable, but it's a dropdown in their iframe... nothing the donor can do about that as far as I know. On my phone (iOS running the most recent version), the dropdown... [17:33:12] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Add default order for Lybunt report to sort descending by greatest 2014 amount - https://phabricator.wikimedia.org/T119911#1858914 (atgo) Having the default sort by donation size worked out would b... [17:41:22] Fundraising Sprint Yo La Tengo, Fundraising Tech Backlog, Fundraising-Backlog, QuickSurveys, Reading Web Sprint 62 - D________________: Spike: QuickSurveys deployment process - https://phabricator.wikimedia.org/T119632#1858928 (Jdlrobson) [17:41:39] Fundraising Sprint Yo La Tengo, Fundraising Tech Backlog, Fundraising-Backlog, QuickSurveys, Reading Web Sprint 62 - D________________: Spike: QuickSurveys deployment process - https://phabricator.wikimedia.org/T119632#1831491 (Jdlrobson) [17:43:45] Fundraising Sprint Yo La Tengo, Fundraising Tech Backlog, Fundraising-Backlog, QuickSurveys, Reading Web Sprint 62 - D________________: Spike [2 hours]: QuickSurveys deployment process - https://phabricator.wikimedia.org/T119632#1858932 (KLans_WMF) [17:58:21] Fundraising-Backlog: Add Janelle Chojnacki to fr-all@ - https://phabricator.wikimedia.org/T120506#1858993 (atgo) @caitvirtue we'll add her to fr-development, which feeds into fr-all. I'm not sure what development-team is. [17:58:45] Fundraising-Backlog, fundraising-tech-ops: Add Janelle Chojnacki to fr-development@ - https://phabricator.wikimedia.org/T120506#1858996 (atgo) a:Jgreen [18:11:25] cwd: Making our iframe taller doesn't make the scroll bar go away? [18:11:38] hehe u just said that [18:13:17] awight: it's "responsive" so you have to make it really really tall [18:13:24] because skinny devices pile everything up [18:17:06] lol [18:17:14] responsive as in hella touchy [18:18:17] Fundraising-Backlog: Donation form stops at "Loading: Where Your Donation Goes" - https://phabricator.wikimedia.org/T120675#1859117 (MBeat33) ccogdill points out that the screenshot URL is from an email link [18:30:16] awight: I need to discuss the refunds again with you at some point [18:32:40] eileen: Any time! [18:33:09] I guess I need to figure out if there is a reason not to use the core method if there are no discrepancies [18:33:37] (I can't recall if we deployed that patch showing financial data yet maybe not?) [18:36:34] there were some things that I felt were issues - but I've put up patches for them (esp the date on the transactions was wrong ) [18:41:13] K4-713: I'm seeing the WR1 auditor search IOP logs back to 2015-01-01, but the oldest missing transaction is currently 2015-11-06. What's up with that? [18:41:28] Fundraising-Backlog: recurring PayPal donation not reaching Civi - https://phabricator.wikimedia.org/T120692#1859232 (MBeat33) NEW [18:41:59] eileen: Refund date is definitely important. I liked that financial line item patch, it's at least been merged. [18:42:26] eileen: Looks like it's been deployed. [18:42:28] awight: You have to lean out the IOP logs. [18:42:33] er. Clean. [18:42:47] aaah. [18:42:48] k [18:42:56] The thing is: It doesn't know when the oldest transaction *originated*. [18:43:00] It knows the settle date. [18:43:11] So, it'll search back to the beginning of time if you let iy. [18:43:13] *it [18:43:16] goddamnit. [18:43:34] hehe [18:44:10] Killing those IOP logs (or moving them to old or whatever if that exists) is a great way to improve running time. [18:44:34] ok, I thought that would limit itself to some grace period around the transaction date. [18:46:52] awight: ok - so, with those paths does just editing to 'Refunded' status stack up - or do we still have some gaps we need a hook / alternative method for? [18:47:02] Fundraising-Analysis, Analytics-Backlog: Provide performant query access to banner show/hide numbers - https://phabricator.wikimedia.org/T90649#1859299 (Milimetric) [18:47:37] eileen: mmm. All that stuff in wmf_mark_refund needs to happen, or an equivalent [18:47:42] looking... [18:47:46] hey K4-713 - https://phabricator.wikimedia.org/T114038 [18:48:37] Fundraising-Backlog, fundraising-tech-ops: Give Mikhail Access to Collab - https://phabricator.wikimedia.org/T120403#1859302 (ellery) The relevant links are in the last email I sent you. Here is the link to the collab page: https://collab.wikimedia.org/wiki/Fundraising/Engineering/SQL_Database_Overview [18:48:45] greg-g: ^ [18:51:53] eileen: * set wmf_contribution_extra.parent_contribution_id (equivalent is fine) * check for already refunded, * Check for sane refund amount, * build trxn_id using WmfTransaction class. * Set refund fields, see lines around 1795 and 1818 [18:52:04] atgomez: ty! [18:52:08] eileen: So yeah no other magic is involved. there is a lot of field setting, though [18:53:18] Fundraising Dash, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, § Fundraising Sprint Abba, and 3 others: Dash: breakdown bars - https://phabricator.wikimedia.org/T86094#1859321 (DStrine) [18:53:28] Fundraising Dash, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review: Allow user to create and add widgets to multiple boards - https://phabricator.wikimedia.org/T120673#1859322 (DStrine) [18:53:38] Fundraising Dash, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review: Add numeric filters to common filter component - https://phabricator.wikimedia.org/T120678#1859323 (DStrine) [18:53:55] awight: OK I'll look - sounds like relevant is only "build trxn_id using WmfTransaction class. * Set refund fields, see lines around 1795 and 1818 [18:55:00] opps atgomez dstrine looks like I double booked myself at stand up time [18:55:42] eileen: send an email to frtech if you can't make it. [18:55:51] dstrine: cool [18:56:43] the only issue I'm having is figuring out which days I should do wmf - ie. if I'm doing (your) Sun for now then I think there are regular meetings on (your) Wed [18:57:05] eileen: Ah, you're right cos things like the no_thank_you field only apply at the contribution level. [18:57:07] but I feel like there is another one I'm not seeing [18:59:17] awight: the only thing that is jumping out at me as still required from that hook is setting a transaction id for the refund if required [19:00:21] the trxn_id thing is giving me pause, actually... [19:00:34] I guess we never do anything with RFD * though [19:01:06] hmm - it should be recorded against the transaction ideally [19:01:25] That will be much nicer, agreed... [19:01:44] (which should be doable but my guess is the UI might be broken for that purpose - I'd need to check) [19:06:23] awight: so you think that if we ensured any transaction_id recorded in the UI is correctly recorded we could gut the hook & use the core method? [19:07:18] eileen: definitely [19:07:41] We would just need to work on a migration for old refunds + fix our reports [19:08:17] awight: do they need migrating? [19:09:05] I guess we should check again on staging once it's updated but I think they are slightly different but 'ok' [19:09:18] more importantly - which reports? [19:10:03] because how we get data out kinda dictates whether the data is ok [19:11:31] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations, FR-Paypal: Create Civi records for legacy PayPal subscriptions - https://phabricator.wikimedia.org/T119899#1859394 (awight) [19:11:32] Fundraising-Backlog: recurring PayPal donation not reaching Civi - https://phabricator.wikimedia.org/T120692#1859393 (awight) [19:14:27] eileen: The "Gateway Reconciliation" custom report, for sure. I don't know of others. [19:14:59] awight: ok - I'll look at that report & make sense of it then [19:15:03] (away for a bit) [19:15:09] Fundraising-Backlog: recurring PayPal donation not reaching Civi - https://phabricator.wikimedia.org/T120692#1859412 (Ppena) Paypal double checked this information and they show that all payments, specifically for the time period of February 2013 to current, have all completed successfully to Wikimedia. I h... [19:15:43] eileen: The idea is that we can group on (is_refunded) to sum the + and - amounts separately [19:16:16] awight: ok cool I'll take a look [19:20:17] atgomez: dstrine: I'm adding a task to the sprint for the issues around hide cookie/impression diet interactions (from FR-tech thread), sound good? [19:23:19] Fundraising-Backlog: recurring PayPal donation not reaching Civi - https://phabricator.wikimedia.org/T120692#1859463 (awight) I've confirmed that payments from this subscription are handled correctly by PayPal. They are picked up by our nightly audit process, and sent to the recurring queue. However, this... [19:24:53] Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, FR-Adyen: Adyen: retest internally with real credit cards - https://phabricator.wikimedia.org/T118293#1859471 (cwdent) a:cwdent [19:25:00] AndyRussG: yep sounds good [19:25:05] atgomez: K thx! [19:25:13] rrrg [19:26:45] AndyRussG: are you referring to he "CentralNotice updates" thread? [19:26:46] ah atgomez just responded ... nm it's really her call :) [19:26:56] dstrine: yep that's it [19:27:44] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Recurring-Donations, FR-Paypal: Create Civi records for legacy PayPal subscriptions - https://phabricator.wikimedia.org/T119899#1859477 (awight) I think I just got a good measure of the magnitude of the problem, by grepping through `/archive/ba*/... [19:29:47] K4-713: 5 minute check-in delay so I can give Ellery/Megan a quick response? [19:30:14] AndyRussG: Ha! I'm late too. :p [19:32:44] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: CentralNotice: impression diet and hide cookies interaction bug causes hidden impression counting for impression diet - https://phabricator.wikimedia.org/T120698#1859486 (AndyRussG) NE... [19:32:58] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: CentralNotice: impression diet and hide cookies interaction bug causes hidden impression counting for impression diet - https://phabricator.wikimedia.org/T120698#1859495 (AndyRussG) [19:40:03] current status: http://xkcd.com/1612/ [19:40:03] :P [19:44:20] atgomez: has mobile campaign gone up yet? Maybe we should wait on this... [19:49:15] AndyRussG: I think the test has gone up but we are gonna hold off on the proper campaign [19:52:45] I heard the bell [19:59:42] AndyRussG: i think a test is live [20:00:43] XenoRyet: can you do a chmod on lutetium to give g+w [20:01:27] Am I holding on to something I shouldn't be again? [20:08:09] ooh i got a bell, too! [20:08:40] Fundraising-Analysis: Estimate the Number of New Donors - https://phabricator.wikimedia.org/T120708#1859679 (ellery) NEW a:mpopov [20:09:27] atgomez: has ejegg deprived people around the bell of getting to be the first to ring it? [20:13:01] perhaps perhaps [20:13:07] i'm at home today though so i don't know what they're doing in the office [20:15:28] ah right - of course you were online at the standup [20:18:02] yeah i've got the sniffles. keeping my germs to myself. [20:19:06] hope you feel better soon [20:22:50] atgomez: Seddon OK thanks! Looking into a possible fix now... [20:26:54] (CR) Eileen: CRM-17680 fix core Lybunt to sort by the sort field (and add last year field to the list) (3 comments) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/257285 (https://phabricator.wikimedia.org/T119911) (owner: Eileen) [20:28:21] Fundraising-Backlog, fundraising-tech-ops: Add Janelle Chojnacki to fr-development@ - https://phabricator.wikimedia.org/T120506#1859793 (Jgreen) Open>Resolved done! [20:35:07] Fundraising-Backlog, fundraising-tech-ops: Add Janelle Chojnacki to fr-development@ - https://phabricator.wikimedia.org/T120506#1859823 (atgo) Thanks @jgreen! I've updated the contact list on collab, too: https://collab.wikimedia.org/wiki/Fundraising [21:15:20] https://phabricator.wikimedia.org/T120675 [21:15:24] https://phabricator.wikimedia.org/T120030 [21:16:31] (CR) Cdentinger: [C: 2] "Never thought of that before!" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256606 (owner: Ejegg) [21:18:00] (Merged) jenkins-bot: Fix jshint nitpick [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/256606 (owner: Ejegg) [21:32:49] i may have overestimated my computer's ability to load an html table with 100,000 rows [21:34:11] pinned 1 core, FF ram at 2G and counting [21:35:52] ejegg: Meeting? [21:35:58] Okay if you're busy. [21:36:03] I have not lunched yet. [21:37:04] i think i'll try wget [21:42:41] Fundraising-Backlog, Wikimedia-Fundraising: Estimate the proportion of people who send us complaints vs are affected by an issue - https://phabricator.wikimedia.org/T120722#1859982 (awight) NEW [21:43:00] K4-713: there is free lunch in the fund cave [21:43:10] too late [21:43:20] well ya didn't miss much [21:44:12] besides, I don't get the impression there are a lot of vegetarians in there. [21:46:05] 97K item html table from activemq frontend: 77MB/2.6 million lines [21:46:33] i'm going to think about that next time XML seems like a good idea for something [21:46:44] K4-713: oops! [21:46:59] sorry, totally spaced on 1:1 [21:50:12] haha... no worries. Guess you didn't have anything critical for me, then. :) [21:53:36] K4-713: portabella sammies, actually! [21:53:47] Fundraising-Backlog: Donation form stops at "Loading: Where Your Donation Goes" - https://phabricator.wikimedia.org/T120675#1859999 (MBeat33) ...and that this screen briefly appears as a normal part of the email link loading the form. We'll ask donors to refresh the page as an interim response. [21:53:50] D: [21:54:17] >_< [21:55:34] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, FR-GlobalCollect: Globalcollect Status 25/404 errors - https://phabricator.wikimedia.org/T120030#1860009 (awight) p:High>Unbreak! "unbreaking". [21:55:53] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, FR-GlobalCollect: Globalcollect Status 25/404 errors - https://phabricator.wikimedia.org/T120030#1860016 (awight) a:awight [21:56:46] Fundraising-Backlog: Donation form stops at "Loading: Where Your Donation Goes" - https://phabricator.wikimedia.org/T120675#1860022 (Ejegg) The landing page also makes a cross-domain request to load the payment outages from meta. It's possible that when that request fails, we never get to the line of code t... [21:57:45] Fundraising-Backlog: mobile donation form: expiration date error - https://phabricator.wikimedia.org/T120053#1860038 (atgo) @mbeat33 please let us know if you do/have seen any more reports of this after the test today. [22:00:15] Fundraising-Backlog, Wikimedia-Fundraising: Estimate the proportion of people who send us complaints vs are affected by an issue - https://phabricator.wikimedia.org/T120722#1860055 (atgo) I suspect we need a couple of different measurements here. Some errors don't display the instructions for reporting a... [22:02:18] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, FR-GlobalCollect: Globalcollect Status 25/404 errors - https://phabricator.wikimedia.org/T120030#1860066 (awight) I see a comment in ZD# 181301, that they filled out donation data... [22:07:15] ccogdill: I'm looking at some donation links in a bulk email forwarded by a donor... would like to ask you about the amount choices when you have a minute. I don't see the different hpc= links causing amounts to be highlighted. [22:18:35] Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising-Backlog: Donation form error message: "No processors available" - https://phabricator.wikimedia.org/T117872#1860134 (awight) Oh. That's really bad, that order ID was used 10 months ago. This means our logic to prevent order I... [22:18:50] Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising-Backlog: Donation form error message: "No processors available" - https://phabricator.wikimedia.org/T117872#1860135 (awight) p:High>Unbreak! [22:19:41] Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising-Backlog: Donation form error message: "No processors available" - https://phabricator.wikimedia.org/T117872#1860151 (awight) a:awight [22:22:37] Fundraising-Backlog, FR-GlobalCollect: Getting error 21000080 from GlobalCollect: INVALID_COUNTRYCODE - https://phabricator.wikimedia.org/T120727#1860182 (awight) NEW [22:29:47] Fundraising-Backlog, FR-GlobalCollect: GlobalCollect error 430339: INVALID_MERCHANT_OR_SERVICE_PROVIDER - https://phabricator.wikimedia.org/T120728#1860220 (awight) NEW [22:35:44] atgomez: I assume that ideally, in logs of banner display, if a banner should be hidden by both a hide cookie and the impression diet feature, which reason should be recorded? [22:35:49] rrrg I mean [22:36:08] I assume that ideally, the hide cookie reason should take precedence, in the log, right? [22:38:28] Jeff_Green: Which _joe_ is that? Sutherland? [22:38:33] Fundraising-Backlog: Donation form stops at "Loading: Where Your Donation Goes" - https://phabricator.wikimedia.org/T120675#1860268 (Ejegg) Nah, never mind, we show the form before that script loads. [22:38:41] awight: guiseppe [22:39:28] ooh thx [22:41:13] Fundraising-Backlog: Donation form stops at "Loading: Where Your Donation Goes" - https://phabricator.wikimedia.org/T120675#1860276 (Ejegg) You /can/ trigger it by setting hpc to a negative number: https://donate.wikimedia.org/w/index.php?title=Special:FundraiserLandingPage&country=US&uselang=en&utm_medium=e... [22:44:22] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, MediaWiki-extensions-DonationInterface: [Epic] SPOF: Replace ActiveMQ donation queues with Redis - https://phabricator.wikimedia.org/T108229#1860285 (awight) Kafka is an interesting suggestion, it looks like high availabili... [22:54:41] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, FR-GlobalCollect: Globalcollect Status 25/404 errors - https://phabricator.wikimedia.org/T120030#1860370 (awight) @MBeat33 If you can get any of these details from donors, it woul... [23:03:54] (PS1) AndyRussG: impressionDiet: don't count impressions if banner hidden by close cookie [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/257497 (https://phabricator.wikimedia.org/T120698) [23:04:10] awight: ejegg|afk: cwd: XenoRyet: ^ [23:04:59] It doesn't solve all our possible mixin order-of-hook-execution woes, but it should solve the current problem! [23:14:31] XenoRyet: I tried out those patches on staging & the results are the same (except the sorting) [23:15:11] Cool. I'll check it out myself and get you some CR. [23:16:10] (PS2) Eileen: CRM-17680 fix wmf_lybunt to order by last year's total [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/257286 (https://phabricator.wikimedia.org/T119911) [23:16:33] thanks - there is more work to do in upstreaming & whatever feedback I get from them [23:17:02] but, I feel like it this is 'ok' then we should get it to FR staff [23:17:12] & I can plug away at tidying up [23:17:19] Agreed [23:18:15] XenoRyet: I think I dropped your commits off staging too - it's back on master + that commit + some files I can't get rid of [23:19:06] No worries, my commits were mostly dead ends anyway. I don't need them anymore. [23:27:50] atgomez: dstrine-brb: if we weren't waiting on the new impression diet issue, when would the mobile campaign be slated to go up? Is it being delayed by this issue? [23:28:45] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, FR-GlobalCollect: Globalcollect Status 25/404 errors - https://phabricator.wikimedia.org/T120030#1860594 (awight) I've emailed GC, begging for weblogs with a few examples of the 4... [23:32:21] Hey. [23:32:29] https://gerrit.wikimedia.org/r/#/c/256459/ is in the SWAT in half an hour. [23:32:44] awight asked for it to be mentioned in here, though I don't understand why. [23:33:50] James_F: Hmm OK... thanks! Maybe so that we can check it won't interact badly w/ CentralNotice or anything... [23:34:13] * AndyRussG looks [23:34:31] AndyRussG: It doesn't touch anything that CN is using (or there'll be trouble). :-) [23:35:34] James_F: indeed, I don't see any issue... Maybe awight thought it was "geolocalization" rather than just "localization" :) [23:35:36] Also, Jon R. has a few patches which are apparently needed. [23:35:45] AndyRussG: Ah, yeah, that I would not touch. :-) [23:36:23] James_F: yea that's probably it... Yeah we rely heavily on GeoIP, currently in CentralNotice though we'd like to farm it out 8p [23:36:42] Totally. [23:38:26] James_F: I was mostly being paranoid, and to get a timestamp + reminder so we can watch for discontinuities. Thank you for the note! [23:38:44] awight: Of course. Just had me worried that CN was using odd features of OOUI. :-) [23:39:18] ... the only side effect I could imagine is if this patch just breaks ResourceLoader outright. [23:40:52] Ha. [23:41:33] Well, it's been merged into master for nearly a week now with no ill effects in Beta Cluster or in development. [23:41:42] If it broke RL but only in prod we'd be… sad. [23:43:19] awight: do u know if we're holding up the mobile campaign due to the impression diet issue? Here's the patch... https://gerrit.wikimedia.org/r/#/c/257497/ [23:43:57] RL, the hearbeat of Las Vegas [23:44:05] AndyRussG: I haven't heard anything about that, if so, but my ear is not well glued to the tracks [23:44:44] I heard something about it going up soon but couldn't find e-mail evidence... [23:46:35] dstrine: do u know the current timeline on the mobile campaign? [23:47:05] AndyRussG: no [23:47:14] let me try to look that up ... [23:47:28] dstrine: K thanks... I'm just wondering how urgent the fix for the new impression diet is or isn't [23:48:07] dstrine: we're pretty surely missed this evening's SWAT, but there's another tomorow morning [23:48:46] I know the mobile campaign was supposed to launch tomorrow at 100%. They were supposed to do a test today and see if the issues brought up during the standup were big enough to block starting the campaign [23:48:58] not very helpful but that’s what I can offer :D [23:49:25] AndyRussG: megan responded and it does sound like it's blocking [23:49:30] ccogdill: ah cool! yeah that is helpful :) [23:49:59] dstrine: K thanks! [23:50:16] so let's check in Tuesday morning [23:51:02] AndyRussG: if you know who long this will take, please keep replying to that email. Megan will read it before any of us are awake tomorrow [23:52:03] (CR) XenoRyet: "Couple of inline comments." (2 comments) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/257285 (https://phabricator.wikimedia.org/T119911) (owner: Eileen) [23:52:23] eileen: ^ [23:52:27] dstrine: just waiting on CR, and also I'd like a consensus that this would be OK to push out tomorrow morning. If it gets reviewed tonight it could go out with the "morning SWAT" at 8:00 am PST. Apologies for being pushy about this--I know there's other equally urgent stuff! [23:54:41] awight: would you be able to help CR? ^ [23:54:42] XenoRyet: thanks -looking at them now [23:55:21] XenoRyet: did it all make sense or did you run from the room screaming? [23:55:39] No, it made sense. Pretty slick, I thought. [23:56:04] turned out the core one was not working that well to start with! [23:56:05] (CR) Awight: "Question inline..." (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/257497 (https://phabricator.wikimedia.org/T120698) (owner: AndyRussG) [23:56:22] Yea, this version seems much better overall. [23:57:36] Trying to think of what wording sounds right for that sorting dropdown. Probably fine as is, actually, but I wanted to think about it for a minute. [23:57:50] there are still a few more things to fix - but I didn't hear Anne say 'take your time get it perfect' this morning :-) [23:58:04] re the drop-down - it would be better if it weren't part of the title [23:58:20] there are some problems with those sort boxes - so I could rework that tab a bit [23:58:26] Definitely not. Push this thing out the door and come back around later. [23:58:58] (PS2) Eileen: CRM-17680 fix core Lybunt to sort by the sort field (and add last year field to the list) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/257285 (https://phabricator.wikimedia.org/T119911) [23:59:01] Yea, we can leave that as is for now too. [23:59:58] (PS1) Eileen: CRM-17680 fix core Lybunt to show last-year total [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/257502 (https://phabricator.wikimedia.org/T119909)