[00:00:20] I just pushed up a change to remove that order-by & also one on the stats down the bottom [00:00:33] (CR) AndyRussG: "Thx!!!!!!!" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/257497 (https://phabricator.wikimedia.org/T120698) (owner: AndyRussG) [00:00:55] (CR) Eileen: "Removed that order by now" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/257285 (https://phabricator.wikimedia.org/T119911) (owner: Eileen) [00:01:48] (CR) Eileen: CRM-17680 fix core Lybunt to sort by the sort field (and add last year field to the list) (2 comments) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/257285 (https://phabricator.wikimedia.org/T119911) (owner: Eileen) [00:02:30] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: LYBUNT: Change "lifetime total" to "Last year total" - https://phabricator.wikimedia.org/T119909#1860808 (Eileenmcnaughton) a:Eileenmcnaughton [00:02:30] awight: sending up ammended commit message... [00:02:57] eileen: Looking now. You pust those to staging yet? [00:03:04] (CR) Awight: [C: 2] impressionDiet: don't count impressions if banner hidden by close cookie (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/257497 (https://phabricator.wikimedia.org/T120698) (owner: AndyRussG) [00:03:18] awight: thx! [00:03:32] should I cancel the CR+2 so you can fix the message? [00:04:00] AndyRussG: canceled. I'll +2 again once you amend. [00:04:24] Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: CiviCRM upgrade: Donation Processing: no refund button after clicking Edit transaction - https://phabricator.wikimedia.org/T116317#1860813 (Eileenmcnaughton) I di... [00:04:45] XenoRyet: no - I'll grab that second one to staging now - the first is on staging [00:04:46] AndyRussG: sorry just seeing your ping from earlier [00:04:46] awight: ah cool thx also! Yeah my computer crashed a little while ago and somehow my poofy console editor (not vi) broke [00:04:52] atgomez: np! [00:05:10] eileen: Cool, let me know when it's there. MIght as well look at both in one go. [00:05:26] Code looks good though. [00:06:38] btw - I hope I didn't hurt your brain with that typo in wmf_lybunt I introduced during the upgrade - it was actually ignoring the year on the form - looking for $params['yid'] not $this->_params['yid'] - I'm guessing you might have hit that along the way [00:10:08] (PS2) AndyRussG: impressionDiet: don't count impressions if banner hidden by close cookie [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/257497 (https://phabricator.wikimedia.org/T120698) [00:11:15] (CR) Awight: [C: 2] impressionDiet: don't count impressions if banner hidden by close cookie [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/257497 (https://phabricator.wikimedia.org/T120698) (owner: AndyRussG) [00:12:26] Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: CiviCRM upgrade: Donation Processing: no refund button after clicking Edit transaction - https://phabricator.wikimedia.org/T116317#1860879 (MBeat33) @eileenmacnau... [00:12:37] (CR) AndyRussG: impressionDiet: don't count impressions if banner hidden by close cookie (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/257497 (https://phabricator.wikimedia.org/T120698) (owner: AndyRussG) [00:12:58] awight: thanks for the review and quick Jenkins juggling! [00:13:13] (Merged) jenkins-bot: impressionDiet: don't count impressions if banner hidden by close cookie [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/257497 (https://phabricator.wikimedia.org/T120698) (owner: AndyRussG) [00:15:10] awight: ejegg: cwd: XenoRyet: I'll keep smoke testing this some more tonight... If no more issues come up, are you OK with the idea of putting on the morning SWAT (8 am PST, I'll be around) ? [00:15:32] "puttin' on the SWAT" [00:15:37] oh yeah [00:15:40] ooooh yeah. [00:16:02] btw, for new meaning to "swatting": http://www.cbsnews.com/news/swatting-prank-terrorizes-wisconsin-dad-no-joke-to-cops/ [00:16:45] jesus [00:17:08] probably cost a quarter million tax dollars [00:17:11] AndyRussG: sure, works for me - I'll be around at 11am eastern [00:17:38] awight: that is crazy [00:17:55] awight: ejegg: K thanks! SWAT it is... [00:18:00] http://specialreports.dailydot.com/how-to-destroy-an-american-family [00:18:11] Maybe we someone should rename those twice-daily deploy turns [00:18:20] squat? [00:19:30] hehe [00:19:53] ejegg: also crazy [00:19:58] snot? [00:20:18] yah, pretty sad story [00:20:23] Everyone should have names that are as fun as ours ;p [00:20:25] (PS2) Eileen: CRM-17680 fix core Lybunt to show last-year total [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/257502 (https://phabricator.wikimedia.org/T119909) [00:20:46] actually I guess they do [00:20:53] well almost [00:21:15] eileen: Heh, was just about to ask you about that. [00:21:46] XenoRyet: ah yeah - good spotting - I got an ugly enotice on staging [00:22:07] staging report - civicrm/report/instance/50?reset=1&output=criteria seems ok [00:22:27] Fundraising Tech Backlog: Handle noscript browsers on paymentswiki - https://phabricator.wikimedia.org/T120786#1860984 (Krenair) Well, this is fundraising, and it's tech, so sticking it under #fundraising-tech-backlog Can you guys please remember to set projects as you create tasks? Thanks. [00:27:02] eileen: Yea, looks good. +2s inbound. [00:27:06] no vagrant in opensuse repos: wat [00:27:07] cool [00:27:30] so I guess I need to figure out how & when to deploy (in theory I know how I just haven't before) [00:27:46] Fundraising-Backlog: Handle noscript browsers on paymentswiki - https://phabricator.wikimedia.org/T120786#1861011 (DStrine) [00:27:53] (CR) XenoRyet: [C: 2] CRM-17680 fix wmf_lybunt to order by last year's total [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/257286 (https://phabricator.wikimedia.org/T119911) (owner: Eileen) [00:28:07] (CR) XenoRyet: [C: 2] CRM-17680 fix core Lybunt to sort by the sort field (and add last year field to the list) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/257285 (https://phabricator.wikimedia.org/T119911) (owner: Eileen) [00:28:21] Fundraising-Backlog: Handle noscript browsers on paymentswiki - https://phabricator.wikimedia.org/T120786#1860951 (DStrine) @Krenair I put it in our triage queue. Thanks for catching this! [00:28:27] (CR) XenoRyet: [C: 2] CRM-17680 fix core Lybunt to show last-year total [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/257502 (https://phabricator.wikimedia.org/T119909) (owner: Eileen) [00:29:46] ejegg: damn that is cold. [00:29:50] and persistent. [00:30:07] yeah, one heckuva grudge [00:30:20] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Get Marc Brent access to CiviCRM - https://phabricator.wikimedia.org/T120789#1861028 (CaitVirtue) [00:31:02] Just a bad targeting algorithm... [00:31:34] (Merged) jenkins-bot: CRM-17680 fix wmf_lybunt to order by last year's total [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/257286 (https://phabricator.wikimedia.org/T119911) (owner: Eileen) [00:31:36] dstrine: sorry i forgot to tag that FR :( [00:31:47] cwd: it's all good [00:32:09] (Merged) jenkins-bot: CRM-17680 fix core Lybunt to sort by the sort field (and add last year field to the list) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/257285 (https://phabricator.wikimedia.org/T119911) (owner: Eileen) [00:33:34] (Merged) jenkins-bot: CRM-17680 fix core Lybunt to show last-year total [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/257502 (https://phabricator.wikimedia.org/T119909) (owner: Eileen) [00:34:29] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: iframe not appearing for some people (confirmed modern browsers) - https://phabricator.wikimedia.org/T112181#1861049 (MBeat33) The donor in #178349 was able to enter their card details and donate using MS Edge... [00:35:36] Bassoon! [00:35:43] XenoRyet: thanks for that - I think I need to do some follow on clean-up … but I guess I'd better figure deploy first [00:36:48] eileen: No worris. Yea, I think as-is deploy is the thing for now. [00:39:13] looks like there are 5 patches merged [00:39:17] since last deploy [00:39:35] what is the process - do we just decide 'now' s good [00:39:41] awight, AndyRussG|souper: (It's now live, FWIW; nothing seems amiss.) [00:39:50] is it better to do it in the morning when people are around for longer? [00:40:13] That I'm not sure about. [00:40:29] awight: does this sound at all familiar? [00:40:32] Stderr: VBoxManage: error: Code NS_ERROR_ABORT (0x80004004) - Operation aborted (extended info not available) [00:41:43] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, FR-GlobalCollect: Globalcollect Status 25/404 errors - https://phabricator.wikimedia.org/T120030#1861062 (MBeat33) thanks, @awight, I will add donor feedback as we receive it. The... [00:43:03] i wish i could say this hasn't been my every experience with vagrant [00:44:33] awight: we have some LYBUNT changes pending deployment - how should that work in terms of choosing when to deploy them? [00:44:53] there are a small number of other undeployed changes in the civicrm repo too [00:51:42] cwd: no. okay, well... puppet/modules/activemq/templates/activemq.xml.erb [00:51:51] you can just render the template by hand :) [00:52:22] eileen: Usually, we just eyeball and decide whether to merge or cherry-pick [00:52:33] If you're unsure, then ask the patch authors... [00:53:39] awight: have you tried running mw-vagrant on anything besides virtualbox? [00:53:49] no [00:54:01] cos I <3 Oracle $oftware [00:54:08] :) [00:54:17] especially... giving it root permissions plus a kernel module. [00:55:59] awight they are all my patches - I'm just not sure timing - do I just do it 'when I feel like it' or co-ordinate, do I choose a particular time of day? [00:56:17] cwd: Some internet sketchers are saying, delete .virtualbox/VirtualBox.xml. https://forums.freebsd.org/threads/virtualbox-not-working.11893/ [00:56:21] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: iframe not appearing for some people (confirmed modern browsers) - https://phabricator.wikimedia.org/T112181#1861107 (MBeat33) The donor in #182003 entered their card details, but the GC iframe wouldn't load -... [00:56:22] eileen: hehe. Go for it! [00:59:38] cwd: I recommend starting the GUI at least once, cos it gives you better diagnostics. [00:59:58] gotta run for now... [01:11:56] "modprobe vboxdrv" fixed it. can't imagine why that isn't handled by a readable error. typical corporate software. [01:12:04] * cwd needs dinner [01:37:18] (PS1) Eileen: CiviCRM submodule update (incl Lybunt changes) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/257518 [01:39:21] (CR) Eileen: [C: 2] "Self-merge submodule update only" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/257518 (owner: Eileen) [01:41:25] (Merged) jenkins-bot: CiviCRM submodule update (incl Lybunt changes) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/257518 (owner: Eileen) [01:45:42] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/257520 [01:46:29] (CR) Eileen: [C: 2] "Merge commit -can be self-approved" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/257520 (owner: Eileen) [01:51:05] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, FR-GlobalCollect: Globalcollect Status 25/404 errors - https://phabricator.wikimedia.org/T120030#1861178 (MBeat33) #182991 was able to enter his card #s, "error code came immediat... [01:58:28] Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising-Backlog: Track email clickthroughs on donate wiki - https://phabricator.wikimedia.org/T114010#1861187 (Ejegg) @CCogdill_WMF I think I have the queries worked out, but there aren't any hit... [02:59:15] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Add default order for Lybunt report to sort descending by greatest 2014 amount - https://phabricator.wikimedia.org/T119911#1861260 (Eileenmcnaughton) @xenoryet & I worked on this today & I have mer... [03:08:30] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: UI Sillyness: Can't see all the fields when adding a new email address to a contact record - https://phabricator.wikimedia.org/T118037#1861270 (Eileenmcnaughton) Please vote for 1) Give FR staff 'Use the administrati... [03:44:59] Fundraising-Backlog: Adyen listener: reschedule capture on missing "pending" message - https://phabricator.wikimedia.org/T120798#1861285 (cwdent) NEW [07:59:55] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work: Duplicate Order ID detection is broken for GlobalCollect - https://phabricator.wikimedia.org/T120805#1861471 (awight) NEW a:awight [08:02:04] Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, FR-GlobalCollect: Do not show donation form error message: "No processors available" - https://phabricator.wikimedia.org/T117872#1861480 (awight) p:Unbreak!>High [08:02:29] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work, FR-GlobalCollect: Duplicate Order ID detection is broken for GlobalCollect - https://phabricator.wikimedia.org/T120805#1861484 (awight) [08:08:40] Fundraising-Backlog: Recurring PayPal donations not reaching Civi if subscription is older than a few years - https://phabricator.wikimedia.org/T120692#1861502 (awight) [08:53:27] Blocked-on-Fundraising-Tech: Fundraiser banner looks broken on mobile frontend android native browser - https://phabricator.wikimedia.org/T120806#1861576 (Bawolff) Im assuming this is fundraising related [10:15:22] Blocked-on-Fundraising-Tech: Fundraiser banner looks broken on mobile frontend android native browser - https://phabricator.wikimedia.org/T120806#1861668 (Pcoombe) Unlikely, we aren't running any fundraising banners on Commons. They are on Wikipedias only . [14:20:52] Fundraising-Backlog, fundraising-tech-ops: Give Mikhail Access to Collab - https://phabricator.wikimedia.org/T120403#1862080 (mpopov) Open>Resolved >>! In T120403#1859302, @ellery wrote: > The relevant links are in the last email I sent you. Here is the link to the collab page: https://collab.wikim... [15:00:13] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising: Donatewiki form is displaying with low dollar amount and then changing quickly. Also showing Amazon and then hiding. - https://phabricator.wikimedia.org/T119678#1862198 (Pcoombe) @MBeat33 Did you hear any more about this? I ca... [15:05:31] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising: Donatewiki form is displaying with low dollar amount and then changing quickly. Also showing Amazon and then hiding. - https://phabricator.wikimedia.org/T119678#1862216 (CCogdill_WMF) > For the "Renew your donation" copy in th... [15:17:42] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising: Donatewiki form is displaying with low dollar amount and then changing quickly. Also showing Amazon and then hiding. - https://phabricator.wikimedia.org/T119678#1862247 (Pcoombe) I think the donor has a good point though: if y... [15:22:08] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising: Donatewiki form is displaying with low dollar amount and then changing quickly. Also showing Amazon and then hiding. - https://phabricator.wikimedia.org/T119678#1862264 (CCogdill_WMF) I see the point, but I don't think we have... [15:27:09] Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising-Backlog: Track email clickthroughs on donate wiki - https://phabricator.wikimedia.org/T114010#1862283 (CCogdill_WMF) @Ejegg awesome! We don't normally have a use for contact_id / recipien... [15:28:05] Fundraising-Backlog, Epic: [epic] Get Adyen back up - https://phabricator.wikimedia.org/T90748#1862287 (cwdent) [15:28:07] Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising-Backlog, FR-Adyen, Patch-For-Review: Fix or disable Adyen job runner - https://phabricator.wikimedia.org/T117451#1862285 (cwdent) Open>Resolved Looks like they finally turned off that report. Additionally, the... [15:30:33] Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising-Backlog: Track email clickthroughs on donate wiki - https://phabricator.wikimedia.org/T114010#1862289 (CCogdill_WMF) Quick question - which do you prefer between contact_id or recipient_i... [15:43:09] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, FR-Adyen, Patch-For-Review: Fix or disable Adyen job runner - https://phabricator.wikimedia.org/T117451#1862330 (cwdent) [15:44:52] (PS1) AndyRussG: impressionDiet: don't count impressions if banner hidden by close cookie [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/257614 (https://phabricator.wikimedia.org/T120698) [15:45:35] (CR) AndyRussG: [C: 2] impressionDiet: don't count impressions if banner hidden by close cookie [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/257614 (https://phabricator.wikimedia.org/T120698) (owner: AndyRussG) [15:47:43] (Merged) jenkins-bot: impressionDiet: don't count impressions if banner hidden by close cookie [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/257614 (https://phabricator.wikimedia.org/T120698) (owner: AndyRussG) [15:59:26] Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising-Backlog: Track email clickthroughs on donate wiki - https://phabricator.wikimedia.org/T114010#1862378 (Ejegg) @CCogdill_WMF how about contact ID, just because that's how I've written the... [16:00:55] cwd|afk: ejegg|away XenoRyet CN change getting ready to go out... [16:01:40] good luck! [16:02:42] AndyRussG: let me know if you want help testing [16:03:12] ejegg: cwd: thanks! I'll let you know when it's actually live :) [16:03:23] ejegg: happy to say the adyen audit worked and i got my thank you for yesterday [16:03:25] Really a prettty small change [16:03:33] cwd: congrats! [16:03:47] cwd wonderful! [16:03:58] guess we're subscribed to the right report now [16:04:15] yep, also didn't see anything about the failed report [16:04:35] and if you hadn't fallen into that short race condition hole, we would have had to engineer a situation like this to test the audit! [16:04:51] hehe, unexpected benefits [16:05:10] i am currently trying to get the activemq stuff working on vagrant to troubleshoot said race condition [16:07:29] i am getting this failure [16:07:36] ==> default: Error: Could not set 'present' on ensure: 404 Not Found at 22:/vagrant/puppet/modules/activemq/manifests/init.pp [16:07:46] funny thing is that file is there [16:25:17] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising, Unplanned-Sprint-Work: Make FR banners not display over Mediaviewer - https://phabricator.wikimedia.org/T120130#1862433 (WMDE-Fisch) @AndyRussG Thanks for pining me about that. @kai.nissen already worked on a fix. [16:32:18] cwd dang, no idea. wish I had more vagrant-fu. [16:34:04] ejegg: i figured it out, the version of activemq we are looking for is no longer there [16:34:26] going to push a potential version bump once i get git review figured out on the vagrant box [16:34:36] oh, thanks! [16:35:04] If your vagrant fs is shared, you should be able to git-review from the outside [16:35:38] oh man good thinking [16:40:16] ejegg: cwd: we're live w/ the CN change... looks fine so far... [16:40:30] nice, nice [16:40:47] no errors for me [16:40:47] excellent [16:41:06] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising: Donatewiki form is displaying with low dollar amount and then changing quickly. Also showing Amazon and then hiding. - https://phabricator.wikimedia.org/T119678#1862473 (MBeat33) The donor quoted in the description, #172711, d... [16:43:48] ejegg: cool! [16:44:19] The problem w/ close cookie and impression diet interactions appears fixed, too :) [16:44:31] wonderful [16:57:37] no issues on mobile either... gonna e-mail fr-tech [17:35:36] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, FR-GlobalCollect: Globalcollect Status 25/404 errors - https://phabricator.wikimedia.org/T120030#1862614 (MBeat33) early returns, more to come today: #182636 firefox – was able t... [17:44:16] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work, FR-GlobalCollect: Duplicate Order ID detection is broken for GlobalCollect - https://phabricator.wikimedia.org/T120805#1862659 (atgo) @awight did you mean to add this to the sprint? We should triage together, right? [17:48:20] ls [17:48:28] derp [17:49:11] * ejegg wonders if there's an irssi plugin to detect shell commands [17:52:05] atgomez: Would you like to triage https://phabricator.wikimedia.org/T120805 ? [17:58:30] Fundraising Tech Backlog: CiviCRM: Found an Activity that I can't edit. Why? - https://phabricator.wikimedia.org/T120846#1862712 (Krenair) fundraising tech? [17:58:47] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CiviCRM: Found an Activity that I can't edit. Why? - https://phabricator.wikimedia.org/T120846#1862719 (CaitVirtue) [18:12:26] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Add default order for Lybunt report to sort descending by greatest 2014 amount - https://phabricator.wikimedia.org/T119911#1862781 (CaitVirtue) @XenoRyet (@atgo) Thanks for your work on this. Shou... [18:16:03] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Add default order for Lybunt report to sort descending by greatest 2014 amount - https://phabricator.wikimedia.org/T119911#1862800 (XenoRyet) @CaitVirtue Not quite yet. Looks like Eileen got hung... [18:22:46] (PS4) Ejegg: Groupings and stacked bar charts for X-by-Y [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257078 (https://phabricator.wikimedia.org/T86094) [18:23:13] (CR) Ejegg: "PS4: whitespace" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257078 (https://phabricator.wikimedia.org/T86094) (owner: Ejegg) [18:24:33] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, FR-GlobalCollect: Globalcollect Status 25/404 errors - https://phabricator.wikimedia.org/T120030#1862822 (awight) @MBeat33 I'd love to hear any more reports you've summarized, but... [18:26:40] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, FR-GlobalCollect: Globalcollect Status 25/404 errors - https://phabricator.wikimedia.org/T120030#1862828 (MBeat33) @awight got it, thanks [18:34:41] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising: Donatewiki form is displaying with low dollar amount and then changing quickly. Also showing Amazon and then hiding. - https://phabricator.wikimedia.org/T119678#1862857 (CCogdill_WMF) Okay, I see three possible resolutions for... [18:39:00] Fundraising-Backlog: Donation form stops at "Loading: Where Your Donation Goes" - https://phabricator.wikimedia.org/T120675#1862882 (MBeat33) [19:01:55] atgomez: Did you still want to triage? [19:03:56] aaargh, I've hit this bug *so many times* without learning. When I try to run phpunit.php tests in MediaWiki, why would --group DonationInterface result in no tests running? [19:04:00] burble ggaaargh [19:06:13] (PS1) Awight: Remove GC account number from tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/257665 [19:11:18] which phab board should I use to file a task for upgrading the version of R on lutetium from 2.14.1 (4 years outdated) to 3.2.3? [19:25:56] bearloga: Include the fundraising-tech-ops project, that might be enuf. [19:26:15] bearloga: Have you confirmed that the existing scripts are compatible? [19:29:12] awight: to my knowledge Ellery uses python exclusively. I'm pretty sure Oliver and I are the only R users in the foundation :) [19:30:31] bearloga: There are some legacy scripts meganhernandez might still use, in /srv/br/sahar -- I hope to bog we don't need those any more. [19:38:56] (PS1) Ejegg: Add year selector to Big English [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257677 (https://phabricator.wikimedia.org/T94110) [19:39:27] Fundraising Dash, Fundraising Sprint Yo La Tengo, Unplanned-Sprint-Work, Patch-For-Review: Add date picker to Totals Earned widget - https://phabricator.wikimedia.org/T94110#1863212 (Ejegg) a:Ejegg [19:42:16] Fundraising-Backlog, FR-GlobalCollect: Getting error 21000080 from GlobalCollect: INVALID_COUNTRYCODE - https://phabricator.wikimedia.org/T120727#1863235 (atgo) what's the volume of these, @awight? [19:42:21] http://joshmillard.com/garkov/ [19:42:57] cwd / awight / XenoRyet or AndyRussG if you want to get into dash stuff: Lots of patches ready for review! https://gerrit.wikimedia.org/r/#/q/status:open+project:wikimedia/fundraising/dash,n,z Most exciting is stacked bars: https://gerrit.wikimedia.org/r/257078, but these two bugfixes would be great too: https://gerrit.wikimedia.org/r/257202 & https://gerrit.wikimedia.org/r/257004 [19:43:57] ejegg: thanks! [19:44:52] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, MediaWiki-extensions-ContributionTracking, MediaWiki-extensions-DonationInterface: Consolidate contribution_tracking code into a single library - https://phabricator.wikimedia.org/T120466#1863270 (atgo) Is this part of... [19:46:25] Fundraising-Backlog: Donation form stops at "Loading: Where Your Donation Goes" - https://phabricator.wikimedia.org/T120675#1863284 (MBeat33) #181207 got this using Firefox 42.0 on a Macbook Pro; most likely link is http://links.wikimedia.mkt4477.com/ctt?kn=15&ms=NTAxNjM0MTkS1&r=MTE4ODczMDM4NjU0S0&b=0&j=ODIw... [19:50:31] Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising-Backlog: Track email clickthroughs on donate wiki - https://phabricator.wikimedia.org/T114010#1863319 (CCogdill_WMF) Okay, so the url parameter is &contact_id=%%CONTACTID%%. This won't be... [20:05:20] Fundraising-Backlog: Zendesk accounts for fr-techsen - https://phabricator.wikimedia.org/T118611#1863389 (DStrine) Open>Resolved a:DStrine [20:08:35] Fundraising Sprint Vengaboys, Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Changing card type sometimes results in bad order_id reuse - https://phabricator.wikimedia.org/T116089#1863409 (DStrine) p:Low>Nor... [20:12:52] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CiviCRM: Found an Activity that I can't edit. Why? - https://phabricator.wikimedia.org/T120846#1863456 (atgo) @caitvirtue is this important to you on a deadline? I'm assuming not because you didn't put anything, and moving it later in the future. Let u... [20:13:47] Fundraising-Backlog: Handle noscript browsers on paymentswiki - https://phabricator.wikimedia.org/T120786#1863463 (DStrine) Also handle edge cases where the user has AdBlock Plus set to "funky", and so on. [20:23:23] (CR) Ejegg: [C: 2] "The magic is disappearing from the world... *sigh*" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/257665 (owner: Awight) [20:24:07] (Merged) jenkins-bot: Remove GC account number from tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/257665 (owner: Awight) [20:27:25] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work: banner data and missing alterImpressionData(): Determine exact impact on data and coping mechanisms - https://phabricator.wikimedia.org/T120017#1842830 (DStrine) [20:27:38] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Investigate possible brief drop in banner history log rate on 2015-12-01 at 20:21 UTC - https://phabricator.wikimedia.org/T120058#1863538 (DStrine) [20:31:03] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: UI Sillyness: Prospect Tab - Extra spacing between hard returns in text fields - https://phabricator.wikimedia.org/T119983#1863566 (atgo) hey @caitvirtue did this get fixed with the new theme? [20:38:00] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Bad scrolling experience while editing a contribution in popup - https://phabricator.wikimedia.org/T118825#1863615 (atgo) @eileenmcnaughton is this something that should be reported upstream? [20:38:26] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Engage validation displaying incorrect errors - https://phabricator.wikimedia.org/T118824#1810164 (DStrine) Hopefully, we can get Engage out of Civi before we need to fix this. [20:38:58] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Problems when viewing a contribution; and possible corruption - https://phabricator.wikimedia.org/T118826#1863623 (DStrine) p:Triage>High [20:40:55] Fundraising-Backlog: portions of CC#s in Civi donor name fields: possible to update DataValidator? - https://phabricator.wikimedia.org/T118943#1863632 (DStrine) Open>declined a:DStrine PCI says, it's not our problem if people send us unsolicited CC#s. We would do well to manually edit these out as... [20:41:41] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Advanced Search UI: this this is in the wrong place. - https://phabricator.wikimedia.org/T118610#1863638 (atgo) @eileenmcnaughton is this also upstream like T120332? [20:43:18] Hi [20:43:50] as XenoRyet commented - I got stalled pushing out that civi code by this not merging https://gerrit.wikimedia.org/r/#/c/257520/ [20:43:50] o/ [20:45:07] Fundraising-Backlog, Wikimedia-Fundraising: [Epic] Support landing page A/B tests - https://phabricator.wikimedia.org/T120869#1863651 (DStrine) NEW [20:45:17] Fundraising-Backlog, Wikimedia-Fundraising: [Epic] Support landing page A/B tests - https://phabricator.wikimedia.org/T120869#1863658 (DStrine) [20:45:19] Fundraising-Backlog, Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-DonationInterface: Looks like we've been randomly skipping landingpages impression logfiles - https://phabricator.wikimedia.org/T118526#1802608 (DStrine) [20:46:48] Fundraising-Backlog, Wikimedia-Fundraising, FR-Campaigns: [Epic] Support landing page A/B tests - https://phabricator.wikimedia.org/T120869#1863651 (DStrine) [20:47:41] Fundraising-Backlog, Wikimedia-Fundraising: [Epic] Support landing page A/B tests - https://phabricator.wikimedia.org/T120869#1863651 (DStrine) [20:49:28] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Figure out & fix the certificate issue that's not allowing civi users to have dashlets - https://phabricator.wikimedia.org/T118356#1798014 (DStrine) There might be an Nginx way to do this. [20:49:34] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Add default order for Lybunt report to sort descending by greatest 2014 amount - https://phabricator.wikimedia.org/T119911#1863691 (Eileenmcnaughton) Yep, I got stalled on the installment here - I'... [21:03:31] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, FR-GlobalCollect: Globalcollect Status 25/404 errors - https://phabricator.wikimedia.org/T120030#1863748 (MBeat33) @awight, I'm not sure if this is the same issue, but the donor i... [21:32:38] Fundraising-Backlog: Deploy thank you letter to update postal address - https://phabricator.wikimedia.org/T120877#1863846 (jrobell) NEW [21:34:20] fundraising-tech-ops: Please upgrade the version of R on lutetium - https://phabricator.wikimedia.org/T120878#1863856 (mpopov) NEW [21:36:33] fundraising-tech-ops: Please upgrade the version of R on lutetium - https://phabricator.wikimedia.org/T120878#1863864 (mpopov) @MeganHernandez_WMF I was told there are some legacy R scripts in /srv/br/sahar that might still be used (althoughly I've been told that's highly unlikely) and if they're still used... [21:37:11] Fundraising-Analysis, Phabricator, Project-Creators, Research-and-Data: Spaces request for Fundraising-Analysis - https://phabricator.wikimedia.org/T119258#1863866 (Krenair) It's been fixed. I have left a note on the project description. Please do not try that again on any project @ellery. [21:38:37] Fundraising-Analysis, Phabricator, Project-Creators, Research-and-Data: Spaces request for Fundraising-Analysis - https://phabricator.wikimedia.org/T119258#1863869 (demon) >>! In T119258#1860818, @Krenair wrote: > Why has #Fundraising-Analysis been marked as a private project within the last week? We... [21:39:44] Fundraising-Analysis, Phabricator, Project-Creators, Research-and-Data: Spaces request for Fundraising-Analysis - https://phabricator.wikimedia.org/T119258#1863870 (Krenair) Is #Fundraising-Analysis itself actually being used for ACL? It's not supposed to be, that would be a violation of the guidelines. [21:40:37] Fundraising-Analysis, Phabricator, Project-Creators, Research-and-Data: Spaces request for Fundraising-Analysis - https://phabricator.wikimedia.org/T119258#1863871 (demon) >>! In T119258#1863870, @Krenair wrote: > Is #Fundraising-Analysis itself actually being used for ACL? It's not supposed to be, t... [21:50:33] (PS1) Awight: Handle another GC error indicating Order ID reuse [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/257751 (https://phabricator.wikimedia.org/T120805) [21:53:48] awight: i accidentally got attribution for your link https://blog.adafruit.com/?p=179291 [21:55:12] (PS1) Ejegg: Add age of donations in payments_initial [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257754 [21:57:01] (PS2) Ejegg: Add age of donations in payments_initial [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257754 [21:57:37] cwd: score! It was from... my dad via my mom. Let's not rub that around in print ;) [21:58:12] hehe [21:58:40] nice! [22:03:26] awight: did you see my note about failing to deploy those patches? [22:03:44] Fundraising Dash, Fundraising-Backlog: Use URL fragments to indicate which board you're on - https://phabricator.wikimedia.org/T120000#1863918 (Ejegg) Looks like this was on Sherah's road map once upon a time. She included a js library called [[ https://github.com/millermedeiros/hasher/ | Hasher ]] that... [22:03:58] eileen1: Yipes! I think I sleep-read that, but haven't done anything about it yet. [22:04:12] awight: [22:04:14] ok [22:04:26] Fundraising-Backlog: Deploy thank you letter to update postal address - https://phabricator.wikimedia.org/T120877#1863919 (jrobell) p:Triage>High [22:04:32] I couldn't remember what you said when you showed us about the job not completing [22:04:33] Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Don't include refunded donations in Silverpop export - https://phabricator.wikimedia.org/T117931#1863921 (CCogdill_WMF) Resolved>Open I've been doing s... [22:04:36] eileen1: I think Zuul jobs are not running on that deployment branch, so feel free to just submit it [22:04:44] oh hrm [22:04:50] I see there were jobs [22:04:58] (CR) Awight: "recheck" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/257520 (owner: Eileen) [22:05:05] sometimes that ^ helps [22:06:17] does it need V+2? [22:07:28] well, the Zuul job is supposed to provide that [22:08:24] oh, hmm [22:08:36] * awight taps feet [22:08:40] any time now... [22:13:51] (CR) Awight: [C: -2] Handle another GC error indicating Order ID reuse [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/257751 (https://phabricator.wikimedia.org/T120805) (owner: Awight) [22:16:53] Fundraising-Backlog: Spike: Is it a problem that the Silverpop export is still not updating entire database? - https://phabricator.wikimedia.org/T120880#1863948 (CCogdill_WMF) NEW [22:18:28] how do you guys live without colour in your channel? [22:18:49] (CR) Awight: [C: 2] "kicking CR+2" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/257520 (owner: Eileen) [22:19:24] Krenair: we have a lot of color, it's just in the form of four-letter words. [22:19:30] haha [22:21:37] eileen1: I think the issue is that we have no jobs that run on the deployment branch. We need to add some empty or trivial jobs. Ridiculous situation to be in. For now I guess we just force submit and cause Krenair to throw buckets of red paint into our channel. [22:22:15] awight: :-) [22:22:18] :) [22:22:26] I wish it were a joke. [22:26:01] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Continuous-Integration-Config: Bad empty CI jobs on wikimedia/fundraising/crm deployment branch - https://phabricator.wikimedia.org/T120881#1863979 (awight) NEW [22:26:51] (CR) Eileen: [V: 2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/257520 (owner: Eileen) [22:27:23] ok awight I've merged it - now I guess I need to move to the next step! [22:28:12] cool! I'll be around to chuckle about anything that goes wrong, don't worry [22:32:29] i can *almost* get my dash instance at home to load, but then: Error: Load timeout for modules: c3 [22:32:48] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Continuous-Integration-Config: Bad empty CI jobs on wikimedia/fundraising/crm deployment branch - https://phabricator.wikimedia.org/T120881#1864010 (JanZerebecki) Just adding the noop job to all pipelines of wikimedia/fundraising/crm in integration/... [22:33:01] (PS1) Awight: Handle another GC error indicating Order ID reuse [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/257767 (https://phabricator.wikimedia.org/T120805) [22:34:03] man nvm has a lot to say [22:34:35] (CR) Cdentinger: [C: 2] Fix button order in donation-age titlebar [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257199 (owner: Ejegg) [22:34:40] There a fun DI patch ^ [22:35:44] awight: the log command in here doesn't work https://collab.wikimedia.org/wiki/Fundraising/Engineering#Deploy_Fundraising_Code [22:36:32] eileen: git log --oneline --no-merges --reverse deployment..master [22:36:40] (if your deploy branch is deployment) [22:37:17] (Merged) jenkins-bot: Fix button order in donation-age titlebar [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257199 (owner: Ejegg) [22:37:39] cwd no below that [22:37:48] !log Updating civicrm from xyz to abc [22:37:52] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:38:01] ohh I see [22:38:09] I gets pasted in IRC... [22:38:17] !log [22:38:17] ah haha yeah [22:38:17] log Updating civicrm from d385e34c775aec50a5c17357c8a11cb0244123ce to 291816c88ab07bb914d56c70ff3d58eb1aa0124d [22:38:26] that is confusing [22:38:34] log Updating civicrm from d385e34c775aec50a5c17357c8a11cb0244123ce to 291816c88ab07bb914d56c70ff3d58eb1aa0124d [22:38:42] !log Updating civicrm from d385e34c775aec50a5c17357c8a11cb0244123ce to 291816c88ab07bb914d56c70ff3d58eb1aa0124d [22:38:46] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:38:52] thanks :-) [22:45:09] I still think you guys are crazy. So much simpler and more informative to say "git cherry -v origin/deployment origin/master". What's the advantage to the wonky "log" way of doing it? [22:45:31] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Add default order for Lybunt report to sort descending by greatest 2014 amount - https://phabricator.wikimedia.org/T119911#1864028 (Eileenmcnaughton) @caitvirtue I just deployed & it looks Ok to m... [22:45:43] Anyone have a minute for https://gerrit.wikimedia.org/r/257767 ? [22:46:00] I'd like to melt down payments before the sun is down. [22:46:19] awight: i'll check it out [22:46:22] OK no sign of anything disastrous having happened yet…. (from my deploy - seems awight still has ambitions) [22:46:27] cwd: Thanks! [22:46:36] eileen1: I think I can do some real damage here... [22:47:45] cool - also - do you have any thoughts on this one https://phabricator.wikimedia.org/T118037 - the stuff at the bottom about fixing the menu items to work [22:48:02] (CR) Awight: [C: -2] "Still being discussed in Phabricator." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/197741 (https://phabricator.wikimedia.org/T53475) (owner: Awight) [22:52:37] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: UI Sillyness: Can't see all the fields when adding a new email address to a contact record - https://phabricator.wikimedia.org/T118037#1864041 (awight) >>! In T118037#1850937, @Eileenmcnaughton wrote: > It seems that w... [22:53:09] Hmmm dash segfaults! [22:55:11] damn [22:55:58] awight: well i'm really not qualified to judge the efficacy of this solution but the code seems good and the tests pass [22:56:15] happy to kick it if you think it's urgent [22:57:52] heh yeah I felt the same when I opened the diff ^ but I didn't even get to trying the tests [22:58:30] The thing that bothers me is that I wasn't able to get the tests to fail with the old logic... [22:58:47] But I did confirm that the new code is regenerating the Order ID at the right time. [22:59:31] what i don't get is how we'd generate the same ID twice. isn't it epoch time? [22:59:53] it's mt_rand [23:00:06] damn [23:00:31] and we're... hitting old numbers pretty often now. We should probably do that math some time soon. [23:00:38] IDpocalypse [23:00:50] sequegeddon [23:01:27] could append a random number to epoch time...if you're not into the whole brevity thing [23:02:01] brvty [23:02:04] I don't think there's a nice solution here. We have 10 digits to work with, and we've already heavily polluted everything up through the high 999,999's [23:04:16] IDV6 [23:04:18] amirite [23:04:31] hex [23:05:23] awight: where is the 10 digit road block? [23:06:09] It has to fit in a tiny box on GC's end [23:06:29] We've already asked for one more digit, so we can just start incrementing by 1 like normal human beings. but no. [23:06:33] their mainframe... [23:06:34] anyway [23:07:07] The official recommendation is that we'll need to create a new account with them, next year, and enable the mode where GC creates order ids. [23:07:55] is GC the bottleneck across all the providers? [23:07:59] Fundraising-Analysis, Phabricator, Project-Creators, Research-and-Data: Spaces request for Fundraising-Analysis - https://phabricator.wikimedia.org/T119258#1864061 (Qgil) The instructions to manage S5 private space and the members of #acl*fundraising_research_policy_admins who have access to it hav... [23:08:03] or...do some have different format IDs? [23:11:06] Fundraising-Analysis, Phabricator, Project-Creators, Research-and-Data: Spaces request for Fundraising-Analysis - https://phabricator.wikimedia.org/T119258#1864065 (Aklapper) @ellery: https://www.mediawiki.org/wiki/Phabricator/Creating_and_renaming_projects#Project_Policies says: "IMPORTANT: these po... [23:11:56] AndyRussG: via thcipriani: "Notice: Undefined index: next_time_24h in /srv/mediawiki/php-1.27.0-wmf.7/extensions/CentralNotice/special/SpecialHideBanners.php on line 30" [23:12:09] does that ring a bell and/or you want me to make a bug or something? [23:12:53] cwd: huh that sounds either like someone messing w/ us, or a bug from some new banner scripts [23:13:31] AndyRussG: just logspam i think, unless there's some user input getting in there [23:13:51] cwd: well any user can call whatever URL they want [23:14:01] and yeah it does sound like that [23:14:26] cwd: know if we got a lot of those, or just a few? [23:14:44] cwd AndyRussG : 'next_time_24h' is the name of the hide reason when people click 'Remind me next time' [23:15:06] AndyRussG: tyler says 20/hr [23:15:24] cwd: the-wub: K we have a bug fer sher then [23:15:40] * AndyRussG shakes off dash bits [23:16:14] AndyRussG: you can see it if you log into logstash and check the fatalmonitor dashboard [23:16:16] * cwd parrot [23:16:44] cwd: mmm I think I have all I need, I'll see in a sec ;p [23:17:02] AndyRussG: thanks! [23:17:03] the-wub: cwd: thx BTW, also thx to TYler [23:17:04] AndyRussG: here's an example banner with it if that's helpful: https://en.wikipedia.org/?banner=B1516_en6C_dsk_p2_sm_template_bulb&force=1&country=US [23:17:11] the-wub: K [23:17:14] cool [23:20:52] the-wub: cwd: K, doesn't seem to be affecting users. I get the hide cookie storm fine when clicking on that [23:21:06] Just looks like it's a server-side warning [23:21:14] but not stopping any shows [23:21:21] that's good [23:22:26] yeah, I tested the cookies for workingness before I started using them :) [23:23:06] awight: looking at your DI patch. Seems like the right thing to do, as long as that error only comes from I_OWP calls. peeping at some logs... [23:23:43] the-wub: duration of the created cookies also seems fine [23:27:13] ejegg: glad to have your eyes on that, i was sweating a little over the +2 button [23:27:24] bad time to nuke DI [23:28:19] heh [23:30:17] awight: I see a few places this is happening for SET_PAYMENT or GET_ORDERSTATUS, which would be bad places to regenerate an order_id [23:31:03] that was my gut worry, regenerating somewhere it shouldn't [23:32:00] ejegg: i started trying to dash, but am getting Error: Load timeout for modules: c3 [23:32:05] in js console [23:32:10] (CR) Ejegg: [C: -1] "I see a few places this is happening for SET_PAYMENT or GET_ORDERSTATUS, which would be bad places to regenerate an order_id. Can you chec" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/257767 (https://phabricator.wikimedia.org/T120805) (owner: Awight) [23:32:22] cwd oh, did you submodule update --init? [23:32:28] either that or bower install... [23:33:03] aah, that might be it [23:33:09] where to get bower from [23:33:11] ? [23:33:17] cwd usually that means requirejs can't even find the lib [23:33:44] bower.io [23:33:55] ejegg: on that topic, I'm getting node Segfaults [23:33:56] but the submodule update oughtta do it [23:34:36] AndyRussG: whee! What does 'node --version' say when run in your dash dir? [23:34:56] ejegg: v0.8.2 [23:35:05] well that's the right version... [23:35:23] Am I missing some command to install stuff? [23:35:40] npm install Bower [23:35:40] npm http GET https://registry.npmjs.org/Bower [23:35:40] npm http GET https://registry.npmjs.org/Bower [23:35:40] npm http GET https://registry.npmjs.org/Bower [23:35:40] npm ERR! Error: SSL Error: CERT_UNTRUSTED [23:35:42] npm ERR! at ClientRequest. (/home/lap/.nvm/v0.8.2/lib/node_modules/npm/node_modules/request/main.js:440:26) [23:35:43] ok, i'm gonna run for a bit but i'll be back on for awight's bluejeans and check out some more of those dash patches [23:35:44] Segmentation fault [23:35:48] (also) [23:35:55] cwd: isn't that tomorrow? [23:36:11] AndyRussG: if for some reason npm was installing stuff for a different version, you can get the 0.8.2 modules by nuking node_modules and git submodule update [23:36:18] AndyRussG: doh! [23:36:26] ok just dash patches in that case :P [23:36:27] cwd|afk: oh no, it is tonight [23:36:40] * ejegg really ought to set up dash in vagrant... [23:36:56] ejegg: i think i filed that task [23:37:02] i think it was my first ever task [23:37:08] heh, thanks! [23:37:25] https://phabricator.wikimedia.org/T99869 [23:37:27] Ah phew it's not until 7 pm PST, so 10 pm here [23:37:39] * cwd|afk really afk now [23:37:49] cwd|afk: No bluejeans tonight! that's tomorrow [23:38:00] awight: ? [23:38:09] * awight looks wildly at calendar [23:38:14] yes, Wednesday night [23:38:56] awight: ah so the main thing is tonight and tomorrow is something remote? [23:39:33] awight: hmmm that doesn't seem to be explained as such in the e-mails u sent? [23:40:31] awight: ah k no I'm crazy [23:40:52] * AndyRussG jiggles brain [23:45:02] Fundraising-Analysis, Phabricator, Project-Creators, Research-and-Data: Spaces request for Fundraising-Analysis - https://phabricator.wikimedia.org/T119258#1864153 (Krenair) >>! In T119258#1864061, @Qgil wrote: > @krenair, let me add that your style resolving these situations comes across as unnecess... [23:46:58] the-wub: BTW, unrelated to the above bug, whenever we create a new hide reason, we need to update the hide reason codes in ext.CentralNotice.display.state.js [23:47:15] Those are used in the minification of the banner history logs [23:47:34] Fundraising-Analysis, Phabricator, Project-Creators, Research-and-Data: Spaces request for Fundraising-Analysis - https://phabricator.wikimedia.org/T119258#1864164 (ellery) I apologize for the confusion I have caused. I learn through experimentation and tend to bias towards action instead of sending... [23:48:02] the-wub: if you're good to stick with that hide reason, we can add it easily [23:48:42] AndyRussG: ?? I thought that was the point of your patch the other day, that we could make any custom ones [23:48:52] using mw.centralNotice.customHideBanner() [23:48:54] the-wub: yes, we can make custom hide cookies with custom reasons [23:48:55] Yeah [23:49:24] And that will be recorded correctly in Special:RecordImpression and in the banner history data stored in users' browsers [23:49:57] However, the problem we still have with sending back banner history is that it has to be minified [23:50:10] So we have numeric codes for all the hide reasons [23:50:47] If we don't update that, banner history will just get the code for "other" hide reason... Not the end of the world, either, just might be nice to fix because data [23:52:10] Fundraising-Analysis, Phabricator, Project-Creators, Research-and-Data: Spaces request for Fundraising-Analysis - https://phabricator.wikimedia.org/T119258#1864169 (Krenair) >>! In T119258#1864164, @ellery wrote: > @Krenair Please do not assume I am acting in bad faith, knowingly breaking rules and t... [23:57:04] Fundraising-Analysis, Phabricator, Project-Creators, Research-and-Data: Spaces request for Fundraising-Analysis - https://phabricator.wikimedia.org/T119258#1864186 (DarTar) @krenair > It should be obvious that you should not mess around with transparency-sensitive things such as visibility policies... [23:57:18] AndyRussG: okay, we will continue using that hide reason. I am heading to bed now, please email if there are any more problems [23:58:38] Fundraising-Analysis, Phabricator, Project-Creators, Research-and-Data: Spaces request for Fundraising-Analysis - https://phabricator.wikimedia.org/T119258#1864196 (ellery) @Krenair I think you are missing my point, maybe we can chat in person during All Hands. It seems like the one thing we can ag...