[00:00:07] Fundraising-Backlog: CentralNotice: fix "Notice: Undefined index" in server logs with new hide cookie reason - https://phabricator.wikimedia.org/T120890#1864197 (AndyRussG) NEW [00:00:28] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work: CentralNotice: fix "Notice: Undefined index" in server logs with new hide cookie reason - https://phabricator.wikimedia.org/T120890#1864205 (AndyRussG) [00:00:51] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: CentralNotice: fix "Notice: Undefined index" in server logs with new hide cookie reason - https://phabricator.wikimedia.org/T120890#1864209 (AndyRussG) a:AndyRussG [00:04:10] (PS2) Awight: Handle another GC error indicating Order ID reuse [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/257767 (https://phabricator.wikimedia.org/T120805) [00:04:16] ejegg: more fun ^! [00:04:25] cool, looking! [00:10:07] Fundraising-Analysis, Phabricator, Project-Creators, Research-and-Data: Spaces request for Fundraising-Analysis - https://phabricator.wikimedia.org/T119258#1864224 (Krenair) >>! In T119258#1864186, @DarTar wrote: > it's clear that this is a major gap in the software and you should **never **assume th... [00:12:05] (PS3) Ejegg: Handle another GC error indicating Order ID reuse [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/257767 (https://phabricator.wikimedia.org/T120805) (owner: Awight) [00:12:46] aaarg I've been out of PHP sooo long [00:13:10] (CR) Ejegg: [C: 2] "Looks good, should drastically cut down the number of failed GC donors." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/257767 (https://phabricator.wikimedia.org/T120805) (owner: Awight) [00:13:15] Fundraising-Analysis, Phabricator, Project-Creators, Research-and-Data: Spaces request for Fundraising-Analysis - https://phabricator.wikimedia.org/T119258#1864229 (Krenair) >>! In T119258#1864196, @ellery wrote: > @Krenair I think you are missing my point, maybe we can chat in person during All Hand... [00:14:00] (Merged) jenkins-bot: Handle another GC error indicating Order ID reuse [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/257767 (https://phabricator.wikimedia.org/T120805) (owner: Awight) [00:15:38] Fundraising-Backlog: Civi exports timing out - https://phabricator.wikimedia.org/T120892#1864231 (MBeat33) NEW [00:18:47] ejegg: OK thanks! [00:19:02] (CR) Awight: Handle another GC error indicating Order ID reuse (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/257767 (https://phabricator.wikimedia.org/T120805) (owner: Awight) [00:20:49] bassoon! [00:22:37] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/257786 [00:23:23] awight: hoping to deploy that tonight, right? I want to get e972f67 (catch post-payment queue exceptions) out too, will prep commits. [00:23:23] 616d003 pared down iframe stylesheet [00:23:23] e972f67 Catch error queueing final status message [00:23:23] 4f0e325 Remove GC account number from tests [00:23:23] b8d0ca2 Handle another GC error indicating Order ID reuse [00:23:23] ack.... freaking middle button [00:24:16] (CR) Ejegg: [C: 2 V: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/257786 (owner: Ejegg) [00:25:02] ejegg: okay, I can babysit the deploy then. Holler when the smoke clears. [00:26:39] eileen1: Donno if you saw my response https://phabricator.wikimedia.org/T118037#1864041 [00:28:00] Hey, what do you guys do with OTRS tickets? [00:28:02] "When I donated through PayPal after reviewing a Wikipedia article, I found [00:28:02] it slightly difficult to go back to my article. [00:28:02] May I suggested opening the PayPal page in a new tab perhaps? " [00:28:09] https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=8843279 [00:28:12] MBeat: ^ [00:28:34] Reedy: Thanks for the note! We keep Donor Services tickets in ZenDesk. [00:28:51] I suppose that should be manually migrated over. [00:28:54] Mmm. Can I count this as "passed on to the relevant people"? :) [00:29:01] Or are you likely to open a phab ticket for it? [00:29:15] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/257789 [00:29:26] Reedy: We can take it from here! Thanks again. [00:29:45] (CR) Ejegg: [C: 2 V: 2] Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/257789 (owner: Ejegg) [00:29:48] thx Reedy - in OTRS you can fwd to wm-donations - this forward to Zendesk automatically [00:29:54] Ah [00:30:38] literally just forward it, rather than move queue? [00:32:32] moving it to that queue would be perfect, and much obliged :) [00:33:04] Done, thanks [00:35:12] ejegg: You doing the deployment or shall I? [00:35:25] code updating just now! [00:35:30] rad [00:36:34] !log updated paymentswiki from ff7a706219e72f7362f4e06386e6732933a40478 to 96d8a49ecd521ac8ce75521aaf97ed8f0dbefc9a [00:36:38] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [00:37:29] ooh, we caught one right away. [00:38:14] hey. order ID regenerated, iframe redirected and message sent to limbo [00:39:00] awesome! [00:39:16] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work, FR-GlobalCollect, Patch-For-Review: Duplicate Order ID detection is broken for GlobalCollect - https://phabricator.wikimedia.org/T120805#1864295 (awight) Looks good so far, we caught one of these in CT# 30972868 and it c... [00:39:26] oh phooey, died on return [00:39:34] Requested order id not present in the session [00:39:40] yeah. AARGH [00:39:44] want to patch that up quick and go forward? [00:40:15] regenerating order id should always update session [00:40:15] I'm... not sure [00:41:43] what could possibly go wrong :) [00:42:22] he said it. [00:45:32] Scary stuff. [00:45:37] (PS1) Awight: Store new ID to the session when regenerating Order ID [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/257795 (https://phabricator.wikimedia.org/T120805) [00:46:01] yeah, definitely [00:46:28] I'm a little bit encouraged by the fact we're already calling that at the start of every txn [00:47:01] and I don't see anything messing with $_SESSION['Donor'] mid txn and expecting it to persist [00:48:45] yeah. I see why it doesn't work, cos we're only retrying the do_transaction_internal and not the outer function. [00:49:33] awight: what about putting the addDonorData call on line 1079, after we've reassigned $this->unstaged_data ? [00:51:17] ejegg: rats. I'd like this to happen every time we regenerate the order ID, but I see what you're saying. [00:51:44] Did I mention that I'm utterly snowblinded by the "unstaged" terminology? [00:51:50] ahh, looks like we're good for order_id cause its unstaged_data value is set in refreshGatewayValueFromSource [00:52:06] but if there's anything else that depends on it... [00:52:22] er, no, that should be covered in the calculatedFields [00:55:04] awight: want to add an assertion to the test case that $_SESSION['Donor']['order_id'] != $orig_id [00:55:29] I think addRequestData populates unstaged, so we're good there. [00:55:40] ejegg: yes. I do. [00:55:42] one moment, please [00:58:43] MBeat: Here's the GC id for the potential new problem: 6926618581 [00:58:52] ty [00:58:55] (PS2) Awight: Store new ID to the session when regenerating Order ID [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/257795 (https://phabricator.wikimedia.org/T120805) [01:03:21] (CR) Ejegg: [C: 2] "Seems like the obviously correct thing to do. If anybody was relying on the old order ID being in session, they should be bopped with a m" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/257795 (https://phabricator.wikimedia.org/T120805) (owner: Awight) [01:03:42] * awight clicks to see what type of bopping this is [01:04:00] mallard [01:04:05] definitely a mallard [01:04:06] (Merged) jenkins-bot: Store new ID to the session when regenerating Order ID [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/257795 (https://phabricator.wikimedia.org/T120805) (owner: Awight) [01:05:38] my ducks are *loud*. And sharp. [01:06:28] (PS1) Awight: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/257803 [01:06:47] (CR) Awight: [C: 2] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/257803 (owner: Awight) [01:07:12] (Merged) jenkins-bot: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/257803 (owner: Awight) [01:07:45] (PS1) Awight: update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/257804 [01:08:00] Fundraising-Analysis, Research-and-Data-Archive: Revenue Projections - https://phabricator.wikimedia.org/T107946#1864343 (Peachey88) > ellery moved this task to Done on the Fundraising-Analysis workboard. @ellery, If this task is completed please close the task report out, This can be done by the Change s... [01:08:17] (CR) Awight: [C: 2] update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/257804 (owner: Awight) [01:09:44] * awight resists urge to V+2 [01:10:14] oh shoot, does that break things? [01:10:56] Fundraising-Backlog: Silverpop data inaccurate - two donors with the same contact ID - https://phabricator.wikimedia.org/T120897#1864349 (CCogdill_WMF) NEW [01:11:29] sorta [01:11:43] k, i'll quit doing it! [01:11:43] I hear that when we force submit, Zuul has to be rebooted. [01:11:55] I'm surprised They don't hunt us down more often... [01:13:02] oh man, a whole reboot? [01:13:47] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, MediaWiki-extensions-ContributionTracking, MediaWiki-extensions-DonationInterface: Consolidate contribution_tracking code into a single library - https://phabricator.wikimedia.org/T120466#1864363 (awight) This is part o... [01:14:16] or uh service restart [01:14:42] yeah, that still sounds ungood [01:15:56] Now I'm confused. Does our core#fundraising/REL1_25 branch merge via Zuul or not... [01:16:11] err... [01:16:13] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: UI Sillyness: Can't see all the fields when adding a new email address to a contact record - https://phabricator.wikimedia.org/T118037#1864366 (Eileenmcnaughton) Yes - the issue is just the navigation menu (left hand b... [01:16:15] let's see [01:17:26] https://gerrit.wikimedia.org/r/#/c/256594/1 got a v+2 from jenkins [01:17:56] And https://integration.wikimedia.org/zuul/ says that gate-and-submit jobs "will be merged by Jenkins if tests pass". [01:18:02] We need a serious CI makeover [01:18:08] oh, but it's got cwd on the 'merged' comment [01:18:21] I clicked. [01:18:54] cool, looks like the last 6 were all submitted by us [01:19:18] That's more a measure of our mean patience than CI config, though... [01:19:23] hey ejegg awight cwd|afk XenoRyet https://phabricator.wikimedia.org/T120897 [01:19:32] dstrine: ^ [01:19:43] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work: Silverpop data inaccurate - two donors with the same contact ID - https://phabricator.wikimedia.org/T120897#1864367 (atgo) [01:19:45] !log Updating paymentswiki from 96d8a49ecd521ac8ce75521aaf97ed8f0dbefc9a to 74143e43eb36f93be7881f626443182d3bb58cef [01:19:49] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [01:20:12] Fundraising-Backlog: Civi exports timing out - https://phabricator.wikimedia.org/T120892#1864369 (Eileenmcnaughton) ie it doesn't complete the search/ before you select to export the rows? When you say previously - do you know when it was last exporting. I don't think any recently-deployed changes would be... [01:20:15] MBeat: this is the timestamp at which I think I stopped causing that new status 600 bug [01:20:26] cool, thx [01:22:09] that one i just pasted is unbreak now [01:22:10] :| [01:22:32] atgomez: oh phooey, let's see what's up with those IDs [01:22:55] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work, FR-GlobalCollect, and 2 others: Duplicate Order ID detection is broken for GlobalCollect - https://phabricator.wikimedia.org/T120805#1864376 (awight) Not so fast... The session was not being updated, so we sent a bunch of... [01:23:09] thanks ejegg [01:26:53] Fundraising-Backlog: Civi exports timing out - https://phabricator.wikimedia.org/T120892#1864380 (MBeat33) sorry - I can complete the search, and see the results, it's the exporting that trips me up. I was able to export data as large or bigger as recently as 12/5 - thx [01:34:47] ejegg: What do you think about turning off the temporariness of the silverpop intermediate tables? [01:35:20] It's not a huge amount of data, and we're sort of shooting selves in the foot by wiping potentially admissable evidence. [01:35:34] (admissible) [01:35:35] awight: I had some theory that inserting into temp tables made mysql lock the source tables less [01:35:42] oh? [01:35:50] I forget if I had any evidence for that... [01:36:17] http://dev.mysql.com/doc/refman/5.7/en/internal-locking.html ? [01:37:35] so it's definitely row-level locks if anything [01:41:51] ok... *no* payments.errors [01:41:59] That does happen. [01:42:07] Plenty of successful stuff coming through [01:42:16] I'll take this opportunity to RUN AWAY [01:42:23] see ya! [01:47:43] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Temp tables for silverpop_export don't need to be temporary - https://phabricator.wikimedia.org/T120899#1864397 (Ejegg) NEW [01:48:56] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work: Silverpop data inaccurate - two donors with the same contact ID - https://phabricator.wikimedia.org/T120897#1864405 (Ejegg) @CCogdill_WMF, I see 325 duplicated contact IDs in the export. I'll keep digging for the cause and a... [01:51:19] Fundraising-Backlog: Civi exports timing out - https://phabricator.wikimedia.org/T120892#1864408 (Eileenmcnaughton) Do you just select default export fields or a mapping? [01:52:26] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work: Silverpop data inaccurate - two donors with the same contact ID - https://phabricator.wikimedia.org/T120897#1864409 (CCogdill_WMF) Thank you, @Ejegg, 325 is a comforting number. I will proceed with sending emails for now. I'm... [02:01:50] (PS1) AndyRussG: Prevent notice in logs for custom hide cookie reasons [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/257811 (https://phabricator.wikimedia.org/T120890) [02:03:01] ejegg: sory to distract and bug you so late, I got distracted by a bug... Mmm NE more thoughts on my node segfault? [02:03:14] s/sory/sorry/ [02:03:23] (It's just not the same with only one "r".) [02:03:41] AndyRussG: is your node_modules populated by checking out submodules, or by doing npm install? [02:04:02] I did populate the submodules, but didn't do npm install... [02:04:19] OK, so you've got all the same libs as me... [02:04:28] just tried npm install, that's doing stuff... [02:05:09] oh, hmm, I guess there are probably newer versions of things [02:05:25] I sure hope npm is getting the right versions for 0.8.2 [02:05:45] but anyway, where was your segfault? [02:07:04] AndyRussG: Oh hey, I bet you need a config file! [02:08:23] ejegg: Huh, npm install also segfaulted [02:08:25] at the end [02:08:38] pm ERR! Error: SSL Error: CERT_UNTRUSTED [02:08:38] npm ERR! at ClientRequest. (/home/lap/.nvm/v0.8.2/lib/node_modules/npm/node_modules/request/main.js:440:26) [02:08:38] Segmentation fault [02:09:00] Tho I'll still accept the config file... [02:09:14] weird, it's trying to run npm? [02:09:21] oh, sorry, i see [02:09:32] what happens when you run node server.js -d ? [02:11:05] As for a config file, you can edit defaults.js if you need to change db settings [02:11:34] AndyRussG: ^^ [02:11:39] Fundraising-Backlog: Civi exports timing out - https://phabricator.wikimedia.org/T120892#1864434 (MBeat33) There's a saved field mapping called fraud detection that I use. [02:12:10] ejegg: $ node server.js -d [02:12:10] Segmentation fault [02:12:14] Same old same old [02:12:27] oh, just immediately, huh? [02:12:41] try node config.js [02:12:46] see if node can run anything at all [02:13:48] or even node defaults.js - no libs at all [02:15:13] ejegg: hmm ^ both of the above are fine (no output tho) [02:15:24] yah, none expected [02:16:22] Maybe it's the same cert thing, then, just not saying so [02:16:34] AndyRussG: it really shouldn't be! [02:16:51] I think the cert thing is npm trying to download via ssl [02:17:16] and the dash shouldn't be doing any external requests at all with -d [02:17:31] (it talks to the oauth server if that's left off) [02:17:35] http://stackoverflow.com/questions/21855035/ssl-error-cert-untrusted-while-using-npm-command [02:17:42] This thing might help: https://github.com/ddopson/node-segfault-handler [02:17:53] let me see if I can install that [02:19:10] Hmm tried the cert workaround and tried npm install, now got a different segfault [02:19:20] hrm? [02:19:24] npm ERR! Error: No compatible version found: dotenv@'^0.4.0' [02:19:24] npm ERR! Valid install targets: [02:19:24] npm ERR! ["0.0.1","0.0.2","0.0.3","0.0.4","0.0.5","0.1.0","0.1.1","0.1.2","0.2.0","0.2.1","0.2.2","0.2.3","0.2.4","0.2.5","0.2.6","0.2.7","0.2.8","0.3.0","0.4.0","0.5.0","0.5.1","1.0.0","1.1.0","1.2.0"] [02:19:24] npm ERR! at installTargetsError (/home/lap/.nvm/v0.8.2/lib/node_modules/npm/lib/cache.js:588:10) [02:19:25] npm ERR! at /home/lap/.nvm/v0.8.2/lib/node_modules/npm/lib/cache.js:466:15 [02:19:27] npm ERR! at saved (/home/lap/.nvm/v0.8.2/lib/node_modules/npm/node_modules/npm-registry-client/lib/get.js:136:7) [02:19:29] Segmentation fault [02:19:39] Looks like maybe any error gives a segfault [02:20:02] err, ok, let's go back to the committed node_modules [02:20:15] K [02:20:23] somehow they work with 0.8.2 on at least my machine, cwd's, and the production server [02:20:29] git submodule update -i [02:20:35] yah [02:20:43] K that's good enuf :) [02:24:08] (PS1) Ejegg: DIAGNOSTIC: try using segfault-handler [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257813 [02:24:19] AndyRussG: wanna try ^^^ [02:24:38] after you pull that down, npm install segfault-handler [02:25:00] then see if running node server -d dumps anything interesting to stderr [02:25:16] oooh K! [02:25:44] Hahah segfault [02:25:59] npm http 200 https://registry.npmjs.org/bindings [02:25:59] npm ERR! Error: No compatible version found: bindings@'^1.2.1' [02:26:00] npm ERR! Valid install targets: [02:26:00] npm ERR! ["0.0.1","0.1.0","0.1.1","0.2.0","0.2.1","0.2.2","0.2.3","0.2.4","0.3.0","0.4.0","1.0.0","1.1.0","1.1.1","1.2.0","1.2.1"] [02:26:00] Segmentation fault [02:26:03] ejegg: ^ [02:26:35] aargh, you can't even install segfault-handler? [02:26:41] Nope [02:27:04] Maybe it's some system library that I have installed, that isn't compatible with this old node [02:27:08] Lemme try with a new version [02:27:35] (PS1) Ejegg: Add SQL formatting library [wikimedia/fundraising/dash/node_modules] - https://gerrit.wikimedia.org/r/257815 [02:27:37] (PS1) Ejegg: DIAGNOSTIC: segfault-handler [wikimedia/fundraising/dash/node_modules] - https://gerrit.wikimedia.org/r/257816 [02:27:57] AndyRussG: phooey, i guess so [02:28:11] K just tried node 0.1 [02:28:14] sorry 0.10 [02:28:24] And was able to install segfault-handler... :) [02:28:32] Ah, that'll definitely need to reinstall all the modules [02:28:39] or, i think it will... [02:29:17] Well it at least gives me a stacktrace when I try running server.js [02:29:31] yeah? where's the issue? [02:29:46] $ node server.js -d [02:29:46] module.js:356 [02:29:46] Module._extensions[extension](this, filename); [02:29:46] ^ [02:29:47] Error: Module version mismatch. Expected 11, got 1. [02:29:49] at Module.load (module.js:356:32) [02:29:52] at Function.Module._load (module.js:312:12) [02:29:54] at Module.require (module.js:364:17) [02:29:56] at require (module.js:380:17) [02:29:58] at /home/lap/Development/dash/node_modules/node-syslog/node-syslog.js:3:21 [02:30:00] at Object. (/home/lap/Development/dash/node_modules/node-syslog/node-syslog.js:66:3) [02:30:03] at Module._compile (module.js:456:26) [02:30:05] at Object.Module._extensions..js (module.js:474:10) [02:30:07] at Module.load (module.js:356:32) [02:30:07] yeah, the modules for 0.8.2 won't work on 0.10 [02:30:09] at Function.Module._load (module.js:312:12) [02:30:16] Sorry I guess I shoulda pastebinn'd [02:30:18] Yeah [02:30:39] ooh, I do remember node-syslog being problematic elsewhere though... [02:31:03] Hmmm and now even with your patch, and segfault-handler installed, 0.8.2 still just segfaults silently [02:31:03] can you install that one under 0.8.2? [02:31:10] argh... [02:31:26] Ah right, I guess what's installed under 0.10 isn't also available under 0.8.2... (?) [02:31:53] AndyRussG: I think they're all smooshed into the same node_modules folder [02:32:07] really [02:32:22] one node library dir to rule them all [02:32:32] K lemme go back to 0.10 and try npm install [02:33:58] AndyRussG: did any new file get created when it segfaulted? [02:34:02] Hmm even after npm install, it still won't run server.js (same error as above) [02:34:08] maybe try this: [02:34:09] var segfault = require( 'segfault-handler' ), didwegethere = console.log( 'loaded segfault handler' ), bs = segfault.registerHandler("crash.log"), [02:34:20] put that at the top of server.js [02:34:58] Apparently not... git status just says modified: node_modules (untracked content) [02:35:33] and try running again under 0.8.2, with this version of node_modules: https://gerrit.wikimedia.org/r/#/c/257816/ [02:37:13] $ node server.js -d [02:37:13] loaded segfault handler [02:37:14] PID 16412 received SIGSEGV for address: 0x0 [02:37:14] /home/lap/Development/dash/node_modules/segfault-handler/build/Release/segfault-handler.node(+0x18da)[0x7f9c153e48da] [02:37:14] /lib/x86_64-linux-gnu/libpthread.so.0(+0xf8d0)[0x7f9c1599e8d0] [02:37:14] node(_ZN2v88internal6String11WriteToFlatItEEvPS1_PT_ii+0x729)[0x7fe499] [02:37:16] node(_ZN2v88internal6String14SlowTryFlattenENS0_13PretenureFlagE+0xb3)[0x7fef83] [02:37:18] node(_ZN2v88internal24Runtime_StringCharCodeAtENS0_9ArgumentsEPNS0_7IsolateE+0x15d)[0x85332d] [02:37:20] [0x17eb3a30b88b] [02:37:41] uhhhh [02:37:57] ejegg: this seems like someone else's rabbit hole... What if I just try installing under vagrant rather than my frankenstein experimental/testing/unstable/stable debian box? [02:38:16] AndyRussG: that might be best... [02:38:37] If it works it might even be "useful" to see how to set up a vagrant version of this... [02:39:06] yeah, i was trying to get started with that, but i'm getting a bunch of errors from vagrant up [02:39:13] will figure that out at some point [02:39:23] Fundraising-Analysis, Phabricator, Project-Creators, Research-and-Data: Spaces request for Fundraising-Analysis - https://phabricator.wikimedia.org/T119258#1864456 (mmodell) Really no harm was done. On the internet it is difficult to tell whether a comment is only matter-of-fact bluntness or intenti... [02:40:10] ejegg: heh yeah that's another layer... Fortunately my vagrant is OK these days... [02:40:14] AndyRussG: ejegg, got Error: SSL Error: CERT_UNTRUSTED trying to npm install bower -- you ever get? [02:40:49] cwd: hi! that particular one yeah i solved--http://stackoverflow.com/questions/21855035/ssl-error-cert-untrusted-while-using-npm-command [02:40:56] But it still segfaulted :| [02:41:25] AndyRussG: did you just bypass ssl? wonder why such a popular repo doesn't have a trusted cert... [02:41:29] Fundraising-Analysis, Phabricator, Project-Creators, Research-and-Data: Spaces request for Fundraising-Analysis - https://phabricator.wikimedia.org/T119258#1864477 (mmodell) {T120903} [02:41:46] cwd it might be because old npm has an old cert bundled [02:42:38] wow, it got late! [02:42:50] i gotta get away from this computer... [02:42:58] ejegg: ah didn't think of that. now i will try my most silly favorite command [02:43:01] sudo npm install -g npm [02:43:03] ejegg: thanks so much, sorry to delay u! [02:43:07] good luck with the dash! [02:43:36] cwd: interesting [02:43:38] wait cwd, are you trying to install new bower modules? [02:43:54] ejegg|away: nah just bower install [02:43:56] the stuff in the submodules /should/ work if you've got it all checked out [02:44:09] bower_modules is also a git submodule [02:44:32] ah, yeah i have that (and same ssl error installing npm) [02:44:32] src/bower_modules, that is [02:44:54] and requirejs is still telling you stuff times out? [02:44:57] but it might have to do with network lag here (timeout loading some js) [02:46:13] yeah i think it's just lag and timing out [02:46:18] didn't work remotely, works at home [02:47:11] AndyRussG: you get segfault just trying to start the server? [02:47:14] ah, huh. maybe can change timeout in src/app/requirejs.config.js? [02:47:19] cwd: yep! [02:47:31] ok, really leaving now... [02:47:45] ejegg|away: cya! [02:50:21] AndyRussG: that's funky, and you've got the right node version... what linux? [02:50:27] cwd: debian [02:50:44] i definitely had dash running on jessie before [02:51:08] Hmmm yeah this is a mishmash of distributions [02:51:28] can't imagine how that would matter anyway [02:51:51] cwd: do you recommend installing node or npm using the os-provided packages? [02:52:12] AndyRussG: my process anymore is: [02:52:20] apt install npm [02:52:26] npm install -g n [02:52:31] n 0.8.2 [02:52:48] K I'll try that [02:52:51] (n is a top contender for worst named binary) [02:52:52] (in vagrant) [02:52:57] Heh [02:53:55] what is n? [02:54:12] AndyRussG: n is the new nvm (node version manager) [02:54:21] helpful naming... [02:54:22] Ah K [02:54:29] Krenair: nnnnnnnaming! :) [02:54:53] it's not that the unix forefathers didn't consider one letter binaries, it's that they decided (wisely imo) not to [02:55:26] also didn't forbid filenames beginnign with dashes... [02:55:46] like -r and -f [02:56:12] and yet we ended up with flags like -g [02:57:05] Krenair: which to npm means "do a completely conceptually different thing" [02:57:36] * AndyRussG is just copying commands blindly [02:57:46] $ n 0.8.2 [02:57:46] install : node-v0.8.2 [02:57:46] Error: invalid version 0.8.2 [02:58:09] cwd: ^ [02:58:38] AndyRussG: ah yeah, i'm running 0.8.7, seems to work fine [02:59:10] ah K trying [02:59:15] i really think if we want to take advantage of what node has to offer we should get this project on stable [02:59:33] ES6 (ES2015?) has been merged into core since [03:00:57] ? [03:01:01] K 0.8.7 installed... [03:01:19] AndyRussG: https://nodejs.org/en/docs/es6/ [03:03:03] ah right! contemporary js... [03:10:10] cwd: woops sorry about that, VirtualBox + X11 from experimental together hosed my computer [03:13:47] AndyRussG: sounds about right [03:14:20] heheh recently my vagrant has been all processor heavy, haven't gotten it to work right yet [03:14:57] Mmm combine that with the Java powering Eclipse... [03:19:09] yeah virtualbox guzzles my laptop battery [03:22:37] cwd: heh fortunately I don't mind being plugged in most of the time, but my fan and air ducts are getting dirty, and thus louder every day [03:22:58] I should clean this thing out one day [03:54:53] cwd: time to sleep! cya 'round :) [08:26:05] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-GlobalCollect: Most "Clock at" profiling messages are irrelevant - https://phabricator.wikimedia.org/T120917#1864722 (awight) NEW [09:29:16] Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, FR-GlobalCollect: Do not show donation form error message: "No processors available" - https://phabricator.wikimedia.org/T117872#1864811 (awight) [09:29:18] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work, FR-GlobalCollect, and 2 others: Duplicate Order ID detection is broken for GlobalCollect - https://phabricator.wikimedia.org/T120805#1864809 (awight) Open>Resolved Verified working for at least one case, `30998951:569... [09:31:00] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CC Large Donation Emails to Janelle - https://phabricator.wikimedia.org/T120301#1864813 (awight) [09:32:28] Fundraising Sprint Queen, Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint The Pogues, and 8 others: Log DonationInterface fatal errors to syslog - https://phabricator.wikimedia.org/T107918#1864814 (awight) To verify: run the log tickler for old times' s... [09:38:59] (CR) Awight: "@AndyRussG: I think we should fail closed instead, and look up a default hide duration for the 'other' catchall. Happy to merge it this w" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/257811 (https://phabricator.wikimedia.org/T120890) (owner: AndyRussG) [09:40:51] (PS5) Awight: Groupings and stacked bar charts for X-by-Y [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257078 (https://phabricator.wikimedia.org/T86094) (owner: Ejegg) [15:23:04] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising: Donatewiki form is displaying with low dollar amount and then changing quickly. Also showing Amazon and then hiding. - https://phabricator.wikimedia.org/T119678#1865466 (Pcoombe) @CCogdill_WMF I fixed the CSS on the form by ju... [15:46:20] (Abandoned) Cdentinger: break out of iframe with liberated request var [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/256961 (owner: Cdentinger) [16:42:48] (PS3) Cdentinger: Make darn sure the modal goes away [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257004 (owner: Ejegg) [16:42:57] (CR) Cdentinger: [C: 2] Make darn sure the modal goes away [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257004 (owner: Ejegg) [16:43:38] thanks cwd! That was getting really annoying in dev - not sure if it cropped up much in prod [16:44:23] np! yeah i was seeing it consistently with https://gerrit.wikimedia.org/r/#/c/257754/2 for some reason [16:44:28] so now i'll see if that goes away [16:44:45] (PS3) Cdentinger: Add age of donations in payments_initial [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257754 (owner: Ejegg) [16:44:50] (Merged) jenkins-bot: Make darn sure the modal goes away [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257004 (owner: Ejegg) [16:45:23] (PS4) Cdentinger: Add age of donations in payments_initial [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257754 (owner: Ejegg) [16:47:32] weird, i still see it on there [16:47:39] oh no! [16:49:51] hmmm: TypeError: dataget.results is undefined [16:49:56] ruh roh [16:50:00] let's see... [16:50:15] ah i just don't have any data in there [16:50:43] oh yeah, some kind of error handling might be nice... [16:51:04] yeah, i'll throw something in [16:57:05] (PS1) Cdentinger: handle no 'donation age' results [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257927 [16:57:05] fanny needs a walk, back in a bit! [17:00:57] Fundraising-Backlog: Advise BPay donors not to reuse reference #s - https://phabricator.wikimedia.org/T119912#1865841 (MBeat33) [17:02:14] (CR) Ejegg: "If we wanted to handle the case where one table has data but not the other, we could fix it in SQL by wrapping each part of the union in c" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257927 (owner: Cdentinger) [17:17:31] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: iframe not appearing for some people (confirmed modern browsers) - https://phabricator.wikimedia.org/T112181#1865913 (MBeat33) #184625 is a mobile donor: -iPhone 6 plus -software update 9.2 not yet installed -... [17:37:33] Fundraising-Backlog: Advise BPay donors not to reuse reference #s - https://phabricator.wikimedia.org/T119912#1865975 (Pcoombe) Thanks Michael. This isn't something I could do on my own, it would need a DonationInterface change and deployment. [17:37:57] Fundraising-Backlog: Donation form stops at "Loading: Where Your Donation Goes" - https://phabricator.wikimedia.org/T120675#1865976 (Pcoombe) a:Pcoombe [17:43:27] Phew finally got my vagrant running without a zillion% CPU usage [17:49:18] AndyRussG: what was the secret? vagrant suspend? :D [17:50:05] Hheh no, update virtualbox on the host, then vagrant destroy, git pull, ./setup.sh, vagrant up [17:50:22] what version of virtualbox are you running? [17:53:59] Fundraising-Backlog, Wikimedia-Fundraising, Analytics: Public dashboards for CentralNotice and Fundraising - https://phabricator.wikimedia.org/T88744#1866043 (Milimetric) Can we get more information on this task? What kind of dashboards, what kind of data are we visualizing, how often is it updated,... [17:54:19] cwd: 5.0.10 [17:54:52] nice, me too [17:55:18] Yeah it was the same version number as before, just some minor Debian package update [17:55:32] Not sure if that's what fixed it, but I'm glad it's fixed [17:55:53] I was like I can work with this, but the laptop fan is like a vaccum cleaner [17:56:14] Fundraising-Backlog: Donation form stops at "Loading: Where Your Donation Goes" - https://phabricator.wikimedia.org/T120675#1866057 (Pcoombe) Open>Resolved I couldn't reproduce what's causing this. However @Ejegg's suggestion is a good one, and I've implemented it. This should stop it from stalling on... [17:56:32] Now running node inside vagrant, and it isn't segfaulting [17:56:32] ! [17:56:35] :) [18:01:34] cwd / AndyRussG / XenoRyet Anything for scrum of scrums? It's 1/2 hr early today [18:01:54] Nothing from me [18:01:55] hmmm, don't think so [18:01:57] thanks! [18:02:00] cool [18:02:57] ejegg: no all good, thx! [18:03:03] ty [18:03:11] say hi to the big english standup for me! [18:10:14] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: iframe not appearing for some people (confirmed modern browsers) - https://phabricator.wikimedia.org/T112181#1866179 (MBeat33) #184625 used a banner from Wikipedia [18:16:36] Fundraising Dash, Fundraising-Backlog: Add a favicon to the Dash - https://phabricator.wikimedia.org/T120979#1866220 (atgo) NEW [18:24:55] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work: Silverpop data inaccurate - two donors with the same contact ID - https://phabricator.wikimedia.org/T120897#1866267 (atgo) p:Unbreak!>High [18:25:18] Fundraising-Backlog: mobile error: unresponsive Amazon donate button - https://phabricator.wikimedia.org/T120981#1866268 (MBeat33) NEW [18:28:19] the-wub, thanks for T120675 [18:30:17] no problem MBeat [18:36:59] Fundraising-Backlog: mobile error: unresponsive Amazon donate button - https://phabricator.wikimedia.org/T120981#1866323 (atgo) @pcoombe I think this is probably one for you - let us know if tech needs to look at it, too. [18:45:38] (PS1) Ejegg: Add favicon [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257963 (https://phabricator.wikimedia.org/T120979) [18:47:17] Fundraising Dash, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review: Add a favicon to the Dash - https://phabricator.wikimedia.org/T120979#1866353 (atgo) [18:50:43] ejegg: where do I change the port used by dash? [18:52:25] ah K found it, I think [18:53:53] Hmmm changed it in default.js, no dice tho [18:54:06] hmm, let me see [18:55:35] AndyRussG: what did you change listen to? [18:55:54] Second line of defaults.js [18:56:03] P.S. No more segfaults! [18:56:10] Working fine under vagrant [18:56:15] Well, "fine" so far [18:57:06] AndyRussG: what value are you using for listen? [18:57:12] 8000 [18:57:15] Awesome that it's running! [18:57:16] Lemme try another I guess [18:57:20] Yeah! [18:57:21] hmm, that totally ought to work [18:57:54] when you run with -d, does it say 'Will try to listen on port: 8000' ? [18:57:56] $ node server.js -d [18:57:57] Dash starting up [18:57:57] Will try to listen on IP address: undefined [18:57:57] Will try to listen on port: 8080 [18:57:57] Using OAuth providerURL: https://civi.dev/civi [18:57:57] Using OAuth providerBackendURL: http://localhost/civi [18:57:59] Application error: Error: listen EADDRINUSE [18:58:14] So it doesn't actually take the change into account... [18:58:45] ejegg: ah wait, I see the issue [18:58:52] It's some vagrant nfs problem [18:58:53] ah whew [18:58:57] ;) [18:59:12] 'cos that's the only place we say 8080 in the source! [18:59:23] yeah [18:59:25] :) [18:59:46] ejegg: thx much... gotta run to a wee meeting, cya! [19:00:05] i might be in that one too! [19:01:10] (PS2) Ejegg: Add favicon [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257963 (https://phabricator.wikimedia.org/T120979) [19:01:15] Fundraising-Backlog: Globalcollect donor name field empty - https://phabricator.wikimedia.org/T120986#1866400 (MBeat33) NEW [19:03:57] ejegg: ah yeah u r! [19:04:00] hey ejegg you joining this meeting? [19:04:06] one sec! [19:09:40] ejegg: is there a bad echo? i'm muted by mic and by hangout, but i am hearing a little echo [19:10:52] atgomez: just a little one, sorry, thought it was the room [19:41:07] Fundraising-Backlog: mobile error: unresponsive Amazon donate button - https://phabricator.wikimedia.org/T120981#1866522 (Pcoombe) a:Pcoombe Yep, this sounds like a banner bug. @MBeat33 do you know if the donor tried any of the other buttons? Please let me know if you hear of any more occurrences [19:51:08] Fundraising-Backlog: mobile error: unresponsive Amazon donate button - https://phabricator.wikimedia.org/T120981#1866564 (MBeat33) @Pcoombe, I've asked the donor and will add any future occurrences here. [19:52:41] atgomez: you around? [19:58:21] Fundraising-Backlog: Localization for Mustache forms - https://phabricator.wikimedia.org/T120992#1866585 (cwdent) NEW [20:05:45] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Adyen: Localization for Mustache forms - https://phabricator.wikimedia.org/T120992#1866612 (awight) [20:06:51] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Adyen: Adyen as a backup for en outside of the US: AU, CA, GB, IE, NZ - https://phabricator.wikimedia.org/T120994#1866619 (awight) NEW [20:07:04] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Adyen: Localization for Mustache forms - https://phabricator.wikimedia.org/T120992#1866585 (awight) [20:07:07] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Adyen: Adyen as a backup for en outside of the US: AU, CA, GB, IE, NZ - https://phabricator.wikimedia.org/T120994#1866626 (awight) [20:07:09] cwd: donno whether that helps ^ [20:07:39] awight: thanks! i'll look through that [20:08:12] Fundraising-Backlog: PayPal donation link unresponsive - https://phabricator.wikimedia.org/T120995#1866629 (MBeat33) NEW [20:09:03] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Adyen: Adyen as a backup for en outside of the US: AU, CA, GB, IE, NZ - https://phabricator.wikimedia.org/T120994#1866619 (awight) Make the forms appropriate for international (English) use, as a backup credit card processor for the Big E... [20:09:39] Fundraising-Backlog, FR-Adyen: Confirm that Adyen account can process AUD, CAD, GBP, EUR, and NZD, and from all Big English countries. - https://phabricator.wikimedia.org/T120996#1866638 (awight) NEW a:Ppena [20:11:17] sorry - started a bit later today & missed that deploy mtg [20:11:39] (actually not really later - but just not earlier) [20:11:47] Fundraising Dash, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review: Add a favicon to the Dash - https://phabricator.wikimedia.org/T120979#1866647 (Ejegg) a:Ejegg [20:13:51] Fundraising-Analysis, Fundraising-Backlog: Provide graph of banner impression count distribution - https://phabricator.wikimedia.org/T120997#1866653 (awight) NEW [20:19:54] woo my dash rang! love the dash bell [20:24:15] Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Can we get the staging (CiviCRM & Drupal) DB updated from live? - https://phabricator.wikimedia.org/T119748#1866698 (Eileenmcnaughton) Any progress on this - it would be really helpful for debugging https://phabricator.wikimedia.org/T120892 [20:25:26] Fundraising-Backlog, FR-GlobalCollect: Must open a new GlobalCollect account in order to escape Order ID apocalypse - https://phabricator.wikimedia.org/T121000#1866699 (awight) NEW [20:25:35] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, FR-GlobalCollect: Globalcollect Status 25/404 errors - https://phabricator.wikimedia.org/T120030#1866706 (MBeat33) For the time being we'll advise donors to try a different method... [20:26:03] Fundraising-Backlog, FR-GlobalCollect: Must open a new GlobalCollect account in order to escape Order ID apocalypse - https://phabricator.wikimedia.org/T121000#1866712 (awight) [20:27:29] Fundraising-Backlog, FR-GlobalCollect: Civi `trxn_id` must support multiple gateway accounts - https://phabricator.wikimedia.org/T121001#1866730 (awight) NEW [20:33:20] awight: nice trips [20:33:33] T1211000 [20:35:02] cwd: too many of some digit? that's not a thing yet... [20:36:35] cwd: ah. my odometer score, gotcha! [20:37:12] :D [20:43:11] Fundraising-Backlog, FR-GlobalCollect: Civi `trxn_id` must support multiple gateway accounts - https://phabricator.wikimedia.org/T121001#1866780 (Eileenmcnaughton) There is a unique index in the contribution table on trxn_id. I think it usually makes sense to have a unique key in the financial_trxn table... [20:46:11] cwd: ejegg: finally got a local instance of dash running! :) [20:46:32] hooray! [20:46:35] :D [20:46:39] "local" on vagrant [20:46:56] ejegg: now... hmmm... I click on login and it gives me an error... [20:47:04] AndyRussG: are you running with -d? [20:47:15] ejegg: yep [20:47:19] Nothing visible on the console [20:47:37] { [20:47:37] "code": "ER_ACCESS_DENIED_ERROR", [20:47:37] "errno": 1045, [20:47:37] "sqlState": "28000", [20:47:38] "fatal": true [20:47:40] } [20:47:44] (in the browser) [20:47:59] hmm... [20:48:06] oh hey, that's from the db! [20:48:16] Yeah! [20:48:18] let's set those db credentials in the defaults.js [20:48:25] Hmm maybe I need to change the db user [20:48:30] yeah [20:48:39] also, you may need to run the schema scripts [20:48:44] Did that :) [20:48:47] cool [20:50:07] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: UI Sillyness: Can't see all the fields when adding a new email address to a contact record - https://phabricator.wikimedia.org/T118037#1866795 (Eileenmcnaughton) {F3062080} In this menu 'Import Checks', 'Test Thank-yo... [20:53:08] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: UI Sillyness: Can't see all the fields when adding a new email address to a contact record - https://phabricator.wikimedia.org/T118037#1866817 (Eileenmcnaughton) Note that having the 'admin' in the urls is what makes t... [21:01:47] AndyRussG: New db creds fix the problem? [21:19:23] ejegg: not yet... [21:19:38] new issue? or the same? [21:36:43] ejegg: same.... [21:37:48] ejegg: it looks like there are 2 sets of credentials in default.js [21:38:19] neither seems good tho... [21:38:40] AndyRussG: Ah, one sec [21:39:21] ejegg: hmm maybe also I have the wrong pw for mysql on vagrant [21:39:38] AndyRussG: OK, for civicrmDb, dblogin, and dbpwd, copy the values for the CiviCRM db from the civi settings file [21:39:46] one sec, let me find that [21:40:35] ejegg: ahh K hmm [21:40:49] OK, get those values from CIVICRM_DSN in sites/default/civicrm.settings.php [21:41:23] then for the other set - userDb* [21:42:06] that should be a user with write access to the userDb, where the dash_user etc tables are (often this is also fredge) [21:48:45] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: UI Sillyness: Can't see all the fields when adding a new email address to a contact record - https://phabricator.wikimedia.org/T118037#1867075 (Eileenmcnaughton) I did some checks & it seems to be the system generated... [21:49:44] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CC Large Donation Emails to Janelle - https://phabricator.wikimedia.org/T120301#1867083 (Eileenmcnaughton) @leannes that link should be on your left hand menu now too Ok to close this? [21:52:01] gonna relocate [21:57:35] ejegg: weeeee works :) [21:57:44] hooray! [21:57:52] Were you able to get any test data in there? [21:58:51] hmm, let me actually check in some datasets from mockaroo [21:58:53] ejegg: notyet! [21:59:06] but it shows a dashboard :) [21:59:10] wheee! [22:01:22] AndyRussG: Here's a CRM patch that you'll need to follow the test data directions: https://gerrit.wikimedia.org/r/247765 [22:01:30] feel free to +2 if it looks good! [22:02:34] ejegg: cool...! Where are the test data directions? [22:04:31] AndyRussG: https://gerrit.wikimedia.org/r/257037 [22:04:42] I'm going to check in some datasets with that in a sec [22:05:10] ejegg: fantastic! K, so I should wait for a new patchset on that last one? [22:05:38] yep, jus 1 min [22:08:08] ejegg: thx! [22:12:37] (PS3) Ejegg: WIP document test data generation [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257037 [22:12:45] AndyRussG: OK, there's some test data in there now [22:12:52] will update readme in a sec [22:13:08] but basically, first run the contribution_tracking.sql script against your drupal db [22:13:27] weeeee [22:13:41] then use the drush command (with the multi-message patch for CiviCRM) to import all the json DonationQueueMessages [22:14:27] Finally, run the sql commands in payments_initial.sql against your fredge db to populate the payments_initial table [22:19:22] (CR) AndyRussG: "> I think we should fail closed instead, and look up a default" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/257811 (https://phabricator.wikimedia.org/T120890) (owner: AndyRussG) [22:31:58] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CC Large Donation Emails to Janelle - https://phabricator.wikimedia.org/T120301#1867321 (LeanneS) @Eileenmcnaughton Thank you! The link is very helpful. All set to close this task. [22:38:38] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CC Large Donation Emails to Janelle - https://phabricator.wikimedia.org/T120301#1867370 (Eileenmcnaughton) Open>Resolved [22:45:52] Fundraising-Backlog, FR-GlobalCollect: Must open a new GlobalCollect account in order to escape Order ID apocalypse - https://phabricator.wikimedia.org/T121000#1867415 (awight) [22:48:08] Fundraising Sprint Yo La Tengo, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: Analyze options for limiting banners following close button clicks causing incorrect impression counts in impression diet cookies. - https://phabricator.wikimedia.org/T121031#1867430 (AndyRussG) NEW [22:48:20] Fundraising Sprint Yo La Tengo, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: Analyze options for limiting banners following close button clicks causing incorrect impression counts in impression diet cookies. - https://phabricator.wikimedia.org/T121031#1867439 (AndyRussG) a:AndyRussG [22:51:59] (PS4) Ejegg: WIP test data [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257037 [22:52:09] (CR) Awight: "Splitting hair further. Ouch!" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/257811 (https://phabricator.wikimedia.org/T120890) (owner: AndyRussG) [22:52:19] (PS2) Ejegg: Queue consumer can import multiple messages from JSON [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/247765 (https://phabricator.wikimedia.org/T114466) [22:52:56] PPena: thank you, Pats! [22:54:31] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Adyen: Adyen as a backup for en outside of the US: AU, CA, GB, IE, NZ - https://phabricator.wikimedia.org/T120994#1867496 (awight) [22:54:33] Fundraising-Backlog, FR-Adyen: Confirm that Adyen account can process AUD, CAD, GBP, EUR, and NZD, and from all Big English countries. - https://phabricator.wikimedia.org/T120996#1867494 (awight) Open>Resolved Eran Belo from Adyen says, > You can process all your volume on your existing single merch... [22:55:00] PPena: got the adyen button to say donate! [22:55:18] (CR) AndyRussG: "hairs.gotNeurons() === false ;p" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/257811 (https://phabricator.wikimedia.org/T120890) (owner: AndyRussG) [22:56:11] (CR) Awight: [C: 2] "Great! TODO: generalize import from file and reuse from all drush import commands." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/247765 (https://phabricator.wikimedia.org/T114466) (owner: Ejegg) [22:56:34] thanks awight ! [22:59:29] (Merged) jenkins-bot: Queue consumer can import multiple messages from JSON [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/247765 (https://phabricator.wikimedia.org/T114466) (owner: Ejegg) [23:00:34] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising: Donatewiki form is displaying with low dollar amount and then changing quickly. Also showing Amazon and then hiding. - https://phabricator.wikimedia.org/T119678#1867539 (CCogdill_WMF) Awesome, thanks again, @Pcoombe! [23:00:56] (PS1) Ejegg: Oozie/Hive scripts to get email tracking data [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/258058 (https://phabricator.wikimedia.org/T114010) [23:06:34] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work: banner data and missing alterImpressionData(): Determine exact impact on data and coping mechanisms - https://phabricator.wikimedia.org/T120017#1867559 (AndyRussG) a:AndyRussG [23:09:25] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work: banner data and missing alterImpressionData(): Determine exact impact on data and coping mechanisms - https://phabricator.wikimedia.org/T120017#1867565 (AndyRussG) Started [[ https://collab.wikimedia.org/wiki/Fundraising/2015/... [23:15:04] (PS2) Ejegg: Oozie/Hive scripts to get email tracking data [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/258058 (https://phabricator.wikimedia.org/T114010) [23:16:47] (CR) Cdentinger: [C: 2] Actually sort filters [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257209 (owner: Ejegg) [23:20:37] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, FR-GlobalCollect: Globalcollect Status 25/404 errors - https://phabricator.wikimedia.org/T120030#1867605 (MBeat33) The donor in #182876 using Chrome Version 47.0.2526.73 got this... [23:21:14] (CR) Cdentinger: [C: 2] Hide filters not intended for user selection [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257204 (owner: Ejegg) [23:22:59] (CR) Cdentinger: [C: 2] Add favicon [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257963 (https://phabricator.wikimedia.org/T120979) (owner: Ejegg) [23:26:31] (Merged) jenkins-bot: Actually sort filters [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257209 (owner: Ejegg) [23:26:33] (Merged) jenkins-bot: Add favicon [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257963 (https://phabricator.wikimedia.org/T120979) (owner: Ejegg) [23:30:08] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Add default order for Lybunt report to sort descending by greatest 2014 amount - https://phabricator.wikimedia.org/T119911#1867623 (Eileenmcnaughton) @caitvirtue - did you try re-running the lybunt [23:36:25] (CR) Cdentinger: [C: 2] Add numeric filters [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257203 (https://phabricator.wikimedia.org/T120678) (owner: Ejegg) [23:37:05] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work, Patch-For-Review: CentralNotice: impression diet and hide cookies interaction bug causes hidden impression counting for impression diet - https://phabricator.wikimedia.org/T120698#1867652... [23:37:31] Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Reports "Save a Copy" is broken - https://phabricator.wikimedia.org/T117166#1867654 (Eileenmcnaughton) [23:38:04] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: UI Sillyness: Can't see all the fields when adding a new email address to a contact record - https://phabricator.wikimedia.org/T118037#1867658 (Eileenmcnaughton) [23:38:22] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work, FR-GlobalCollect, Patch-For-Review: Fix error when processing refunds in GlobalCollect WR1 audit script - https://phabricator.wikimedia.org/T120411#1867659 (awight) [23:38:27] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work, FR-GlobalCollect: GC audit failed two days in a row: timing out after 90 minutes - https://phabricator.wikimedia.org/T120397#1867660 (DStrine) [23:39:15] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: LYBUNT: Change "lifetime total" to "Last year total" - https://phabricator.wikimedia.org/T119909#1867661 (Eileenmcnaughton) [23:39:48] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work, FR-GlobalCollect, and 2 others: Duplicate Order ID detection is broken for GlobalCollect - https://phabricator.wikimedia.org/T120805#1867662 (awight) [23:40:06] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Add default order for Lybunt report to sort descending by greatest 2014 amount - https://phabricator.wikimedia.org/T119911#1867664 (Eileenmcnaughton) [23:40:25] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CC Large Donation Emails to Janelle - https://phabricator.wikimedia.org/T120301#1867665 (DStrine) [23:40:52] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Add column to Engage Import: Direct Mail Appeal - https://phabricator.wikimedia.org/T119921#1867666 (awight) Resolved>Invalid [23:40:54] Fundraising-Backlog: Adyen form cries "No processors available" when country set to GB - https://phabricator.wikimedia.org/T121036#1867668 (cwdent) NEW [23:41:04] Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Add tag to CiviCRM: "Invite to all events" - https://phabricator.wikimedia.org/T118889#1867675 (DStrine) [23:42:36] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work, FR-GlobalCollect, Patch-For-Review: Fix error when processing refunds in GlobalCollect WR1 audit script - https://phabricator.wikimedia.org/T120411#1867677 (awight) [23:43:31] Fundraising Dash, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Patch-For-Review: Add country filter to Fraud widget on Dash - https://phabricator.wikimedia.org/T89526#1867679 (atgo) [23:45:29] Fundraising Dash, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Patch-For-Review: Add country filter to Fraud widget on Dash - https://phabricator.wikimedia.org/T89526#1038435 (atgo) Open>Resolved [23:45:31] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work: banner data and missing alterImpressionData(): Determine exact impact on data and coping mechanisms - https://phabricator.wikimedia.org/T120017#1867684 (AndyRussG) [23:45:34] Fundraising Sprint Yo La Tengo, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: Analyze options for limiting banners following close button clicks causing incorrect impression counts in impression diet cookies. - https://phabricator.wikimedia.org/T121031#1867687 (AndyRussG) [23:45:36] Fundraising Sprint Yo La Tengo, Fundraising-Backlog: Sprint Y goal (11/25 - 12/9): Kick off Big English!! - https://phabricator.wikimedia.org/T115623#1867688 (DStrine) Open>Resolved [23:46:12] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: UI Sillyness: Adding an address to an existing contact works, but looks weird - https://phabricator.wikimedia.org/T118104#1867694 (Eileenmcnaughton) @caitvirtue - is the resolved now we changed the theme? [23:51:06] Fundraising-Backlog: Spike: Is it a problem that the Silverpop export is still not updating entire database? - https://phabricator.wikimedia.org/T120880#1867734 (atgo) p:Triage>High [23:52:31] Fundraising-Backlog: Advise BPay donors not to reuse reference #s - https://phabricator.wikimedia.org/T119912#1867743 (atgo) @meganhernandez_wmf @ccogdill_wmf @jrobell @pcoombe - can you give us a line of text for this please? [23:52:40] (PS1) Awight: Update WMF's mailing address in thank-you letter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/258070 (https://phabricator.wikimedia.org/T120877) [23:52:53] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: UI Sillyness: Can't see all the fields when adding a new email address to a contact record - https://phabricator.wikimedia.org/T118037#1867749 (Eileenmcnaughton) @caitvirtue - this is another one that the theme change... [23:53:30] Fundraising-Backlog, Patch-For-Review: Deploy thank you letter to update postal address - https://phabricator.wikimedia.org/T120877#1867751 (awight) @jrobell Side note: the current pt and pt-br translations include an English paragraph, the one starting "Everyone is a potential Wikipedian." [23:53:48] Fundraising Sprint Z, Fundraising-Backlog, Patch-For-Review: Deploy thank you letter to update postal address - https://phabricator.wikimedia.org/T120877#1867752 (awight) [23:54:55] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: Analyze options for limiting banners following close button clicks causing incorrect impression counts in impression diet cookies. - https://phabricator.wikimedia.org/T121031#1867754 (DSt... [23:57:11] Fundraising Sprint Yo La Tengo, Fundraising Sprint Z, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: Analyze options for limiting banners following close button clicks causing incorrect impression counts in impress... - https://phabricator.wikimedia.org/T121031#1867770 [23:57:13] Fundraising Sprint Yo La Tengo, Fundraising Sprint Z, Fundraising-Backlog, Unplanned-Sprint-Work: Silverpop data inaccurate - two donors with the same contact ID - https://phabricator.wikimedia.org/T120897#1867771 (DStrine) [23:57:15] Fundraising Sprint Z, Fundraising-Backlog: Civi exports timing out - https://phabricator.wikimedia.org/T120892#1864231 (DStrine) [23:57:18] Fundraising Sprint Yo La Tengo, Fundraising Sprint Z, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, and 2 others: CentralNotice: fix "Notice: Undefined index" in server logs with new hide cookie reason - https://phabricator.wikimedia.org/T120890#1867773 (DStrine) [23:57:20] Fundraising Dash, Fundraising Sprint Yo La Tengo, Fundraising Sprint Z, Fundraising-Backlog, and 2 others: Allow user to create and add widgets to multiple boards - https://phabricator.wikimedia.org/T120673#1867777 (DStrine) [23:57:22] Fundraising Dash, Fundraising Sprint Yo La Tengo, Fundraising Sprint Z, Fundraising-Backlog, and 2 others: Add numeric filters to common filter component - https://phabricator.wikimedia.org/T120678#1867776 (DStrine) [23:57:24] Fundraising Sprint Yo La Tengo, Fundraising Sprint Z, Fundraising-Backlog, Unplanned-Sprint-Work, and 2 others: Fix error when processing refunds in GlobalCollect WR1 audit script - https://phabricator.wikimedia.org/T120411#1867778 (DStrine) [23:58:01] Fundraising Dash, Fundraising Sprint Yo La Tengo, Fundraising Sprint Z, Fundraising-Backlog, and 4 others: Dash: breakdown bars - https://phabricator.wikimedia.org/T86094#1867818 (DStrine) [23:58:02] Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, and 5 others: Edits to LYBUNT report - https://phabricator.wikimedia.org/T88819#1867817 (DStrine)