[00:05:46] (CR) Pcoombe: [C: 2] "Looks good. Thanks Adam!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/258070 (https://phabricator.wikimedia.org/T120877) (owner: Awight) [00:07:44] Fundraising Sprint Yo La Tengo, Fundraising Sprint Zapp, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: iframe not appearing for some people (confirmed modern browsers) - https://phabricator.wikimedia.org/T112181#1867862 (MBeat33) the donor in ZD #182003 got as far as selecting a card... [00:08:46] Fundraising Sprint Zapp, Fundraising-Backlog: Civi exports timing out - https://phabricator.wikimedia.org/T120892#1867869 (Eileenmcnaughton) a:Eileenmcnaughton [00:09:38] Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising Sprint Zapp, Fundraising-Backlog, and 2 others: Civi error while running module schema upgrade - https://phabricator.wikimedia.org/T116877#1867878 (Eileenmcnaughton) Open>Resolved [00:10:56] Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising Sprint Zapp, Fundraising-Backlog, FR-Adyen: Adyen: retest internally with real credit cards - https://phabricator.wikimedia.org/T118293#1867885 (Ejegg) [00:10:58] Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 4 others: Update Adyen adapter to use SHA-256 signature - https://phabricator.wikimedia.org/T116679#1867883 (Ejegg) Open>Resolved [00:12:06] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising, Unplanned-Sprint-Work: Make FR banners not display over Mediaviewer - https://phabricator.wikimedia.org/T120130#1867889 (DStrine) [00:12:41] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Wikimedia-Fundraising, Unplanned-Sprint-Work: Make FR banners not display over Mediaviewer - https://phabricator.wikimedia.org/T120130#1867892 (DStrine) Open>Resolved [00:13:07] Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising Sprint Zapp, Fundraising-Backlog, FR-Adyen: Adyen: retest internally with real credit cards - https://phabricator.wikimedia.org/T118293#1867897 (Ejegg) [00:13:09] Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, FR-Adyen: Configure new Adyen account - https://phabricator.wikimedia.org/T119442#1867895 (Ejegg) Open>Resolved [00:14:59] Fundraising-Backlog, Epic: [epic] Adyen campaign ready - https://phabricator.wikimedia.org/T118202#1867909 (cwdent) [00:21:26] Fundraising Sprint Zapp, Fundraising-Backlog: Impressions are looking weird for mobile campaign - https://phabricator.wikimedia.org/T121042#1867922 (atgo) NEW [00:21:59] hey team (esp AndyRussG): ^ [00:30:16] AndyRussG: k4 has an idea - maybe the bannesr are loading after the reader has scrolled passed the top of the screen [00:30:28] are you able to investigate? or anyone? [00:31:37] awight ejegg xenoryet cwd: https://phabricator.wikimedia.org/T121042 [00:32:08] hmm [00:32:15] yeah...that sounds complicated [00:33:10] i wouldn't really know where to begin [00:33:11] Fundraising Sprint Zapp, Fundraising-Backlog: Impressions are looking weird for mobile campaign - https://phabricator.wikimedia.org/T121042#1867980 (ellery) I'm happy to go over the data I cited in the email with anyone involved. [00:33:45] hmm, hard to verify things are working with the campaign down! [00:34:54] Fundraising Sprint Zapp, Fundraising-Backlog: Impressions are looking weird for mobile campaign - https://phabricator.wikimedia.org/T121042#1867986 (atgo) [00:35:28] (PS1) Cdentinger: add state dropdown to mustache form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/258075 [00:40:29] thanks for the CR cwd ! [00:40:33] ejegg: there's an irritating little css thing in that you might know more about than i do ^ [00:40:56] ejegg: np! it's sort of cursory but since this won't break payments i hope that's ok [00:41:00] gotta head out, but I'll take a look when I'm back at the computer! [00:51:23] (CR) Awight: [C: -1] "Can you do something to switch on country?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/258075 (owner: Cdentinger) [00:51:59] K I just saw the baner impression thing... I'll check it out a bit later [00:52:17] (PS1) Awight: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/258079 [00:52:25] (CR) Awight: [C: 2] Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/258079 (owner: Awight) [00:52:42] (CR) Awight: [V: 2] Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/258079 (owner: Awight) [00:55:34] !log update fundraising CRM from 49e949c303466db9f96cb38b718190c887f7ed89 to fa7124e1d8d92b576c7650030fe64d024c822088 [00:55:40] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [00:56:39] (PS1) Cdentinger: fiddle with iframe container/content height [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/258080 [00:57:52] Fundraising Sprint Yo La Tengo, Fundraising Sprint Zapp, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Create a state dropdown for Mustache forms - https://phabricator.wikimedia.org/T119585#1868035 (cwdent) a:cwdent [00:59:15] (PS2) Cdentinger: fiddle with iframe container/content height [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/258080 (https://phabricator.wikimedia.org/T119585) [00:59:47] derp, wrong patch [01:00:04] (PS3) Cdentinger: fiddle with iframe container/content height [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/258080 [01:07:54] Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising Sprint Zapp, Fundraising Tech Backlog, and 4 others: Documentation for civicrm, drupal and pgehres MYSQL Tables - https://phabricator.wikimedia.org/T119481#1868110 (awight) Open>Resolved [01:14:36] awight: seems like all the gateways have "name" as a required field but i can't find where that's set as a default, do you know off hand? [01:18:30] Fundraising Sprint Zapp, Fundraising-Backlog: Advise BPay donors not to reuse reference #s - https://phabricator.wikimedia.org/T119912#1868162 (MBeat33) Suggested copy: Please note, BPay is not available as a recurring option. Each Reference # is only valid for one donation. [01:23:03] Fundraising Sprint Zapp, Fundraising-Backlog: Advise BPay donors not to reuse reference #s - https://phabricator.wikimedia.org/T119912#1868183 (CCogdill_WMF) > Suggested copy: Please note, BPay is not available as a recurring option. Each Reference # is only valid for one donation. Instead of "Each Refer... [01:28:48] Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Can we get the staging (CiviCRM & Drupal) DB updated from live? - https://phabricator.wikimedia.org/T119748#1868231 (Eileenmcnaughton) [03:20:21] (PS1) Cdentinger: WIP mustache l10n [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/258099 [05:18:02] (PS3) Ejegg: Oozie/Hive scripts to get email tracking data [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/258058 (https://phabricator.wikimedia.org/T114010) [05:43:10] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/258107 [05:48:08] (PS2) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/258107 [05:48:26] (CR) Ejegg: [C: 2 V: 2] Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/258107 (owner: Ejegg) [05:51:52] !log updated fundraising dashdoard from 9f0a4d98586f1281716e39b34d924de524458177 to 34dee88d137aa1d0c4487a3a94b87e7ed2f8d0c4 [05:51:57] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [06:00:00] Fundraising Dash, Fundraising Sprint Yo La Tengo, Fundraising Sprint Zapp, Fundraising-Backlog, and 2 others: Add a favicon to the Dash - https://phabricator.wikimedia.org/T120979#1868540 (Ejegg) [06:00:45] Fundraising Dash, Fundraising Sprint Yo La Tengo, Fundraising Sprint Zapp, Fundraising-Backlog, and 2 others: Add a favicon to the Dash - https://phabricator.wikimedia.org/T120979#1868542 (Ejegg) Open>Resolved [06:03:47] Fundraising Dash, Fundraising Sprint Yo La Tengo, Fundraising Sprint Zapp, Fundraising-Backlog, and 2 others: Fraud gauge widget is over-reporting fraud rates. - https://phabricator.wikimedia.org/T120169#1868545 (Ejegg) Open>Resolved [07:34:01] Fundraising Sprint Zapp, Fundraising-Backlog: Civi exports timing out - https://phabricator.wikimedia.org/T120892#1868578 (Eileenmcnaughton) I've been trying to replicate this on staging and it seems inconsistent. I made some changes that improved the speed a bit - at the extreme I did a search that found... [14:53:46] (CR) Ottomata: "Looks good to me, just a minor nit." (1 comment) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/258058 (https://phabricator.wikimedia.org/T114010) (owner: Ejegg) [16:17:25] Fundraising Sprint Zapp, Fundraising-Backlog: Advise BPay donors not to reuse reference #s - https://phabricator.wikimedia.org/T119912#1869634 (atgo) I like @ccogdill_wmf's suggestion since donors may not know what "recurring" is the same way that we do. [17:01:50] Hi the-wub! Thanks for putting up the test campaign :) I'm now going through data Ellery sent with a slightly clearer brain than last night... Pls LMK if u see anything odd! [17:03:13] the-wub: I was gonna start by looking at unexpected JS interactions, especially somehow banners hidden being recorded as shown. I'll hopefully more ideas once I more fully understand the data... [17:21:38] Fundraising Sprint Zapp, Fundraising-Backlog: Advise BPay donors not to reuse reference #s - https://phabricator.wikimedia.org/T119912#1869864 (MBeat33) good point, that works! [17:22:33] (CR) Ejegg: "Thanks Ottomata! I'm sure I'll need the readme if this ever needs revisiting a few months down the line." (1 comment) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/258058 (https://phabricator.wikimedia.org/T114010) (owner: Ejegg) [17:30:59] Fundraising Sprint Zapp, Fundraising-Backlog: Advise BPay donors not to reuse reference #s - https://phabricator.wikimedia.org/T119912#1869884 (atgo) So just the 1 sentence? [17:37:48] hey AndyRussG were you able to connect with ellery? [17:38:14] atgomez: nope... But morning + coffee = understanding the data better [17:38:29] atgomez: also I haven't reached out to him other than the e-mail to fr-tech [17:38:40] great, please let me know if i can help. this is top top priority [17:40:33] atgomez: yep! Sorry I couldn't get to it more last night [17:40:56] (I did try... ;p) [17:41:34] no worries [17:42:27] awight knows some stuff, too, from talking to ellery last night [17:43:54] atgomez: ah great :) [17:45:00] apparently impressions are half of pageviews [17:45:03] L| [17:45:06] :| [17:46:46] Fundraising Dash, Fundraising-Backlog: pageview vs. impressions widget - https://phabricator.wikimedia.org/T121121#1869922 (atgo) NEW [17:52:37] atgomez: yeah sounds bad [17:52:50] atgomez: so the mobile campaign is back up? [18:16:09] Fundraising Sprint Zapp, Fundraising-Backlog, Patch-For-Review: Deploy thank you letter to update postal address - https://phabricator.wikimedia.org/T120877#1870095 (Pcoombe) Open>Resolved a:Pcoombe Thanks! [18:28:06] ejegg|away: if you have time to look this over that'd be awesome: https://gerrit.wikimedia.org/r/#/c/258099/1 [18:28:17] adam wanted the dropdown to be country specific: https://gerrit.wikimedia.org/r/#/c/258075/1 [18:28:35] which sort of spiders out into general l10n for the mustache forms [18:29:07] and i don't think it's a good idea to half ass it [18:31:27] cwd: huh, ok [18:32:52] but yeah it sort of implies a lot of code to get written and FR seems to be chomping at the bit for this [18:38:21] cwd: we still need it for AU as well, I think [18:38:29] but I guess that can be a later commit [18:38:54] setting up for GB will require a bunch of different stuff too [18:39:06] if we're going to make it look like the GC form [18:39:10] totally different [18:39:38] also i don't think we can process refunds [18:41:24] i feel like there is a disconnect between FR and tech regarding the priority of this [18:41:33] cwd ejegg that sounds right [18:41:37] so, here's the deal. [18:41:48] the idea is to have this as a backup [18:42:01] right now, we don't have that for the campaign. we've missed the biggest window, but it'd still be good. [18:42:19] also, we won't be able to test this at all in these countries for january-march probably, because we like to give them a rest after the campaign [18:42:43] i'm fine to leave the state as a text entry until we're able to get to it [18:42:54] it's fine if it's not a perfect a/b test - our first goal is backup processing [18:43:19] yeah, i think it can be used for that in the US right now, though i need to look into this refunds thing [18:43:47] refunds thing? [18:43:57] just saw 2 failmails [18:44:02] PPena said she tried a refund [18:44:07] my guess is there's nothing in place for that [18:44:20] oh got it [18:44:21] cwd: maybe there is for the audit, just not the IPN notifications? [18:44:26] you mean on our side to account? [18:44:32] on our side [18:44:46] ejegg: yeah that could be [18:45:00] cwd just looked, and nope [18:45:23] only thing we do with the audit is capture authorized-but-not-captured charges [18:45:59] so... i definitely missed that as a 'campaign ready' task [18:46:14] good on PPena for testing it! [18:46:32] there are a lot of moving pieces [18:46:43] i definitely would not have thought of that [18:46:47] and didn't [18:47:15] Heh, when I first looked at this, I thought we had been using it full-on at some point and were just spinning it back up [18:47:15] ejegg cwd we're not at campaign ready - we're looking at 1 hour test [18:47:42] atgomez: ah, cool. I should still file something blocking campaign-ready for the refunds [18:47:54] thanks, that would be great to be organized in the milestones :) [18:48:40] happy to build out the refund mechanics, another new area for me [18:49:07] let's aim for solid 1-hour test and defer the rest into blocking tasks for the campaign [18:49:15] or in this case "backup ready" [18:49:51] can we do a 1hr test without refund capability? [18:50:10] Fundraising-Backlog, FR-Adyen, FR-Smashpig: Process refunds in Adyen audit file - https://phabricator.wikimedia.org/T121129#1870262 (Ejegg) NEW [18:50:31] cwd - we can refund, right? we just don't know about it? [18:50:34] or… we can't even refund? [18:51:01] i guess we probably can...is it done through the account dashboard? [18:51:23] so we probably just don't do anything with the message, i see now [18:51:34] that would be my guess [18:52:01] MBeat PPena - to confirm, the refunds you tried with adyen were through their console, right? [18:52:10] ejegg: should we teach the listener to do that, or just the audit parser? [18:52:31] Fundraising-Backlog, FR-Adyen, FR-Smashpig: Don't send failmail on Adyen refund notifications - https://phabricator.wikimedia.org/T121131#1870285 (Ejegg) NEW [18:52:51] cwd: I was thinking just shut the listener up, and let the audit parser do the recording [18:53:07] well, I guess it depends what we need to do [18:53:26] If it's just a matter of queueing a message, we can do that during the processAccountingReportJob [18:54:11] if it means we have to do some API communication to figure out the original donation data, then it should be its own kind of Job, and could be queued from either audit or IPN message [18:54:37] and that depends on what info they send in the ipn message? [18:54:46] or in the audit file [18:54:56] gotcha [18:54:58] I guess we'll have an example of the audit file tonight. [18:56:20] ehh, didn't need to split it out like that, just thought the failmail thing would be good to solve b4 the 1 hr test, and the other one could wait till campaign ready [18:56:55] Fundraising-Backlog, Epic: [epic] Adyen campaign ready - https://phabricator.wikimedia.org/T118202#1870325 (Ejegg) [18:56:56] Fundraising-Backlog, FR-Adyen, FR-Smashpig: Process refunds in Adyen audit file - https://phabricator.wikimedia.org/T121129#1870326 (Ejegg) [18:58:05] so ejegg cwd refunds will not be in civi, right/ [18:58:07] ? [18:58:13] just want to summarize for the rest of the team [18:58:28] i think for gc they come in the audit. [18:58:45] atgomez yes! problems? [18:58:56] no… no problems [18:59:11] just a question [18:59:22] atgomez saw someone said it didnt work on the other chat window...:) [18:59:39] what didn't work? [19:00:11] atgomez: they're not getting into Civi now, but after https://phabricator.wikimedia.org/T121129 is done they will! [19:00:25] ok, thanks [19:18:34] AndyRussG: ohai [19:18:41] Do you happen to have an Etherpad open? [19:18:42] awight: hey ho! [19:18:49] awight: ah no, good idea [19:19:06] https://etherpad.wikimedia.org/p/FR_unsolved_mysteries [19:19:33] I'm pasting in as-is the e-mail I'm drafting, part is just notes [19:20:06] :D [19:27:42] meganhernandez: Feel free to reenable Impression Diet, we should have enuf data now. [19:30:47] ah ok, thanks awight just enabled impression diet [19:30:54] Thank you! [19:31:20] meganhernandez: You probably don't want to watch, but here's our scratchpad for the day: https://etherpad.wikimedia.org/p/FR_unsolved_mysteries [19:31:42] meganhernandez: Do you know where we can go to get all of ewulczyn's work? [19:34:28] should we get mobile back up? with or without diet to get data there? [19:35:12] let’s ask ellery, he can check in at noon [19:35:22] meganhernandez: I think ellery agrees we should put it back up. [19:35:46] My only question for you, is if (in the worst case) you're okay with resetting the cookie so that everyone on mobile gets the full-screen banner again. [19:36:16] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, Unplanned-Sprint-Work, FR-GlobalCollect, and 2 others: Duplicate Order ID detection is broken for GlobalCollect - https://phabricator.wikimedia.org/T120805#1870443 (MBeat33) I checked GC600s from Tuesday after @awight's fix, and didn't see anythi... [19:36:45] AndyRussG: I found this, https://github.com/ewulczyn/wmf [19:36:51] now to find his data... [19:36:58] Hmmm [19:37:08] cool! [19:37:20] nvm, I'm gonna wait for him to tell us where the data is. [19:37:56] we should get mobile back up? with or without diet? with or without banner history? [19:38:52] i’d like to not give people a second big banner. but if we need to, i’d rather do it earlier before too many more peolpe see banners [19:39:06] meganhernandez: I suggest putting it back up, with impression diet and banner history. [19:39:22] The chance that the fullscreen thing is firing incorrectly seems pretty remote. [19:42:18] meganhernandez: what awight said sounds great :) [19:42:59] ok mobile and ipad campaigns are back up, with the same settings as yesterday. banner history and diet enabled [19:47:15] awight: we're no longer getting the "banner_count" param on S:RI, which could have server for debugging [19:47:23] We could still add it in [19:47:36] Meh actually forget it, it's not reliable this year [19:48:11] awight: check out my rundown on Ellery's doc in the == Notes on e-mail attachment from Ellery == section of the etherpad [19:49:28] meganhernandez awight AndyRussG do you think you still want the checkin at noon? sounds like we're covering some ground her ein irc [19:49:35] AndyRussG: Thank you for that. I agree, honestly most of the issues seemed like nonsense that came out of apples + oranges year-over-year comparisons. [19:50:01] I think year-on-year is an interesting debugging tool, but we have to be much more careful interpreting things like "down" and "up". [19:50:17] For diagnostics, all I care about are ratios between parts of the pipeline. [19:51:01] I'm currently pulling pageviews from Hive [19:51:14] It's gonna take me a few minutes to figure out how to add all the correct restrictions. [19:51:47] Do you agree it's just, * anonymous user * uselang=en * enwiki * Non-Special [19:52:10] atgomez: I would like access to ellery, still [19:52:24] Fine if he eats over the camera ;) [19:52:31] hehe ok [19:53:05] Sorry to fuss about the agenda, I was mostly mad at myself for rolling into the orfice at noon. [19:55:37] awight: i grabbed 62 if you want a room for this [19:55:42] nobody else is in the office [19:56:55] awight: I would say, try only main namespace [19:56:58] Fundraising Sprint Zapp, Fundraising-Backlog: mobile donation form: expiration date error - https://phabricator.wikimedia.org/T120053#1870496 (MBeat33) 185899 got the expiration date error; I'm following up with them for specs & will add them if they reply. [19:57:01] https://i.imgur.com/Zphm6SL.gifv [19:57:45] awight: avoid the first day of the campaign [19:57:52] (if you're looking at desktop) [20:37:00] Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising Sprint Zapp, and 2 others: Track email clickthroughs on donate wiki - https://phabricator.wikimedia.org/T114010#1870637 (Ejegg) Hi @CCogdill_WMF, here are some stats from the first links w... [20:57:19] Is it illegal to alternate between bites of sun-dried olives and peanut butter sandwich? [20:57:34] At least I have some water :) [20:59:34] hehe, taking the second lunch shift, I see... [21:00:23] Third, actually [21:00:42] K I'm gonna just finish the olives first [21:01:07] hey AndyRussG awight ejegg|vps cwd XenoRyet [21:01:14] atgomez: hi! [21:01:15] IRC standup? [21:01:26] I'm game [21:01:28] fine with me [21:01:31] Sure [21:01:31] awight and i assume AndyRussG are deep in figuring out this impressions thing - don't want to break the focus :) [21:01:35] sure, works for me! [21:01:42] awesome, thanks. [21:01:42] Yea, makes sense. [21:01:49] dstrine: i think you're out today, but FYI ^ [21:02:10] I had some good BS, but I can save it for tomorrow ;-) [21:02:19] K4-713: FYI ^ [21:02:47] Yeah, I kinda assumed that would be the case. [21:03:12] XenoRyet: cool, thx! [21:03:47] there are a ton of new adyen issues and i'm not really sure where to focus. i started looking into the audit parser for taking care of refunds. [21:04:42] cwd sounds like maybe the look n feel is important to do a comparison [21:04:52] so I'll review that dropdown in a sec [21:04:52] ejegg: does smashpig do the download for adyen? [21:05:07] cwd yeah, it's the ProcessAccountingReportJob [21:05:10] ejegg: ok cool...like i say that spiders out into a lot of other stuff [21:05:20] cool, yeah i just saw no adyen in wmf_audit and was like wait a minute [21:05:33] I'm still working on https://phabricator.wikimedia.org/T120255, but making good progress and should have something pushed for review soon. [21:05:46] right, but I think a US-only one is cool for now if that's the only place they're doing an hr test [21:06:18] cool, yeah we should have a conversation about how to do the special display casing in mustache. [21:06:24] if we do it wrong now we'll pay for it forever [21:07:28] heh, right. I think the _required flags are ok, but maybe add the state list and label to the context data [21:07:43] for now just note that in a TODO though [21:08:30] yeah, if you check out that other patch i was breaking out the context more, i think it's a good approach generally but could be organized better [21:08:51] cool [21:09:50] My update: gave ccogdill some CSVs with email tracking data, am working on sync scripts to get the data off stat1002 and onto a labs instance where I can make them available to FR-not-tech [21:10:12] reviewing Adyen stuff with cwd [21:10:31] and trying to get some idea of what's going on with impressions, but mostly just a spectator there [21:11:00] cwd let's talk about adyen prioritization [21:11:22] Fundraising Sprint Zapp, Fundraising-Backlog: Advise BPay donors not to reuse reference #s - https://phabricator.wikimedia.org/T119912#1870742 (jrobell) Thank you guys. How about merging Caitlin's and Michael's ideas into one: "Each Reference # is only valid once. Please do not reuse this reference numb... [21:11:34] also: plz review dash patches! https://gerrit.wikimedia.org/r/257677 https://gerrit.wikimedia.org/r/257078 https://gerrit.wikimedia.org/r/257079 https://gerrit.wikimedia.org/r/257202 https://gerrit.wikimedia.org/r/257203 [21:11:56] atgomez: all ears [21:12:01] ejegg: will do! [21:12:08] heh, thanks! [21:12:22] Fundraising Sprint Zapp, Fundraising-Backlog: Advise BPay donors not to reuse reference #s - https://phabricator.wikimedia.org/T119912#1870744 (atgo) Thanks @jrobell. I'm adding this to the task description. We won't get to this today, so if you have further tweaks please update here. [21:12:33] Fundraising Sprint Zapp, Fundraising-Backlog: Advise BPay donors not to reuse reference #s - https://phabricator.wikimedia.org/T119912#1870745 (atgo) [21:17:10] (Abandoned) Ejegg: WIP: Demonstrate base template [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/193395 (owner: Ejegg) [21:17:45] Fundraising Sprint Zapp, Fundraising-Backlog: Advise BPay donors not to reuse reference #s - https://phabricator.wikimedia.org/T119912#1870757 (jrobell) thanks. @atgo. @CCogdill_WMF and @MBeat33 and @Ppena, does that make sense to you? [21:18:33] Fundraising Sprint Zapp, Fundraising-Backlog: Advise BPay donors not to reuse reference #s - https://phabricator.wikimedia.org/T119912#1870758 (CCogdill_WMF) Fine with me. [21:20:19] Fundraising Sprint Zapp, Fundraising-Backlog: Advise BPay donors not to reuse reference #s - https://phabricator.wikimedia.org/T119912#1870767 (MBeat33) Yes, that's great, thx [21:24:42] awight: where are you going to pull ur pageview data from? [21:24:52] https://phabricator.wikimedia.org/P2403 [21:24:55] It's not working, yet. [21:27:38] Fundraising-Backlog: CIVI reports not reconciling - https://phabricator.wikimedia.org/T121154#1870803 (Ppena) NEW [21:31:09] Fundraising Sprint Zapp, Fundraising-Backlog: Advise BPay donors not to reuse reference #s - https://phabricator.wikimedia.org/T119912#1870818 (Ppena) sounds good! [21:36:57] awight: hmmm should I try too? What's not working? [21:39:20] awight: country seems to be full name [21:39:38] awight: try country_code [21:40:44] ejegg: Yes, thanks! [21:40:50] awight: ah, I see madhuvisy beat me to it! [21:40:54] I have a number now, 4.2M pageviews [21:40:59] cool [21:42:32] awight: \o/ [21:43:21] awight: did you get the 'like' part working? What if you just exclude everything with a ':'? [21:44:47] I'd like to match what our banners do, which is only excluding Special: afaik [21:44:58] thx for the reminder though--no I haven't uncommented that line yet. [21:45:17] Cool! There is a change history on these pastes [21:47:07] awight: no, banners now exclude all non-article namespaces [21:47:40] That should be correctly counted on the date you chose [21:48:01] Dec 7? [21:48:25] filtering Special: dropped .6M pageviews so far [21:48:33] Dec 4 [21:48:36] ^ that one [21:48:54] awight: yeah I think that should be fine [21:49:10] I guess this is the-wub code that was excluding non-main namespaces? I think that was only Talk:, eh? [21:49:21] I need to figure out when he added that to the banners. the-wub: awake? [21:49:34] ("figure out" = flail wildly) [21:53:53] AndyRussG: if ( mw.config.get('wgNamespaceNumber') > 0 && !mw.config.get('wgIsMainPage') ) { [21:53:53] awight: that was added on Nov 24 (to fix https://phabricator.wikimedia.org/T119400) [21:53:55] you're right [21:53:57] the-wub: Thanks! [21:54:26] awight: then we made a fix so the reason was given correctly on Dec 4: https://phabricator.wikimedia.org/T120338 [21:54:36] awight: yeah that's been live the whole campaign, correctly counted ^ [21:55:28] (PS5) Cdentinger: WIP test data [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257037 (owner: Ejegg) [21:58:54] ejegg: would you rather i make a different patch for that rather than amending yours? ^ [21:59:19] awight: for that period, from Hive I get 45280 banner history logs sent to us [21:59:25] cwd got more test data to add? [21:59:42] I can un-WIP that if you want to merge and follow up [22:00:14] ah, thanks for the typo fix! [22:00:18] AndyRussG: I pasted that to the etherpad [22:00:59] ejegg: np! so what about civicrm_contribution? should those get inserted by the json file? [22:01:02] drush qc? [22:01:06] cwd yup! [22:01:20] that should get data into all the civi tables [22:01:33] but the contribution_tracking data should be inserted first [22:01:45] ah good, that's what i did [22:01:54] awight: those numbers add up fine [22:02:00] cause that's the first thing we persist on payments right? [22:02:05] CT? [22:02:34] AndyRussG: 45280 * 100? yeah, perfectly. [22:02:44] cwd yep! [22:02:55] groovy [22:02:59] * awight prepares to smoke and eat red herring [22:02:59] awight: I'm totally not worried about impressions on desktop [22:03:08] I'm... not quite there yet [22:03:16] working on hide impressions now... [22:03:36] ah K [22:03:54] Do you want me to drop the text file with all the banner events in your home directory somewhere? [22:04:16] mmm. Filesrv1? [22:04:16] Or otherwise send it? [22:04:25] awight: ah K. Yay! I have tht now [22:04:53] (PS6) Ejegg: Add some test data and instructions [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257037 [22:05:09] (PS7) Ejegg: Add some test data and instructions [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257037 [22:05:15] It's the full event log string w/ user agent and all [22:06:00] awight: is that still OK for a sub-folder of Fundraising on fileserv? [22:06:31] Fundraising/Tech/ maybe [22:06:45] yeah, privacy not an issue there [22:06:48] ejegg: imma try to pm you non-otr, no need to fire it up, but lmk if it's still base64 [22:07:05] AndyRussG: remind me how to see the sendBeacon request in a debugger? FF doesn't show it, but I remember that's a bug [22:07:12] (in FF) [22:07:16] awight: update ur FF [22:07:25] or use chrom(e/ium) [22:08:04] K goin' VPN [22:08:18] * AndyRussG silences Spotify [22:08:28] * awight braces for turbulence [22:12:10] Fundraising Sprint Yo La Tengo, Fundraising Sprint Zapp, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, and 3 others: Fix "Notice: Undefined index: next_time_24h in SpecialHideBanners.php" - https://phabricator.wikimedia.org/T120890#1870909 (Krinkle) About 50 entries per hour at Fundraising Sprint Yo La Tengo, Fundraising Sprint Zapp, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, and 3 others: Fix "Notice: Undefined index: next_time_24h in SpecialHideBanners.php" - https://phabricator.wikimedia.org/T120890#1870910 (Krinkle) [22:15:20] AndyRussG: https://phabricator.wikimedia.org/P2405 [22:16:47] The "show" count really should have been higher than pgehres.bannerimpressions [22:16:52] awight: kewl! [22:16:56] I mean hmm [22:18:21] awight: it's not that different [22:18:49] pgehres I think is no longer floating down the lossy UDP canal [22:19:04] *row, row, row your packets* [22:20:08] Well, by any measure it seems that we're accounting for (more than ;) 100% of pageviews. [22:20:44] The only issue is the thing you and Ellery pointed out two hours ago, that waitdate is killing us. [22:21:16] Did ellery send an email that I missed, btw? [22:21:27] nvm [22:23:36] AndyRussG: I'll send an email concluding this exciting edition of My Paranoia [22:23:43] want to review a draft? [22:24:16] awight: sure. But I'm worried still about mobile [22:24:37] I'd like to do the same thing for a day on which the mobile campaign was up, and filter for mobile devices, if possible [22:24:44] yah I can offer 3rd + 4th eyes on that, now [22:25:01] awight: kewl thanks! [22:25:48] awight: atgomez: dstrine: should we make a card for all this impressionnumberbowling? [22:26:02] (maybe there is one? /me checks) [22:26:25] Ah right https://phabricator.wikimedia.org/T121042 [22:27:25] AndyRussG: I just realized, when we turned off the Impression Diet campaign feature today, we would still have hidden banners for anyone with a hide cookie. [22:27:42] awight: yes that is correct [22:27:52] awight: but that's not what hides for waitdate [22:28:03] that's only close, donate and the new remind-me-later [22:29:42] sorry? [22:33:03] awight: if you disable impression diet, people whose banners are being hidden due to that feature do indeed start getting banners [22:33:11] Those aren't hide cookies, they're counting cookies [22:33:30] Only close-clickers and donors would get hidden [22:33:55] awight: btw I miscounted impressions from the BH log, I was including donations too :( woops [22:33:59] Lemme reparse that [22:36:33] awight: number is even better now [22:37:03] AndyRussG: Thank you, I see what you're saying about the hide cookie. So in theory, impressions should have soared by 2x during our test hour. [22:38:02] AndyRussG: Do you have access to the notebook Ellery shared during our call? [22:38:05] awight: on desktop? they should've gone up some. Not sure how much [22:38:15] awight: only what he pasted at the bottom of the etherpad [22:38:24] ooh great [22:45:18] awight: for mobile pageviews in the campaign, I'll use the same query that you did, but for mobile web access_method [22:45:26] (CR) Cdentinger: [C: 2] Add age of donations in payments_initial [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257754 (owner: Ejegg) [22:45:38] and use a time right at the mobile launch [22:45:50] AndyRussG: That should work. webrequest_source = 'mobile' [22:46:26] (for the webrequest table) [22:47:11] (CR) Cdentinger: [C: 2] "Data looks good!" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257037 (owner: Ejegg) [22:47:30] (Merged) jenkins-bot: Add age of donations in payments_initial [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257754 (owner: Ejegg) [22:48:43] (Merged) jenkins-bot: Add some test data and instructions [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257037 (owner: Ejegg) [22:56:59] ejegg: if you have time for an easy one, this might be good to get out before we test tomorrow: https://gerrit.wikimedia.org/r/#/c/258080/ [22:58:41] cwd for sure, just a sec while i chat in -analytics about the email stuff [22:59:04] no hurry! [22:59:09] thanks [23:00:53] AndyRussG awight|meeting how's things going with the impressions? [23:01:01] i'm reading backscroll… not totally sure i udnesrtand [23:01:06] atgomez: we confirmed that desktop impressions are fine [23:01:18] awesome. [23:01:21] and have been fine? [23:01:33] Well, we took a slice from 4 Dec [23:01:35] And that one was fine [23:01:59] I'm now using the same procedure on mobile post mobile-100% [23:03:58] hey the_wub, are you still around? [23:04:19] ccogdill: yeah [23:04:35] I have a couple questions about MG’s landing page [23:04:46] thanks AndyRussG i'll leave you to it :) [23:04:47] their email just went out - I noticed Amazon isn’t on there [23:05:10] atgomez: thanks we'lll send some updates pertty soon [23:05:26] also I noticed the link didn’t seem to inset a country parameter, so I’m wondering - does it geolocate? [23:05:49] we sent the same email to people in multiple countries/currencies, so I want to make sure the GB donors aren’t see $ amounts on the form [23:05:53] ^ the_wub [23:06:03] ccogdill: hmm... give me a second [23:07:15] ty! [23:08:44] I can update email urls after an email is sent, but only to those who haven’t opened it yet. So it’s kind of a race against the clock if we want to change it [23:09:29] I don't think we need to update the urls. something is going wrong though, there is a JS error. debugging now... [23:10:14] if you add country= parameters manually you can get the Amazon button (in US) and the other currencies [23:10:15] that’s good news! [23:10:31] right, but the country= isn’t in the email url currently [23:10:47] we don’t usually put that in our URLs, I’m used to it geolocating [23:11:11] exactly, and I think the JS error I found may be stopping the geolocation [23:12:20] ahhhh [23:20:38] ccogdill: darn. I fixed that JS error, but still no geolocation [23:20:44] (CR) Cdentinger: "If I try to group by any of the utm_ fields my browser up and dies. It might have something to do with the test data being more unique in" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257078 (https://phabricator.wikimedia.org/T86094) (owner: Ejegg) [23:20:50] okay... [23:20:52] ccogdill: can you give me the link that was sent in the email? [23:21:03] is there a way to modify the url so it geolocates? [23:21:04] yeah 1 sec [23:21:19] https://donate.wikimedia.org/w/index.php?title=Special:FundraiserLandingPage&appeal=Appeal-MGAnnual&form-countryspecific=Form-countryspecific-MGAnnual&utm_medium=MGAnnual&utm_source=MGAnnual_2015&utm_campaign=MGAnnual_2015 [23:23:27] (CR) Cdentinger: "Actually not medium (that one is cool!), just source and campaign." [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257078 (https://phabricator.wikimedia.org/T86094) (owner: Ejegg) [23:23:51] ccogdill: try https://donate.wikimedia.org/?appeal=Appeal-MGAnnual&form-countryspecific=Form-countryspecific-MGAnnual&utm_medium=MGAnnual&utm_source=MGAnnual_2015&utm_campaign=MGAnnual_2015 [23:24:04] not sure why that should make a difference, but it does [23:24:08] yeah that geolocated [23:24:13] okay so I will update this in the email [23:24:21] nothing we can do about the people who already opened it, right? [23:24:27] it already has a 20% open rate :( [23:24:28] sweet! [23:24:39] no, not much we can do about that sorry [23:24:58] hopefully most are in the US anyway [23:25:57] okay thanks [23:26:34] sorry for barking up the wrong tree for a while there :( [23:26:50] no problem, we fixed it as fast as we could [23:53:30] (CR) Cdentinger: "The text filters don't seem to work because the query is getting built with RLIKE and so the magical % expansion used with LIKE means some" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257202 (owner: Ejegg) [23:53:40] awight|meeting: it's easy already to clear all waitdate status. Just change the cookie name [23:54:02] (You'd also clear other counts, though) [23:54:21] Still 10 impressions is not that much [23:54:52] (CR) Ejegg: "yep, that'll be bad test data. I'll update the schema and regenerate the JSON. Also, maybe the backend should throw an error if there ar" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257078 (https://phabricator.wikimedia.org/T86094) (owner: Ejegg) [23:55:21] awight|meeting: also maybe also add that we confirmed via BH log numbers? [23:58:35] (CR) Ejegg: "ahh, thanks! Will fix the text filters in another patch" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/257202 (owner: Ejegg)