[00:11:31] Fundraising Sprint Zapp, Fundraising-Backlog, Traffic, Unplanned-Sprint-Work, operations: Firefox SPDY is buggy and is causing geoip lookup errors for IPv6 users - https://phabricator.wikimedia.org/T121922#1902801 (Ejegg) Some stats for a full day post-fallback-fix: 15,539,986 hits to geoiploo... [00:53:17] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CiviCRM upgrade: migrate custom fields to standard fields - https://phabricator.wikimedia.org/T122342#1902878 (awight) It's pretty much the same motivation as upstreaming code changes, but in this case we're removing custom complexity in favor of core s... [00:57:00] (PS1) Awight: Don't allow user_ip in GET params [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/260884 (https://phabricator.wikimedia.org/T122093) [00:57:02] (PS1) Awight: Fail validation and present error page for bad country [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/260885 (https://phabricator.wikimedia.org/T120727) [00:57:27] (CR) Awight: [C: 2] "CR+2'd in Phabricator" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/260884 (https://phabricator.wikimedia.org/T122093) (owner: Awight) [00:57:37] (CR) Awight: [C: 2] "CR+2'd in Phabricator" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/260885 (https://phabricator.wikimedia.org/T120727) (owner: Awight) [00:58:21] (CR) jenkins-bot: [V: -1] Fail validation and present error page for bad country [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/260885 (https://phabricator.wikimedia.org/T120727) (owner: Awight) [00:58:27] (Merged) jenkins-bot: Don't allow user_ip in GET params [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/260884 (https://phabricator.wikimedia.org/T122093) (owner: Awight) [00:59:29] goddamn [01:00:58] (PS1) Awight: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/260886 [01:02:03] (CR) Awight: [C: 2] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/260886 (owner: Awight) [01:03:14] (PS1) Awight: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/260887 [01:03:26] (CR) Awight: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/260887 (owner: Awight) [01:03:40] (CR) Awight: [V: 2] Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/260887 (owner: Awight) [01:05:23] !log update payments from bae4d02afd8cfe1f8b8617c2f74bb36e420d281d to a7785baa7b40b442ecf0b60d47572502d0759780 [01:05:29] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [01:40:54] Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising Sprint Zapp, Fundraising-Backlog, and 2 others: CiviCRM upgrade: Adapt refund processing & reporting to reflect changes since the upgrade. - https://phabricator.wikimedia.org/T116317#1902978 (Eileenmcnaughton) I have opened... [16:28:56] Fundraising Sprint Zapp, Fundraising-Backlog, Traffic, Unplanned-Sprint-Work, operations: Firefox SPDY is buggy and is causing geoip lookup errors for IPv6 users - https://phabricator.wikimedia.org/T121922#1903527 (faidon) Just to complete the numbers above: only 2 out of 743 1:1000 sampled req... [16:47:16] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: "The" issue: Contacts with dup records (with and without "The") - https://phabricator.wikimedia.org/T122264#1903530 (CaitVirtue) @atgo - good questions! Yes, both. 1st priority is a scan of org records to for dups and cleanup. 2nd is a rule for the f... [17:26:03] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: [Please rename me] UI Sillyness: The boxes don't fit in the other boxes the right way - https://phabricator.wikimedia.org/T117614#1903544 (DStrine) [17:26:51] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: [Please rename me] UI Sillyness: The boxes don't fit in the other boxes the right way - https://phabricator.wikimedia.org/T117614#1779761 (DStrine) @atgo I took the sprint "zapp" off this task a you had already moved it out of the current sprint column.... [18:09:49] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Seems that an import overwrote an existing contribution? - https://phabricator.wikimedia.org/T117632#1903571 (LeanneS) @awight Something similar happened with CID 11462532 and 434179. I manually entered in a donation for 11462532, and somehow an October... [18:55:39] Fundraising-Backlog: Civi should allow users to do email address changes that are communicated to Silverpop - https://phabricator.wikimedia.org/T122411#1903592 (CCogdill_WMF) NEW [18:57:50] Fundraising-Backlog: Civi should allow users to do email address changes that are communicated to Silverpop - https://phabricator.wikimedia.org/T122411#1903600 (CCogdill_WMF) [19:04:06] Anyone able to review https://gerrit.wikimedia.org/r/#/c/260738/ ? AndyRussG, do you mind if I try to deploy that today? [19:04:59] Just gonna... deploy CentralNotice and DonationInterface, can't see anything going wrong. [19:05:47] ;P [19:07:20] Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Don't include refunded donations in Silverpop export - https://phabricator.wikimedia.org/T117931#1903604 (CCogdill_WMF) @atgo this is probably in Low-Normal... [19:11:14] awight: hey! I can't deal do much with it today, I'm afraid. If someone else can CR and you're pretty sure about it, then yeah, I think it's fine! :) [19:13:04] awight: whyyyy [19:15:20] AndyRussG: ok, works for me! [19:16:53] cwd: ino. That was a parting gift of massively increased complexity... Did you see the dirty flags? gah. [19:41:41] yow, what an edifice [19:42:23] It sprouted virtually overnight, too. I just resigned myself to fate at that point. [19:46:20] Pumping a little duck scum as I wait for my unit tests to run... [19:51:23] awight: is this what's up for deploy? https://gerrit.wikimedia.org/r/#/c/260885/1 [19:51:50] cwd: Yeah, that's the one I'm trying to debug [19:52:09] cwd: There's also a CN patch which I feel is UBN [19:52:24] shoot, did this come up yesterday? does it have to do with the forms i deleted? [19:52:57] I don't think so--tests passed on the patch right before this one [19:53:28] I probably broke validation somehow, so it's good that CI closed the reactor door on me [19:54:50] well i have vagrant working locally so i might be able to help diagnose [19:56:51] That would be great! It's probably something related to the country validation, since I was stomping around in that part of the code. [20:05:42] awight: rugh, of course i don't have my gerrit key, but i should be able to pull change sets right? [20:06:15] you can add a new key to gerrit through the ui [20:07:09] If you wanna pull a patchset over https though, just copy the commands in the "checkout" tab [20:07:25] e.g. git fetch https://gerrit.wikimedia.org/r/mediawiki/extensions/DonationInterface refs/changes/85/260885/1 && git checkout FETCH_HEAD [20:08:54] I'm narrowing in on the problem--I force the country to be recalculated from IP at some point [20:18:47] (PS2) Awight: Fail validation and present error page for bad country [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/260885 (https://phabricator.wikimedia.org/T120727) [20:19:48] (CR) jenkins-bot: [V: -1] Fail validation and present error page for bad country [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/260885 (https://phabricator.wikimedia.org/T120727) (owner: Awight) [20:20:05] ^K triumphalism [20:20:27] it's an improvement anyway [20:21:37] (PS3) Awight: Fail validation and present error page for bad country [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/260885 (https://phabricator.wikimedia.org/T120727) [20:21:50] That should be the one. XenoRyet cwd ejegg ^ any blessings or curses appreciated [20:21:54] Fatal error: unknown class ApiFormatWddx in /vagrant/mediawiki-fr/tests/phpunit/includes/api/format/ApiFormatWddxTest.php on line 76 [20:22:00] <_< [20:22:06] awight: i'll check it out [20:22:27] cwd: u might need some composer update [20:22:32] (CR) jenkins-bot: [V: -1] Fail validation and present error page for bad country [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/260885 (https://phabricator.wikimedia.org/T120727) (owner: Awight) [20:23:54] uno mas! [20:24:39] (PS4) Awight: Fail validation and present error page for bad country [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/260885 (https://phabricator.wikimedia.org/T120727) [20:25:42] * awight licks the butter knife between surgeries [20:26:28] that was the one [20:26:42] * awight looks hella crazy at Jenkins [20:29:05] awight: https://gerrit.wikimedia.org/r/#/c/260885/4/gateway_common/DonationData.php [20:29:13] are you sure you don't want to check that static var before setting it? [20:29:53] I'm pretty certain that static initialization only happens once per run [20:30:24] http://php.net/manual/en/language.variables.scope.php#language.variables.scope.static [20:30:55] Mostly, I just want to collect as many FIXME's and XX's in one place as I can [20:33:14] awight: ah ha, that is new to me [20:38:15] nice trick [20:38:53] awight: well i'm happy kicking this if you're reasonably confident [20:39:04] the CN thing...i have no idea about [20:44:53] I'm confident enuf to at least give this DI patch a shot. [20:45:28] I do worry about the massive change to validation making it suddenly impossible to donate, not gonna lie about that [20:45:43] * cwd looks again [20:46:35] awight: ok so why was this TODO before? https://gerrit.wikimedia.org/r/#/c/260885/4/gateway_common/DataValidator.php [20:46:41] MBeat: Are you around for a couple of hours? I'm considering a medium-risk deploy, which might cause donation problems. [20:47:08] I have about one hour awight before I have to hop off [20:47:13] cwd: I wish I'd made a note of why... but my guess is that it was just too risky. [20:47:22] MBeat: ok, works for me! [20:47:33] I'll probably still do this, and watch Zendesk a bit. [20:47:42] keep me posted, will watch the front of the queue [20:48:14] awight: risky because someone might not have a valid country set? or because the method that checks is unreliable? [20:48:39] MBeat: What should change is that people who were not being geolocated are currently allowed to fill out their CC details, and only after submitting do they see a mysterious error. With this change, they will be blocked from beginning the donation flow, and will see an error page that points them to Ways To Give. [20:49:01] that sounds good [20:49:26] hopefully they select their country from WTG [20:49:29] The risk is that other people will fall into the same hole [20:49:30] yes [20:50:02] cwd: Risky cos there may be bugs that cause people to not have a country set for other reasons [20:51:10] hmmm yes, well they should show up in the logs [20:51:18] the logs that i of course can't get at right now [20:51:31] :) [20:52:25] this has seriously never happened before [20:52:37] i've had wifi go out on that thing but not wired [20:52:43] and the whole rig is on a ups [20:54:34] cwd you have your yubikey right? [20:54:40] (CR) Ejegg: "Good simplification, nice update to object cache access. Logic looks solid and works locally. Please update getMessageFieldsFromCache call" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/260738 (https://phabricator.wikimedia.org/T122251) (owner: Awight) [20:54:48] Jeff_Green: yep [20:55:28] cwd: generate a new keypair for fundraising, and post the public key on your user page in officewiki or collabwiki and I can get your access going [20:57:36] Jeff_Green: thanks, that'd be amazing. can just delete it next week? [20:58:07] sure [20:58:14] it's pretty easy to switch keys [21:01:23] Well lmk what you want to do with the DI patch! [21:01:53] Jeff_Green: https://office.wikimedia.org/wiki/User:CDentinger_%28WMF%29 [21:02:15] awight: Can you add a log message before that displayFailPage? [21:02:35] ejegg: sure, thanks! [21:03:27] maybe displayFailPage should have a mandatory logReason argument [21:03:44] (PS3) Awight: Fix Translate integration [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/260738 (https://phabricator.wikimedia.org/T122251) [21:03:55] (CR) Awight: "Thanks for grepping!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/260738 (https://phabricator.wikimedia.org/T122251) (owner: Awight) [21:05:10] (PS5) Awight: Fail validation and present error page for bad country [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/260885 (https://phabricator.wikimedia.org/T120727) [21:05:37] cwd propagating [21:11:30] cwd be done by now, give it a try? [21:11:53] (PS4) Ejegg: Fix Translate integration [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/260738 (https://phabricator.wikimedia.org/T122251) (owner: Awight) [21:12:26] Jeff_Green: is there an example ssh config around for the bastion host? [21:13:00] sec, I'll email one [21:14:37] sent [21:14:49] thank you! [21:14:57] no problem [21:16:15] (CR) Ejegg: [C: 2] Fix Translate integration [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/260738 (https://phabricator.wikimedia.org/T122251) (owner: Awight) [21:20:01] woot woot [21:21:56] youch, there's a lot of CentralNotice stuff in the wings... [21:22:21] AndyRussG: How do you feel about "KVStore: Wrap accesses to LocalStorage in try/catch blocks" ? Shall I cherry-pick over it, or deploy? [21:24:05] LOL, hosting provider I recently ran away from just sent me this amazing email: To make sure you don't loose any data, please do the follow: [21:24:08] 1. [21:24:08] 3. [21:24:08] 4. [21:24:11] 2. [21:24:54] That's like, the definition of "sketchy" [21:24:56] awight: try/catch patch seems very safe [21:25:19] I might as well, while I'm babysitting... [21:25:57] (PS1) Awight: Merge master into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/260944 [21:27:26] (CR) Awight: [C: 2] Merge master into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/260944 (owner: Awight) [21:31:30] awight: yeah pls do cherry-pick it! [21:31:38] also useful! [21:31:38] AndyRussG: around it? [21:31:40] thx!!!! [21:31:57] ah, ok I've merged, so it's included. lmk if that's wrong [21:31:57] awight: well, I haven't been actually merging master to wmf_deploy recently [21:32:27] awight: I haven't chekced what else may be going in from master... I think there's a git log command to check [21:32:40] here's the roster: https://gerrit.wikimedia.org/r/260944 [21:33:59] awight: K I haven't looket at all at "Improve output subtitle on Special:CentralNoticeBanners" or "'wikpedia' typo in API example", so I guess use your judgement re: any risks involved with those ones! :) [21:34:07] gotta run!! thanks!!! :) [21:34:10] sure, will do! [21:34:23] all of those look fine to me [21:36:50] cool thx ejegg awight :) [21:42:47] hopping off, awight - nothing unseemly in the ZD queue [21:45:25] ejegg: fyi, Thursday is Friday this week [21:45:38] so my hands are tied wrt this CentralNotice deploy... [21:46:05] oh, so it's postponed till Monday then? [21:47:09] sigh* [21:48:58] Fundraising Sprint Zapp, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-Translate, and 2 others: Translation tool showing zero translations in MessageGroupStats for CentralNotice banner - https://phabricator.wikimedia.org/T122251#1903692 (awight) @jalexander We have... [21:56:38] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, FR-Smashpig: Rename GlobalCollect to Ingenico - https://phabricator.wikimedia.org/T122420#1903734 (Ejegg) NEW [22:16:51] (Merged) jenkins-bot: Merge master into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/260944 (owner: Awight) [22:56:03] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, FR-Smashpig: Rename GlobalCollect to Ingenico - https://phabricator.wikimedia.org/T122420#1903804 (awight) I don't imagine there's any contractual stuff, because we don't surface their name in the UI. We'r... [22:57:04] fundraising-tech-ops, operations, ops-codfw: bellatrix hardware RAID predictive failure - https://phabricator.wikimedia.org/T122026#1903805 (RobH) p:Triage>High [23:02:31] have to run a quick errand, back soon, available on mobile [23:04:16] (CR) Awight: [C: 2] "I can buy that. campaign and link_id will be a bit inaccurate due to grouping, but that makes sense if you just want unique visitor count" [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/259622 (https://phabricator.wikimedia.org/T114010) (owner: Ejegg) [23:06:32] (CR) Awight: [C: 2] Replace donatewiki counts table with view [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/259623 (https://phabricator.wikimedia.org/T114010) (owner: Ejegg) [23:26:25] (CR) Awight: [V: 2] Fix key on donatewiki_unique [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/259622 (https://phabricator.wikimedia.org/T114010) (owner: Ejegg) [23:26:35] (CR) Awight: [V: 2] Replace donatewiki counts table with view [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/259623 (https://phabricator.wikimedia.org/T114010) (owner: Ejegg) [23:27:08] I'm out. [23:27:13] bye!