[01:33:47] (PS6) Eileen: CRM-17640 Update contribution api to do a sensible query when getcount is being invoked [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256241 (https://phabricator.wikimedia.org/T116317) [01:34:37] (PS7) Eileen: (patch already in 4.7) CRM-17640 Update contribution api to do a sensible query when getcount is being invoked [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256241 (https://phabricator.wikimedia.org/T116317) [01:35:00] (CR) jenkins-bot: [V: -1] (patch already in 4.7) CRM-17640 Update contribution api to do a sensible query when getcount is being invoked [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256241 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [01:38:52] (PS3) Eileen: (merged into 4.6.11) Backport FinancialTrxn api [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/261599 (https://phabricator.wikimedia.org/T116317) [01:44:31] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256241 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [01:46:34] (PS5) Eileen: (merged into 4.7) CRM-17627 Set transaction date correctly for refunds [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/257271 (https://phabricator.wikimedia.org/T116317) [01:48:49] (PS3) Eileen: (merged into 4.7) CRM-17700 allow contribution get to bypass permissions [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/258918 (https://phabricator.wikimedia.org/T121284) [01:50:46] (PS3) Eileen: (merged into 4.7) CRM-17751 add api support for setting the trxn_id for a refund [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/261600 (https://phabricator.wikimedia.org/T116317) [01:52:25] (CR) jenkins-bot: [V: -1] (merged into 4.7) CRM-17751 add api support for setting the trxn_id for a refund [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/261600 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [02:02:58] (CR) Eileen: "Depends on another for-CR commit but haven't managed to get that commit into dependency chain" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/261600 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [02:04:56] (PS3) Eileen: (merged into 4.6.11) Backport EntityFinancialTrxn api [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/261759 (https://phabricator.wikimedia.org/T116317) [03:30:28] Fundraising Sprint Zapp, Wikimedia-Fundraising-CiviCRM: Financial Transactions not visible for some transactions & possibly fee transactions are missing - https://phabricator.wikimedia.org/T122946#1917319 (Eileenmcnaughton) NEW a:Eileenmcnaughton [04:05:59] Fundraising Sprint Zapp, Wikimedia-Fundraising-CiviCRM: Add indexes to CiviCRM entity financial transaction table - https://phabricator.wikimedia.org/T122947#1917347 (Eileenmcnaughton) NEW a:Eileenmcnaughton [14:04:31] (PS1) Hashar: Pass jshint and add it to 'npm test' command [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/262703 (https://phabricator.wikimedia.org/T63599) [14:10:44] (PS1) Hashar: Add jsonlint to npm test command [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/262704 (https://phabricator.wikimedia.org/T63599) [15:05:44] (CR) Paladox: [C: 1] "I have looked and all code seems to be good." [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/262703 (https://phabricator.wikimedia.org/T63599) (owner: Hashar) [18:48:44] (CR) Alex Monk: "AndyRussG: ping" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/234831 (owner: Glaisher) [18:54:16] Krenair: thanks! [21:03:11] eileen: oh hey! [21:03:36] We just found a nice room to work in, r u interested in a conference line? [21:04:08] cool - yeah I'll do that! [21:07:39] awight: let me know how to join [21:17:40] eileen: https://codeclimate.com [21:17:48] Free signup [21:18:14] Dunno if you can see this: https://codeclimate.com/repos/568d6b5b59754f237f000c47/includes/Banner.php [21:20:09] I have to login first & I'm just reading through the org access part because I don't fully understand what it's saying about those yet & I have access tolots of orgs [21:20:36] I'll try to login and share screen on the room's computer [21:21:03] cool [22:18:39] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Convert PayPal interstitial form from RapidHTML to Mustache - https://phabricator.wikimedia.org/T123001#1918986 (Ejegg) NEW [22:19:25] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Convert GlobalCollect forms from RapidHTML to Mustache - https://phabricator.wikimedia.org/T123002#1918994 (Ejegg) NEW [22:40:18] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Convert GlobalCollect forms from RapidHTML to Mustache - https://phabricator.wikimedia.org/T123002#1919041 (Eileenmcnaughton) should this be linked to https://phabricator.wikimedia.org/T86248 (blocker to it?) [22:41:44] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Do not directly access $_SESSION superglobal in DonationInterface - https://phabricator.wikimedia.org/T123006#1919056 (cwdent) NEW [22:42:00] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Convert GlobalCollect forms from RapidHTML to Mustache - https://phabricator.wikimedia.org/T123002#1919063 (awight) [22:42:22] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Convert GlobalCollect forms from RapidHTML to Mustache - https://phabricator.wikimedia.org/T123002#1918994 (awight) [22:42:25] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Make the forms come from one template - https://phabricator.wikimedia.org/T86248#1919066 (awight) [22:42:39] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Convert PayPal interstitial form from RapidHTML to Mustache - https://phabricator.wikimedia.org/T123001#1919069 (awight) [22:42:42] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Make the forms come from one template - https://phabricator.wikimedia.org/T86248#964453 (awight) [22:43:11] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Convert GlobalCollect forms from RapidHTML to Mustache - https://phabricator.wikimedia.org/T123002#1918994 (awight) @eileenmcnaughton: Yes, thanks! [23:32:30] (PS1) Ejegg: Fix maintenance form display [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/262840 (https://phabricator.wikimedia.org/T86248) [23:33:30] (CR) jenkins-bot: [V: -1] Fix maintenance form display [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/262840 (https://phabricator.wikimedia.org/T86248) (owner: Ejegg) [23:38:24] (PS2) Ejegg: Fix maintenance form display [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/262840 (https://phabricator.wikimedia.org/T86248) [23:39:10] (CR) jenkins-bot: [V: -1] Fix maintenance form display [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/262840 (https://phabricator.wikimedia.org/T86248) (owner: Ejegg) [23:44:03] (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/262840 (https://phabricator.wikimedia.org/T86248) (owner: Ejegg)