[00:17:07] (CR) Paladox: [C: 1] Add jsonlint to npm test command [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/262704 (https://phabricator.wikimedia.org/T63599) (owner: Hashar) [01:54:06] (CR) Legoktm: [C: 2] Add jsonlint to npm test command [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/262704 (https://phabricator.wikimedia.org/T63599) (owner: Hashar) [01:55:59] (CR) Legoktm: [C: -1] "Repo needs a .jshintrc file..." [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/262703 (https://phabricator.wikimedia.org/T63599) (owner: Hashar) [02:09:10] (CR) Paladox: "Please could you re c+2." [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/262704 (https://phabricator.wikimedia.org/T63599) (owner: Hashar) [20:01:20] (PS7) Paladox: Replace package grunt-jscs-checker with grunt-jscs, Update packages, Add jsonlint test [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263235 [20:02:31] (CR) jenkins-bot: [V: -1] Replace package grunt-jscs-checker with grunt-jscs, Update packages, Add jsonlint test [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263235 (owner: Paladox) [20:03:26] (CR) Paladox: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/260885 (https://phabricator.wikimedia.org/T120727) (owner: Awight) [20:04:07] (CR) jenkins-bot: [V: -1] Fail validation and present error page for bad country [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/260885 (https://phabricator.wikimedia.org/T120727) (owner: Awight) [20:11:41] (CR) Paladox: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/260884 (https://phabricator.wikimedia.org/T122093) (owner: Awight) [20:11:59] (PS1) Paladox: Test: Do NOT MERGE [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263238 [20:12:42] (CR) jenkins-bot: [V: -1] Test: Do NOT MERGE [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263238 (owner: Paladox) [20:12:48] (PS8) Paladox: Replace package grunt-jscs-checker with grunt-jscs, Update packages, Add jsonlint test [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263235 [20:13:11] (Abandoned) Paladox: Test: Do NOT MERGE [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263238 (owner: Paladox) [20:13:47] (CR) jenkins-bot: [V: -1] Replace package grunt-jscs-checker with grunt-jscs, Update packages, Add jsonlint test [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263235 (owner: Paladox) [20:19:25] (CR) Paladox: [C: 1] "This can be merged." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263235 (owner: Paladox) [20:21:25] (PS2) Paladox: Pass jshint and add it to 'npm test' command [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/262703 (https://phabricator.wikimedia.org/T63599) (owner: Hashar) [20:29:45] (PS3) Paladox: Pass jshint and add it to 'npm test' command [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/262703 (https://phabricator.wikimedia.org/T63599) (owner: Hashar) [20:30:13] Wikimedia-Fundraising, Wikimedia-Site-Requests, Patch-For-Review: Clean up fundraising code (extra skins and allowed templates for foundationwiki) in CommonSettings.php - https://phabricator.wikimedia.org/T50493#1923597 (Luke081515) a:Krenair [23:18:49] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Advanced Search UI: this this is in the wrong place. - https://phabricator.wikimedia.org/T118610#1923706 (Eileenmcnaughton) Pretty sure this is a duplicate of T120332 - @caitvirtue - OK to close this in favour of R120332? [23:19:08] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: UI Annoyance: Move "Display Contacts As" back to the top of the Advanced Search - https://phabricator.wikimedia.org/T120332#1923707 (Eileenmcnaughton) a:Eileenmcnaughton [23:41:17] (PS1) Eileen: (merged into 4.7) Whitespace only. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/263309 [23:41:20] (PS1) Eileen: (proposed for 4.7) CRM-17439 layout changes for advanced search panes [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/263310 [23:51:17] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: UI Annoyance: Move "Display Contacts As" back to the top of the Advanced Search - https://phabricator.wikimedia.org/T120332#1923721 (Eileenmcnaughton) I've done a PR of proposed changes against upstream (4.7) and also put them on staging. Note it would... [23:52:29] (PS2) Eileen: (merged into 4.7) Whitespace only. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/263309 (https://phabricator.wikimedia.org/T120332) [23:52:31] (PS2) Eileen: (proposed for 4.7) CRM-17439 layout changes for advanced search panes [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/263310 (https://phabricator.wikimedia.org/T120332) [23:52:54] Fundraising Sprint Zapp, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: UI Annoyance: Move "Display Contacts As" back to the top of the Advanced Search - https://phabricator.wikimedia.org/T120332#1923725 (Eileenmcnaughton) [23:53:37] Fundraising Sprint Zapp, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: UI Annoyance: Move "Display Contacts As" back to the top of the Advanced Search - https://phabricator.wikimedia.org/T120332#1851253 (Eileenmcnaughton) I've also pulled this into the current sprint. Reason being there is a bri... [23:54:27] (CR) jenkins-bot: [V: -1] (proposed for 4.7) CRM-17439 layout changes for advanced search panes [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/263310 (https://phabricator.wikimedia.org/T120332) (owner: Eileen) [23:54:31] Fundraising Sprint Zapp, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: UI Annoyance: Move "Display Contacts As" back to the top of the Advanced Search - https://phabricator.wikimedia.org/T120332#1923727 (Eileenmcnaughton) (oh yeah - the other reason is that I wanted to get it sorted before 4.7 g... [23:55:49] (CR) Eileen: "patch is now on staging" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/261599 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [23:56:35] (CR) Eileen: "patch is now on staging" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/261759 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [23:57:36] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/263310 (https://phabricator.wikimedia.org/T120332) (owner: Eileen)