[00:03:16] (CR) Eileen: "Patch is now on staging" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256163 (https://phabricator.wikimedia.org/T116724) (owner: Eileen) [00:03:55] (CR) Eileen: "Patch is on staging" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256241 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [00:04:32] (CR) Eileen: "patch is on staging" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/257271 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [00:05:15] (CR) Eileen: "patch is on staging" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/258918 (https://phabricator.wikimedia.org/T121284) (owner: Eileen) [01:07:13] (PS1) Eileen: (merged into 4.7) CRM-17627 Set transaction date correctly for refunds [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/263313 (https://phabricator.wikimedia.org/T116317) [01:07:15] (PS1) Eileen: (merged into 4.7) CRM-17751 add api support for setting the trxn_id for a refund [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/263314 (https://phabricator.wikimedia.org/T116317) [01:07:45] (CR) jenkins-bot: [V: -1] (merged into 4.7) CRM-17627 Set transaction date correctly for refunds [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/263313 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [01:07:50] (Abandoned) Eileen: (merged into 4.7) CRM-17751 add api support for setting the trxn_id for a refund [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/261600 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [01:08:38] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/263313 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [01:17:42] (PS3) Eileen: CRM-17751 add refund trxn to forms [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/261601 (https://phabricator.wikimedia.org/T116317) [01:21:21] (CR) Eileen: "Patching going onto staging" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/261601 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [01:27:08] (CR) Eileen: "patch is now on staging" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/263310 (https://phabricator.wikimedia.org/T120332) (owner: Eileen) [10:47:02] (CR) Hashar: "This change depends on parent change https://gerrit.wikimedia.org/r/#/c/262703/ Zuul will get it merged whenever the parent is merged. Tho" [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/262704 (https://phabricator.wikimedia.org/T63599) (owner: Hashar) [14:47:50] (PS1) Florianschmidtwelzow: Follow up mediawiki/core change [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263351 (https://phabricator.wikimedia.org/T123202) [14:48:34] (CR) jenkins-bot: [V: -1] Follow up mediawiki/core change [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263351 (https://phabricator.wikimedia.org/T123202) (owner: Florianschmidtwelzow) [14:53:46] (PS2) Florianschmidtwelzow: Follow up mediawiki/core change [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263351 (https://phabricator.wikimedia.org/T123202) [14:54:24] (CR) jenkins-bot: [V: -1] Follow up mediawiki/core change [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263351 (https://phabricator.wikimedia.org/T123202) (owner: Florianschmidtwelzow) [15:02:06] (PS3) Florianschmidtwelzow: Follow up mediawiki/core change [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263351 (https://phabricator.wikimedia.org/T123202) [15:02:45] (CR) jenkins-bot: [V: -1] Follow up mediawiki/core change [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263351 (https://phabricator.wikimedia.org/T123202) (owner: Florianschmidtwelzow) [15:56:48] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Advanced Search UI: this this is in the wrong place. - https://phabricator.wikimedia.org/T118610#1924246 (CaitVirtue) @Eileenmcnaughton yes, totally. Thanks for catching that! [16:09:44] (CR) Ejegg: "Oof, looks like we should probably switch over to RequestContext calls in a lot of places to be consistent" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263351 (https://phabricator.wikimedia.org/T123202) (owner: Florianschmidtwelzow) [16:15:23] (CR) Paladox: "@Hashar could you merge this please since it is a really minor change to js that wont affect anyone. Actually it should fix the js since m" [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/262703 (https://phabricator.wikimedia.org/T63599) (owner: Hashar) [16:15:31] (CR) Paladox: [C: 1] Pass jshint and add it to 'npm test' command [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/262703 (https://phabricator.wikimedia.org/T63599) (owner: Hashar) [16:18:38] (PS1) Paladox: Test: DO NOT MERGE [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263359 [16:19:20] (CR) jenkins-bot: [V: -1] Test: DO NOT MERGE [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263359 (owner: Paladox) [16:20:59] (PS2) Paladox: Test: DO NOT MERGE [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263359 [16:22:13] (PS3) Paladox: Test: DO NOT MERGE [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263359 [16:23:01] (CR) jenkins-bot: [V: -1] Test: DO NOT MERGE [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263359 (owner: Paladox) [16:23:35] (CR) jenkins-bot: [V: -1] Test: DO NOT MERGE [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263359 (owner: Paladox) [16:32:38] Fundraising Sprint Zapp, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add indexes to CiviCRM entity financial transaction table - https://phabricator.wikimedia.org/T122947#1924312 (DStrine) [16:32:48] Fundraising Sprint Zapp, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Financial Transactions not visible for some transactions & possibly fee transactions are missing - https://phabricator.wikimedia.org/T122946#1924314 (DStrine) [16:36:45] (PS1) Ejegg: Wipe out $wgRequest [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263362 [16:38:42] (PS4) Paladox: Test: DO NOT MERGE [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263359 [16:38:55] (CR) Ejegg: "A recent core change made getRequest() not use $wgRequest, which breaks some tests. We should nuke the global everywhere to be consistent" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263359 (owner: Paladox) [16:39:39] (CR) jenkins-bot: [V: -1] Test: DO NOT MERGE [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263359 (owner: Paladox) [16:40:16] cwd: got some time for a straightforward (but not small) DI patch? Think we need to merge this before anything else will work: https://gerrit.wikimedia.org/r/#q,I671ca0641e622f6c4bac1dfa3fb17f9f3dd86f18,n,z [16:40:26] (CR) Paladox: [C: 1] "Thanks." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263362 (owner: Ejegg) [16:41:28] ejegg: sure, lemme take a look [16:41:31] (Abandoned) Paladox: Test: DO NOT MERGE [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263359 (owner: Paladox) [16:41:35] thanks! [16:41:52] (PS2) Paladox: Wipe out $wgRequest [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263362 (https://phabricator.wikimedia.org/T123202) (owner: Ejegg) [16:42:51] ah yeah, testing DI against master [16:44:21] one less global is nice though [16:44:30] cwd ooh right, let me run the tests against our branch too. Think it should still work. [16:45:08] i just was gonna try that but i am on a new computer and still setting stuff up [16:46:24] rather, i put everything on my laptop and decommissioned the home server [16:47:25] fundraising-tech-ops: monitor SSL cert expiration in frack - https://phabricator.wikimedia.org/T123144#1924371 (Jgreen) p:Normal>High [16:47:50] ah, right. [16:48:26] ejegg: tests look good against 1.25? if so i'd say this is fine [16:48:47] (PS1) Paladox: Test: DO NOT MERGE [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263368 [16:49:55] (CR) jenkins-bot: [V: -1] Test: DO NOT MERGE [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263368 (owner: Paladox) [16:50:16] (PS2) Paladox: Test: DO NOT MERGE [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263368 [16:51:31] (Abandoned) Paladox: Test: DO NOT MERGE [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263368 (owner: Paladox) [16:51:35] cwd yep, passes on 1.25. I'm just going to update the commit msg [16:52:15] ejegg: cool, only thing was a little trailing ws in DonationData [16:52:25] (PS3) Ejegg: Wipe out $wgRequest [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263362 (https://phabricator.wikimedia.org/T123202) [16:52:27] ... [16:52:32] Sprint Planning at 9am? [16:52:33] (CR) Paladox: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263235 (owner: Paladox) [16:52:48] i notice gerrit only highlights trailing ws in the right pane, even if it's present in both [16:53:27] K4-713: ouch, forgot about that [16:53:39] * cwd blows dust off headphones [16:53:44] * K4-713 tries not to employ the tone I can only achieve before 10am [16:54:30] oh woah, yah that's early. I should relocate to higher bandwidth [16:54:52] I like how everyone is basically guaranteed to have no idea what's going on yet. [16:55:10] Bah. [16:57:15] * cwd makes 4th cup of coffee [16:59:12] (PS1) Paladox: Add grunt-jsonlint and update packages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263371 [16:59:27] (CR) Florianschmidtwelzow: "I'm also not really happy about the massive usage of RequestContext::getMain() :/ A better solution would be to find a way to set the obje" (6 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263362 (https://phabricator.wikimedia.org/T123202) (owner: Ejegg) [16:59:39] (CR) Florianschmidtwelzow: [C: -1] "see comments PS2" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263362 (https://phabricator.wikimedia.org/T123202) (owner: Ejegg) [17:00:08] (CR) jenkins-bot: [V: -1] Add grunt-jsonlint and update packages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263371 (owner: Paladox) [17:00:25] (Abandoned) Florianschmidtwelzow: Follow up mediawiki/core change [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263351 (https://phabricator.wikimedia.org/T123202) (owner: Florianschmidtwelzow) [17:01:47] (PS2) Paladox: Add grunt-jsonlint and update packages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263371 [17:03:22] (CR) jenkins-bot: [V: -1] Add grunt-jsonlint and update packages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263371 (owner: Paladox) [17:12:07] Fundraising Sprint Zapp, Fundraising-Backlog, Unplanned-Sprint-Work: 1 million failmails (fill this out more when we know more) - https://phabricator.wikimedia.org/T122619#1924421 (DStrine) Please follow up with fr-all with results and reference to this: T108229 [17:14:16] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, FR-Smashpig: Rename GlobalCollect to Ingenico - https://phabricator.wikimedia.org/T122420#1924425 (atgo) p:Triage>High [17:28:04] Fundraising-Backlog: SPIKE: scope FRIG scope - https://phabricator.wikimedia.org/T123246#1924527 (cwdent) NEW a:cwdent [17:28:51] Fundraising Sprint Zapp, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface: Spike: Split out ActiveMQ replacement tasks for making code changes - https://phabricator.wikimedia.org/T123247#1924535 (awight) NEW [17:30:51] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, FR-Smashpig: [EPIC]Rename GlobalCollect to Ingenico - https://phabricator.wikimedia.org/T122420#1924553 (DStrine) [17:33:20] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, FR-Smashpig: Update all references to GlobalCollect in code, determine if we need to update old database entries - https://phabricator.wikimedia.org/T123249#1924572 (Ejegg) NEW [17:35:14] Fundraising-Backlog: Some Globalcollect donations not in Civi - https://phabricator.wikimedia.org/T122730#1924592 (cwdent) a:cwdent [17:35:33] Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, and 2 others: fix SmashPig job runner failure mode - https://phabricator.wikimedia.org/T117447#1924593 (DStrine) [17:36:15] Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising-Backlog, and 2 others: fix SmashPig job runner failure mode - https://phabricator.wikimedia.org/T117447#1774532 (DStrine) [17:38:58] hey Jeff_Green - anna stillwell is having trouble getting into civi [17:39:13] ok [17:39:21] she's also having trouble getting into phab [17:39:57] "could not find valid value for CID" Jeff_Green - is that you or fr-tech? [17:40:10] Fundraising Sprint Zapp, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: UI Annoyance: Move "Display Contacts As" back to the top of the Advanced Search - https://phabricator.wikimedia.org/T120332#1924606 (CaitVirtue) Haha, good to know that bribes move the queue. I checked it out on staging and... [17:40:30] atgomez: that's not an error I recognize, is that from civi or phabricator? [17:40:38] civi [17:41:28] does she get to the login page at all? [17:42:00] oh Jeff_Green she got it [17:42:12] seems to be making errors randomly [17:42:20] huh [17:47:06] atgomez: that CID error is from civicrm so probably fr-tech terrain, I don't see anything at a system level at the moment [18:02:46] Fundraising Sprint A 2016, Fundraising Sprint Zapp, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface: Spike: Split out ActiveMQ replacement tasks for making code changes - https://phabricator.wikimedia.org/T123247#1924719 (DStrine) [18:02:48] Fundraising Sprint A 2016, Fundraising-Backlog: SPIKE: scope FRIG scope - https://phabricator.wikimedia.org/T123246#1924720 (DStrine) [18:02:50] Fundraising Sprint A 2016, Fundraising Sprint Zapp, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add indexes to CiviCRM entity financial transaction table - https://phabricator.wikimedia.org/T122947#1924721 (DStrine) [18:02:52] Fundraising Sprint A 2016, Fundraising Sprint Zapp, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Financial Transactions not visible for some transactions & possibly fee transactions are missing - https://phabricator.wikimedia.org/T122946#1924722 (DStrine) [18:02:55] Fundraising Sprint A 2016, Fundraising Sprint Zapp, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Donors still don't know payments succeeded when queue is dead. - https://phabricator.wikimedia.org/T122627#1924724 (DStrine) [18:02:57] Fundraising Sprint A 2016, Fundraising-Backlog: Some Globalcollect donations not in Civi - https://phabricator.wikimedia.org/T122730#1924723 (DStrine) [18:03:06] Fundraising Sprint A 2016, Fundraising Sprint Zapp, Fundraising-Backlog: Spike: Is it a problem that the Silverpop export is still not updating entire database? - https://phabricator.wikimedia.org/T120880#1924739 (DStrine) [18:03:07] Fundraising Sprint A 2016, Fundraising Sprint Zapp, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: Impression and donation numbers are looking weird for mobile campaign - https://phabricator.wikimedia.org/T121042#1924737 (DStrine) [18:03:32] Fundraising Sprint A 2016, Fundraising Sprint Yo La Tengo, Fundraising Sprint Zapp, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: iframe not appearing for some people (confirmed modern browsers) - https://phabricator.wikimedia.org/T112181#1924760 (DStrine) [18:03:33] Fundraising Sprint A 2016, Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Sprint William Shatner, and 6 others: Edits to LYBUNT report - https://phabricator.wikimedia.org/T88819#1924763 (DStrine) [18:03:56] cwd, ejegg: Hurm. I would like to propose that we can today's checkins, mostly because I need to spend some time figuring out what's going on before I can usefully talk about it. [18:04:28] works for me K4-713 [18:04:42] yaaaay. [18:07:23] the untitled sprint "A" is here: https://phabricator.wikimedia.org/project/sprint/board/1697/ [18:07:45] we will vote on names at standup [18:07:57] Please move your tasks into the correct columns [18:09:04] K4-713: no problem, i'm just hooking up ye olde internet anyhow [18:09:26] cwd: That seems like a better use of your time anyway. [18:09:57] i will be sure to post speedtest screenshots to make everyone jealous [18:11:51] I'm thrilled about: https://lists.wikimedia.org/pipermail/teampractices/2016-January/000970.html [18:12:51] huh, neat [18:12:56] ooh cool [18:15:35] there's a forked project which delivers a small shock when you press the "enqueue" button... [18:17:14] I have an emergency yardfowl errand to run... should be back in 45 min. [18:18:40] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Advanced Search UI: this this is in the wrong place. - https://phabricator.wikimedia.org/T118610#1924828 (atgo) [18:18:42] Fundraising Sprint Zapp, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: UI Annoyance: Move "Display Contacts As" back to the top of the Advanced Search - https://phabricator.wikimedia.org/T120332#1924829 (atgo) [18:21:01] (PS4) Ejegg: Wipe out $wgRequest [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263362 (https://phabricator.wikimedia.org/T123202) [18:37:43] http://results.speedtest.comcast.net/result/1175942204.png [18:38:08] i can get gigabit to the isp...turns out the internet has a lot of bottlenecks well below that [18:45:33] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Minimize use of globals in DonationInterface - https://phabricator.wikimedia.org/T123267#1924911 (Ejegg) NEW a:Ejegg [18:47:08] dragging a task at the bottom of the backlog to another column in the current sprint: ridiculous [18:53:08] Fundraising Sprint A 2016, Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Sprint William Shatner, and 6 others: Edits to LYBUNT report - https://phabricator.wikimedia.org/T88819#1924956 (XenoRyet) @atgo @CaitVirtue Are we still meaning to do more review on this, or can we close... [19:07:10] (PS1) Ejegg: Zap more globals with fewer RequestContext::getMain calls [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263402 (https://phabricator.wikimedia.org/T123267) [19:07:46] (CR) jenkins-bot: [V: -1] Zap more globals with fewer RequestContext::getMain calls [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263402 (https://phabricator.wikimedia.org/T123267) (owner: Ejegg) [19:11:59] (CR) Ejegg: "Thanks for the CR, FlorianSW! I fixed the spaces in DonationData and created a follow-on patch (Ie40dd73b15908af6adb2f6e10032c1df845a0baf)" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263362 (https://phabricator.wikimedia.org/T123202) (owner: Ejegg) [19:14:37] (PS2) Ejegg: Zap more globals with fewer RequestContext::getMain calls [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263402 (https://phabricator.wikimedia.org/T123267) [19:18:54] (CR) Paladox: [C: 1] Wipe out $wgRequest [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263362 (https://phabricator.wikimedia.org/T123202) (owner: Ejegg) [19:28:00] Fundraising Sprint Zapp, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: UI Annoyance: Move "Display Contacts As" back to the top of the Advanced Search - https://phabricator.wikimedia.org/T120332#1925036 (MBeat33) The screenshots look good to me as well, and many thanks, Eileen [19:41:40] Fundraising Sprint Zapp, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: UI Annoyance: Move "Display Contacts As" back to the top of the Advanced Search - https://phabricator.wikimedia.org/T120332#1925055 (Eileenmcnaughton) I think you need to create an account on JIRA before you can post comments... [19:41:57] (CR) Hashar: "I do not have much faith in my JavaScript review skill and this extension is related to Wikimedia Fundraising, so I would prefer either a" [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/262703 (https://phabricator.wikimedia.org/T63599) (owner: Hashar) [19:44:07] (CR) Hashar: [C: 1] "+1 just to say that I would blindly trust whatever Florianschmidtwelzow says :-}" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263362 (https://phabricator.wikimedia.org/T123202) (owner: Ejegg) [19:45:51] Fundraising Sprint A 2016, Fundraising Sprint Zapp, Fundraising-Backlog: UI Annoyance: Move "Display Contacts As" back to the top of the Advanced Search - https://phabricator.wikimedia.org/T120332#1925069 (Eileenmcnaughton) [19:51:29] (CR) Paladox: "Ok." [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/262703 (https://phabricator.wikimedia.org/T63599) (owner: Hashar) [19:52:54] cwd: You want to brainstorm about Frig, at some point? [19:53:20] yeah i'd love to [19:53:59] One thing we could do is look at the Civi deployment scripts eileen wrote, and ponder how a more general framework would integrate with that... [19:54:04] awight: the stubs are here https://github.com/caseydentinger/frig [19:54:23] yeah, i mean we could consider using scap [19:54:37] it would be more invasive surgery [19:54:43] but might be worth it [19:54:49] it looks great! [19:54:58] i feel like the more code we can share with the rest of the org the better [19:55:24] re: scap, I think the actual deployment step can be left pluggable [19:56:12] yeah... the only thing i think we might benefit from is the symlink flipping [19:56:20] unless the rsync script already does that... [19:56:30] It does [19:56:38] well then...nm [19:57:04] urm. Actually, I think any symlinks we maintain are done via puppet [19:58:15] i heard chad saying they hope to have everyone on differential this year [19:58:16] sounds good to discuss the Civi scripts with it. There will be a lot of core team work going into the Civi side at the sprint at the end of the month so good to get our stuff incorporated there [19:58:29] It might be worthwhile to spell out all the smallish steps that happen during a deployment [19:58:54] ... I'll start an Etherpad and we can slowly trickle-charge [19:59:02] Unless cwd eileen has one already? [19:59:11] nope, fire it up [19:59:19] not yet [20:00:24] aww, title length limit [20:00:49] sux. https://etherpad.wikimedia.org/p/Frig_deployment_tool [20:08:14] eileen: we actually do sometimes need to delete the tests in donationinterface so that could be generalized from civi [20:08:49] (PS3) Ejegg: Fix maintenance form display [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/262840 (https://phabricator.wikimedia.org/T86248) [20:08:56] they sneak through the merge when changed on master, i did some research and do not believe there's a way to stop that from happening [20:09:01] cwd: yeah the problem is that there are a bunch of files & folders and CiviCRM doesn't maintain a list of the ones to be removed - only the ones to keep [20:09:43] cwd: agreed--I'm unindenting the line [20:09:43] eileen: dang that's a serious whitelist [20:09:51] cwd hence the business of running in a script & checking in the results [20:10:04] it's not so huge - ie. CRM folder is just one thing [20:10:09] eileen: sorry, I forget what repo your recent deployment scripts went to [20:10:11] aah, word [20:11:39] awight: this is the PR against core for adding a 'folder dist' https://github.com/civicrm/civicrm-core/pull/7035 [20:12:21] and this is the extra little script https://gerrit.wikimedia.org/r/#/c/252376/ [20:13:05] eileen: Thanks! [20:15:55] cwd: Am i right that you've been working on the frig-merge component, mostly? [20:16:15] That might be a useful initial division of labor to split out of the epic, at least... [20:16:36] awight: yeah, the other part i think being the gerrit work, which i'm now questioning the worth of [20:16:53] if we're going to move to phab, might just wait until it can be arc scripts [20:17:20] (CR) Ejegg: "Looks pretty good to me, though there are a couple trailing commas that you could zap." (1 comment) [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/262703 (https://phabricator.wikimedia.org/T63599) (owner: Hashar) [20:17:37] (CR) Eileen: "ohh look - 4 draft comments from ages ago...." (4 comments) [wikimedia/fundraising/civicrm-core] - https://gerrit.wikimedia.org/r/252376 (https://phabricator.wikimedia.org/T1152925) (owner: Eileen) [20:17:38] cwd: Good point [20:19:27] cwd: maybe i was wrong about the "workflow" section, and the two "update" steps should go under "compile", below? [20:19:51] awight: i think that's a good logical division [20:20:32] (CR) Florianschmidtwelzow: [C: -1] "A massive step into the right direction! However, I've some suggestions to make it even more context-based, maybe it's possible to impleme" (6 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263402 (https://phabricator.wikimedia.org/T123267) (owner: Ejegg) [20:21:09] There's something about parent repos, here... [20:21:25] like, if you're pushing a new DI, which directory are you in when you deploy? [20:24:51] awight: the new commit won't be on remote after committing [20:25:07] so what i've always done is go into the submodule and pull [20:25:22] but i guess you could just cat the new sha1 to the pointer [20:25:30] without it existing on remote [20:25:56] but it sounds like it could be a mess if it didn't make it up for some reason [20:27:38] I see what u mean [20:28:10] OTOH, we should be working with two clones, a master and deployment checkout. [20:28:41] One of the steps is to pull from local master into local deployment, so nothing has to be merged in gerrit to complete the paymentswiki submodule dance. [20:30:36] awight: as long as the merge patch makes it up before the submodule update [20:30:49] maybe it wouldn't actually matter [20:31:00] but it would put the repo in a trashed state momentarily [20:31:27] cwd: I'm suggesting that nothing has to be "up" [20:31:48] We have two local checkouts, so can git pull sideways rather than up and down [20:32:09] awight: you mean on the deploy server? [20:32:15] No, locally [20:32:24] Fundraising Sprint A 2016, Fundraising Sprint Zapp, Fundraising-Backlog: UI Annoyance: Move "Display Contacts As" back to the top of the Advanced Search - https://phabricator.wikimedia.org/T120332#1925252 (Eileenmcnaughton) Link to create an account: https://issues.civicrm.org/jira/secure/Signup!defau... [20:32:26] I'm assuming for now that frig is only a local tool [20:32:29] e? [20:32:32] eh [20:32:36] yeah that's what i've been thinking [20:32:51] so i'm confused [20:33:03] i merge local master into local deploy [20:33:13] then i locally update the parent repo with the new sha1 [20:33:32] then i push both commits to gerrit? [20:34:38] That was my thought, exactly [20:34:56] but that last step is part of the "sync" step, perhaps [20:35:02] >-< [20:35:12] so then excessively high solar winds cause the deployment repo to stall [20:35:27] but the parent patch goes through and is now pointing to a commit that doesn't exist [20:35:29] at least, I figure there should be a "stop and see if it works" checkpoint between merge and sync [20:35:32] in the submodule [20:35:44] https://hangouts.google.com/hangouts/_/wikimedia.org/frig_phreaking?hl=en&authuser=0 [20:35:47] if u want [20:35:52] yeah, brt [20:36:02] * cwd pauses bowie [20:36:14] o.o, [20:36:33] * cwd dries eyes [20:38:12] aww. listening to the new album now. definitely a goodbye [20:39:45] what a bad ass [20:40:53] Bowie was the first concert I ever went to. [20:41:02] I still have the ticket stub. Found it last weekend. [20:41:37] oh wow. wish I'd gotten to a concert of his [20:42:01] He was fucking great live. [20:42:19] :'( [20:51:24] Fundraising Sprint A 2016, Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Sprint William Shatner, and 6 others: Edits to LYBUNT report - https://phabricator.wikimedia.org/T88819#1925313 (CaitVirtue) I have not had a chance to look at any changes made to the report since 12/15is... [21:07:49] resetting router... [21:14:25] Fundraising Sprint A 2016: Backport FinancialTrxn & Entity Financial Trxn apis - https://phabricator.wikimedia.org/T123288#1925385 (Eileenmcnaughton) NEW a:Eileenmcnaughton [21:14:57] Fundraising Sprint Asbestos Removal 2016: Backport FinancialTrxn & Entity Financial Trxn apis - https://phabricator.wikimedia.org/T123288#1925393 (Eileenmcnaughton) https://gerrit.wikimedia.org/r/#/c/261759/ [21:17:03] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Zapp, Fundraising-Backlog: UI Annoyance: Move "Display Contacts As" back to the top of the Advanced Search - https://phabricator.wikimedia.org/T120332#1851253 (Eileenmcnaughton) This has now been merged into 4.7 upstream [21:21:48] Fundraising Sprint Asbestos Removal 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Performance: Civi: don't be so crazy about "SET NAMES utf8" - https://phabricator.wikimedia.org/T116724#1925410 (Eileenmcnaughton) [21:22:21] Fundraising Sprint Asbestos Removal 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Performance: Civi: don't be so crazy about "SET NAMES utf8" - https://phabricator.wikimedia.org/T116724#1925414 (Eileenmcnaughton) a:Eileenmcnaughton [21:24:58] Fundraising Sprint Asbestos Removal 2016: Backport FinancialTrxn & Entity Financial Trxn apis - https://phabricator.wikimedia.org/T123288#1925432 (Eileenmcnaughton) [21:25:00] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising Sprint Zapp, and 3 others: CiviCRM upgrade: Adapt refund processing & reporting to reflect changes since the upgrade. - https://phabricator.wikimedia.org/T116317#1746265 (Eileenmcnaug... [21:25:57] * Seddon definitely needs to remove fundraising as a watchword...... whilst in the fundraising channel [21:30:29] cwd: I think your new internet is flooding my DSL [21:31:18] DOn't look now: File:Teenage_Volunteer_Workers_exposed_to_Asbestos_at_Michigan_Central_Station_-_Detroit,_Michigan,_USA_-_30_June_2009.jpg [21:38:34] (PS1) Mhutti1: Changed wording of donate_interface-informationsharing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263438 [21:41:53] fundraising-tech-ops: monitor SSL cert expiration in frack - https://phabricator.wikimedia.org/T123144#1925513 (Jgreen) Open>Resolved done [21:42:08] (CR) jenkins-bot: [V: -1] Changed wording of donate_interface-informationsharing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263438 (owner: Mhutti1) [21:43:28] Fundraising Sprint Lou Reed, Fundraising Sprint N*E*R*D, Fundraising Sprint ODB, MediaWiki-extensions-CentralNotice, and 3 others: CentralNotice mobile modules should not be loaded in the head - https://phabricator.wikimedia.org/T100372#1925518 (Jdlrobson) [21:57:01] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising Sprint Zapp, and 4 others: Batch import fails on amount >= $1,000 - https://phabricator.wikimedia.org/T118333#1925570 (atgo) Hey @caitvirtue @leanne when do you think you'll have the... [22:04:49] (CR) Ejegg: [C: -1] ""...the ones in the country you live." is still missing a word" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263438 (owner: Mhutti1) [22:06:08] (PS3) Ejegg: Zap more globals with fewer RequestContext::getMain calls [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263402 (https://phabricator.wikimedia.org/T123267) [22:06:55] (CR) jenkins-bot: [V: -1] Zap more globals with fewer RequestContext::getMain calls [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263402 (https://phabricator.wikimedia.org/T123267) (owner: Ejegg) [22:07:40] (PS6) Awight: Fail validation and present error page for bad country [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/260885 (https://phabricator.wikimedia.org/T120727) [22:08:39] (CR) jenkins-bot: [V: -1] Fail validation and present error page for bad country [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/260885 (https://phabricator.wikimedia.org/T120727) (owner: Awight) [22:08:59] (PS4) Ejegg: Zap more globals with fewer RequestContext::getMain calls [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263402 (https://phabricator.wikimedia.org/T123267) [22:12:11] (CR) Ejegg: "OK, centralized the context in adapter and got rid of the redundancy in the special page subclass." (5 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263402 (https://phabricator.wikimedia.org/T123267) (owner: Ejegg) [22:12:51] (CR) Florianschmidtwelzow: [C: 1] "I'll merge this together with the follow up (see my comment there :P) :)" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263362 (https://phabricator.wikimedia.org/T123202) (owner: Ejegg) [22:13:26] (CR) Florianschmidtwelzow: [C: 1] "Looks good, but I haven't tested yet and let me sleep about this one more night :) Thanks for the follow up!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263402 (https://phabricator.wikimedia.org/T123267) (owner: Ejegg) [22:22:15] (PS2) Mhutti1: Changed wording of donate_interface-informationsharing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263438 [22:23:31] (CR) jenkins-bot: [V: -1] Changed wording of donate_interface-informationsharing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263438 (owner: Mhutti1) [22:23:52] (PS3) Mhutti1: Changed wording of donate_interface-informationsharing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263438 [22:25:05] (CR) jenkins-bot: [V: -1] Changed wording of donate_interface-informationsharing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263438 (owner: Mhutti1) [22:30:13] Fundraising Sprint Zapp, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Unbreak DonationInterface tests - https://phabricator.wikimedia.org/T123296#1925633 (awight) NEW [22:31:31] ejegg: Is that RequestContext stuff you're doing related to fixing the V-1 breakage ^^? [22:31:47] awight: yep! [22:31:57] ejegg: Whew, thank you! [22:32:08] lmk if I can help with anything [22:32:18] The first patch just gets things passing, the 2nd builds on it to clean up more globals [22:32:25] I think they're both ready for CR [22:32:43] ah, I could pull a ticket or two into sprint to represent 'em [22:33:26] Fundraising Sprint Asbestos Removal 2016, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Minimize use of globals in DonationInterface - https://phabricator.wikimedia.org/T123267#1925642 (Ejegg) [22:34:32] ejegg: u could reuse that one I just filed if you want [22:34:45] CR'ing... [22:34:53] Fundraising Sprint Asbestos Removal 2016, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: DonationInterface fails mwext-DonationInterface-testextension-zend test - https://phabricator.wikimedia.org/T123202#1925647 (Ejegg) [22:36:48] Fundraising Sprint Zapp, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Unbreak DonationInterface tests - https://phabricator.wikimedia.org/T123296#1925653 (Ejegg) [22:36:51] Fundraising Sprint Asbestos Removal 2016, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: DonationInterface fails mwext-DonationInterface-testextension-zend test - https://phabricator.wikimedia.org/T123202#1923562 (Ejegg) [22:40:25] ejegg: Do we need to update the payments deployment branch, or are your changes backwards-compatible? [22:40:44] Looks compatible at a glance [22:40:47] awight: tests still pass on 1.25 [22:40:57] and some random clicking doesn't show breakage [22:41:07] thanks! [22:41:36] I have something weird happening with my local tests at the moment, EnableQueue is not being overridden by TestConfiguration or something. [22:41:46] * awight confuses self by end of sentence [22:43:25] hmm [22:43:39] lemme just make sure everything's getting localized right [22:44:03] looks like maybe RapidHTML is getting the wrong language [22:44:18] ok, I'm testing locally too [22:44:57] It's localizing fine for me... [22:45:11] Special:GlobalCollectGateway&appeal=JimmyQuote&ffname=cc-vmad&recurring=&uselang=he&language=he¤cy=ILS&country=IL&amount=20.01 [22:45:39] yeah, it's just the @language var in the jimmy quote templates [22:45:48] seems stuck on en [22:46:30] oh.... LanguageSwitch| [22:46:32] nvm [22:47:10] Config artifact? [22:47:45] nah, I think the LanguageSwitch just fell back to en because the thing didn't exist in de [22:47:59] If I create the de version it shows up fine [22:49:21] Still breaks things if I try to stop setting the $wgLang global var in GatewayPage (even if I update the WmfFramework to use context->getLanguage() ) [22:50:26] yeesh [22:50:54] Message constructor still uses the global as a default if you don't add the language param [22:51:18] rather than "uselang"? [22:52:51] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: paymentswiki interface mildly allergic to shift-tab - https://phabricator.wikimedia.org/T123303#1925820 (awight) [22:52:52] Ah, I mean if I delete the wgLang lines 69-70 in GatewayPage [22:53:17] Yep. Due to bad things I did in WmfFramework [22:53:25] awight: oh, sorry, I was talking about the optional constructor argument [22:53:56] maybe WmfFramework::getLanguageCode [22:54:08] Fundraising Sprint Asbestos Removal 2016, Wikimedia-Fundraising-CiviCRM: Fix speed issue when doing a refund in the UI - https://phabricator.wikimedia.org/T123305#1925829 (Eileenmcnaughton) NEW a:Eileenmcnaughton [22:54:26] (CR) Awight: [C: 2] "Win! Thanks everyone who gave extra review." (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263362 (https://phabricator.wikimedia.org/T123202) (owner: Ejegg) [22:54:49] even if you update WmfFramework::getLanguageCode to use context it wasn't working - think we need to explicitly pass language argument in a bunch of places too [22:55:32] Fundraising Sprint Asbestos Removal 2016, Wikimedia-Fundraising-CiviCRM: Fix speed issue when doing a refund in the UI - https://phabricator.wikimedia.org/T123305#1925829 (Eileenmcnaughton) [22:55:34] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising Sprint Zapp, and 3 others: CiviCRM upgrade: Adapt refund processing & reporting to reflect changes since the upgrade. - https://phabricator.wikimedia.org/T116317#1925844 (Eileenmcnaug... [22:55:35] That would be a sad affair... [22:55:39] yeah, tons of wfMessage() without inLanguage() [22:55:45] Fundraising Sprint Asbestos Removal 2016, Wikimedia-Fundraising-CiviCRM: Backport FinancialTrxn & Entity Financial Trxn apis - https://phabricator.wikimedia.org/T123288#1925846 (Eileenmcnaughton) [22:56:09] I guess that's the price we pay for statelessness [23:03:07] Fundraising Sprint Asbestos Removal 2016, Wikimedia-Fundraising-CiviCRM: Fix contribution.get to still retrieve custom fields when no user is logged in but permissions are set to not be checked - https://phabricator.wikimedia.org/T123309#1925954 (Eileenmcnaughton) NEW a:Eileenmcnaughton [23:03:44] (Merged) jenkins-bot: Wipe out $wgRequest [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263362 (https://phabricator.wikimedia.org/T123202) (owner: Ejegg) [23:03:56] Fundraising Sprint Asbestos Removal 2016, Wikimedia-Fundraising-CiviCRM: Fix contribution.get to still retrieve custom fields when no user is logged in but permissions are set to not be checked - https://phabricator.wikimedia.org/T123309#1925954 (Eileenmcnaughton) [23:04:12] (PS14) Paladox: WIP Convert DonationInterface to extension registration [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/242214 (https://phabricator.wikimedia.org/T108763) (owner: Awight) [23:06:10] awight: I was just looking at this one https://phabricator.wikimedia.org/T91911 [23:06:31] (CR) Paladox: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263438 (owner: Mhutti1) [23:06:36] I did a gerrit for it back when we discussed it (but should probably have pulled it into the sprint at that point) [23:06:51] but, interesting to see that there is an 'upstream' tag on it. [23:07:07] (CR) Paladox: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/260885 (https://phabricator.wikimedia.org/T120727) (owner: Awight) [23:07:19] Should we be tagging the things we upstream in some way? [23:07:28] (CR) Paladox: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/260885 (https://phabricator.wikimedia.org/T120727) (owner: Awight) [23:07:37] Fundraising Sprint Asbestos Removal 2016, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 3 others: Point amp cache to $WORKSPACE - https://phabricator.wikimedia.org/T91911#1925997 (Eileenmcnaughton) [23:07:54] (PS3) Paladox: Add grunt-jsonlint and update packages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263371 [23:07:57] Fundraising Sprint Asbestos Removal 2016, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 3 others: Point amp cache to $WORKSPACE - https://phabricator.wikimedia.org/T91911#1926002 (Eileenmcnaughton) a:Eileenmcnaughton [23:08:04] (PS9) Paladox: Replace package grunt-jscs-checker with grunt-jscs, Update packages, Add jsonlint test [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263235 [23:10:10] (CR) Paladox: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/260229 (https://phabricator.wikimedia.org/T96047) (owner: Awight) [23:10:33] (CR) Paladox: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/260228 (https://phabricator.wikimedia.org/T96047) (owner: Awight) [23:10:49] (CR) Paladox: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/259795 (https://phabricator.wikimedia.org/T121800) (owner: Ejegg) [23:10:51] Fundraising Sprint Asbestos Removal 2016, Wikimedia-Fundraising-CiviCRM: Add support for passing a refund trxn id to the CiviCRM api - https://phabricator.wikimedia.org/T123312#1926023 (Eileenmcnaughton) NEW a:Eileenmcnaughton [23:11:09] (CR) Paladox: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/234718 (owner: Awight) [23:11:25] eileen: Sorry, I've been sitting here waiting for the page to load... My 'net is very wrong today. [23:11:42] Cool! [23:12:18] I should probably rebase my changes to amp and try to upstream again... [23:12:33] I thought it was upstreamed already? [23:13:01] not sure. The merge conflict does suggest it was [23:13:26] re: the upstream tag, I'm personally using it as a reminder that I should upstream things. [23:13:35] lemme check the "official" defintion [23:13:44] ah right - not that they have already been upstreamed [23:13:51] https://phabricator.wikimedia.org/project/profile/153/ [23:14:08] hehe, it's a third definition [23:14:11] aha! [23:14:17] "blocked-by-upstream" [23:15:13] I doubt there are any cross-project uses for that tag, so I'd say feel free to do whatever you want wrt tagging as Upstream [23:15:55] maybe I should comment on the Upstream project page that we have a different need [23:17:12] ok [23:17:43] I have to stop for a bit & feed a kid. I have been messing up all the careful triage by adding extra tickets to cover the gerrits that are hanging around [23:17:51] awesome! [23:18:16] eileen: Seems like unnecessary bookkeeping to add an Upstream tag to things you've already fixed upstream, if you agree [23:18:46] ok [23:18:58] In a way the rebase process creates a list of them [23:29:51] Fundraising Sprint Asbestos Removal 2016, Fundraising-Backlog: SPIKE: scope FRIG scope - https://phabricator.wikimedia.org/T123246#1926075 (cwdent) Open>Resolved This doc is a good outline: https://etherpad.wikimedia.org/p/Frig_deployment_tool I'd consider this scoped, and further tasks will be use... [23:43:11] (CR) Awight: [C: 2] Zap more globals with fewer RequestContext::getMain calls (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263402 (https://phabricator.wikimedia.org/T123267) (owner: Ejegg) [23:44:45] (CR) Awight: [C: 2] Add grunt-jsonlint and update packages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263371 (owner: Paladox) [23:45:06] (Merged) jenkins-bot: Zap more globals with fewer RequestContext::getMain calls [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263402 (https://phabricator.wikimedia.org/T123267) (owner: Ejegg) [23:45:38] thanks again awight! Just noticed one thing I missed in GatewayPage... [23:45:50] (Merged) jenkins-bot: Add grunt-jsonlint and update packages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263371 (owner: Paladox) [23:46:43] (CR) Awight: [C: 2] "Thank you for the updates!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263235 (owner: Paladox) [23:46:59] (CR) jenkins-bot: [V: -1] Replace package grunt-jscs-checker with grunt-jscs, Update packages, Add jsonlint test [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263235 (owner: Paladox) [23:48:47] (PS10) Awight: Replace package grunt-jscs-checker with grunt-jscs, Update packages, Add jsonlint test [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263235 (owner: Paladox) [23:49:04] (CR) Awight: "PS 10: manual rebase" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263235 (owner: Paladox) [23:49:13] (CR) Awight: [C: 2] Replace package grunt-jscs-checker with grunt-jscs, Update packages, Add jsonlint test [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263235 (owner: Paladox) [23:49:44] (PS4) Awight: Fix maintenance form display [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/262840 (https://phabricator.wikimedia.org/T86248) (owner: Ejegg) [23:50:12] (Merged) jenkins-bot: Replace package grunt-jscs-checker with grunt-jscs, Update packages, Add jsonlint test [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263235 (owner: Paladox) [23:50:58] (CR) Awight: [C: 2] "You hear the howling of the CwnAnnwn..." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/262840 (https://phabricator.wikimedia.org/T86248) (owner: Ejegg) [23:51:03] (PS5) Awight: Fix maintenance form display [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/262840 (https://phabricator.wikimedia.org/T86248) (owner: Ejegg) [23:51:45] (PS7) Awight: Fail validation and present error page for bad country [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/260885 (https://phabricator.wikimedia.org/T120727) [23:52:51] (CR) jenkins-bot: [V: -1] Fail validation and present error page for bad country [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/260885 (https://phabricator.wikimedia.org/T120727) (owner: Awight) [23:57:38] hrm? [23:58:51] ejegg: oops, I just saw your note [23:59:09] nah, I only noticed after you +2ed [23:59:26] * awight steam rollers back and forth some more [23:59:40] oh, I think you might be failing b/c the test is setting wgOut instead of requestContext::main->setOutput [23:59:54] Fundraising Sprint Asbestos Removal 2016, Wikimedia-Fundraising-CiviCRM: Add ability to enter a trxn_id for the refund transaction when editing a contribution to be Refunded - https://phabricator.wikimedia.org/T123319#1926169 (Eileenmcnaughton) NEW a:Eileenmcnaughton