[00:30:20] (PS8) Ejegg: (patch already in 4.7) CRM-17640 Update contribution api to do a sensible query when getcount is being invoked [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256241 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [00:40:17] (PS1) Reedy: No alias file in extension [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/263780 [00:41:26] Hang on, am I being blind [00:42:00] (CR) Legoktm: [C: 2] No alias file in extension [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/263780 (owner: Reedy) [00:42:45] (Merged) jenkins-bot: No alias file in extension [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/263780 (owner: Reedy) [00:43:04] legoktm: Not sure if that should've been merged [00:43:06] :P [00:44:09] Ah [00:44:11] Missing space [00:44:11] 23:21:50 Warning: include(): Failed opening '/mnt/srv/mediawiki-staging/php-master/extensions/LandingCheckLandingCheck.alias.php' for inclusion (include_path='/mnt/srv/mediawiki-staging/php-master:/usr/local/lib/php:/usr/share/php') in /mnt/srv/mediawiki-staging/php-master/includes/cache/LocalisationCache.php on line 527 [00:44:20] *slash [00:44:42] (PS1) Reedy: Revert "No alias file in extension" [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/263783 [00:44:47] (CR) Reedy: [C: 2] Revert "No alias file in extension" [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/263783 (owner: Reedy) [00:44:48] oops [00:44:50] sorry [00:44:52] heh [00:45:01] Will make a proper commit :) [00:46:43] (CR) Reedy: "CR -1" (1 comment) [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/261915 (https://phabricator.wikimedia.org/T88055) (owner: Mhutti1) [00:47:48] cmon jenkins [00:48:43] (Merged) jenkins-bot: Revert "No alias file in extension" [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/263783 (owner: Reedy) [00:49:20] (PS1) Reedy: Add / to alias in php file [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/263784 [00:49:46] * legoktm intensely reviews [00:50:26] (CR) Legoktm: [C: 2] Add / to alias in php file [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/263784 (owner: Reedy) [00:50:57] (Merged) jenkins-bot: Add / to alias in php file [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/263784 (owner: Reedy) [01:25:57] Hi eileen ! Trying to figure out where Civi calls the getcount while editing a transaction to refunded status [01:27:05] without your patch applied, if I put a breakpoint in civicrm_api3_generic_getcount, it never gets hit [01:27:40] that's what gets called when there's no entity-specific getcount api function, right? [01:28:01] oh, I should just apply your patch and put a breakpoint in the new code... [01:28:09] (CR) Eileen: "Yeah I think we should merge it as is & focus on the other things - I did it upstream to so if I fix further I'll fix there" (2 comments) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/263309 (https://phabricator.wikimedia.org/T120332) (owner: Eileen) [01:28:27] (PS3) Ejegg: (merged into 4.7) Whitespace only. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/263309 (https://phabricator.wikimedia.org/T120332) (owner: Eileen) [01:28:46] (CR) jenkins-bot: [V: -1] (merged into 4.7) Whitespace only. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/263309 (https://phabricator.wikimedia.org/T120332) (owner: Eileen) [01:29:31] eew, git fail [01:29:50] (CR) Ejegg: [C: 2] (merged into 4.7) Whitespace only. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/263309 (https://phabricator.wikimedia.org/T120332) (owner: Eileen) [01:30:11] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/263309 (https://phabricator.wikimedia.org/T120332) (owner: Eileen) [01:32:03] (Merged) jenkins-bot: (merged into 4.7) Whitespace only. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/263309 (https://phabricator.wikimedia.org/T120332) (owner: Eileen) [01:35:17] eileen: huh, even with your patch applied I don't see it hitting civicrm_api3_contribution_getcount when changing a contribution status to refunded and saving [01:48:53] ejegg|away: I noticed that the speed issue seemed to be back despite that patch yesterday - I wonder if some other change happened after I did that patch that is interacting - I'll look again… [01:52:31] Fundraising Sprint Asbestos Removal 2016, Fundraising-Backlog: Some Globalcollect donations not in Civi - https://phabricator.wikimedia.org/T122730#1930336 (cwdent) It sounds like this may be an issue with our audit parsing, or the way audit files are prepared at GC, or both, as I am able to find the offe... [06:32:39] (CR) TTO: Changed wording of donate_interface-informationsharing (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263438 (owner: Mhutti1) [12:18:24] (PS4) Mhutti1: Changed wording of donate_interface-informationsharing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263438 [12:19:27] (CR) jenkins-bot: [V: -1] Changed wording of donate_interface-informationsharing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263438 (owner: Mhutti1) [12:21:45] (CR) Mhutti1: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263438 (owner: Mhutti1) [12:24:39] (PS5) Mhutti1: Changed wording of donate_interface-informationsharing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263438 [12:25:32] (CR) jenkins-bot: [V: -1] Changed wording of donate_interface-informationsharing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263438 (owner: Mhutti1) [12:27:06] (CR) Mhutti1: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263438 (owner: Mhutti1) [13:11:35] Fundraising Sprint Yo La Tengo, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review, Wikimedia-log-errors: Fix "Notice: Undefined index: next_time_24h in SpecialHideBanners.php" - https://phabricator.wikimedia.org/T120890#1930903 (Pcoombe) [14:56:30] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: certain Civi searches take a long time - https://phabricator.wikimedia.org/T123418#1931307 (MBeat33) [15:03:30] Fundraising Sprint Asbestos Removal 2016, Fundraising-Backlog: Some Globalcollect donations not in Civi - https://phabricator.wikimedia.org/T122730#1931325 (MBeat33) @cwdent I pinged Sal at GC about that. DS just found two more transactions from 12/29, GC 4366394234 & 7587050617, that did not make it to C... [15:04:56] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Zapp, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Donors still don't know payments succeeded when queue is dead. - https://phabricator.wikimedia.org/T122627#1909335 (MBeat33) Two more from a don... [18:12:09] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Additional Civi Login For Engage - https://phabricator.wikimedia.org/T123526#1931733 (LeanneS) NEW [18:23:51] eileen, AndyRussG, cwd|brb, XenoRyet : anything to tell/ask other teams for Scrum of Scrums? [18:23:59] Na, I'm good. [18:24:09] nope! thanks [18:24:14] oops [18:27:05] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Additional Civi Login For Engage - https://phabricator.wikimedia.org/T123526#1931792 (LeanneS) p:High>Unbreak! [18:30:31] ejegg: ohh no - but it's intriguing to know there is a scrum of scrums [18:30:36] cool, thanks! [18:31:08] eileen: yeah, just one member of each coding team, working out any inter-team dependencies [18:35:20] cool [18:38:56] (CR) Mhutti1: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263438 (owner: Mhutti1) [18:40:46] Fundraising Sprint Asbestos Removal 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, Unplanned-Sprint-Work: Additional Civi Login For Engage - https://phabricator.wikimedia.org/T123526#1931847 (atgo) Adding since this needs to happen this week [18:41:18] (CR) Ejegg: "Seeing the same set of failures on an unrelated patch - must have been caused by some core update..." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263438 (owner: Mhutti1) [18:48:50] Fundraising-Backlog: Having trouble receiving Coinbase reports via SpiderOak - https://phabricator.wikimedia.org/T123530#1931889 (LeanneS) NEW [18:58:42] (CR) Nemo bis: [C: -1] Changed wording of donate_interface-informationsharing (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263438 (owner: Mhutti1) [19:00:50] (CR) Nemo bis: "Thanks for including the link to the TWN thread; I've updated its summary https://translatewiki.net/w/i.php?diff=6623214&oldid=6020764&rci" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263438 (owner: Mhutti1) [19:05:55] (PS6) Mhutti1: Changed wording of donate_interface-informationsharing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263438 [19:07:08] (CR) jenkins-bot: [V: -1] Changed wording of donate_interface-informationsharing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263438 (owner: Mhutti1) [19:24:32] We've got another core change breaking DonationInterface tests. Tracking it down with the nifty git bisect automation described by hashar here: https://phabricator.wikimedia.org/T123202 [19:25:12] and here's our culprit: a73c5b7395a07d490f7052fd3b2491ebd656b190 Add SessionManager [19:25:41] erk, this might be a tough one [19:41:43] Fundraising Sprint Asbestos Removal 2016, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Do not directly access $_SESSION superglobal in DonationInterface - https://phabricator.wikimedia.org/T123006#1932129 (Ejegg) [20:13:00] AndyRussG|sortof: Don't look now, but I brought up Banner History at today's meeting on replacing our analytics with a unique token system. [20:14:08] The response was sort of unfortunate--KLeduc brought up the important issue of having to design use cases ahead of time, but the other downsides mentioned were more a function of BH being in its infancy: it took a lot of work to implement, and we don't know what to do with the data, yet. [20:14:52] Thought you should know, these seem like easy points to address in an overview of how BH works. [20:20:17] awight: interesting! Yeah I was actually talking to KLeduc a bit about it at AH [20:27:43] AndyRussG|sortof: I walked into the presentation late, he was saying that he'd actually addressed the BH project specifically earlier in his talk... [20:28:41] Fundraising Sprint Asbestos Removal 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, Unplanned-Sprint-Work: Additional Civi Login For Engage - https://phabricator.wikimedia.org/T123526#1932379 (Eileenmcnaughton) Do we have an email for her? [20:29:35] (CR) Hashar: "https://gerrit.wikimedia.org/r/#/c/243223/ wraps the PHP sessions in a SessionManager class. Might be related to the test failures." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/195375 (owner: Awight) [20:30:40] Fundraising Sprint Asbestos Removal 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, Unplanned-Sprint-Work: Additional Civi Login For Engage - https://phabricator.wikimedia.org/T123526#1932398 (LeanneS) @Eileenmcnaughton ellenj@engageusa.com. Thanks! [20:33:11] (PS1) Ejegg: Omitted line from RequestContext cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263922 [20:34:05] (CR) jenkins-bot: [V: -1] Omitted line from RequestContext cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263922 (owner: Ejegg) [20:36:03] Fundraising Sprint Asbestos Removal 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, Unplanned-Sprint-Work: Additional Civi Login For Engage - https://phabricator.wikimedia.org/T123526#1932439 (Eileenmcnaughton) I've created the account in Drupal (CiviCRM) & give... [20:37:21] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-GlobalCollect: GlobalCollect audit: lots of "impossible" errors for refunds - https://phabricator.wikimedia.org/T120430#1932451 (awight) p:Triage>High Still seeing a lot of these. [20:37:24] ejegg: can I grab you re https://gerrit.wikimedia.org/r/#/c/256163/4/CRM/Core/DAO.php for a moment? I realise I'm not clear about your comment [20:37:51] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Continuous-Integration-Config, Patch-For-Review, WorkType-Maintenance: Bad empty CI jobs on wikimedia/fundraising/crm deployment branch - https://phabricator.wikimedia.org/T120881#1932461 (greg) [20:38:02] actually I DO understand it [20:38:07] (CR) Paladox: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/195375 (owner: Awight) [20:38:16] I was too quick to misread it so ignore above ejegg [20:38:25] (CR) Paladox: "check experimental" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/195375 (owner: Awight) [20:39:18] eileen: oh, ok [20:39:34] I just saw that setFactory() stuff in both places [20:40:48] awight: links? slide deck somewheres? [20:40:53] (CR) Ejegg: "Yep, git bisect shows that's indeed the core commit that breaks DI. Starting to work on a fix." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/195375 (owner: Awight) [20:48:24] ejegg: yeah - you were too sharp for me - I was playing catch up [20:49:01] I figure it wasn't doing anything bad since that class was the same as the constant in Config [20:49:03] in 4.7 (which is where I ported the patch from there are some more changes which I think make sense to add in ) [20:49:24] actually there are a LOT of good changes in 4.7 - but there is a small one I think I can add in [20:49:35] ah, right on. [20:49:51] * ejegg pulls down updates to civi core for perusal [20:51:42] The jenkins tests run a LOT faster on 4.7 & it's because of the work Tim did - but I can't backport all that - this is the upstream commit that removed that other fn https://github.com/civicrm/civicrm-core/commit/635f0b8655fb0b77ba882cde2081e5055326d175 [20:52:45] ah, cool [20:53:20] wow, that is a lot of simplification [20:53:22] nice [20:54:21] yeah Tim has done fab stuff - the test runs in jenkins are sooo much faster on 4.7 - [20:54:44] although a lot of that is clearing caches & stuff that isnt done frequently outside tests [20:54:56] so I don't notice the UI being heaps faster on 4.7 [20:57:52] well, speeding up development is definitely worth while [21:06:57] (PS5) Eileen: (backport from 4.7) CRM-17394 - Initialize DB slightly later. Fix query-log and redundant SET NAMES. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256163 (https://phabricator.wikimedia.org/T116724) [21:06:59] (PS2) Eileen: (merged into 4.7) CRM-17627 Set transaction date correctly for refunds [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/263313 (https://phabricator.wikimedia.org/T116317) [21:07:01] (PS2) Eileen: (merged into 4.7) CRM-17751 add api support for setting the trxn_id for a refund [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/263314 (https://phabricator.wikimedia.org/T116317) [21:07:03] (PS4) Eileen: CRM-17751 add refund trxn to forms [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/261601 (https://phabricator.wikimedia.org/T116317) [21:07:05] (PS1) Eileen: Partial backport of DB initialisation fixes. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/263924 (https://phabricator.wikimedia.org/T116724) [21:08:34] (PS2) Eileen: Partial backport of DB initialisation fixes. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/263924 (https://phabricator.wikimedia.org/T116724) [21:08:36] (PS6) Eileen: (backport from 4.7) CRM-17394 - Initialize DB slightly later. Fix query-log and redundant SET NAMES. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256163 (https://phabricator.wikimedia.org/T116724) [21:08:59] Fundraising Sprint Asbestos Removal 2016, Fundraising-Backlog, Unplanned-Sprint-Work, FR-GlobalCollect: Refund not matching original amount--GC original may have been imported incorrectly - https://phabricator.wikimedia.org/T123404#1932657 (DStrine) a:awight [21:11:54] (CR) jenkins-bot: [V: -1] (merged into 4.7) CRM-17751 add api support for setting the trxn_id for a refund [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/263314 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [21:13:09] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/263314 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [21:18:46] Fundraising Sprint Asbestos Removal 2016, Fundraising-Backlog, Unplanned-Sprint-Work: Having trouble receiving Coinbase reports via SpiderOak - https://phabricator.wikimedia.org/T123530#1932705 (DStrine) AWight is gonna suggest PGP-encrypted email, which was Coinbase's first suggestion anyway. [21:41:04] https://www.youtube.com/watch?v=AFXTxQPV79w [21:41:14] if anyone needs to waste 2m [21:53:19] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Yo La Tengo, Fundraising Sprint Zapp, Fundraising-Backlog, and 2 others: Add default order for Lybunt report to sort descending by greatest 2014 amount - https://phabricator.wikimedia.org/T119911#1933027 (CaitVirtue) @eileenmcnaughton I c... [21:54:50] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Yo La Tengo, Fundraising Sprint Zapp, Fundraising-Backlog, and 2 others: LYBUNT: Change "lifetime total" to "Last year total" - https://phabricator.wikimedia.org/T119909#1933043 (CaitVirtue) @XenoRyet @eileenmcnaughton The data looks good... [22:13:30] MBeat: Can you take a look in the GC console for me? I'm investigating txn# 2098041776 from Jan 7, it seems to have been charged for $1 and then refunded for $10 [22:13:36] This is the one we were emailing about... [22:13:43] sure thing [22:13:47] Is it possible that the manual refund was made for the wrong amoung? [22:13:50] t [22:13:50] thanks! [22:16:50] it’s weird, awight, the auth and req amounts are both $1, and that’s the amount we canceled. But in the Payment Details tab it says Authorization Amount: 100 - it looks like we refunded the correct amount [22:18:09] so I’m not sure where the $10 comes from [22:21:14] MBeat: okay, that's very helpful! [22:21:28] I can pull out the audit line and email GC about this (will cc you) [22:21:34] thanks [22:43:55] (PS1) Ejegg: Use SessionManager instead of deprecated fn [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/264017 (https://phabricator.wikimedia.org/T123006) [22:44:56] (CR) jenkins-bot: [V: -1] Use SessionManager instead of deprecated fn [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/264017 (https://phabricator.wikimedia.org/T123006) (owner: Ejegg) [22:51:10] cwd: I just noticed something that might bear on your audit file investigation... [22:51:26] WR1 files only refer to transactions using the contribution_tracking ID, not the gateway transaction id. [22:51:27] awight: i'm all ears [22:51:39] I think I relearn this once a year. [22:51:40] oh really [22:52:29] awight: thanks! lemme look into that... [22:54:58] awight: if all i have is gateway ID, can i look it up in CT? the query that i've seen joins on contribution_extra and turns up nothing [22:55:08] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Zapp, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Need to see UTM Source/UTM Campaign in Civi - https://phabricator.wikimedia.org/T121284#1933278 (CaitVirtue) I think so. When I search via Find Contributions for Di... [22:57:03] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Sprint William Shatner, and 6 others: Edits to LYBUNT report - https://phabricator.wikimedia.org/T88819#1933295 (CaitVirtue) I can't run the FY report, so I'm not able to verify that functi... [22:57:05] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Zapp, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Need to see UTM Source/UTM Campaign in Civi - https://phabricator.wikimedia.org/T121284#1933296 (awight) Followup task: it would be great to have access to the contri... [22:58:36] cwd: oooh, that's a good point [22:58:55] What's the gateway txn id? [22:59:59] awight: an example of one is 1538846519 [22:59:59] so there's definitely a contribution_tracking row for this same pageload [22:59:59] but i'm not sure if we can correlate [23:01:51] could potentially try to triangulate using various logs [23:01:54] sounds fugly [23:02:17] yeah I don't see that in the db [23:02:20] nasty [23:02:45] If you miraculously have the contribution tracking id... what is that? [23:03:01] yeah...i don't [23:03:15] lemme try something stupid [23:10:39] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/263314 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [23:11:49] awight: it was just stupid enough to work. CTID 33377165 -- sadly still not in any wr1 files [23:12:17] but we should be able to tease the CTIDs out of those csv files, if they end up being of any use [23:25:49] aargh, we do SO much crazy session stuff... [23:34:08] Fundraising Sprint Asbestos Removal 2016, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Lynbunt report could be faster - https://phabricator.wikimedia.org/T122024#1933407 (DStrine) [23:51:40] (PS2) Ejegg: WIP update session handling for 1.27 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/264017 (https://phabricator.wikimedia.org/T123006) [23:52:51] (CR) jenkins-bot: [V: -1] WIP update session handling for 1.27 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/264017 (https://phabricator.wikimedia.org/T123006) (owner: Ejegg) [23:53:40] cwd: It does seem to be missing... [23:54:00] Although: 657020160105.csv and WikimediaMonth.20160101.flw.csv [23:54:13] awight: yep [23:54:17] but missing from the files we parse [23:54:19] I don't like it. [23:55:31] gc does not appear to know where those csv files are coming from [23:55:38] our normal audit files are fixed length (retch)