[00:02:00] well i gotta go chauffeur, later! [00:11:35] Fundraising Sprint Asbestos Removal 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, Unplanned-Sprint-Work: Additional Civi Login For Engage - https://phabricator.wikimedia.org/T123526#1933510 (awight) a:Jgreen @eileenmcnaughton Thank you! That's perfect. Yea... [00:17:12] Fundraising Sprint Asbestos Removal 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, Unplanned-Sprint-Work: Additional Civi Login For Engage - https://phabricator.wikimedia.org/T123526#1933517 (atgo) @leannes if I recall correctly, @jgreen will want a cell number... [00:37:22] (PS3) Ejegg: WIP update session handling for 1.27 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/264017 (https://phabricator.wikimedia.org/T123006) [00:38:34] (CR) jenkins-bot: [V: -1] WIP update session handling for 1.27 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/264017 (https://phabricator.wikimedia.org/T123006) (owner: Ejegg) [00:58:15] aargh, this rabbit hole is pretty damn deep [01:22:02] Fundraising Sprint Asbestos Removal 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, Unplanned-Sprint-Work: Additional Civi Login For Engage - https://phabricator.wikimedia.org/T123526#1933711 (LeanneS) Thanks all! @atgo yes, I'll add Ellen's number as soon as I... [18:31:08] Fundraising Sprint Asbestos Removal 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, Unplanned-Sprint-Work: Additional Civi Login For Engage - https://phabricator.wikimedia.org/T123526#1934829 (LeanneS) @Jgreen and @atgo Ellen's number is now on the Collab page. [18:41:04] Fundraising Tech Backlog, Security-Team: Fix SSL issues identified in last openvas scan - https://phabricator.wikimedia.org/T123648#1934878 (csteipp) NEW [18:43:37] fundraising-tech-ops, FR-Paypal: fundraising.wm.o SSL certificate needs renewal - https://phabricator.wikimedia.org/T123649#1934889 (awight) NEW [20:01:59] Fundraising Sprint Zapp, Fundraising-Backlog, Traffic, Unplanned-Sprint-Work, and 2 others: Firefox SPDY-coalesces requests to geoiplookup over text-lb, causing GeoIP IPv6 failures - https://phabricator.wikimedia.org/T121922#1935151 (BBlack) I've implemented the "separate IP" fix for now so we can... [20:37:14] aargh, our unit tests are already completely fubar as regards session. We're clearing out the data, but not ending the session and resetting the id, so calls to gateway->session_exists() are all wrong [20:39:56] ooof [20:40:45] and to actually end and restart a session, we need to wrap everything with output buffering, not just the form tests [20:41:19] oh no, really! [20:41:49] ejegg: What about just mocking the session access? [20:41:53] yeah, otherwise the session setup fails with 'headers already sent', but it's wrapped in wfSuppressWarnings... [20:42:13] awight: yeah, the new way mocks session access via FauxRequest [20:42:29] but I was hoping to get some tests that pass on the old code [20:43:15] Sounds decreasingly possible... [20:43:53] yarp. I'm just trying to figure out if any of the old tests are only passing b/c of the session leakage [20:44:04] !! [20:44:13] oh wait, phpunit can run single tests, not just groups. lemme script that up [20:46:01] aww, --process-isolation got me excited for a sec, but it's having trouble serializing a closure [20:46:06] Jeff_Green: Hi! I'm sure you're already aware, but https://phabricator.wikimedia.org/T123649 [20:56:07] SessionManager sounds like a win, from anomie's email [20:56:23] yeah, it's definitely better than not having it! [20:57:36] not sure the best way to detect whether a session exists, though. And trying to get data when a session doesn't exist yet will create a new session [20:58:59] Why do we need to detect, anyway? Can't we just test whether the data we want is present? [20:59:54] good question... [21:01:03] I've been trying to keep the functionality as unchanged as possible, but I think you're right. [21:02:25] alright, I'll push ahead with the mocks and quit trying to make the session existence tests work on the old code [21:10:46] awight ya, i poked in a ticket earlier today for the same thing, but I can't find it now [21:11:58] oh duh, i'm not logged in. that's why [21:13:03] fundraising-tech-ops, FR-Paypal: fundraising.wm.o SSL certificate needs renewal - https://phabricator.wikimedia.org/T123649#1935310 (Jgreen) [21:16:34] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Yo La Tengo, Fundraising Sprint Zapp, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: iframe not appearing for some people (confirmed modern browsers) - https://phabricator.wikimedia.org/T112181#1935335 (DStrine) @MBeat33... [21:16:45] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Yo La Tengo, Fundraising Sprint Zapp, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: iframe not appearing for some people (confirmed modern browsers) - https://phabricator.wikimedia.org/T112181#1935336 (DStrine) Open>... [21:16:54] (CR) Awight: [C: 2] Make landing page parameters case-insensitive [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/263679 (https://phabricator.wikimedia.org/T114010) (owner: Ejegg) [21:17:50] thanks awight! [21:18:04] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint UB40, Fundraising Sprint Vengaboys, Fundraising Sprint William Shatner, and 6 others: Edits to LYBUNT report - https://phabricator.wikimedia.org/T88819#1935342 (XenoRyet) Open>Resolved [21:29:47] phooey, hangout freezeup [21:35:50] https://k60.kn3.net/D/3/F/6/7/B/A41.gif [21:36:05] so stoic [21:36:40] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Lynbunt report could be faster - https://phabricator.wikimedia.org/T122024#1935419 (DStrine) [21:38:35] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Lynbunt report could be faster - https://phabricator.wikimedia.org/T122024#1894027 (DStrine) [21:38:51] Fundraising Sprint Asbestos Removal 2016, Fundraising-Backlog, Unplanned-Sprint-Work: LYBUNT related: Fiscal Year report does not work - https://phabricator.wikimedia.org/T123671#1935422 (DStrine) [21:43:07] atgomez: Thank you! [21:44:10] bwahaha... wat [21:45:14] I feel like our gif game is a little dog heavy: http://i.imgur.com/CGxOH5g.gifv [21:45:50] I missed the beginning. [21:45:53] So sad. [23:22:58] K4-713: fyi i'm camped out at old timey finger in case you need anything. i'm in meetings (here) from 330-5 though [23:47:09] (PS4) Ejegg: WIP update session handling for 1.27 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/264017 (https://phabricator.wikimedia.org/T123006) [23:48:07] (CR) jenkins-bot: [V: -1] WIP update session handling for 1.27 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/264017 (https://phabricator.wikimedia.org/T123006) (owner: Ejegg)