[17:43:53] (CR) Siebrand: [C: -1] "The change isn't necessarily more correct than the current text. I've proposed (yet) an other option." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263438 (owner: Mhutti1) [18:17:23] (PS7) Mhutti1: Changed wording of donate_interface-informationsharing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263438 [18:18:24] (CR) jenkins-bot: [V: -1] Changed wording of donate_interface-informationsharing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263438 (owner: Mhutti1) [19:02:02] (PS5) Ejegg: WIP update session handling for 1.27 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/264017 (https://phabricator.wikimedia.org/T123006) [19:16:18] (PS6) Ejegg: WIP update session handling for 1.27 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/264017 (https://phabricator.wikimedia.org/T123006) [19:17:14] (CR) jenkins-bot: [V: -1] WIP update session handling for 1.27 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/264017 (https://phabricator.wikimedia.org/T123006) (owner: Ejegg) [19:22:14] (PS7) Ejegg: WIP update session handling for 1.27 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/264017 (https://phabricator.wikimedia.org/T123006) [19:24:00] cwd, K4-713 : wanna take a look at the session handling patch? I figure we can clean up / encapsulate more when we upgrade to 1.27 and can use SessionManager calls everywhere. There are still some test failures in 1.25 that I'd appreciate help diagnosing and fixing! [19:24:38] I won't have time to look at this for another... couple hours, at least. [19:24:45] k [19:26:35] I think cwd definitely has his head in the code more than me at this point, too... [19:27:06] yeah, this touches some arcane stuff that I thought your insight might be valuable on [19:27:30] I'll see if I can have a look after my lunch-disrupting meetings + actual lunch. [19:27:52] I guess there's no way we'd be deploying today anyway, though. [19:27:53] :p [19:27:57] WOOT FRIDAY [19:28:11] heh, no way I'm deploying this sucker without a lot more testing [19:28:28] it's a bigger change than i was hoping to make [19:29:41] well, bigger than i was hoping to make right now, but still smaller than moving all the session stuff outside of gatewayAdapter [19:32:08] K4-713: I have a central notice question, if you change bucket with mw.centralNotice.setBucket( newBucket ); does the impression cookie with the campaign get reset? [19:32:24] Er. [19:32:26] Seddon: I can look that up for ya [19:32:30] :D [19:32:43] K4-713: delegated without even having to so anything :P [19:32:46] do* [19:32:51] thanks ejegg :) [19:32:51] Well-oiled machine! [19:34:17] Seddon: Yep, looks like it does store the new bucket during that call [19:34:18] hey dstrine early lunch? [19:34:43] err, wait, that's not what you were asking [19:35:09] dstrine: i'm thinking sunrise deli [19:35:17] Seddon - which cookie exactly? [19:35:25] * atgomez turns around, realizes dstrine isn't even at his computer [19:36:07] ejegg, just getting some lunch but I'll check that out after [19:36:15] thanks cwd! [19:39:53] ejegg: Ill be honest and say I am not entirely sure. now I might be making this up. But i have in my head that I read.... somewhere that I cant remember..... that if the bucket assigned to a browser doesn't match with the impression count cookie (because you have changed that persons bucket) that the impression count gets reset [19:40:13] but I may be making that completely up [19:40:15] This is for the banner diet mixin? [19:40:59] impression diet rather [19:42:21] ejegg: yes I think so [19:43:55] Seddon: I don't see anything in the impressionDiet code that depends on buckets. As long as the cookie name mixin parameter stays the same, it should keep using the same cookie [19:46:10] (PS8) Ejegg: WIP update session handling for 1.27 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/264017 (https://phabricator.wikimedia.org/T123006) [19:46:41] ejegg: but changing buckets won't reset the count in the cookie? [19:46:51] Doesn't look like it! [19:47:17] We can test (locally or on aabooks) to make sure [19:49:13] ejegg: damn.... I dont suppose you have a js code snippet that would reset the impression count? [19:49:45] Ah, so you /* want */ to reset the impression count? [19:49:57] ejegg: yeah :P [19:50:03] But only for certain users, not the whole campaign? [19:50:09] ejegg: correct :P [19:50:28] k, lemme see how that could work... [19:52:22] ejegg: so this is the script currently: http://pastebin.com/CBG7uzv1 [19:52:59] ejegg: its not my code. I basically macguyvered the germans user selection and have tacked on the bucket change [19:53:44] hmm, so it would have to run before the pre-banner mixins, and it would have to make the mixin think there was a 'reset=1' parameter on the URL [19:54:30] lemme see if mw.util.getParamValue can be convinced to use a value from code [19:56:08] phooey, no way to do that [20:00:09] Seddon: not looking pretty - the impressionDiet code doesn't expose any of it's methods, so you'd have to copy a bunch of that code [20:00:56] ejegg: uch :P ok [20:01:06] lemme see... [20:04:47] ejegg: btw this is totally not a high priority so if I have taken you away from something its really something that I can toss on the fire [20:05:09] So, here's the code: http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FCentralNotice.git/master/resources%2Fsubscribing%2Fext.centralNotice.impressionDiet.js [20:05:49] you need to replicate storeCounts, and call it with an object like that from getZeroedCounts() [20:07:22] ah dang, even that's not quite going to work, 'cause you don't have the cookie name from mixinParams... [20:07:29] :( [20:09:02] yeah I think this is gonna be way more complicated than I thought it would be [20:09:42] Seems like a valid request though - I think mixins should get 'force' and 'reset' from central notice state variables that banners can change [20:10:06] then impressionDiet should have a post-banner callback that zeroes counts if the banner set 'reset' [20:16:35] ejegg: yeah I am getting way over my head :P [20:38:59] (PS9) Ejegg: WIP update session handling for 1.27 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/264017 (https://phabricator.wikimedia.org/T123006) [20:41:03] (CR) jenkins-bot: [V: -1] WIP update session handling for 1.27 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/264017 (https://phabricator.wikimedia.org/T123006) (owner: Ejegg) [20:43:14] whaa? [20:43:30] ah man [20:46:37] (PS10) Ejegg: WIP update session handling for 1.27 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/264017 (https://phabricator.wikimedia.org/T123006) [20:47:25] ejegg: i am trying to see if this will be of any use to me MediaWiki:CentralNotice/Resources/BannerShowHideCountDate.js [20:47:39] which is the old method [20:49:21] hmm, is this a new campaign or is it ongoing? [20:49:49] oops, I should relocate for standup [20:50:34] Seddon: if it's an ongoing campaign that uses the mixin, that won't help. If it's a new campaign, you could make a modified version of that with a reset function. [20:51:11] ejegg|afk: itll be a new campaign [20:51:51] not fundraising [21:08:41] ejegg: question, isn't the cookie name set in the campaign? [21:09:32] (PS1) Aaron Schulz: Define doesWrites() for Action classes [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/264345 (https://phabricator.wikimedia.org/T123589) [21:32:18] Hi [21:33:02] I've seen there is a "donator name" (keep in all lower case - remove this note) [21:33:51] In the 15.wp webpage [21:34:12] Should I report it on phabricator? [21:35:36] unauthenticated_: where do you see that? [21:35:50] where on the 15.wp page? [21:36:02] (CR) Siebrand: [C: 1] "i18n/L10n reviewed." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263438 (owner: Mhutti1) [21:36:06] List of contributors, let me find the exact url for you [21:36:45] https://15.wikipedia.org/contributors.html [21:36:56] Sorry, im on mobile [21:37:48] ^search remove on that page [21:37:51] unauthenticated_: no problem! thank you for the report, i will make sure it gets updated [21:38:05] Yw [21:40:48] heh, also (keep in all lower case - remove this note) [21:43:13] cwd if you're making a ticket, I've got a couple more things to add [21:43:31] ejegg: typos on the b-day page? [21:43:38] yah [21:43:40] yeah i just spammed -staff and think i'll make a ticket instead [21:43:45] ah cool [21:48:39] ejegg: want to add to https://phabricator.wikimedia.org/T123794 ? [21:48:51] will do [21:49:21] atgomez: i will pay you to mail me one of those honey stickers [21:49:27] so srs [22:21:26] (CR) Alex Monk: [C: 2] Define doesWrites() for Action classes [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/264345 (https://phabricator.wikimedia.org/T123589) (owner: Aaron Schulz) [22:24:06] (Merged) jenkins-bot: Define doesWrites() for Action classes [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/264345 (https://phabricator.wikimedia.org/T123589) (owner: Aaron Schulz) [23:01:11] heading out to this in a little bit: http://bostonbikeparty.com/