[00:07:59] Reedy: and why they fuck did you leave? he's becoming a pilot they said. I was quite dissapointed to not see you. You missed out on reminiscing about Caaaarrllllll with keegan [00:08:22] Haha [00:08:27] Vaguely something like that [00:08:41] But unfortunately there are some real bastards in the world, and I got somewhat screwed over [00:10:21] If I'd known the shit was going to hit the fan earlier (or, some more prep on my part), I could've come to SF [00:11:30] Now stuff is in somewhat limbo [00:18:44] Reedy: yeah I heard you got fucked over, how long you gonna wait it out? [00:19:08] You heard? I wonder how many people know things? :P [00:19:20] I'm currently waiting for said bastards to reply to my lawyers [00:19:24] Though, it's not looking hopefuly [00:19:28] s/y// [00:22:14] 3.5 months or so of limbo as it stands [00:22:50] Reedy: probably not many people :P I just have good contacts and asked after you :P [00:28:55] I'm gonna be at FOSDEM, maybe Jerusalem, and maybe Wikimania if I can get things in order [11:24:30] (PS1) WMDE-leszek: Update device "selector logic" URL [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/264938 [16:24:05] hey dstrine [16:24:18] the civi meeting you set - eileen can't do a 10am i'm assuming [16:48:09] (PS11) Ejegg: WIP update session handling for 1.27 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/264017 (https://phabricator.wikimedia.org/T123006) [17:10:46] (PS12) Ejegg: WIP update session handling for 1.27 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/264017 (https://phabricator.wikimedia.org/T123006) [17:14:39] Fundraising-Backlog: Amazon: duplicate transaction - only 1 reached Civi - https://phabricator.wikimedia.org/T121920#1944378 (MBeat33) Brick at Amazon reviewed these transactions and summarized: "So these transactions appear normal and would tend to indicate that the donor tried again after an initial declin... [18:19:21] (CR) Ejegg: [C: 2] (backport from 4.7) CRM-17394 - Initialize DB slightly later. Fix query-log and redundant SET NAMES. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256163 (https://phabricator.wikimedia.org/T116724) (owner: Eileen) [18:19:35] (CR) Ejegg: [C: 2] Partial backport of DB initialisation fixes. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/263924 (https://phabricator.wikimedia.org/T116724) (owner: Eileen) [18:33:55] hey ejegg, trying to run tests against the session patch (on hhvm if that matters) and get "DatabaseBase::factory no viable database extension found for type 'mysql'" [18:34:21] i have been screwing with gerrit for like 3 hours so that might have something to do with it [18:34:21] oh huh, I've never seen that one [18:34:36] i _think_ everything is up to date [18:34:40] got all the composer bits? [18:35:09] ooh, or maybe that's a php extension you install as a deb [18:35:39] ah, i was wondering about php5-mysql [18:35:49] i'm confused about how that interacts with hhvm [18:36:02] err, good question [18:36:33] well it works so i'm just going to not worry about it [18:36:36] thanks! [18:36:53] oh, did installing php5-mysql do the trick? [18:37:03] yep [18:37:08] and php5-curl and probably a few more [18:37:21] nice, guess it can load the same extensions [18:37:29] yep [18:37:30] MBeat: I'm chatting with a guy with CC questions. [18:37:35] i guess that makes sense [18:37:36] MBeat: what's your general email? [18:37:44] mbeattie@wiki [18:37:57] what kind of CC questions? [18:38:33] /m MBeat [18:40:46] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Easy: Quotation marks are low on Jimmy quote - https://phabricator.wikimedia.org/T94049#1944666 (Pcoombe) a:Haritha28>Pcoombe It actually requires editing a [[ https://payments.wikimedia.org/index.php?title=Template:Quote&action=edit |... [18:43:17] (PS13) Ejegg: WIP update session handling for 1.27 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/264017 (https://phabricator.wikimedia.org/T123006) [18:51:24] Fundraising-Backlog, fundraising-tech-ops, MediaWiki-extensions-DonationInterface, Easy: Quotation marks are low on Jimmy quote - https://phabricator.wikimedia.org/T94049#1944714 (atgo) [18:58:54] (PS14) Ejegg: WIP update session handling for 1.27 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/264017 (https://phabricator.wikimedia.org/T123006) [19:07:41] Fundraising-Backlog, FR-Astropay: Make a plan for Astropay Spanish-speaking LATAM countries - https://phabricator.wikimedia.org/T124075#1944814 (atgo) NEW [19:07:58] Fundraising-Backlog, FR-Astropay: Make a plan for Astropay Spanish-speaking LATAM countries - https://phabricator.wikimedia.org/T124075#1944814 (atgo) p:Normal>High [19:17:14] Fundraising-Backlog: Create tools to retrieve relevant information from logs in a useful format - https://phabricator.wikimedia.org/T113268#1944877 (CCogdill_WMF) p:Low>Normal Bumping up priority now that we're out of Q2. The early tests we did of this kind of email suggests we are leaving money on the... [19:18:30] (PS15) Ejegg: WIP update session handling for 1.27 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/264017 (https://phabricator.wikimedia.org/T123006) [19:39:28] (PS16) Ejegg: WIP update session handling for 1.27 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/264017 (https://phabricator.wikimedia.org/T123006) [19:40:06] k, definitely need to look at something different for a while [19:42:16] (PS2) Ejegg: CRM-17806 Class-api: Check if constant is defined before defining it [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/263558 (https://phabricator.wikimedia.org/T123333) (owner: Eileen) [19:42:39] (CR) Ejegg: [C: 2] "noclobber!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/263558 (https://phabricator.wikimedia.org/T123333) (owner: Eileen) [19:46:47] (Merged) jenkins-bot: CRM-17806 Class-api: Check if constant is defined before defining it [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/263558 (https://phabricator.wikimedia.org/T123333) (owner: Eileen) [19:50:07] (CR) Ejegg: "We were hoping to use CiviMail for bounce tracking as well as storing the text of the emails to diagnose oddities like the doubled letters" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/261267 (https://phabricator.wikimedia.org/T119560) (owner: Ejegg) [20:07:35] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Lybunt report could be faster - https://phabricator.wikimedia.org/T122024#1945126 (atgo) [20:08:21] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: [EPIC] Lybunt report could be faster - https://phabricator.wikimedia.org/T122024#1945134 (DStrine) [20:11:14] Fundraising-Backlog: Update text on frdata - https://phabricator.wikimedia.org/T123426#1945187 (DStrine) [20:14:56] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: [epic] Make deduping reversible - https://phabricator.wikimedia.org/T111704#1945216 (atgo) [20:16:24] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice impressions beacon corrupts 'mixins' property - https://phabricator.wikimedia.org/T120082#1945245 (awight) [20:16:30] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Scope & plan work for making manual deduplicates reversible. - https://phabricator.wikimedia.org/T124089#1945246 (atgo) NEW [20:17:39] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Create tools to monitor the operation of CentralNotice for targeted groups of users - https://phabricator.wikimedia.org/T122589#1945272 (awight) [20:17:58] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Make banner impression counts available somewhere public - https://phabricator.wikimedia.org/T115042#1713344 (awight) [20:18:00] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Create tools to monitor the operation of CentralNotice for targeted groups of users - https://phabricator.wikimedia.org/T122589#1908274 (awight) [20:20:07] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Make banner impression counts available somewhere public - https://phabricator.wikimedia.org/T115042#1945295 (awight) [20:20:09] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Create tools to monitor the operation of CentralNotice for targeted groups of users - https://phabricator.wikimedia.org/T122589#1945294 (awight) [20:21:16] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Create tools to monitor the operation of CentralNotice for targeted groups of users - https://phabricator.wikimedia.org/T122589#1945303 (DStrine) [20:23:01] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, FR-Smashpig: [Epic] Rename GlobalCollect to Ingenico - https://phabricator.wikimedia.org/T122420#1945330 (awight) [20:27:21] Fundraising-Backlog, FR-GlobalCollect: Must open a new GlobalCollect account in order to escape Order ID apocalypse - https://phabricator.wikimedia.org/T121000#1945378 (awight) [20:27:24] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, FR-Smashpig: Update all references to GlobalCollect in code, determine if we need to update old database entries - https://phabricator.wikimedia.org/T123249#1945377 (awight) [20:28:35] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, FR-Smashpig: Update all references to GlobalCollect in code, determine if we need to update old database entries - https://phabricator.wikimedia.org/T123249#1924572 (awight) We would like to postpone this w... [20:29:50] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Convert PayPal interstitial form from RapidHTML to Mustache - https://phabricator.wikimedia.org/T123001#1945407 (DStrine) [20:29:57] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Convert GlobalCollect forms from RapidHTML to Mustache - https://phabricator.wikimedia.org/T123002#1945409 (DStrine) [20:32:05] Fundraising Sprint Asbestos Removal 2016, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Change any donor-facing GlobalCollect branding to read "Ingenico". - https://phabricator.wikimedia.org/T122597#1945421 (atgo) We need to ask Ingenico about what the cc statements say [20:32:23] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Convert GlobalCollect forms from RapidHTML to Mustache - https://phabricator.wikimedia.org/T123002#1945429 (atgo) p:Triage>Normal [20:32:28] Fundraising Sprint Asbestos Removal 2016, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Change any donor-facing GlobalCollect branding to read "Ingenico". - https://phabricator.wikimedia.org/T122597#1945430 (awight) [20:33:18] Fundraising-Backlog, Epic: [epic] PayPal upgrade - https://phabricator.wikimedia.org/T87621#1945438 (awight) [20:33:21] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Convert PayPal interstitial form from RapidHTML to Mustache - https://phabricator.wikimedia.org/T123001#1945437 (awight) [20:34:06] Fundraising-Backlog, FR-Worldpay: Diagnostics: sent WorldPay the "stringin" logs for a transaction Anne made - https://phabricator.wikimedia.org/T122866#1945441 (awight) [20:34:13] Fundraising-Backlog, FR-Worldpay: Debugging: sent WorldPay the "stringin" logs for a transaction Anne made - https://phabricator.wikimedia.org/T122866#1915558 (awight) [20:35:23] Fundraising-Backlog, FR-Worldpay: Debugging: sent WorldPay the "stringin" logs for a transaction Anne made - https://phabricator.wikimedia.org/T122866#1945452 (DStrine) [20:36:25] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Amazon: Quit looking in pending queue for completion message information - https://phabricator.wikimedia.org/T122641#1945458 (awight) [20:36:48] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Amazon: Quit looking in pending queue for completion message information - https://phabricator.wikimedia.org/T122641#1945464 (DStrine) [20:37:56] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Amazon, FR-Astropay: Quit looking in pending queue for completion message information - https://phabricator.wikimedia.org/T122641#1945471 (awight) [20:41:51] Fundraising-Backlog: PayPal 404 error: mobile and desktop - https://phabricator.wikimedia.org/T122603#1945485 (atgo) Open>declined a:atgo Hey @mbeat33 we're going to assume this will get resolved with the new paypal integration T87621 [20:42:49] Fundraising-Backlog, FR-GlobalCollect: Add Discover card type to Canada iframe options - https://phabricator.wikimedia.org/T122218#1945500 (awight) [20:44:49] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Scope & plan work for making manual deduplicates reversible. - https://phabricator.wikimedia.org/T124089#1945517 (DStrine) [20:44:51] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Merging Feature Needed: "Add New" for mailing addresses - https://phabricator.wikimedia.org/T121691#1945518 (DStrine) [20:45:33] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, FR-GlobalCollect, FR-Smashpig: Rename all references to GlobalCollect in code, to Ingenico. Determine if we need to update old database entries - https://phabricator.wikimedia.org/T123249#1945523 (awight) [20:46:52] Fundraising-Backlog: mobile donation form: expiration date error - https://phabricator.wikimedia.org/T120053#1945538 (atgo) @mbeat33 did you reach out to GC about this? [20:48:24] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-DonationInterface: Spike: Plan how to share more resources between donatewiki, banners, and payments - https://phabricator.wikimedia.org/T119822#1945561 (awight) [20:49:28] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: "The" issue: Contacts with dup records (with and without "The") - https://phabricator.wikimedia.org/T122264#1945565 (atgo) @caitvirtue we'll help come up with a query to surface these, but it'll require at least a manual review and probably manual merging. [20:50:42] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: "The" issue: Contacts with dup records (with and without "The") - https://phabricator.wikimedia.org/T122264#1945567 (Eileenmcnaughton) Quick question - is the s intentional ie The Merck Foundation and Merck Foundations It changes the scope a bit if it is [21:10:52] (CR) Eileen: "this is too slow!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/263578 (owner: Eileen) [21:29:50] Fundraising Sprint Asbestos Removal 2016, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, Patch-For-Review: Do not directly access $_SESSION superglobal in DonationInterface - https://phabricator.wikimedia.org/T123006#1945792 (Ejegg) a:Ejegg [21:35:50] Well, that was fun [21:35:57] We nearly just deployed master of CentralNotice [21:41:03] woohoo! [21:51:21] (PS1) Eileen: CRM-17837 Improve Lybunt report. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/265143 [21:54:04] ejegg: i have been looking into the possibility of getting CI running against 1.25 so we wouldn't necessarily have to support both versions of core, sounds like it might be possible [21:54:16] possible possibility [21:54:19] cwd oh yeah? [21:55:00] still a bunch of stones to overturn but how would you feel about that vs. patching DI? [21:55:17] my feeling is we can fix the false positive regressions by patching [21:55:40] I like the push to modernize, but there are definitely times it would mess us up badly to be unable to deploy small changes [21:55:40] but we could still miss false negatives if CI is running a different version that we develop against and run live [21:56:39] ejegg: what do you mean by that? unable to deploy small changes? [21:56:41] Well, we could still have the tests run against latest core in a non-voting job, right? [21:56:53] ejegg: that would be my preference for sure [21:57:20] cwd I mean, as it is now we have to fix things to work with 1.27 before we can merge ANYTHING, even if we had an emergency fix for 1.25 [21:57:49] ejegg: ah yes indeed [21:58:08] it does sound to me like fixing it on CI would be the most sustainable solution [21:58:18] and an advisory role for 27 [21:58:18] so yeah, doing CI against our deployed version would be great [21:58:38] ok, i'm going to file a ticket and see if i can get some more solid info [21:58:59] also increasing the bus factor on CI probably isn't a bad thing :) [21:59:21] nice [21:59:24] (CR) Eileen: "I'm still testing this out myself...." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/265143 (owner: Eileen) [21:59:24] ejegg: this is what i've been looking at https://www.mediawiki.org/wiki/Continuous_integration/Jenkins_job_builder [22:02:05] so we'd split DonationInterface out of mediawiki-extensions.yaml [22:02:58] i think so? [22:11:40] looks like we'd have to convince zuul-cloner to fall back to a different branch of core than master [22:12:38] Note that you can experiment with changing the job directly, by logging into https://integration.wikimedia.org/ci/ with your LDAP account [22:12:53] ah, cool [22:14:46] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Jenkins: CI: test DonationInterface against fundraising/REL1_25 - https://phabricator.wikimedia.org/T124105#1945950 (cwdent) NEW [22:15:19] oh neat [22:15:28] (PS2) Eileen: CRM-17837 Improve Lybunt report. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/265143 [22:16:05] if we can pass it --project-branch mediawiki/core=fundraising/REL1_25 that might do the trick [22:17:13] man i hope it's that simple [22:17:33] i made that ticket just now ^ [22:20:21] hmm, looks like we'd have to do another "# Evil copy paste of `zuul-cloner` macro" [22:23:39] ejegg: where do you see that comment? [22:23:59] grepped for zuul-cloner, saw that in mediawiki.yaml [22:24:31] aah ha [22:24:39] in integration/config repo, jjb dir [22:25:27] * cwd isn't sure what an experimental extension is [22:38:59] i have to run an errand, back in a bit [22:49:23] (PS3) Eileen: CRM-17837 Improve Lybunt report. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/265143 [22:50:16] atgomez: dstrine: hi! when is a good time to IRC chat about some stuff in this beautifully named sprint? [22:50:47] I'm still slogging through backlogged phabspam but I can pause and restart that whenever [22:51:22] https://phabricator.wikimedia.org/T121042 was in the "Done" column in the last sprint [22:51:49] IIRC there's a different card for follow-up on that one [22:52:15] AndyRussG: move any to the appropriate column [22:52:33] If you are looking for new work, there is a ton of stuff in review. [22:53:09] Also the backlog still has a decent amount [22:53:36] dstrine: ah K great :) any sense on what's most urgent in review, or should I just look at priority settings? [22:54:01] yea https://phabricator.wikimedia.org/T120017 is also done [22:54:49] dstrine: the only one that's really undone and is in the Asbestos backlog is https://phabricator.wikimedia.org/T120058 [22:54:56] (of the 3 assigned to me) [22:58:34] (PS3) Ejegg: (proposed for 4.7) CRM-17439 layout changes for advanced search panes [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/263310 (https://phabricator.wikimedia.org/T120332) (owner: Eileen) [22:59:06] (CR) Ejegg: [C: 2] "Looks good to me, and it's merged upstream" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/263310 (https://phabricator.wikimedia.org/T120332) (owner: Eileen) [23:00:37] Fundraising-Backlog, Wikimedia-Fundraising, Analytics: Public dashboards for CentralNotice and Fundraising - https://phabricator.wikimedia.org/T88744#1946085 (AndyRussG) Somewhat related: T122589 [23:01:05] (CR) Eileen: "Yep - it can get a bit confusing merging it into 2 places - upstream & WMF - I generally do a bit more in the upstream one (e.g add tests " [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/263310 (https://phabricator.wikimedia.org/T120332) (owner: Eileen) [23:02:22] (PS4) Eileen: CRM-17837 Improve Lybunt report. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/265143 [23:02:27] (Merged) jenkins-bot: (proposed for 4.7) CRM-17439 layout changes for advanced search panes [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/263310 (https://phabricator.wikimedia.org/T120332) (owner: Eileen) [23:05:43] (PS9) Ejegg: (patch already in 4.7) CRM-17640 Update contribution api to do a sensible query when getcount is being invoked [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256241 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [23:08:04] Fundraising-Backlog: mobile donation form: expiration date error - https://phabricator.wikimedia.org/T120053#1946154 (MBeat33) Sorry for not updating this sooner, @atgo. GC first replied that the error was due to not specifying a month, but when we documented donors (mobile and one on desktop) who got this e... [23:09:47] (CR) Ejegg: [C: 2] "Query looks better than before, and this lays the groundwork for improving getcount on all the other entities." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256241 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [23:12:24] (CR) Eileen: "Fortunately most other entities were already OK - I think 2 or 3 others which were not critical to wmf were affected - possibly pledge & p" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/256241 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [23:16:41] (PS5) Eileen: CRM-17837 Improve Lybunt report. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/265143 [23:21:27] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Zapp, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: Impression and donation numbers are looking weird for mobile campaign - https://phabricator.wikimedia.org/T121042#1946202 (AndyRussG) Open>Res... [23:26:26] Does anyone have the friendly link to Asbestos? [23:27:16] AndyRussG: https://phabricator.wikimedia.org/project/sprint/board/1697/ [23:27:51] cwd: thanks!! [23:28:05] :) [23:33:01] (PS6) Eileen: CRM-17837 Improve Lybunt report. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/265143 [23:49:44] (PS7) Eileen: CRM-17837 Improve Lybunt report. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/265143