[03:49:55] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Create an alert for suspicious dips in banner impressions - https://phabricator.wikimedia.org/T116047#1951146 (AndyRussG) [03:49:57] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: [Epic] Analytics, graphs and monitoring for banners and CentralNotice - https://phabricator.wikimedia.org/T124132#1951145 (AndyRussG) [03:51:30] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-Translate, I18n: Can't use Translate extension's variables feature in CentralNotice - https://phabricator.wikimedia.org/T87448#1951147 (AndyRussG) [03:54:08] Fundraising-Backlog, Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Epic, and 3 others: Special:RecordImpression should die in a fire - https://phabricator.wikimedia.org/T45250#1951150 (AndyRussG) [03:57:31] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Easy: Write API for campaign creation and use it to create browser test fixtures - https://phabricator.wikimedia.org/T107376#1951153 (AndyRussG) [04:02:02] Fundraising-Backlog, Wikimedia-Fundraising, Analytics: Public dashboards for CentralNotice and Fundraising - https://phabricator.wikimedia.org/T88744#1951155 (AndyRussG) [04:02:04] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: [Epic] Analytics, graphs and monitoring for banners and CentralNotice - https://phabricator.wikimedia.org/T124132#1951154 (AndyRussG) [04:03:26] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: [Epic] Analytics, graphs and monitoring for banners and CentralNotice - https://phabricator.wikimedia.org/T124132#1946773 (AndyRussG) [14:51:16] Fundraising Sprint Asbestos Removal 2016, Fundraising-Backlog: Other amount in WMF donation form: error message unclear - https://phabricator.wikimedia.org/T118741#1951787 (Pcoombe) @atgo No, it's still a banner issue [15:00:12] Fundraising Sprint Asbestos Removal 2016, Fundraising-Backlog, Wikimedia-Fundraising: Other amount in WMF donation form: error message unclear - https://phabricator.wikimedia.org/T118741#1951989 (Pcoombe) [15:44:17] Fundraising Sprint Asbestos Removal 2016, Fundraising-Backlog, Wikimedia-Fundraising: Other amount in WMF donation form: error message unclear - https://phabricator.wikimedia.org/T118741#1952171 (atgo) Ok @pcoombe I'm going to remove #fundraising-backlog for now. If it becomes an fr-tech thing please... [15:44:28] Fundraising Sprint Asbestos Removal 2016, Wikimedia-Fundraising: Other amount in WMF donation form: error message unclear - https://phabricator.wikimedia.org/T118741#1952174 (atgo) [16:21:33] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Change any donor-facing GlobalCollect branding to read "Ingenico". - https://phabricator.wikimedia.org/T122597#1952307 (Ejegg) Got a reply: > Our legal entit... [16:48:09] Fundraising Sprint Yo La Tengo, Fundraising Sprint Zapp, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Spike [2 hours]: QuickSurveys deployment process - https://phabricator.wikimedia.org/T119632#1952431 (AndyRussG) Quick question: what new Phabricator tasks (if any) exist to track... [16:57:35] mornin' cwd [16:57:53] howdy! [16:58:23] thinking bout hitting the gas with the session refactor? [16:59:16] yeah, I'm game to deploy today if the patches look good [17:01:08] cool, yeah i've been messing with it and haven't turned up anything yet, mind if i give it a few more minutes? [17:01:22] sure, take your time. it's early yet [17:02:17] i'm still rebuilding some bits of my dev env [17:02:35] keep running across something broken [17:02:36] ah, man, for like the third time,right? [17:03:42] at least! [17:03:49] but my last one was the longest lived [17:03:54] accumulated a lot of details [17:17:39] Fundraising-Backlog, fundraising-tech-ops, MediaWiki-extensions-DonationInterface, Easy: Quotation marks are low on Jimmy quote - https://phabricator.wikimedia.org/T94049#1952485 (Pcoombe) Open>Resolved This is done ([[ https://payments.wikimedia.org/index.php?title=Template:Quote&diff=prev&... [17:31:26] ejegg: tried to run the tests against core/master -- ever seen this? PHP Fatal error: Call to undefined function MediaWiki\suppressWarnings() in /srv/core/maintenance/Maintenance.php on line 1021 [17:31:41] aargh, yeah. Lemme see [17:32:32] vendor/mediawiki/at-ease/src/Functions.php:function suppressWarnings( $end = false ) [17:32:37] composer update? [17:32:46] with dev [17:33:56] aah yeah lemme try that [18:21:42] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Improve security of UKFC data transfers - https://phabricator.wikimedia.org/T124315#1952703 (CaitVirtue) NEW [18:34:51] (CR) Cdentinger: [C: 2] "I am no longer afraid." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/265367 (https://phabricator.wikimedia.org/T123006) (owner: Ejegg) [18:35:36] lenny bruce is not afraid [18:36:16] :) [18:36:27] Thanks for the scrutiny! [18:36:51] you bet! i think it's good, quite a few incidental improvements imo [18:37:56] Thanks! Ideally we'd move all those session_ functions out of gateway adapter [18:38:00] ejegg: when do you want to deploy this? i was going to head afk for awhile shortly, if you want to wait for the afternoon i'll be happy to watch logs and stuff [18:38:09] (Merged) jenkins-bot: Update session handling for 1.27 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/265367 (https://phabricator.wikimedia.org/T123006) (owner: Ejegg) [18:38:32] Sure, maybe right after the all-FR retro? [18:38:55] that starts in an hr, so deploy 2 hrs from now? [18:39:26] (CR) Mhutti1: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263438 (owner: Mhutti1) [18:39:44] yeah sounds good! i'd like to try rolling the merges with frig if that's cool with you [18:40:15] ah cool, I like it! [18:40:44] (CR) Ejegg: "try one more rebase - we just merged a patch we needed to work with some recent core changes" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263438 (owner: Mhutti1) [18:41:13] all it will do so far is merge a dev branch into a deploy branch, and update a submodule and commit [18:41:21] leaves all the gerrit stuff up to the user [18:41:30] well, that's saving some time at least [18:41:42] yeah, starting to chip away at the rote stuff [18:41:59] and stuff that i have fat fingered before [18:43:08] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Astropay: Prepare logos for AstroPay LATAM banks and cards - https://phabricator.wikimedia.org/T124320#1952786 (Ejegg) NEW [18:53:42] (PS9) Mhutti1: Changed wording of donate_interface-informationsharing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263438 [18:56:09] (CR) Mhutti1: "Great :) Thanks for fixing the test so quickly." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263438 (owner: Mhutti1) [19:04:20] wikibugs? [19:07:40] i'm gonna go plant myself somewhere with food for th' retro [20:03:34] Fundraising Sprint Asbestos Removal 2016, Fundraising-Backlog, Unplanned-Sprint-Work: Generate PGP key and exchange with Coinbase - https://phabricator.wikimedia.org/T124251#1953128 (LeanneS) @awight Sounds good! I'll put something on our calendars for early next week. [22:37:19] (PS3) Eileen: (merged into 4.7) CRM-17751 add api support for setting the trxn_id for a refund [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/263314 (https://phabricator.wikimedia.org/T116317) [22:39:23] (CR) Eileen: "new version pushed with merge issue fixed." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/263314 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [22:44:39] (CR) Ejegg: [C: 2] "Lol @ 'natural justice'. Survival of the fittest API params!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/263314 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [23:04:12] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/263314 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [23:09:00] (CR) Cdentinger: [C: 2] "Definite progress towards sanity." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/265390 (https://phabricator.wikimedia.org/T123006) (owner: Ejegg) [23:14:25] (CR) Cdentinger: [C: 2] $_SESSION cleanup: Worldpay adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/265389 (https://phabricator.wikimedia.org/T123006) (owner: Ejegg) [23:14:58] ejegg: you about to get snowed in or are you far enough north? [23:15:16] ooh, I should check the forecast again [23:15:37] i'm jealous [23:15:40] i love a good blizzard [23:16:30] Wikimedia-Fundraising-CiviCRM: The Family Foundation: find total value of relationships - https://phabricator.wikimedia.org/T124368#1953917 (DStrine) NEW [23:17:31] they're saying it'll pass south of Boston now - we'll just get a dusting on saturday [23:19:14] ejegg: i just noticed these patches i've been reviewing aren't merging. i don't see the submit button... [23:19:43] cwd I think you might have started from the top of the stack - i had them all depend on each other [23:19:56] ooh of course [23:20:01] * cwd gets back to it [23:22:30] ejegg eileen dstrine atgomez1 here’s that task T122411 [23:26:25] Fundraising-Backlog: Civi should allow users to do email address changes that are communicated to Silverpop - https://phabricator.wikimedia.org/T122411#1953983 (CCogdill_WMF) p:Low>Normal Changing priority because this is continuing to be very time consuming! [23:27:16] Fundraising-Backlog: Civi should allow users to do email address changes that are communicated to Silverpop - https://phabricator.wikimedia.org/T122411#1953991 (Ejegg) Could do this with audit logging, but we're not sure if we'll be able to use that. Otherwise we could add an edit hook that adds the deleted... [23:28:54] (CR) Cdentinger: [C: 2] $_SESSION cleanup: GatewayPage [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/265385 (https://phabricator.wikimedia.org/T123006) (owner: Ejegg) [23:33:36] (CR) Cdentinger: [C: 2] $_SESSION cleanup: Amazon adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/265381 (https://phabricator.wikimedia.org/T123006) (owner: Ejegg) [23:34:31] (Merged) jenkins-bot: $_SESSION cleanup: Amazon adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/265381 (https://phabricator.wikimedia.org/T123006) (owner: Ejegg) [23:38:45] I think I might deploy those pending Civi fixes.... [23:38:59] at least the search pane one will be much awaited! [23:39:17] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Criteria Sort in Advanced Search results doesn't work - https://phabricator.wikimedia.org/T118614#1954051 (MBeat33) This sort functionality would be great to have switched on for Donor Services. Searching for donors with non-unique names is something we... [23:41:56] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Criteria Sort in Advanced Search results doesn't work - https://phabricator.wikimedia.org/T118614#1954067 (Eileenmcnaughton) So this is actually just a thing we can turn on in the UI and turn off again if it causes problems. So I guess the main thing is... [23:42:26] dstrine: Re https://phabricator.wikimedia.org/T118614 - is the right list to email fr-online? [23:43:39] eileen: yeah sure [23:43:55] cool [23:44:38] ejegg: are you OK with merging this one? https://gerrit.wikimedia.org/r/#/c/258918/ (you looked at it before & suggested extending the scope but I am inclined to leave the extended scope upstream (where it is) and not extend it in our repo at this stage [23:45:08] oh yeah, lemme take one more look at it [23:45:15] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Criteria Sort in Advanced Search results doesn't work - https://phabricator.wikimedia.org/T118614#1954077 (MBeat33) thank you! [23:45:47] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising-Backlog: Some Globalcollect donations not in Civi - https://phabricator.wikimedia.org/T122730#1954080 (cwdent) @atgo I still don't see any of those order IDs in the WR1 files. I'll poke them about it. [23:55:32] eileen: oh right, I was worried about triggering warnings in getFields for non-Contribution entities [23:56:59] ejegg: does that patch cause that? or is it just not fixed for them? [23:58:21] It looks like it might, since it calls $bqr->getFields with a param that doesn't exist for most entity query objects [23:58:42] but I havent figured out exactly where to go in the UI to trigger that [23:58:50] (CR) Cdentinger: [C: 2] "I don't know much about this file but these are very linear changes." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/265384 (https://phabricator.wikimedia.org/T123006) (owner: Ejegg) [23:59:06] the golden spike! [23:59:44] (Merged) jenkins-bot: $_SESSION cleanup: session_velocity filter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/265384 (https://phabricator.wikimedia.org/T123006) (owner: Ejegg)