[00:00:26] (CR) AndyRussG: "recheck" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/265829 (https://phabricator.wikimedia.org/T120082) (owner: AndyRussG) [00:01:09] cwd: have u ever heard of a donate skin? [00:01:41] K4-713: ^ ? [00:01:47] AndyRussG: no...like a mediawiki skin? [00:01:58] on donate wiki? [00:02:07] causing some funny error on CI [00:02:38] AndyRussG: No idea. [00:02:44] Hm! [00:02:55] K4-713: cwd: thx ;) [00:05:02] cwd: K4-713: if ur curious this is on wikimedia-releng [00:05:25] Sadly, I can't get involved, because I am (totally unsurprisingly) in a meeting. [00:08:01] K4-713: np was just asking mainly out of curiosity :) ... have fun!!!! [01:22:05] merry weekend friends! [01:22:16] You too [02:04:52] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Zapp, Fundraising-Backlog, and 2 others: Civi exports timing out - https://phabricator.wikimedia.org/T120892#1958633 (Eileenmcnaughton) Note: the failing query is donors who've given at least $1,000 s... [02:25:17] Fundraising-Backlog: Fully retire Donate skin - https://phabricator.wikimedia.org/T124519#1958656 (AndyRussG) NEW [02:31:38] Fundraising-Backlog: Fully retire Donate skin - https://phabricator.wikimedia.org/T124519#1958684 (AndyRussG) [03:47:44] Hi eileen, yt? I'm trying to add some test data to smoke test Elliot's patch... Keep getting this error: " [03:47:44] Notice: Undefined index: payment_submethod in wmf_civicrm_get_message_payment_instrument() (line 656 of /vagrant/srv/org.wikimedia.civicrm/sites/all/modules/wmf_civicrm/wmf_civicrm.module). [03:47:44] Unknown import error: Import aborted due to error at row 2: INVALID_MESSAGE Cannot create contribution, civi error! Source: '\'Carl TEST Perry\' is not a valid option for field custom_28', after 0 records were stored successfully, 0 were ignored, and 0 duplicates encountered." [03:48:04] Any thoughts? [03:48:32] P.S. Apologies for bothering you on the weekend, pls ignore for any reason whatsoever ;p [03:48:37] AndyRussG: hey [03:49:01] I've been doing a bit of work today actually because I had a disrupted start to the week & the kids aren't here [03:49:17] (& I just wanna close some shit out) [03:49:21] Ah heh I know the feeling :) [03:49:36] re the message - the custom field (28) will have a set of valid option values [03:49:43] (configured through the UI) [03:50:50] I just was trying to import some test donation entries as per ejegg's suggestion. I took the engage.csv file, removed all but the first three entries, and changed all the dates to recent [03:51:01] Beyond that I truly have no idea what's going on 8p [03:51:07] :-) [03:51:19] So the field is no 28 [03:51:28] sites/all/modules/offline2civicrm/test_data/engage.csv [03:51:54] By what numbering scheme? Is that the ordering of the fields expected from the csv file? [03:52:29] tI don't see that file on my local - is that in the patch? [03:54:39] No... I'm using vagrant [03:55:11] AndyRussG: which ticket / gerrit? [03:55:31] https://gerrit.wikimedia.org/r/#/c/261267/ [03:55:51] Here's the file I'm trying to import [03:56:28] ejegg suggested importing some data then running the drush ty job to smoke test the sample rate setting [03:56:52] The code does seem straightforward but I'm generally inclined to see it work [03:56:58] :-) [03:57:12] did you paste a link to the file? I don't see it [03:57:19] Ah uuups [03:57:21] https://tools.wmflabs.org/paste/view/6cccbc95 [03:57:30] that was copy-no-paste [03:58:55] So, if you do SELECT custom_group_id, name FROM civicrm_custom_field WHERE id = 28; you should get the id & name of the field that it's borking on [03:59:40] & from civicrm/admin/custom/group?reset=1 you can see the group & drill down to the custom field & check the options available for it [04:00:18] (prior to 4.6 the custom data wasn't validated but from 4.6 it is so a csv that worked on 4.2 might have been 'getting away with' invalid data) [04:00:32] Ah hmm K [04:00:48] I was selecting "engage" as the file format [04:00:57] Maybe I need to kill the header [04:01:32] THis is the error in it '\'Carl TEST Perry\' is not a valid option for field custom_28', [04:02:05] I don't know which column custom_28 is because it will vary between installs [04:06:55] Hmmm [04:07:39] Maybe the format has changed since the test file was created [04:13:32] SELECT * FROM civicrm_custom_field WHERE id = 28; [04:13:32] +----+-----------------+--------+--------------------+-----------+-----------+---------------------+-------------+---------------+-----------------+--------+- [04:13:32] | id | custom_group_id | name | label | data_type | html_type | default_value | is_required | is_searchable | is_search_range | weight | [04:13:32] +----+-----------------+--------+--------------------+-----------+-----------+---------------------+-------------+---------------+-----------------+--------+- [04:13:32] | 28 | 2 | Appeal | Direct Mail Appeal | String | Select | spontaneousdonation | 1 | 1 | 0 | 1 | [04:13:34] +----+-----------------+--------+--------------------+-----------+-----------+---------------------+-------------+---------------+-----------------+--------+- [04:13:36] 1 row in set (0.00 sec) [04:13:53] The field is "Appeal" [04:16:13] Hmmm that's really wonky... That is the field that that data is in, in the csv file rrrrg [04:21:09] AndyRussG: yep - the data is in that field - but if you go through the UI to configure that field (civicrm/admin/custom/group?reset=1 ) you will see the valid values for the field [04:23:03] eileen: Hmmm I don't see that field mentioned there [04:23:28] AndyRussG: that link is a list of custom groups - look in the group Gift Data [04:23:41] civicrm/admin/custom/group/field?reset=1&action=browse&gid=2 [04:23:41] Ahhh right silly me [04:24:24] on the Direct Mail Appeal field you'll see Edit multiple choice options [04:24:42] on 4.2 ANY data was accepted, in 4.6 only valid options are accepted [04:25:00] which is why the file you have probably worked in the past [04:25:09] eileen: Ah OK got it [04:25:30] :-) [04:25:33] Yeah I was going to say, I just blanked the field, but then I got a similar error with another one [04:25:40] So yea that makes sense now [04:28:17] yeah - it's an upgrade change - it's caught us in a few places - although it's not necessarily a bad change [04:29:55] Hmmm I add an option but then it doesn't show up on the list of options... [04:31:37] K even though I couldn't see the option I added, the import worked.... Or, it said "Successfull import". Even though I got errors like this for each row: "Notice: Undefined index: payment_submethod in wmf_civicrm_get_message_payment_instrument() (line 656 of /vagrant/srv/org.wikimedia.civicrm/sites/all/modules/wmf_civicrm/wmf_civicrm.module). [04:31:37] Notice: Undefined variable: campaignKey in wmf_campaigns_civicrm_custom() (line 260 of /vagrant/srv/org.wikimedia.civicrm/sites/all/modules/wmf_campaigns/wmf_campaigns.module)." [04:38:12] AndyRussG: you could also try to sample data from dash - i think there are instructions in the readme [04:39:07] ejegg|away: hey! thx :) It seems that even with those errors, it did import some data! [04:39:24] oh cool! [04:39:26] Now running the ty job, getting an error for each row [04:39:44] Permission denied RenderTranslatedPage.php:72 [warning] [04:39:44] WD make-thank-you: en -- Could not open [error] [04:39:44] /vagrant/srv/org.wikimedia.civicrm/sites/all/modules/thank_you/generators/../templates/html/thank_you.en.html for writing! [04:41:09] Ah I think it's a vagrant permissions issue, lemme try fixing permissions outside vag [04:41:11] rant [04:44:27] Ah K fixing the permissions outside vagrant worked [04:47:35] ejegg|away: now where would I see which sent e-mails got saved? [04:50:52] Harrrrg I think it may not actually have generated the contacts, even tho it imported the donations? [04:53:54] K I'll hack about some more another time... thanks so much!! cheers :) [04:54:58] sorry,that i don't know - maybe /var/spool/mail ? [04:59:55] ejegg|away: I think it somehow didn't create any contacts, so didn't send e-mails? Don't see any contacts on my civicrm dashboard [05:01:39] Cya! thanks again :) [11:21:16] (CR) Umherirrender: Pass jshint and add it to 'npm test' command (1 comment) [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/262703 (https://phabricator.wikimedia.org/T63599) (owner: Hashar) [19:11:30] (PS1) Ejegg: Send cardholder name to Adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/265936 (https://phabricator.wikimedia.org/T124230) [19:12:31] (CR) jenkins-bot: [V: -1] Send cardholder name to Adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/265936 (https://phabricator.wikimedia.org/T124230) (owner: Ejegg) [19:15:19] (PS2) Ejegg: Send cardholder name to Adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/265936 (https://phabricator.wikimedia.org/T124230) [19:16:11] Fundraising Sprint Bloodletting 2016, Fundraising-Backlog, FR-Adyen, Patch-For-Review: Pass cardholder name to Adyen iframe - https://phabricator.wikimedia.org/T124230#1959167 (Ejegg) Maybe leave it visible but pre-populated to allow the donor to change it if necessary? [19:17:13] (PS2) Ejegg: Omitted line from RequestContext cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263922 [19:18:05] (CR) jenkins-bot: [V: -1] Omitted line from RequestContext cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263922 (owner: Ejegg) [19:59:20] (PS1) Ejegg: Can't use getPersistedSessionId any more [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/265941 [20:01:48] (PS3) Ejegg: Send cardholder name to Adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/265936 (https://phabricator.wikimedia.org/T124230) [20:02:16] (PS2) Ejegg: Simplify session_hasDonorData [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/265556 [20:03:58] (PS3) Ejegg: Omitted line from RequestContext cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263922 [20:04:40] (CR) Ejegg: [V: 2] Make landing page parameters case-insensitive [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/263679 (https://phabricator.wikimedia.org/T114010) (owner: Ejegg)