[15:51:00] !log updated DjangoBannerStats from a64fe0e373a978d3df0b7f1dd74ac4cc5c78d34e to 71df14d4d8b11f3ca0ef1eeb6c6e2db9be79103a [15:51:02] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [15:55:30] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, and 4 others: Track email clickthroughs on donate wiki - https://phabricator.wikimedia.org/T114010#1961895 (Ejegg) Hi @CCogdill_WMF! I just deployed th... [16:02:48] (PS2) Ejegg: Can't use getPersistedSessionId any more [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/265941 [16:02:50] (PS3) Ejegg: Simplify session_hasDonorData [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/265556 [16:03:43] (PS4) Ejegg: Omitted line from RequestContext cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263922 [16:04:06] (PS4) Ejegg: Send cardholder name to Adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/265936 (https://phabricator.wikimedia.org/T124230) [16:29:17] Fundraising-Backlog: Matching Gifts search link gives proxy error - https://phabricator.wikimedia.org/T124666#1961995 (MBeat33) NEW [16:35:29] Howdy cwd! [16:35:39] mornin! [16:35:59] Did you have ha good weekend? [16:36:03] *have [16:36:09] *a [16:36:17] oh yeah real good [16:36:25] fun football game yesterday :D [16:36:33] aww, man [16:36:49] I blame the altitude [16:37:28] srsly though, that defence was impressive [16:37:47] *defense [16:37:47] yeah it was a really exciting game, right up to the last 10 seconds [16:38:06] Coulda been very different without that missied point [16:38:10] if that 2 point conversion had happened i bet the pats would have won in overtime [16:38:32] ehh, they were struggling the whole time, who knows how it would have gone [16:38:56] but yeah i think they said it was dude's first missed extra point in 9 seasons? [16:38:58] brutal [16:39:19] yah, only the 2nd of his career. he'd gotten like 500 straight [16:39:37] so, guess what happened with 1.27 over the weekend [16:40:05] wow [16:40:13] yeah i saw they had to roll back cause of session issues? [16:40:23] oh really? [16:40:46] I gotta catch up on email / ops news [16:41:01] yeah... i think .11 rolled back to .10 [16:41:06] why, what were you gonna say? [16:41:08] I just saw they removed a function in SessionManager that broke our tests again [16:41:24] so... that CI work is definitely relevant [16:41:52] haha damn it [16:42:07] With the current 1.27 code, I can't see any good way to check whether a session is already active [16:42:10] well that's a good excuse to prioritize it anyway [16:42:50] so I just nuked session_exists, which we were hardly using anyway: https://gerrit.wikimedia.org/r/#/c/265941/2 [16:43:10] i'm gonna try setting up jjb then, adam made it sound like you can still get useful command output without setting up the entire CI infrastructure [16:43:23] oh cool [16:44:46] also, more progress on Adyen AVS stuff. looks like we can get the info we need to auto-capture totally innocent looking charges and leave the shady-looking ones open for manual review. Deets here: https://phabricator.wikimedia.org/T122244 [16:45:13] lmk if the proposed changes sound good [16:45:29] oh neat [16:45:40] so...session setup won't complain if there's already one? [16:46:20] ooh, I probably need to update WmfFramework.drupal... [16:47:14] I have WmfFramework.mediawiki::setupSession checking for a cookie before it calls wfSetupSession (under 1.25) [16:47:42] Under 1.27, we're calling SessionManager::getGlobalSession()->persist(), which should be fine to repeat [16:48:24] ooh i see, i misread that line [16:48:28] * cwd makes more coffee [16:48:44] heh [16:49:08] yeah that seems like a safer setup in general [16:49:48] (PS3) Cdentinger: Can't use getPersistedSessionId any more [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/265941 (owner: Ejegg) [16:49:55] (CR) Cdentinger: [C: 2] Can't use getPersistedSessionId any more [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/265941 (owner: Ejegg) [16:51:11] (Merged) jenkins-bot: Can't use getPersistedSessionId any more [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/265941 (owner: Ejegg) [16:52:55] (PS1) Ejegg: Fix WmfFramework::setupSession under drupal [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266254 [17:04:12] Fundraising-Backlog: Matching Gifts search link gives proxy error - https://phabricator.wikimedia.org/T124666#1962114 (Pcoombe) The entire https://www.matchinggifts.com/ domain appears to be down. Renee has their contact details, but she doesn't seem to be on Phabricator. I'll drop her an email. [17:16:59] Fundraising-Backlog: Matching Gifts search link gives proxy error - https://phabricator.wikimedia.org/T124666#1962138 (Pcoombe) Update: It appears only their secure site (which we use) is down. http://www.matchinggifts.com is still up. [17:22:42] (CR) Ejegg: [C: 2] "Looks good! No need for !vendor, this extension has no composer dependencies" [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/262703 (https://phabricator.wikimedia.org/T63599) (owner: Hashar) [17:23:37] (PS2) Ejegg: Remove mixin param from /beacon/impression calls [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/265829 (https://phabricator.wikimedia.org/T120082) (owner: AndyRussG) [17:24:44] (CR) Paladox: "Thanks." [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/262703 (https://phabricator.wikimedia.org/T63599) (owner: Hashar) [17:24:48] (CR) Ejegg: [C: 2] "cleanForURLSerialization now working as advertised!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/265829 (https://phabricator.wikimedia.org/T120082) (owner: AndyRussG) [17:27:05] (Merged) jenkins-bot: Remove mixin param from /beacon/impression calls [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/265829 (https://phabricator.wikimedia.org/T120082) (owner: AndyRussG) [17:33:21] (CR) Ejegg: "Test look good! Just curious about the @after and @throws annotations" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/265861 (owner: Eileen) [17:58:43] (CR) AndyRussG: "Thanks!! :)" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/265829 (https://phabricator.wikimedia.org/T120082) (owner: AndyRussG) [18:41:17] (CR) MtDu: "@martineznovo," [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/266064 (https://phabricator.wikimedia.org/T108259) (owner: MtDu) [18:42:41] hi awight! [18:46:25] ejegg: oh hey! [18:46:32] I've been... submerged [18:47:00] how's the family? [18:47:29] great, thanks! Mari accidentally calls me mommy again, which is the highest form of flattery. [18:50:43] hehe [19:27:09] ejegg: shall I just +2 your Civi mail sample rate patch? I haven't been able to smoke test, but the code looks fine [19:27:21] Sure, thanks! [19:27:32] K! :) [19:28:42] (CR) AndyRussG: [C: 2] "Weeeee ;)" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/261267 (https://phabricator.wikimedia.org/T119560) (owner: Ejegg) [19:30:42] (Merged) jenkins-bot: Add sample rate for thank_you CiviMail activities [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/261267 (https://phabricator.wikimedia.org/T119560) (owner: Ejegg) [19:36:25] (PS1) Ejegg: Quit double-staging Adyen data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266293 [19:47:31] (PS1) Ejegg: Add risk score to Adyen queue messages. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266295 (https://phabricator.wikimedia.org/T122244) [19:49:04] Fundraising-Backlog: Civi: can the Change Log be used to recover contribs that have been inadvertently deleted? - https://phabricator.wikimedia.org/T124695#1963062 (MBeat33) NEW [20:03:40] (CR) Martineznovo: "cellpadding tells the table to apply that padding to all individual cells." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/266064 (https://phabricator.wikimedia.org/T108259) (owner: MtDu) [20:36:04] Fundraising Sprint Asbestos Removal 2016, Fundraising-Backlog: Generate PGP key and exchange with Coinbase - https://phabricator.wikimedia.org/T124251#1963284 (awight) This is complete and we've confirmed that @LeanneS can decrypt files. The last remaining step is to check the fingerprint using an indepe... [20:37:29] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising-Backlog: Generate PGP key and exchange with Coinbase - https://phabricator.wikimedia.org/T124251#1950399 (awight) [20:43:06] cwd: in https://github.com/caseydentinger/frig/blob/master/README.md, what exactly is meant by "push it up and approve" ? Is the only command-line step that's omitted git review? [20:43:14] Also, how do I code comment in Github? [20:43:58] (CR) Eileen: "I stand by @throws - this is a good annotation that my IDE adds. .after is a mistake - also added by my IDE - I'll remove that" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/265861 (owner: Eileen) [20:44:38] AndyRussG: yeah exactly, i decided to keep it uncoupled to gerrit [20:44:47] in the hopes of moving to phab i guess [20:45:04] AndyRussG: you should just be able to click on the line number to comment [20:45:15] AndyRussG: it's annoying, you can only comment on patches I believe [20:45:30] Ah hm K [20:45:32] thx! [20:45:36] Mmm nothing like Gerrit! [20:46:21] awight: ah yeah that's right [20:46:26] AndyRussG: try https://github.com/caseydentinger/frig/commit/3c964980e5b539aaca62f4aa8b773ffddcc42a92 [20:46:47] cwd: cool thx! [20:47:16] hrmmm [20:47:21] questionably useful diff [20:47:59] The Gerrit design colours are so much prettier ;) [20:48:43] Really all UIs should just copy Gerrit and forget any other attempts at "design" [20:49:17] hehe, the gerrit UI makes you go oh cute it's from the 90s...psych! everything is lazy loaded and brittle [20:49:36] crunch crunch! [20:49:42] (PS3) Eileen: Civi46 add install functions test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/265861 [20:50:20] (PS4) Ejegg: Civi46 add install functions test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/265861 (owner: Eileen) [20:51:23] (CR) Ejegg: [C: 2] "Thanks for the tests! Sorry if my pickiness about non-functional things is annoying." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/265861 (owner: Eileen) [20:52:07] (CR) Eileen: "Nope - go ahead & be picky!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/265861 (owner: Eileen) [20:52:34] (CR) Eileen: Civi46 add install functions test (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/265861 (owner: Eileen) [21:00:18] (CR) jenkins-bot: [V: -1] Civi46 add install functions test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/265861 (owner: Eileen) [21:01:50] hmm, test db priv annoyances. think those are transient [21:02:00] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/265861 (owner: Eileen) [21:06:22] ejegg: you around? [21:06:32] yep, sorry! [21:06:33] one sec [21:34:56] AndyRussG: Anything I can do to help with the Civi setup woes? [21:35:01] Is this in vagrant? [21:52:10] awight: sure! [21:52:27] thx! [21:52:44] I'm not even sure if it set up properly, or if there was some funny thing I should have done to upgrade on vagrant [21:53:02] I did vagrant destroy and re-built, after pulling the recent git repos [22:01:04] That should work... [22:01:08] what are the issues? [22:08:50] cwd: can you make that event editable so I can add a room? [22:09:42] sure lemme try [22:10:24] ok i think it's editable [22:19:12] thx! [22:30:38] awight: I tried importing some data from a csv file. Eventually it imported but with some funny errors I didn't understand [22:31:12] I also don't know enuf about the system to know what's going on. I see some logs in the UI about the imports, but there were no contacts generated, apparently [22:31:36] awight: I tried pointing him at the engage test data [22:31:46] awight: we could debug though maybe I should chose some relevant new review task to work on? [22:31:58] cwd: https://meta.wikimedia.org/wiki/User:Adamw/Draft/Wikimedia_Foundation_membership_controversy [22:31:59] AndyRussG: I forget, did I suggest the dash test data too? [22:32:10] ejegg: yeah! I didn't get to trying that... [22:35:19] $ jenkins-jobs test config/ -o output/ [22:36:36] integration/jenkins-job-builder [23:06:36] ejegg: i think i hung up right as you were about to say something [23:07:01] heh, just 'see you on IRC' [23:07:13] hehe [23:21:18] (PS1) Ejegg: WIP Run fraud checks before Adyen payment capture [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/266434 (https://phabricator.wikimedia.org/T122244) [23:21:52] Basic idea for enabling manual review on suspicious Adyen stuff ^^ [23:28:04] AndyRussG: When you get a chance to look at the logs again, paste me a few! [23:28:43] awight: ah right there are logs.... mmm [23:29:09] They should be accessible from the import GUI [23:29:17] Ah right [23:29:45] I'm really not sure what I should look at now. Should I concentrate on Civi stuff? The Adyen patch in review? Pull in something CentralNotice-y? [23:30:07] awight: atgomez: dstrine: ejegg: cwd: eileen: ^ [23:30:11] XenoRyet: ^ [23:30:29] ooh, review me, review me! [23:30:35] Ayden? [23:30:41] heh, I dunno what's highest priority either... [23:30:54] I might have snagged most of the easy civi reviews [23:30:55] https://phabricator.wikimedia.org/T124230 ? [23:31:21] AndyRussG: yeah, that one's pretty straightforward! [23:31:54] You can just test the url that's generated if you don't need the full credentialed setup [23:31:54] (PS5) AndyRussG: Send cardholder name to Adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/265936 (https://phabricator.wikimedia.org/T124230) (owner: Ejegg) [23:32:44] AndyRussG: if you want some test credentials, I can hop on OTR [23:32:48] (CR) jenkins-bot: [V: -1] Send cardholder name to Adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/265936 (https://phabricator.wikimedia.org/T124230) (owner: Ejegg) [23:33:09] AndyRussG: yeah review-able things would be top priority, then pair with anyone in the doing column, then try anything in the backlog. After that, if you are in need of pulling things in, I would check with atgomez [23:33:22] oh man, breakage from a rebase is ominous. more core flailing? [23:33:44] heh [23:33:56] ejegg: I'll need a test Adyen account or something? awight: I feel like looking at the logs from my failed Civi import may not be focusing much on the next Civi task to review, maybe for that let's choose something that still needs review as a focus for fixing my broken setup? does that make sense? [23:34:09] ejegg: ah OK re: url [23:34:14] dstrine: thanks! [23:34:35] AndyRussG: if you want some test credentials just let me know [23:34:58] K lemme see what I can figure out and I'll probably ping w/ newbie questions in a sec [23:34:59] Call to a member function clearGlobalsCache() [23:35:01] that went nuclear [23:35:13] yeah, what the heck is that... [23:35:49] Hmm maybe I shouldn't've rebased... [23:36:07] nah, rebasing was totally kosher [23:36:21] AndyRussG: yeah, that works too! No rush [23:36:22] if it's another core change, we'd have hit this on gate+submit anyway [23:36:24] awight: AndyRussG sorry didn't see that before. I need to finish something before there is a civi thing to review & it's probably more of an awight ejegg thing because it is complex & stuff they have dealt with. The lybunt on needs some feedback from cvirtue [23:36:25] this->adapter is non-object [23:37:02] cwd right, but this->adapter = new TestingGenericAdapter() right in setUp [23:37:11] so I wonder if there's a different root cause [23:37:13] and I can't remember much about that amp one other than to say it's to with updating buildkit - I think awight remembers it (T91911) [23:37:20] yeah there must be [23:37:34] trying to reproduce locally [23:42:40] eileen: ah OK thanks! [23:44:19] k, broken here too. time to find the culprit with that awesome git bisect command hashar dropped in https://phabricator.wikimedia.org/T123202 [23:44:54] AndyRussG: there are some parts of Civi I wouldn't wish on anyone :-) [23:44:57] aha, ' Handle static access in TestingAccessWrapper' - Ia8ec6ee0a364807e78fc182c4ce99d782b921eda [23:45:21] :( think that one needs fixing in core... [23:45:24] heh don't worry [23:48:28] wooooo gitbisect! [23:48:33] not bad [23:48:43] so handy! [23:49:47] ejegg: cwd: huh having trouble bring my vagrant's DI up to date! $ php update.php [23:49:48] MediaWiki 1.27alpha Updater [23:49:48] [Mon Jan 25 23:49:25 2016] [hphp] [2594:7fa0e70c1d00:0:000001] [89ede9:89f158:89fa54:89fd73:8b380e:8b642f:a3c681:7ce830:7fa0df0baec5:7ca349] [23:49:48] Fatal error: Function already defined: wfEntryPointCheck in /vagrant/mediawiki/maintenance/Maintenance.php on line 25 [23:50:12] Ah wait, I did composer update from outside the vm, hmmm [23:50:49] Hmm no that wasn't it [23:51:59] Should I not have done git pull on the fundraising/REL1_25 branch? [23:52:16] eileen: Thanks, I can take a look at the amp patch [23:52:53] awight: I can barely remember it - but I know we discussed it at some point :-) [23:53:42] AndyRussG: that should be fine... [23:53:44] I still remember, don't worry ;) [23:54:56] how much good does that globals cache really do for us, anyway? [23:54:59] (CR) Awight: [C: 2] "That should work. Thanks, totten and eileen!" [wikimedia/fundraising/civicrm-buildkit/vendor/totten/amp] - https://gerrit.wikimedia.org/r/256377 (https://phabricator.wikimedia.org/T91911) (owner: Eileen) [23:56:52] Weird! I'm runing update.php in /vagran/mediawiki-fr, but it's complaining about this file: /vagrant/mediawiki/maintenance/Maintenance.php on line 25 [23:57:00] i.e., in /vagrant/mediawiki/ [23:58:11] Must be some vagrant config ishiew [23:59:46] AndyRussG: How are you running update.php? I believe you have to run mwscript and give the --wiki= argument [23:59:57] See the main page of the installed wiki