[00:00:15] Ah k...! mm yeah I no args [00:00:59] https://github.com/wikimedia/mediawiki-vagrant/blob/master/puppet/modules/payments/files/Main_Page.wiki [00:01:07] e.g. mwscript extensions/DonationInterface/globalcollect_gateway/scripts/orphans.php --wiki paymentswiki [00:03:07] (PS1) Ejegg: Quit statically caching global vars [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266439 [00:03:59] another must-merge-to-progress patch ^^ cwd's CI work is getting more important by the minute [00:04:30] ugh [00:04:33] i think i'm on the right track [00:04:38] woohoo! [00:05:37] awight: OK mwscript maintenance/update.php --wiki paymentswiki worked... [00:06:58] attention span waning.... [00:07:07] I'm out for the night, folks [00:07:25] ejegg|away: cya! [00:15:53] cwd: awight: XenoRyet: what's ur command for running DI tests, again? [00:16:20] (CR) Awight: [V: 2] Add option to define a separate path for the amp app [wikimedia/fundraising/civicrm-buildkit/vendor/totten/amp] - https://gerrit.wikimedia.org/r/256377 (https://phabricator.wikimedia.org/T91911) (owner: Eileen) [00:16:55] AndyRussG: I cd to tests/phpunit, then e.g. php phpunit.php --filter DonationInterface_Adapter_GatewayAdapterTest::testResetOnRecurringSwitch [00:16:55] AndyRussG: you should just be able to do --group DonationInterface [00:17:01] +1 ^^ [00:17:44] /vagrant/mediawiki-fr/tests/phpunit$ php phpunit.php --group DonationInterface [00:17:44] [Tue Jan 26 00:17:29 2016] [hphp] [2248:7fa9918f9d00:0:000001] [89ede9:89f158:89fa54:89fd73:8b380e:8b642f:a3c681:7ce830:7fa9898f2ec5:7ca349] [00:17:44] Fatal error: Function already defined: wfEntryPointCheck in /vagrant/mediawiki/maintenance/Maintenance.php on line 25 [00:18:11] same error from the maintenance script? [00:18:13] (PS1) Awight: Update amp and other libs [wikimedia/fundraising/civicrm-buildkit] - https://gerrit.wikimedia.org/r/266441 (https://phabricator.wikimedia.org/T91911) [00:18:14] gotta be systemic [00:18:23] /vagrant/mediawiki-fr/tests/phpunit$ php phpunit.php --filter DonationInterface_Adapter_GatewayAdapterTest::testResetOnRecurringSwitch [00:18:23] [Tue Jan 26 00:18:10 2016] [hphp] [2251:7f72babffd00:0:000001] [89ede9:89f158:89fa54:89fd73:8b380e:8b642f:a3c681:7ce830:7f72b2bf8ec5:7ca349] [00:18:23] Fatal error: Function already defined: wfEntryPointCheck in /vagrant/mediawiki/maintenance/Maintenance.php on line 25 [00:18:25] Yep [00:18:39] Argh, I recognize that one... [00:18:45] The update script I solved calling mwscript instead of php [00:18:54] and the --wiki paymentswiki param [00:19:37] It's something about multiple wikis, again. [00:19:45] yerp [00:19:53] aah that makes sense [00:20:29] (CR) Awight: [C: 2 V: 2] Update amp and other libs [wikimedia/fundraising/civicrm-buildkit] - https://gerrit.wikimedia.org/r/266441 (https://phabricator.wikimedia.org/T91911) (owner: Awight) [00:20:34] Yeah that's why the error is under the mediawiki rather than the mediawiki-fr directory [00:20:49] Something is pulling in config and code from the main wiki via some hardcoded dir [00:21:10] Try MW_INSTALL_PATH=/vagrant/mediawiki-fr php phpunit.php --group DonationInterface [00:21:22] ... and if it works, please add to mediawiki-vagrant Main_Page.wiki [00:22:00] awight: K! That's an improvement!! Yes, I think that's that bug [00:22:02] It tried to run tests [00:22:15] ghastly [00:22:23] But ended with "No tests executed!" [00:22:32] I think there's some make step or something [00:22:48] nah, the Makefile is just a wrapper [00:23:20] ugh, "no tests" is probably because errors are suppressed by that terrible phpunit.php script [00:23:38] hmmm [00:23:40] Maybe check in /vagrant/logs and /var/log for interesting fatal errors? [00:23:57] It did think about it for a while [00:25:01] ah--another thing to do in addition to vagrant destroy, is to git pull new versions of all the repos [00:25:13] vagrant only manages the initial clone, but doesn't update for you [00:26:57] awight: yeah did that! [00:27:20] Or at least, with mediawiki-fr core repo. Then checked out ejegg's patch [00:28:23] /vagrant/logs is sure full u [00:28:24] up [00:28:45] From what I remember, the 100 times I've seen that "no tests" thing, I usually tear apart all the unit test base classes, add printfs everywhere, then discover that it was an error somewhere [00:28:53] e.g. need to run composer update? [00:29:30] It's pretty jarring that our phpunit framework hides the errors from us... [00:29:54] awight: that's what I did run above ^ I thought, correctly, lemme try with the env variable you mentioned [00:30:20] that shouldn't be a factor [00:30:32] did you also run in the DI directory, though? [00:31:49] Same thing on the lastest DI master [00:31:56] No, I was running in the core dir [00:32:14] DI needs a composer update as well [00:32:43] maybe look in /var/log/syslog [00:32:52] I believe PHP fatal errors will show up there [00:33:17] Same thing if I do this /vagrant/mediawiki-fr/extensions/DonationInterface/tests$ MW_INSTALL_PATH=/vagrant/mediawiki-fr php ../../../tests/phpunit/phpunit.php --group DonationInterface [00:33:25] Ah hmm didn't know about the DI composer... [00:36:16] Hmm that killed the vm! [00:36:23] Very mighty! [00:36:41] https://xkcd.com/349/ [00:36:42] baaahahaha [00:38:50] yep [00:39:02] Story of my life [00:39:27] [RuntimeException] [00:39:27] The .git directory is missing from /vagrant/mediawiki-fr/extensions/DonationInterface/vendor/coderkungfu/php-queue, see https://getcomposer.org/commit-de [00:39:27] ps for more information [00:39:40] ^ from the DI composer update [00:39:43] aaaaaaaaaaaaaaaaarrggg [00:40:01] cwd: awight: thx much, I have to pause for family supper time [00:40:11] AndyRussG: rm -rf vendor [00:40:18] It's an infuriating composer bug [00:40:18] ah hmm k [00:40:26] see ya! [00:40:32] (PS1) Awight: Point amp to temporary directory [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/266443 (https://phabricator.wikimedia.org/T91911) [00:40:47] awight: weee that worked! [00:40:58] K seeya maybe laters or morrow ;) thanks again [00:41:04] (CR) Awight: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/266443 (https://phabricator.wikimedia.org/T91911) (owner: Awight) [00:41:34] (PS1) Awight: DO NOT MERGE - CI job validation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/266444 [00:46:49] (PS2) Awight: Point amp to temporary directory [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/266443 (https://phabricator.wikimedia.org/T91911) [00:49:38] (PS3) Awight: Point amp to temporary directory [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/266443 (https://phabricator.wikimedia.org/T91911) [00:49:57] (Abandoned) Awight: DO NOT MERGE - CI job validation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/266444 (owner: Awight) [00:55:51] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Tech Backlog, Fundraising-Backlog, and 4 others: Point amp cache to $WORKSPACE - https://phabricator.wikimedia.org/T91911#1964474 (awight) @eileenmcnaughton Hooray! I tweaked the composer.lock, and verified... [01:00:57] awight: cwd: even after the composer update, I still get no tests run [01:01:23] using --group flag? [01:03:28] AndyRussG: logs? [01:03:33] cwd: yep [01:03:51] AndyRussG: if you remove that does it run anything? [01:03:55] the group flag [01:04:07] I've been following along in the background here. Instead of 'no tests run', I'm getting 'Couldn't find a usable PHPUnit' [01:04:18] harrrr [01:04:25] XenoRyet: vagrant? [01:04:31] Yea, vagrant [01:04:32] awight: it does seem to be running stuff. It does stuff on TestFileIterator::setupCurrentTest [01:04:44] And the last line is "Invalid user language code" [01:04:51] O_o [01:04:56] awight: good idea, lemme try [01:04:58] but no fatal errors? [01:05:15] XenoRyet: what is your commandline? [01:05:17] XenoRyet: wooo hmm composer update'd? [01:05:36] Yea, did the composer updates like you guys were talking about, ran fine. [01:06:21] MW_INSTALL_PATH=/vagrant/mediawiki-fr php phpunit.php --group DonationInterface [01:06:26] That's what I'm running. [01:07:27] awight|brb: yeah! without that flag it does indeed run some tests [01:07:32] actually a lot of tests [01:14:36] AndyRussG: yeah i have had that problem before where the group flag does not work [01:15:01] i don't know what the deal is, maybe phpunit version? but you can simulate it by going --filter DonationInterface [01:16:29] cwd: K hmmm Yeah I just tried the other filter command u suggested, to no avail [01:16:51] XenoRyet: are you running from within the vm (ssh vagrant)? [01:17:00] Yep [01:17:31] And you updated the core repo and the DI repo, and ran composer update on both, and maintenance/update.php on core? [01:18:00] hmm that's weird [01:18:05] Maybe didn't do core repo [01:18:56] this isn't a totally fresh vagrant box either, but it's not too old. [01:21:31] http://nonprofitwithballs.com/2016/01/10-classic-movies-that-should-have-been-about-nonprofit-work/ [01:22:41] eileen: heheh :) [01:23:39] :-) [01:23:58] Sorry the needle is stuck on this one line, but I believe that whenever I've had the "no tests" error, it's been due to a masked exception which causes the DI tests to not load. [01:24:08] gotta run! [01:45:47] i'm useless. g'night! [01:47:26] (PS1) XenoRyet: Nonsense Name Fraud Filter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266456 (https://phabricator.wikimedia.org/T120255) [01:48:27] (CR) jenkins-bot: [V: -1] Nonsense Name Fraud Filter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266456 (https://phabricator.wikimedia.org/T120255) (owner: XenoRyet) [01:52:07] (PS2) XenoRyet: Nonsense Name Fraud Filter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266456 (https://phabricator.wikimedia.org/T120255) [01:53:03] (CR) jenkins-bot: [V: -1] Nonsense Name Fraud Filter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266456 (https://phabricator.wikimedia.org/T120255) (owner: XenoRyet) [02:44:39] http://arstechnica.com/tech-policy/2016/01/editors-demand-ouster-of-wikimedia-board-member-involved-in-no-poach-deal/ [03:09:13] (PS5) Eileen: CRM-17751 add refund trxn to forms [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/261601 (https://phabricator.wikimedia.org/T116317) [03:14:39] (Abandoned) Eileen: Add function to add financial_trxn rows for upgraded refunds. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/263578 (owner: Eileen) [03:15:30] ejegg|away: it's like a slow motion train wreck [03:21:33] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising-Backlog, Patch-For-Review: LYBUNT related: Fiscal Year report does not work - https://phabricator.wikimedia.org/T123671#1964836 (Eileenmcnaughton) @Caitvirtue - do you want to catch up for 10 mins tomorrow &... [03:28:27] (CR) Eileen: "I've rebased this and the patch is now on staging. I just did a refund against me civicrm/contact/view?reset=1&force=1&cid=8513790&selecte" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/261601 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [03:39:15] Fundraising Tech Backlog, MediaWiki-Vagrant: Write MW-Vagrant puppet to allow us to spin up dev, staging, and testing instances, and deploy sandbox servers on WMF-labs - https://phabricator.wikimedia.org/T99957#1964851 (bd808) Assuming this should have been tagged with #fr-tech since @awight created it a... [03:39:18] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add ability to enter a trxn_id for the refund transaction when editing a contribution to be Refunded - https://phabricator.wikimedia.org/T123319#1926169 (Eileenmcnaught... [03:39:37] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Update upgraded Refunded Contributions to have the correct financial transaction records - https://phabricator.wikimedia.org/T123346#1964858 (Eilee... [03:39:47] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Remove duplicate refunded status & transfer contributions with this status to the original Refunded status - https://phabricator.wikimedia.org/T123329#1964860 (Eileenmc... [03:40:35] Fundraising Sprint Bloodletting 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: certain Civi searches take a long time - https://phabricator.wikimedia.org/T123418#1964863 (Eileenmcnaughton) a:Eileenmcnaughton [04:19:28] Fundraising Tech Backlog, MediaWiki-Vagrant: Write MW-Vagrant puppet to allow us to spin up dev, staging, and testing instances, and deploy sandbox servers on WMF-labs - https://phabricator.wikimedia.org/T99957#1964907 (demon) Interesting, we were just talking about this today in #releng as a possible pr... [04:26:38] (PS3) Eileen: Fix gateway reconcilliation report to use transactions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/260320 (https://phabricator.wikimedia.org/T116317) [04:26:40] (PS2) Eileen: Update Mark Refund function to reflect use of financial_trxns [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/261757 [04:26:42] (PS1) Eileen: Ensure all contributions have a payment instrument set. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/266467 [04:26:44] (PS1) Eileen: Update upgraded contributions of Refunded status to have financial data. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/266468 [04:26:46] (PS1) Eileen: Add upgrade hook to remove duplicate 'Refunded' contribution status [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/266469 (https://phabricator.wikimedia.org/T116317) [04:29:07] (CR) jenkins-bot: [V: -1] Fix gateway reconcilliation report to use transactions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/260320 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [04:30:29] (CR) jenkins-bot: [V: -1] Update Mark Refund function to reflect use of financial_trxns [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/261757 (owner: Eileen) [04:44:03] (PS2) Eileen: Ensure all contributions have a payment instrument set. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/266467 [05:21:39] (PS3) Eileen: Ensure all contributions have a payment instrument set. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/266467 [05:22:51] (PS2) Eileen: Update upgraded contributions of Refunded status to have financial data. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/266468 [05:24:32] (PS2) Eileen: Add upgrade hook to remove duplicate 'Refunded' contribution status [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/266469 (https://phabricator.wikimedia.org/T116317) [05:25:13] (CR) jenkins-bot: [V: -1] Add upgrade hook to remove duplicate 'Refunded' contribution status [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/266469 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [05:28:58] (Abandoned) Eileen: Fix refund to grab lowest contribution status id rather than highest. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/261756 (owner: Eileen) [05:32:10] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/266469 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [05:43:39] (CR) Eileen: "I'll fix the dependency chain once test fixes are discussed & agreed" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/261757 (owner: Eileen) [05:47:01] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, and 4 others: CiviCRM upgrade: Adapt refund processing & reporting to reflect changes since the upgrade. - https://phabricator.wikimedia.org/T116317#1964972 (... [15:18:06] (CR) Hashar: "I have refreshed the job ( CI change https://gerrit.wikimedia.org/r/#/c/266447/ ). So I guess this can land now :-}" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/266443 (https://phabricator.wikimedia.org/T91911) (owner: Awight) [15:23:31] (PS2) Hashar: Add jsonlint to npm test command [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/262704 (https://phabricator.wikimedia.org/T63599) [15:24:38] (CR) Hashar: [C: 2] Add jsonlint to npm test command [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/262704 (https://phabricator.wikimedia.org/T63599) (owner: Hashar) [15:27:47] (CR) Hashar: [C: 2] Add jsonlint to npm test command [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/262704 (https://phabricator.wikimedia.org/T63599) (owner: Hashar) [15:28:32] (Merged) jenkins-bot: Add jsonlint to npm test command [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/262704 (https://phabricator.wikimedia.org/T63599) (owner: Hashar) [16:04:52] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising-Backlog: Some Globalcollect donations not in Civi - https://phabricator.wikimedia.org/T122730#1965861 (MBeat33) We are still seeing a trickle of donor inquiries about transactions related to this. The donor in Z... [16:48:31] (CR) Ejegg: "On second thought, PaymentCaptureAction is the wrong place to read the queue. It should add the contents of the Auth IPN message to the Pa" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/266434 (https://phabricator.wikimedia.org/T122244) (owner: Ejegg) [17:58:36] (PS2) Ejegg: WIP Run fraud checks before Adyen payment capture [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/266434 (https://phabricator.wikimedia.org/T122244) [18:07:25] (CR) Paladox: "Thanks." [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/262704 (https://phabricator.wikimedia.org/T63599) (owner: Hashar) [18:11:31] (PS8) Ejegg: Fail validation and present error page for bad country [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/260885 (https://phabricator.wikimedia.org/T120727) (owner: Awight) [18:13:00] (CR) jenkins-bot: [V: -1] Fail validation and present error page for bad country [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/260885 (https://phabricator.wikimedia.org/T120727) (owner: Awight) [18:24:33] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising-Backlog: Some Globalcollect donations not in Civi - https://phabricator.wikimedia.org/T122730#1966429 (atgo) Any luck @cwdent? [18:26:41] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising-Backlog: Some Globalcollect donations not in Civi - https://phabricator.wikimedia.org/T122730#1966447 (cwdent) There was an email but no progress, Sal said he'll let us know when the files land. [18:46:05] eileen: Did you want to chat about refunds at some point? [18:47:28] véase #wikimedia-operations, meta is down [18:48:13] the-wub: should we send an e-mail about it to fr-tech? Sounds like it'll be fixed soon, so maybe just a post-mortem? [18:48:20] as is donate.wikimedia.org. messed up config file means they're redirecting to wikimediafoundation.org [18:48:29] ooh [18:48:31] fyi MBeat ^ [18:48:37] the-wub: ah right.... Where were there campaigns? [18:48:57] ty the-wub [18:49:45] AndyRussG: not any of the huge countries. Italy, France, I think [18:49:56] I kind of rely on being able to check in CentralNotice :P [18:50:05] ooh, central auth is messed up too I guess [18:51:07] hmm, hope those '301 Moved Permanently' redirects don't mess with caches too badly [18:51:39] the-wub: eh mee tooo [18:52:36] the-wub: fwiw, go to en.wikipedia.org, opena a browser console, and check out mw.centralNotice.choiceDat [18:52:39] a [18:52:46] mw.centralNotice.choiceDada [18:52:49] rrrrg [18:52:55] mw.centralNotice.choiceData [18:53:01] okay, in #wikimedia-operations they're saying it may take 20 mins for the fix to take effect [18:53:40] ah cool thx [18:54:13] Yeah confirmed Special:BannerLoader calls are returning 404 Not Founds [18:54:15] AndyRussG: I get an array of 7 objects, they look okay to me [18:54:37] the-wub: yeah the campaign should be chosen fine, just the banner can't be fetched [18:54:43] https://en.wikipedia.org/wiki/Main_Page?country=AT [18:55:16] At least S:RI shouldn't record any nondisplays as displays [18:55:25] ah I see. thanks AndyRussG [18:55:26] sorry /beacon/impression [18:55:45] awight: definitely - maybe in about half an hour (which is 30 mins before the meeting starts) I was just catching up on the slow-motion trainwreck http://www.bbc.com/news/technology-35411208 [18:55:46] Yeah the choice data is created by a direct server-side call to the meta database, which seems to be fine [18:57:26] eileen: sounds good! [18:57:26] AndyRussG: I'm writing a quick summary for fr-online now [18:57:45] the-wub: cool beans, thx! [18:59:31] eileen: There was a Ars Technica article on that subscandal, too... [19:00:21] yeah I saw that but that's an obscure site? [19:00:32] bbc is a bit more of a big deal [19:01:48] I don't think I feel sympathy for the guy, but... he's going to have to change his name to do anything else. [19:03:15] yeah - it's certainly moved this part of his his history to no 1 spot on google searches on him [19:03:56] The vote of no confidence is quite a read, btw. Don't miss the oppose section, it starts strong! [19:04:34] with the 'are you really guy kawasaki' discussion? [19:04:52] HAHA yeah. [19:05:07] "is this mic on?" [19:06:02] will the real kawasaki please stand up [19:08:15] so good [19:08:46] yeah, I actually sympathise with him not knowing how to sign. but don't know why he felt the need to show up there at all [19:09:26] it's not often I agree with Fae, but he has been right on with this no confidence vote [19:10:01] above is all in my volunteer voice etc etc [19:10:14] which was the ars technica article? [19:10:26] http://arstechnica.com/tech-policy/2016/01/editors-demand-ouster-of-wikimedia-board-member-involved-in-no-poach-deal/ [19:11:05] at least a few comments on ars aying folks cancelled donations, one saying they wrote to Lila [19:11:55] the-wub: the volunteer in me also doesn't like having a trustee that's great at firing people for stepping out of line (something the employee in me never does...) [19:12:22] ejegg: yeah as soon as I saw it I forewarned donor services and major gifts [19:12:27] Seddon: thx! [19:12:43] ty [19:12:50] AndyRussG: the employee in me might think the same, but couldn't say it publicly :) [19:12:55] cwd: awight: ejegg: XenoRyet: when I try to run DI tests, somehow it's always trying to run ParserMethodsTest... that's where it borks, strangely [19:12:56] the-wub: I totally agree. The Wikimedians have been kicking all the ass lately. This is sort of demonstrating to me how much more they could be responsible for--for example, if the WMF were a membership organization again. [19:13:28] AndyRussG: weird, how are you running them? [19:14:00] ejegg: trying a few ways... here's one: [19:14:00] /vagrant/mediawiki-fr$ MW_INSTALL_PATH=/vagrant/mediawiki-fr php tests/phpunit/phpunit.php --group DonationInterface [19:14:19] slight variant: /vagrant/mediawiki-fr/extensions/DonationInterface/tests$ MW_INSTALL_PATH=/vagrant/mediawiki-fr php ../../../tests/phpunit/phpunit.php --group DonationInterface [19:15:10] awight: it realistically never as been [19:15:22] I usually use --group=DonationInterface [19:15:29] (with an equals sign) [19:15:38] Does that help? [19:16:11] haha, we are only the 2nd item on the bbc's tech news. behind My Little Pony http://www.bbc.co.uk/news/technology-35412978 [19:16:33] omg, font misuse! [19:20:33] Seddon: That's what I heard, but after reading the history I'm not convinced... [19:21:39] AndyRussG: This is terrible, but lately I've only had luck running tests from the tests/phpunit working directory [19:21:49] Seddon: for a rainy day, https://meta.wikimedia.org/wiki/Wikimedia_Foundation_membership_controversy [19:21:55] AndyRussG: ah, I always run from that dir too [19:21:55] awight: ah from the core? Lemee try now [19:23:30] yay, sites are back for me [19:23:39] apparently they could still be down for some people though [19:27:51] The next big thing after WP? https://www.hitrecord.org/ [19:28:21] oh, cool! [19:28:52] yeah Mariana just showed me the (a?) promotional video, it's amazing [19:29:30] ejegg: awight: running from /vagrant/mediawiki-fr/tests/phpunit gives the same result [19:29:42] One sec pastebinning the log [19:29:42] AndyRussG: with the equals sign? [19:29:51] between group and DonationInterface [19:31:31] ejegg: nearly the same result [19:32:34] weird, still trying to run non-DI just, huh? Lemme update my vagrant and try [19:35:43] awight refunds? [19:39:33] oh man, on bbc [19:39:43] AndyRussG: i hope you are proud! [19:40:05] * ejegg hums innocently [19:40:32] :-) [19:40:37] cwd: arrrrggg /me jumps to avoid colliding planes, trains and automobiles [19:40:46] 8p [19:41:08] hehe [19:41:11] I don't think you need to jump - just walk away slowly - this one is all slow motion [19:41:12] I can't imagine it wouldn't have come out [19:41:22] no [19:42:06] i'm sure it would have, but afaik you can claim the first responder prize [19:42:09] though the timing definitely enhanced the uproar [19:42:27] what with Doc James fresh in everyone's minds [19:42:59] ejegg: cwd: XenoRyet: awight: here's my log, with the --debug-tests flag: https://tools.wmflabs.org/paste/view/1c5a90ef [19:43:08] https://lists.wikimedia.org/pipermail/wikimedia-l/2016-January/081394.html [19:43:09] Ah helicopters too! [19:43:36] cwd: yep saw that one........ [19:43:36] yowza! that's pretty deep debug [19:43:52] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Astropay: Verify which fiscal numbers we need to collect for AstroPay in each new LATAM country - https://phabricator.wikimedia.org/T124329#1966868 (atgo) @ejegg does that make this one "done"? [19:44:26] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Astropay: Verify which fiscal numbers we need to collect for AstroPay in each new LATAM country - https://phabricator.wikimedia.org/T124329#1966873 (Ejegg) Nah, I still need to update all the l10n strings, but that'll be simple [19:44:56] http://www.vagalume.com.br/malvina-reynolds/theres-a-bottom-below.html [19:46:28] these are some depressing lyrics [19:48:51] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Improve security of UKFC data transfers - https://phabricator.wikimedia.org/T124315#1966881 (atgo) @caitvirtue it would probably be helpful to start with how they send data now. Potentially we can have them mirror the new Coinbase process through pgp en... [19:51:16] AndyRussG: hitrecord looks really neat [19:51:44] unfortunately not CC licensed [19:56:19] only remixable by other hitrecord members [19:56:19] shameful [19:57:20] AndyRussG: ugh, getting class already declared: Maintenance when I try to test inside vagrant [19:57:46] (PS3) Ejegg: Run fraud checks before Adyen payment capture [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/266434 (https://phabricator.wikimedia.org/T122244) [19:59:01] Fundraising Sprint Bloodletting 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: certain Civi searches take a long time - https://phabricator.wikimedia.org/T123418#1966905 (Eileenmcnaughton) A wildcard is being prefixed to the contribution source string, causing the slowness. After we fixed t... [20:00:41] (CR) Ejegg: [C: -1] "Oops, I need to put this in the pending queue message, not just the limbo one." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266295 (https://phabricator.wikimedia.org/T122244) (owner: Ejegg) [20:02:12] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Astropay: Verify which fiscal numbers we need to collect for AstroPay in each new LATAM country - https://phabricator.wikimedia.org/T124329#1966907 (atgo) Maybe we should change the title in order to reflect that? Reads to me like we need... [20:02:55] http://magnatune.com/ [20:03:30] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Astropay: Verify which fiscal numbers we need to collect for AstroPay in each new LATAM country, update l10n files - https://phabricator.wikimedia.org/T124329#1966909 (Ejegg) [20:06:27] cwd: oh yeah magnatune! that was like the first streaming site I ever used! [20:07:51] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Create CiviCRM naming convention rule: In general, records should not begin with "The" - https://phabricator.wikimedia.org/T122592#1966915 (atgo) [20:12:34] Fundraising-Backlog, Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Epic, and 3 others: [EPIC] Special:RecordImpression should be used at a very low sample rate - https://phabricator.wikimedia.org/T45250#1966952 (DStrine) [20:14:13] Fundraising-Backlog, Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Epic, and 3 others: [EPIC] Special:RecordImpression should be used at a very low sample rate - https://phabricator.wikimedia.org/T45250#1045534 (DStrine) fr-tech has discussed this a few times. We have a few steps left... [20:18:19] Fundraising-Backlog: Civi: can the Change Log be used to recover contribs that have been inadvertently deleted? - https://phabricator.wikimedia.org/T124695#1966984 (atgo) @mbeat33 is there a chance that the agent had multiple tabs open? That can cause issues like this. [20:19:04] Fundraising-Backlog: Civi: can the Change Log be used to recover contribs that have been inadvertently deleted? - https://phabricator.wikimedia.org/T124695#1966995 (awight) See also T117632 [20:19:19] Fundraising-Backlog: Civi: can the Change Log be used to recover contribs that have been inadvertently deleted? - https://phabricator.wikimedia.org/T124695#1967003 (awight) [20:19:21] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Dedupe merge failed to relink a contribution? - https://phabricator.wikimedia.org/T117630#1967004 (awight) [20:19:31] Fundraising-Backlog, fundraising-tech-ops: Matching Gifts search link gives proxy error - https://phabricator.wikimedia.org/T124666#1967010 (atgo) Hmm both of those seem to be down for me... @pcoombe you just went to those domains? {F3283754} [20:19:52] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: [epic] Make deduping reversible - https://phabricator.wikimedia.org/T111704#1967013 (awight) [20:20:16] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: [epic] Make deduping reversible - https://phabricator.wikimedia.org/T111704#1614185 (awight) [20:20:18] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Dedupe merge failed to relink a contribution? - https://phabricator.wikimedia.org/T117630#1780273 (awight) [20:20:35] Fundraising-Backlog: Fully retire MediaWiki "Donate" skin - https://phabricator.wikimedia.org/T124519#1967020 (awight) [20:22:16] Fundraising-Backlog: Fully retire MediaWiki "Donate" skin - https://phabricator.wikimedia.org/T124519#1967048 (atgo) Hey @pcoombe can you confirm that this is ok to delete? Seemingly hasn't been used since 2009 but looks like your domain. [20:23:39] Fundraising-Backlog: Fully retire MediaWiki "Donate" skin - https://phabricator.wikimedia.org/T124519#1967058 (awight) p:Triage>Normal [20:28:32] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Astropay: Verify which fiscal numbers we need to collect for AstroPay in each new LATAM country, update l10n files - https://phabricator.wikimedia.org/T124329#1967102 (atgo) p:Triage>Normal [20:28:32] AndyRussG: re unique IDs discussion: https://office.wikimedia.org/wiki/Topic:Swhoudwspsceipuv [20:28:32] awight: thx! [20:40:33] (PS1) Ejegg: Update country-specific financial number labels [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266580 (https://phabricator.wikimedia.org/T124329) [21:04:30] awight: I guess we have an hour until our next meeting - do you want to talk refunds?? [21:04:45] eileen: yes! [21:05:02] shall we open a hangout for some voice? ejegg interested? [21:05:59] sounds good-making a calendar entry now so I can steal a room... [21:07:02] cool [21:09:09] ok, headed for screen... [21:18:55] Fundraising Sprint Bloodletting 2016, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Astropay, Patch-For-Review: Verify which fiscal numbers we need to collect for AstroPay in each new LATAM country, update l10n files - https://phabricator.wikimedia.org/T124329#1967362 (Ejegg) a... [21:20:26] ah, I'll join in a minute awight / eileen ! [21:47:03] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Fix WMF_donor rollup calculations to use financial transactions - https://phabricator.wikimedia.org/T124834#1967481 (Ejegg) NEW [21:47:25] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Fix WMF_donor rollup calculations to use financial transactions - https://phabricator.wikimedia.org/T124834#1967489 (Ejegg) [21:47:27] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, and 4 others: CiviCRM upgrade: Adapt refund processing & reporting to reflect changes since the upgrade. - https://phabricator.wikimedia.org/T116317#1967488 (... [21:48:23] awight: what's this thing? https://github.com/wikimedia/integration-config/blob/master/jjb/integration.yaml#L148 [21:49:53] i've found a dozen or so places that look sort of like somewhere you could hang some config to plumb a flag into zuul-cloner [21:50:12] a lot of ins, a lot of outs, a lot of what-have-yous [21:53:36] scratch that one...i think it's for testing core [21:53:46] but unscratch it if i'm wrong [21:56:45] cwd: why is my composer.lock file showing up as modified in my DI git repo? I guess it should be gitignored? [21:57:52] cwd: ooh, I really don't know what that is [21:57:55] AndyRussG: those files do get checked in [21:58:04] but vendor is a submodule live [21:58:10] it looks like CI for the CI, though [21:58:18] Hummm [21:58:38] I just git reset --hard [21:58:43] AndyRussG: ideally (i think) we'd be able to run composer update & install when we deploy [21:59:06] Hmm also... I think I heard concerns about that being a security risk when it was talked about for core [21:59:08] but the lock file has been edited and running update will hose it [21:59:28] AndyRussG: yeah there's no guarantees about upstream packagist packages [21:59:44] Anyway I'll not make any changes in it along w/ any patchsets [22:00:04] and no way to check signatures without running the autoloader code which could be bad [22:00:04] (PS6) AndyRussG: Send cardholder name to Adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/265936 (https://phabricator.wikimedia.org/T124230) (owner: Ejegg) [22:01:02] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, and 4 others: Track email clickthroughs on donate wiki - https://phabricator.wikimedia.org/T114010#1967522 (CCogdill_WMF) Thank you @Ejegg! We should ha... [22:04:59] cwd: what type of dog is it (Vail-man is asking) [22:05:21] I said "eileen [22:05:21] 11:04 [22:05:21] nganivet: a largish but friendly one I believe & it's an indoor dog" [22:06:12] eileen: she's a border collie [22:06:16] https://www.mediawiki.org/wiki/Extension:CentralNotice/Notes/Campaign-associated_mixins_and_banner_history#Features_roadmap [22:06:17] mutt [22:08:06] cwd can you join #civicrm (to discuss the dog) [22:09:53] ok! [22:15:42] Fundraising-Backlog, fundraising-tech-ops: Matching Gifts search link gives proxy error - https://phabricator.wikimedia.org/T124666#1967593 (MBeat33) Matchinggifts.com is working again, as is our form. [22:18:45] Fundraising-Backlog, fundraising-tech-ops: Matching Gifts search link gives proxy error - https://phabricator.wikimedia.org/T124666#1967651 (atgo) Open>Resolved a:atgo Closing, thanks! [22:53:12] eileen: Donno if you saw, but there's one more tiny CR for you on the Amp task. [22:53:26] https://gerrit.wikimedia.org/r/#/c/256377/ [22:53:38] Also a thing for the CI team to review... [22:53:50] oh, not that patch [22:54:27] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM, Continuous-Integration-Config, Patch-For-Review: Optimize CiviCRM CI job - https://phabricator.wikimedia.org/T91903#1967908 (awight) [22:55:00] eileen: There it is... https://gerrit.wikimedia.org/r/#/c/266443/ [22:56:06] awight: yeah that patch makes sense - I think I can get away with approving it based on that without figuring out how to test the CI usage of it [22:56:45] hmm - is that upstream already? [22:57:50] ah yes - self converstaion [22:59:29] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Find and fix any references to parent_contribution_id or the "RFD" trxn_id prefix - https://phabricator.wikimedia.org/T124842#1967923 (awight) NEW a:Eileenmcnaughton [22:59:40] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Find and fix any references to parent_contribution_id or the "RFD" trxn_id prefix - https://phabricator.wikimedia.org/T124842#1967923 (awight) p:High>Normal [23:01:59] eileen: yah, fwiw the patch did trigger normal CI, and I verified that the .amp-BUILDNO directory was created where expected. [23:02:23] (PS3) Awight: Update Mark Refund function to reflect use of financial_trxns [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/261757 (owner: Eileen) [23:03:18] awight: ok the patch refers to a couple of variables - workspace & build_number - so I guess as long as it's clear they will always be defined it has to be pretty safe [23:04:55] (CR) jenkins-bot: [V: -1] Update Mark Refund function to reflect use of financial_trxns [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/261757 (owner: Eileen) [23:05:49] Those come from Jenkins, https://wiki.jenkins-ci.org/display/JENKINS/Building+a+software+project#Buildingasoftwareproject-below [23:06:39] ah sweet [23:06:52] gotta relocate [23:08:04] (CR) Awight: [C: 2] Ensure all contributions have a payment instrument set. (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/266467 (owner: Eileen) [23:08:29] awight: so one thing - we are pointing our buildkit to our amp repo aren't we? but actually we have no salient differences to upstream now? [23:10:23] (CR) Eileen: [C: 2] "Checked with awight on IRC & the variables come from jenkins" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/266443 (https://phabricator.wikimedia.org/T91911) (owner: Awight) [23:10:25] eileen: yep, it's our own repo. If you think we're equivalent, then yeah by all means let's cut free from our clone, and default to upstream again! [23:10:25] (Merged) jenkins-bot: Ensure all contributions have a payment instrument set. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/266467 (owner: Eileen) [23:11:38] Cool! We should be able to run concurrent Civi CI jobs now. [23:13:07] I'm cheating the rush, will be back online in 1.5 hr. [23:14:29] awight: ah - this isn't merged upstream https://github.com/totten/amp/pull/18 [23:21:42] (CR) Eileen: Ensure all contributions have a payment instrument set. (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/266467 (owner: Eileen) [23:27:06] awight: does fr-tech keep a log of completed phab tickets or is there a way to collate that on a weekly basis? [23:27:16] and easy way* [23:27:18] an*