[00:04:14] (PS1) Eileen: Hack out credit note calculation [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/266951 (https://phabricator.wikimedia.org/T123305) [00:05:33] ejegg: it was indeed a workspace thing, but just that somehow the workspace already had files in it (no idea) [00:05:39] i had tyler nuke em and now it's running [00:05:55] aha! [00:07:20] i guess some previous run failed to clean up, which is strange because the cleanup steps run whether the job dies or not [00:07:26] shrug.emoji [00:12:04] (PS2) Ejegg: Record Adyen payment on IPN capture notification [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/266930 (https://phabricator.wikimedia.org/T121158) [00:12:56] woohoo! Only one little bit left to have all the adyen AVS / manual review stuff done - need to make the antifraud queue consumer deal with multiple messages for a single payment [00:13:15] cwd, I think they re-use src between jobs to speed things up [00:13:39] Did you see that output where it was resetting and updating the already-checked-out repo? [00:14:39] ejegg: hmm, the working dir for this is: /mnt/jenkins-workspace/workspace/mwext-donationinterfacecore125-testextension-php53 [00:14:53] i know it does do clones from a local repo cache [00:14:55] oh weird [00:15:16] so it could only have been left over from a previous run of that job? [00:15:31] yeah that's what it looks like [00:15:40] there is this 'localhost-cleanup' publisher... [00:15:53] hm [00:16:52] hrm no i don't think that's it [00:17:06] right, all that does is rm -f "/srv/localhost-worker/$BUILD_TAG" [00:19:10] there are global-teardown and mw-teardown... gotta find those scripts [00:24:59] Neither of those delete the directory [00:25:22] well, think i'm going to call it an evening [00:25:32] awesome that you got it running! [00:25:39] see you later folks [00:27:35] see ya! [02:43:37] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, I18n: zh-..., pt, and other language variants are not supported by CentralNotice - https://phabricator.wikimedia.org/T55641#1972823 (Shizhao) [03:55:25] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, I18n: zh-..., pt, and other language variants are not supported by CentralNotice - https://phabricator.wikimedia.org/T55641#1972939 (Liuxinyu970226) [03:55:30] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, I18n: zh-..., pt, and other language variants are not supported by CentralNotice - https://phabricator.wikimedia.org/T55641#588090 (Liuxinyu970226) [07:26:59] (CR) Eileen: "After reading your comments and doing more digging I have decided it makes sense to remove the handling for the fees. I have logged an iss" (7 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/266468 (owner: Eileen) [07:33:52] (PS5) Eileen: Update upgraded contributions of Refunded status to have financial data. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/266468 [07:35:01] (PS3) Eileen: Add upgrade hook to remove duplicate 'Refunded' contribution status [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/266469 (https://phabricator.wikimedia.org/T116317) [15:34:26] (CR) AndyRussG: [C: 2] "LGTM!!! :D" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/265936 (https://phabricator.wikimedia.org/T124230) (owner: Ejegg) [15:35:33] (Merged) jenkins-bot: Send cardholder name to Adyen [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/265936 (https://phabricator.wikimedia.org/T124230) (owner: Ejegg) [15:37:13] thanks AndyRussG ! [15:37:26] ejegg|away: likewise! [15:38:34] ejegg|away: I noticed that in general updates to the top part of the form are not passed on when you click on "pay" in the iframe. For eample, if you update the e-mail address after the iframe loads, then click "pay", the data sent to adyen has the old e-mail addres [15:38:56] So it's a more general problem, not just full_name-related, and since that one's visible, it seems even less problematic [15:39:20] I was going to make a Phab task for that, but I thought maybe it's a known and already-tracked issue? [15:39:22] cwd: ^ [15:40:00] ah,i'll look into that [15:40:01] hmm yeah that's a tough one [15:40:12] would have to resend the request for the iframe [15:40:13] phab task would be great! [15:40:27] or maybe disable stuff outside the iframe once it loads [15:41:12] K phabtaskifying [15:41:45] ejegg|away: cwd: would it be adyen-specific or applicable to staged data for all processors using iframes (are there others?) [15:41:47] ? [15:42:03] probably all [15:42:04] AndyRussG: i think it would be applicable to all of them [15:42:07] K [15:42:12] Which ones use iframe? [15:42:15] worldpay uses one [15:42:18] aaaand [15:42:20] ejegg|away? [15:43:06] astropay mebbe? [15:46:50] globalcollect [15:47:38] astro and pp are full redirect, amazon is all via js widget on our site [15:54:26] Ah hmm K thx! [15:59:19] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: DonationInterface: User updates to fields providing staged data aren't updated in iframe - https://phabricator.wikimedia.org/T125090#1974197 (AndyRussG) NEW [16:00:08] ejegg|away: cwd: ^ Pls go ahead and fix the task if its incomprehensible, wrong-terminology-using, etc. etc. :) thx! [17:17:08] fundraising-tech-ops, operations: make sure netapp fundraising share gets wiped - https://phabricator.wikimedia.org/T118535#1974426 (akosiaris) Open>Resolved A week has passed, volume has been wiped, resolving. [17:31:30] Fundraising Sprint Bloodletting 2016, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, and 3 others: Verify which fiscal numbers we need to collect for AstroPay in each new LATAM country, update l10n files - https://phabricator.wikimedia.org/T124329#1952914 (DStri... [17:31:41] Fundraising Sprint Bloodletting 2016, Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, and 3 others: fix SmashPig job runner failure mode - https://phabricator.wikimedia.org/T117447#1774532 (DStrine) [18:08:13] well unsurprisingly this CI change is spiraling into abject chaos [18:08:21] oh no! [18:08:22] Woooo! [18:08:32] Keep your hands in the air. [18:08:48] is the shared 'src' workspace a problem? [18:08:49] "do the tests pass?" is basically like asking "is the cat alive?" [18:08:56] :/ [18:09:03] d'oh [18:09:16] ejegg: nah i got all that figured out [18:09:23] About six years ago, Selenium was like that all the time. [18:09:41] K4-713: totally, browser tests are always like that [18:09:44] Run the same suite twice in a row and get totally different answers. [18:09:45] or used to be anyway [18:09:57] Run all the tests singly and they all pass, all the time. [18:10:23] the problem here is basically there are N different configurations and no two work the same [18:10:27] just a for instance: [18:10:46] core/tests/phpunit/phpunit.php is _completely different_ between master and 1.25 [18:11:12] ooh, so we would need to dredge up old version of all the CI scripts [18:12:06] Oh, barf. [18:12:14] so hilariously if you check out REL1_25 on all of the submodules the tests pass [18:12:19] *That* kind of "different configurations." [18:12:29] but this bears no resemblance to our production setup [18:12:59] also, i'm still sort of murky on this, but i have a strong feeling our tests wouldn't pass against our production setup [18:13:01] ooh right, we don't want vendor at master either [18:13:10] cwd wait what? [18:13:20] I mean, besides the fact that we delete tests [18:13:36] yeah i mean DI at master but everything else at the deployed state [18:13:39] I can run unit tests locally against fundraising/REL1_25 with all the submodules [18:13:57] running _all_ the tests blows up a million different ways [18:14:07] So... when I run tests on my local... [18:14:12] oh, you mean not just DonationInterface [18:14:17] ...I have a totally different instance with basically no config. [18:14:31] K4-713: yeah i use a different localsettings for sure [18:14:58] this is *basically* how integration runs the tests: php /srv/core/tests/phpunit/phpunit.php --with-phpunitdir "/srv/core/vendor/phpunit/phpunit" --testsuite extensions [18:15:14] There's that whole mysql prep script that I don't run locally [18:15:30] I've always locally run the DI tests on our payments branch of mediawiki. [18:15:42] Though, I haven't done that in a really, really long time. [18:15:46] It might have walked off. [18:15:56] so it's running more stuff than just --group DonationInterface [18:16:02] what specifically...i'm still digging at that [18:26:22] heh also the phpunit version in vendor matters [18:26:30] (which isn't installed on 1.25) [18:28:12] unless it actually doesn't because integration is using system phpunit (need to find out if that is true) [18:28:43] utterly macabre [18:31:52] ooh, I think phpunit might have been added to vendor after 1.25 [18:32:07] when I run tests locally in 1.25 it uses system phpunit [18:32:19] but on 1.27 it's the vendor version [18:32:30] yeah [18:32:45] so the tests probably wouldn't pass on CI by simple virtue of a different phpunit version [18:32:49] the tests for our live setup [18:33:26] they totally run different sets of tests [18:33:44] ok my brain hurts i gotta get outta here for a little while [18:34:48] (CR) Ejegg: [C: 2] "Works for me! So this isn't a foreign key to anything - all I can see is that it shows this ID on the invoice for cancelled / returned don" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/266951 (https://phabricator.wikimedia.org/T123305) (owner: Eileen) [18:56:01] Fundraising Sprint Yo La Tengo, Fundraising Sprint Zapp, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Spike [2 hours]: QuickSurveys deployment process - https://phabricator.wikimedia.org/T119632#1979043 (jhobs) So the email that was sitting as a reminder for me to add Jon's questi... [19:54:22] (CR) XenoRyet: [C: 2] "Looks good, and does what it says." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/261601 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [20:03:27] (Merged) jenkins-bot: CRM-17751 add refund trxn to forms [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/261601 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [20:46:41] ejegg: are there patches for https://phabricator.wikimedia.org/T122244? [20:46:51] Also hi all! [20:47:00] Hi AndyRussG! [20:47:14] Yep, there's one in DI and a few in SmashPig [20:47:20] Ah K [20:47:27] Didn't see 'em in the tazk [20:47:41] ah, I think the privte task is hidden from grrrt-bot [20:47:53] Ah K [20:47:58] https://gerrit.wikimedia.org/r/266295 [20:48:07] Is it OK maybe to put 'em in a Phab comment? [20:48:17] sure, lemme do that now [20:48:23] Ah k thx!! [20:53:05] AndyRussG: ok, bottom comment links to patches [20:53:13] ejegg: woooho thx! [21:00:04] There are a few little DonationInterface patches I'd like to merge so they don't get forgotten, too: [21:00:22] (single line) https://gerrit.wikimedia.org/r/263922 [21:00:47] (simplify a session_ function to reflect use): https://gerrit.wikimedia.org/r/265556 [21:01:29] (don't blow up under Drupal if you try to start a session): https://gerrit.wikimedia.org/r/266254 [21:36:04] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Zapp, Fundraising-Backlog: Spike: Is it a problem that the Silverpop export is still not updating entire database? - https://phabricator.wikimedia.org/T120880#1979657 (CCogdill_WMF) @Ejegg thanks for... [22:02:06] ejegg: K all set! sorry for the delay 8p [22:02:17] no prob, lemme send you a chat request [22:03:28] AndyRussG: emailed [22:05:53] (CR) XenoRyet: [C: 2] Omitted line from RequestContext cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263922 (owner: Ejegg) [22:20:59] (CR) XenoRyet: [C: 2] "Love getting rid of unused code" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/265556 (owner: Ejegg) [22:43:39] (CR) XenoRyet: [C: 2] Fix WmfFramework::setupSession under drupal [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266254 (owner: Ejegg) [22:44:53] (Merged) jenkins-bot: Fix WmfFramework::setupSession under drupal [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266254 (owner: Ejegg) [22:56:26] (PS2) Ejegg: Quit double-staging Adyen data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266293 [23:01:18] cwd: gonna take me a minute to kick down a door [23:01:31] np! [23:17:15] awight: https://gerrit.wikimedia.org/r/#/c/266653/ [23:17:35] https://gerrit.wikimedia.org/r/267183 [23:22:44] mwext-DonationInterface-testextension-php53-core1_25 ? [23:26:24] (PS5) Ejegg: Omitted line from RequestContext cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263922 [23:28:07] (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263922 (owner: Ejegg) [23:30:33] https://github.com/openstack-infra/zuul [23:30:56] (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263922 (owner: Ejegg) [23:31:12] https://storyboard.openstack.org/#!/project/679 [23:32:17] https://storyboard.openstack.org/#!/story/1235005 [23:32:18] Fundraising-Analysis, Research consulting, Research-and-Data: Scope donor contribution campaign test - https://phabricator.wikimedia.org/T104652#1980203 (DarTar) Open>declined a:DarTar Closing this as it's unlikely anyone will work on this anytime soon. [23:33:45] XenoRyet: mind re-applying your +2 to https://gerrit.wikimedia.org/r/#/c/263922/ ? It needed a rebase, and the darn auto-merge just wouldn't take it after that. I think it's triggered on a new +2, so I took yours off for another try [23:33:59] Yea, no problem. [23:34:05] thanks [23:34:18] (CR) XenoRyet: [C: 2] Omitted line from RequestContext cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263922 (owner: Ejegg) [23:37:34] https://wikitech.wikimedia.org/wiki/Nova_Resource:Integration [23:37:43] cwd: ssh integration-slave-precise-1011.eqiad.wmflabs [23:38:20] Host *.eqiad.wmflabs [23:38:20] ProxyCommand ssh -a -W %h:%p bastion1.eqiad.wmflabs [23:49:37] awight: maybe attaching the job to the repo is a layout.yaml thing? [23:50:02] that file... [23:50:04] * cwd shudders [23:51:32] (Merged) jenkins-bot: Omitted line from RequestContext cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/263922 (owner: Ejegg) [23:51:56] (PS4) Ejegg: Simplify session_hasDonorData [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/265556 [23:54:46] XenoRyet: could you plz give ^^ the same treatment? [23:55:11] (CR) XenoRyet: [C: 2] Simplify session_hasDonorData [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/265556 (owner: Ejegg) [23:55:17] There you go. [23:55:20] ty! [23:55:32] no worries [23:57:00] gonna relocate, will check in again later. see yas [23:58:44] (Merged) jenkins-bot: Simplify session_hasDonorData [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/265556 (owner: Ejegg) [23:59:54] Fundraising Sprint Bloodletting 2016, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, and 2 others: CI: test DonationInterface against fundraising/REL1_25 - https://phabricator.wikimedia.org/T124105#1980343 (cwdent) @hashar Ok, the latest PS passes: https://gerr...