[00:25:31] (CR) Eileen: "I feel like there must be a slogan in there somewhere :-)" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/261601 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [00:27:52] (CR) Eileen: "Yeah - the credit note functionality was part of a feature to add support for VAT and there are some UK accounting requirements in there. " [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/266951 (https://phabricator.wikimedia.org/T123305) (owner: Eileen) [04:02:24] Fundraising-Analysis, Research management, Research-and-Data-Archive: Big English data analysis support - https://phabricator.wikimedia.org/T118054#1980746 (DarTar) [04:08:10] Fundraising-Analysis, Research management, Research-and-Data-Archive: Hire FR data analysis contractor - https://phabricator.wikimedia.org/T118957#1980760 (DarTar) [07:39:20] (CR) Awight: [C: 2] "Aah, the fee... Yeah I agree that would be overkill, and almost certainly incorrect anyway." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/266468 (owner: Eileen) [07:41:06] (CR) Awight: Update Mark Refund function to reflect use of financial_trxns (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/261757 (owner: Eileen) [07:41:10] (PS4) Awight: Update Mark Refund function to reflect use of financial_trxns [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/261757 (owner: Eileen) [07:43:19] (CR) jenkins-bot: [V: -1] Update Mark Refund function to reflect use of financial_trxns [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/261757 (owner: Eileen) [07:53:40] (CR) Awight: [C: -1] "Oops, I started reviewing this and then realized it couldn't be right, this patch must be stale, from before we decided to delegate to Civ" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/261757 (owner: Eileen) [07:54:33] (PS5) Awight: [WIP] Update Mark Refund function to reflect use of financial_trxns [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/261757 (owner: Eileen) [07:55:23] (CR) Awight: "This can probably be cherry-picked onto master, since it's independent of the other patches?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/260320 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [07:56:14] (CR) jenkins-bot: [V: -1] [WIP] Update Mark Refund function to reflect use of financial_trxns [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/261757 (owner: Eileen) [07:57:19] (PS4) Awight: Fix gateway reconciliation report to use transactions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/260320 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [08:04:11] (CR) Awight: [C: 2] "It even works!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/260320 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [08:04:41] (PS2) Awight: Allow setting read timeouts per queue [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/261613 (owner: Ejegg) [08:06:35] (Merged) jenkins-bot: Fix gateway reconciliation report to use transactions [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/260320 (https://phabricator.wikimedia.org/T116317) (owner: Eileen) [08:08:26] (CR) Awight: [C: 2] "Why just the one place?" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/261613 (owner: Ejegg) [08:08:35] (PS3) Awight: Allow setting read timeouts per queue [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/261613 (owner: Ejegg) [08:09:00] (CR) jenkins-bot: [V: -1] Allow setting read timeouts per queue [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/261613 (owner: Ejegg) [08:12:17] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: LYBUNT query cleanup - https://phabricator.wikimedia.org/T119036#1980982 (awight) [08:32:49] (CR) Awight: [C: -1] "Could be worth writing a test? Also, I wonder whether the default zone maps need to be kept secret or not... We definitely do want to pr" (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266456 (https://phabricator.wikimedia.org/T120255) (owner: XenoRyet) [17:15:41] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add 'refunded because fraud' checkbox to contribution edit screen. - https://phabricator.wikimedia.org/T125224#1981923 (Ejegg) NEW [18:26:18] (CR) Ejegg: "Clever! I tried it with the suggested settings against 125 refunded FR donations from November and December. It caught 14 of the gibberish" (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266456 (https://phabricator.wikimedia.org/T120255) (owner: XenoRyet) [18:32:13] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Zapp, Fundraising-Backlog, and 2 others: Civi exports timing out - https://phabricator.wikimedia.org/T120892#1982210 (JCuriel) I tried switching from Firefox to Chrome, to see if maybe that would help... [19:01:10] Hey ejegg... You mentioned yesterday that some of the interactions for GlobalCollect are documented? Is that all in one place? I'm thinking maybe looking at that, if there is such, to write up something similar for Adyen... thx! [19:02:22] AndyRussG: I was just looking at some stuff on collab - let me pull that back up [19:02:33] ejegg: ah cool thx! [19:10:07] (CR) XenoRyet: "Yea, I'll write a test for it. I'm not sure whether the zone maps do need to be private or not. If you knew them, you could defeat them " [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266456 (https://phabricator.wikimedia.org/T120255) (owner: XenoRyet) [19:13:09] (CR) Awight: "We should at least provide a demonstration default value... I don't have a strong opinion whether we include the real settings or not, any" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266456 (https://phabricator.wikimedia.org/T120255) (owner: XenoRyet) [19:22:54] ejegg: what are the main entry points for the gateway adapters? [19:23:57] eileen1: Hi! Please lmk if there's more I should look at for the refund work. [19:24:03] Might be easiest to look at it from the special pages and api endpoints, AndyRussG [19:24:43] AndyRussG: Also, we're trying to standardize on doPayment, so that specific workflows are transparent to calling code [19:25:02] yeah, that's a good one to start with! [19:25:11] Right the special pages being adyen_gateway.body.php and the parent, GatewayPage [19:25:16] awight: ejegg: ah K sounds good [19:25:17] It returns a Command pattern sort of thing, which encodes how the UI is supposed to respond [19:25:45] Ah K iiinteresting ;) [19:28:44] Right, it's a PaymentResult, which can be fatally failed, non-fatally failed, redirect, successful, iframe, or [19:29:22] cwd|afk: Creepy CI error, seems to be unrelated to your work but possibly related to the bug you saw: https://integration.wikimedia.org/ci/job/wikimedia-fundraising-civicrm/1633/console [19:29:44] ah, forget that last ', or' [19:30:09] (PS2) Awight: Remove "too many banners" warning [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/247785 (https://phabricator.wikimedia.org/T109714) [19:30:46] Fundraising Sprint Bloodletting 2016, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Easy, Patch-For-Review: Unnecessary bucket warnings in campaign settings - https://phabricator.wikimedia.org/T109714#1982524 (awight) Moving to sprint cos it's an easy review [19:31:04] Fundraising Sprint Bloodletting 2016, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Easy, Patch-For-Review: Unnecessary bucket warnings in campaign settings - https://phabricator.wikimedia.org/T109714#1982529 (awight) a:awight [19:35:14] AndyRussG: Some parts aren't standardized on doPayment yet though [19:35:38] for instance, DonationApi calls globalcollect's do_transasction function directly [19:39:46] AndyRussG: and when the donor comes back to the result switcher / return url, we generally call processResponse [19:40:12] hmmm K [19:40:45] err, though that's kind of mushy [19:42:08] I guess some adapters use processResponse to handle API responses from server to server calls. [19:42:28] maybe I should rename it when it's used in the resultswitcher context [19:44:04] mush_response [19:44:17] unstage_garble [19:44:23] hehe [19:44:34] addSquishyData [19:55:52] Fundraising Sprint Bloodletting 2016, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice impressions beacon corrupts 'mixins' property - https://phabricator.wikimedia.org/T120082#1982591 (awight) a:AndyRussG [20:53:16] awight: hmm! i wonder... [21:10:38] AndyRussG: https://collab.wikimedia.org/wiki/Fundraising/Fraud_Filtering_Documentation fwiw [21:11:06] awight: yep! hoping to fill out for Adyen :) [22:03:10] awight: i think people wanna pat you on the back in -staff [22:06:28] (CR) Ejegg: "Looks like a huge win! Think I found some more cruft that can go if you want to optimize further." (6 comments) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/265143 (https://phabricator.wikimedia.org/T123671) (owner: Eileen) [22:27:45] gotta head out. Have a great weekend all! [22:27:59] You too, catch ya later [22:28:01] see ya! [23:09:27] gon relocate [23:23:23] guys. especially K4-713 https://www.youtube.com/watch?v=uJ3kV3Icm28 [23:23:52] I have that on my ipod. :D [23:33:29] Well, I know what I"m listening to for the next 15 minutes :) [23:38:01] also good: http://www.discogs.com/Electric-Moog-Orchestra-Music-From-Star-Wars/release/476287