[00:34:53] <grrrit-wm>	 (PS3) Cdentinger: Quit double-staging Adyen data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266293 (owner: Ejegg)
[00:35:00] <grrrit-wm>	 (CR) Cdentinger: [C: 2] Quit double-staging Adyen data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266293 (owner: Ejegg)
[00:36:22] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Quit double-staging Adyen data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266293 (owner: Ejegg)
[00:41:58] <wikibugs>	 Fundraising Sprint Bloodletting 2016, Wikimedia-Fundraising-CiviCRM: Please refresh staging DB - https://phabricator.wikimedia.org/T125445#1988472 (Eileenmcnaughton) Thanks for dealing with this so quickly!
[00:42:38] <wikibugs>	 Fundraising Sprint Bloodletting 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: [Epic] Restore Civi manual refund functionality - https://phabricator.wikimedia.org/T124979#1988473 (Eileenmcnaughton) @ejegg - update on https://issues.civicrm.org/jira/browse/CRM-17951 - seems along the lines o...
[14:13:29] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising: 'continue' button on the iDeal donation form not working - https://phabricator.wikimedia.org/T125470#1989752 (Pcoombe) Thanks. When I tried just now, I was able to reach the bank pages for ABN AMRO, ING, SNS Bank and ASN Bank, but not any of the other banks.
[16:59:33] <wikibugs>	 Fundraising Sprint Bloodletting 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Please refresh staging DB - https://phabricator.wikimedia.org/T125445#1990249 (DStrine)
[17:52:12] <grrrit-wm1>	 (PS1) Ejegg: WIP read refunds from Adyen audit files [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/267926
[18:29:37] <ejegg>	 phooey, I need to redo the whole Adyen audit processor
[18:30:44] <cwd>	 ejegg: how come?
[18:46:55] <grrrit-wm1>	 (CR) Ejegg: [C: -1] "Going to make the bigger change, getting rid of limbo message and queueing pending message before opening iframe" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266295 (https://phabricator.wikimedia.org/T122244) (owner: Ejegg)
[19:00:14] <grrrit-wm1>	 (CR) Cdentinger: "check experimental" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/260228 (https://phabricator.wikimedia.org/T96047) (owner: Awight)
[19:23:09] <grrrit-wm>	 (PS7) Ejegg: Run fraud checks before Adyen payment capture [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/266434 (https://phabricator.wikimedia.org/T122244)
[19:24:38] <grrrit-wm>	 (PS8) Ejegg: Run fraud checks before Adyen payment capture [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/266434 (https://phabricator.wikimedia.org/T122244)
[19:35:42] <grrrit-wm>	 (PS5) Ejegg: Add risk score to Adyen pending queue message [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266295 (https://phabricator.wikimedia.org/T122244)
[19:38:25] <ejegg>	 hmm, still not sure that's the best way
[19:39:56] <ejegg>	 just remembered that the limbo queue Adyen uses is readable by the IPN.  So maybe it makes more sense to use that as a backup when the pending queue message is missing
[19:40:52] <ejegg>	 slightly unnecessary message juggling, but would be using the queues as they're labeled
[19:41:30] <grrrit-wm>	 (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266293 (owner: Ejegg)
[20:15:29] <wikibugs>	 Fundraising-Backlog, Epic: [EPIC] Create Preference Center for donors to manage email subscription preferences - https://phabricator.wikimedia.org/T125272#1991303 (DStrine)
[20:16:31] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add 'refunded because fraud' checkbox to contribution edit screen. - https://phabricator.wikimedia.org/T125224#1991313 (atgo) Hey @mbeat33 what do you think about this?
[20:22:00] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add 'refunded because fraud' checkbox to contribution edit screen. - https://phabricator.wikimedia.org/T125224#1991357 (MBeat33) @atgo I love it, great idea. It'll be easy to add this to the DS process for refunds once we can do them in Civi again.
[20:22:17] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Clean up old-style refunds created since upgrade - https://phabricator.wikimedia.org/T124984#1991358 (DStrine)
[20:22:19] <wikibugs>	 Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Remove duplicate refunded status & transfer contributions with this status to the original Refunded status - https://phabricator.wikimedia.org/T123329#1991359 (DStrine)
[20:25:57] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Clean up old-style refunds created since upgrade - https://phabricator.wikimedia.org/T124984#1991392 (Eileenmcnaughton) I think the task to remove the duplicate refunded status is enough - they will wind up with appropriate financial_trxn table entries....
[20:27:12] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Allow fallback to alternative campaign if mixin would hide this one - https://phabricator.wikimedia.org/T124969#1991396 (atgo) @andyrussg has the most domain knowledge here, and he's working on the ed program for the month. We will look into this a...
[20:27:44] <wikibugs>	 Fundraising-Backlog: Update email address for MG in 'too large amount' error message - https://phabricator.wikimedia.org/T124935#1991404 (atgo) @pcoombe is this on donatewiki? Something you can update?
[20:28:24] <wikibugs>	 Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Create a dev 'thank you' page that posts an IPN message - https://phabricator.wikimedia.org/T124854#1991408 (atgo)
[20:34:44] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: [epic] Make deduping reversible - https://phabricator.wikimedia.org/T111704#1991442 (atgo)
[20:34:46] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: [epic] Dedupe exact matches - https://phabricator.wikimedia.org/T111702#1991443 (atgo)
[20:35:53] <wikibugs>	 Fundraising-Backlog: Q3 GOALS!  (January-March) Keep at top of Q3 column - https://phabricator.wikimedia.org/T117466#1775015 (atgo)
[20:35:55] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Epic, I18n: [Epic] Use translatable pages for banner content - https://phabricator.wikimedia.org/T116235#1991459 (atgo)
[20:36:02] <wikibugs>	 Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Zapp, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add indexes to CiviCRM entity financial transaction table - https://phabricator.wikimedia.org/T122947#1991462 (Eileenmcnaughton)
[20:36:04] <wikibugs>	 Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Fix speed issue when doing a refund in the UI - https://phabricator.wikimedia.org/T123305#1991461 (Eileenmcnaughton)
[22:12:01] <cwd>	 suddenly any calls to phpunit immediately exit 0 with no output
[22:18:06] <ejegg>	 cwd vagrant or real box?
[22:24:24] <cwd>	 ejegg: was my mistake
[22:24:30] <ejegg>	 k
[22:24:37] <cwd>	 i'm making a patch to intentionally break tests
[22:24:42] <ejegg>	 ah word
[22:25:54] <grrrit-wm1>	 (PS1) Cdentinger: DO NOT MERGE - breaking some tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/268013
[22:26:45] <grrrit-wm1>	 (CR) Cdentinger: "check experimental" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/268013 (owner: Cdentinger)
[22:27:14] <grrrit-wm1>	 (CR) jenkins-bot: [V: -1] DO NOT MERGE - breaking some tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/268013 (owner: Cdentinger)
[22:27:29] <ejegg>	 looks like that worked
[22:28:18] <cwd>	 rgh, actually that was the voting job that (correctly) rejected it
[22:28:28] <ejegg>	 ah
[22:28:33] <cwd>	 doesn't look like it made it to the experimental one
[22:28:43] <cwd>	 damn
[22:29:11] <cwd>	 so i'd have to change something that would pass against master but break against 1.25 to actually test
[22:29:25] <ejegg>	 hmm
[22:29:54] <cwd>	 ah never mind!
[22:29:59] <cwd>	 it ran after all, was just delayed
[22:31:16] <grrrit-wm1>	 (PS2) Cdentinger: DO NOT MERGE - breaking some tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/268013
[22:32:49] <grrrit-wm1>	 (CR) Cdentinger: "check experimental" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/268013 (owner: Cdentinger)
[22:38:09] <cwd>	 hey neat, for whatever reason the production build does not have the same dirty workspace problem as in testing.  just broke then fixed it, and it was successful the 2nd time.
[23:00:02] <grrrit-wm1>	 (Abandoned) Cdentinger: DO NOT MERGE - breaking some tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/268013 (owner: Cdentinger)
[23:02:59] <cwd>	 ejegg, XenoRyet -- i think this thing is probably ready to get put into place as the voting job, and make the current one non voting
[23:03:07] <cwd>	 do you guys have keys to the integration servers?
[23:03:09] <ejegg>	 nice!
[23:03:21] <ejegg>	 I can ssh into 'em
[23:03:29] <cwd>	 good deal
[23:03:48] <cwd>	 when we were testing a failed job would leave a state that the next run couldn't deal with
[23:03:59] <cwd>	 but that didn't happen when i just tested the actual job with the zuul hooks
[23:04:30] <cwd>	 so i'd say it's probably cool to switch em out, with the caveat that if that happens the quick fix is to ssh in and blow away the src dir
[23:04:42] <ejegg>	 ok, good to know!
[23:04:55] <cwd>	 it will say which box and the path to it at the top of the jenkins output
[23:05:12] <ejegg>	 yep!
[23:05:18] <cwd>	 but with any luck that won't even happen
[23:05:32] <ejegg>	 XenoRyet: speaking of unit tests, did you get 'em running under vagrant?
[23:05:37] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Criteria Sort in Advanced Search results doesn't work - https://phabricator.wikimedia.org/T118614#1992119 (MBeat33) This is working for me too, and I haven't noticed any issues - thanks.
[23:06:13] <ejegg>	 XenoRyet: I finally did, but I had to dig into the MWMultiVersion junk to get 'em running under /vagrant/mediawiki-fr
[23:06:24] <ejegg>	 I'll email the rest of the details
[23:06:37] <XenoRyet>	 No, not yet.  Seeing what you did would be helpful.
[23:11:51] <ejegg>	 emailed
[23:12:01] <XenoRyet>	 Cool, thanks, I'll take a look
[23:19:35] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Criteria Sort in Advanced Search results doesn't work - https://phabricator.wikimedia.org/T118614#1992226 (Eileenmcnaughton) Open>Resolved a:Eileenmcnaughton Yay! (that's an official response)
[23:28:26] <eileen1>	 ejegg: I just got off a call from Joe Murray re the refunds and I think we have a way forward - check https://issues.civicrm.org/jira/browse/CRM-17951  - I edited the description
[23:28:50] <ejegg>	 awesome, eileen1! I'll take a look in just a minute
[23:28:58] <eileen1>	 cool
[23:34:49] <grrrit-wm1>	 (PS3) Ejegg: Record Adyen payment on IPN capture notification [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/266930 (https://phabricator.wikimedia.org/T121158)
[23:34:51] <grrrit-wm1>	 (PS9) Ejegg: Run fraud checks before Adyen payment capture [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/266434 (https://phabricator.wikimedia.org/T122244)
[23:34:53] <grrrit-wm1>	 (PS6) Ejegg: Add message to antifraud queue in capture job [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/266643 (https://phabricator.wikimedia.org/T122244)
[23:35:35] <grrrit-wm1>	 (CR) Ejegg: "PS6: rebase" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/266643 (https://phabricator.wikimedia.org/T122244) (owner: Ejegg)
[23:37:28] <ejegg>	 cwd would you mind re-submitting https://gerrit.wikimedia.org/r/#/c/266293/ ? zuul glich screwed up the gate + submit last time
[23:38:00] <grrrit-wm1>	 (CR) Cdentinger: [C: 2] Quit double-staging Adyen data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266293 (owner: Ejegg)
[23:38:05] <ejegg>	 thanks!
[23:38:06] * cwd shakes fist at zuul
[23:38:20] <cwd>	 np!
[23:38:47] <ejegg>	 I'll rebase the 'risk_score' one over it as soon as it merges, think i need to do it manually
[23:39:29] <grrrit-wm1>	 (Merged) jenkins-bot: Quit double-staging Adyen data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266293 (owner: Ejegg)
[23:41:24] <grrrit-wm1>	 (PS6) Ejegg: Add risk score to Adyen pending queue message [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266295 (https://phabricator.wikimedia.org/T122244)
[23:41:55] <ejegg>	 ah cool, autorebase worked
[23:48:38] <wikibugs>	 Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising-Backlog, FR-Adyen: Adyen listener: reschedule capture on missing "pending" message - https://phabricator.wikimedia.org/T120798#1992326 (Ejegg) Open>declined a:Ejegg This shouldn't be needed if we add...