[15:51:27] Fundraising-Backlog: No banner impressions since 4 Feb - https://phabricator.wikimedia.org/T126228#2008017 (Pcoombe) NEW [15:51:42] Fundraising-Backlog: No banner impression data since 4 Feb - https://phabricator.wikimedia.org/T126228#2008026 (Pcoombe) [15:58:43] Jeff_Green: looks like the queue was pretty flakey over the weekend [16:18:17] Fundraising-Backlog: No banner impression data since 4 Feb - https://phabricator.wikimedia.org/T126228#2008145 (cwdent) Amongst all the alert emails over the weekend I did see several that looked like failing to connections to silicon, Jeff probably knows more. [16:18:41] hard to hear over the din of worldpay [17:02:01] Fundraising-Backlog: No banner impression data since 4 Feb - https://phabricator.wikimedia.org/T126228#2008280 (Jgreen) The banner history problem is the exact same cause as before, somehow I managed to revert the fix. I will fix this today and re-do the backfill. [17:02:51] Fundraising-Backlog: No banner impression data since 4 Feb - https://phabricator.wikimedia.org/T126228#2008290 (Jgreen) >>! In T126228#2008145, @cwdent wrote: > Amongst all the alert emails over the weekend I did see several that looked like failing to connections to silicon, Jeff probably knows more. This... [17:24:07] Fundraising-Backlog: No banner impression data since 4 Feb - https://phabricator.wikimedia.org/T126228#2008360 (Jgreen) re. backfilling, last logged line was: 2016-02-04T20:47:39 [18:22:35] ejegg: finally tracked down that strange hang when trying to open the iframe, it was from the pending queue being commented out [18:23:49] (PS3) XenoRyet: Nonsense Name Fraud Filter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266456 (https://phabricator.wikimedia.org/T120255) [18:24:50] (CR) jenkins-bot: [V: -1] Nonsense Name Fraud Filter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266456 (https://phabricator.wikimedia.org/T120255) (owner: XenoRyet) [19:04:38] (CR) Ejegg: "Looks like the tests need some values for the filter globals. You should at least have empty arrays or zeros with doc comments in Donation" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266456 (https://phabricator.wikimedia.org/T120255) (owner: XenoRyet) [19:30:29] Fundraising-Backlog: No banner impression data since 4 Feb - https://phabricator.wikimedia.org/T126228#2009158 (Pcoombe) Hi @Jgreen, any ETA on this? The backfilling can wait, but we would like to have new impressions coming in before we start the Sweden campaign. [19:41:36] (PS2) Eileen: Add Entity Financial Account api [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/268614 (https://phabricator.wikimedia.org/T124979) [19:42:14] (CR) Eileen: "resubmitted without dependency" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/268614 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [19:45:17] Fundraising-Backlog: No banner impression data since 4 Feb - https://phabricator.wikimedia.org/T126228#2009249 (Jgreen) The configuration is fixed and the backfilling process has already started, I think we'll be caught up in 8-12 hours. To clarify, backfilling was a bad description on my part. What we do... [19:45:59] (PS2) Eileen: CRM-17951 preliminary refactoring to improve code legibility [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/268460 [19:49:52] (PS2) Eileen: CRM-17951 ( merged into 4.7) add support for Chargeback contribution status and having an account relationship for refunds. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/268459 (https://phabricator.wikimedia.org/T124979) [19:51:00] (Abandoned) Eileen: CRM-17951 (pending 4.7) add Contribution Status of Chargeback [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/268461 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [19:51:56] (CR) jenkins-bot: [V: -1] CRM-17951 ( merged into 4.7) add support for Chargeback contribution status and having an account relationship for refunds. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/268459 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [20:06:35] Fundraising-Backlog: No banner impression data since 4 Feb - https://phabricator.wikimedia.org/T126228#2009374 (Pcoombe) Okay, thanks for the clarification. [20:18:30] (PS1) Eileen: Update Mark Refund to report error [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269200 (https://phabricator.wikimedia.org/T124979) [20:22:30] (CR) Eileen: "Running the patch with this https://gerrit.wikimedia.org/r/#/c/269200/ reveals a dependency on https://gerrit.wikimedia.org/r/#/c/268614/ " [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/268459 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [20:23:26] If anyone wants to review this it will make it easier for me to line up the dependency chain :-) https://gerrit.wikimedia.org/r/#/c/268614/ [20:28:36] looking... [20:34:37] (CR) Ejegg: [C: 2] "Mmm, API capabilities! Looks very straightforward." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/268614 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [20:39:12] (CR) Ejegg: "Just one question" (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/268447 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [20:39:50] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/268459 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [20:41:54] (CR) Eileen: CRM-17951 (merged into 4.7) modify transaction view to show the financial account of the transaction (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/268447 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [20:49:10] ejegg: thanks for that - now it's passing locally but not on gerrit :-( [20:49:24] hmm, let's see [20:49:29] I used this locally to get the real error https://gerrit.wikimedia.org/r/#/c/269200/ [20:49:37] (rather than that db_error fail) [20:49:47] (PS2) Ejegg: CRM-17951 form fixes to make chargeback more consistent with refund behaviour [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/268617 (owner: Eileen) [20:50:19] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/268735 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [20:54:00] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/268459 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [20:57:52] (CR) Ejegg: "Tests pass, but this should merge after I6956f8266f41 which creates the isContributionStatusNegative function" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/268617 (owner: Eileen) [20:58:28] Wikimedia-Fundraising-CiviCRM: Sync our buildkit with upstream - https://phabricator.wikimedia.org/T126266#2009593 (Eileenmcnaughton) NEW [21:15:05] (CR) Cdentinger: Add risk score to Adyen pending queue message (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266295 (https://phabricator.wikimedia.org/T122244) (owner: Ejegg) [21:19:29] (CR) Ejegg: Add risk score to Adyen pending queue message (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266295 (https://phabricator.wikimedia.org/T122244) (owner: Ejegg) [21:23:19] Fundraising-Backlog: JCB card not an option for recurring donation in Japanese form - https://phabricator.wikimedia.org/T126268#2009657 (MBeat33) NEW [21:30:08] ejegg: do you want to look at this - https://gerrit.wikimedia.org/r/#/c/269200/ - if we merge that then we will get better messages on the one that IS failing [21:31:00] (it's kinda interim since I think that code changes again in the mark_refund update) [21:33:41] sure, after this 1:1 with K4! [21:34:26] ejegg: cool [21:57:35] (CR) Ejegg: [C: 2] "Nice! Looks like this will give better info than my attempt." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269200 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [21:58:26] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/268459 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [21:58:38] (Abandoned) Ejegg: Remove obsolete db_error() calls [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/268838 (owner: Ejegg) [22:01:55] ejegg: I'm just trying to run the upgrade script on staging now - it did hit an error - which I've hopefully sorted out [22:03:00] k [22:04:16] It's doing my head in figuring out the right order for all the commits :-) [22:04:25] heh [22:07:37] (PS3) Ejegg: CRM-17951 preliminary refactoring to improve code legibility [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/268460 (owner: Eileen) [22:12:24] (CR) Ejegg: [C: 2] "Much nicer" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/268460 (owner: Eileen) [22:16:49] (PS1) Ejegg: Don't error on bad contribution source [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269307 [22:18:59] (CR) jenkins-bot: [V: -1] Don't error on bad contribution source [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269307 (owner: Ejegg) [22:22:44] (CR) Ejegg: "Weird, how are we getting an undefined index error?" (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/268459 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [22:25:00] ejegg: I think that undefined index is because a fix in the CRM repo needs merging to add before it will work - I'm not getting it locally and locally I have run all the db updates [22:25:24] ah, I think I see which one. [22:25:55] (PS1) Eileen: Fix update script not to fall over on missing check_number [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269312 (https://phabricator.wikimedia.org/T124979) [22:25:58] (CR) Ejegg: [C: 2] "Looks good, works on my machine" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/268735 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [22:26:28] yep - it's really confusing having the 2 interdependent repos! [22:26:29] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/268459 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [22:26:59] for reals [22:29:24] (PS8) Eileen: Update Mark Refund function to reflect use of financial_trxns [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/261757 [22:30:23] The upgrade script completed on staging in ~25 mins [22:30:42] (CR) jenkins-bot: [V: -1] Update Mark Refund function to reflect use of financial_trxns [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/261757 (owner: Eileen) [22:30:51] I had to make 1 change https://gerrit.wikimedia.org/r/#/c/269312/ [22:30:55] (PS2) Ejegg: Fix update script not to fall over on missing check_number [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269312 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [22:31:56] (CR) Ejegg: [C: 2] "Nice! I had to fix payment_instrument_id as well to make it run locally, but I guess my fake data may be even less consistent than our rea" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269312 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [22:32:33] eileen: 25 minutes isn't too bad at all [22:33:20] (PS9) Eileen: Update Mark Refund function to reflect use of financial_trxns [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/261757 (https://phabricator.wikimedia.org/T124979) [22:33:25] nah - it's liveable [22:35:01] (CR) jenkins-bot: [V: -1] Update Mark Refund function to reflect use of financial_trxns [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/261757 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [22:41:14] (CR) Eileen: "Looks like this has an abandoned dependency" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/268459 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [22:44:24] (PS10) Eileen: Update Mark Refund function to reflect use of financial_trxns [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/261757 (https://phabricator.wikimedia.org/T124979) [22:47:00] (CR) jenkins-bot: [V: -1] Update Mark Refund function to reflect use of financial_trxns [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/261757 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [22:53:31] (PS11) Eileen: Update Mark Refund function to reflect use of financial_trxns [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/261757 (https://phabricator.wikimedia.org/T124979) [22:54:33] (CR) Eileen: "I tried to do a merge fix & managed to revert to an older version - I think this is the right version now!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/261757 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [22:56:07] (CR) jenkins-bot: [V: -1] Update Mark Refund function to reflect use of financial_trxns [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/261757 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [23:00:32] (CR) Eileen: "I'm going to re-send this for review without the dependency" (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/268459 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [23:00:58] (CR) Eileen: "This is failing because https://gerrit.wikimedia.org/r/#/c/268459/ is not merged" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/261757 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [23:02:03] (PS3) Eileen: CRM-17951 ( merged into 4.7) add support for Chargeback contribution status and having an account relationship for refunds. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/268459 (https://phabricator.wikimedia.org/T124979) [23:04:10] (PS3) Eileen: CRM-17951 form fixes to make chargeback more consistent with refund behaviour [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/268617 [23:04:21] (PS2) Eileen: CRM-17951 form fixes for chargeback [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/268618 (https://phabricator.wikimedia.org/T124979) [23:07:59] (CR) Ejegg: [C: -1] "Couple concerns" (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/268459 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [23:09:53] (CR) Ejegg: "oops, one of the comments was on the wrong patch set" (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/268459 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [23:34:56] (PS1) Eileen: Search speed fix - partial backport of CRM-17492 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/269332 (https://phabricator.wikimedia.org/T123418) [23:41:56] (CR) Eileen: "Just tested on staging and this is 'ok as far as it goes' but there isn't actually an index on contribution_source to use - so we need to " [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/269332 (https://phabricator.wikimedia.org/T123418) (owner: Eileen) [23:58:17] (CR) Ejegg: [C: 2] "Looks good" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/269332 (https://phabricator.wikimedia.org/T123418) (owner: Eileen)