[00:01:43] (CR) Eileen: [C: 2] "I always feel a bit sad when code tidy up involves removing comments that amuse me" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269569 (https://phabricator.wikimedia.org/T124842) (owner: Ejegg) [00:03:03] heh, we had to tearfully kill off message<->antimessage collision last summer when we switched to a queue backend that actually supported deletion [00:15:36] (PS1) Ejegg: Update archaic chargeback import logic [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269570 (https://phabricator.wikimedia.org/T124842) [00:16:52] (PS12) Eileen: Update Mark Refund function to reflect use of financial_trxns [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/261757 (https://phabricator.wikimedia.org/T124979) [00:18:00] (CR) Eileen: "All good points!" (5 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/261757 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [00:18:40] (CR) jenkins-bot: [V: -1] Update Mark Refund function to reflect use of financial_trxns [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/261757 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [00:25:59] (CR) Ejegg: "keeping debug sounds good! Trying to figure out that test fail - update_7100 should have ensured 'Chargeback' exists, right?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/261757 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [00:26:03] (CR) Eileen: "This raises a question about exception handling (see comments). Apart from that we only seem to lose the editing of source to include" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269570 (https://phabricator.wikimedia.org/T124842) (owner: Ejegg) [00:29:41] (CR) Eileen: "There is some static caching going on which might be causing us a problem in the tests" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/261757 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [00:34:13] (CR) Ejegg: "good point on the exception handling. About the static caching, I guess you could call civicrm_api_option_group( 'contribution_status', nu" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/261757 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [00:36:51] (PS13) Eileen: Update Mark Refund function to reflect use of financial_trxns [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/261757 (https://phabricator.wikimedia.org/T124979) [00:41:33] (PS14) Eileen: Update Mark Refund function to reflect use of financial_trxns [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/261757 (https://phabricator.wikimedia.org/T124979) [00:41:44] I need to head out soon, but I'll check in on refund stuff in a few hrs [00:42:05] ejegg: ok I've just updated mark_refund with exception handling [00:42:14] thanks! [00:42:49] so I'm Ok to merge your one - since we put the fix into my one [00:43:09] sounds right [00:44:00] (CR) Eileen: [C: 2] "Exception handling now in mark_refund and re my question about the return value - it's not required" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269570 (https://phabricator.wikimedia.org/T124842) (owner: Ejegg) [00:44:27] see ya later [00:44:28] And it's passing! [00:44:30] see ya [00:58:18] (PS4) XenoRyet: Nonsense Name Fraud Filter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266456 (https://phabricator.wikimedia.org/T120255) [01:03:52] (CR) jenkins-bot: [V: -1] Nonsense Name Fraud Filter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266456 (https://phabricator.wikimedia.org/T120255) (owner: XenoRyet) [01:08:46] (PS5) XenoRyet: Nonsense Name Fraud Filter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266456 (https://phabricator.wikimedia.org/T120255) [01:46:37] (CR) Cdentinger: Nonsense Name Fraud Filter (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266456 (https://phabricator.wikimedia.org/T120255) (owner: XenoRyet) [01:51:18] Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising-Backlog, FR-Adyen, FR-Smashpig: Process refunds in Adyen audit file - https://phabricator.wikimedia.org/T121129#2013870 (cwdent) a:cwdent [01:55:21] (PS2) Cdentinger: Ensure Adyen result switcher logs correct OID [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/269339 (owner: Ejegg) [01:56:21] Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising-Backlog, FR-Adyen, FR-Smashpig: Process refunds in Adyen audit file - https://phabricator.wikimedia.org/T121129#2013879 (Eileenmcnaughton) Let me know if you need any updating on current status of the processing re... [01:59:42] Fundraising Sprint Cat Herding, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Fix WMF_donor rollup calculations to use financial transactions - https://phabricator.wikimedia.org/T124834#2013883 (Eileenmcnaughton) [02:00:04] (PS1) Eileen: Update contribution_post hook to look at transaction totals [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269587 (https://phabricator.wikimedia.org/T124834) [02:01:56] (CR) jenkins-bot: [V: -1] Update contribution_post hook to look at transaction totals [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269587 (https://phabricator.wikimedia.org/T124834) (owner: Eileen) [02:03:34] (CR) Cdentinger: Ensure Adyen result switcher logs correct OID [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/269339 (owner: Ejegg) [02:03:43] (CR) Cdentinger: [C: 2] Ensure Adyen result switcher logs correct OID [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/269339 (owner: Ejegg) [02:04:56] (Merged) jenkins-bot: Ensure Adyen result switcher logs correct OID [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/269339 (owner: Ejegg) [02:07:30] (CR) Eileen: "Further comments on the Phab ticket about the other fields" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269587 (https://phabricator.wikimedia.org/T124834) (owner: Eileen) [02:10:43] (CR) XenoRyet: Nonsense Name Fraud Filter (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266456 (https://phabricator.wikimedia.org/T120255) (owner: XenoRyet) [02:11:19] (PS6) XenoRyet: Nonsense Name Fraud Filter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266456 (https://phabricator.wikimedia.org/T120255) [02:15:04] (PS7) XenoRyet: Nonsense Name Fraud Filter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266456 (https://phabricator.wikimedia.org/T120255) [02:16:46] (PS8) XenoRyet: Nonsense Name Fraud Filter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266456 (https://phabricator.wikimedia.org/T120255) [02:17:40] (PS2) Eileen: Update contribution_post hook to look at transaction totals [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269587 (https://phabricator.wikimedia.org/T124834) [03:08:20] Fundraising Sprint Cat Herding, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Fix WMF_donor rollup calculations to use financial transactions - https://phabricator.wikimedia.org/T124834#2013947 (Eileenmcnaughton) I added a patch to the post to fix the usd lifetime total - I... [04:32:58] (PS1) Eileen: Update contribution_post hook to filter contributions for Completed status [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269599 (https://phabricator.wikimedia.org/T124834) [10:40:59] fundraising-tech-ops: db1008 (and fdb2001) periodically lags every day at the same time ~10:30UTC - https://phabricator.wikimedia.org/T126314#2014373 (jcrespo) This just happened again today at 10:30. [16:58:43] (PS1) Ejegg: Update audit refund matching logic [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269716 (https://phabricator.wikimedia.org/T124842) [17:55:03] Fundraising-Backlog: Recent up tick in fail mail - https://phabricator.wikimedia.org/T126482#2015550 (cwdent) NEW [18:49:27] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint William Shatner, and 5 others: Track email clickthroughs on donate wiki - https://phabricator.wikimedia.org/T114010#2015754 (CCogdill_WMF) Another round of emails went... [18:51:32] (CR) Cdentinger: [C: 2] Run fraud checks before Adyen payment capture [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/266434 (https://phabricator.wikimedia.org/T122244) (owner: Ejegg) [18:59:40] Fundraising-Backlog: Recent up tick in fail mail - https://phabricator.wikimedia.org/T126482#2015812 (Eileenmcnaughton) Error: INVALID_MESSAGE The refunded amount was greater than the payment: USD Are donor services being notified? Also I wonder what amount they exceed by - e.g if <.50cents && < x% of the... [19:13:57] (CR) Eileen: "OMG merged!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/261757 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [20:26:16] (PS1) Ejegg: Fix query string key case change [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/269820 (https://phabricator.wikimedia.org/T114010) [20:27:19] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Zapp, and 3 others: Add indexes to CiviCRM entity financial transaction table - https://phabricator.wikimedia.org/T122947#2016360 (Eileenmcnaughton) [20:28:51] (CR) Eileen: "This should have merged earlier I thought - retrying 'publish & submit'" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269569 (https://phabricator.wikimedia.org/T124842) (owner: Ejegg) [20:29:42] (PS2) Ejegg: Fix query string key case change [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/269820 (https://phabricator.wikimedia.org/T114010) [20:30:01] (PS1) Eileen: Cleanup: Drupal 7 hook_update_N signature [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269821 [20:31:04] (CR) Ejegg: "It depends on I1be0baf3cf37b2, which makes the queue consumer OK with removing the refund transaction id" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269569 (https://phabricator.wikimedia.org/T124842) (owner: Ejegg) [20:32:15] XenoRyet: got a minute to review something? [20:32:28] Sure. What do you need? [20:32:45] I made some pretty basic mistakes in this python job, and this ought to fix em: https://gerrit.wikimedia.org/r/269820 [20:32:56] Cool, I'll take a look. [20:33:46] (CR) Eileen: [C: 2] "I just cherry picked this across from the 4.6.9 branch to master - it went on find & still looks good to me" [wikimedia/fundraising/crm] (civi-4.6.9) - https://gerrit.wikimedia.org/r/243120 (owner: Awight) [20:36:41] (CR) Eileen: [C: 2] CRM-17177. die() instead of trigger_error() when accessed via web. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/268698 (owner: Ejegg) [20:39:09] (CR) XenoRyet: [C: 2] Fix query string key case change [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/269820 (https://phabricator.wikimedia.org/T114010) (owner: Ejegg) [20:45:57] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint William Shatner, and 5 others: Track email clickthroughs on donate wiki - https://phabricator.wikimedia.org/T114010#2016461 (Ejegg) Oops, this outage was all my fault.... [20:48:33] (CR) Ejegg: [V: 2] Fix query string key case change [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/269820 (https://phabricator.wikimedia.org/T114010) (owner: Ejegg) [20:53:58] (CR) Eileen: [C: 2] "This makes sense - I wrote a test just to check it worked - I don't know how work submitting it it is as it pretty much duplicates existin" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269567 (https://phabricator.wikimedia.org/T124842) (owner: Ejegg) [20:54:16] !log updated DjangoBannerStats from 71df14d4d8b11f3ca0ef1eeb6c6e2db9be79103a to c143b8dd41ae413dab494ae3e194f40b8cd04bb1 [20:54:22] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [20:54:28] (CR) Eileen: "ps - I love the branch name" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269567 (https://phabricator.wikimedia.org/T124842) (owner: Ejegg) [20:54:56] Thanks Eileen! [20:56:22] ejegg: thanks for writing them! Is that all instances now? [20:56:40] i think that does it for 'RFD' [20:56:58] phew [20:57:30] are there still some on parent_contribution_id ? [20:57:34] there's this one for the parent contribution ids: https://gerrit.wikimedia.org/r/269716 [20:57:47] which /might/ be all we need [20:57:54] Fundraising Sprint Cat Herding, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Fix WMF_donor rollup calculations to use financial transactions - https://phabricator.wikimedia.org/T124834#2016496 (Eileenmcnaughton) [20:59:09] ejegg: do you know if there are any tests that cover that audit module code? [20:59:49] definitely some for the base audit stuff, but I dunno about globalcollect [21:01:00] Ok - so it's just a case of me looking at that one, you looking at the post_hook fixes & then doing a last grep [21:01:45] whew! [21:01:55] :-) [21:02:19] and then schedule a deploy & get a csv off Michael to import missing ones [21:03:06] that'll be the fun part! [21:14:06] Fundraising-Backlog: Audit accounts in drupal to check none need to be disabled - https://phabricator.wikimedia.org/T126533#2016598 (Eileenmcnaughton) NEW [21:14:55] (Merged) jenkins-bot: Update archaic chargeback import logic [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269570 (https://phabricator.wikimedia.org/T124842) (owner: Ejegg) [21:33:53] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint William Shatner, and 5 others: Track email clickthroughs on donate wiki - https://phabricator.wikimedia.org/T114010#2016736 (CCogdill_WMF) @Ejegg I saw your ping on IR... [21:39:56] XenoRyet: did you get those messages? looked like otr may have puked [21:40:37] Yea, it puked, but got the message anyway. [21:41:13] So those three in SmashPig then? Cool, I'll pick up something else. [21:43:34] sounds good! [21:50:08] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint William Shatner, and 5 others: Track email clickthroughs on donate wiki - https://phabricator.wikimedia.org/T114010#2016819 (Ejegg) OK, the fix is up and email clicks... [22:00:30] (PS2) Ejegg: Fix financial trxn records for upgraded contributions missing to_financial_account_id. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269556 (https://phabricator.wikimedia.org/T122946) (owner: Eileen) [22:02:20] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint William Shatner, and 5 others: Track email clickthroughs on donate wiki - https://phabricator.wikimedia.org/T114010#2016856 (CCogdill_WMF) Awesome, that's good to know... [22:05:55] (CR) Ejegg: [C: 2] Fix financial trxn records for upgraded contributions missing to_financial_account_id. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269556 (https://phabricator.wikimedia.org/T122946) (owner: Eileen) [22:06:10] ejegg: dstrine so I need to send out a scheduling email - did we decide on your Monday in case I hit any problems & want some support? [22:06:29] That would be good for me! [22:07:09] OK - I'm guessing around 4pm your time - what time is it for you now? [22:07:28] it's 5pm here on the us east coast [22:07:41] OK - so you normally have standups at 4pm [22:07:46] yep! [22:07:54] & straight after that you catch Katie don't you? [22:08:03] on mondays, yeah [22:08:19] so probably should say 3pm your time which is 9am mine & I think 1pm SF [22:08:56] Sure, if you're up for it! [22:09:02] OK - I'll send that out [22:09:06] thanks [22:09:26] my other discovery yesterday is that the fields is_2016_donor doesn't mean what I thought [22:09:35] oh? [22:09:47] Oh right, the fiscal year thing [22:09:49] I wonder about renaming them to 'Is FY 2016-17 Donoar' [22:10:01] we could change those labels in the update script [22:10:17] possibly without the typo [22:10:36] Sure, sounds good [22:11:11] OK - I'll do that & re-review the lybunt to check I did it right [22:12:40] (PS2) Ejegg: Cleanup: Drupal 7 hook_update_N signature [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269821 (owner: Eileen) [22:13:44] Fundraising Sprint Cat Herding: Change labels on custom fields to denote Fiscal Year - https://phabricator.wikimedia.org/T126543#2016876 (Eileenmcnaughton) NEW a:Eileenmcnaughton [22:14:22] (CR) Ejegg: [C: 2] Cleanup: Drupal 7 hook_update_N signature [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269821 (owner: Eileen) [22:15:04] (CR) Cdentinger: [C: 2] Add message to antifraud queue in capture job [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/266643 (https://phabricator.wikimedia.org/T122244) (owner: Ejegg) [22:20:18] (CR) Cdentinger: [C: 2] Don't destroy message on capture error [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/268025 (https://phabricator.wikimedia.org/T117816) (owner: Ejegg) [22:33:29] eileen: so, I notice we're not deleting the old-style negative refund 'contributions' in update 7070 when we add the compensating financial trxns to the original refunded contribution [22:33:55] ejegg: no I didn't go there [22:34:07] the transactions are attached to the negative contributions [22:34:15] so, the right amount of transactions exist [22:34:27] oh, huh, lemme see [22:34:29] we could merge them - but I thought we might not need to [22:39:15] ejegg: strange, i can't get this to submit: https://gerrit.wikimedia.org/r/#/c/268025/ [22:39:31] i see "syntax error in json" on the network tab :\ [22:39:50] hmm, there's a crm patch taking a while too [22:39:57] let's check the ol zuul queue [22:40:41] nope, not much there [22:41:05] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269821 (owner: Eileen) [22:41:26] Is the group I email re scheduling fr-online or fr-all ? [22:41:49] i saw it acting sorta funny earlier, like 15 things sitting at 0 minutes to go [22:41:53] but it looks to have cleared out [22:44:24] so, that's confusing... [22:44:35] hitting submit doesn't work for me either [22:44:50] check the network panel? [22:46:09] posted to /submit with {"wait_for_merge":true} [22:46:33] response was {"status":"SUBMITTED"} [22:46:48] oh huh [22:46:56] well that sounds workingish [22:47:10] i was getting a json error but it must be my browser [22:47:16] but no merge - maybe the gerrit<->zuul communication is down? [22:48:17] hmm, seems like we'd see other stuff piling up doesn't it? [22:48:34] huh, guess that's not it - just let me submit the crm patch [22:49:14] (PS3) Ejegg: Update contribution_post hook to look at transaction totals [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269587 (https://phabricator.wikimedia.org/T124834) (owner: Eileen) [22:49:30] oh hmm https://gerrit.wikimedia.org/r/#/c/266930/3 [22:49:50] (CR) Eileen: "I made a couple of minor comments but nothing that I see as a blocker to merging - let me know if you want to make any changes in response" (5 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269716 (https://phabricator.wikimedia.org/T124842) (owner: Ejegg) [22:50:06] (CR) Ejegg: [C: 2] "Seems to work for both old and new refunds" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269587 (https://phabricator.wikimedia.org/T124834) (owner: Eileen) [22:50:18] looks like that's blocking? i did notice the smashpig patch i +2d this morning took 1.5hrs to merge for some strange reason [22:50:32] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269587 (https://phabricator.wikimedia.org/T124834) (owner: Eileen) [22:51:13] cwd oh right! [22:51:25] that one needs CR before it'll merge the next [22:51:42] though i thought you'd see a 'submitted, merge pending [22:51:48] status or some such [22:52:20] derp, totally thought i'd hit the button already [22:55:10] (CR) Cdentinger: [C: 2] Record Adyen payment on IPN capture notification [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/266930 (https://phabricator.wikimedia.org/T121158) (owner: Ejegg) [22:56:38] (PS2) Eileen: Update contribution_post hook to filter contributions for Completed status [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269599 (https://phabricator.wikimedia.org/T124834) [22:58:41] (PS2) Ejegg: Update audit refund matching logic [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269716 (https://phabricator.wikimedia.org/T124842) [22:59:05] (CR) Ejegg: "Thanks for the suggestions!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269716 (https://phabricator.wikimedia.org/T124842) (owner: Ejegg) [23:01:55] (CR) Eileen: [C: 1] "This seems fine to me - I have a slight reservation about merging now as opposed to after we deploy all the updates - the update script as" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/267707 (owner: Ejegg) [23:05:57] (CR) Ejegg: [C: -1] "Looking good! We need to also filter out completed contributions with a negative total_amount, to skip old-style refunds. Also, sorry I wr" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269599 (https://phabricator.wikimedia.org/T124834) (owner: Eileen) [23:13:05] (CR) Eileen: Don't error on bad contribution source (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269307 (owner: Ejegg) [23:15:17] atgomez: which email should I send to regarding letting people know about the deploy / outage? [23:16:27] fr-all@ [23:16:30] eileen: ^ [23:17:04] atgomez: thanks [23:33:02] (PS2) Ejegg: Don't error on bad contribution source [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269307 [23:36:55] (CR) Eileen: "Definitely an improvement - one line comment though" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269307 (owner: Ejegg) [23:39:43] (CR) Ejegg: [C: 1] "Looks good! One line got duplicated in DonationInterface.php, but I'm ready to merge this" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266456 (https://phabricator.wikimedia.org/T120255) (owner: XenoRyet) [23:40:04] Fundraising Sprint Cat Herding, Fundraising-Backlog, Unplanned-Sprint-Work: Change labels on custom fields to denote Fiscal Year - https://phabricator.wikimedia.org/T126543#2017248 (DStrine) [23:40:48] (CR) Ejegg: "oof, that's the second time this patch you've caught me not testing locally!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269307 (owner: Ejegg) [23:41:03] (CR) jenkins-bot: [V: -1] Don't error on bad contribution source [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269307 (owner: Ejegg) [23:41:53] (PS9) XenoRyet: Nonsense Name Fraud Filter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266456 (https://phabricator.wikimedia.org/T120255) [23:42:07] (CR) Eileen: "Looks like Jenkins spotted it too :-)" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269307 (owner: Ejegg) [23:42:17] Ejegg: Thanks, just submitted with that line unduplicated. [23:43:06] (PS3) Ejegg: Don't error on bad contribution source [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269307 [23:43:23] XenoRyet: getting that merged is going to warrant a beer isn't it? [23:43:39] Yea. I spent quite a bit of time in the weeds on that one. [23:43:50] Learned some stuff though, so that's good. [23:43:52] (PS10) Ejegg: Nonsense Name Fraud Filter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266456 (https://phabricator.wikimedia.org/T120255) (owner: XenoRyet) [23:44:08] learning's always good [23:44:23] Indeed [23:44:36] (CR) Ejegg: [C: 2] Nonsense Name Fraud Filter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266456 (https://phabricator.wikimedia.org/T120255) (owner: XenoRyet) [23:44:56] eileen: ok, actually tested it locally this time! [23:45:05] :-) [23:45:34] ejegg: just getting my head back into this, there's no adyen audit parser, it's all the listener right? and the listener will get notified for refunds through the "Standard Notification" subscription i see on the console? [23:45:54] yep [23:46:07] (CR) Eileen: [C: 2] Don't error on bad contribution source [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269307 (owner: Ejegg) [23:46:19] I figure there should be an actual audit thing for adyen at some point [23:46:44] 'cause right now we're screwed if the listener communication fails [23:46:52] yeah i was gonna ask, the listener seems ephemeral enough that something that actually downloads a file might be preferable [23:46:59] in addition [23:47:14] yeah, and gets corroborating details from the logs in case of queue snafu [23:47:23] yeah [23:47:40] i see a bunch of downloaded files on the listener so i guess there's a job for that already [23:47:55] basically something just like the worldpay and astropay audit parsers built off the BaseAuditParser [23:48:35] yeah, it's downloading them and till now has just been capturing all the danglings auths [23:48:48] sorry, gotta relocate... [23:48:57] cool [23:56:51] (PS3) Eileen: Update contribution_post hook to filter contributions for Completed status [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269599 (https://phabricator.wikimedia.org/T124834) [23:58:12] (CR) Eileen: "Good point!!!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269599 (https://phabricator.wikimedia.org/T124834) (owner: Eileen)