[00:03:16] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Zapp, and 3 others: Financial Transactions not visible for some transactions & possibly fee transactions are missing - https://phabricator.wikimedia.org/T122946#2017322 (... [00:25:17] i gotta go pick up the dog, later [00:32:02] (Merged) jenkins-bot: Nonsense Name Fraud Filter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/266456 (https://phabricator.wikimedia.org/T120255) (owner: XenoRyet) [00:42:08] Fundraising Sprint Cat Herding, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Fix WMF_donor rollup calculations to use financial transactions - https://phabricator.wikimedia.org/T124834#2017437 (Eileenmcnaughton) a:Eileenmcnaughton [00:48:15] ejegg: are you still there? [00:48:58] yep, for a bit [00:49:18] bout to merge that last wmf_donor patch [00:50:01] ejegg: cool was just looking at atgomez's email & I'm under the belief we just let the queue pile up - is that what you expect? [00:50:41] yep, we'd let the queue fill up! [00:50:50] OK - I'll reply - thanks! [00:51:28] ty [00:51:55] ejegg: I also stuck it in your calendar [00:52:18] thanks eileen ! [00:54:18] (PS4) Ejegg: Update contribution_post hook to filter contributions for Completed status [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269599 (https://phabricator.wikimedia.org/T124834) (owner: Eileen) [00:54:40] (CR) Eileen: "I feel like this is superceded & can be abandonned?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/243088 (https://phabricator.wikimedia.org/T99838) (owner: Awight) [00:56:45] (CR) Ejegg: [C: 2] Update contribution_post hook to filter contributions for Completed status [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269599 (https://phabricator.wikimedia.org/T124834) (owner: Eileen) [00:57:17] later all [01:17:23] (PS1) Eileen: Adjust donor field labels to indicate they are fiscal year. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269885 (https://phabricator.wikimedia.org/T126543) [01:21:35] (CR) Eileen: [C: 2] "I honestly think that is the last one!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269716 (https://phabricator.wikimedia.org/T124842) (owner: Ejegg) [01:24:36] Fundraising Sprint Asbestos Removal 2016, Fundraising-Backlog: Update error message to ask donors for more specific information/include transaction ID - https://phabricator.wikimedia.org/T121530#2017553 (atgo) [01:25:15] Fundraising Sprint Asbestos Removal 2016, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Investigate possible brief drop in banner history log rate on 2015-12-01 at 20:21 UTC - https://phabricator.wikimedia.org/T120058#2017556 (atgo) [01:25:49] Fundraising-Backlog: Recent up tick in fail mail - https://phabricator.wikimedia.org/T126482#2017558 (Eileenmcnaughton) I noticed we got one just now with a deadlock on adding emails - the issue there is that another query is causing a Deadlock - probably a poorly written update or insert query. To get infor... [01:27:03] Fundraising Sprint Cat Herding, Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review: Change labels on custom fields to denote Fiscal Year - https://phabricator.wikimedia.org/T126543#2017561 (atgo) @eileenmcnaughton - should this be in "review"? [01:27:23] Fundraising Sprint Cat Herding, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Advise on reports - https://phabricator.wikimedia.org/T126297#2017562 (atgo) p:Triage>Normal [01:27:48] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Yo La Tengo, Fundraising Sprint Zapp, Fundraising-Backlog, and 2 others: Globalcollect Status 25/404 errors - https://phabricator.wikimedia.org/T120030#2017565 (atgo) [01:28:34] Fundraising Sprint Cat Herding, Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review: Change labels on custom fields to denote Fiscal Year - https://phabricator.wikimedia.org/T126543#2017567 (Eileenmcnaughton) Yep - will move it - do you think I need to make sure I get the blessing of Caitl... [01:28:59] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Zapp, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Donors still don't know payments succeeded when breakage, e.g. queue is dead. - https://phabricator.wikimedia.org/T122627#2017569 (atgo) [01:40:54] Fundraising Sprint Cat Herding, Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review: Change labels on custom fields to denote Fiscal Year - https://phabricator.wikimedia.org/T126543#2017591 (CaitVirtue) Finance actually defines it the other way, with something happening in FY16-17 as FY17... [01:47:30] Fundraising Sprint Cat Herding, Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review: Change labels on custom fields to denote Fiscal Year - https://phabricator.wikimedia.org/T126543#2017595 (Eileenmcnaughton) I searched the DB and there are currently no 'Is 2016 Donor' entries (well 4 but... [02:30:14] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising-Backlog, FR-Ingenico: Refund not matching original amount--GC original may have been imported incorrectly - https://phabricator.wikimedia.org/T123404#2017672 (Eileenmcnaughton) I just looked at the one that... [06:14:37] (PS17) Eileen: CRM-17837 Improve Lybunt report. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/265143 (https://phabricator.wikimedia.org/T123671) [06:16:04] (CR) Eileen: "I've reviewed the commit to address the first couple of comments - I haven't gotten to the others yet - I've put the fixes for the 2 I hav" (2 comments) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/265143 (https://phabricator.wikimedia.org/T123671) (owner: Eileen) [10:55:38] fundraising-tech-ops: db1008 (and fdb2001) periodically lags every day at the same time ~10:30UTC - https://phabricator.wikimedia.org/T126314#2018183 (jcrespo) There are several things wrong here: ``` SELECT ct.utm_medium, ct.utm_campaign, min(c.receive_date), max(c.... [11:03:55] fundraising-tech-ops: db1008 (and fdb2001) periodically lags every day at the same time ~10:30UTC - https://phabricator.wikimedia.org/T126314#2018193 (jcrespo) The lag stays high from 08:20 to 10:40 https://icinga.wikimedia.org/cgi-bin/icinga/history.cgi?host=db1008&service=check_mysql [17:02:27] (PS2) Ejegg: Adjust donor field labels to indicate they are fiscal year. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269885 (https://phabricator.wikimedia.org/T126543) (owner: Eileen) [17:05:14] (CR) Ejegg: [C: 2] Adjust donor field labels to indicate they are fiscal year. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/269885 (https://phabricator.wikimedia.org/T126543) (owner: Eileen) [17:52:06] thanks ejegg for helping eileen with clarifying that queue thing. i was mostly asking so that we coudl have that answer for the fundraisers ;) [17:52:18] sure thing [17:52:28] how's trip prep going? [18:00:30] (Abandoned) Ejegg: Add defaultremote to .gitreview [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/224872 (owner: Ejegg) [18:04:51] say ejegg, do you have any special sauce for faking requests to the listener? [18:05:15] cwd there's a script in Tests [18:05:31] one sec, lemme find the magic words [18:05:35] soap injecter? [18:05:50] yep! [18:06:02] ./soapinject.py localhost '/ipn/smashpig_http_handler.php?p=adyen/listener&XDEBUG_SESSION_START=netbeans-xdebug' authorization.xml [18:06:08] ah cool, this looks reasonable [18:06:11] nice, thanks! [18:06:13] well, you can omit the xdebug bit [18:06:27] heh, or maybe i should set xdebug up [18:06:37] i know i lean on it heavily! [18:07:09] there are certain things it's a game changer for [18:07:26] but i've always been a die('here') luddite [18:08:15] but... call stack navigation and custom watch expressions! [18:08:34] it's nothing to sneeze at [18:08:43] hey, if you can live without it, more power to you! [18:09:21] i was starting to get decent at it on my last setup [18:09:47] decent vim plugin? [18:09:48] it's easy to get lost in the like 9000 calls in your average web application [18:09:58] erk, yeah [18:10:06] i bet the vim plugin makes it harder than a nice gui [18:10:28] it's a whole lot of magick [18:10:33] that is hard to remember [18:11:00] netbeans gui is fair enough, but word is phpstorm beats em all [18:11:15] does it cost money? [18:11:28] they gave the foundation a bunch of licenses [18:11:39] they're on officewiki someplace [18:12:23] err, i might be hoarding one... I should use it or release my claim [18:13:17] yeah i bet it's slick, you should fire it up [18:13:44] I switched to it a couple of weeks ago, it is pretty nice. [18:15:17] ejegg: so is /ipn pointed at...smashpig_http_handler.php ? [18:15:44] word. looks like my old license expired, but there are a bunch of unclaimed ones [18:16:38] uh, I think at the PublicHtml directory - i specify the whole filename in the command [18:17:11] ah indeed, so you have a vhost for that or something? [18:17:27] /ipn => /smash-pig/PublicHtml [18:17:46] nah, just a directory alias [18:17:54] i hit that one via localhost [18:17:59] goootcha [18:18:01] thanks [18:31:11] Fundraising-Backlog, Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, I18n: Allow better searching on Special:MessageGroupStats - https://phabricator.wikimedia.org/T125336#2019572 (atgo) [18:42:13] hey ejegg I hadn't taken in that Monday is a holiday for you [18:42:33] eileen: ehh, no problem [18:42:53] good time for a maintenance outage then [18:43:26] maybe I'll take off an hr early tuesday [18:44:21] ejegg: OK cool - the thing I'm most worried about is taking the queues down 'cos I haven't actually done that before and I've found logging into jenkins a bit intermittant [18:44:35] oof, what a pain [18:44:49] once you get in there it's pretty straightforward [18:45:04] I often just hit the 'prepare for shutdown' button [18:45:29] lets the current tasks finish but doesn't start anything new till you cancel the shutdown [18:50:03] ejegg: ok - well I'll try it on (your) Monday and scream help if I need it. I'm about to reply to the emails - I believe the emails going out are still fine - per Jessica's email? [18:50:33] err, lemme look [18:51:13] oh yeah, emails are fine [18:51:37] (PS6) Ejegg: Use composer-managed Minfraud classes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180894 [18:56:35] (CR) jenkins-bot: [V: -1] Use composer-managed Minfraud classes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180894 (owner: Ejegg) [19:05:59] Fundraising-Backlog: Use TLS encryption on Civi TY emails - https://phabricator.wikimedia.org/T126643#2019750 (CCogdill_WMF) NEW [19:06:33] Fundraising-Backlog: Use TLS encryption on Civi TY emails - https://phabricator.wikimedia.org/T126643#2019759 (CCogdill_WMF) [19:07:09] hey Jeff_Green [19:07:15] hey ccogdill [19:07:19] want to give you a heads up about the task above [19:07:32] I’m really not sure of the priority, so I figured I’d just make sure you knew it was there [19:07:35] the TLS one? [19:07:37] yeah [19:07:48] we should already do that when it's available at the receiving end [19:07:51] hmm [19:07:52] okay [19:07:52] i can double check [19:08:18] thanks! [19:11:50] (PS7) Ejegg: Use composer-managed Minfraud classes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180894 [19:12:28] hey ccogdill did you see my email about link shortening yesterday? [19:14:30] yes, sorry about that atgomez [19:14:42] I haven’t put any thought into this question before so I didn’t have a quick answer [19:14:54] let me take a minute and I’ll reply [19:17:56] no worries [19:19:30] thanks for the response, ccogdill [19:19:39] yep! [19:19:44] lmk if I’m missing the big picture here [19:21:04] Fundraising-Backlog: Use TLS encryption on Civi TY emails - https://phabricator.wikimedia.org/T126643#2019805 (atgo) Interesting. @eileenmcnaughton have you heard anything from Civi core about this? Seems like something we'd want to deal with upstream. [19:22:02] (Abandoned) Ejegg: Get rid of some warnings [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/217760 (owner: Ejegg) [19:22:22] ccogdill: I'll have to research that further, there's no obvious indication in the logs whether or not TLS is being used on a connection the way we're configured, so it's hard to tell what's going on [19:22:48] cool, thank you [19:23:10] I figured because I saw it my own inbox, it would be widespread, but I don’t think we’ve seen any actual complaints yet [19:23:22] but if any donor base will care about this, it’s ours :D [19:23:34] most people don't really have an easy way to tell whether TLS was used [19:24:00] right, my understanding was gmail was pulling back that veil [19:24:11] but doing it without actually explaining to users what it meant [19:24:35] yep [19:24:59] I wonder if they'll start adding all the other fun stuff that could be determined from message headers :-) [19:25:12] XenoRyet: just updated a patch that had been languishing for a year, to use Minfraud's stuff from the composer lib [19:25:23] if you want to review, it's here: https://gerrit.wikimedia.org/r/180894 [19:25:32] Yea, sure. I'll take a look. [19:25:39] Thanks! [19:26:14] yeah I’ve heard they’re throwing even crazier messages for unsigned emails [19:26:17] at least we’re good there [19:26:49] so far the only complaints I've ever seen have been about the mkt47whatever URLs in silverpop messages :-) [19:27:15] yep. we’re almost away from that!! [19:27:18] almost [19:27:19] hopefully going away soon, if the email link tracking via kafkatee holds up! [19:27:20] yay [19:27:31] heh, exactly [19:27:33] data coming for you in t-3 hours ejegg :p [19:27:38] cool [19:27:58] if we're going to do this properly we should really buy a couple more SSL certs... sigh [19:28:20] thanks gmail [19:37:30] hey ejegg|afk XenoRyet cwd|afk can we push the fraud patch today? [21:20:26] Fundraising Sprint Cat Herding, Fundraising-Backlog: Sprint Goal C (2/3 to 2/17): run Adyen test, start Astropay, tie up loose civi ends - https://phabricator.wikimedia.org/T122372#2020307 (DStrine) [21:36:20] Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising-Backlog, FR-Adyen, FR-Smashpig: Process refunds in Adyen audit file - https://phabricator.wikimedia.org/T121129#2020355 (Ejegg) The current audit parser built in to SmashPig does just about nothing. It was capturi... [21:45:16] (PS1) XenoRyet: Remove France from GlobalCollect forms. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/270113 [21:51:56] (CR) Ejegg: [C: 2] Remove France from GlobalCollect forms. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/270113 (owner: XenoRyet) [21:54:44] (Merged) jenkins-bot: Remove France from GlobalCollect forms. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/270113 (owner: XenoRyet) [21:55:13] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint William Shatner, and 5 others: Track email clickthroughs on donate wiki - https://phabricator.wikimedia.org/T114010#2020437 (CCogdill_WMF) @Ejegg success! Results from... [22:09:47] Fundraising-Backlog: Recent up tick in fail mail - https://phabricator.wikimedia.org/T126482#2020584 (Jgreen) If we can narrow it down to a time of day and which database is being queried I can dig into the mysql slow query log. We know for example that we have severe replication lag between about 08:20 an... [22:10:37] Fundraising-Backlog: Use TLS encryption on Civi TY emails - https://phabricator.wikimedia.org/T126643#2020588 (Jgreen) a:Jgreen [22:22:07] Fundraising-Backlog: Use TLS encryption on Civi TY emails - https://phabricator.wikimedia.org/T126643#2020698 (Jgreen) We have TLS partly enabled but the MTA configuration is ancient and fairly broken, and I think it's not actually being used in transactions. To properly fix it, I think we should adjust the... [22:23:05] Fundraising-Backlog: Use TLS encryption on Civi TY emails - https://phabricator.wikimedia.org/T126643#2020704 (Jgreen) >>! In T126643#2020698, @Jgreen wrote: > We have TLS partly enabled but the MTA configuration is ancient and fairly broken, and I think it's not actually being used in transactions. > > To... [23:11:05] (PS1) Ejegg: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/270131 [23:12:37] (CR) Ejegg: [C: 2 V: 2] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/270131 (owner: Ejegg) [23:14:29] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/270132 [23:14:56] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/270132 (owner: Ejegg) [23:15:07] (CR) Ejegg: [V: 2] Update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/270132 (owner: Ejegg) [23:27:16] !log updated payments-wiki from fad669c99db8240b26a524aa70c85cfebd13a18c to 5b909f06acce6444186ac02a494439c2ddd624aa [23:27:19] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master