[00:46:27] gotta head out, g'night! [00:53:46] Fundraising-Backlog: Recent up tick in fail mail - https://phabricator.wikimedia.org/T126482#2021266 (Eileenmcnaughton) I would have said "We are looking for an INSERT OR UPDATE query that joins onto the civicrm_email table and includes an indexed field somewhere in the WHERE clause or join" - which makes th... [12:29:11] (CR) Aklapper: "@Ssmith: Is this still wanted? If so, could you add some reviewers? This patch has been rotting here for more than a year so some progress" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/164087 (owner: Ssmith) [13:40:34] Fundraising-Backlog: Recent up tick in fail mail - https://phabricator.wikimedia.org/T126482#2022289 (Jgreen) Yeah, I think we're going to have to redesign the silverpop processor to be less abusive on the database, or maybe move it back to lutetium . . . [15:27:16] Fundraising-Backlog: Use TLS encryption on Civi TY emails - https://phabricator.wikimedia.org/T126643#2022475 (Jgreen) Open>Resolved Fixed! Hopefully! Please keep an eye on email feedback loops and let me know if there were any unanticipated consequences. [15:32:11] Fundraising-Backlog, Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Documentation: Banner and donatewiki style guide documentation needs updating - https://phabricator.wikimedia.org/T119821#2022495 (Pcoombe) p:Triage>Low The donate wiki styleguide is pretty much up to date, that... [15:33:53] Fundraising-Backlog, Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, I18n: Allow better searching on Special:MessageGroupStats - https://phabricator.wikimedia.org/T125336#2022497 (Pcoombe) Perhaps a simple checkbox to "archive" the banner or mark it as no longer needing translations is... [15:46:59] Fundraising-Backlog, Wikimedia-Site-Requests, Easy: Geolocation not available on wikimediafoundation.org - https://phabricator.wikimedia.org/T73747#2022521 (Pcoombe) @awight Any idea what's the best way to make this happen? It would be really helpful for the Store if we could add location dependent st... [17:29:57] Fundraising-Backlog: Use TLS encryption on Civi TY emails - https://phabricator.wikimedia.org/T126643#2023002 (CCogdill_WMF) Awesome @Jgreen, that was fast! I just made a test donation and there was no red lock in my TY email. [19:50:40] cwd do you want to split up work on the adyen audit parser? [19:57:15] ejegg: i was thinking about that [19:58:07] you were saying having SP do the download but the job run in jenkins would require some sort of coordination? [19:59:27] i figure we'd just see when they usually send us audit files [19:59:38] and schedule the parsing for an hour or so after that [19:59:45] (if it's regular) [19:59:51] i've just been digging around in smashpig [20:00:17] i wonder if it'd be worth just doing the download in crm tgoo [20:00:19] -g [20:00:45] ehh, maybe [20:01:01] so we'd send the 'report ready' job to a different queue [20:01:15] and the crm would check that every so often [20:02:01] or... the adyen audit parsing job could run every hour or so, picking up any new file that's been downloaded [20:02:46] yeah i guess it's the same either way [20:03:05] the division of labor is confusing [20:03:37] so, one of us could write a library class in SmashPig like the WorldpayAudit parser [20:03:46] and the other could write the code that uses it in crm [20:04:05] another subclass of BaseAuditProcessor [20:04:27] any reason to have smashpig involved in that part? [20:04:35] couldn't we just copy worldpay or whoever? [20:05:25] yeah, worldpay's audit file parser is in PaymentProviders/Worldpay/Audit [20:05:47] Amazon and Astropay have audit parsers in Smashpig too [20:06:54] oh, heh, i thought all that was happening in wmf_audit [20:08:02] so, that part holds the logic that instantiates the class from smashpig, calls it to parse the file, looks for corroborating details in logs, and dumps txns on the queue [20:08:23] err, might even check to see which are missing before queueing them [20:10:12] ok yeah i am remembering this now [20:12:26] anyway sure if you want to split this up that'd be cool [20:12:50] rockin. You have a preference on which part? [20:12:51] i just need to get traction on it [20:13:08] i have a hard time avoiding the urge to refactor [20:13:13] hehe [20:13:42] these bits just had a round of that from awight last fall [20:13:42] so both pieces are essentially going to be copying code that's already there right? [20:13:49] cwd pretty much [20:14:44] AstroPay has a pretty simple one if we only need the one file type [20:15:17] that's an open question right? we don't necessarily know which report has all the data? [20:15:37] I think I posted a good candidate in the ticket [20:16:20] yeah, Settlement Detail Report [20:16:25] https://docs.adyen.com/manuals/reporting-manual/settlement-detail-report-structure/settlement-detail-report-journal-types [20:17:47] (CR) XenoRyet: [C: 2] "Looks good, worked for me." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180894 (owner: Ejegg) [20:18:18] ejegg: ^ [20:18:22] Thanks! [20:18:27] No worries [20:19:09] ejegg: cool, i really have no preference which part, do you? [20:19:27] nah, either's good [20:19:34] well, how 'bout I do the CRM bit [20:20:02] sounds good! i'll look at the WP stuff in SP [20:20:24] word [20:20:26] i have sort of a busy afternoon but will put in some time in the evening [20:20:44] (Merged) jenkins-bot: Use composer-managed Minfraud classes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/180894 (owner: Ejegg) [20:23:53] cool [20:24:39] just getting some food, then standup, then my realtor is coming over to appraise my house [20:24:52] should be interesting [20:24:56] oh wow [20:34:51] (PS1) Ejegg: Log Adyen donation details before redirect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/270353 (https://phabricator.wikimedia.org/T121129) [21:31:43] back in awhile! [21:42:32] Fundraising-Backlog, fundraising-tech-ops, Security, operations, audits-data-retention: Delete gadolinium:/a/log/fundraising/ - https://phabricator.wikimedia.org/T92336#2024159 (Dzahn) [22:07:13] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Add country to thank you page URL - https://phabricator.wikimedia.org/T126814#2024228 (Ejegg) NEW [22:08:34] (PS1) Ejegg: WIP add country to thank you URL [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/270415 (https://phabricator.wikimedia.org/T126814) [22:11:32] (CR) jenkins-bot: [V: -1] WIP add country to thank you URL [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/270415 (https://phabricator.wikimedia.org/T126814) (owner: Ejegg) [22:12:05] (PS1) Ejegg: WIP Adyen audit processor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/270416 (https://phabricator.wikimedia.org/T121129) [23:28:38] heading out, folks. Have a great weekend!