[00:25:16] Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: certain Civi searches take a long time - https://phabricator.wikimedia.org/T123418#2030036 (Eileenmcnaughton) @mbeat33 How is this now? Note that the spec... [00:26:22] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising-Backlog, and 2 others: Fix speed issue when doing a refund in the UI - https://phabricator.wikimedia.org/T123305#2030042 (Eileenmcnaughton) [00:26:24] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Zapp, and 3 others: Add indexes to CiviCRM entity financial transaction table - https://phabricator.wikimedia.org/T122947#2030040 (Eileenmcnaughton) Open>Resolved... [00:27:00] Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: [Epic] Restore Civi manual refund functionality - https://phabricator.wikimedia.org/T124979#2030046 (Eileenmcnaughton) [00:27:03] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising Sprint Zapp, and 3 others: [Epic] CiviCRM upgrade: Adapt refund processing & reporting to reflect changes since the upgrade. - https://phabricator.wikimedia.org/T116317#2030047 (Eil... [00:27:05] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add ability to enter a trxn_id for the refund transaction when editing a contribut... - https://phabricator.wikimedia.org/T123319#2030044 [00:27:59] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising-Backlog, and 2 others: Fix speed issue when doing a refund in the UI - https://phabricator.wikimedia.org/T123305#1925829 (Eileenmcnaughton) @mbeat33 Can you confirm that you... [00:31:20] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: [Epic] Repair historical refunds to be consistent with new style - https://phabricator.wikimedia.org/T124983#2030056 (Eileenmcnaughton) [00:31:23] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Remove duplicate refunded status & transfer contributions with this status to the ... - https://phabricator.wikimedia.org/T123329#2030054 [00:31:24] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising Sprint Zapp, and 3 others: [Epic] CiviCRM upgrade: Adapt refund processing & reporting to reflect changes since the upgrade. - https://phabricator.wikimedia.org/T116317#2030057 (Eil... [02:01:06] Fundraising Sprint Cat Herding, Fundraising Tech Backlog: Improve information available for this message Undefined property: stdClass::$name wmf_civicrm.module:24 [notice] - https://phabricator.wikimedia.org/T127028#2030141 (Eileenmcnaughton) NEW a:Eileenmcnaughton [02:01:22] (PS1) Eileen: Add debug info for when option value is not found. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/270889 (https://phabricator.wikimedia.org/T127028) [02:03:17] (PS2) Eileen: Add debug info for when option value is not found. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/270889 (https://phabricator.wikimedia.org/T127028) [02:13:50] Fundraising Sprint Cat Herding: E-notice in log indicates minor error: 02:06:16 Undefined index: contribution_type_id [notice] 02:06:16 recurring_globalcollect.module:363 - https://phabricator.wikimedia.org/T127029#2030160 (Eileenmcnaughton) NEW a:Eileenmcnaughton [02:16:24] (PS1) Eileen: Enotice fix (indicating unset parameter) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/270890 (https://phabricator.wikimedia.org/T127029) [02:16:48] Fundraising Sprint Cat Herding, Fundraising Tech Backlog, Patch-For-Review: Improve information available for this message Undefined property: stdClass::$name wmf_civicrm.module:24 [notice] - https://phabricator.wikimedia.org/T127028#2030141 (Eileenmcnaughton) [02:24:08] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/265216 (https://phabricator.wikimedia.org/T123671) (owner: Eileen) [03:36:03] (PS18) Eileen: CRM-17837 Improve Lybunt report. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/265143 (https://phabricator.wikimedia.org/T123671) [03:37:55] (CR) Eileen: "I just synced up with the 4.7 version - made our code closer to the upstream & added the on_hold field upstream which I had previously mis" (3 comments) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/265143 (https://phabricator.wikimedia.org/T123671) (owner: Eileen) [08:19:26] (PS1) Eileen: Fix error when updating completed transaction. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/270896 (https://phabricator.wikimedia.org/T124979) [08:58:19] Wikimedia-Fundraising, Wikimedia-Fundraising-CiviCRM, Labs, Tracking: Create new labs project: fundraising-integration - https://phabricator.wikimedia.org/T88599#2030479 (hashar) @danny_b Please stop spamming old bugs. Thank you. [11:56:45] Wikimedia-Fundraising, Wikimedia-Fundraising-CiviCRM, Labs: Create new labs project: fundraising-integration - https://phabricator.wikimedia.org/T88599#2030814 (Danny_B) [11:57:31] Wikimedia-Fundraising, Wikimedia-Fundraising-CiviCRM, Labs: Create new labs project: fundraising-integration - https://phabricator.wikimedia.org/T88599#1015947 (Danny_B) @hashar: Please stop re-adding incorrect tags. This is //not// a #tracking task. Thank you. [13:11:38] Fundraising-Backlog, Wikimedia-Fundraising: "Renew your donation: 0 kr" - https://phabricator.wikimedia.org/T127059#2030968 (Josve05a) NEW [13:13:47] Fundraising-Backlog, Wikimedia-Fundraising: Email thanks me for a $0 donation - https://phabricator.wikimedia.org/T125778#2030986 (Josve05a) Resolved>Open {F3363842} Note that it has a double space. where the old "$0" was. makes it look like a scam/bad grammar. ---- See also {T127059} [14:06:49] (CR) Aklapper: "This patch has been sitting here for five months without a review. @Awight: Any idea who should/could review this and give a +1 or -1 at l" [wikimedia/fundraising/civicrm-buildkit] - https://gerrit.wikimedia.org/r/240624 (https://phabricator.wikimedia.org/T113559) (owner: Awight) [15:47:22] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising-Backlog, and 2 others: Fix speed issue when doing a refund in the UI - https://phabricator.wikimedia.org/T123305#2031566 (MBeat33) @Eileenmcnaughton, I just refunded Ingenico... [15:55:56] Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: certain Civi searches take a long time - https://phabricator.wikimedia.org/T123418#2031592 (MBeat33) @Eileenmcnaughton this works like a charm now - many t... [17:27:20] cwd: can you download any reports from the adyen customer area? [17:29:05] hmm, lemme try [17:29:56] well, the only option is "queue" [17:30:17] (CR) Ejegg: [C: 2] "Safer!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/270896 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [17:30:32] cwd yeah, I get the same [17:30:32] maybe it will get downloaded? [17:30:35] i'm not sure [17:30:48] right, I expected it to appear someplace on that page once it was generated [17:31:07] there's a link to the top right of the 'subscriptions' section that says 'show all downloads' [17:31:18] but whenever I click that I get a modal with an error message [17:33:22] X| [17:35:06] if you get the same, I'll call their customer support like our contacts there suggested [17:35:12] ejegg: do you know for sure that the report we're subscribed to (payment accounting report) is missing data? or could it be that we just haven't seen all the types of transactions yet? [17:35:24] Right, that's what I'm trying to find out [17:35:50] yep i get the same error [17:35:53] PPena refunded a couple of txns in December ( i think 12/8 ) and I was trying to generate that report [17:39:03] ah dang yeah doesn't look like the download job was running that far back [17:39:42] I think it was running but it was deleting downloads after clearing auths [17:39:51] aah [17:40:02] so the download doesn't run unless the listener gets pinged? [17:40:11] right [17:40:19] we don't have a manual way to kick it like the jenkins jobs? [17:40:45] nope - the listener notification comes with an https url [17:41:02] ah sure [17:41:15] wondering if maybe those generated files are queued up for download [17:41:18] so we can't just trawl an sftp dir [17:41:54] I thought maybe, but I queued up a bunch last week and haven't seen 'em hit the listener [17:42:43] can we have someone put through some charges and refunds? [17:43:03] yeah, that would work too [17:43:12] not super helpful until the files land [17:43:14] but it's something [17:43:49] i was just gonna mock up some data in the mean time [17:43:50] I just got settled in the quiet room at the library, but when I move for foods I'll call their customer support [17:43:59] groovy [17:54:25] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: [epic] Dedupe exact matches - https://phabricator.wikimedia.org/T111702#2032215 (DStrine) [17:55:06] Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: certain Civi searches take a long time - https://phabricator.wikimedia.org/T123418#2032218 (Eileenmcnaughton) Open>Resolved Great! [17:55:37] Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: [Epic] Restore Civi manual refund functionality - https://phabricator.wikimedia.org/T124979#2032224 (Eileenmcnaughton) [17:55:39] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising-Backlog, and 2 others: Fix speed issue when doing a refund in the UI - https://phabricator.wikimedia.org/T123305#2032222 (Eileenmcnaughton) Open>Resolved Good to hear [17:55:41] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising Sprint Zapp, and 3 others: [Epic] CiviCRM upgrade: Adapt refund processing & reporting to reflect changes since the upgrade. - https://phabricator.wikimedia.org/T116317#2032225 (Eil... [17:55:49] Fundraising-Backlog, FR-Worldpay: [epic] Make sure worldpay works in english for all 5 countries - https://phabricator.wikimedia.org/T114780#2032227 (DStrine) [17:56:53] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: [epic] Dedupe CiviCRM - https://phabricator.wikimedia.org/T77938#2032232 (DStrine) [17:57:38] Fundraising-Backlog, FR-Ingenico: Add Discover card type to Canada iframe options - https://phabricator.wikimedia.org/T122218#2032241 (DStrine) [17:58:25] Fundraising-Backlog, FR-Astropay: [epic] Processing via Astropay for Spanish-speaking LATAM countries - https://phabricator.wikimedia.org/T102143#2032247 (DStrine) [18:00:24] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Epic, I18n: [Epic] Use translatable pages for banner content - https://phabricator.wikimedia.org/T116235#2032259 (DStrine) [18:01:01] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, MediaWiki-extensions-DonationInterface: [Epic] SPOF: Replace ActiveMQ donation queues with Redis - https://phabricator.wikimedia.org/T108229#2032265 (DStrine) [18:01:07] Fundraising-Backlog, FR-Ingenico: Add Discover card type to Canada iframe options - https://phabricator.wikimedia.org/T122218#2032267 (Ppena) FYI this is broken within GC and we should not add until they confirm its fixed :) [18:01:29] (PS1) Eileen: CiviCRM submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/271006 [18:01:40] Fundraising-Backlog: CiviCRM contact dedupe--get to a point where we can let people key in merge resolutions - https://phabricator.wikimedia.org/T117462#2032269 (DStrine) [18:04:28] Fundraising-Backlog, Epic: [epic] Support language variants throughout donation pipeline - https://phabricator.wikimedia.org/T96594#2032289 (DStrine) [18:04:58] (CR) Eileen: [C: 2] "Merge fix - self-reviewing" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/271006 (owner: Eileen) [18:12:18] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/271011 [18:12:38] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Adyen, FR-Smashpig: Generate unique merchant reference for each Adyen redirect - https://phabricator.wikimedia.org/T127096#2032321 (Ejegg) NEW [18:13:06] Fundraising Sprint Cat Herding, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, and 2 others: Generate unique merchant reference for each Adyen redirect - https://phabricator.wikimedia.org/T127096#2032328 (Ejegg) a:Ejegg [18:15:57] (CR) Eileen: [C: 2] "merge commit" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/271011 (owner: Eileen) [18:16:54] !log Updating CiviCRM from b499564de8a2239b1c20acba0f8d52493c9a9c22 to b2566a9849c2b3a2a0c8f0b524c69bbc2dca5f8f [18:16:58] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [18:20:58] (PS1) Ejegg: Switch to ct_id + sequenceNum order IDs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/271017 (https://phabricator.wikimedia.org/T127096) [18:22:43] (PS1) Eileen: Fix type error in Refund logic. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/271018 (https://phabricator.wikimedia.org/T124979) [18:24:48] (CR) jenkins-bot: [V: -1] Fix type error in Refund logic. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/271018 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [18:26:26] (PS2) Eileen: Fix type error in Refund logic. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/271018 (https://phabricator.wikimedia.org/T124979) [18:42:50] (CR) Ejegg: [C: -1] "The !$isNegative case should be consistent with this one. We were using true and false before, which seemed to work." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/271018 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [18:50:32] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint William Shatner, and 5 others: Track email clickthroughs on donate wiki - https://phabricator.wikimedia.org/T114010#2032484 (CCogdill_WMF) Our counts on donate.wiki ar... [18:55:17] Fundraising-Backlog, Wikimedia-Fundraising: Email thanks me for a $0 donation - https://phabricator.wikimedia.org/T125778#2032503 (CCogdill_WMF) Thanks @Josve05a . Believe it or not, we have it on our calendar to fix this today — we have just been working ou... [19:05:15] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint William Shatner, and 5 others: Track email clickthroughs on donate wiki - https://phabricator.wikimedia.org/T114010#2032543 (Ejegg) Hi @CCogdill_WMF! It's great to he... [19:09:26] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint William Shatner, and 5 others: Track email clickthroughs on donate wiki - https://phabricator.wikimedia.org/T114010#2032558 (CCogdill_WMF) That sounds like a good sugg... [19:24:43] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint William Shatner, and 5 others: Track email clickthroughs on donate wiki - https://phabricator.wikimedia.org/T114010#2032602 (CCogdill_WMF) @Ejegg is there any way to e... [19:28:24] (CR) Eileen: "Yeah I wondered about that - in my first patch I had TRUE & FALSE & the test failed so I changed to 1 & 0." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/271018 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [19:29:12] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint William Shatner, and 5 others: Track email clickthroughs on donate wiki - https://phabricator.wikimedia.org/T114010#2032621 (Ejegg) Sure, that shouldn't be a problem t... [19:31:18] (PS1) Ejegg: Allow logarithmically increasing Velocity penalty [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/271036 (https://phabricator.wikimedia.org/T126812) [19:38:34] (PS1) Ejegg: Widen contact_id column [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/271041 (https://phabricator.wikimedia.org/T114010) [19:39:01] (CR) Eileen: "The CiviCRM rule looks like" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/271018 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [19:40:52] (PS3) Eileen: Fix type error in Refund logic. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/271018 (https://phabricator.wikimedia.org/T124979) [19:43:35] (CR) Ejegg: [C: 2] "Looks good to me!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/271018 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [19:46:09] (Merged) jenkins-bot: Fix type error in Refund logic. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/271018 (https://phabricator.wikimedia.org/T124979) (owner: Eileen) [19:47:46] Fundraising Sprint Cat Herding, Fundraising Tech Backlog, Fundraising-Backlog, Patch-For-Review: Improve information available for this message Undefined property: stdClass::$name wmf_civicrm.module:24 [notice] - https://phabricator.wikimedia.org/T127028#2032688 (DStrine) [19:47:59] Fundraising Sprint Cat Herding, Fundraising-Backlog, Patch-For-Review: E-notice in log indicates minor error: 02:06:16 Undefined index: contribution_type_id [notice] 02:06:16 recurring_globalcollect.module:363 - https://phabricator.wikimedia.org/T127029#2032689 (DStri... [19:48:09] Fundraising Sprint Cat Herding, Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review: E-notice in log indicates minor error: 02:06:16 Undefined index: contribution_type_id [notice] 02:06:16 recurring_globalc... - https://phabricator.wikimedia.org/T127029#2030160 [19:48:24] Fundraising Sprint Cat Herding, Fundraising Tech Backlog, Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review: Improve information available for this message Undefined property: stdClass::$name wmf_civicrm.module:24 [notice] - https://phabricator.wikimedia.org/T127028#2030141... [19:49:03] (CR) XenoRyet: [C: 2] "I like the idea and the implementation." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/271036 (https://phabricator.wikimedia.org/T126812) (owner: Ejegg) [19:52:15] ejegg: thanks for that - there are 2 other really minor ones & once they are merged I'll push them out [19:52:31] cool, I'll take a look in a bit! [19:52:39] (Merged) jenkins-bot: Allow logarithmically increasing Velocity penalty [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/271036 (https://phabricator.wikimedia.org/T126812) (owner: Ejegg) [19:52:42] relocating for backlog thing... [19:52:56] cool [19:59:33] (CR) Eileen: [C: 2] "This seems fine to me. We have an issue in that our fork of buildkit is out of sync with the upstream version & needs a bit of love to get" [wikimedia/fundraising/civicrm-buildkit] - https://gerrit.wikimedia.org/r/240624 (https://phabricator.wikimedia.org/T113559) (owner: Awight) [20:00:53] (CR) Eileen: "This seems fine to me. We have an issue in that our fork of buildkit is out of sync with the upstream version & needs a bit of love to get" [wikimedia/fundraising/civicrm-buildkit] - https://gerrit.wikimedia.org/r/240624 (https://phabricator.wikimedia.org/T113559) (owner: Awight) [20:04:34] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Add country to thank you page URL - https://phabricator.wikimedia.org/T126814#2032756 (Ejegg) [20:08:34] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Banner device settings should be set at campaign level - https://phabricator.wikimedia.org/T127011#2032790 (DStrine) [20:15:43] Fundraising Sprint Cat Herding, Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review: E-notice in log indicates minor error: 02:06:16 Undefined index: contribution_type_id [notice] 02:06:16 recurring_globalc... - https://phabricator.wikimedia.org/T127029#2032839 [20:23:17] (CR) Eileen: [C: 2] Ensure 'Gateway' option value exists [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/267707 (owner: Ejegg) [20:23:59] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Astropay: GatewayAdapter::getCurrencies should return currencies supported for the donor's country - https://phabricator.wikimedia.org/T124327#2032887 (Ejegg) We could potentially get this info from the DonationInterfaceFormSettings. [20:34:40] (CR) Cdentinger: Merge antifraud records in queue consumer (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/268035 (https://phabricator.wikimedia.org/T122244) (owner: Ejegg) [20:46:50] Wikimedia-Fundraising-CiviCRM, FR-Ingenico: Possible Globalcollect audit parsing regression - https://phabricator.wikimedia.org/T127111#2032974 (Ejegg) NEW [21:15:36] i'm not saying adyen isn't probably the most "with it" payment provider of the moment [21:15:42] but their web console is hot garbage [21:18:58] is payments wiki working for you? [21:19:16] any of the fr-tech-ops getting those alerts? [21:20:22] uh oh [21:20:27] mutante: looks gone [21:20:38] haven't seen any alerts [21:21:36] it's in the operations channel [21:21:49] looks like Jeff and Chris are both afk [21:22:38] mutante: thanks for the heads up. is it related to libgcrypt11? [21:22:40] so there are 2 more people in the tech-ops group atgo and katie [21:22:49] i don't know [21:23:13] should we call people? [21:23:20] or is it not that critical right now [21:23:22] atgo is out, katie is around somewhere [21:24:04] mutante: ah wait, it's not as broken as i thought [21:24:39] ah [21:25:08] mutante: sorry my bad, fat fingered browser history [21:25:38] so it's broken? [21:25:53] no i don't think so [21:26:01] at least not all of them, i think there are 4 [21:42:05] (PS3) Ejegg: Prevent civicrm-buildkit from storing SQL dumps [wikimedia/fundraising/civicrm-buildkit] - https://gerrit.wikimedia.org/r/240624 (https://phabricator.wikimedia.org/T113559) (owner: Awight) [21:44:15] ejegg: do you remember what channel adam and andy are hanging out in? [21:44:59] think it's wikimedia-ed [21:46:10] hrhrh [22:04:26] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CiviMail TY activity should be on same contact as donation - https://phabricator.wikimedia.org/T127121#2033251 (Ejegg) NEW [22:08:50] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising-Backlog: Some Globalcollect donations not in Civi - https://phabricator.wikimedia.org/T122730#2033265 (MBeat33) From earlier in December, GC 6899946567 processed successfully... [22:10:29] (CR) Ejegg: [C: 2] Prevent civicrm-buildkit from storing SQL dumps [wikimedia/fundraising/civicrm-buildkit] - https://gerrit.wikimedia.org/r/240624 (https://phabricator.wikimedia.org/T113559) (owner: Awight) [22:12:57] (CR) Ejegg: [V: 2] Prevent civicrm-buildkit from storing SQL dumps [wikimedia/fundraising/civicrm-buildkit] - https://gerrit.wikimedia.org/r/240624 (https://phabricator.wikimedia.org/T113559) (owner: Awight) [22:15:05] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: [epic] Make deduping reversible - https://phabricator.wikimedia.org/T111704#2033289 (Eileenmcnaughton) [22:16:00] dstrine: I just updated the description here https://phabricator.wikimedia.org/T111704 with a lot more detail [22:17:24] Fundraising-Backlog, Wikimedia-Fundraising: Email thanks me for a $0 donation - https://phabricator.wikimedia.org/T125778#2033292 (CCogdill_WMF) Open>Resolved I can confirm the spacing has been fixed. [22:18:07] ejegg: the 2 minor ones are https://phabricator.wikimedia.org/T127029 https://phabricator.wikimedia.org/T127028 - should both be trivial… [22:18:28] (unless I've done something dumb!) [22:18:32] cool, I'll take a look! [22:20:13] (PS2) Ejegg: Enotice fix (indicating unset parameter) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/270890 (https://phabricator.wikimedia.org/T127029) (owner: Eileen) [22:21:27] (CR) Eileen: [C: 2] "cool" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/268701 (owner: Ejegg) [22:22:44] (CR) Ejegg: [C: 2] "D'oh! Guess we need to chase down the rest of those references." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/270890 (https://phabricator.wikimedia.org/T127029) (owner: Eileen) [22:22:54] (CR) jenkins-bot: [V: -1] Enotice fix (indicating unset parameter) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/270890 (https://phabricator.wikimedia.org/T127029) (owner: Eileen) [22:23:33] (CR) Eileen: [C: 2] "This is a backport of a security patch upstream - fine!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/268700 (owner: Ejegg) [22:23:53] (CR) Eileen: [C: 2] "This is a backport of a security patch upstream - fine!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/268699 (owner: Ejegg) [22:25:17] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/270890 (https://phabricator.wikimedia.org/T127029) (owner: Eileen) [22:25:56] (CR) Eileen: "When we use the api it protects us from underlying changes - so we have gotten away with the rest so far - but in this case we are bypassi" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/270890 (https://phabricator.wikimedia.org/T127029) (owner: Eileen) [22:28:52] (CR) jenkins-bot: [V: -1] Enotice fix (indicating unset parameter) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/270890 (https://phabricator.wikimedia.org/T127029) (owner: Eileen) [22:35:53] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising-Backlog, Patch-For-Review: LYBUNT related: Fiscal Year report does not work - https://phabricator.wikimedia.org/T123671#1935422 (Eileenmcnaughton) I brought this over to t... [22:38:21] (PS1) Eileen: Revert "Prevent civicrm-buildkit from storing SQL dumps" [wikimedia/fundraising/civicrm-buildkit] - https://gerrit.wikimedia.org/r/271135 [22:39:31] (CR) Ejegg: [C: 2 V: 2] Revert "Prevent civicrm-buildkit from storing SQL dumps" [wikimedia/fundraising/civicrm-buildkit] - https://gerrit.wikimedia.org/r/271135 (owner: Eileen) [22:39:49] (Abandoned) Ejegg: Fix SQL_SKIP comment [wikimedia/fundraising/civicrm-buildkit] - https://gerrit.wikimedia.org/r/271128 (owner: Ejegg) [22:40:25] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/270890 (https://phabricator.wikimedia.org/T127029) (owner: Eileen) [22:45:23] (CR) Eileen: "worked that time!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/270890 (https://phabricator.wikimedia.org/T127029) (owner: Eileen) [22:47:47] (PS3) Ejegg: Add debug info for when option value is not found. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/270889 (https://phabricator.wikimedia.org/T127028) (owner: Eileen) [22:48:41] (CR) Ejegg: [C: 2] Add debug info for when option value is not found. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/270889 (https://phabricator.wikimedia.org/T127028) (owner: Eileen) [22:51:59] (CR) Eileen: "A watched gerrit never merges" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/270889 (https://phabricator.wikimedia.org/T127028) (owner: Eileen) [22:54:37] (PS1) Eileen: CiviCRM security patches [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/271138 [22:55:46] (CR) Eileen: [C: 2] "Submodule update - self-reviewing" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/271138 (owner: Eileen) [22:58:00] (Merged) jenkins-bot: CiviCRM security patches [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/271138 (owner: Eileen) [23:03:04] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/271142 [23:03:41] (CR) Eileen: [C: 2] "Merging to deployment - self review" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/271142 (owner: Eileen) [23:06:19] !log Updating CiviCRM from b2566a9849c2b3a2a0c8f0b524c69bbc2dca5f8f to bccb044c39b1eb9f270a60df69771db59623599f [23:06:22] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [23:07:22] (PS2) Ejegg: Switch to ct_id + sequenceNum order IDs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/271017 (https://phabricator.wikimedia.org/T127096) [23:10:25] cwd: Yo. [23:10:30] I can't do anything about this either. [23:10:54] Wait, maybe I can do something... [23:10:59] * K4-713 texts Jeff_Green [23:13:48] hehe [23:13:58] K4-713: he knows, he was on a plane earlier [23:14:03] Oh, ha. [23:14:08] Well, he fixed it. [23:14:54] whew! [23:16:48] that will be a fun incident report [23:17:04] we basically panicked for awhile until jeff restarted apache [23:43:12] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: [epic] Make deduping reversible - https://phabricator.wikimedia.org/T111704#2033654 (Eileenmcnaughton) [23:45:17] eileen: is deduping a problem in the civi world besides wmf? [23:46:13] cwd a lot of other orgs expose their civi instance to the world [23:46:31] so a donor often has an account [23:46:41] ah ha [23:46:48] so we crowd source the dedupe [23:46:58] or...they do [23:47:08] yeah... [23:48:23] Fundraising-Backlog: Make dedupe reversible step 1 of 3 test turning on logging on Staging to see how it performs. - https://phabricator.wikimedia.org/T127133#2033674 (DStrine) [23:48:37] i'm a newbie to the dedupe problem but the idea of making them undo-able sounds unsustainable [23:48:38] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: [epic] Make deduping reversible - https://phabricator.wikimedia.org/T111704#2033683 (DStrine) [23:48:40] Fundraising-Backlog: Make dedupe reversible step 1 of 3 test turning on logging on Staging to see how it performs. - https://phabricator.wikimedia.org/T127133#2033668 (DStrine) [23:49:02] unless it has an expiry [23:49:23] Fundraising-Backlog: Make dedupe reversible step 1 of 5 test turning on logging on Staging to see how it performs. - https://phabricator.wikimedia.org/T127133#2033686 (DStrine) [23:49:34] but i was wondering, what about an sql view or rollup table instead of changing the actual data? [23:49:52] Fundraising-Backlog: Make dedupe reversible step 2 of 5: Identify and Address specific points of slowness i - https://phabricator.wikimedia.org/T127135#2033687 (DStrine) NEW [23:49:56] cwd yeah, I think the idea was to turn on audit logging and see how crazy the space requirements got [23:50:13] Fundraising-Backlog: Make dedupe reversible step 2 of 5: Identify and Address specific points of slowness i - https://phabricator.wikimedia.org/T127135#2033696 (DStrine) [23:50:15] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: [epic] Make deduping reversible - https://phabricator.wikimedia.org/T111704#1614185 (DStrine) [23:50:18] you'd need a lot fewer indexes on the audit stuff [23:50:43] and some of our biggest tables are using 2x the space for index as they are for data [23:50:51] yeah i believe it [23:51:46] cwd the logging option was pioneered by the New York State Senate I think? [23:52:03] interesting [23:52:05] is it bin logs? [23:52:17] basically the requirement to have reversability is not something most orgs specifically link to deduping [23:52:23] shadow tables I think [23:52:33] yeah shadow tables [23:52:41] and size could be a big problem I agree [23:53:07] eileen: so, the shadow table unique keys are something like original table id + version # ? [23:53:18] or timestamp? [23:53:25] ejegg: normally they don't have unique keys per se [23:53:41] hmm [23:53:46] in fact in their 'native' manner they use the archive engine & are write only [23:54:04] whoa [23:54:10] but for performance reasons we sometimes convert them to innodb [23:54:16] gotta be some way to read them if they're to be any use! [23:54:34] well 90% of the time when I use them it is for forensics on an issue [23:54:44] or me recovering data lost due to some bug [23:54:47] would a view be an option? you could then tweak the rules real time and "undo" would be a non-issue [23:54:53] huh, ok [23:55:14] cwd - how would a view work? [23:55:22] cwd there's a huge amount of stuff that reads and writes from the contact etc tables [23:55:27] ie. how does a view give you history? [23:56:04] hmmm, well i don't know the problem space very well [23:56:34] but like in what context do things need to be deduped? when reports are run? when people search for contribs in civi? [23:56:57] cwd definitely when sending bulk emails [23:57:17] cwd so the next step after the reversibility is to run a script through the DB deduping low-hanging fruit [23:57:37] so, I guess the worry is 'what do we do if that mis-dupes people' [23:57:52] yeah [23:58:15] well take the email problem for instance, i think that would be pretty trivially solved with a rollup of some sort [23:58:33] the email job would just ask a different source for data [23:58:47] and you wouldn't have to touch the existing stuff [23:59:10] cwd yeah, we do a bunch of de-duplication in the nightly silverpop export [23:59:20] yeah the issue is more that the same people are in our database multiple times giving inaccurate donor history etc [23:59:31] rollups + dedupes take about an hr each night [23:59:41] (CR) Paladox: "recheck" [extensions/ContributionReporting] - https://gerrit.wikimedia.org/r/270059 (owner: L10n-bot) [23:59:41] ouch [23:59:47] but ok [23:59:55] I suppose