[00:03:56] <grrrit-wm>	 (PS3) Cdentinger: WIP Adyen audit processor [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/270457
[00:08:25] <wikibugs>	 Fundraising Sprint Dirt Farming, Fundraising-Backlog: Make dedupe reversible step 1 of 5 test turning on logging on Staging to see how it performs. - https://phabricator.wikimedia.org/T127133#2037297 (Eileenmcnaughton) a:Eileenmcnaughton
[00:08:57] <wikibugs>	 Fundraising Sprint Dirt Farming, Fundraising-Backlog: Make dedupe reversible step 2 of 5: Identify and Address specific points of slowness i - https://phabricator.wikimedia.org/T127135#2037298 (Eileenmcnaughton) a:Eileenmcnaughton
[00:10:35] <grrrit-wm>	 (PS5) Eileen: Fix e-Notice due to some Option Values not having the 'name' field filled in. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/271188 (https://phabricator.wikimedia.org/T127029)
[00:11:40] <grrrit-wm>	 (CR) Eileen: "I opened this up to all option groups for custom fields. There were a couple on individual_suffix & the like which didn't look unique so I" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/271188 (https://phabricator.wikimedia.org/T127029) (owner: Eileen)
[00:16:16] <grrrit-wm>	 (PS1) Eileen: Get more info when contribution create fails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/271447
[00:17:19] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Get more info when contribution create fails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/271447 (owner: Eileen)
[00:37:34] <grrrit-wm>	 (PS3) Ejegg: WIP Adyen audit processor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/270416 (https://phabricator.wikimedia.org/T121129)
[00:37:36] <grrrit-wm>	 (PS1) Ejegg: Rename get_recon_file_date function [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/271450 (https://phabricator.wikimedia.org/T121129)
[00:42:41] <grrrit-wm>	 (PS2) Ejegg: Rename get_recon_file_date function [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/271450 (https://phabricator.wikimedia.org/T121129)
[00:42:43] <grrrit-wm>	 (PS4) Ejegg: WIP Adyen audit processor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/270416 (https://phabricator.wikimedia.org/T121129)
[00:43:13] <grrrit-wm>	 (CR) Ejegg: "Thanks cwd, this one should fix the issues" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/270416 (https://phabricator.wikimedia.org/T121129) (owner: Ejegg)
[00:43:23] <grrrit-wm>	 (CR) Ejegg: WIP Adyen audit processor (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/270416 (https://phabricator.wikimedia.org/T121129) (owner: Ejegg)
[00:44:58] <grrrit-wm>	 (CR) Ejegg: [C: 2] "So modern!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/271447 (owner: Eileen)
[00:59:02] <grrrit-wm>	 (PS6) Ejegg: Fix e-Notice due to some Option Values not having the 'name' field filled in. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/271188 (https://phabricator.wikimedia.org/T127029) (owner: Eileen)
[01:09:50] <grrrit-wm>	 (CR) Ejegg: [C: 2] "Huzzah for signal to noise ratio improvements!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/271188 (https://phabricator.wikimedia.org/T127029) (owner: Eileen)
[01:17:06] <eileen>	 ejegg: I think I will push those last patches out to deployment.  Are there any others we should squeeze through first?
[01:17:49] <ejegg>	 eileen: I think we're good as-is
[01:18:06] <eileen>	 ok - I'll do it then
[01:18:52] <ejegg>	 I'm trying to get this one merged and deployed before we deploy smashpig next, but it certainly doesn't need to be tonight: https://gerrit.wikimedia.org/r/268035
[01:21:42] <grrrit-wm>	 (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/271456
[01:23:07] <grrrit-wm>	 (CR) Eileen: [C: 2] "merge from master - self reviewing" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/271456 (owner: Eileen)
[01:25:49] <ejegg>	 i gotta head out.  good luck with the deploy eileen !
[01:26:55] <eileen>	  !log Updating civicrm
[01:26:56] <eileen>	 from bccb044c39b1eb9f270a60df69771db59623599f to 352bd7ce9abc4d3ce954e978aa333e6ec4a59849
[01:50:56] <wikibugs>	 Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Advise on reports - https://phabricator.wikimedia.org/T126297#2037607 (Eileenmcnaughton) Hi Caitlin,   Sorry I've been a bit slow on this!  This is the bas...
[01:50:58] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add dropdown with standard reasons to refunded donation area. - https://phabricator.wikimedia.org/T125224#2037608 (Ejegg)
[03:52:24] <grrrit-wm>	 (CR) Cdentinger: [C: 2] Rename get_recon_file_date function [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/271450 (https://phabricator.wikimedia.org/T121129) (owner: Ejegg)
[03:55:51] <grrrit-wm>	 (PS2) Cdentinger: Include composer autoloader in default settings file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/271357 (owner: Ejegg)
[04:04:39] <grrrit-wm>	 (CR) Cdentinger: [C: 2] "I could see putting more details about our particular Civi install in version control here, there are quite a few config variables and so " [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/271357 (owner: Ejegg)
[13:43:43] <wikibugs>	 Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: [Epic] Restore Civi manual refund functionality - https://phabricator.wikimedia.org/T124979#2039298 (MBeat33) @Eileenmacnaughton totally, and many thanks -...
[16:08:48] <grrrit-wm>	 (PS5) Cdentinger: WIP Adyen audit processor [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/270416 (https://phabricator.wikimedia.org/T121129) (owner: Ejegg)
[16:10:15] <ejegg>	 Hi cwd!
[16:10:25] <ejegg>	 I'm thinking of deploying DonationInterface soon
[16:10:26] <cwd>	 morning!
[16:10:44] <cwd>	 lessee...
[16:10:54] <ejegg>	 Would be cool if we could get these two adyen related bits up too: https://gerrit.wikimedia.org/r/270353 https://gerrit.wikimedia.org/r/271017
[16:12:33] <cwd>	 cool lemme take a look
[16:12:44] <ejegg>	 thanks!
[16:13:12] <grrrit-wm>	 (PS2) Cdentinger: Log Adyen donation details before redirect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/270353 (https://phabricator.wikimedia.org/T121129) (owner: Ejegg)
[16:18:26] <grrrit-wm>	 (CR) Cdentinger: [C: 2] Log Adyen donation details before redirect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/270353 (https://phabricator.wikimedia.org/T121129) (owner: Ejegg)
[16:20:41] <grrrit-wm>	 (Merged) jenkins-bot: Log Adyen donation details before redirect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/270353 (https://phabricator.wikimedia.org/T121129) (owner: Ejegg)
[16:37:25] <cwd>	 ejegg: i'm having trouble wrapping my mind about the order id regen thing
[16:37:52] <cwd>	 it's not checking if the sequence number is different from last time, just if it's there
[16:38:07] <cwd>	 so i'm thinking about >2 things happening at once
[16:39:09] <cwd>	 don't we want to regenerate the order id whenever they open a new payments tab?
[16:48:42] <ejegg>	 cwd sorry, got distracted!
[16:49:08] <ejegg>	 cwd so, there's always an order ID generated by the time you get to do_transaction
[16:49:21] <ejegg>	 sequence number starts out at zero
[16:50:01] <ejegg>	 so if this is your first time calling do_transaction, you check the sequence number, it's zero, and you don't regenerate, which is fine, cause you never used that order id
[16:50:16] <ejegg>	 then at the end of the do_transaction call you increment the sequence number
[16:50:58] <ejegg>	 I don't regenerate the order number right then, because I want any remaining log lines for this request to have the same order number as the request has had to this point
[16:51:12] <ejegg>	 then you open a new tab or click a different card type
[16:51:40] <ejegg>	 you check the sequence number, and it's non-zero, which means this isn't your first time using the contribution tracking id
[16:51:53] <ejegg>	 which means you should make sure you have a new order ID
[16:52:12] <ejegg>	 so that's why I put the regeneration there
[16:52:24] <cwd>	 ah ha, so it's ok to have multiple order ids pointing to the same ct_id?
[16:52:30] <ejegg>	 cwd yep
[16:53:03] <ejegg>	 one ct_id should include all the attempts up to a successful or definitively failed donation
[16:54:31] <cwd>	 ok, i imagine this will be fine then
[16:54:35] <cwd>	 thanks for the explanation
[16:54:38] <ejegg>	 sure thing!
[16:54:50] <grrrit-wm>	 (PS3) Cdentinger: Switch to ct_id + sequenceNum order IDs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/271017 (https://phabricator.wikimedia.org/T127096) (owner: Ejegg)
[16:54:58] <grrrit-wm>	 (CR) Cdentinger: [C: 2] Switch to ct_id + sequenceNum order IDs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/271017 (https://phabricator.wikimedia.org/T127096) (owner: Ejegg)
[16:55:03] <ejegg>	 It's kinda un-DRY, if you look at Astropay and I think Amazon you see the same pattern
[16:55:43] <ejegg>	 I think we could say it should happen that way whenever order_id_meta['ct_id'] is true
[16:56:13] <cwd>	 yeah so basically after the first successful transaction you start regenerating every time
[16:56:17] <ejegg>	 yah
[16:56:24] <cwd>	 could make it a function called shouldregen or whatever
[16:56:27] <cwd>	 for semantics
[16:57:06] <ejegg>	 word
[16:58:54] <ejegg>	 you'll probably want to update the test report you're using to develop the audit parser, to add .0 or the like to all the MerchantReference numbers
[16:59:16] <cwd>	 ah yeah, will do
[16:59:41] <grrrit-wm>	 (Merged) jenkins-bot: Switch to ct_id + sequenceNum order IDs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/271017 (https://phabricator.wikimedia.org/T127096) (owner: Ejegg)
[17:01:54] <grrrit-wm>	 (PS1) Ejegg: Expand list of penalized fraudy error codes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/271556 (https://phabricator.wikimedia.org/T126813)
[17:06:23] <wikibugs>	 Fundraising Sprint Dirt Farming, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, and 2 others: Update payment methods and submethods for AstroPay LATAM rollout - https://phabricator.wikimedia.org/T124323#2040184 (Ejegg)
[17:09:08] <wikibugs>	 Fundraising Sprint Dirt Farming, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, and 2 others: Update payment methods and submethods for AstroPay LATAM rollout - https://phabricator.wikimedia.org/T124323#2040217 (Ejegg) Grr, dev site doesn't do URL fragm...
[17:09:35] <ejegg>	 XenoRyet1: I fixed the link to the payment methods by country list in the AstroPay ticket
[17:09:59] <ejegg>	 read the last comment too
[17:10:42] <XenoRyet1>	 10-4
[17:11:22] <wikibugs>	 Fundraising Sprint Dirt Farming, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Astropay: GatewayAdapter::getCurrencies should return currencies supported for the donor's country - https://phabricator.wikimedia.org/T124327#1952880 (Ejegg) a:Ejegg
[17:29:13] <ejegg>	 phooey, this currency-by-county thing is more complicated than I expected
[17:29:57] <ejegg>	 We're not actually specifying currencies on a lot of those form settings
[18:10:20] <grrrit-wm>	 (PS1) Cdentinger: More helpful message on parseDonation error [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/271565
[18:23:34] <grrrit-wm>	 (PS1) Ejegg: WIP filter currencies by country [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/271569 (https://phabricator.wikimedia.org/T124327)
[18:24:22] <grrrit-wm>	 (CR) Ejegg: [C: 2] "Helpful!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/271565 (owner: Cdentinger)
[18:30:23] <dstrine>	 hey fr-tech, aside from casey's note on the sprint links, is anyone having any trouble in phabricator?
[18:31:43] <dstrine>	 I'm not seeing any problems with our tasks or anything fundamentally different with our workflows. However I want to surface anything you find annoying or blocking
[18:33:21] <XenoRyet1>	 Haven't noticed anything yet, but I'll poke around some and let you know.
[18:33:22] <cwd>	 haven't noticed anything
[18:33:28] <cwd>	 nice new features too!
[18:34:01] <dstrine>	 ok thanks all!
[18:52:33] <wikibugs>	 Wikimedia-Fundraising: Opting out of the annual fundraising e-mail is a terrible user experience; links.email.donate.wikimedia.org has invalid certificate - https://phabricator.wikimedia.org/T60373#2040991 (CCogdill_WMF)
[18:52:35] <wikibugs>	 Blocked-on-Fundraising-Tech, Wikimedia-Fundraising, HTTPS: links.email.donate.wikimedia.org should offer HTTPS - https://phabricator.wikimedia.org/T74514#2040989 (CCogdill_WMF) declined>Resolved Reopening (and resolving) this task to say Fundraising Tech has successfully set up email click tracki...
[19:37:34] <grrrit-wm>	 (PS1) Ejegg: Add minfraud library [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/271590
[19:38:22] <grrrit-wm>	 (CR) Ejegg: [C: 2 V: 2] "Self-merging 3rd party lib we were already using" [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/271590 (owner: Ejegg)
[19:39:25] <grrrit-wm>	 (PS1) Ejegg: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/271592
[19:40:22] <grrrit-wm>	 (CR) Ejegg: [C: 2 V: 2] "Self-reviewing merge for deployment" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/271592 (owner: Ejegg)
[19:44:27] <grrrit-wm>	 (PS1) Ejegg: Update extensions/DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/271593
[19:45:47] <grrrit-wm>	 (CR) Ejegg: [C: 2 V: 2] "Self-merge for deploy" [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/271593 (owner: Ejegg)
[19:50:21] <ejegg|afk>	 gonna update DonationInterface if nobody objects
[19:55:35] <ejegg>	 !log updated payments-wiki from 5b909f06acce6444186ac02a494439c2ddd624aa to fdea9fa9a5951d7ae57bb4d54aa9374f236638d6
[19:55:39] <morebots>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master
[19:56:42] <ejegg>	 !log rolled back payments-wiki to 5b909f06acce6444186ac02a494439c2ddd624aa
[19:56:46] <morebots>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master
[19:56:52] <ejegg>	 hmm, let's see what went wrong...
[19:58:02] <cwd>	 ejegg: what did you see?
[19:58:32] <ejegg>	 I got a 'no procesors available' error as soon as I clicked a card type on the GC form
[19:58:42] <ejegg>	 oh man, I'm so dumb...
[19:58:52] <ejegg>	 was looking at my dev server
[19:59:11] <cwd>	 hehe
[19:59:11] <ejegg>	 relying too much on the magic history completion
[19:59:17] <ejegg>	 ok, let's try that again
[19:59:18] <cwd>	 i did the exact same thing the other day
[20:00:01] <cwd>	 when 1001 was thrashing, i checked my laptop and thought payments was down
[20:00:10] <ejegg>	 heh
[20:00:31] <ejegg>	 !log updated payments-wiki from 5b909f06acce6444186ac02a494439c2ddd624aa to fdea9fa9a5951d7ae57bb4d54aa9374f236638d6
[20:01:49] <ejegg>	 ok, didn't break GC!
[20:02:15] <cwd>	 adyen looks fine too
[20:04:06] <ejegg>	 rockin
[20:05:53] <ejegg>	 new log line looks good, merchantReference/order_id/correlation_id has the .0 sequence suffix
[20:06:58] <ejegg>	 nicely anonymized, too.  Think I'll use it for test data!
[20:07:14] <cwd>	 hehe excellent
[20:10:34] <ejegg>	 well, I'll zap your IP...