[00:01:24] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/272638 [00:03:02] (CR) Eileen: [C: 2] "Merge commit - self-approving" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/272638 (owner: Eileen) [00:07:31] !log Updating civicrm from 07f8ea80d3fee19d4977d673a719f5a692ffbded to 181ef79fd1360ca337990b6768ebc10b1185a431 [00:07:34] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [01:08:38] Fundraising Sprint Dirt Farming, Fundraising-Backlog: Make dedupe reversible step 1 of 5 test turning on logging on Staging to see how it performs. - https://phabricator.wikimedia.org/T127133#2053770 (Eileenmcnaughton) @Jgreen I have uploaded the sql that would turn logging on on staging to my sandbox bra... [04:25:04] Blocked-on-Fundraising-Tech, Wikimedia-Fundraising, HTTPS: links.email.donate.wikimedia.org should offer HTTPS - https://phabricator.wikimedia.org/T74514#2054108 (Chmarkine) So is `links.email.donate.wikimedia.org` still in use? If not, can we remove it from the DNS record? [04:58:51] Blocked-on-Fundraising-Tech, Wikimedia-Fundraising, HTTPS: links.email.donate.wikimedia.org should offer HTTPS - https://phabricator.wikimedia.org/T74514#2054126 (CCogdill_WMF) It will be in use for another couple of weeks, until the Swedish banners come down. We have an active automated email program... [15:33:01] Fundraising-Backlog: Civi: search by date+amount range is inoperative - https://phabricator.wikimedia.org/T127836#2055432 (MBeat33) [16:43:55] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add dropdown with standard reasons to refunded donation area. - https://phabricator.wikimedia.org/T125224#2055707 (MBeat33) The full range of reasons we manually refund Ingenico transactions would include: fraud chargeback - Ingenico dispute chargeback... [17:10:30] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Easy: Clone button for CN campaigns - https://phabricator.wikimedia.org/T91078#2055879 (Pcoombe) Bumping this, it would save us even more time now there are so many mixin settings that we use in Fundraising campaigns. [17:21:14] (PS1) Ejegg: Document all the Adyen AVS/CVV result codes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/272768 [17:39:02] (CR) Cdentinger: [C: 2] Document all the Adyen AVS/CVV result codes [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/272768 (owner: Ejegg) [18:06:13] (PS1) Ejegg: Delete unused images [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/272782 [18:07:56] !log updated SmashPig from 97629339994bffe8831a9067f5e9c21fa423586b to c34a5fc3cfbb16d6fb019bea9a3d8d73eeb73f7b [18:08:00] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [18:11:13] ok, queued up the capture job [18:13:32] d'oh, error [18:14:03] hmmm [18:14:13] Undefined property: SmashPig\CrmLink\Messages\DonationInterfaceMessage::$order_id [18:14:29] yep [18:14:38] lemme see what I should have been using [18:14:50] and maybe add a constructor test for antifraudmessage [18:16:36] hmm, order_id should totally be a property [18:21:10] ahh, not actually setting it in DI - needs to be derived from correlation id [18:23:40] MBeat: did sal's email make any sense to you? i did some searching in civi but still couldn't find any of those transactions, but maybe i'm not searching for the right thing...contribution ids? [18:23:57] let me take a look [18:26:35] from Sal’s .xls doc, the order IDs are in Civi if you plug em into Gateway Transaction ID. The Merch Ref #s are only at the Ingenico portal, cwd [18:27:40] beyond that I’m not sure what we need to get this batch into Civi [18:28:50] MBeat: ok that's what i thought, so you agree that they're not in civi yet? [18:29:47] nope, I just tested a couple and they’re still not there [18:30:31] drag. the output from the audit parser is long and confusing so i was hoping they made it and i just couldn't tell [18:30:50] well i'll see if i can see why [18:40:56] (CR) Eileen: "I've started looking at this patch as it will help me on what I am working on & I fortuitously came across it at the right time." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/132156 (owner: Awight) [18:49:01] (PS1) Ejegg: Set antifraud order id from merchantReference [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/272791 (https://phabricator.wikimedia.org/T122244) [18:49:25] cwd mind taking a look at ^^ when you have a chance? [18:52:07] I guess we can use that last donation as a test case for filling in missing stuff from the audit [18:52:53] sure thing [18:53:13] thanks! [18:55:16] (CR) Cdentinger: [C: 2] Set antifraud order id from merchantReference [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/272791 (https://phabricator.wikimedia.org/T122244) (owner: Ejegg) [18:55:27] thanks! [18:55:33] I'll deploy that and test again [18:57:13] np! [18:58:59] !log updated SmashPig from c34a5fc3cfbb16d6fb019bea9a3d8d73eeb73f7b to d2083b28c28bd6afe61d30fc913fa0edd4203f82 [18:59:03] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [19:05:43] aargh, failmail flood still in effect [19:05:57] where is that not getting caught...? [19:08:15] and... avsResult and cvvResult are blank too. phooey again [19:09:46] ohhh, I need to ask them to turn on the additionalData for prod... [19:10:59] ejegg: question about GC merchant refs... [19:11:19] does the stuff after the dot represent the same attempt? [19:11:30] like...the first part is a transaction and the 2nd is "sub" stuff? [19:11:53] cwd um, sort of [19:12:06] I think the second part is totally random, actually [19:12:10] let me look at the code [19:14:39] cwd huh, yep, it's random. [19:14:46] the first part is the ct_id [19:15:08] and the second part is the 5 least significant digits of microtime [19:15:45] ejegg: thanks! that makes sense [19:16:12] yw [19:41:37] (PS1) Ejegg: Job runner should catch all exceptions [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/272804 (https://phabricator.wikimedia.org/T117447) [19:42:34] (PS1) Ejegg: More logging in Adyen capture request job [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/272805 (https://phabricator.wikimedia.org/T122244) [19:42:59] cwd not sure why it's still breaking, but hopefully those ^^^ will shed some light [19:44:10] cool, checking [19:44:18] thank you [19:44:40] (CR) Cdentinger: [C: 2] Job runner should catch all exceptions [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/272804 (https://phabricator.wikimedia.org/T117447) (owner: Ejegg) [19:44:57] derp, not verified yet [19:45:44] heh, lot of good that verification does - just checking the composer.json syntax, I think [19:47:17] (Merged) jenkins-bot: Job runner should catch all exceptions [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/272804 (https://phabricator.wikimedia.org/T117447) (owner: Ejegg) [19:48:58] (CR) Cdentinger: [C: 2] More logging in Adyen capture request job [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/272805 (https://phabricator.wikimedia.org/T122244) (owner: Ejegg) [19:49:30] if only this stuff were more locally reproduceable [19:49:40] but that sounds like a bear [19:50:00] yeah, I thought sure I'd tested it all locally [19:50:18] got the queue running and all [19:51:22] i don't even know all the moving pieces on the live setup [19:52:53] let's see - front end wiki -> queue -> ipn receiver -> queue -> job runner -> queue -> civi, I think [19:53:32] oh, I should relocate for backlog thing [19:55:06] dstrine: fud? [19:55:27] sorry I just came back. I was about to go to backlog grooming [19:56:02] d'oh! ok, will say hi later [19:56:55] ccogdill: you lunching? [19:57:17] awight was going to wait another 30… not quite hungry yet [19:57:25] but I can forage with you if you’re looking for a buddy :) [19:57:35] awight: where are you hiding these days? [19:57:38] yes, please! I can wait 30, have to be back by 1 [19:57:45] I haven't seen you at your desk in like a month [19:57:46] oh well we can go sooner [19:57:47] I'm on 5, mingling with the social scientists ;) [19:57:54] a rushed lunch break is no good! [19:58:13] awight just lmk when you want to go, I’m not on a strict schedule today [20:01:55] dstrine: truck just turned up to drop stuff off - will be a few mins [20:02:22] Fundraising-Backlog: Ingenico: BPay donation form shows blank screen after 'Continue' - https://phabricator.wikimedia.org/T127863#2056781 (MBeat33) [20:02:42] Fundraising-Backlog: Ingenico: BPay donation form shows blank screen after 'Continue' - https://phabricator.wikimedia.org/T127863#2056762 (MBeat33) Sorry about that, @Aklapper [20:05:57] oops awight, my mom is leaving the bay today and wants to meet for lunch. rain check, por favor! [20:07:39] (CR) Ejegg: [C: -2] "Thanks, but I think we don't want to do this here. This will make composer complain when we try to update, and it looks like the only affe" [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/272214 (https://phabricator.wikimedia.org/T127608) (owner: Ori.livneh) [20:07:50] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Reactivate Civi Login for Engage User - https://phabricator.wikimedia.org/T127375#2056816 (DStrine) @LeanneS can you ask if this person can get to the login screen? If they can, they just need to be reactivated. Otherwise they need a cert and that will... [20:09:20] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: CiviMail TY activity should be on same contact as donation - https://phabricator.wikimedia.org/T127121#2033251 (DStrine) [20:09:33] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Reactivate Civi Login for Engage User - https://phabricator.wikimedia.org/T127375#2041914 (Eileenmcnaughton) Her actual account is still active - if she can get to the site (has the certificate) it should work [20:27:17] Fundraising-Backlog, WMF-Design: Polish : Credit card input form should reflect organization of credit card - https://phabricator.wikimedia.org/T1189#2056922 (Volker_E) [20:55:25] Some nice news from down here http://www.nzherald.co.nz/business/news/article.cfm?c_id=3&objectid=11594599&ref=NZH_FBpage [20:56:06] awesome! [20:58:28] cool! i want to visit [21:01:24] !log updated SmashPig from d2083b28c28bd6afe61d30fc913fa0edd4203f82 to e106af8d440b461779cca60d55efba33dbfa7518 [21:01:29] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:02:31] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Reactivate Civi Login for Engage User - https://phabricator.wikimedia.org/T127375#2057130 (LeanneS) @Eileenmcnaughton She tried, but received an error message that the website declined to show the webpage. [21:05:13] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Reactivate Civi Login for Engage User - https://phabricator.wikimedia.org/T127375#2057150 (Eileenmcnaughton) OK - so it's the certificate that she doesn't have - that one comes from @Jgreen - he's away this week unfortunately [21:05:38] cwd ejegg yep - I haven't been to that area since I was a kid - I think I need to go back too! [21:11:09] (PS1) Ejegg: Fix queue function call names [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/272825 (https://bugzilla.wikimedia.org/122244) [21:11:26] cwd so... I guess I really didn't test this job ^^^ [21:12:46] b...bugzilla? [21:13:01] d'oh, missed a 'T' [21:13:03] * cwd PTSDs [21:13:05] lemme fix that [21:13:28] (PS2) Ejegg: Fix queue function call names [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/272825 (https://phabricator.wikimedia.org/T122244) [21:13:41] oh funny [21:13:46] sorry to startle you! [21:14:24] hehe [21:15:07] so...shouldn't we have an integration test for smashpig that will catch php errors? [21:15:35] yeah, we need a mock queue object [21:15:42] would be dead easy to swap in with config [21:15:54] also, CI should run phpunit for smashpig [21:16:25] i could probably take care of that part [21:16:42] that'd be cool! [21:18:34] i'll file a bug anyway [21:18:57] (CR) Cdentinger: [C: 2] Fix queue function call names [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/272825 (https://phabricator.wikimedia.org/T122244) (owner: Ejegg) [21:19:52] (PS1) Ejegg: Rename config's 'obj' function to 'object' [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/272833 [21:24:32] Fundraising-Backlog: SmashPig CI should run phpunit tests - https://phabricator.wikimedia.org/T127879#2057268 (cwdent) [21:25:12] ejegg: do you know if there is already a ticket for writing some tests for the queue stuff? [21:25:23] !log updated SmashPig from e106af8d440b461779cca60d55efba33dbfa7518 to 5ef60d1fb73d70b7b1501bc97273505c2d625159 [21:25:26] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:25:29] cwd I don't think so [21:25:53] want me to write one? [21:26:01] yes plz! [21:28:00] Fundraising-Backlog, FR-Smashpig: SmashPig should mock queues for tests - https://phabricator.wikimedia.org/T127880#2057293 (cwdent) [21:29:22] whew, finally [21:29:33] oh, I should tell Jenkins to email when that job fails [21:30:43] k, that's set [21:31:44] whew! [21:44:29] (CR) Ejegg: "Looks nice to have, needs manual rebase." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/241109 (owner: Awight) [21:45:13] (PS3) Ejegg: Fix Lybuns report logic to rely more on updated core report & untilise enhancements [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/265216 (https://phabricator.wikimedia.org/T123671) (owner: Eileen) [21:46:58] (Abandoned) Ejegg: Merge "Clear out session data when changing adapters" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/164087 (owner: Ssmith) [22:01:23] if anybody's got some free time, here are a bunch of mostly small commits that could use review: https://gerrit.wikimedia.org/r/#/q/owner:Ejegg+status:open+-age:1mon,n,z [22:01:54] The DonationInterface ones are all officialy in the current sprint [22:04:58] ejegg: i'd be happy to, do you feel like taking a look at these transactions that missed the audit somehow? i have some breadcrumbs but feel pretty lost [22:05:52] sure, I can take a loo [22:05:53] k [22:06:12] but you said the order numbers still aren't in the .wr* files? [22:07:34] just pm'd you [23:20:19] (PS2) Cdentinger: Log date of Amazon report in downloader [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/272538 (owner: Ejegg) [23:20:27] (CR) Cdentinger: [C: 2] Log date of Amazon report in downloader [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/272538 (owner: Ejegg) [23:21:44] (Merged) jenkins-bot: Log date of Amazon report in downloader [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/272538 (owner: Ejegg) [23:25:20] cwd I found the decoder key for wr1 files: https://git.wikimedia.org/blob/wikimedia%2Ffundraising%2Ftools.git/master/audit%2Fglobalcollect%2FWr1Parser%2FWr1DataFile.php#L49 [23:26:04] ha, i was definitely wondering what those meant [23:26:45] i was hoping xon didn't mean software flow control [23:28:27] Fundraising Sprint Dirt Farming: test task for dstrine - https://phabricator.wikimedia.org/T127906#2058041 (DStrine) [23:28:45] Fundraising Sprint Dirt Farming: test task for dstrine - https://phabricator.wikimedia.org/T127906#2058058 (DStrine) Open>Resolved [23:29:16] Fundraising Sprint Cat Herding: test task for dstrine - https://phabricator.wikimedia.org/T127906#2058041 (DStrine) [23:37:20] OK - it just got a bit wierder [23:38:54] * ejegg trepidaciously tabs over to gmail [23:39:00] :-) [23:39:21] Uh oh. Dare I look? [23:40:10] "Oliver's resignation letter is pretty wordy" is as far as I've gotten [23:40:18] sigh [23:41:55] yeah - it's extensive … there is a shorter version on L