[00:12:09] Looks like I beat vagrant by a few minutes. but I skipped all the config nitty-gritty [00:12:16] "fun"! [00:15:00] whee! [00:15:53] I lied. I missed sooo many steps. [00:16:12] hmm I feel kinda blocked now since I need jeff on the triggers. [00:16:15] F**** that: https://getcomposer.org/download/ [00:16:22] I guess I could look at https://issues.civicrm.org/jira/browse/CRM-18106 [00:17:00] awight: stretch has composer in apt :D [00:17:26] I'm so embarrassed that I just pasted that all into a root shell [00:19:41] php -r "unlink('composer-setup.php');" [00:19:44] amazing [00:19:49] i guess it's portable [00:20:15] WARNING: Please do not redistribute the install code. It will change with every version of the installer. Instead, please link to this page. [00:21:17] LOL [00:22:17] i got a linkedin friend request to my work email [00:22:17] gotta pick up the kid [00:22:38] there's no such thing as not having a linked in account [00:22:41] wat [00:22:44] you can just choose not to claim it [00:23:21] those are so disturbing. At least it's become a meme. [00:23:23] gtg! [00:25:41] Fundraising-Backlog: Updates to Adyen form so that it matches Ingenico - https://phabricator.wikimedia.org/T128541#2078310 (atgo) [00:25:49] Fundraising-Backlog: Updates to Adyen form so that it matches Ingenico - https://phabricator.wikimedia.org/T128541#2078322 (atgo) [01:17:57] how's the fam ejegg ? [01:23:37] doing well cwd, thanks for asking! [01:24:05] :) [01:24:09] do they live near by? [01:25:23] my folks do, but both my sisters are far away [02:34:34] (PS1) Cdentinger: WIP: move IDEAL to mustache forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274334 [02:36:02] (CR) jenkins-bot: [V: -1] WIP: move IDEAL to mustache forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274334 (owner: Cdentinger) [06:52:45] (CR) Awight: [C: -1] "It looks like an improvement, but I'm confused about the intended behavior. This is a twitchy enough area that we would benefit from some" (5 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/271689 (https://phabricator.wikimedia.org/T124327) (owner: Ejegg) [06:53:14] (PS2) Awight: Allow a different fallback currency for each country [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/271703 (https://phabricator.wikimedia.org/T124327) (owner: Ejegg) [07:03:57] Fundraising Sprint Dirt Farming, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Astropay, and 2 others: GatewayAdapter::getCurrencies should return currencies supported for the donor's country - https://phabricator.wikimedia.org/T124327#2078884 (awight) I would love to catch up on... [07:04:22] (CR) Awight: Allow a different fallback currency for each country (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/271703 (https://phabricator.wikimedia.org/T124327) (owner: Ejegg) [07:05:35] (PS2) Awight: Fix code for MasterCard debit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/271810 (owner: Ejegg) [07:06:44] (CR) Awight: [C: 2] "n.b. this is only supported by WorldPay at the moment" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/271810 (owner: Ejegg) [07:08:59] (Merged) jenkins-bot: Fix code for MasterCard debit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/271810 (owner: Ejegg) [07:12:26] (CR) Awight: "(only partially reviewed)" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/273310 (https://phabricator.wikimedia.org/T127121) (owner: Ejegg) [07:13:07] (CR) Awight: [C: 2] "Awesome!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/274015 (owner: Ejegg) [07:14:51] (Merged) jenkins-bot: Re-queue damaged jobs via UI [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/274015 (owner: Ejegg) [12:04:47] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: [Possibly a duplicate ticket] Upcoming SSL cert expirations - https://phabricator.wikimedia.org/T128489#2079529 (Aklapper) Potentially related on the Ops side: T112542#1682373 [14:03:22] Fundraising Sprint Dirt Farming, Fundraising-Backlog, fundraising-tech-ops, Patch-For-Review: Make dedupe reversible step 1 of 5 test turning on logging on Staging to see how it performs. - https://phabricator.wikimedia.org/T127133#2079829 (Jgreen) Yeah, you're right. Looking at trigger.mysql the... [14:51:48] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: error when cancelling recurring Ingenico donations - https://phabricator.wikimedia.org/T128389#2079925 (MBeat33) [14:59:33] Fundraising-Analysis, DBA: Consider installing pt-deadlock-logger - https://phabricator.wikimedia.org/T128011#2079928 (Jgreen) I was wrong about autocommit, but without any deadlocks reported in innodb engine status pt-deadlock-logger will have nothing to log. [17:40:55] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, WorkType-NewFunctionality: Create an import method for matching gifts and payroll deductions - https://phabricator.wikimedia.org/T115044#2080537 (CaitVirtue) Checking in on this, as it's a current pain point for us. (The January Benevity file (match... [17:41:10] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, WorkType-NewFunctionality: Create an import method for matching gifts and payroll deductions - https://phabricator.wikimedia.org/T115044#2080540 (CaitVirtue) p:Triage>High [17:58:28] atgomez: dstrine: K4-713: apologies, I didn't make it out of the house in time for the retro, so will be trapped WFH [17:59:07] I am wfh too. [17:59:31] I had near-migraine times when I woke up this morning, so I didn't even try. :p [17:59:33] Well we have a lot of others on the call [17:59:40] we are all remoties!!! [17:59:41] It's sort of funny to imagine all the couches together in one virtual office [18:00:00] One of the rare instances in which slamming a bunch of coffee actually fixed the issue. [18:23:30] cwd / K4-713 / awight - anything for scrum of scrums? [18:23:41] good here, thanks [19:07:56] Fundraising-Analysis, DBA: Consider installing pt-deadlock-logger - https://phabricator.wikimedia.org/T128011#2080864 (Eileenmcnaughton) Hi, it's ok to close if this isn't going to go anywhere useful. I thought INNODB always knew about the most recent deadlock but that is not implied by http://dba.stackex... [19:34:25] ejegg: Should I continue working down your CR? [19:34:30] and, how was the scrummy? [19:34:51] awight: sure, that would be great! [19:35:08] I did have questions about what I've reviewed so far, but that can wait until whenever [19:35:16] Scrummy was fine, some tech hiccups as it was the first with bluejeans [19:35:26] oh--cool! [19:35:29] now's fine if you have questions - ask away! [19:35:35] Can't wait until there's a free version of that. [19:35:55] k. Do you have any docs on the amount chooser feature? [19:36:04] yarp, would be nice if FF had good enough webrtc support too [19:36:09] docs on amount chooser? [19:36:10] I remember that was flagged as needing design [19:36:34] ah, no, we never got any design input as such [19:36:46] yeah, I left some comments in https://gerrit.wikimedia.org/r/#/c/271689/ [19:36:55] I just figured I'd try to improve what we've got a tiny bit [19:37:23] ah thanks, I'll peruse [19:37:59] totally [19:37:59] I'd be happy to write tests for this cos I think it's important to get right [19:37:59] but I wouldn't know how it's *supposed* to work [19:38:31] https://etherpad.wikimedia.org/p/Fundraising_-_amount_chooser [19:39:07] donno if it makes sense to separate the features like that [19:43:55] ejegg: do you agree my s/or/and/ in your first point? [19:43:58] *with [19:44:49] I realized, if the currency is unsupported then the amount is meaningless [19:45:13] right, unsupported currency should let you edit both [19:45:27] ooh-- actually there are two kinds of unsupported currency: unknown vs known but not supported [19:45:37] and maybe a distinction, supported by some gateway but not this one [19:46:24] there's also the fallback currency conversion [19:47:04] if we're convering based on potentially old rates, we might want to let them edit [19:47:12] the converted amount [19:47:38] good point! [19:49:17] cwd|afk: K4-713: you might want to get in on the etherpad ^ [19:49:23] cc eileen if you're interested! [19:51:10] edge city [19:53:48] awight / ejegg: Have you spoken to Anne and/or others who are more responsible for defining workflows? [19:54:10] Waiting for her to join to ambush about that [19:55:17] hmm, this bit was just a follow-on to the currency filtering anyway, doesn't need to go through to start working with AstroPay [19:55:30] That's probably going to be later. They're doing the monthly lunch funs at the office. [19:55:46] noms [19:55:51] I think the different fallback currencies for different countries would be more important there [19:56:03] https://gerrit.wikimedia.org/r/271703 [19:56:39] ah, just saw your comment [19:57:04] yeah, generic country -> currency map would probably make more sense [19:57:15] cool [19:57:22] I'll try to weasel that into the etherpad [19:58:37] was it that easy? [19:59:08] the fallback thing? Yeah, just a small tweak to the existing fallback logic [20:00:37] K4-713: LOL recursion [20:00:46] awight: ahh, I remember what I was thinking [20:01:04] baba [20:01:06] er. [20:01:08] Baha [20:01:13] O_O [20:01:17] I love this channel [20:01:26] that getCurrencies might use other info beyond country to decide what's available [20:01:31] I... am needing to deploy some tactical red bull. [20:01:33] ++ [20:01:59] but... by country is all we need for now [20:02:07] ejegg: Yes! Like... payment method support for whatever it is. [20:02:20] That's all over the place. [20:02:28] right, exactly [20:02:45] ejegg: This is a tiny detail, but my preference would be that getCurrencies is a helper, on a friend class [20:02:59] getSupportedCurrencies(context) [20:03:04] getPreferredCurrency(context) [20:03:58] the friend class is subclassed per gateway, or has rules for all gateways? [20:04:13] or uses some declarative structure to determine? [20:04:27] neither [20:04:38] it pulls capabilities from gateways [20:06:16] uhh, maybe I'm wrong about getSupportedCurrencies, and that should be on Gateway after all [20:06:51] so getPreferredCurrency would take things like settlement fees into account? [20:06:58] cool! [20:07:16] hmm, though that would be gateway specific too [20:07:45] sheesh, if we had multiple CC processors we could even make that decision transparently, after we know the amount [20:08:10] bah, still feels like we should be able to write out all the rules in an expanded version of the form settings [20:08:36] * awight gets confused and drifts back to feature specification [20:10:40] * awight rubs hands at apparently successfully provisioned vagrant box, 12 hours later [20:11:27] ejegg: What are you imagining for supported countries? It sounds like the AstroPay case is that only one currency is supported per method,? [20:12:08] yeah, astropay has one currency supported per country, for all methods in that country [20:13:03] oh--so there are methods which work for multiple countries but support a different currency in each one? [20:13:14] yep! [20:13:19] that is so funky. [20:13:30] I wonder if it's a feature, or an actual financial/legal thing [20:13:44] Like Visa / MC - AstroPay only wants to accept transactions in BRL for BR for example [20:14:19] err, or maybe that was our call [20:14:53] anyway, in terms of the getCurrencies helper, perhaps there are two layers. Gateway.getCurrencies, which is sensitive to context, and then a Helper::getAllSupportedCurrencies which iterates over each gateway and method or something? [20:15:13] what would that be used for? [20:15:24] if the donor chooses a currency supported by another gateway or method, we redirect to that method instead [20:15:30] gah [20:15:37] I think AliExpress had this stuff dialed in almost perfectly. [20:15:41] need to look at that again [20:15:49] oh huh, so should i [20:16:25] (PS3) Ejegg: Allow a different fallback currency for each country [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/271703 (https://phabricator.wikimedia.org/T124327) [20:16:39] (PS4) Ejegg: Allow a different fallback currency for each country [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/271703 (https://phabricator.wikimedia.org/T124327) [20:16:55] Oh. They don't allow changing anything [20:17:04] cos there is a fixed amount you need to pay [20:17:21] * awight is not well prepared for the commercial world [20:17:55] Huh, if we're going to switch to a whole different gateway form, we might as well send the donor back to donatewiki [20:18:23] not sure if that would feel rude [20:19:06] (CR) jenkins-bot: [V: -1] Allow a different fallback currency for each country [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/271703 (https://phabricator.wikimedia.org/T124327) (owner: Ejegg) [20:19:34] maybe less confusing than clicking 'donate by credit card', choosing a different currency and getting redirected to paypal [20:20:24] I don't think it's quite like that [20:20:39] the donor can make a high-level suggestion like "want to pay by credit card", [20:20:55] then we are free to redirect them to anything that supports CC (paypal actually does!) [20:21:45] hmm, the #1 thing that the AliExpress workflow does better IMO is the country chooser [20:22:26] Donors would be very likely to answer that question by choosing the country where their money resides [20:23:04] so we have a first step form that takes the currency and amount, then sends them to a method-specific form for the required fields? Sounds like reinventing the form chooser [20:23:36] I'm starting to think, we don't let people choose currency directly. [20:23:55] (nearly) all currencies are national... [20:24:30] Country also captures "which methods might be available for taking your money?" [20:25:14] Hmm, so we just need to make sure they can choose it on whatever page initially sends them to us [20:25:28] e.g. how ways to give has different links under paypal for each supported currency [20:26:09] AE doesn't display the country on every page, but makes a "more payment methods" tab available everywhere [20:26:59] ejegg: what is "choose it" ^? currency? [20:27:04] err or country [20:27:18] awight: yeah, choose currency [20:27:32] what about the idea of never offering that directly, just country? [20:28:51] hmm, so if you wanted to pay via paypal but weren't in one of the countries whose currency is supported, that would be confusing [20:29:17] Would that happen? [20:29:25] ah--I see what you mean [20:29:32] you would click "more payment methods", then [20:30:42] (PS7) Awight: Add more Latin American methods for AstroPay [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/273507 (https://phabricator.wikimedia.org/T124323) (owner: Ejegg) [20:30:49] we can take USD from a paypal user in japan though - wouldn't they be blocked that way? [20:31:26] no, they would click "more payment methods", then choose Region: united states [20:31:43] I'm just channeling "UX for review: AliExpress checkout" btw [20:31:57] ah [20:32:30] seems non-intuitive to make someone choose a country they don't live in [20:32:41] when they just want to make an international payment in a different currency [20:33:25] We should ask someone from Japan who does this [20:33:28] and if we want to record their actual country of residence, which might be legally relevant to things, we'd have to offer a separate country field [20:33:38] Why would this person want to pay in USD? [20:34:00] If PayPal only accepts USD and not JPY, then that's a second good reason to offer a country chooser and not a currency chooser [20:34:01] b/c we don't seem to support JPY via paypal [20:34:12] there's no way the donor could guess this fact [20:34:24] they would simply say "i'm in Japan" and we would present paypal as an option [20:34:37] if they choose paypal, the donation is converted to USD (pretty much what we do now) [20:35:29] ok [20:35:58] so if it's a valid but unsupported currency, always convert [20:36:15] the country chooser page on AE is really cool--as you change country, the methods are updated [20:36:21] yeah [20:36:47] but for an invalid or missing currency code, only offer the national currency, with an editable amount box? [20:37:05] yes. It might never be necessary to offer editable currency [20:38:00] ok, so if they're from JP and get to our paypal form without an amount, we show them an entry form in JPY [20:38:00] If someone has a reason to pay us in ITL, they almost certainly know that these are from Italy--and choosing country has the additional benefit of directing them to exactly the methods we support with ITL [20:38:17] ooh good question [20:38:21] then when they try to submit it, we say 'just kidding, JPY isn't supported' [20:38:30] here's what we think that is in USD [20:39:09] ouch--maybe we show small, static text "400,000 JPY" below the amount, which is updated as the USD are changed [20:39:58] hmm, so we still only offer the one fallback currency [20:40:00] ? [20:40:12] fallback? [20:40:29] In this AE-inspired workflow, yeah we only ever show the national currency for your chosen country [20:40:30] Well, USD as a fallback for JPY [20:40:43] ah--right, unless there is some method-related glitch [20:40:45] in fact. [20:40:50] even though paypal supports a bunch of other currencies [20:41:05] Maybe we shouldn't even show USD. eh, no that's wrong cos like you say the rates might be stale [20:41:20] or otherwise misunderstood [20:41:34] maybe we have a JPY entry box, but USD in fine print [20:43:06] there might be exchange fee reasons to donate in one currency vs another too - if you have an ewallet with a USD balance, but are paying from the eurozone, it would be a bummer to get ripped on the exchange rate both ways [20:43:28] huh. [20:43:41] Presumably that donor would be aware of this though [20:43:46] so might guess the country trick [20:44:10] and get an address input with a required zip code? [20:44:13] unless of course we only offer the wallet method to the eurozone [20:44:22] gah, another good point [20:44:41] I think we need to let people choose currency if they have a good reason [20:44:47] how would billing address interact with all this [20:45:20] We could pre-populate address country with the method country, but allow editing. If the donor chooses USA, we display zip [20:45:53] I'm still not convinced that these currency-aware people would be impeded by using the country chooser instead [20:46:18] right, it would just complicate giving us accurate data [20:46:29] * awight considers pinging MBeat expertise :) [20:46:53] you can even get a USD-denominated credit card in other countries [20:47:43] non-US folks who do a lot of business with US use them to avoid foreign txn fees [20:47:49] The editable fields are certainly distracting when not needed. Maybe a pencil icon plus click-to-edit is best for everything? [20:48:02] yah, I like that [20:48:20] for starters, how about just not editable when there's only one choice? [20:48:20] then, country chooser can be totally orthogonal to this [20:48:55] (reading) [20:48:57] tangentially related, anyone want to stop me from rewriting "IDEAL" in mustache? [20:48:58] Not sure that's good. Maybe the edit button in that case would redirect to country chooser? [20:49:16] cos the intent to edit currency would mean we had made a bad guess about country or method. [20:49:26] cwd: doit :D [20:49:43] awight: ok, let's do that when we add the edit button [20:50:00] it's awkwardly part of GC [20:50:22] cwd: i was wondering, if you could have different renderers depending on form? [20:50:33] awight: is it still a marginal improvement for now to not show a dropdown with a single value? [20:50:55] awight: yeah i am using ffname [20:51:12] ejegg: When does anyone see this editable thing, again? [20:51:42] right now, if there's an amount error in mustache forms, both amount and currency are editable [20:51:45] cwd: cool! Yeah if you can pull the dragon's teeth one at a time it sounds great [20:52:01] ejegg: maybe don't offer currency edit for now? [20:52:18] MBeat: ^ there's one for you :) [20:54:06] hmm, trying not to change too much just now [20:54:20] (CR) Awight: [C: 2] "Exciting stuff!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/273507 (https://phabricator.wikimedia.org/T124323) (owner: Ejegg) [20:54:52] taking away currency editing means we have to always know a good default [20:55:16] ejegg: ok. Well, this patch is a useful way to break up the code so no problem merging it. [20:55:37] (Merged) jenkins-bot: Add more Latin American methods for AstroPay [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/273507 (https://phabricator.wikimedia.org/T124323) (owner: Ejegg) [20:56:58] What K4-713 said, also: CldrCurrencies::getCurrenciesByCountry [20:58:19] yah, we also have a NationalCurrencies class floating around [20:58:46] :) [20:59:20] ejegg: Why do we throw a DomainException if more than one currency is supported? [20:59:20] Wow, I totally blew it on the "eating stuff" front. [20:59:23] aww [20:59:40] fixing. :p [20:59:53] awight: I think I'm going away from that [21:00:06] ejegg: oh--I just saw your PS4 [21:00:17] great! [21:00:27] (PS5) Ejegg: Allow a different fallback currency for each country [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/271703 (https://phabricator.wikimedia.org/T124327) [21:00:48] yeah, making the global do only what it says, not a more complicated 'fallbackCurrencyByLotsOfFactors' [21:01:25] giving donors ability to specify currency would be great, given the frequency of geolocation errors/travelers abroad - if it’s thorny to build it’s not an immediate need from DS land [21:02:32] (CR) Awight: Allow a different fallback currency for each country (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/271703 (https://phabricator.wikimedia.org/T124327) (owner: Ejegg) [21:02:47] MBeat: That sounds like we should be changing their country. [21:03:11] (CR) Awight: [C: 2] Allow a different fallback currency for each country [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/271703 (https://phabricator.wikimedia.org/T124327) (owner: Ejegg) [21:03:15] ...and a bunch of other things along with it, like available payment methods. [21:03:26] ejegg: That was hilarious, every time I had a comment your next patchset would have already corrected [21:03:36] * awight erases more drafts [21:03:44] yes. the edge cases are weird, though, like donors in France who have UK-based cards that default to EUR - we end up sending them customized urls [21:04:19] MBeat: Woah. Is that people travelling, usually, or geolocation problems? [21:04:37] Or, do people who live in France have legit UK-based cards? [21:04:55] I would believe that, like some canadians have USD cards [21:04:57] (Merged) jenkins-bot: Allow a different fallback currency for each country [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/271703 (https://phabricator.wikimedia.org/T124327) (owner: Ejegg) [21:04:58] MBeat: I think that would be covered by the combo thing we're discussing. They would probably guess to choose "region" = UK, would see the correct bank card options, then could change the currency to EUR manually. [21:05:19] mostly geolocation errors, then travelers. the ones with cards based in a country that default to a ‘non-native’ currency are rarer [21:05:34] good to know! [21:05:42] So... all of those things. Cool. :) [21:05:50] hehehe [21:05:57] just give us... 18 months [21:06:01] :) [21:06:15] so, in the 1.5 years I lived in the UK I never stopped using my kiwi credit card [21:06:47] did you pay a lot of exchange fees eileen ? [21:06:54] I don't think so [21:06:59] eileen: Would you expect to be able to use NZ payment methods? Like... er. [21:07:11] Do they BPay there? [21:07:24] in NZ? I think it's DPS [21:07:37] I... don't know that one. [21:07:45] * K4-713 makes note [21:07:52] hmm - wmf probably just offers paypal to nz? [21:08:47] We could check. [21:09:06] looks like I paid $3 by paypal in 2014 :-) [21:09:07] I mean, I'm sure paypal and credit card. [21:09:14] :D [21:12:48] yep [21:23:56] (PS2) Awight: Fix appending country to TY page URL [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/273965 (https://phabricator.wikimedia.org/T126814) (owner: Ejegg) [21:26:40] (CR) Awight: [C: 2] Fix appending country to TY page URL (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/273965 (https://phabricator.wikimedia.org/T126814) (owner: Ejegg) [21:28:06] (Merged) jenkins-bot: Fix appending country to TY page URL [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/273965 (https://phabricator.wikimedia.org/T126814) (owner: Ejegg) [21:28:34] (PS3) Awight: Update Paypal return URL handling [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/273966 (https://phabricator.wikimedia.org/T126814) (owner: Ejegg) [21:29:22] (CR) Ejegg: Fix appending country to TY page URL (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/273965 (https://phabricator.wikimedia.org/T126814) (owner: Ejegg) [21:31:07] (CR) Awight: [C: 2] "Nice one! Some minor things inline..." (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/273966 (https://phabricator.wikimedia.org/T126814) (owner: Ejegg) [21:31:34] (PS4) Awight: Don't show single-value currency dropdown [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/271689 (https://phabricator.wikimedia.org/T124327) (owner: Ejegg) [21:32:00] (CR) Awight: [C: 2] "Improvement! Edge cases are still edgy..." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/271689 (https://phabricator.wikimedia.org/T124327) (owner: Ejegg) [21:32:24] (PS5) Awight: Add more Latin American methods for AstroPay [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/273515 (https://phabricator.wikimedia.org/T124323) (owner: Ejegg) [21:32:49] (Merged) jenkins-bot: Update Paypal return URL handling [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/273966 (https://phabricator.wikimedia.org/T126814) (owner: Ejegg) [21:34:16] (CR) Awight: [C: 2] Add more Latin American methods for AstroPay (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/273515 (https://phabricator.wikimedia.org/T124323) (owner: Ejegg) [21:34:35] (CR) Awight: [C: 2] Remove obsolete Amazon FPS audit [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/274029 (owner: Ejegg) [21:34:37] (Merged) jenkins-bot: Don't show single-value currency dropdown [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/271689 (https://phabricator.wikimedia.org/T124327) (owner: Ejegg) [21:34:52] (PS2) Awight: Associate CiviMail record with the right contact [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/273310 (https://phabricator.wikimedia.org/T127121) (owner: Ejegg) [21:36:00] ejegg: fyi, I'll merge https://gerrit.wikimedia.org/r/#/c/273310 but curious if you could explain how contact_id == undefined happens? [21:36:19] hmm, lemme check [21:37:23] awight: err, outside of the test, never, I guess. I should just make that param mandatory [21:37:26] (Merged) jenkins-bot: Add more Latin American methods for AstroPay [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/273515 (https://phabricator.wikimedia.org/T124323) (owner: Ejegg) [21:37:28] (Merged) jenkins-bot: Remove obsolete Amazon FPS audit [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/274029 (owner: Ejegg) [21:38:09] ok, I'll leave that patch alone then [21:41:49] (CR) Awight: [C: 2] Use RequestContext instead of $wgLang (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274298 (owner: Krinkle) [21:41:54] (PS7) Awight: Use RequestContext instead of $wgLang [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274298 (owner: Krinkle) [21:42:55] (PS3) Ejegg: Associate CiviMail record with the right contact [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/273310 (https://phabricator.wikimedia.org/T127121) [21:43:24] ok, there it is with the param required ^^ [21:43:46] (PS4) Awight: Associate CiviMail record with the right contact [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/273310 (https://phabricator.wikimedia.org/T127121) (owner: Ejegg) [21:47:24] (CR) Awight: Associate CiviMail record with the right contact (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/273310 (https://phabricator.wikimedia.org/T127121) (owner: Ejegg) [21:48:51] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, WorkType-NewFunctionality: Create an import method for matching gifts and payroll deductions - https://phabricator.wikimedia.org/T115044#2081810 (Eileenmcnaughton) It looks like there have been some fixes around matching by email - but not about mat... [21:50:56] oh no! AndyRussG you too? where can we find two more pairs of glass slippers :) [21:51:32] (CR) Ejegg: "Most of those edge cases would be fixed by setting the currency fallback global, but the 'no currency at all' one definitely needs fixing " [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/271689 (https://phabricator.wikimedia.org/T124327) (owner: Ejegg) [21:53:37] (CR) Ejegg: Associate CiviMail record with the right contact (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/273310 (https://phabricator.wikimedia.org/T127121) (owner: Ejegg) [21:54:15] awight: wat? [21:56:18] * AndyRussG is worried [21:58:08] I heard you were also coming back to the Family, after the crazy adventures in February! [21:59:43] * awight sighs, reminiscing about canned smoked herring and guitar in the box car [22:03:28] awight: I am [22:03:59] back for the sprint kick-off! :) [22:05:14] Hmm what letter are we on now? [22:06:26] D … dirt-farming [22:06:32] you missed cat-herding! [22:07:40] (PS1) Ejegg: Make PayPal tests less tautological [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274505 [22:16:36] (CR) Awight: [C: 2 V: 1] "This is great, and works! I do question committing the perf.log in this repo though. Results are not comparable across machines, for exa" (12 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/273179 (https://phabricator.wikimedia.org/T127133) (owner: Eileen) [22:16:56] (CR) Awight: [C: 2] "One thing we have to keep in mind is that, more commerce means more trade. ;)" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274505 (owner: Ejegg) [22:17:24] heh [22:17:43] (CR) Awight: "A comment from eileen: the performance hit she mentions was actually due to debugMode, and should be disregarded." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/273179 (https://phabricator.wikimedia.org/T127133) (owner: Eileen) [22:17:51] (PS4) Awight: Add rudimentary performance timing drush command [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/273179 (https://phabricator.wikimedia.org/T127133) (owner: Eileen) [22:18:56] (CR) Awight: [C: 2] "Thanks!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/273310 (https://phabricator.wikimedia.org/T127121) (owner: Ejegg) [22:20:00] (Merged) jenkins-bot: Make PayPal tests less tautological [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274505 (owner: Ejegg) [22:21:00] (Merged) jenkins-bot: Associate CiviMail record with the right contact [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/273310 (https://phabricator.wikimedia.org/T127121) (owner: Ejegg) [22:31:03] (CR) Awight: [C: -1] "Picking at tiny scabs for now... I need to dig deeper to understand if there's a way to break into more reusable pieces." (7 comments) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/274060 (https://phabricator.wikimedia.org/T120892) (owner: Eileen) [22:31:59] (CR) Awight: "abandon for staleness?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/251572 (owner: Cdentinger) [22:33:26] (Abandoned) Cdentinger: ran composer update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/251572 (owner: Cdentinger) [22:33:36] i'm going to get back to that some day [22:34:08] (CR) Eileen: "It's worth noting that this is a backport of a patch from NYSenate" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/274060 (https://phabricator.wikimedia.org/T120892) (owner: Eileen) [22:34:09] hehe. kill it! [22:34:41] (CR) Awight: "hehehe, /me treats with additional circumspection" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/274060 (https://phabricator.wikimedia.org/T120892) (owner: Eileen) [22:39:34] (PS1) Ejegg: Fix undefined variable in logging [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274544 [22:43:29] ejegg: I moved the obviously ready tasks to Pending Deployment, but not the ones where you might be planning more work. It was totally arbitrary, don't mind me! [22:44:03] thanks! [22:45:19] (PS2) Cdentinger: WIP: move IDEAL to mustache forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274334 [22:47:18] (PS1) Cdentinger: fix quote [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274563 [22:47:43] (CR) Eileen: "I guess the subtext of that is that if something in it is worth changing it needs to meet the threshold of being worth me fixing upstream " [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/274060 (https://phabricator.wikimedia.org/T120892) (owner: Eileen) [22:48:32] (PS1) Ejegg: Move getBlahPage methods out of gateway class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274565 [22:49:17] (CR) Ejegg: [C: 2] "good catch!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274563 (owner: Cdentinger) [22:49:30] (CR) jenkins-bot: [V: -1] WIP: move IDEAL to mustache forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274334 (owner: Cdentinger) [22:49:51] awight: moved getThankYouPage et al out of the adapter for ya: https://gerrit.wikimedia.org/r/274565 [22:51:55] fancy! [22:52:03] (CR) jenkins-bot: [V: -1] Move getBlahPage methods out of gateway class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274565 (owner: Ejegg) [22:52:19] whoops, something broke... [22:53:09] oh weird, setMwGlobals doesn't complain like that on my machine [22:53:51] (Merged) jenkins-bot: fix quote [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274563 (owner: Cdentinger) [22:54:33] (PS2) Ejegg: Move getBlahPage methods out of gateway class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274565 [22:54:39] ejegg: did the test against REL1_25 disappear? [22:55:06] i just noticed it's not in the list... [22:57:39] cwd oh man, really? [22:58:01] huh, you're right [22:58:09] damn it [22:58:53] i still see it in the layout file [22:59:42] also the master test is set to voting again [22:59:44] wth [23:02:38] awight, AndyRussG, ejegg: Meeting? [23:02:53] K4-713: yep one sec :) [23:06:59] Fundraising Sprint Dirt Farming, Fundraising-Backlog: Sprint Goal D: Astropay Spanish, fix IDEAL, start dedupe work - https://phabricator.wikimedia.org/T126570#2082173 (DStrine) Open>Resolved [23:07:23] (PS3) Ejegg: Move getBlahPage methods out of gateway class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274565 [23:30:48] Fundraising Sprint Dirt Farming, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, and 2 others: Adyen capture job should have a rejection threshold - https://phabricator.wikimedia.org/T128004#2082263 (Ejegg) Open>Resolved [23:31:05] Fundraising-Backlog, Epic, FR-Adyen: [epic] Adyen campaign ready - https://phabricator.wikimedia.org/T118202#2082270 (Ejegg) [23:31:07] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 3 others: Adyen payments listener destroys donation info if capture fails - https://phabricator.wikimedia.org/T117816#2082269 (Ejegg) Open>Resol... [23:31:19] Fundraising-Backlog, Epic, FR-Adyen: [epic] Adyen campaign ready - https://phabricator.wikimedia.org/T118202#1794246 (Ejegg) [23:32:06] Fundraising-Backlog, Epic, FR-Adyen: [epic] Adyen campaign ready - https://phabricator.wikimedia.org/T118202#1794246 (Ejegg) [23:32:08] Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, Fundraising-Backlog, and 4 others: Process the Adyen audit file like the other audit files are processed - https://phabricator.wikimedia.org/T121129#2082274 (Ejegg) Open>Resolved [23:33:47] Fundraising Sprint William Shatner, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: [Epic] Followup tasks after Civi 4.6 upgrade - https://phabricator.wikimedia.org/T116416#2082288 (DStrine) [23:33:49] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Dirt Farming, Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, and 4 others: [Epic] CiviCRM upgrade: Adapt refund processing & reporting to reflect changes since the upgrade. - https://phabricator.wikimedia.org/T116317#2082287... [23:34:09] Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Advise on reports - https://phabricator.wikimedia.org/T126297#2082292 (DStrine) Open>Resolved [23:34:54] Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review: E-notice in log indicates minor error: 02:06:16 Undefined index: contribution_type_id ... - https://phabricator.wikimedia.org/T127029#2082294 [23:41:18] Fundraising Sprint Dirt Farming, Fundraising-Backlog, Wikimedia-Fundraising, Epic, FR-Ingenico: [EPIC] 'continue' button on the iDeal donation form not working - https://phabricator.wikimedia.org/T125470#2082364 (DStrine) [23:42:16] Fundraising-Backlog: Enabling Offline BT for Poland (and Other countries) - https://phabricator.wikimedia.org/T127715#2082366 (MBeat33) Sweden and Norway? [23:44:57] Fundraising Sprint Dirt Farming, Fundraising-Backlog, Wikimedia-Fundraising, FR-Ingenico: 'continue' button on the iDeal donation form not working - https://phabricator.wikimedia.org/T125470#2082391 (DStrine) [23:48:33] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Change any donor-facing GlobalCollect branding to read "Ingenico". - https://phabricator.wikimedia.org/T122597#2082440 (E... [23:53:09] Fundraising Sprint E 2016, Fundraising-Backlog: Sprint E Goal: Astropay 1-hour test ready, keep re-dupe moving - https://phabricator.wikimedia.org/T128674#2082469 (atgo) [23:55:43] Fundraising Sprint Dirt Farming, Fundraising-Backlog, fundraising-tech-ops, Patch-For-Review: Make dedupe reversible step 1 of 5 test turning on logging on Staging to see how it performs. - https://phabricator.wikimedia.org/T127133#2082532 (Eileenmcnaughton) Progress status- this is on on staging...