[00:01:15] <wikibugs>	 Fundraising-Backlog: Sprint F Goal: Scope Q4 work - https://phabricator.wikimedia.org/T128678#2082577 (atgo)
[00:03:18] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: [Possibly a duplicate ticket] Upcoming SSL cert expirations - https://phabricator.wikimedia.org/T128489#2082595 (atgo) a:atgo>None
[00:03:44] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: [Possibly a duplicate ticket] Upcoming SSL cert expirations - https://phabricator.wikimedia.org/T128489#2076602 (DStrine) a:Jgreen
[00:12:47] <awight>	 I can't fur the life of me find our internal quarterly goals wiki.
[00:14:38] <wikibugs>	 Fundraising Sprint E 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: [Possibly a duplicate ticket] Upcoming SSL cert expirations - https://phabricator.wikimedia.org/T128489#2082629 (DStrine)
[00:14:42] <wikibugs>	 Fundraising Sprint E 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: error when cancelling recurring Ingenico donations - https://phabricator.wikimedia.org/T128389#2082642 (DStrine)
[00:14:44] <wikibugs>	 Fundraising Sprint Dirt Farming, Fundraising Sprint E 2016, Fundraising-Backlog: Make dedupe reversible step 2 of 5: Identify and Address specific points of slowness i - https://phabricator.wikimedia.org/T127135#2082644 (DStrine)
[00:14:46] <wikibugs>	 Fundraising Sprint Dirt Farming, Fundraising Sprint E 2016, Fundraising-Backlog, fundraising-tech-ops, Patch-For-Review: Make dedupe reversible step 1 of 5 test turning on logging on Staging to see how it performs. - https://phabricator.wikimedia.org/T127133#2082645 (DStrine)
[00:14:48] <wikibugs>	 Fundraising Sprint Dirt Farming, Fundraising Sprint E 2016, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 3 others: Add country to thank you page URL - https://phabricator.wikimedia.org/T126814#2082647 (DStrine)
[00:14:50] <wikibugs>	 Fundraising Sprint Dirt Farming, Fundraising Sprint E 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: CiviMail TY activity should be on same contact as donation - https://phabricator.wikimedia.org/T127121#2082646 (DStrine)
[00:14:52] <wikibugs>	 Fundraising Sprint Dirt Farming, Fundraising Sprint E 2016, Fundraising-Backlog, Wikimedia-Fundraising, FR-Ingenico: 'continue' button on the iDeal donation form not working - https://phabricator.wikimedia.org/T125470#2082650 (DStrine)
[00:14:54] <wikibugs>	 Fundraising Sprint Dirt Farming, Fundraising Sprint E 2016, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 4 others: GatewayAdapter::getCurrencies should return currencies supported for the donor's country - https://phabricator.wikimedia.org/T124327#2082651 (DStrine)
[00:14:57] <wikibugs>	 Fundraising Sprint Dirt Farming, Fundraising Sprint E 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 4 others: Update payment methods and submethods for AstroPay LATAM rollout - https://phabricator.wikimedia.org/T124323#2082652 (DStrine)
[00:15:00] <wikibugs>	 Fundraising Sprint Dirt Farming, Fundraising Sprint E 2016, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Astropay: Prepare logos for AstroPay LATAM banks and cards - https://phabricator.wikimedia.org/T124320#2082653 (DStrine)
[00:15:02] <wikibugs>	 Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 3 others: LYBUNT related: Fiscal Year report does not work - https://phabricator.wikimedia.org/T123671#2082654 (DStrine)
[00:15:04] <wikibugs>	 Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 2 others: Some Globalcollect donations not in Civi - https://phabricator.wikimedia.org/T122730#2082655 (DStrine)
[00:15:06] <wikibugs>	 Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 5 others: Civi exports timing out - https://phabricator.wikimedia.org/T120892#2082657 (DStrine)
[00:15:08] <wikibugs>	 Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 3 others: Spike: Is it a problem that the Silverpop export is still not updating entire database? - https://phabricator.wikimedia.org/T120880#2082658 (...
[00:19:03] <wikibugs>	 Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 3 others: Spike: Is it a problem that the Silverpop export is still not updating entire database? - https://phabricator.wikimedia.org/T120880#2082676 (...
[00:59:45] <wikibugs>	 Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 3 others: Spike: Is it a problem that the Silverpop export is still not updating entire database? - https://phabricator.wikimedia.org/T120880#2082781 (...
[01:12:00] <grrrit-wm>	 (CR) Krinkle: Use RequestContext instead of $wgLang (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274298 (owner: Krinkle)
[01:12:46] <awight>	 I may have killed Phabricator with a 5M upload :)
[01:14:11] <awight>	 nope, it's an upgrade
[01:14:28] <grrrit-wm>	 (PS8) Awight: Use RequestContext instead of $wgLang [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274298 (owner: Krinkle)
[01:22:59] <grrrit-wm>	 (PS1) Eileen: Cast var to an array to avoid an e-Notice [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/274617
[01:25:29] <grrrit-wm>	 (CR) Eileen: "Did you change your mind about the perf_log? I see it's plus 2 now" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/273179 (https://phabricator.wikimedia.org/T127133) (owner: Eileen)
[01:29:18] <grrrit-wm>	 (CR) Awight: "I did intend to merge it, this is a great script and I have no blocking objections--especially since this commit doesn't include any outpu" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/273179 (https://phabricator.wikimedia.org/T127133) (owner: Eileen)
[01:29:22] <grrrit-wm>	 (PS5) Awight: Add rudimentary performance timing drush command [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/273179 (https://phabricator.wikimedia.org/T127133) (owner: Eileen)
[01:32:24] <eileen>	 awight: where are you at on this one? https://gerrit.wikimedia.org/r/#/c/274060/1 - ie are any of your comments important enough to fix upstream?
[01:33:19] <awight>	 eileen: I see... okay, I'll merge in the interest of a clean backport, and you can decide whether anything is worth followup
[01:33:25] <grrrit-wm>	 (PS2) Awight: CRM-17748 Expose options['result_buffering'] to CRM_Core_DAO [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/274060 (https://phabricator.wikimedia.org/T120892) (owner: Eileen)
[01:34:34] <eileen>	 awight: yeah - I'll probably leave those for now
[01:35:09] <eileen>	 that comment really should go  - but I already have a few PRs to nurse through upstream
[01:35:11] <grrrit-wm>	 (CR) Awight: [C: 2] "No blockers. This is just a backport, so my comments in the last patchset are only relevant as cleanup of core Civi code." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/274060 (https://phabricator.wikimedia.org/T120892) (owner: Eileen)
[01:35:21] <grrrit-wm>	 (PS2) Awight: Return more rows per query and use unbuffered query to manage the memory [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/274061 (https://phabricator.wikimedia.org/T120892) (owner: Eileen)
[01:35:26] <eileen>	 awight: the other thing I wanted to ask you about is the lybunt report
[01:35:53] <eileen>	 I fixed up the core lybunt report and sorted out things like performance on it
[01:36:21] <eileen>	 afterwards I didn't think the custom one gave any benefits that warranted having custom code … but....
[01:37:03] <eileen>	 then I came to the conclusion that the custom one took into account soft credits - based on one record that seemed to...
[01:37:37] <eileen>	 but… since then I can't see that we actually are looking at soft_credits in our triggers … wmf_civicrm_most_recent_completed_contribution_date
[01:37:49] <eileen>	 sorry not triggers post hook
[01:38:09] <grrrit-wm>	 (Merged) jenkins-bot: CRM-17748 Expose options['result_buffering'] to CRM_Core_DAO [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/274060 (https://phabricator.wikimedia.org/T120892) (owner: Eileen)
[01:44:40] <grrrit-wm>	 (CR) Awight: [C: 2] "Cool! I'm happy to hear that the db driver actually does unbuffered result fetching. In my only other experience, the Python MySQL clien" (3 comments) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/274061 (https://phabricator.wikimedia.org/T120892) (owner: Eileen)
[01:45:38] <awight>	 eileen: that sounds bad.  Everything soft credits related needs to be reviewed, IMO
[01:45:52] <awight>	 worth making a task even, if you wish
[01:46:21] <eileen>	 awight: hmm OK - I might be wrong - but I couldn't see anything to show it was being included in the calcs
[01:46:33] <awight>	 I've only poorly understood them, so I know I've personally overlooked in many places.
[01:46:41] <awight>	 that is probably true
[01:46:56] <awight>	 we don't have a design document for lybunt, afaik
[01:47:14] <eileen>	 well basically it currently does 2 things differently
[01:47:43] <awight>	 We should probably have a checklist for all our report design, e.g. how does it handle refunds, soft credits, multiple currencies...
[01:47:47] <eileen>	 1) sets some default fields - this could be arguably be done just by the general mechanism of creating new reports by copying old ones which is common
[01:48:21] <eileen>	 2) it queries the custom fields rather than contributions. That no longer gives performance benefits
[01:48:51] <eileen>	 however, if those fields are more accurate - eg. they take into account soft credits - then that makes it worth having
[01:49:46] <eileen>	 BUT, we can either just use the last contribution date field (in which case it's technicaly a lybuns not a lybunt)
[01:49:51] <eileen>	 or the per-year fields … but
[01:50:13] <eileen>	 the per year fields are only there for financial years, not calendar years - so we have inconsistency
[01:50:50] <eileen>	 ANOTHER option is just to fix the core lybunt report to allow soft credits to be considered and use that
[01:52:59] <awight>	 eileen: My instinct is that soft credits should clearly count in the same way that direct donations do.  It's worth consulting fr-online with that question, though.
[01:53:08] <awight>	 lybuns is a general form of lybunt, right?
[01:53:19] <eileen>	 Last Year But Not Since
[01:53:21] <eileen>	 vs
[01:53:29] <eileen>	 Last Year But Not This Year
[01:53:30] <awight>	 ah--I thought "s" stood for "some"
[01:53:39] <eileen>	 SYBUNT
[01:53:44] <awight>	 hehehe
[01:53:44] <eileen>	 Some year but not this year
[01:53:58] <eileen>	 if you run a lybunt this year it's the same as a sybunt
[01:54:02] <eileen>	 as a lybunt
[01:54:33] <eileen>	 but if you run a lybunt for 2014 then it will give LYBUNS results if we are working off 'most recent contribution'
[01:54:39] <awight>	 I'm in favor of the core solution, I guess.
[01:54:59] <eileen>	 Yeah - probably best really - I mean we usually wind up doing that in the end
[01:55:19] <eileen>	 and then we core either a) get rid of the custom report or b) just use it to set defaults
[01:55:24] <awight>	 might as well pull the self-adhesive bandage off
[01:55:29] <eileen>	 :-)
[01:55:40] <grrrit-wm>	 (Merged) jenkins-bot: Return more rows per query and use unbuffered query to manage the memory [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/274061 (https://phabricator.wikimedia.org/T120892) (owner: Eileen)
[01:55:41] <eileen>	 ok
[01:56:03] <awight>	 u think there's any use case for optionally considering soft credits, or should it just happen?
[01:56:08] <eileen>	 optional
[01:56:22] <awight>	 hrm, mebbe civi would benefit from a view that included all soft-credited contributions
[01:56:52] <eileen>	 how do you mean? You can see them on a person's contribution tab but that's not what you mean is it
[01:56:52] <grrrit-wm>	 (CR) Awight: Use RequestContext instead of $wgLang [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274298 (owner: Krinkle)
[01:56:58] <grrrit-wm>	 (CR) Awight: [C: 2] Use RequestContext instead of $wgLang [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274298 (owner: Krinkle)
[01:58:08] <grrrit-wm>	 (Merged) jenkins-bot: Use RequestContext instead of $wgLang [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274298 (owner: Krinkle)
[01:58:24] <awight>	 eileen: i mean a database view
[01:58:53] <eileen>	 oh I see like a view of contributions + soft credits as contributions kinda thing?
[01:58:55] <awight>	 We could simply change the table name in reports, when we want to include soft-credited contributions
[01:58:59] <awight>	 yah
[01:59:18] <awight>	 the vision is fading... :)
[01:59:20] <eileen>	 interesting…
[01:59:37] <eileen>	 btw this one is a really simple fix https://gerrit.wikimedia.org/r/#/c/274617/
[02:00:06] <grrrit-wm>	 (PS2) Awight: Cast var to an array to avoid an e-Notice [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/274617 (owner: Eileen)
[02:00:21] <awight>	 thanks for the stimuli!
[02:00:57] <awight>	 whoa... is that really doing (array) null?
[02:01:18] <grrrit-wm>	 (CR) Awight: [C: 2] Cast var to an array to avoid an e-Notice [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/274617 (owner: Eileen)
[02:01:32] <eileen>	 yep
[02:01:34] <eileen>	 :-)
[02:02:18] <wikibugs>	 Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 3 others: Spike: Is it a problem that the Silverpop export is still not updating entire database? - https://phabricator.wikimedia.org/T120880#2082948 (...
[02:02:46] <eileen>	 awight: there is just this one left - https://gerrit.wikimedia.org/r/#/c/274048/ - I'm guessing you won't look at that today? In which case I think I will deploy those fixes you just approved now
[02:03:14] <grrrit-wm>	 (Merged) jenkins-bot: Cast var to an array to avoid an e-Notice [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/274617 (owner: Eileen)
[02:04:17] <awight>	 eileen: Oh i did kind of chicken out on that one... lemme see...
[02:04:35] <eileen>	 awight: well there is a kind of a chicken option there...
[02:04:46] <eileen>	 I've assigned the upstream version for QA to monish
[02:04:56] <eileen>	 so you could wait & see what he says :-)
[02:14:48] <grrrit-wm>	 (CR) Awight: CRM-18125 remove country_id from filter where state_province_id is present (5 comments) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/274048 (https://phabricator.wikimedia.org/T120892) (owner: Eileen)
[02:15:56] <awight>	 rats, my vagrant civi install doesn't have CSS
[02:17:12] <awight>	 eileen: Have you smoke tested by any chance?  I would need an hour to fix my CRM install
[02:17:20] <awight>	 if so, I'm happy to merge this as-is
[02:17:32] <eileen>	  Yeah I have done a test on it
[02:17:45] <awight>	 k thanks!
[02:17:46] <wikibugs>	 Fundraising Sprint Dirt Farming, Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Wikimedia-Fundraising, FR-Ingenico: Store and update list of currenly working IDEAL banks - https://phabricator.wikimedia.org/T128692#2082991 (cwdent)
[02:17:52] <grrrit-wm>	 (PS3) Awight: CRM-18125 remove country_id from filter where state_province_id is present [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/274048 (https://phabricator.wikimedia.org/T120892) (owner: Eileen)
[02:17:59] <grrrit-wm>	 (CR) Awight: [C: 2] CRM-18125 remove country_id from filter where state_province_id is present [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/274048 (https://phabricator.wikimedia.org/T120892) (owner: Eileen)
[02:18:12] * awight blesses the ocean liner
[02:19:32] <wikibugs>	 Fundraising Sprint Dirt Farming, Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Wikimedia-Fundraising, FR-Ingenico: Move IDEAL forms to Mustache templates - https://phabricator.wikimedia.org/T128693#2083009 (cwdent)
[02:19:52] <grrrit-wm>	 (Merged) jenkins-bot: CRM-18125 remove country_id from filter where state_province_id is present [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/274048 (https://phabricator.wikimedia.org/T120892) (owner: Eileen)
[03:21:45] <grrrit-wm>	 (PS1) Eileen: CiviCRM submodule update - export speed fixes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/274624
[03:27:37] <grrrit-wm>	 (CR) Eileen: [C: 2] "Submodule - self merging" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/274624 (owner: Eileen)
[03:41:35] <grrrit-wm>	 (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/274627
[03:48:35] <wikibugs>	 Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 5 others: Civi exports timing out - https://phabricator.wikimedia.org/T120892#2083153 (Eileenmcnaughton) Dang this is annoying - on staging I just tr...
[04:36:46] <grrrit-wm>	 (CR) Eileen: [C: 2] "Merge commit, self-approving" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/274627 (owner: Eileen)
[04:42:00] <eileen>	 !log CiviCRM updated from ff0e0c6f7bc8424f8097bc66e529b7836474d416 to cbcfafcb2e6d6e1dae12a2b2d554445871992aff
[04:42:05] <morebots>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master
[04:57:14] <wikibugs>	 Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 5 others: Civi exports timing out - https://phabricator.wikimedia.org/T120892#2083234 (Eileenmcnaughton) Hmm the speed improvements were not enough t...
[08:31:33] <grrrit-wm>	 (PS1) XenoRyet: Update payment methods and submethods for AstroPay LATAM rollout [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274648 (https://phabricator.wikimedia.org/T124323)
[08:37:39] <grrrit-wm>	 (PS1) XenoRyet: Prepare logos for AstroPay LATAM banks and cards [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274649 (https://phabricator.wikimedia.org/T124320)
[08:42:46] <wikibugs>	 Fundraising Sprint Dirt Farming, Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, FR-Astropay: Prepare logos for AstroPay LATAM banks and cards - https://phabricator.wikimedia.org/T124320#2083474 (XenoRyet) Bot doesn't look to have linked...
[13:06:46] <grrrit-wm>	 (CR) Hashar: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/195375 (owner: Awight)
[14:53:40] <wikibugs>	 Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: error when cancelling recurring Ingenico donations - https://phabricator.wikimedia.org/T128389#2084324 (MBeat33) There is more going on with Civi & recurring donations. The donor in Zendesk #212072...
[14:54:00] <wikibugs>	 Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: multiple errors when cancelling recurring Ingenico donations - https://phabricator.wikimedia.org/T128389#2084325 (MBeat33)
[14:54:23] <wikibugs>	 Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: multiple errors when cancelling recurring Ingenico donations - https://phabricator.wikimedia.org/T128389#2072787 (MBeat33) p:Triage>Unbreak!
[15:31:51] <grrrit-wm>	 (CR) Hashar: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/274624 (owner: Eileen)
[15:31:57] <grrrit-wm>	 (CR) Hashar: "recheck" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/274627 (owner: Eileen)
[17:33:49] <grrrit-wm>	 (PS3) Cdentinger: WIP: move IDEAL to mustache forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274334
[17:35:17] <wikibugs>	 Fundraising Sprint Dirt Farming, Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: CiviCRM: Export broken - https://phabricator.wikimedia.org/T128221#2084888 (CaitVirtue) Thank you!
[17:35:42] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] WIP: move IDEAL to mustache forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274334 (owner: Cdentinger)
[17:40:46] <cwd>	 ejegg: can you think of a reason not to add a submethod hidden input to mustache index?
[17:41:09] <ejegg>	 why hidden?
[17:41:27] <ejegg>	 There's already the set of radio buttons in the payment_method partial
[17:41:35] <cwd>	 well on this ideal thing it's jsut statically "rtbt_ideal"
[17:42:29] <ejegg>	 let me take a look at how you're doing it, one sec
[17:43:38] <cwd>	 i was just going to set them with javascript
[17:45:12] <ejegg>	 I'd put the hidden input inside payment_method.html.mustache, in a {{^ payment_submethod_required }} block
[17:47:47] <cwd>	 ok
[17:58:17] <cwd>	 ejegg: turns out there's some magic that splits up payment method if sent like method.submethod
[17:58:50] <cwd>	 problem with marking submethod as required is it will show a bunch of radio buttons for non-choices
[17:59:03] <cwd>	 would require special casing based on ffname in several places
[18:01:52] <ejegg>	 ah word
[18:02:12] <ejegg>	 right, the {{^ block means not
[18:02:52] <cwd>	 oh, derp
[18:03:41] <cwd>	 i'm confused, doesn't GC require submethod?
[18:03:56] <ejegg>	 you can set that per method, right?
[18:05:09] <cwd>	 hrm, i'm not sure
[18:05:49] <ejegg|call>	 I think you can take that into account in getRequiredFields
[18:07:17] <cwd>	 yeah, that's where i was looking but it isn't defined in the gc adapter, just uses the parent
[18:23:54] <wikibugs>	 Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: [Possibly a duplicate ticket] Upcoming SSL cert expirations - https://phabricator.wikimedia.org/T128489#2085239 (Jgreen) I get notified daily for all certs that expire in less th...
[18:24:19] <grrrit-wm>	 (PS4) Cdentinger: WIP: move IDEAL to mustache forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274334
[18:26:16] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] WIP: move IDEAL to mustache forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274334 (owner: Cdentinger)
[18:32:37] <grrrit-wm>	 (PS5) Cdentinger: WIP: move IDEAL to mustache forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274334
[18:34:04] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] WIP: move IDEAL to mustache forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274334 (owner: Cdentinger)
[18:35:41] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Determine a process and schedule for renewing SSL certificates in Civi - https://phabricator.wikimedia.org/T115902#2085333 (Jgreen) p:Triage>Normal
[18:35:58] <wikibugs>	 Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: [Possibly a duplicate ticket] Upcoming SSL cert expirations - https://phabricator.wikimedia.org/T128489#2085339 (Jgreen)
[18:36:00] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Determine a process and schedule for renewing SSL certificates in Civi - https://phabricator.wikimedia.org/T115902#1735672 (Jgreen)
[18:42:07] <grrrit-wm>	 (PS1) Cdentinger: give 'bt' submethod a group [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274771
[18:45:49] <AndyRussG>	 awight: Heh I was wondering if I was missing like, a meeting or something
[18:47:15] <cwd>	 hehe me too
[18:47:34] <awight>	 That was crazy.
[18:47:41] <awight>	 I send the email at 9:05
[18:47:51] <awight>	 but apparently it didn't actually go out until uselessly late
[18:47:52] <awight>	 plus...
[18:48:07] <awight>	 I was looking at the wrong meeting on my phone when I sent that email.
[18:48:17] * awight pulls rock back over tunnel
[18:59:05] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Determine a process and schedule for renewing SSL certificates in Civi - https://phabricator.wikimedia.org/T115902#2085451 (Jgreen) Sorry, I never saw this ticket. Actually, even knowing that it should exist it took me about 10...
[19:00:24] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Determine a process and schedule for renewing SSL certificates in Civi - https://phabricator.wikimedia.org/T115902#2085453 (Jgreen) a:Jgreen
[19:01:27] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Determine a process and schedule for renewing SSL certificates in Civi - https://phabricator.wikimedia.org/T115902#1735672 (Jgreen) Open>Resolved Process created thus closing ticket. Please reopen if there are any additio...
[19:05:40] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Determine a process and schedule for renewing SSL certificates in Civi - https://phabricator.wikimedia.org/T115902#2085478 (CaitVirtue) Resolved>Open
[19:08:36] <wikibugs>	 Fundraising Sprint Dirt Farming, Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: CiviCRM: Export broken - https://phabricator.wikimedia.org/T128221#2085490 (Eileenmcnaughton) Erm - does that mean you've re-tried & it's OK now  ... or you are just trusting me that it is...
[19:08:44] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Determine a process and schedule for renewing SSL certificates in Civi - https://phabricator.wikimedia.org/T115902#2085491 (CaitVirtue) Re-opening, as my intention is to make sure there's an end-to-end solution for the users....
[19:12:16] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Determine a process and schedule for renewing SSL certificates in Civi - https://phabricator.wikimedia.org/T115902#2085541 (Jgreen) > @K4-713 @DStrine - I think you're in agreement with JGreen that OIT should help with the inst...
[19:34:05] <wikibugs>	 Fundraising Sprint Dirt Farming, Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: CiviCRM: Export broken - https://phabricator.wikimedia.org/T128221#2085633 (CaitVirtue) Retried!  I'm a good tester!!  ;-)
[19:43:23] <grrrit-wm>	 (CR) Ejegg: [C: 2] give 'bt' submethod a group [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274771 (owner: Cdentinger)
[19:45:19] <grrrit-wm>	 (Merged) jenkins-bot: give 'bt' submethod a group [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274771 (owner: Cdentinger)
[19:58:21] <ejegg>	 cwd: I have an idea for the submethods
[19:58:52] <cwd>	 whatcha got?
[19:59:09] <ejegg>	 when there's only one submethod available, let's leave the radio buttons in, but hide them with css and make sure the one available method is selected
[19:59:40] <ejegg>	 So the js doesn't have to decide whether to look for a checked radio button or a hidden field value
[19:59:56] <ejegg>	 I realize we're gonna need something like that for some of the AstroPay cases
[20:00:31] <cwd>	 where there's a static submethod?
[20:00:41] <ejegg>	 some countries only have one cash or one bt submethod available
[20:00:59] <ejegg>	 so it makes no sense to show the user a choice
[20:01:13] <ejegg>	 but it would be nice for the form to work exactly the same way behind the scenes
[20:01:23] <cwd>	 yeah i agree
[20:01:48] <ejegg>	 I can code that up real quick so we can both work off it
[20:02:03] <ejegg>	 unless you'd rather
[20:02:23] <cwd>	 hrm, either way is fine, how do you imagine we decide to hide the buttons?
[20:02:30] <cwd>	 specific stylesheets for those methods?
[20:02:53] <AndyRussG>	 ejegg: cwd: awight|meeting: XenoRyet: atgomez: dstrine: what should I be working on?
[20:03:23] <ejegg>	 hi AndyRussG !
[20:03:27] <AndyRussG>	 Hey :)
[20:03:28] <cwd>	 wb!
[20:03:29] <ejegg>	 let's see what we've got...
[20:03:33] <AndyRussG>	 :)
[20:03:34] <cwd>	 things have been pretty quiet on the CN front
[20:03:46] <AndyRussG>	 Yeah good to hear
[20:04:33] <ejegg>	 hmm, I dunno
[20:05:03] <ejegg>	 XenoRyet just put up some AstroPay stuff for review - I've been making some links to test all the cases locally, but we could split them up
[20:06:43] <AndyRussG>	 ejegg: ah sure! yeah I didn't see anything for review half an hour ago...
[20:06:51] <ejegg>	 cwd I was thinking we just add a class on the parent element, like we're doing with the amount and currency code inputs in the payment_amount partial
[20:07:15] <ejegg>	 AndyRussG: https://gerrit.wikimedia.org/r/274649  and https://gerrit.wikimedia.org/r/274648
[20:07:17] <XenoRyet>	 ejegg:  Cool.  I put some stuff up late last night too.  I'm mostly on baby duty until standup, but I'll take a look later this afternoon.
[20:07:32] <ejegg>	 AndyRussG: you can pull down both changes at once
[20:07:51] <AndyRussG>	 ahh Gerrit
[20:07:59] <AndyRussG>	 In truth I didn't like GitHub
[20:08:09] * AndyRussG ducks
[20:08:43] <ejegg>	 then we're comparing them to teh 'FINAL Astropay Flow' slide deck on google docs
[20:08:46] <cwd>	 ejegg: based on ffname or something?
[20:09:22] <AndyRussG>	 I guess GitHub would've worked better if we had squashed commits in PRs
[20:09:33] <AndyRussG>	 or something
[20:09:42] <ejegg>	 cwd nope, I figure just replace the 'submethod_required' var with a show_submethods var,
[20:09:45] <dstrine>	 AndyRussG: ejegg XenoRyet and cwd thanks for discussing. Astropay is definitely a high priority
[20:09:55] <ejegg>	 and set that to false when there's only one submethod
[20:10:45] <cwd>	 ejegg: when you say there's only one submethod...there are actually a few that match on the IDEAL form, but you arrive with one already set from donatewiki
[20:11:11] <cwd>	 but if i make submethod required it shows like 5 buttons
[20:12:06] <AndyRussG>	 ejegg: u sed split 'em up? which should I start on? or both or either?
[20:12:26] <AndyRussG>	 Didn't see any dependencies in Gerrit
[20:12:30] <AndyRussG>	 (between the two)
[20:13:34] <AndyRussG>	 Are either of them logically "first" or "second" -ish?
[20:14:08] <ejegg>	 AndyRussG: I think we should both pull down both patches
[20:14:23] <AndyRussG>	 ejegg: K
[20:14:27] <ejegg>	 then I'll start from the top of that doc (Brazil credit cards) and you start from the bottom
[20:14:30] <AndyRussG>	 ejegg: How do you mean pul down both at once?
[20:14:35] <ejegg>	 you can skip Peru though
[20:14:53] <AndyRussG>	 Like merge them locally?
[20:15:04] <ejegg>	 AndyRussG: you can just copy-paste the 'download' text in each gerrit page
[20:15:16] <ejegg>	 yah, just cherry-pick 'em both
[20:15:34] <AndyRussG>	 Ah heh OK
[20:15:43] <AndyRussG>	 Yeah I usually do git review -d ####
[20:16:14] <AndyRussG>	 K I'll look at 'em together
[20:16:16] <AndyRussG>	 Thanks!
[20:16:32] <ejegg>	 cwd: multiple submethods, huh? Looked like bt only had bt, but let me look
[20:16:59] <cwd>	 ejegg: method is actually rtbt
[20:17:10] <cwd>	 it was just complaining about bt when scanning the options
[20:19:56] <ejegg>	 ah, hmm, so maybe we want to do it differently...
[20:22:08] <cwd>	 i'm doing enough special casing based on ffname, maybe i should just use that to reset adapter->submethods
[20:23:09] <grrrit-wm>	 (PS1) Ejegg: Hide submethod buttons when only one choice [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274797
[20:24:13] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Hide submethod buttons when only one choice [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274797 (owner: Ejegg)
[20:25:02] <ejegg>	 cwd I think those submethods are all country-specific
[20:25:23] <ejegg>	 and if you add country keys there will probably only be a single one available for each
[20:26:33] <cwd>	 country keys to the submethods arrays?
[20:26:48] <ejegg>	 yep
[20:27:27] <cwd>	 cool i'll try that
[20:29:34] <grrrit-wm>	 (PS2) Ejegg: Hide submethod buttons when only one choice [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274797
[20:34:52] <AndyRussG>	 ejegg: what creds do I need to test out those DI patches?
[20:35:18] <AndyRussG>	 P.S. gotta run in a sec, back online in a bit... dunno if e-mail is OK 4 such, if not I guess OTR
[20:35:23] <ejegg>	 AndyRussG: I'm not sure we can test them via the AstroPay sandbox...
[20:35:34] <AndyRussG>	 hmmm
[20:36:07] <ejegg>	 I tried one of the ARS banks, but there might only be the one test bank code TE configured for astropay
[20:36:26] <ejegg>	 So I'm just checking that we send the right bank code
[20:39:30] <AndyRussG>	 Hmmm
[20:39:41] <AndyRussG>	 I have a Mexican debit card BTW, if that's useful 4 anything
[20:39:45] <AndyRussG>	 cya in a bit!
[20:46:57] <cwd>	 2 out of 3 payment processors i've worked with here paste xml into emails
[20:51:00] <ejegg>	 relocating for mtg, back soon
[21:08:16] <grrrit-wm>	 (CR) Ejegg: "pretty good so far, just a couple little things" (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274648 (https://phabricator.wikimedia.org/T124323) (owner: XenoRyet)
[21:10:18] <wikibugs>	 Fundraising Sprint Dirt Farming, Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Wikimedia-Fundraising, FR-Ingenico: Store and update list of currenly working IDEAL banks - https://phabricator.wikimedia.org/T128692#2086038 (DStrine) p:High>Normal
[21:35:05] <grrrit-wm>	 (CR) Ejegg: "FR-not-tech cares about the button order, so we should try to match what's in the slide deck. If there aren't any conflicts between count" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274648 (https://phabricator.wikimedia.org/T124323) (owner: XenoRyet)
[22:01:33] <wikibugs>	 Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 3 others: Spike: Is it a problem that the Silverpop export is still not updating entire database? - https://phabricator.wikimedia.org/T120880#2086282 (...
[22:09:00] <grrrit-wm>	 (CR) Paladox: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274648 (https://phabricator.wikimedia.org/T124323) (owner: XenoRyet)
[22:09:15] <grrrit-wm>	 (PS1) Cdentinger: remove Friesland Bank [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274828
[22:10:46] <awight>	 ccogdill: Do you have a minute to chat about Silverpop?
[22:11:06] <ccogdill>	 on a call with our email guy currently awight
[22:11:10] <ccogdill>	 I can chat at 3
[22:11:14] <awight>	 hehe, perfect.  Thanks!
[22:11:39] <ccogdill>	 k!
[22:11:41] <grrrit-wm>	 (CR) Awight: [C: 2] "Not even a bank." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274828 (owner: Cdentinger)
[22:12:21] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] remove Friesland Bank [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274828 (owner: Cdentinger)
[22:13:55] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Update payment methods and submethods for AstroPay LATAM rollout [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274648 (https://phabricator.wikimedia.org/T124323) (owner: XenoRyet)
[22:14:35] <awight>	 cwd: ^ looks like we have more regressions in the CI framework
[22:14:41] <awight>	 ERROR 2002 (HY000): Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2)
[22:14:43] <cwd>	 yep
[22:14:46] <cwd>	 talkin to lego
[22:15:06] <awight>	 awesome!
[22:15:21] * awight turns "everything is awesome" to max volume
[22:16:11] <awight>	 OMG, never mind about calling their API to check bank availability.
[22:16:19] <awight>	 "Friesland is in this API but is in the works of being removed from this XML"
[22:16:55] <cwd>	 yeah i laughed at that
[22:17:12] <cwd>	 i picture a sloth backspacing it over the course of many days
[22:17:37] <awight>	 it's as if, "do you have an API" is a common question for the sales department.
[22:17:45] <awight>	 Who was intimately involved in writing the API backend.
[22:17:50] <awight>	 It's actually just that text file.
[22:19:45] <cwd>	 they're putting the humanity back into data requests
[22:19:58] <awight>	 *oinbase style
[22:20:08] <awight>	 here's your report, sir!
[22:20:18] <awight>	 eeexcellent...
[22:21:11] <awight>	 ejegg: just for lulz, I take back part of what I said in the standup, that I didn't see the same overlap between the unupdated_exported* files and CC's report.
[22:21:22] <ejegg>	 oh?
[22:21:23] <awight>	 I was comparing dos and unix newlines...
[22:21:28] <ejegg>	 aargh!
[22:21:28] <awight>	 zero overlap
[22:22:05] <ejegg>	 huh, i'm still stumped
[22:23:01] <awight>	 I have a list of the unaccounted-for records now, my usual process is a plodding bisection, where I run through the export queries and limit them to just a few example records.
[22:23:57] <grrrit-wm>	 (CR) Paladox: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274648 (https://phabricator.wikimedia.org/T124323) (owner: XenoRyet)
[22:27:37] <grrrit-wm>	 (CR) Paladox: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274648 (https://phabricator.wikimedia.org/T124323) (owner: XenoRyet)
[22:27:49] <cwd>	 sorry friends CI is busted
[22:30:29] <ejegg>	 d'oh! guess i'll hold off deploying that thank you page link stuff
[22:32:24] <grrrit-wm>	 (CR) Paladox: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274648 (https://phabricator.wikimedia.org/T124323) (owner: XenoRyet)
[22:36:21] <cwd>	 awight, ejegg if you have any idea about this: https://integration.wikimedia.org/ci/job/mwext-donationinterfacecore125-testextension-zend53/9/console
[22:36:32] <cwd>	 couldn't find usable phpunit...installs phpunit right above
[22:38:41] <awight>	 cwd: You could log into that slave node and poke around...
[22:39:20] <cwd>	 oh yeah i forgot i had login
[22:39:38] <awight>	 almost certainly unrelated, but does this line show up in the 5.5 tests?
[22:39:41] <awight>	 22:32:53 Class ComposerHookHandler is not autoloadable, can not call pre-update-cmd script
[22:40:01] <awight>	 let me downgrade my certainty to "possible unrelated" ;)
[22:40:06] <awight>	 *y
[22:40:31] <awight>	 ejegg: I'm so happy about these non-tempoerary tables!!!
[22:41:00] <ejegg>	 awight: yeah, much less mysterious!
[22:41:52] <awight>	 it's bad enuf that we blow away the export files after 24 hours...
[22:42:01] <awight>	 maybe we should consider gzipping a week's worth.
[22:42:21] <awight>	 it's only 250MB :)
[22:42:26] <awight>	 per day.
[22:44:09] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi Prospect Field - Saving Error - https://phabricator.wikimedia.org/T107087#2086540 (CaitVirtue) Resolved>Open {F3516535}  {F3516536}Reopening, as I think something related is happening again.  SUPER annoying to add a bunch of info and then hav...
[22:45:12] <ejegg>	 yeah, oughtta zip down pretty well
[22:45:59] <ejegg>	 can we point logrotate or something at it?
[22:46:48] <awight>	 I think JG might have some custom stuff, but yeah agreed it should be outside of the application
[22:46:57] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi Prospect Field - Saving Error - https://phabricator.wikimedia.org/T107087#2086556 (awight) @CaitVirtue I'm sorry, but your activity was a bit suspicious.  We can't make exceptions to this rule ;-)
[22:50:40] <ccogdill>	 hey awight
[22:50:44] <ccogdill>	 free now!
[22:52:40] <awight>	 ccogdill: I was trying to hit you up for a copy of the file we exported on Dec 7, but I think I have the info I was looking for.
[22:52:51] <ccogdill>	 oh okay
[22:52:59] <ccogdill>	 sorry I haven’t dug into that yet, I can look at it now!
[22:53:04] <awight>	 ccogdill: I'm also curious about how you generated the list,
[22:53:14] <ccogdill>	 lots to remind myself about… I need to double check
[22:53:19] <ccogdill>	 I haven’t looked at this in awhile
[22:53:25] <awight>	 but that's not a blocker for me, just curiosity.
[22:53:45] <awight>	 I spot-checked that your list is correct at least.
[22:53:51] <ccogdill>	 ah okay awight
[22:54:04] <ccogdill>	 so we pulled a list from Silverpop of people who were not updated the night before
[22:54:04] <awight>	 The duplicated contact IDs in your file tipped me off that something odd had happened, is all.
[22:54:12] <ccogdill>	 that’s a field in our db - last modified date
[22:54:12] <awight>	 cool
[22:54:17] <awight>	 excellent
[22:54:28] <grrrit-wm>	 (CR) Paladox: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274648 (https://phabricator.wikimedia.org/T124323) (owner: XenoRyet)
[22:54:36] <ccogdill>	 anything else specifically I can look at to be helpful with this?
[22:55:11] <awight>	 Thanks, I think I have enough to work with for now!
[22:55:17] <ccogdill>	 okay!
[22:55:28] <awight>	 I'l try not to make another of my epically haphazard changes to the export script.
[22:57:18] <grrrit-wm>	 (CR) Paladox: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274828 (owner: Cdentinger)
[23:03:39] <awight>	 ccogdill: I could use an, um, mysql lesson.  Remind me how to import a file of IDs into a table?
[23:03:50] <ccogdill>	 haha
[23:04:04] <ccogdill>	 you already have the file in your home dir on lutetium?
[23:05:02] <awight>	 let's say I do ;)
[23:05:15] <ccogdill>	 create the table, then 'LOAD DATA LOCAL INFILE '[location/filename]' INTO TABLE [tablename]
[23:05:21] <awight>	 cool!  thank you
[23:05:30] <ccogdill>	 mhm
[23:05:35] <awight>	 We should add that to the Fun with SQL page
[23:05:38] <awight>	 sooo useful.
[23:05:41] <ccogdill>	 yeeeah
[23:05:50] <awight>	 I'll ask you how to export in a few more minutes ;)
[23:05:52] <ccogdill>	 although I had to get permission to be able to create tables
[23:05:56] <ccogdill>	 kk
[23:06:05] <awight>	 huh.  You should have your own database to do anything with.
[23:06:15] <awight>	 which... yeah is not the default
[23:06:56] <ccogdill>	 yeah I have my own cause I asked for it. So it could be on Fun SQL with an asterisk
[23:07:43] <awight>	 hehe "more fun" with SQL
[23:20:58] <wikibugs>	 Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 3 others: Spike: Is it a problem that the Silverpop export is still not updating entire database? - https://phabricator.wikimedia.org/T120880#2086758 (...
[23:24:02] <wikibugs>	 Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 3 others: Spike: Is it a problem that the Silverpop export is still not updating entire database? - https://phabricator.wikimedia.org/T120880#2086772 (...
[23:28:04] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: wmf_contribution_extra records missing for many historical contributions - https://phabricator.wikimedia.org/T128811#2086790 (awight)
[23:29:14] <legoktm>	 cwd: [15:28:59] <grrrit-wm> (PS1) Legoktm: Unbreak composer setup [vendor] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/274841 (https://phabricator.wikimedia.org/T128676)
[23:29:56] <cwd>	 legoktm: thanks!  awight you might want to take a quick look too
[23:30:12] * legoktm spotted a typo in the commit message >.<
[23:30:57] <awight>	 loose apostrophes cause ships to be given away!
[23:31:39] <legoktm>	 test failure is unrelated, sigh
[23:32:31] <cwd>	 Can not find the binary google-chrome
[23:32:50] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi Prospect Field - Saving Error - https://phabricator.wikimedia.org/T107087#1486277 (CaitVirtue) I award @awight a prickly cactus bc I can't come down there and flick his ear for that comment right at the moment.
[23:33:27] <awight>	 trolled!
[23:34:20] <legoktm>	 that's https://gerrit.wikimedia.org/r/#/c/274843/
[23:35:10] <wikibugs>	 Fundraising-Backlog, FR-Adyen: Adyen form for French (France), Ukrainian (Ukraine), & Hebrew (Israel) - https://phabricator.wikimedia.org/T128812#2086811 (atgo)
[23:35:50] <wikibugs>	 Fundraising-Backlog, FR-Adyen: Updates to Adyen form so that it matches Ingenico - https://phabricator.wikimedia.org/T128541#2078310 (atgo)
[23:36:40] <ccogdill>	 awight I guess you figured out that export without my help?
[23:36:48] <ccogdill>	 you did teach me to do it once upon a time, after all
[23:37:21] <awight>	 I didn't even go that far--turns out there were two more explanations for the failure to update
[23:37:45] <awight>	 (mentioned in the task)
[23:38:30] <awight>	 The biggest hole is that we won't pick up any contributions from 2012 or earlier, cos of a silly technicality.
[23:39:42] <awight>	 Another place we were losing people is by design, we're excluding people with no completed contributions, e.g. one refunded oddonation
[23:39:45] <awight>	 aha
[23:39:49] <awight>	 sorry you're way ahead of me
[23:39:54] <legoktm>	 cwd: so want to +2 https://gerrit.wikimedia.org/r/#/c/274841/ ? tests passing now
[23:40:07] <legoktm>	 and then the phpunit tests should magically pass, but based on our luck, I doubt it
[23:40:23] <cwd>	 sure thing
[23:40:25] <cwd>	 heheh
[23:41:41] <wikibugs>	 Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 3 others: Spike: Is it a problem that the Silverpop export is still not updating entire database? - https://phabricator.wikimedia.org/T120880#2086837 (...
[23:42:10] <grrrit-wm>	 (CR) Cdentinger: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274828 (owner: Cdentinger)
[23:42:48] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: wmf_contribution_extra records missing for many historical contributions - https://phabricator.wikimedia.org/T128811#2086842 (awight)
[23:43:25] <legoktm>	 cwd: you're going to have to force merge that patch
[23:43:45] <legoktm>	 the tests are failing because of the weird ways branches work, and Wikibase master obviously doesn't work on 1.25
[23:43:56] <legoktm>	 it can't find a fundraising/REL1_25 branch, so it falls back to master
[23:44:46] <cwd>	 legoktm: looks green here https://gerrit.wikimedia.org/r/#/c/274828/ ...
[23:45:15] <legoktm>	 oh, you already submitted it
[23:45:16] <legoktm>	 I missed that
[23:46:12] <legoktm>	 and https://gerrit.wikimedia.org/r/#/c/274828/ passed!
[23:46:14] <legoktm>	 wooooooo
[23:47:01] <awight>	 wow, thanks for the proton beam!
[23:47:08] <cwd>	 oh wait, but the other change didn't merge??
[23:47:16] <cwd>	 to composer.lock etc?
[23:47:39] <legoktm>	 which change?
[23:48:02] <cwd>	 https://gerrit.wikimedia.org/r/#/c/274841/
[23:48:13] <cwd>	 i see those errors about wikibase
[23:48:25] <cwd>	 but looks like it merged beforehand...
[23:48:33] <grrrit-wm>	 (PS2) Awight: Prepare logos for AstroPay LATAM banks and cards [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274649 (https://phabricator.wikimedia.org/T124320) (owner: XenoRyet)
[23:48:43] <grrrit-wm>	 (CR) Awight: [C: 2] Prepare logos for AstroPay LATAM banks and cards [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274649 (https://phabricator.wikimedia.org/T124320) (owner: XenoRyet)
[23:50:16] <grrrit-wm>	 (Merged) jenkins-bot: Prepare logos for AstroPay LATAM banks and cards [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274649 (https://phabricator.wikimedia.org/T124320) (owner: XenoRyet)
[23:50:22] <legoktm>	 yeah, because you pressed submit
[23:50:53] <legoktm>	 but we're all good now with the DonationInterface tests?
[23:51:14] <cwd>	 legoktm: yep looks fine on that end
[23:51:24] <legoktm>	 awesome
[23:53:38] <cwd>	 legoktm: thanks again!
[23:54:02] <legoktm>	 :)
[23:57:10] <grrrit-wm>	 (PS1) Krinkle: build: Bump various devDependencies [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/274847
[23:57:25] <grrrit-wm>	 (CR) Krinkle: "Backport for CI." [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/274847 (owner: Krinkle)
[23:58:23] <wikibugs>	 Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 3 others: Spike: Is it a problem that the Silverpop export is still not updating entire database? - https://phabricator.wikimedia.org/T120880#2086914 (...