[00:04:03] (PS2) Cdentinger: Fix one currency selector edge case [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/275023 (owner: Ejegg) [00:04:10] (CR) Cdentinger: [C: 2] Fix one currency selector edge case [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/275023 (owner: Ejegg) [00:17:12] (PS3) Cdentinger: Fix bug so we use invalid amount error [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276014 (https://phabricator.wikimedia.org/T129277) (owner: Ejegg) [00:17:22] (CR) Cdentinger: [C: 2] Fix bug so we use invalid amount error [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276014 (https://phabricator.wikimedia.org/T129277) (owner: Ejegg) [00:22:50] (Merged) jenkins-bot: Fix one currency selector edge case [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/275023 (owner: Ejegg) [00:23:05] (PS4) Cdentinger: Fix bug so we use invalid amount error [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276014 (https://phabricator.wikimedia.org/T129277) (owner: Ejegg) [00:25:02] thanks for the CR cwd [00:25:13] that deploy looks pretty solid [00:25:18] good stuff [00:25:28] think i'm gonna head out for the night [00:25:34] cya! [00:26:45] later! [00:33:36] (CR) Cdentinger: Fix bug so we use invalid amount error [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276014 (https://phabricator.wikimedia.org/T129277) (owner: Ejegg) [00:33:44] (CR) Cdentinger: [C: 2] Fix bug so we use invalid amount error [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276014 (https://phabricator.wikimedia.org/T129277) (owner: Ejegg) [00:36:03] (Merged) jenkins-bot: Fix bug so we use invalid amount error [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276014 (https://phabricator.wikimedia.org/T129277) (owner: Ejegg) [00:44:00] I'm going to run too. Let's keep talking WP tomorrow [01:01:19] (PS3) Cdentinger: Show an invalid amount message on missing currency [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276017 (https://phabricator.wikimedia.org/T129277) (owner: Ejegg) [09:04:52] (CR) Paladox: "recheck" [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/266032 (https://phabricator.wikimedia.org/T87917) (owner: MtDu) [09:05:59] (PS3) Paladox: Convert FundraiserLandingPage to use extension registration [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/266032 (https://phabricator.wikimedia.org/T87917) (owner: MtDu) [09:06:29] (CR) Paladox: "You missed ; at the end of $wgExtensionMessagesFiles['FundraiserLandingPageMagic'] = __DIR__ . '/FundraiserLandingPage.i18n.magic.php'" [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/266032 (https://phabricator.wikimedia.org/T87917) (owner: MtDu) [09:08:47] (PS4) Paladox: Convert FundraiserLandingPage to use extension registration [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/266032 (https://phabricator.wikimedia.org/T87917) (owner: MtDu) [09:11:14] (PS5) Paladox: Convert FundraiserLandingPage to use extension registration [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/266032 (https://phabricator.wikimedia.org/T87917) (owner: MtDu) [09:11:42] (CR) Paladox: "Add missing alias file to extension.json and the main php file." [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/266032 (https://phabricator.wikimedia.org/T87917) (owner: MtDu) [09:14:04] (CR) Paladox: [C: 1] "Havent tested but looks good." [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/266032 (https://phabricator.wikimedia.org/T87917) (owner: MtDu) [09:15:09] (PS1) Paladox: Add npm entry point [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/276116 [09:15:33] (CR) Paladox: "check experimental" [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/276116 (owner: Paladox) [09:25:57] (CR) Paladox: "recheck" [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/261445 (owner: Legoktm) [11:48:26] (CR) Aklapper: "@Awight: This patch which adds two lines of comments has been sitting here for six months. Any decision (-1, +1, +2, abandon?) in order to" [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/216854 (owner: Awight) [14:41:41] (PS1) Ejegg: Add UYU currency to AstroPay adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276166 (https://phabricator.wikimedia.org/T124323) [14:41:43] (PS1) Ejegg: Add PSE bank trasfer to AstroPay adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276167 (https://phabricator.wikimedia.org/T124323) [14:41:45] (PS1) Ejegg: Add form settings for new AstroPay methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276168 (https://phabricator.wikimedia.org/T124323) [14:42:36] (PS2) Ejegg: Add UYU currency to AstroPay adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276166 (https://phabricator.wikimedia.org/T124323) [14:43:00] (PS2) Ejegg: Add PSE bank trasfer to AstroPay adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276167 (https://phabricator.wikimedia.org/T124323) [14:43:27] (PS2) Ejegg: Add form settings for new AstroPay methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276168 (https://phabricator.wikimedia.org/T124323) [14:55:33] (PS1) Ejegg: Fix some Mustache CSS for narrow screens [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276173 (https://phabricator.wikimedia.org/T124320) [15:00:39] (PS2) WMDE-leszek: Update device "selector logic" URL [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/264938 (https://phabricator.wikimedia.org/T129354) [15:25:40] (PS3) Cdentinger: Fixmes [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/216854 (owner: Awight) [15:25:54] (CR) Cdentinger: [C: 2] Fixmes [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/216854 (owner: Awight) [15:26:48] (Merged) jenkins-bot: Fixmes [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/216854 (owner: Awight) [15:44:10] (CR) Aklapper: "@Awight: Could this trivial patch get a decision (-1, +1, +2, abandon?) please? This has been sitting here for six months... Thanks!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/95739 (owner: Awight) [15:48:01] (PS4) Cdentinger: fix comment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/95739 (owner: Awight) [15:48:07] (CR) Cdentinger: [C: 2] fix comment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/95739 (owner: Awight) [15:50:54] (Merged) jenkins-bot: fix comment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/95739 (owner: Awight) [16:16:45] (PS1) Ejegg: Fix BBVA Bancomer bank code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276194 (https://phabricator.wikimedia.org/T124323) [16:17:34] (CR) Cdentinger: Show an invalid amount message on missing currency (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276017 (https://phabricator.wikimedia.org/T129277) (owner: Ejegg) [16:31:09] ejegg: running without that patch ^ and using country=UA i actually got OutOfBoundsException [16:31:17] is that what you got too? [16:33:25] actually i still get it with that patch applied [16:34:31] cwd yeah, I should fail less drastically! [16:34:38] you want country=UY [16:37:11] oh i see [16:37:13] 276166 [16:39:56] hmm, why is that not getting caught in GatewayPage (line 87)? [16:41:06] hmmm [16:41:09] ah, it's in the constructor... [16:41:20] dang overweight constructors... [16:43:12] yeah DI needs a lot of massaging [16:52:11] hmm, would be easier to show a nice fail page on constructor error if we merged this one: https://gerrit.wikimedia.org/r/274565 [16:52:21] cwd what do you think of that ^^ ? [16:53:05] oops, did I not check in the resultPages class? [16:53:13] argh, and I probably nuked it locally... [16:54:09] doh [16:54:11] reflog? [16:54:40] never checked it in :( and I've done at least 1 reset --hard [16:54:53] dang [16:54:55] been there [16:56:30] wait, how are any of those tests passing without it? [16:57:16] (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274565 (owner: Ejegg) [17:01:14] cwd ok, gerrit is just dumb and not showing the class in the UI [17:01:33] * ejegg loses lasts shred of confidence in our code review platform [17:02:44] oh weird... [17:02:45] * ejegg recants accusations, realizes that he actually screwed up and added that class to the previous commit [17:02:54] ah ha! [17:02:58] well we should still kill gerrit [17:05:05] (PS2) Ejegg: Fix undefined variable in logging [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274544 [17:06:26] (PS4) Ejegg: Move getBlahPage methods out of gateway class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274565 [17:08:29] so yeah, with ^^ we could call ResultPages::getFailPage with a generic/dummy adapter if constructing the real thing fails [17:09:37] cool, checking that out [17:14:07] ejegg: was 274544 a manual rebase? [17:14:45] cwd rebased, and removing the ResultPages class [17:15:01] aah word [17:15:32] (CR) Ejegg: "Rebased, and moved ResultPages class into this commit" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274565 (owner: Ejegg) [17:39:42] should we be worried about the email "Fail Mail: BAD_AUDIT_LINE (paypal-audit)" [17:40:42] (CR) Cdentinger: [C: 2] "Good idea, and parent adapter shrinks a little" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274565 (owner: Ejegg) [17:41:44] I just got a second email on that thread [17:42:06] dstrine: looking [17:43:15] (Merged) jenkins-bot: Move getBlahPage methods out of gateway class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274565 (owner: Ejegg) [17:43:48] dstring hmm, that may be a new paypal audit failure mode... [17:44:31] saw that yesterday, meant to look, got distracted [17:47:15] do you think this has any affect on donors? [17:48:37] if a butterfly flaps its wings in peking in central park you get rain instead of sunshine [17:48:57] but no i think this is an audit parser thing so probably no direct effect [17:50:39] Fundraising-Backlog: Deploy Thank you letters to remove Lila's signature - https://phabricator.wikimedia.org/T129373#2103778 (jrobell) [17:56:09] (PS1) Ejegg: Enable fail page without adapter instance [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276218 (https://phabricator.wikimedia.org/T129376) [17:56:28] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Catch exceptions in adapter constructor - https://phabricator.wikimedia.org/T129376#2103812 (Ejegg) [18:00:27] cwd: should I make an investigation task? [18:01:29] dstrine: sure! that'd be good. looks like a new thing [18:01:52] Fundraising-Backlog: Investigate: Fail Mail: BAD_AUDIT_LINE (paypal-audit) - https://phabricator.wikimedia.org/T129379#2103847 (DStrine) [18:12:03] (PS1) Ejegg: WIP catch errors in adapter constructors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276222 (https://phabricator.wikimedia.org/T129376) [18:13:56] (CR) jenkins-bot: [V: -1] WIP catch errors in adapter constructors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276222 (https://phabricator.wikimedia.org/T129376) (owner: Ejegg) [18:18:19] (PS2) Ejegg: Catch errors in adapter constructors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276222 (https://phabricator.wikimedia.org/T129376) [18:19:54] (CR) jenkins-bot: [V: -1] Catch errors in adapter constructors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276222 (https://phabricator.wikimedia.org/T129376) (owner: Ejegg) [18:20:25] cwd, want to take over for me at Scrum of Scrums? [18:20:45] I've been copy-pasting the same basic stuff for the last few weeks [18:21:00] ejegg: sure i can do that. is it in 10m? [18:21:03] sorry for last-minute ask! [18:21:09] no worries! [18:21:23] you're awesome, thanks! [18:21:28] oh, let me send the new links [18:21:37] We just switched to bluejeans [18:22:24] right on [18:30:47] (PS3) Ejegg: Catch errors in adapter constructors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276222 (https://phabricator.wikimedia.org/T129376) [18:31:55] (CR) jenkins-bot: [V: -1] Catch errors in adapter constructors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276222 (https://phabricator.wikimedia.org/T129376) (owner: Ejegg) [18:32:36] (PS4) Ejegg: Catch errors in adapter constructors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276222 (https://phabricator.wikimedia.org/T129376) [18:32:51] Fundraising-Backlog: Expand access to the table that holds failed payment data - https://phabricator.wikimedia.org/T129261#2104024 (MBeat33) Sorry all for being unclear in the wording of the request. We'd like to get the email addresses for a batch of transactions. The errors began 3/8/2016 8:46:00 AM (Inge... [18:34:18] (CR) jenkins-bot: [V: -1] Catch errors in adapter constructors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276222 (https://phabricator.wikimedia.org/T129376) (owner: Ejegg) [18:37:24] (PS5) Ejegg: Catch errors in adapter constructors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276222 (https://phabricator.wikimedia.org/T129376) [18:42:14] woot, that works ^^ [18:47:23] Fundraising-Backlog, FR-Smashpig: Create PhpQueueDataStore compatible with StompDataStore - https://phabricator.wikimedia.org/T129386#2104049 (Ejegg) [18:48:57] Fundraising-Backlog, FR-Smashpig: Create PhpQueueDataStore compatible with StompDataStore - https://phabricator.wikimedia.org/T129386#2104064 (Ejegg) [18:48:59] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, MediaWiki-extensions-DonationInterface: [Epic] SPOF: Replace ActiveMQ donation queues with Redis - https://phabricator.wikimedia.org/T108229#2104063 (Ejegg) [18:49:57] Fundraising-Backlog, FR-Smashpig: Create PhpQueueDataStore compatible with StompDataStore - https://phabricator.wikimedia.org/T129386#2104049 (Ejegg) [18:49:59] Fundraising-Backlog, FR-Smashpig, Technical-Debt: SmashPig should mock queues for tests - https://phabricator.wikimedia.org/T127880#2104069 (Ejegg) [19:03:40] (PS1) Ejegg: Add more credit cards (for Chile) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/276237 (https://phabricator.wikimedia.org/T124323) [19:04:08] OK, I'm outta here. Have a good one folks! [19:09:21] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, Patch-For-Review: Catch exceptions in adapter constructor - https://phabricator.wikimedia.org/T129376#2104162 (Ejegg) [19:18:10] (CR) XenoRyet: [C: 2] Add UYU currency to AstroPay adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276166 (https://phabricator.wikimedia.org/T124323) (owner: Ejegg) [19:26:19] (CR) XenoRyet: [C: 2] Add PSE bank trasfer to AstroPay adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276167 (https://phabricator.wikimedia.org/T124323) (owner: Ejegg) [19:32:11] (Merged) jenkins-bot: Add UYU currency to AstroPay adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276166 (https://phabricator.wikimedia.org/T124323) (owner: Ejegg) [19:32:14] (Merged) jenkins-bot: Add PSE bank trasfer to AstroPay adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276167 (https://phabricator.wikimedia.org/T124323) (owner: Ejegg) [20:56:01] dstrine: Making lunch for the kid real fast, might be a minute or two late to standup. Just FYI [20:59:06] kk I'm going to have to run after the first 5 minutes ... moight be kind of a light standup [20:59:08] *might [21:03:54] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: CentralNotice: DB timeouts when enabling more than one campaign at once from Special:CentraNotice - https://phabricator.wikimedia.org/T128869#2104652 (AndyRussG) [[ https:/... [21:05:52] dstrine: also there in 1 min or so... [21:12:50] (CR) Cdentinger: Enable fail page without adapter instance (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276218 (https://phabricator.wikimedia.org/T129376) (owner: Ejegg) [21:33:27] https://lists.cypherpunks.ca/pipermail/otr-announce/2016-March/000062.html [21:46:26] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: multiple errors when cancelling recurring Ingenico donations, and with refunds reaching Civi - https://phabricator.wikimedia.org/T128389#2104778 (MBeat33) For CIDs 10015244 12361150 11366703 refer... [21:48:33] (CR) XenoRyet: [C: 2] Fix some Mustache CSS for narrow screens [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276173 (https://phabricator.wikimedia.org/T124320) (owner: Ejegg) [21:53:40] (Merged) jenkins-bot: Fix some Mustache CSS for narrow screens [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276173 (https://phabricator.wikimedia.org/T124320) (owner: Ejegg) [21:54:58] Fundraising-Backlog, FR-Worldpay: Worldpay refunds not reaching Civi - https://phabricator.wikimedia.org/T129265#2100102 (cwdent) I see a bunch of files named WPG_AUDIT_YYYYMMDDhhmm.txt (instead of .csv) in /completed up until 2015/12/9, according to the regex they would have been processed: ^WPG_AUDIT_\d... [21:58:27] (CR) XenoRyet: [C: 2] Fix BBVA Bancomer bank code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276194 (https://phabricator.wikimedia.org/T124323) (owner: Ejegg) [22:00:14] (Merged) jenkins-bot: Fix BBVA Bancomer bank code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276194 (https://phabricator.wikimedia.org/T124323) (owner: Ejegg) [22:36:59] Fundraising-Backlog, FR-Worldpay: Worldpay refunds not reaching Civi - https://phabricator.wikimedia.org/T129265#2104999 (cwdent) I turned up these couple: WPG_AUDIT_201512071000.txt:30555280.0 <-- canceled WPG_AUDIT_201512021000.txt:28710673.0 <-- charged back WPG_AUDIT_201512021000.txt:29139090.0 <-- c... [22:54:52] MBeat, ppena -- ^^ [22:55:05] there are definitely several things wrong with the WP audit situation [22:55:10] cwd: hi [22:55:13] ty cwd [22:55:13] not least of which we haven't gotten files in a long time [22:55:30] but i did find 3 of those in the "completed" dir that somehow weren't processed [22:56:38] MBeat: in your estimation are the ones listed in the ticket probably the "tip of the iceberg" ? [22:56:52] most likely, cwd [22:57:05] unknown unknowns [22:57:17] i wonder if there's a way to find out [22:57:44] problems w/multiple causes…we could spot check a bunch more transaction IDs [22:58:09] but we didn;t find a bunch that were in Civi and send you the exceptions [22:58:18] these were right off the bat [22:58:52] sheesh [23:00:07] i guess if we could get them to deliver all the audit files since december we could script something to compare the last status against what's in civi [23:00:38] ostensibly that's what the audit parser already does [23:00:43] gotta hop off (middle school band concert yay!) but let me know if you want me to poke into any transactions, cwd [23:01:12] thanks MBeat ! [23:01:15] enjoy the show [23:01:29] will do - really good music teacher, actually [23:02:47] ppena: do you know who we're supposed to email at WP these days? [23:03:42] cwd: Sascha.Vrolijk@worldpay.com and Matt.Kaefer@worldpay.com [23:04:23] thanks! [23:05:52] cwd: are you suggesting that we get a huge audit file of the missing data ... run it ...and try to backfil? [23:06:25] dstrine: well that's what the audit parser should be doing anyway [23:06:33] we just haven't gotten any files since early Dec [23:06:51] but there are signs that the audit parser is broken too [23:06:52] I would hope they keep that kind of data around or they can recreate it [23:07:00] which likely means they quietly changed the format [23:07:09] re parser broken YAY :( [23:08:11] * dstrine would like to be really snarky and sarcastic about the history of quiet WP changes [23:08:33] this is the price of doing business with worldpay [23:08:55] .... [23:10:54] we should really try to replace with adyen [23:11:49] https://www.youtube.com/watch?v=Ra0cb11c9Cc [23:14:46] is that worldpay? not invited to the party? [23:17:25] heh, sure [23:22:54] well i emailed em, contact is OOO, symptoms are non-specific, not feeling optimistic about a quick resolution [23:23:48] thanks cwd [23:24:57] like elliott said we are getting some weird csv files filled with irrelevant data [23:25:36] anyhoo [23:41:20] gotta run, will check back later