[00:06:18] (Merged) jenkins-bot: Don't leave queue message dangling [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/276538 (owner: Ejegg) [00:09:09] AndyRussG: the answer is awesomely complicated [00:12:29] Fundraising-Backlog, Wikimedia-Fundraising: "Renew your donation: 0 kr" - https://phabricator.wikimedia.org/T127059#2110257 (CCogdill_WMF) Open>Resolved a:CCogdill_WMF This was resolved as noted in T125778. [00:12:33] the trail starts here https://wikitech.wikimedia.org/wiki/Heterogeneous_deployment#mediawiki-staging.2Fmultiversion [00:12:39] cwd: hahah I can imagine [00:12:56] but probably relinking the extensions dir is the sanest thing for now [00:12:58] wow great to hear u've deciphered it :) [00:14:41] AndyRussG: haha well i wouldn't go that far...probably do some reading on the topic later tho [00:14:59] now i must go get my dog. later! [00:15:03] cwd: have fun! [00:50:31] (PS1) Ejegg: Remove fiscal number validation for PE and MX [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276675 (https://phabricator.wikimedia.org/T129552) [01:36:22] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: MessageUtils::messageExists is busted - https://phabricator.wikimedia.org/T129612#2110720 (Ejegg) [01:36:45] (PS1) Ejegg: Actually fix messageExists test [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276681 (https://phabricator.wikimedia.org/T129612) [01:48:06] (CR) XenoRyet: [C: 2] Remove fiscal number validation for PE and MX [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276675 (https://phabricator.wikimedia.org/T129552) (owner: Ejegg) [01:49:34] (Merged) jenkins-bot: Remove fiscal number validation for PE and MX [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276675 (https://phabricator.wikimedia.org/T129552) (owner: Ejegg) [01:51:37] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Unplanned-Sprint-Work, FR-Astropay, Patch-For-Review: Remove fiscal number for Mexico form - https://phabricator.wikimedia.org/T129552#2110764 (Ejegg) Resolved>Open [01:54:43] thanks XenoRyet! If you or cwd wants to look at https://gerrit.wikimedia.org/r/276681 , that would improve error messages especially for the fiscal numbers on the AstroPay forms [01:55:32] I've gotta tap out for the evening, but if cwd doesn't get to it, I'll take a look in the morning. [01:56:18] thanks! [01:56:27] !log updated SmashPig from 154688db3595060b55498dea3cdf1ee206a854a0 to ad27a3a18cccd6bbd843e671218a1f5c190bdb8a [01:56:31] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [02:08:27] (CR) XenoRyet: [C: 2] Actually fix messageExists test [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276681 (https://phabricator.wikimedia.org/T129612) (owner: Ejegg) [02:09:12] Heh, curiosity got the better of me, and turns out I didn't need to leave so soon anyway. ;-) [02:09:51] (Merged) jenkins-bot: Actually fix messageExists test [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276681 (https://phabricator.wikimedia.org/T129612) (owner: Ejegg) [02:11:38] rockin, that function had been bothering me for a year! [02:16:13] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: [epic] Make deduping reversible - https://phabricator.wikimedia.org/T111704#2110819 (Eileenmcnaughton) Logging is now on & functional on staging. I tinkered around somewhat and was able to successfully merge and un-merge my mother. I have been trackin... [02:38:38] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: [epic] Make deduping reversible - https://phabricator.wikimedia.org/T111704#2110854 (Eileenmcnaughton) Here are a couple of screen shots showing Kermit Trump's change log after I merged Kermit Frog into him & the report of minor changes from the change... [02:39:15] (PS1) Ejegg: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/276686 [02:56:49] (CR) Ejegg: [C: 2 V: 2] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/276686 (owner: Ejegg) [02:58:14] wat? "Kermit Trump's change log after I merged Kermit Frog" [02:58:23] (PS1) Ejegg: Update DonationInterface submethod [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/276690 [02:58:38] (CR) Ejegg: [C: 2 V: 2] Update DonationInterface submethod [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/276690 (owner: Ejegg) [03:00:41] !log updated payments-wiki from 7248c10613018c1a15a1754ab80242f79d04532f to 79f5c9389edd089ae5951a7d172e74e68946a93c [03:00:46] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [04:03:54] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: CentralNotice: DB timeouts when enabling more than one campaign at once from Special:CentraNotice - https://phabricator.wikimedia.org/T128869#2111023 (AndyRussG) As per @jc... [04:07:14] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: CentralNotice: DB timeouts when enabling more than one campaign at once from Special:CentraNotice - https://phabricator.wikimedia.org/T128869#2111038 (AndyRussG) @atgo, @DS... [04:48:37] Fundraising-Backlog: Apply machine learning to fraud detection - https://phabricator.wikimedia.org/T129628#2111070 (Ejegg) [05:45:36] Fundraising-Backlog, FR-Astropay: [epic] Processing via Astropay for Spanish-speaking LATAM countries - https://phabricator.wikimedia.org/T102143#2111095 (Ejegg) [05:45:38] Fundraising Sprint Dirt Farming, Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 4 others: Prepare logos for AstroPay LATAM banks and cards - https://phabricator.wikimedia.org/T124320#2111094 (Ejegg) Open>Resolved [05:46:03] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, Patch-For-Review: MessageUtils::messageExists is busted - https://phabricator.wikimedia.org/T129612#2110720 (Ejegg) Open>Resolved [05:47:02] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Unplanned-Sprint-Work, FR-Adyen, FR-Smashpig: Adyen job runner failing at pending queue - https://phabricator.wikimedia.org/T129547#2108778 (Ejegg) Open>Resolved [05:47:32] Fundraising-Backlog, FR-Astropay: [epic] Processing via Astropay for Spanish-speaking LATAM countries - https://phabricator.wikimedia.org/T102143#1357295 (Ejegg) [05:47:33] Fundraising Sprint Dirt Farming, Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 5 others: Update payment methods and submethods for AstroPay LATAM rollout - https://phabricator.wikimedia.org/T124323#1952834 (Ejegg) Open>Resolved [06:17:52] (CR) Ejegg: "heh, just noticed my fingers autocompleted the wrong subm...." [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/276690 (owner: Ejegg) [07:03:10] (CR) Siebrand: [C: -1] "i18n/L10n reviewed. It's better to move the URL to a separate message that is them marked as {{notranslate}}, or add the URL from the code" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/264938 (https://phabricator.wikimedia.org/T129354) (owner: WMDE-leszek) [13:34:34] (CR) Gilles: "I presume this was left untouched because the big fundraiser was happening then. Can someone from fr-tech take a look now? This looks stra" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/254326 (https://phabricator.wikimedia.org/T111456) (owner: Krinkle) [16:01:26] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Unplanned-Sprint-Work: Update Square Cash import for changed column names and additional info - https://phabricator.wikimedia.org/T129174#2111945 (atgo) Here's the summary of changes I sent over to our contact at Square. He owes me a r... [16:02:25] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Unplanned-Sprint-Work: Update Square Cash import for changed column names and additional info - https://phabricator.wikimedia.org/T129174#2111946 (atgo) [16:03:14] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Unplanned-Sprint-Work: Update Square Cash import for changed column names and additional info - https://phabricator.wikimedia.org/T129174#2097192 (atgo) "Account" I believe includes the "Instrument Type" piece, but I'm following up to... [16:43:27] AndyRussG: do you know what this does? https://gerrit.wikimedia.org/r/275362 [16:43:58] ejegg: ah no! I was looking at that yesterday [16:44:08] Probably.... something important... ;) [16:44:35] heh, maybe! [16:48:07] Also https://phabricator.wikimedia.org/T128869 is getting interesting, I think [16:48:17] I'm gonna start coding up an optimization... [16:49:47] hmm, looks like doesWrites only matters to the profiler [16:49:50] if ( $context->getRequest()->wasPosted() && !$page->doesWrites() ) { [16:49:53] $trxProfiler->setExpectations( $trxLimits['POST-nonwrite'], __METHOD__ ); [16:49:56] } [17:01:08] Hummm [17:01:14] ejegg: and whatdoes the profiler do? [17:03:07] AndyRussG: I assume it's just a measurement instrument, but I could be wrong [17:12:20] Hmmm should find out... [17:46:35] (CR) AndyRussG: "Sure! I'll check it out in the next couple days, thanks 4 the ping :)" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/254326 (https://phabricator.wikimedia.org/T111456) (owner: Krinkle) [17:52:31] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work: CentralNotice: DB timeouts when enabling more than one campaign at once from Special:CentraNotice - https://phabricator.wikimedia.org/T128869#2112209 (AndyRussG) >>! In T12... [18:12:00] ejegg: Did you all know about the breaking the wikis thing? [18:12:06] the-wub: ^^ you too. [18:12:22] K4-713: what? [18:12:30] eek [18:12:32] I think I assumed it had come up in SoS, and the potential awareness campaign they wanted to run about it. [18:12:50] K4-713: I was vaguely aware. they're only going into read-only mode right? (hopefully) [18:12:53] ejegg: This is the 30 minute thing on the 21st of March. [18:12:54] oh shoot, bet I need to read an email [18:13:13] the-wub: Yes. :) [18:13:25] This probably impacts you more than us. [18:13:30] ah, there's that email [18:13:33] wat? [18:13:40] K4-713: If they want to run some notices, I'm fine to have them override fundraising ones. will bring it up with Jessica at our checkin on Monday [18:13:42] [QUICK] Ops is going to break the wikis soon [18:13:52] the-wub: They may have abandoned that idea. [18:14:13] I still think it's probably a good one, though, because it will tell people that the wikis are, you know... generally editable. :p [18:14:14] Ahhh huh OK not right away [18:14:34] Maybe a board decision to move away from that? (jk) [18:14:40] "We are breaking this thing that a ton of readers have still (bafflingly) not noticed is an option in the first place" [18:15:12] Hahah this morning I talked to two more rooms full of kids about the edit button. Then I let them loose on test.wikipedia.org [18:15:27] (parents' talk-about-their-jobs day at school) [18:16:09] ejegg: hi! I have to run in a minute, but I was wondering if you have any ideas about refactoring for https://phabricator.wikimedia.org/T128869... If so I'd love to hear 'em [18:16:45] AndyRussG: I definitely want to investigate that! Will take a look in a little bit [18:16:51] For example, I'm trying to decide how much to refactor client side (detect changes the user makes in JS and only send those?) vs how much to do server-side [18:16:55] ejegg: amazing, thx! [18:17:00] we do have a general maintenance notice in CN, and it's translated into a bazillion languages already. they could use that. https://en.wikipedia.org/?banner=Genericmaintenancenotice&force=1 [18:17:01] K back in about 2 hrs :) [18:18:46] K4-713: While we're on the topic: I assume this switchover process won't affect fundraising systems at all? [18:19:22] the-wub: The frack boxes are all insulated. It's meta and donate wiki we have to worry about. [18:19:29] Which is basically your problem. :) [18:20:07] yay :P [18:20:20] ooh, it really was writing to every row, even the archived ones. gross [18:20:24] the-wub: Worst case scenario, I think, is having to make emergency campaign changes during the read-only times. [18:20:34] So... maybe we just take things down. [18:21:00] ccogdill: You should probably get in on this too. [18:21:08] Let me catch you up real quick. [18:21:10] K4-713: yeah, that's a thing I'm worried about too [18:21:51] On March 21, the wikis are going into read-only mode for a couple short (15-30 minutes each) bursts. [18:22:55] ccogdill: What's your email campaign schedule like leading up to the 21st? [18:23:15] wait, isn't March 21st the day we've all just been ordered not to check email? that's not gonna work... [18:23:22] we’re pretty consistently sending a lot of email every thursday [18:23:27] not that I ever expected it to [18:23:27] definitely not mondays [18:23:38] Yeah, that's why IRC exploded. Some people are going to shift that day off. [18:23:53] ccogdill: What's the tail look like on those campaigns? [18:24:06] the first 48 hours are most important [18:24:11] Rad. [18:24:18] but really a week would be my preference [18:24:24] we have data trickling a month after a send [18:24:50] So, we probably wouldn't notice anything going amiss on the 21st. The only issue would be if we had to adjust the available methods on donate wiki in some kind of emergency situation. [18:25:00] Like... a payment processor falling over. [18:25:15] okay, I’m sure it’ll be fine [18:25:17] So, it seems pretty low-risk for what you're up to. :) [18:25:18] we’re sending in CEST right now, so if it’s done during PST work hours it shouldn’t be a big deal for these campaigns [18:25:27] yep [18:25:33] Great! [18:25:58] the-wub: Do you want to talk to Jessica about the campaign those days? [18:26:10] I'm assuming you have more luck catching her... awake. :) [18:26:34] yes, I'll talk to Jessica. thanks for the info K4-713! [18:26:54] thanks for checking K4! [18:27:15] Totally. I'll email fr-all sometime today, too. [18:27:25] But we should also go for the personal touch. [18:27:58] all the more reason to get https://phabricator.wikimedia.org/T128869 fixed too :) [18:28:12] is it actually the 21st or just the week of the 21st? [18:28:19] The actual 21st. [18:28:46] that email just said "15 to 30 minutes twice during the week of 21 March" [18:28:56] but i have no other info [18:29:02] There are a lot more emails... somewhere. I think. [18:29:09] Maybe the official announce has yet to go out. [18:29:24] That would explain why I've only seen it talked about in IRC and in person. [18:29:55] But, I think there was some kind of mental arm-wrestling contest to set the date, so it seems unlikely to change. [18:30:09] there was an email to wmfall "MediaWiki switchover to Dallas backup data center, week of March 21st and deployment freeze" [18:30:21] * K4-713 sighs [18:30:21] that said actual switchover would be March 22nd [18:30:55] That title says a lot of things, but "feature downtime" isn't one of them. [18:31:06] heh [18:38:53] In totally other news: OH MY GOODNESS: https://www.patreon.com/MariachiEntertainmentSystem?ty=h [18:42:14] awesome [18:44:11] haha, that is great! [18:44:55] I also really like Mexrrissey: https://soundcloud.com/mexrrissey [18:45:15] :D [20:10:37] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog: Deploy Thank you letters to remove Lila's signature - https://phabricator.wikimedia.org/T129373#2103736 (Ejegg) a:Ejegg [20:13:14] (PS1) Ejegg: Thank You letters for executive director transition [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/276808 (https://phabricator.wikimedia.org/T129373) [20:21:06] (PS2) Ejegg: Thank You letters for executive director transition [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/276808 (https://phabricator.wikimedia.org/T129373) [20:25:01] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Patch-For-Review: Deploy Thank you letters to remove Lila's signature - https://phabricator.wikimedia.org/T129373#2112996 (Ejegg) These are up for code review. Most are just the signature change and one or two typo or phrasing fixes,... [20:51:06] (PS1) Ejegg: CRM-18112 - Additional permission for editing "api_key" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/276828 [21:04:14] will be at standup in 2 min [22:19:06] ejegg: cwd: any thoughts on fixing CN database crap? [22:19:23] (and that term is an understatement) [22:20:03] lemme look at that ticket again [22:20:55] The server-side stuff starts here: https://github.com/wikimedia/mediawiki-extensions-CentralNotice/blob/eadd244a7810a35fd0c9706d3e100a75bb970202/special/SpecialCentralNotice.php#L123 [22:21:15] cwd: for ur convenience and reading enjoyment, https://phabricator.wikimedia.org/T128869 [22:21:21] ty! [22:24:22] AndyRussG: just back from my own SQL spelunking trip, will take a look at that CN stuff now! [22:24:30] ejegg: cwd: basically the form sends data for the whole list whenever you post [22:24:49] (including the thousands of hidden entries!) [22:24:54] yep [22:24:58] AndyRussG: yeah i remember dealing with this exact same thing before [22:25:04] And then server-side we just blindly write every value for every row, cell by cell [22:25:05] well really similar anyway [22:25:25] what about just writing some javascript to only send the things that have actually changed? [22:25:38] Yeah I'm thinking that's the best approach [22:25:45] leave the server code out of it [22:25:55] Mmmm yeah [22:26:06] (or well, mostly... some server-side stuff would change) [22:26:25] Yeah my firstidea was on the server, check what has changed and only write what has [22:26:43] But yeah the earlier we can stem a flood of useless data, the better, I guess [22:26:53] thx guys! [22:27:23] yeah i don't see anything wrong with what the server side is doing -- update everything the frontend tells you to update [22:27:53] imo the real problem here is html forms [22:28:07] checkboxes never worked how i want them to [22:31:54] Fundraising-Backlog, FR-Smashpig: Create local git repo for SmashPig config - https://phabricator.wikimedia.org/T129706#2113434 (Ejegg) [22:35:39] Hmm [22:38:05] AndyRussG: or what about a button on each row that enables/disables that single one? [22:38:24] Hmmm [22:38:51] Dunno, do we want to remove the functionality of being able to update a bunch (not usually hundreds, but maybe 10-20) at once? [22:40:45] cwd: mmm the server-side is bad in itself. It starts with a list of all campaigns, and diffs the array between those that are on or off, and runs through both subsets [22:44:14] heh yeah that's not the greatest procedure [22:46:26] AndyRussG: would a quick fix be to just stop rendering the archived hidden ones? [22:46:31] or is there a reason to do that? [22:50:51] Yeah on the bug report itself is an attempt at un-archiving, so you need to be able to see the archived ones if u want [22:55:00] AndyRussG: yeah...that's tough [22:55:53] from my very limited perspective it seems like an onclick on the checkboxes that accumulates a list of stuff to send would be the easiest solution [22:56:04] Yeah [22:56:27] Just send a list of campaigns that were directly modified by the user one way or another, and only work on those [22:57:01] there is the idea that it's not fully resetting state to be in sync with the UI, but that's sort of the case anyway, someone else could be editing the page in the background [22:57:30] so unless you want to push updates to the list with some ajaxy abomination i don't think it's any less correct than what's happening now [22:58:42] gah... I'd say put archive campaigns in a whole different tab, with paging [22:59:15] would that actually be the easiest fix? [22:59:22] that occurred to me also...un-archiving could be a separate action [23:02:43] another thing that occurs to me, all the updates are wrapped in a transaction? is there a reason for that? [23:03:11] d'oh, adyen audit parser failure [23:03:42] ah, just an unknown audit line type [23:04:08] cwd: no, actually it's a million different write queries. Though I don't know how that translates to the concept of "transaction" on the db side [23:04:17] May be just one commit for the whole request [23:04:58] it seems like it must be [23:05:10] why aren't they super slow to disable? [23:05:27] sorry i should actually read the thread :P [23:07:37] WP audit does not appear to have found any new txns [23:12:46] (PS1) Ejegg: Treat 'Type' values case-insensitively [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/276911 [23:12:49] cwd did it download any new files? [23:13:01] also, want to take a look at ^^ if you have a minute? [23:13:17] sure [23:13:23] ah, oops [23:13:25] yeah a bunch of new files [23:13:38] one thing to fix in that PS [23:13:39] (CR) jenkins-bot: [V: -1] Treat 'Type' values case-insensitively [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/276911 (owner: Ejegg) [23:13:44] i'll grep [23:14:09] weird, yeah i do see a bunch of the txns in the new files [23:14:15] maybe i'm reading the output wrong from jenkins [23:14:29] err, they're all still in incoming [23:14:45] i'll kick the parser again [23:15:17] (PS2) Ejegg: Treat 'Type' values case-insensitively [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/276911 [23:17:00] just seems like it's not finding the new files [23:17:16] no idea why, names look fine [23:17:30] cwd I think it's only parsing 3 at a time [23:17:42] ooh, by design? [23:17:48] should i just run it a bunch of times? [23:17:59] there's a flag... one sec [23:19:32] cwd go into the job config and add --run_all [23:19:42] word [23:19:44] thanks [23:20:55] ejegg: added before the path argument, that right? also, should i remove it after i run? [23:21:50] (CR) Cdentinger: [C: 2] Treat 'Type' values case-insensitively [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/276911 (owner: Ejegg) [23:22:13] yep and yep [23:22:21] oh wait [23:22:41] I think the -r needs to be next to the path ard [23:22:44] *arg [23:23:19] so, move run_all to just before the -r [23:23:33] done [23:23:36] gonna hit it [23:23:39] cool [23:23:43] and thanks for the CR [23:24:14] you bet [23:24:17] Processed 278 'negative' transactions [23:24:20] sounds promising [23:24:28] aha, there are those missing refunds [23:24:42] MBeat: are you still around? [23:24:55] sure thing, what’s up? [23:25:19] i *think* we just got all those WP transactions that were missing [23:25:25] would you mind spot checking one or two? [23:25:35] cool, thank you - and yes, will take a look [23:25:44] great, thanks [23:26:00] i will check too, i just don't always know what i'm looking for [23:26:39] cwd, would they have the same transaction IDs as the donations? [23:26:56] (CR) Ejegg: [C: 2] "Merging totten's patch from upstream repo" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/276828 (owner: Ejegg) [23:27:00] cause 30555280.0 at least looks unchanged [23:27:17] MBeat: i would think so...though i guess they might still be processing. ejegg does that sound right to you? [23:27:57] cwd i noticed a few refunds in the older files had a different order id format [23:28:07] let's see if the new ones are all the right format [23:29:03] ooh, it's marked 'CANCELLED', maybe we're only looking for 'REFUNDED' ? [23:29:25] (Merged) jenkins-bot: Treat 'Type' values case-insensitively [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/276911 (owner: Ejegg) [23:29:35] hmm, maybe [23:29:43] i see both of those statuses in the audit files [23:29:51] the ones I’m looking up still have the status ‘completed’ [23:30:09] drat [23:30:41] MBeat: I just looked at the code, and we're ignoring 'CANCELLED' status [23:30:50] I can have it treat that as refunded [23:31:18] ah, cool - we canceled a fair amount so that would be great [23:31:29] thank you [23:32:03] hmm, best possible thing would be to add a third negative status to the parsers, since Civi does have a 'cancelled' status. [23:32:07] I'll make a phab task [23:33:19] will we want to reprocess those files once we change that? [23:33:27] cwd I think so [23:34:09] a lot of them were not moved to completed...it would be convenient if it was the ones with "canceled" rows because it didn't process them. is that a possibility? [23:34:32] maybe [23:36:31] well, it's dani's last day at her job today and i told her i'd come down for happy hour with the staff so i'm going to roll out for awhile [23:36:43] ok, have a good weekend! [23:36:47] also it being late-ish on friday i'd advocate for not fixing/deploying this right now [23:36:50] I'm outta here in like 20 min [23:36:51] ty cwd [23:37:00] & ejegg, you guys rock [23:37:13] np! you rock MBeat [23:37:19] thanks MBeat ! Donor services is pretty awesome [23:37:23] have a good weekend! [23:37:28] :) [23:38:44] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Smashpig, FR-Worldpay: Add 'Cancelled' type for refund messages - https://phabricator.wikimedia.org/T129714#2113667 (Ejegg) [23:46:09] (PS1) Ejegg: Update CiviCRM submodule and SmashPig library [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/276915 [23:54:12] alright, I'm heading out. Have a good weekend all!