[00:00:33] (PS2) Awight: [WIP] Prototype encapsulation for staging functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277698 (https://phabricator.wikimedia.org/T130075) [00:01:18] awight: it needs to take the adapter basically because it might need arbitrary data from the adapter? [00:01:25] yeah... [00:01:28] unpretty [00:01:36] (CR) jenkins-bot: [V: -1] [WIP] Prototype encapsulation for staging functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277698 (https://phabricator.wikimedia.org/T130075) (owner: Awight) [00:02:13] eh, prettier than current [00:02:24] there will be a shit load of these right? [00:02:27] sorta [00:02:59] could make a dir for em i guess [00:03:04] otherwise i think it's great! [00:03:10] I have a perverse plan to encapsulate e.g. all address-related things in a class, so Address might implement more than just StagingHelper [00:04:57] yeah i like that [00:05:07] awight: so here's the thing about yaml, or json, or whatever [00:05:12] but it's really the thing about php [00:05:32] hmm [00:05:34] is arrays are hashes...so the semantics of things that can actually tell the difference crash and burn [00:05:59] wat [00:06:06] this is about hash vs set? [00:06:10] like there is no array in php [00:06:11] mm vs list [00:06:14] it's just a hash [00:06:19] "just" [00:06:21] ah right [00:06:40] I think the yaml importer does that correctly [00:06:41] but yaml can represent the difference [00:07:00] - asdasd creates 0 => asasd [00:07:06] asdasd: creates 'asdasd' => [00:07:16] but what about [00:07:19] - asdf: asdf [00:07:28] *that* is when shit gets funky [00:07:47] I find lots of reasons to do exactly that, but not here [00:07:57] ok, i'll just avoid that one [00:07:59] it's only necessary if you're going to have multiple entries with the same key [00:08:28] do you have a preference on yaml parser? there's a pecl one, and composer has symfony/yaml [00:08:31] & if we do need to use that somewhere, it'll be decoded explicitly when we parse the file [00:09:02] I think I found a reason to use the symfony one, but cannot remember what that was. maybe the pecl isn't included by default? [00:09:13] !log Updating civicrm from 097bc2d298b93424ff07abb18eaf1cfb3f79a0f2 to c99abc42188b7f47726202b4740fbaf68d1c06ab [00:09:17] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [00:09:17] there must be a better parser by now... [00:09:28] awight: correct, pecl is not available by default [00:09:34] nah sfYaml [00:09:41] so i figured on the composer one [00:09:54] it seems like the only actively developed one [00:09:58] yea [00:09:58] supports yaml 1.2, etc [00:10:42] oh cool. I just had an epiphany about how to override e.g. just some of the address processing. [00:10:54] We would create a subclass of CoreStreetAddress [00:10:58] and wrap stage(), etc [00:11:13] oh yeah, good idea [00:11:43] to take advantage of this i would also like to nest submethods under methods [00:11:50] but i'll wait for version 0.2 [00:12:07] awesome [00:12:19] Can't freaking wait to have that stuff out of the class [00:13:20] yes [00:13:24] Eventually, the wild hair in my butt will create a cyst and I'll be comfortable with our software stack as-is again. [00:13:28] I hate how that happens. [00:13:43] * cwd looks at faded page down key [00:14:21] O_O [00:16:18] TODO: deprecate submethod, everything is a first-class method. [00:16:21] is that true? [00:18:59] Uhm [00:19:23] cwd: How old is that comment? [00:19:32] lessee [00:20:01] I want to call shenanigans on that one. [00:20:13] 2483a9ef (Adam Roses Wight 2013-05-16 18:53:55 -0700 841) //TODO: deprecate submethod, e [00:20:15] verything is a first-class method. [00:20:27] 2013? [00:20:29] Shenanigans. [00:20:37] awight: is your middle name actually Roses? [00:20:42] err. [00:20:47] I stole it from my wife [00:20:53] it's a good one [00:21:35] cwd: oh. check out PaymentMethod [00:22:32] It's a whole conversation, but I was bothered by how method and submethod are not um... Liskov substitutable [00:22:59] Like everything in DI, we took that distinction from one payment processor and tried to generalize it to everything else. [00:23:23] The way I see it, the donor has an intention which is like, "use PayPal". [00:23:39] We should fulfil that with paypal_paypal, globalcollect_paypal, or whatev [00:24:04] also, a submethod is something like a subtype of the method. [00:24:57] I want any valid payment method/submethod to provide operations that tell us things. [00:25:27] I only got far enuf to encapsulate methody things in PaymentMethod [00:25:46] but eventually, I'd like to deprecate (method, submethod) [00:26:11] yeah i can see that [00:26:21] hehe [00:26:23] like...submethod is the real method, and method is metadata about that submethod [00:27:03] we just... shouldn't have to care all the time. Like, it should be okay to send someone to a gateway with "pay by credit card" [00:27:06] who knows [00:27:22] oh, yeah i see what you mean [00:27:34] I was also under a haze of misimpressions, so the whole idea might be dingbatty [00:27:56] i still sometimes find myself thinking "we are taking people's money" instead of "we are sending people off to gateways" [00:28:14] at the last job we did because we were tiny and nobody cared [00:28:14] hmm [00:28:35] we sort of do take people's money, some methods don't involve a redirect. I think. [00:29:14] i thought that was the whole PCI-ABCDEF thing? [00:29:54] We're pretty close to PCI A-EP [00:30:16] but either way, we make an API call at the end of the workflow, which takes people's money. sometimes they are redirected, but not necessarily [00:31:13] ah yeah [00:31:20] i am a little brain dead [00:31:44] this regexing php apart is clown shoes. i'm sure the yaml parser can also output yaml [00:31:56] nvim macros... [00:32:12] ah. hey, that's a good move. print php data as yaml [00:32:36] i'm doing the GC one right now and it's too gnarly for macros, there are a dozen or so different structures [00:32:48] kill with fire! [00:32:51] but yeah that's what i'm gonna try [00:37:19] (PS3) Awight: [WIP] Prototype encapsulation for staging functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277698 (https://phabricator.wikimedia.org/T130075) [00:37:52] well i should have thought of that like 3 hours ago [00:38:19] that was all prep ;) [00:38:45] (CR) jenkins-bot: [V: -1] [WIP] Prototype encapsulation for staging functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277698 (https://phabricator.wikimedia.org/T130075) (owner: Awight) [00:39:01] i have to become sufficiently irritated with the wrong solution before the right one presents [00:40:49] (CR) Awight: "@ejegg, I don't understand how Amazon stages the amount..." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277698 (https://phabricator.wikimedia.org/T130075) (owner: Awight) [00:41:05] (CR) Awight: "Ah! by not staging it." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277698 (https://phabricator.wikimedia.org/T130075) (owner: Awight) [00:49:39] (PS4) Awight: Encapsulate staging functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277698 (https://phabricator.wikimedia.org/T130075) [00:50:56] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 3 others: LYBUNT related: Fiscal Year report does not work - https://phabricator.wikimedia.org/T123671#2125123 (Eileenmcnaughton) I updated all the... [01:20:23] (PS1) Awight: [WIP] Encapsulate AstroPay staging methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277705 [01:20:31] gtg [01:21:36] (CR) jenkins-bot: [V: -1] [WIP] Encapsulate AstroPay staging methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277705 (owner: Awight) [01:23:50] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 5 others: Civi exports timing out - https://phabricator.wikimedia.org/T120892#2125162 (Eileenmcnaughton) The time out increase I just did was enough... [01:50:28] (PS1) Cdentinger: WIP: pull payment methods out of GC adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277706 (https://phabricator.wikimedia.org/T130056) [01:51:48] (CR) jenkins-bot: [V: -1] WIP: pull payment methods out of GC adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277706 (https://phabricator.wikimedia.org/T130056) (owner: Cdentinger) [01:53:02] argh yaml parser needs a newer php [01:53:11] i can't even right now [11:00:05] hey jessicarobell give us one moment [12:36:04] (CR) Hashar: "check experimental" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/258718 (owner: Ejegg) [12:36:10] (CR) Hashar: "check experimental" [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/260778 (owner: Ejegg) [13:38:32] (PS1) Paladox: Change package node-syslog to modern-syslog [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/277768 [13:45:46] (PS2) Paladox: Change package node-syslog to modern-syslog [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/277768 [13:46:05] (CR) Paladox: "check experimental" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/277768 (owner: Paladox) [13:50:01] (PS3) Paladox: Change package node-syslog to modern-syslog [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/277768 [13:56:42] (PS1) Paladox: Add jshint and jsonlint to npm [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/277773 [13:58:11] (CR) jenkins-bot: [V: -1] Add jshint and jsonlint to npm [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/277773 (owner: Paladox) [13:59:36] (PS2) Paladox: Add jshint and jsonlint to npm [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/277773 [14:01:43] (CR) jenkins-bot: [V: -1] Add jshint and jsonlint to npm [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/277773 (owner: Paladox) [14:02:59] (PS3) Paladox: Add jshint and jsonlint to npm [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/277773 [15:42:50] woot! Just found an affordable co-working space [15:48:02] ejegg: cool! [15:52:33] ejegg: sweet [16:01:55] (CR) Ejegg: "This is great! Any reason not to put those core helpers in a base implementation of defineStagingHelpers?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277698 (https://phabricator.wikimedia.org/T130075) (owner: Awight) [16:05:14] (PS2) Cdentinger: WIP: pull payment methods out of GC adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277706 (https://phabricator.wikimedia.org/T130056) [16:06:48] (CR) jenkins-bot: [V: -1] WIP: pull payment methods out of GC adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277706 (https://phabricator.wikimedia.org/T130056) (owner: Cdentinger) [16:14:56] (CR) Ejegg: [C: 2] "Thanks! Modern-syslog works great locally, and the sole dependency looks like it should work under the older node version we've got on the" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/277768 (owner: Paladox) [16:21:18] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 5 others: Civi exports timing out - https://phabricator.wikimedia.org/T120892#2126466 (MBeat33) That's awesome, I was able to export all Ingenico no... [16:22:23] (PS1) AndyRussG: [WIP] Admin UI: Optimize handling of changes to campaigns via list [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/277792 (https://phabricator.wikimedia.org/T128869) [16:22:35] (PS3) Cdentinger: WIP: pull payment methods out of GC adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277706 (https://phabricator.wikimedia.org/T130056) [16:22:43] oh cool, 'git checkout - ' does exactly what you expect it to [16:23:09] checks out the last branch you were on [16:23:34] (PS1) Ejegg: Enable syslog on OSX [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/277793 [16:25:47] neat! [16:27:19] (CR) Ejegg: "Hi Sherah! If you have time (and already have the sample data set up) would you mind trying this patch, doing npm install, and see if dash" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/277793 (owner: Ejegg) [16:27:43] (CR) AndyRussG: "Tagging this as WIP to ensure we bang on it for a while, since a bug here has the potential to wreak havoc on the innocent." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/277792 (https://phabricator.wikimedia.org/T128869) (owner: AndyRussG) [16:28:13] holla, v+2 [16:28:30] i think i found a pretty quick way of pulling config out into yaml [16:28:38] aww yiss [16:28:39] i have yet to deal with dynamic content of course [16:28:48] but payment methods should be easy [16:29:00] nice! [16:30:25] ejegg: if you have time, wanna just lmk if that approach makes sense to you? [16:30:55] definitely! pulling the patch down now [16:33:54] (PS2) AndyRussG: [WIP] Admin UI: Optimize handling of changes to campaigns via list [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/277792 (https://phabricator.wikimedia.org/T128869) [16:34:12] Aaarg unfortunate when one forgets to delete large blocks of commented-out code... [16:35:10] (PS3) AndyRussG: [WIP] Admin UI: Optimize handling of changes to campaigns via list [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/277792 (https://phabricator.wikimedia.org/T128869) [16:35:22] Also silly typoes in commit messages are pooh [16:43:52] ejegg: just did astropay the same way, was easy, and i base classed definePaymentMethods [16:44:15] might even be able to further reduce repetition in DonationInterface.php [16:44:39] sweet! that one has the test-mode-only method - did you come up with a way to do things conditionally? [16:45:29] yeah so i just did parent::definePaymentMethods then tack that one on [16:45:42] that might be a good enough pattern for the dynamic stuff [16:45:44] ah, cool [16:45:58] i'll push that up so you can see [16:46:23] howdy awight [16:46:31] hi! [16:47:54] (PS1) Cdentinger: WIP move astropay payment methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277800 [16:49:21] these patches are negative lines too cause yaml [16:49:22] (CR) Awight: "@ejegg It crossed my mind, but we don't provide base implementations for any other define* methods. I sort of think this should be explic" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277698 (https://phabricator.wikimedia.org/T130075) (owner: Awight) [16:49:23] boss [16:49:39] yes! [16:49:54] heck yeah, put that codebase on a diet [16:50:37] so i think i can do all of the adapters by meeting time today, if you guys think this is a good pattern [16:51:09] awight: I think you suggested months ago i add my test links to the vagrant paymentswiki main page: https://gerrit.wikimedia.org/r/275108 [16:51:11] i just made a php file i paste the define method into, and make the yaml parser dump it as yaml [16:51:48] cwd rockin! I was hoping you didn't have to do that globalcollect transform by hand [16:52:04] yeah i spent about 3 hours regexing it apart before the obvious solution hit me :P [16:52:13] (CR) Awight: WIP: pull payment methods out of GC adapter (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277706 (https://phabricator.wikimedia.org/T130056) (owner: Cdentinger) [16:52:18] heh [16:53:07] awight: yeah i agree about that [16:53:23] i would prefer not to have a bunch more globals [16:54:03] but i'm not sure how to execute what you describe... [16:54:15] thanks for the CR on those links awight [16:54:36] for now, it would be enuf to simply read and parse everything in config/*, and merge it into a big per-gateway_config array [16:54:46] then, pull config->payment_methods [16:54:59] We can do the search path += /etc thing later [16:55:31] hmm, nice! [16:55:34] hmm, yeah that's cool [16:56:08] that was the only thing i had any doubts about on that patch too [16:56:46] ok lemme fiddle with that [16:57:40] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Some Ingenico refunds & cancels not reaching Civi - https://phabricator.wikimedia.org/T130129#2126639 (MBeat33) [17:00:04] (CR) Awight: WIP: pull payment methods out of GC adapter (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277706 (https://phabricator.wikimedia.org/T130056) (owner: Cdentinger) [17:01:45] (CR) Awight: WIP: pull payment methods out of GC adapter (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277706 (https://phabricator.wikimedia.org/T130056) (owner: Cdentinger) [17:03:23] (CR) Cdentinger: WIP: pull payment methods out of GC adapter (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277706 (https://phabricator.wikimedia.org/T130056) (owner: Cdentinger) [17:04:15] awight, ejegg : i notice in donationinterface.php there's no variables that are the adapters' base dirs [17:04:23] like /globalcollect_gateway [17:04:29] although that string appears a lot [17:04:49] i'm sorely tempted to make the var and replace everything with it [17:04:50] I almost think it doesn't need to be a config var [17:05:06] maybe just load __DIR__/config/ from the *gateway class [17:05:16] oh, ok cool [17:06:56] (PS5) Awight: Encapsulate staging functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277698 (https://phabricator.wikimedia.org/T130075) [17:06:58] (PS2) Awight: [WIP] Encapsulate AstroPay staging methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277705 [17:07:07] (rebase) [17:08:55] (CR) jenkins-bot: [V: -1] [WIP] Encapsulate AstroPay staging methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277705 (owner: Awight) [17:09:30] Do we have a task for the php55 upgrade yet [17:09:31] ? [17:13:23] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Patch-For-Review: Deploy Thank you letters to remove Lila's signature - https://phabricator.wikimedia.org/T129373#2126675 (Ejegg) I just realized the from name 'Wikimedia Foundation' will need to be translated. Looking into how that w... [17:14:17] awight / cwd / AndyRussG / XenoRyet: Any news or requests for Scrum of Scrums? [17:14:27] None from me. [17:14:31] Fundraising-Backlog, fundraising-tech-ops: Upgrade payments to MediaWiki 1.26 + PHP 5.5 - https://phabricator.wikimedia.org/T130130#2126677 (awight) [17:14:43] Fundraising-Backlog, fundraising-tech-ops: Upgrade payments to MediaWiki 1.26 + PHP 5.5 - https://phabricator.wikimedia.org/T130130#2126692 (awight) p:Triage>High [17:16:19] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Patch-For-Review: Deploy Thank you letters to remove Lila's signature - https://phabricator.wikimedia.org/T129373#2103736 (awight) Rats, "Wikimedia Foundation" occurs in the string `userrights-nodatabase`, but not on its own. [17:16:49] awight: I see '*** This is overwritten by any translations that may exist ***' under the From name field in ty config, but it doesn't look like there's any translation logic under the hood [17:17:10] yipes [17:17:20] I believe it [17:17:33] take this lemon back! [17:17:38] Using different translations systems for the subject line vs the body suuux [17:17:46] yuuuup [17:17:50] you're out of the buyback window :p [17:17:54] heh [17:18:02] and hurtling down the highway [17:18:04] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Patch-For-Review: Deploy Thank you letters to remove Lila's signature - https://phabricator.wikimedia.org/T129373#2126718 (atgo) Are we sure that we need that translated? If it's a formal name, perhaps it shouldn't be? Let's check with... [17:18:11] unsafe at any speed... [17:18:49] ejegg: good here, thanks! [17:21:54] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Patch-For-Review: Deploy Thank you letters to remove Lila's signature - https://phabricator.wikimedia.org/T129373#2126720 (awight) @atgo I think you're right: https://translatewiki.net/wiki/Wikimedia:Wikipedia-ios-about-wikimedia-foun... [17:24:11] (CR) Awight: WIP: pull payment methods out of GC adapter (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277706 (https://phabricator.wikimedia.org/T130056) (owner: Cdentinger) [17:27:21] * awight is infuriated for the 100th time at inability to run phpunit on mediawiki-core [17:31:26] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Patch-For-Review: Deploy Thank you letters to remove Lila's signature - https://phabricator.wikimedia.org/T129373#2126797 (jrobell) How about we just use 'Jimmy Wales" as the from name? The same way we used "Lila Tretikov" in the past.... [17:37:50] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Patch-For-Review: Deploy Thank you letters to remove Lila's signature - https://phabricator.wikimedia.org/T129373#2126810 (CCogdill_WMF) I don't know that our from name testing has the same weight here; an email sent right after a dona... [17:37:58] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Civi: multiple errors when cancelling recurring Ingenico donations - https://phabricator.wikimedia.org/T128389#2126813 (MBeat33) @awight I spun off the missing refunds into {T130129}... [17:47:57] awight: i have a feeling you're going to get grossed out by this next patch set [17:49:44] (PS2) Cdentinger: WIP move astropay payment methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277800 [17:51:38] (CR) jenkins-bot: [V: -1] WIP move astropay payment methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277800 (owner: Cdentinger) [18:11:46] Fundraising-Backlog, FR-Smashpig: Create local git repo for SmashPig config - https://phabricator.wikimedia.org/T129706#2126948 (Jgreen) Would it make sense to change how we use that localsettings repo to include smashpig and other config as well, so it would be more of a 'local settings' repo than "pay... [18:25:49] (CR) Ejegg: [C: 2] "Splitting the code out into other classes is a great direction! Let's decide on a folder structure soon and get some stuff out of gateway_" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277698 (https://phabricator.wikimedia.org/T130075) (owner: Awight) [18:28:46] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Patch-For-Review: Deploy Thank you letters to remove Lila's signature - https://phabricator.wikimedia.org/T129373#2127033 (Ejegg) Cool! It turns out we would have to write code to translate the from name. I'll use "Jimmy Wales, Wikip... [18:35:50] (PS1) Ejegg: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/277832 [18:37:07] (CR) Ejegg: [C: 2] Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/277832 (owner: Ejegg) [18:37:15] ejegg: thanks! [18:38:00] ejegg: I won't lie, AstroPay::unstage_payment_method is really hard to understand for some reason [18:38:00] pushing out those letter changes in a sec [18:38:16] k. Was there a schedule for that btw? [18:38:23] I thought we might be waiting for the 31st [18:38:53] ah, let me review the ticket [18:39:03] i had the impression sooner was good [18:39:08] atgomez: you have any info about this? ^ [18:39:58] re unstage: yeah, there's probably a simpler way to map backward from bank code and method to get submethod [18:44:08] which is the question awight? [18:44:43] (Merged) jenkins-bot: Encapsulate staging functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277698 (https://phabricator.wikimedia.org/T130075) (owner: Awight) [18:45:56] atgomez: Do we want to change the TY letters ASAP or at the end of the month? [18:46:05] we have 2 stages [18:46:08] 1) remove the signature [18:46:13] 2) translations, whenever [18:46:17] with new letter [18:46:29] i think the task we have so far is to remove the signature [18:46:34] 31st or sooner [18:46:50] awight ejegg ^ [18:46:56] OK, cool, I'll deploy the signature change shortly! [18:47:14] Will shut down the email send job for a little bit of testing [18:47:29] thanks [18:47:54] thanks! [18:48:38] (PS3) Awight: Encapsulate AstroPay staging methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277705 [18:51:13] !log disabled thank you mail sender [18:51:17] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [18:52:45] !log updated CiviCRM from c99abc42188b7f47726202b4740fbaf68d1c06ab to 9e03bcc4d0e6e80aedefedbbf1eed608b7e9d38d [18:52:50] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [19:08:26] (PS4) Awight: Encapsulate AstroPay staging methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277705 (https://phabricator.wikimedia.org/T130075) [19:08:28] (PS1) Awight: Generalize data transformations [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277845 (https://phabricator.wikimedia.org/T130075) [19:19:59] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Patch-For-Review: Deploy Thank you letters to remove Lila's signature - https://phabricator.wikimedia.org/T129373#2127237 (Ejegg) Just deployed and spammed myself with a test thank you letter in each language. The job is still off, so... [19:21:34] !log rolled back CiviCRM to c99abc42188b7f47726202b4740fbaf68d1c06ab [19:21:38] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [19:24:12] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Patch-For-Review: Deploy Thank you letters to remove Lila's signature - https://phabricator.wikimedia.org/T129373#2127257 (CCogdill_WMF) > How bad is it that there are still a lot of languages with Lila's name in the body and now Jimmy... [19:33:50] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Civi: multiple errors when cancelling recurring Ingenico donations - https://phabricator.wikimedia.org/T128389#2127300 (awight) The fix seems to have worked, there are some subscript... [19:34:21] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Civi: multiple errors when cancelling recurring Ingenico donations - https://phabricator.wikimedia.org/T128389#2072787 (awight) Open>Resolved [19:34:54] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Patch-For-Review: Deploy Thank you letters to remove Lila's signature - https://phabricator.wikimedia.org/T129373#2127306 (Ejegg) @jrobell Here are the templates that still have Lila's name in them (in a few of them, the matching gift... [19:34:57] ejegg: What you think about https://gerrit.wikimedia.org/r/277845 ... [19:35:09] looking [19:35:15] I might be fetishing out [19:39:34] huh, i kind of like it [19:40:27] awight: let me try implementing request signing as a transform type [19:40:42] * awight shudders [19:40:47] no? [19:40:52] no i totally agree [19:41:01] I was eyeing that one with great circumspection [19:41:11] I think the signing algorithm should be its own class, too. [19:41:12] k [19:41:23] The only catch seemed to be, how to access accountInfo [19:42:28] public method on GatewayType and pass the adapter into ->sign( ? [19:42:33] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Civi: multiple errors when cancelling recurring Ingenico donations - https://phabricator.wikimedia.org/T128389#2127343 (MBeat33) @awight many thanks, this is great! [19:42:41] that works [19:42:53] I really like this GatewayType surgery u did, btw [19:43:01] much more honest... [19:43:21] heh, that interface was totally unused [19:44:03] that exercise really points out the bloat too [19:44:52] beyond 'OMG that many lines' to 'what the heck, that many responsibilities?' [19:45:09] ping anyone know about the mq queue bloat alert? [19:45:25] Jeff_Green: was it the thank you queue? [19:45:26] Jeff_Green: not yet... looking [19:45:30] ah [19:45:34] I just turned that back on [19:45:44] "recurring gc failures missed" [19:45:54] oh huh [19:46:28] looks like it took a big jump and stayed there, as of10-25 minutes ago [19:46:35] err 10-15 not 25 [19:47:23] huh, last recurring gc run was 46 min ago [19:47:26] Jeff_Green: That was me--I forgot we had an alarm on that [19:47:40] awight should I tweak the threshold? [19:47:46] I backfilled some corrupted data, about 1800 recurring subscriptions had an incorrect "null" value [19:47:53] sure, that's a good idea [19:48:14] Jeff_Green: remind me where I can read the alarm source code? [19:48:21] I know you pasted it somewhere... [19:51:23] jesus, 2 more [19:52:03] :( [19:52:32] uuugh [19:53:39] awight it's in the frack puppet repo, checked out to boron:/etc/puppet/modules/nagios/files/plugins/check_activemq [19:55:06] thx [19:56:07] awight and to look at args you'd look in boron:/etc/puppet/modules/role/manifests/fundraising_database.pp [19:56:44] it's alerting at 300 now, what's a reasonable threshold going forward? [19:57:04] I'm trying to remember what this queue is even for [19:57:18] It might be ok to just acknowledge the alert and it should go away... [19:57:37] ok [20:08:18] ejegg: running into some more glue traps with GC's direct debit staging functions... They try to set data constraints and stuff. [20:08:42] aww gross, they change them? [20:08:58] that should happen elsewhere... [20:09:06] yeah [20:09:31] the mappings should be part of the submethod metadata [20:09:42] (PS1) Awight: [WIP] Encapsulate Ingenico staging logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277861 [20:09:50] anyway, gotta prepare for a meeting... [20:11:06] (CR) jenkins-bot: [V: -1] [WIP] Encapsulate Ingenico staging logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277861 (owner: Awight) [20:13:26] (PS4) Cdentinger: WIP: pull payment methods out of GC adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277706 (https://phabricator.wikimedia.org/T130056) [20:15:52] (PS3) Cdentinger: WIP move astropay payment methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277800 [20:17:21] (CR) jenkins-bot: [V: -1] WIP move astropay payment methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277800 (owner: Cdentinger) [20:20:11] WTF is up with account_config vs accountInfo [20:20:19] that might be my fault. [20:20:23] there's no difference [20:21:06] err, no [20:21:33] omg what is up [20:21:47] accountInfo is used in getTransactionSpecificValue, and must be set in subclasses [20:22:16] account_config is set in findAccount and is what you would expect, a copy of *GatewayAccountInfo [20:22:43] k, accountInfo is set by defineAccountInfo. seems to be a pre-staged version of the data [20:23:10] hmm, so accountInfo is supposedly for the 'current' account [20:24:13] in which adapter? [20:24:27] worldpay at least [20:24:56] err, no [20:25:09] it's just some random subset of account_config [20:25:17] This would be good debt to eliminate [20:25:22] yah [20:26:28] a thing to keep in mind is, that defineAccountInfo is closely related to the problem where we need to fill in some $transactions fields using account_config, so need to dress it up after loading from a declarative source. [20:26:39] probably both of those can be collapsed into a single place [20:27:28] awight: I'm thinking the getAccountInfo function can transform stuff from account_config, pick the correct account, etc [20:28:00] sure. then a separate thing folds that data into the transaction? [20:28:42] (PS4) AndyRussG: [WIP] Admin UI: Optimize handling of changes to campaigns via list [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/277792 (https://phabricator.wikimedia.org/T128869) [20:28:44] I think we'd call getAccountInfo inside transactionSpecificValue [20:29:20] how do we know the mapping between staged field name and account info field? [20:29:49] I was thinking getAccountInfo would do that [20:30:13] hrm. it could be different depending on the transaction [20:30:36] right, in getAccountInfo you can check which txn you're in [20:31:04] is it gc you're thinking of? [20:31:12] let me see [20:34:19] huh, maybe the signature object adds credentials and stuff [20:34:39] 'authentication' responsibility [20:46:33] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: account_config vs accountInfo vs account_name is a mess - https://phabricator.wikimedia.org/T130154#2127476 (Ejegg) [21:00:58] awight: just finished some heinous debugging...essentially determining gateway/config path works fine, except not in tests [21:01:13] haarrr [21:01:20] and i can't quite imagine a way around that [21:02:50] cwd: why not in the tests? [21:03:12] awight: cause pwd is tests/includes/test_gateway/ [21:03:34] um. don't use cwd [21:03:47] getcwd [21:03:55] use __DIR__ from the gateway adapter class [21:04:18] so that's gonna be gateway_common, unless we copy/paste the function into every child class [21:04:38] but if you determine __DIR__ for the child class, that will resolve to test_gateway [21:04:42] gotcha [21:05:05] how about $this->getConfigPath :( [21:05:26] and have it in settings after all? [21:05:46] i had such a clean solution too...fscking tests [21:05:52] nah, implemented in each gateway [21:06:00] skin crawls [21:06:21] or better, getBaseFilesystemPath [21:06:31] then you get the /forms/ parent and stuff [21:06:49] would you want that to be /core or /DonationInterface? [21:08:01] I think DonationInterface/amazon_gateway [21:08:42] I'd to move towards each gateway being much more encapsulated and with no forward references from base code [21:09:03] Fundraising-Backlog: Sprint F Goal: Scope Q4 work, deal with some civi bugs - https://phabricator.wikimedia.org/T128678#2127538 (atgo) [21:09:50] awight: where would those be stored? in donationinterface.php? [21:10:41] i dig what you mean about not doing so much in the base class [21:11:22] but i'd also love to avoid excessive repetition [21:11:26] It's incredibly cheesy, but I was thinking class AmazonAdapter{ function getBaseFIlesystemPath() { return __DIR__; [21:11:30] I know. [21:11:32] it's horrible [21:11:53] but it makes the base class logic nicer [21:12:08] yeah actually that's not a bad idea [21:12:13] lemme mess with that [21:12:15] thanks [21:13:33] Fundraising-Backlog: Scope remaining PCI work - https://phabricator.wikimedia.org/T129948#2127546 (DStrine) Open>Invalid [21:13:36] it's a dirty world, but it still spins... [21:17:23] I might be a little bit late to the retro, there's a bird food emergency... [21:36:17] cwd could you abuse the mediawiki autoloader? [21:37:26] probably a bad idea [21:37:51] Fundraising-Backlog, FR-Adyen: Adyen form for French (France), Japanese (Japan), Ukrainian (Ukraine), & Hebrew (Israel) - https://phabricator.wikimedia.org/T128812#2127589 (atgo) [21:37:53] Fundraising-Backlog, FR-Adyen: Hide "cardholder name" field from Adyen form - https://phabricator.wikimedia.org/T124467#2127590 (atgo) [21:44:44] so FYI - i'm goign to have to jump off the call for a minute to let a plumber in at some point [21:46:01] ejegg: hmmmm [21:46:08] i have a "solution" [21:46:10] but it's ugly [21:48:06] class inheritance sux [21:51:22] * ejegg just learned about 'git show' [21:51:40] view a file version from another branch without checking out [21:52:09] what does awight|birds mean? [21:52:20] away with the birds? [21:52:31] he said something mysterious about a bird food emergency [21:52:39] ahhhh [21:55:22] ooh, I should revert those thank you letters for now, so crm is deployable [21:58:21] ejegg: they need to be held until 31st? [21:58:40] (PS4) Cdentinger: WIP move astropay payment methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277800 [21:59:04] eileen: no, just till we sort out a few more languages [21:59:38] we have a single 'from' name for every language, which we're changing to Jimmy Wales, but there are a few templates left with Lila's name [22:00:20] (CR) jenkins-bot: [V: -1] WIP move astropay payment methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277800 (owner: Cdentinger) [22:01:24] (PS1) Ejegg: Revert "Thank You letters for executive director transition" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277900 (https://phabricator.wikimedia.org/T129373) [22:02:38] @AndyRussG you free for a meeting? [22:02:47] dstrine-meeting: yeah just connecting now! [22:07:18] (PS5) Cdentinger: WIP move astropay payment methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277800 [22:15:24] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 3 others: LYBUNT related: Fiscal Year report does not work - https://phabricator.wikimedia.org/T123671#1935422 (Eileenmcnaughton) I *think* this is... [22:17:23] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work, and 2 others: Missing currency code in mustache form gives vague, non-localized error message - https://phabricator.wikimedia.org/T129277#2127744 (Ejegg) Open>Reso... [22:18:43] eileen: Fatal error: Cannot access private property Civi\Core\Transaction\Frame::$state [22:19:42] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Unplanned-Sprint-Work, FR-Astropay, and 2 others: Remove fiscal number for Mexico form - https://phabricator.wikimedia.org/T129552#2127751 (Ejegg) Still waiting on instruction from AstroPay, sending increasingly urgent emails. [22:20:22] cwd :-( no - can't spot anything easily [22:20:51] eileen: ok! thanks for checking [22:20:56] i'll fiddle with it [22:21:10] could be something totally unrelated...there are about a hundred levels of indirection [22:21:23] :-) [22:22:45] Fundraising-Backlog: Expand access to the table that holds failed payment data - https://phabricator.wikimedia.org/T129261#2127758 (MBeat33) Open>Resolved a:MBeat33 We got this data from Sal, and so no longer need this task. [22:24:35] omg why [22:24:42] provision worked fine with debug on [22:24:47] why [22:27:21] it's just trying to mess with you [22:28:12] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Unplanned-Sprint-Work, FR-Astropay, and 2 others: Remove fiscal number for Mexico form - https://phabricator.wikimedia.org/T129552#2127783 (Ejegg) Hah, looks like I should have checked my email before posting that last one. Just go... [22:29:27] neutral evil [22:44:02] Fundraising-Backlog, Wikimedia-Fundraising: Ingenico: BPay donation form shows blank screen after 'Continue' - https://phabricator.wikimedia.org/T127863#2127832 (MBeat33) This white screen error consistently occurs when testing https://donate.wikimedia.org/wiki/Special:FundraiserLandingPage?uselang=en&co... [22:45:07] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog: Sprint E Goal: Astropay 1-hour test ready, keep re-dupe moving - https://phabricator.wikimedia.org/T128674#2127837 (DStrine) Open>Resolved [22:45:49] (PS1) Eileen: sync with 4.7 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277910 [22:45:51] (PS1) Eileen: CRM-18104 Hook for defining log tables. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277911 [22:46:51] Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review: Pull payment methods out of adapters - https://phabricator.wikimedia.org/T130056#2127842 (cwdent) [22:47:14] (Abandoned) Eileen: CRM-18104 Hook for for defining log tables. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277442 (owner: Eileen) [22:49:47] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Zapp, Fundraising-Backlog, and 2 others: Spike: Split out ActiveMQ replacement tasks for making code changes - https://phabricator.wikimedia.org/T123247#1924535 (awight) [22:54:56] (PS2) Eileen: CRM-18180 allow non-standard table names in logging reports [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277443 [22:55:07] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint F, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 4 others: Move staging functions into helper classes - https://phabricator.wikimedia.org/T130075#2127870 (DStrine) [22:55:09] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint F, Fundraising-Backlog, Unplanned-Sprint-Work, Patch-For-Review: Pull payment methods out of adapters - https://phabricator.wikimedia.org/T130056#2127871 (DStrine) [22:55:11] Fundraising Sprint F, Fundraising-Backlog, fundraising-tech-ops: Put faulkner database on ice - https://phabricator.wikimedia.org/T130039#2127873 (DStrine) [22:55:13] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint F, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 3 others: Pull profiling code out of gateway adapter - https://phabricator.wikimedia.org/T130055#2127872 (DStrine) [22:55:15] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint F, Fundraising-Backlog, Unplanned-Sprint-Work, and 2 others: Only capture a single payment against any order ID - https://phabricator.wikimedia.org/T129935#2127874 (DStrine) [22:55:17] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint F, Fundraising-Backlog, Unplanned-Sprint-Work, WMF FR: Ingenico ePayments Partners with Trustwave for PCI Compliance - https://phabricator.wikimedia.org/T129596#2127876 (DStrine) [22:55:19] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint F, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Catch exceptions in adapter constructor - https://phabricator.wikimedia.org/T129376#2127878 (DStrine) [22:55:22] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint F, Fundraising-Backlog, Unplanned-Sprint-Work, and 3 others: Remove fiscal number for Mexico form - https://phabricator.wikimedia.org/T129552#2127877 (DStrine) [22:55:24] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint F, Fundraising-Backlog, Patch-For-Review: Deploy Thank you letters to remove Lila's signature - https://phabricator.wikimedia.org/T129373#2127879 (DStrine) [22:55:26] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint F, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, and 2 others: CentralNotice: DB timeouts when enabling more than one campaign at once from Special:CentraNotice - https://phabricator.wikimedia.org/T128869#2127881 (DStrine) [22:55:29] Fundraising Sprint F, Fundraising-Backlog: Sprint F Goal: Scope Q4 work, deal with some civi bugs - https://phabricator.wikimedia.org/T128678#2127882 (DStrine) [22:55:31] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint F, Fundraising-Backlog, Unplanned-Sprint-Work, FR-Worldpay: Worldpay refunds not reaching Civi - https://phabricator.wikimedia.org/T129265#2127880 (DStrine) [22:55:33] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint F, Fundraising-Backlog: Civi: batch import of refunds, problem transaction: currency switched - https://phabricator.wikimedia.org/T127979#2127883 (DStrine) [22:55:36] Fundraising Sprint Dirt Farming, Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint F, Fundraising-Backlog, and 2 others: Make dedupe reversible step 1 of 5 test turning on logging on Staging to see how it performs. - https://phabricator.wikimedia.org/T127133#2127884 (DStrine) [22:55:37] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 4 others: LYBUNT related: Fiscal Year report does not work - https://phabricator.wikimedia.org/T123671#2127887 (DStrine) [22:55:39] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint F, Fundraising Sprint Zapp, and 3 others: Spike: Split out ActiveMQ replacement tasks for making code changes - https://phabricator.wikimedia.org/T123247#2127888 (DStrine) [22:55:42] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 3 others: Some Globalcollect donations not in Civi - https://phabricator.wikimedia.org/T122730#2127889 (DStrine) [22:55:44] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 4 others: Spike: Is it a problem that the Silverpop export is still not updating entire database? - https://phabricator.wikimedia.org/T120880#2127893 (... [22:55:46] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 6 others: Civi exports timing out - https://phabricator.wikimedia.org/T120892#2127892 (DStrine) [22:55:48] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint F, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Civi should record merge activities on both old and new contacts - https://phabricator.wikimedia.org/T119426#2127894 (DStrine) [22:55:50] Fundraising Sprint F, Fundraising-Backlog, FR-Paypal: Scope PayPal express checkout - https://phabricator.wikimedia.org/T113625#2127895 (DStrine) [23:15:31] awight|birds: that php timeout increase worked for 45k rows but then not for some of the larger ones - I'm inclined just to punt it up to 600 secs [23:15:43] eileen: works for me! [23:15:50] ok - coming through! [23:15:53] It's also legit to do from within the loop, IMO [23:16:13] cos, if we're making progress through the job we're ok. the timeout is mostly to catch a runaway, hung job [23:17:38] awight: yeah - I was probably being paranoid there [23:18:08] worried about an infinite loop - but I can't say how one would occur [23:21:27] (PS1) Eileen: Further time limit increase on exports [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277921 (https://phabricator.wikimedia.org/T120892) [23:23:52] (CR) Awight: [C: 2] "all in good time!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277921 (https://phabricator.wikimedia.org/T120892) (owner: Eileen) [23:24:38] dstrine - I might tinker with the dedupe tasks a bit - the one I have in the sprint is kinda done but I have some fixes that came out of it [23:24:41] cwd|afk: you might be able to say "const GATEWAY_BASE_DIR = __DIR__" [23:25:03] eileen: ok sounds good [23:30:54] Starting to work on this in the background: https://etherpad.wikimedia.org/p/Fundraising_-_documentation_needed [23:33:32] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Fix up core logging spec - https://phabricator.wikimedia.org/T130161#2127955 (Eileenmcnaughton) [23:34:03] Fundraising Sprint Freshmaking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Fix up core logging spec - https://phabricator.wikimedia.org/T130161#2127955 (Eileenmcnaughton) [23:35:20] (Merged) jenkins-bot: Further time limit increase on exports [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277921 (https://phabricator.wikimedia.org/T120892) (owner: Eileen) [23:36:02] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Finalise sql & process for turning logging on on live - https://phabricator.wikimedia.org/T130163#2127990 (Eileenmcnaughton) [23:37:21] Fundraising Sprint Freshmaking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Improve the change log report - https://phabricator.wikimedia.org/T130164#2128006 (Eileenmcnaughton) [23:39:49] K4-713: This is very asynchronous, but if you have anything to add here in the next few weeks... https://etherpad.wikimedia.org/p/Fundraising_-_documentation_needed [23:40:17] awight: It might be easier to identify things we like the docs for. [23:41:43] K4-713: "lack"? [23:42:43] Nope. Like. [23:42:46] What I'm trying to do is put together a checklist, much of which we might already have in some form. [23:42:48] What *do* we have documented? [23:42:51] Shorter list. [23:43:11] aah hehe [23:43:25] (PS2) Eileen: CRM-18104 Hook for defining log tables. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277911 (https://phabricator.wikimedia.org/T130161) [23:43:27] (PS2) Eileen: sync with 4.7 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277910 (https://phabricator.wikimedia.org/T130161) [23:43:29] (PS3) Eileen: CRM-18180 allow non-standard table names in logging reports [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277443 (https://phabricator.wikimedia.org/T130161) [23:43:31] (PS1) Eileen: Add tests for logging functionality to ensure the tables are still creating well [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277923 (https://phabricator.wikimedia.org/T130161) [23:43:33] (PS1) Eileen: CRM-18193 adapt reports to expect a 17 char string rather than 24 char varchar for log_conn_id [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277924 (https://phabricator.wikimedia.org/T130161) [23:43:38] I'm refreshing myself on what we have now, some of it is really good. [23:44:23] K4-713: but what does it get us to just list the good stuff? [23:45:22] If we had a total list of all the things... all the way. [23:50:45] ejegg|away: this is awesome! https://collab.wikimedia.org/wiki/Fundraising/Adyen [23:51:49] (PS2) Eileen: CRM-18193 make unique ID for request available to php & mysql [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277440 (https://bugzilla.wikimedia.org/130161)