[00:00:31] <awight>	 K4-713: maybe this is a documentation "audit" rather than list of what's needed
[00:03:27] <K4-713>	 awight: Seems like the same thing to me, actually. Semantics.
[00:04:59] <awight>	 sure, I'm ruminating just to understand what I'm hoping to accomplish
[00:05:18] <awight>	 K4-713: btw, does this diagram mean anything to you?  https://collab.wikimedia.org/wiki/File:Fundraising_causality.svg
[00:05:38] <awight>	 It's supposed to be a chart of which system failures will break other things.
[00:07:11] <K4-713>	 I'm not sure it's totally correct...
[00:07:22] <K4-713>	 Doesn't payments explode when AMQ fails to exist?
[00:08:16] <K4-713>	 It used to.
[00:10:56] <grrrit-wm>	 (PS1) Eileen: Fix for enable loggin in multisite [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277928 (https://phabricator.wikimedia.org/T130161)
[00:10:58] <grrrit-wm>	 (PS1) Eileen: CRM-18193 create all new log tables with log_conn_id = varchar(17) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277929 (https://phabricator.wikimedia.org/T130161)
[00:11:00] <grrrit-wm>	 (PS1) Eileen: CRM-18193 add routine for converting log tables to support new log_conn_id format & hook spec [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277930 (https://phabricator.wikimedia.org/T130161)
[00:18:21] <grrrit-wm>	 (CR) Awight: "Maybe squash with the parent rev?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277800 (owner: Cdentinger)
[00:24:35] <grrrit-wm>	 (CR) Awight: "Wow, mergeable already! I left a few ideas for cleanup." (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277800 (owner: Cdentinger)
[00:29:46] <wikibugs>	 Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 4 others: Move staging functions into helper classes - https://phabricator.wikimedia.org/T130075#2128192 (awight) a:awight
[00:54:25] <cwd|afk>	 awight: you still 'round?
[00:59:25] <grrrit-wm>	 (PS1) Eileen: Add hook to define log tables, specifying INNODB & indexing contact fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277934 (https://phabricator.wikimedia.org/T130161)
[01:01:20] <grrrit-wm>	 (PS1) Eileen: CiviCRM submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277935
[01:03:04] <grrrit-wm>	 (PS1) Awight: [WIP] Start converting GC staging to new style. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277936
[01:03:05] <awight>	 cwd: hey!
[01:04:20] <cwd>	 yo!  just pondering this config stuff
[01:04:23] <grrrit-wm>	 (CR) Eileen: [C: 2] "submodule, self-approving" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277935 (owner: Eileen)
[01:04:27] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] [WIP] Start converting GC staging to new style. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277936 (owner: Awight)
[01:04:54] <awight>	 want to hangouts or anything?  I have some dishes to do, that might be compatible :)
[01:05:09] <cwd>	 yeah that sounds good
[01:05:10] <cwd>	 but real quick
[01:05:25] <cwd>	 do you recognize this? Fatal error: Function already defined: wfEntryPointCheck in /vagrant/mediawiki/maintenance/Maintenance.php on line 26
[01:05:30] <cwd>	 when trying to run tests from vagrant
[01:05:41] <awight>	 fuck
[01:05:43] <awight>	 y
[01:05:54] <cwd>	 i'm getting a multiversion vibe from that dir
[01:06:05] <awight>	 gaaah
[01:06:42] <awight>	 we've all been hit by this, but I can't remember the magic...
[01:06:52] <awight>	 needs to go into Main_Page.wiki this time.
[01:07:35] <grrrit-wm>	 (Merged) jenkins-bot: CiviCRM submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277935 (owner: Eileen)
[01:07:51] <wikibugs>	 Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, and 2 others: CentralNotice: DB timeouts when enabling more than one campaign at once from Special:CentraNotice - https://phabricator.wikimedia.org/T128869#2128277 (...
[01:07:55] <cwd>	 awight: can you finish this sentence for me?  "we built multiversion instead of using vhosts because ____"
[01:08:00] <awight>	 not in my command history..
[01:08:09] <awight>	 yeah.  I partly blame myself for what happened
[01:08:13] <bd808>	 because 800+ wikis
[01:08:18] <cwd>	 i mean i'm sure there's a good reason
[01:08:39] <cwd>	 bd808: hehe i was hoping you wouldn't notice me talking smack
[01:08:47] <awight>	 Our use case was very different from everyone else's
[01:09:13] <awight>	 just cos of the mw-core divergence
[01:09:14] <bd808>	 I'm honestly not sure why most of fundraising uses MediaWiki as the backend at all
[01:09:19] <cwd>	 do vhosts suck at that scale?
[01:09:36] <Seddon>	 bd808: in what way?
[01:09:40] <awight>	 bd808: it's only for frontend payment processing... we're doing a lot of very slow work to totally decouple from it
[01:10:11] <bd808>	 Seddon: because a wiki is for collaborative editing, not collecting payments
[01:10:40] <awight>	 we... collaboratively edit the UI
[01:10:43] <bd808>	 and well I've lived enough PCI-DSS audit nightmares to not want MediaWiki in scope for the audit
[01:10:57] <cwd>	 heh
[01:10:58] <awight>	 weirdly enough, that part is okay
[01:11:10] <Seddon>	 pretty much what awight says. Its something that's evolved over many many years
[01:11:17] <awight>	 I guess if you can use anything built by Microsoft, that's reasonable
[01:11:40] <Seddon>	 previously the landing page was on donate wiki
[01:11:53] <awight>	 bd808: fwiw, our payments processing code can already run under Drupal (for back of the house work), or standalone.
[01:12:22] <awight>	 but our forms are built in MediaWiki.  We're about halfway into rewriting those as pure Mustache
[01:12:51] <awight>	 cwd: I'm still looking for the magic phpunit flags you need...
[01:13:46] <awight>	 AndyRussG: I think you hit this most recently.  ^ you happen to remember how to run phpunit within the mw-vagrant-multiwiki shell?
[01:14:17] <cwd>	 awight: i use this for a bash history that doesn't rotate: export PROMPT_COMMAND="history 1 >> ~/.muh_histry"
[01:14:34] <awight>	 verra nice
[01:14:42] <awight>	 I think you can set HISTSIZE to infinity, too
[01:14:57] <cwd>	 other advantage is it's shared with all running terms, in a tmux type world
[01:15:10] <awight>	 yes!  that's huge, good idea
[01:15:14] <cwd>	 advantage or disadvantage depending
[01:15:17] <cwd>	 but it's nice to have both
[01:16:05] <awight>	 cwd: well ,I can reproduce the phpunit fail
[01:16:35] <AndyRussG>	 awight: ahah I did get further than nowhere but never got it to actually run!
[01:16:37] <awight>	 Why does that die.  MW_INSTALL_PATH=/vagrant/mediawiki-fr ./phpunit.php --group DonationInterface
[01:16:59] <bd808>	 there's some magic for this... wtf is it
[01:17:01] <awight>	 cwd: would you mind creating a task to freaking fix and document that
[01:17:34] * awight boots backup drive that might have this command
[01:18:42] <cwd>	 you bet
[01:18:52] <awight>	 ugh.  it would be in the balled-up VM filesystem
[01:19:13] <bd808>	 heh. This is what I was looking for -- https://www.mediawiki.org/wiki/Fundraising_tech#Running_PHPUnit_tests_under_vagrant
[01:19:38] <awight>	 O_o
[01:19:41] <awight>	 bd808: thank you.
[01:19:53] <cwd>	 nice
[01:20:08] <bd808>	 note the page that is on ;)
[01:20:11] * awight salutes ejegg|away 's documentation skills again
[01:20:35] <cwd>	 bd808: don't mean to rag on the design at all, just trying to understand.  800 vhosts is certainly a lot, but surely people do it?
[01:21:07] <AndyRussG>	 wooho yeah I remember now ejegg|away mentioned that doc
[01:21:08] <bd808>	 cwd: but changing the docroot would need a service restart across the fleet
[01:21:20] <bd808>	 and that would be teh suxor
[01:21:52] <bd808>	 now we could do things in some other way to update from version to version
[01:22:16] <cwd>	 yeah that makes sense
[01:22:37] <cwd>	 does restarting apache bust any caches varnish side?
[01:22:43] <bd808>	 also we have hundreds of configuration differences from wiki to wiki that multiversion hides
[01:23:43] <bd808>	 no it wouldn't effect varnish other than breaking any inflight backend requests (unless graceful and then you don't know when the restart will really happen)
[01:24:46] <cwd>	 gotcha, yeah it goes deep
[01:25:00] <bd808>	 But you can blame Tim, Chad and Brad for most of the horrors of multiversion
[01:25:17] <bd808>	 and you can blame Tim and Brion for most of the horrors of MW ;)
[01:26:05] <cwd>	 eh, it's not like there's something better
[01:26:29] <cwd>	 i think this is what software that actually gets used is like
[01:26:45] <bd808>	 largely, yeah
[01:27:52] <bd808>	 At $DAYJOB-1 they decided to rewrite all of the legacy code that the founder wrote. It took 4 years and 10 engineers and they recreated a zillion solved bugs in the process
[01:28:26] <bd808>	 and the end result was a big pile of Java replacing a moderate amount of PHP
[01:29:01] <cwd>	 yep.  lots of projects have beautiful, elegant design until it's exposed to users and made to be usable
[01:29:50] <cwd>	 and total rewrites are pretty much like when a band re-records their hit record as geezers
[01:31:25] <grrrit-wm>	 (PS1) Eileen: CiviCRM submodule update [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/277942
[01:31:32] <bd808>	 lol. this one was because a VC told them that PHP wasn't reliable enough to invest in
[01:31:48] <bd808>	 which is hysterical in so many ways
[01:31:58] <grrrit-wm>	 (CR) Eileen: [C: 2] "Self-approving, merge commit" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/277942 (owner: Eileen)
[01:32:29] <cwd>	 bd808: they said that about C too
[01:38:13] <wikibugs>	 Fundraising-Backlog, MediaWiki-Vagrant: Fix fundraising tests under mw-vagrant - https://phabricator.wikimedia.org/T130171#2128295 (cwdent)
[02:27:21] <wikibugs>	 Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 6 others: Civi exports timing out - https://phabricator.wikimedia.org/T120892#1864231 (Eileenmcnaughton) I've increased the limit further - I was go...
[03:09:16] <wikibugs>	 Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Take timings to help with Civi optimization - https://phabricator.wikimedia.org/T109026#2128366 (Eileenmcnaughton) Open>Resolved a:Eileenmcnaughton I'm closing this out as I don't think it's relevant now - that particular patch is fixed &...
[03:10:18] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: LYBUNT query cleanup - https://phabricator.wikimedia.org/T119036#1816336 (Eileenmcnaughton) The latest version of the core Lybunt (after fixes) is taking around 15 seconds - half of which relates to resolving the group - so I think this might be OK to c...
[03:11:11] <wikibugs>	 Fundraising-Backlog: Recent up tick in fail mail - https://phabricator.wikimedia.org/T126482#2128373 (Eileenmcnaughton)
[03:11:13] <wikibugs>	 Fundraising-Analysis, Wikimedia-Fundraising-CiviCRM: Probably cause of failmail deadlocks - soft credit search pain - https://phabricator.wikimedia.org/T130068#2128374 (Eileenmcnaughton)
[03:13:54] <wikibugs>	 Fundraising-Backlog: Apply CRM-18120 potential deadlock fix - https://phabricator.wikimedia.org/T130173#2128377 (Eileenmcnaughton)
[03:14:06] <wikibugs>	 Fundraising Sprint Freshmaking, Fundraising-Backlog: Apply CRM-18120 potential deadlock fix - https://phabricator.wikimedia.org/T130173#2128377 (Eileenmcnaughton)
[03:15:03] <awight>	 eileen: if you're still working on that deployment, I responded to yr email
[03:16:35] <eileen>	 awight: ah - thanks. I'll see if my brain feels up to processing it
[03:18:06] <grrrit-wm>	 (PS1) Awight: Revert "Thank You letters for executive director transition" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/277946
[03:18:30] <eileen>	 awight: Ah thanks!
[03:18:39] <awight>	 eileen: sure!
[03:18:53] <awight>	 just merge that patch whenever you're ready to do your deployment
[03:19:05] <awight>	 actually, since we're revlocked anyway I might as well do it
[03:19:06] <grrrit-wm>	 (CR) Eileen: [C: 2] Revert "Thank You letters for executive director transition" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/277946 (owner: Awight)
[03:19:14] <grrrit-wm>	 (CR) Awight: [C: 2] Revert "Thank You letters for executive director transition" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/277946 (owner: Awight)
[03:19:24] <awight>	 et voila :-)
[03:19:24] <grrrit-wm>	 (Merged) jenkins-bot: Revert "Thank You letters for executive director transition" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/277946 (owner: Awight)
[03:21:20] <eileen>	 awight: OK - the message on boron is still wierd but…
[03:21:36] <awight>	 deploy like: fundraising_code_update -p civicrm=HEAD
[03:21:47] <awight>	 (use -h for more arg syntax)
[03:22:09] <awight>	 I think the message is trying to say, "your deployment won't happen cos we're locked to a revision"
[03:22:51] <eileen>	 ah I see
[03:23:50] <eileen>	 !log Updated CiviCRM from c99abc42188b7f47726202b4740fbaf68d1c06ab to 18431eec74de251066deb77d5b63607e06f6f135
[03:23:56] <morebots>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master
[03:28:24] <grrrit-wm>	 (CR) Eileen: "We probably do need to decide where to record these timings for tracking over time. I just re-ran & got" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/273179 (https://phabricator.wikimedia.org/T127133) (owner: Eileen)
[03:30:11] <awight>	 eileen: sorry to ask, but you're doing timing on the staging server, right?
[03:30:46] <eileen>	 awight: Yep :-)
[03:31:01] <eileen>	 In fact it won't even run on live because I put the dataset in the tests folder
[03:32:41] <grrrit-wm>	 (PS2) Eileen: CRM-18120 make acl query less debilitating [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277439 (https://phabricator.wikimedia.org/T130173)
[03:32:51] <awight>	 whew!
[03:33:16] <awight>	 thanks, the timing relative to deployment raised my hackles, is all ;-)
[03:33:30] <awight>	 suddenly, a cold breeze came through the closed window
[03:33:47] <eileen>	 ah right -no all good
[03:34:31] <grrrit-wm>	 (CR) Eileen: "One more run ... on staging ... to check for variance" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/273179 (https://phabricator.wikimedia.org/T127133) (owner: Eileen)
[03:35:09] <awight>	 One of the funniest fails of that nature was when I tested the queue consumer on staging--after copying the production queue server value over via a db dump
[03:35:31] <awight>	 happily, we have good auditing
[03:36:16] <wikibugs>	 Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 6 others: Civi exports timing out - https://phabricator.wikimedia.org/T120892#2128412 (Eileenmcnaughton) OK - timeout for exports is now 10 minutes!...
[03:37:13] <eileen>	 yeah the 'do something on the wrong server' is always scary!
[03:38:36] <awight>	 I have this deep-seated paranoia that causes me to type the filenames I want to rm, then I go back to the start of the line and type "rm " only if the coast is clear
[03:38:56] <awight>	 the return key is positively magnetic if there are naughty things on the commandline
[03:39:21] <awight>	 rm -rf / home/awight  eeehehe
[03:41:59] <eileen>	 probably a heathy paranoia
[03:42:50] <awight|distracto>	 If only I could do that with other things in life
[04:13:44] <grrrit-wm>	 (PS2) Awight: [WIP] Encapsulate Ingenico staging functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277936
[04:15:31] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] [WIP] Encapsulate Ingenico staging functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277936 (owner: Awight)
[04:18:13] <wikibugs>	 Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising-Backlog: Civi: batch import of refunds, problem transaction: currency switched - https://phabricator.wikimedia.org/T127979#2128439 (Eileenmcnaughton) I just looked into this and I tried to think about what *should...
[04:38:07] <grrrit-wm>	 (PS1) Eileen: Store refund mismatch converted to USD [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277947 (https://phabricator.wikimedia.org/T127979)
[04:40:06] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Store refund mismatch converted to USD [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277947 (https://phabricator.wikimedia.org/T127979) (owner: Eileen)
[04:44:41] <grrrit-wm>	 (PS2) Eileen: Store refund mismatch converted to USD [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277947 (https://phabricator.wikimedia.org/T127979)
[04:47:00] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Store refund mismatch converted to USD [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277947 (https://phabricator.wikimedia.org/T127979) (owner: Eileen)
[04:55:58] <grrrit-wm>	 (PS3) Eileen: Store refund mismatch converted to USD [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277947 (https://phabricator.wikimedia.org/T127979)
[04:57:51] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Store refund mismatch converted to USD [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277947 (https://phabricator.wikimedia.org/T127979) (owner: Eileen)
[05:20:33] <grrrit-wm>	 (PS4) Eileen: Store refund mismatch converted to USD [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277947 (https://phabricator.wikimedia.org/T127979)
[05:21:53] <grrrit-wm>	 (CR) Eileen: "This is now failing on exchange rate calculation - not quite sure how to manage that in the test scenario" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277947 (https://phabricator.wikimedia.org/T127979) (owner: Eileen)
[05:22:22] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Store refund mismatch converted to USD [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277947 (https://phabricator.wikimedia.org/T127979) (owner: Eileen)
[05:34:37] <grrrit-wm>	 (PS5) Eileen: Store refund mismatch converted to USD [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277947 (https://phabricator.wikimedia.org/T127979)
[05:35:03] <wikibugs>	 Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising-Backlog: Civi: batch import of refunds, problem transaction: currency switched - https://phabricator.wikimedia.org/T127979#2128508 (Eileenmcnaughton) I pushed up a patch & test on this but the test is snarled up o...
[05:36:59] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Store refund mismatch converted to USD [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277947 (https://phabricator.wikimedia.org/T127979) (owner: Eileen)
[07:35:25] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: LYBUNT query cleanup - https://phabricator.wikimedia.org/T119036#2128557 (XenoRyet) Agreed. The Lybunt has evolved in ways that make this ticket no longer relevant.  I'll go ahead and close it.
[07:35:58] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: LYBUNT query cleanup - https://phabricator.wikimedia.org/T119036#2128558 (XenoRyet) Open>Invalid
[09:29:00] <wikibugs>	 Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising-Backlog, Patch-For-Review: Deploy Thank you letters to remove Lila's signature - https://phabricator.wikimedia.org/T129373#2128676 (jrobell) Thank you very much @Ejegg for working on this.   Keeping "Jimmy Wal...
[12:13:50] <grrrit-wm>	 (PS3) Awight: Encapsulate Ingenico staging functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277936 (https://phabricator.wikimedia.org/T130075)
[12:45:40] <grrrit-wm>	 (PS5) Awight: Encapsulate AstroPay staging methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277705 (https://phabricator.wikimedia.org/T130075)
[12:45:42] <grrrit-wm>	 (PS2) Awight: Generalize data transformations [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277845 (https://phabricator.wikimedia.org/T130075)
[12:45:44] <grrrit-wm>	 (PS1) Awight: Put all extra transaction keys in submethod meta [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277978
[12:45:46] <grrrit-wm>	 (PS1) Awight: Clean up, add accessors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277979
[12:45:48] <grrrit-wm>	 (PS1) Awight: Make BrazilianFiscalNumber staging reusable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277980
[12:45:50] <grrrit-wm>	 (PS1) Awight: Split ContributionTrackingPlusUnique into a reusable thing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277981
[12:45:52] <grrrit-wm>	 (PS1) Awight: Split out language staging [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277982
[12:45:54] <grrrit-wm>	 (PS1) Awight: Finish encapsulating Ingenico staging logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277983
[12:46:30] <grrrit-wm>	 (PS2) Awight: Clean up, add accessors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277979 (https://phabricator.wikimedia.org/T130075)
[12:46:32] <grrrit-wm>	 (PS6) Awight: Encapsulate AstroPay staging methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277705 (https://phabricator.wikimedia.org/T130075)
[12:46:34] <grrrit-wm>	 (PS2) Awight: Put all extra transaction keys in submethod meta [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277978 (https://phabricator.wikimedia.org/T130075)
[12:46:36] <grrrit-wm>	 (PS2) Awight: Split ContributionTrackingPlusUnique into a reusable thing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277981 (https://phabricator.wikimedia.org/T130075)
[12:46:38] <grrrit-wm>	 (PS2) Awight: Make BrazilianFiscalNumber staging reusable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277980 (https://phabricator.wikimedia.org/T130075)
[12:46:40] <grrrit-wm>	 (PS3) Awight: Generalize data transformations [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277845 (https://phabricator.wikimedia.org/T130075)
[12:46:42] <grrrit-wm>	 (PS2) Awight: Finish encapsulating Ingenico staging logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277983 (https://phabricator.wikimedia.org/T130075)
[12:47:41] <grrrit-wm>	 (CR) Awight: "@cwd heads-up, minor merge conflict" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277978 (https://phabricator.wikimedia.org/T130075) (owner: Awight)
[12:48:57] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Generalize data transformations [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277845 (https://phabricator.wikimedia.org/T130075) (owner: Awight)
[12:49:31] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Make BrazilianFiscalNumber staging reusable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277980 (https://phabricator.wikimedia.org/T130075) (owner: Awight)
[12:49:41] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Split ContributionTrackingPlusUnique into a reusable thing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277981 (https://phabricator.wikimedia.org/T130075) (owner: Awight)
[12:49:54] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Split out language staging [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277982 (https://phabricator.wikimedia.org/T130075) (owner: Awight)
[12:50:06] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Finish encapsulating Ingenico staging logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277983 (https://phabricator.wikimedia.org/T130075) (owner: Awight)
[12:59:00] <grrrit-wm>	 (PS1) Awight: Encapsulate PayPal staging logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277985 (https://phabricator.wikimedia.org/T130075)
[13:29:28] <grrrit-wm>	 (PS1) Awight: Encapsulate Worldpay staging logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277988
[13:29:30] <grrrit-wm>	 (PS1) Awight: [WIP] Remove old staging code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277989
[13:31:40] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] [WIP] Remove old staging code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277989 (owner: Awight)
[13:32:38] <grrrit-wm>	 (Abandoned) Awight: [WIP] Encapsulate Ingenico staging logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277861 (owner: Awight)
[13:44:54] <wikibugs>	 Fundraising-Backlog, FR-Worldpay: Worldpay donation form error - no transactions processing - https://phabricator.wikimedia.org/T130206#2129509 (MBeat33)
[16:20:35] <awight>	 dstrine: I tried two hangouts and neither is the right one...
[16:21:05] <awight>	 can you paste the URL here?
[16:21:06] <dstrine>	 awight:  there was something wrong with the invite
[16:21:13] <dstrine>	 I just sent you the call we are on
[16:21:30] <awight>	 That went to my phone
[16:42:57] <cwd>	 awight: you in a mtg?
[16:43:02] <cwd>	 also...did you stay up all night?
[16:57:56] <awight>	 cwd: oh hey
[16:57:58] <awight>	 what night
[16:58:13] <awight>	 no... I got sleepjacked reading my kid to bed, though
[16:58:22] <awight>	 so woke up at 3:30 with nuthin' to do
[16:58:57] <wikibugs>	 Fundraising-Backlog, FR-Adyen: Updates to Adyen form so that it matches Ingenico - https://phabricator.wikimedia.org/T128541#2130225 (atgo)
[16:59:43] <cwd>	 heh nice
[16:59:58] <cwd>	 can i regale you with a quick tale?
[17:00:01] <awight>	 feel free to merge any of that stuff
[17:00:02] <awight>	 totes
[17:00:07] <cwd>	 https://www.mediawiki.org/wiki/Fundraising_tech#Running_PHPUnit_tests_under_vagrant
[17:00:26] <cwd>	 this doesn't actually work...i edited the page there cause it was missing defined() and so it just ran every time
[17:00:27] <awight>	 baaaaa
[17:00:41] <cwd>	 but when you add the defined it doesn't actually run
[17:00:43] <awight>	 I saw that diff on the train
[17:00:49] <awight>	 wait, what
[17:00:56] <awight>	 then it's not a var
[17:00:58] <cwd>	 like that const is not making it from phpunit.php to Localsettings
[17:01:06] <cwd>	 it gets set at the top of our phpunit wrapper
[17:01:12] <awight>	 holy cow.
[17:01:13] <awight>	 looking
[17:01:13] <cwd>	 but is it shelling out a new php or something?
[17:01:18] <awight>	 O_o
[17:01:24] <cwd>	 i crashed and burned on this
[17:01:32] <awight>	 try dumping the environment variables
[17:01:49] <awight>	 hydroponic freaking rabbithole...
[17:03:16] <cwd>	 also my udev rules stopped working when i apt-get upgraded
[17:03:23] <cwd>	 #unstable
[17:03:34] <cwd>	 so i wasted some time on that too
[17:03:56] <awight>	 rash.
[17:04:01] <awight>	 bold
[17:05:48] <awight>	 What gives.  Now I'm stuck at Couldn't find a usable PHPUnit.
[17:05:59] <cwd>	 composer install?
[17:06:07] <awight>	 nothing happens
[17:06:40] <cwd>	 hrm...
[17:07:26] <awight>	 well, provision dies.  ==> default: Error: Could not update: Execution of '/usr/bin/apt-get -q -y -o DPkg::Options::=--fo
[17:07:29] <awight>	 rce-confold install hhvm' returned 100: Reading package lists...
[17:07:33] <awight>	 so I'll just recreate the VM :(
[17:07:51] <awight>	 auuugh it's the fss.so error
[17:08:21] <awight>	 gotta swap hard drives, brb
[17:14:10] <cwd>	 https://xkcd.com/349/
[17:15:42] <awight|luscrew>	 yes.  I just discovered I need to pry my brand-new rubber feet off.
[17:23:41] <cwd>	 anyway yeah i dumped it and that const is just not there
[17:32:57] <cwd>	 i got a friend in town, gonna go get lunch, back in a bit
[17:49:41] <wikibugs>	 Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog: MW-Vagrant CRM role needs maintenance - https://phabricator.wikimedia.org/T110372#2130438 (awight)
[17:51:00] <wikibugs>	 Fundraising-Backlog, MediaWiki-Vagrant: Fix fundraising tests under mw-vagrant - https://phabricator.wikimedia.org/T130171#2130441 (awight)
[17:51:02] <wikibugs>	 Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog: MW-Vagrant CRM role needs maintenance - https://phabricator.wikimedia.org/T110372#1576476 (awight)
[17:51:09] <wikibugs>	 Fundraising-Backlog, MediaWiki-Vagrant: Fix fundraising PHPUnit tests under mw-vagrant - https://phabricator.wikimedia.org/T130171#2128295 (awight)
[17:55:10] <bd808>	 awight: the fss.so thing is a damed if we do, damed if we don't problem right now :/
[17:56:05] <awight>	 ok, provisioning twice isn't a big deal then.
[17:56:13] <bd808>	 If it was a controlled fleet I would have put the ordering back already. I'm not sure how long to keep it in the who-knows-who-will-be-broken world today
[17:56:19] <awight>	 The PHPUnit thing is currently killing the whole team, though :(
[17:56:40] <awight>	 I'll try to make a patch for that...
[17:57:18] <bd808>	 cool. I think that the logic we looked up last night can be default for everyone
[17:57:36] <bd808>	 stas ran into it a few days ago testing cirrussearch things too
[17:58:02] <awight>	 brand new error when running phpunit.php... > The mwscript command must be used in multiwiki setups.
[17:59:17] <bd808>	 awight: argh. that's from https://gerrit.wikimedia.org/r/#/c/276403/
[17:59:31] <bd808>	 which is a feature I didn't really want in the first place :/
[17:59:59] * awight clouds
[18:00:36] <awight>	 bd808: Do you happen to know if there's a workaround?
[18:00:56] <bd808>	 jump up and down and scream?
[18:01:08] <awight>	 d'oh
[18:01:10] <awight>	 I tried that
[18:03:22] <bd808>	 multiversion needs to be loaded. The defined( 'MW_PHPUNIT_TEST' ) trick
[18:03:33] <bd808>	 that should fix it I think?
[18:04:07] <bd808>	 but that needs to happen before CommonSettings loads ...
[18:04:46] <bd808>	 So it needs to com before line 96 of the root LocalSettings.php
[18:04:49] <awight>	 hehe, I moved it to the head of LocalSettings and that works
[18:04:52] <awight>	 thx
[18:05:08] <bd808>	 a patch to add that for everyone would be nice
[18:05:16] <bd808>	 I can make it if you don't have time
[18:05:20] <awight>	 Couldn't find a usable PHPUnit.
[18:05:26] <awight>	 I can add that, no problem.
[18:05:32] <awight>	 I'm just verifying that it does the trick
[18:05:57] <bd808>	 In 1.27 PHPUnit comes from mediawiki/vendor
[18:06:15] <bd808>	 before that... I don't remember how we loaded it
[18:06:22] <awight>	 me neither
[18:06:39] <awight>	 by burning oxen bones, I believe
[18:06:49] * bd808 runs off to a meeting
[18:07:06] * awight shakes pail of powered bone slop
[18:22:34] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi Prospect Field - Saving Error - https://phabricator.wikimedia.org/T107087#2130544 (awight) Here's some text to paste into the prospect panes (use the source editor), which will reproduce the bug: ``` <script type="text/javascript"> var CRM = {"conf...
[18:49:15] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi Prospect Field - Saving Error - https://phabricator.wikimedia.org/T107087#2130701 (awight) I think we can get rid of the "suspicious activity" warning by setting "CiviCRM: skip IDS check" for all admin and tech roles.
[18:50:35] <wikibugs>	 Fundraising Sprint Freshmaking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Civi Prospect Field - Saving Error - https://phabricator.wikimedia.org/T107087#2130704 (awight)
[18:51:45] <wikibugs>	 Fundraising Sprint Freshmaking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Civi Prospect Field - Saving Error - https://phabricator.wikimedia.org/T107087#1486277 (awight) @CaitVirtue Ready for testing!
[18:54:37] <wikibugs>	 Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog: MW-Vagrant CRM role needs maintenance - https://phabricator.wikimedia.org/T110372#2130715 (awight) Resolved>Open
[18:56:04] <wikibugs>	 Fundraising-Backlog, MediaWiki-Vagrant: Static resources not loading for nonprimary multiwikis - https://phabricator.wikimedia.org/T130243#2130716 (awight)
[19:00:36] <cwd>	 awight: it works at the top of localsettings but not the bottom?
[19:00:48] <awight>	 yeah.
[19:01:05] <awight>	 cwd: Try https://gerrit.wikimedia.org/r/278050
[19:01:16] <awight>	 We're 90% of the way, with that patch
[19:03:01] <cwd>	 awight: it works with defined() at the top?  i can see how moving it to the top would stop double multiversioning
[19:03:23] <awight>	 I put it in another file, even
[19:03:38] <awight>	 just cos that was easier to do with the existing puppet templates.
[19:05:12] <cwd>	 ah ha
[19:05:22] <cwd>	 so just apply that and provision again?
[19:05:25] <awight>	 yah
[19:09:41] <cwd>	 awight: yep nice.  do you know why that const gets lost before localsettings?
[19:10:12] <awight>	 it seems to work
[19:10:37] <awight>	 I noticed that your fix had another bug--the constant name should have been in quotes.  though, that shouldn't have affected the results
[19:10:46] <cwd>	 totally works in that CommonSettings file
[19:10:52] <awight>	 So, now I'm stuck on phpunit not finding the extension tests
[19:10:59] <awight>	 you happen to remember what that is?
[19:11:10] <cwd>	 hmm, what's the error?
[19:11:15] <awight>	 I've had that rash before.
[19:11:17] <cwd>	 wait, does it say 0 tests run?
[19:11:22] <awight>	 sudo -u www-data MW_INSTALL_PATH=/vagrant/mediawiki-fr php5 tests/phpunit/phpunit.php  --wiki paymentswiki --group DonationInterface
[19:11:25] <awight>	 PHPUnit 3.7.28 by Sebastian Bergmann.
[19:11:25] <awight>	 yep.
[19:11:28] <awight>	 Configuration read from /vagrant/mediawiki-fr/tests/phpunit/suite.xml
[19:11:31] <awight>	 Time: 18.68 seconds, Memory: 122.00Mb
[19:11:33] <awight>	 No tests executed!
[19:11:36] <awight>	 I was like, THIS IS THE FR DIR
[19:11:50] <cwd>	 yeah so that's what happened to me when that const isn't set
[19:11:53] <awight>	 oh.
[19:11:57] <awight>	 lemme set to true
[19:12:00] <cwd>	 and multiversion doesn't get loaded
[19:12:34] <cwd>	 i still get 1 weird failure when the tests run
[19:13:15] <awight>	 still doesn't run for me, with that conditional hotwired to true.
[19:13:27] <awight>	 what's your winning commandline?
[19:13:44] <cwd>	 just the one from that page: ./phpunit.php --wiki paymentswiki --group DonationInterface
[19:15:22] <awight>	 nope
[19:15:57] <cwd>	 awight: mine doesn't find the tests unless i'm in that directory
[19:16:03] <cwd>	 tests/phpunit
[19:19:47] <awight>	 I am so depressed about this.
[19:19:55] <awight>	 gonna sit in the sun with a burrito, see ya soon
[19:21:04] <awight>	 feel like CR'ing some of my patchspam?
[19:21:57] <cwd>	 sure
[19:35:14] <grrrit-wm>	 (CR) AndyRussG: "All good, save an inline comment to update :) Thx!!!" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/254326 (https://phabricator.wikimedia.org/T111456) (owner: Krinkle)
[19:37:24] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: wrap LocalStorage access in try/catch to prevent errors on w/ cookies (& LS) disabled - https://phabricator.wikimedia.org/T120384#2130917 (AndyRussG) Open>Resolved
[19:38:36] <grrrit-wm>	 (CR) Cdentinger: [C: 2] "Cool, I built the new yaml from these files and will put them on the other patch." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277978 (https://phabricator.wikimedia.org/T130075) (owner: Awight)
[19:46:53] <grrrit-wm>	 (CR) Cdentinger: [C: 2] Clean up, add accessors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277979 (https://phabricator.wikimedia.org/T130075) (owner: Awight)
[19:52:08] <awightfud>	 Thanks!
[19:52:51] <cwd>	 for shore
[19:54:01] <awight>	 four shore and many dingys ago
[19:54:30] <cwd>	 *dinghy
[19:54:32] * awight glares increasingly glaringly at vagrant phpunit prompt
[19:54:34] <awight>	 hehe thx
[19:54:41] <awight>	 dingy dinghy
[19:54:42] <cwd>	 heheh
[19:54:51] <cwd>	 that could be a good irish folk song
[19:55:34] <awight>	 cwd: btw I do get the constant.
[19:55:52] <cwd>	 if you check for it in localsettings??
[19:55:54] <awight>	 error_log("XXX " . var_export(MW_PHPUNIT_TEST,true));
[19:55:59] <awight>	 in CommonSettings
[19:56:05] <cwd>	 ah, yeah it works for me there too
[19:56:05] <awight>	 [Thu Mar 17 19:55:22 2016] [hphp] [30051:7fb63c1a4100:0:000001] [] XXX true
[19:56:08] <cwd>	 but not localsettings
[19:56:09] <awight>	 ah.
[19:56:43] <awight>	 well, I'm still stuck with blasted extension tests not running.  maybe it's something incredibly stupid like needing to checkout the DI submodule.
[19:57:15] <awight>	 oh.
[19:57:16] <awight>	 oh
[19:57:30] <awight>	 I'm on the deployment branch.  no tests.
[19:58:00] <cwd>	 haha, shit
[19:58:29] <cwd>	 ok lmk if you get a failure having to do with protocol on a url
[19:59:54] <awight>	 done D
[20:00:03] <wikibugs>	 Fundraising Sprint Freshmaking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Civi Prospect Field - Saving Error - https://phabricator.wikimedia.org/T107087#2131034 (atgo) a:awight
[20:00:09] <awight>	 bd808: I think we're good, once that vagrant patch is merged.  Thanks!
[20:00:18] <wikibugs>	 Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising-Backlog, Unplanned-Sprint-Work, WMF FR: Ingenico ePayments Partners with Trustwave for PCI Compliance - https://phabricator.wikimedia.org/T129596#2131039 (atgo) a:awight
[20:00:40] <awight>	 cwd: 10-4
[20:00:40] <awight>	 -'//payments.wiki.local.wmftest.net:8080/wiki/Special:FundraiserMaintenance'
[20:00:43] <awight>	 +'http://payments.wiki.local.wmftest.net:8080/wiki/Special:FundraiserMaintenance'
[20:00:52] <cwd>	 yeah
[20:01:08] <awight>	 I think there's a setting for that... weird.
[20:01:18] <awight>	 protocol relative mumble mumble
[20:01:18] <cwd>	 it's gotta be local to vagrant though
[20:01:28] <cwd>	 cause i don't get it elsewhere
[20:01:39] <awight>	 yeah.  Annoying, but at least it's a number of failures less than 100%
[20:01:46] <bd808>	 yeah mw-v does that
[20:02:11] <awight>	 we probably just need to jiggle our tests.
[20:02:24] <cwd>	 yeah
[20:08:33] <grrrit-wm>	 (Merged) jenkins-bot: Put all extra transaction keys in submethod meta [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277978 (https://phabricator.wikimedia.org/T130075) (owner: Awight)
[20:08:37] <grrrit-wm>	 (Merged) jenkins-bot: Clean up, add accessors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277979 (https://phabricator.wikimedia.org/T130075) (owner: Awight)
[20:20:17] <wikibugs>	 Fundraising-Backlog, MediaWiki-Vagrant, Patch-For-Review: Fix fundraising PHPUnit tests under mw-vagrant - https://phabricator.wikimedia.org/T130171#2131159 (bd808) a:awight
[20:34:36] <wikibugs>	 Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 4 others: Move staging functions into helper classes - https://phabricator.wikimedia.org/T130075#2124621 (awight) I believe @Ejegg was looking at the Adyen...
[20:38:28] <K4-713>	 Urf. I feel like I'm getting sick or something.
[20:39:32] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, MediaWiki-extensions-DonationInterface: [Epic] SPOF: Replace ActiveMQ donation queues with Redis - https://phabricator.wikimedia.org/T108229#2131360 (awight) I should mention that I used a similar migration strategy for the...
[20:39:38] <awight>	 K4-713: sorry to hear it!
[20:40:03] <K4-713>	 awight: How are things over there?
[20:40:21] <awight>	 it's been a tough day, I started at... 3:30 or so
[20:40:28] <awight>	 otherwise good, though!
[20:52:33] <wikibugs>	 Fundraising-Backlog, FR-Smashpig: Create SmashPig PhpQueueDataStore compatible with StompDataStore - https://phabricator.wikimedia.org/T129386#2131571 (awight)
[20:56:17] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops: [Epic] Provision high-availability Redis cluster for Fundraising - https://phabricator.wikimedia.org/T130283#2131633 (awight)
[20:58:16] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops, MediaWiki-extensions-DonationInterface: [Epic] SPOF: Replace ActiveMQ donation queues with Redis - https://phabricator.wikimedia.org/T108229#1515750 (awight)
[21:00:02] <dstrine>	 awight: cwd AndyRussG XenoRyet I'm going to make a few phab tags that may help organization in the future: "FR-PCI" "FR-Paypal-Upgrade" "FR-ActiveMQ" Do those sound like good names for the upcoming work?
[21:00:39] <dstrine>	 This will allow us to filter the backlog for these projects
[21:00:59] <XenoRyet>	 Yea, seem like sensible choices to me.
[21:01:27] <cwd>	 sure sounds good
[21:01:34] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Payments should mirror outbound queue messages to both ActiveMQ and Redis - https://phabricator.wikimedia.org/T130287#2131709 (awight)
[21:02:49] <awight>	 dstrine: That works for me.  Maybe "FR-PayPal-ExpressCheckout", though?
[21:03:20] <dstrine>	 awight ok cool ... that's more specific
[21:05:07] <awight>	 dstrine: also fwiw, I think FR-Queues would be a useful tag going forward, but FR-ActiveMQ is appealing because it's designed to become obsolete in a few months.
[21:17:20] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops: Spike: Investigate suitability of Kafka instead of Redis - https://phabricator.wikimedia.org/T130304#2132042 (awight)
[21:19:27] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Migrate a single, low-volume queue consumer to Redis - https://phabricator.wikimedia.org/T130306#2132077 (awight)
[21:20:17] <cwd>	 awight: while yak shaving i managed to get a stack overflow from php...i'm starting to think there isn't a way to do this
[21:20:32] <cwd>	 avoid defining this method on every class i mean
[21:21:28] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops: [Epic] Provision high-availability Redis cluster for Fundraising - https://phabricator.wikimedia.org/T130283#2132099 (awight)
[21:22:00] <awight>	 cwd: mind if I hack on the WIP for a second?
[21:22:07] <cwd>	 go for it
[21:22:13] <cwd>	 i've got one more idea...
[21:22:16] <awight>	 is the latest up for review?
[21:23:57] <cwd>	 uuh, i've got some changes but nothing worth pushing
[21:24:09] <wikibugs>	 Fundraising-Backlog: fundraising-tools queue operations should use Redis - https://phabricator.wikimedia.org/T130308#2132120 (awight)
[21:24:29] <awight>	 Not trying to take it over or anything, I just wanted to try the thing I was imagining.
[21:24:40] <awight>	 k, I'll yak on the current WIPs
[21:24:51] <awight>	 as a follow-up patch so I'm not in your way...
[21:24:58] <cwd>	 yes please, either way is fine
[21:25:50] <awight>	 I thought 277800 was pretty dang close, fwiw
[21:27:03] <awight>	 (it even passes tests, whee!)
[21:27:32] <cwd>	 yeah, i'm reasonably sure it works as described
[21:27:57] <cwd>	 i do worry about edge cases with the yaml...but i don't really know how to search for them beyond running the tests
[21:28:03] <awight>	 I mean, squash and it's mergeable if you're okay with that.
[21:28:48] <cwd>	 sure thing
[21:28:59] <cwd>	 once i do it for all the adapters we can rip out some extra code too
[21:29:04] <cwd>	 (similar to your patch chain)
[21:29:05] <awight>	 It's certainly a huge improvement
[21:29:18] <cwd>	 i will place the new yaml files too
[21:29:28] <cwd>	 so we won't lose what your last patch did
[21:29:55] <cwd>	 i could also nest the config stuff under another member var
[21:30:33] <cwd>	 but yeah i can't find a way to not make a method on every child for spitting out the dir
[21:30:41] <cwd>	 unless there's a late static binding thing i'm missing
[21:32:42] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Spike: Plan a plugin architecture for DonationInterface - https://phabricator.wikimedia.org/T130311#2132176 (awight)
[21:33:21] <grrrit-wm>	 (PS5) Cdentinger: WIP: pull payment methods out of adapters into yaml config [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277706 (https://phabricator.wikimedia.org/T130056)
[21:33:48] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] WIP: pull payment methods out of adapters into yaml config [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277706 (https://phabricator.wikimedia.org/T130056) (owner: Cdentinger)
[21:34:06] <grrrit-wm>	 (Abandoned) Cdentinger: WIP move astropay payment methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277800 (owner: Cdentinger)
[21:34:23] <cwd>	 awight: they're both in 706 now, abandoned 800
[21:35:01] * cwd puts on rebase hat and gloves
[21:36:19] <grrrit-wm>	 (PS1) Awight: Use late static binding to get gateway base dir [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278086 (https://phabricator.wikimedia.org/T130056)
[21:36:21] <awight>	 It's horrible, but seems to work ^
[21:36:35] <awight>	 is that equally bad to you
[21:36:36] <awight>	 ?
[21:36:37] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Use late static binding to get gateway base dir [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278086 (https://phabricator.wikimedia.org/T130056) (owner: Awight)
[21:36:40] <awight>	 hahaha
[21:36:45] <awight>	 php version probably
[21:36:57] <awight>	 oh, it's just a rebase thing.
[21:37:43] <cwd>	 yeah i'm in the middle of an ugly one but you might be able to rebase on top of the new one cleanly once i finish
[21:37:57] <awight>	 I bet mine will rebase fine
[21:38:01] <cwd>	 that doesn't feel any worse to me
[21:38:14] <cwd>	 i was dreaming of keeping the test code contained in the tests
[21:38:22] <cwd>	 but it's not to be
[21:38:27] <awight>	 I missed that, lemme see...
[21:38:38] <awight>	 Where is the fail?
[21:38:59] <cwd>	 well i can't think of a way to override the parent method in the test class
[21:39:06] <cwd>	 since it gets called on the base class
[21:39:17] <cwd>	 and it's 2 levels down from there
[21:39:32] <awight>	 Why do we need to override?
[21:39:36] <awight>	 and, which method?
[21:39:45] <cwd>	 the one that returns __DIR__
[21:39:57] <cwd>	 i wanted a way to make the tests return the parent __DIR__
[21:40:02] <awight>	 they do!
[21:40:21] <cwd>	 well, only if you have that pasta in each parent
[21:40:32] <awight>	 which pasta?
[21:40:42] <cwd>	 const DIR = __DIR__ or whatever
[21:40:44] <cwd>	 or the method call
[21:40:46] <awight>	 oh.  whatev
[21:41:02] <cwd>	 yeah it works fine, it's not there for anything but making tests pass
[21:41:28] <awight>	 I'm totally missing what you're saying
[21:41:48] <awight>	 Is there an equivalent to snowblind, for trudging in a sewer?
[21:41:54] <awight>	 PHP.
[21:42:06] <cwd>	 like...a single method in gateway adapter can tell all the gateway classes where to find their config files, using reflection
[21:42:12] <awight>	 I just see "<?" and some critical frontal lobe turns off
[21:42:16] <cwd>	 but that same method when run against the test adapters will turn up the wrong dir
[21:42:27] <cwd>	 test_gateway/etc
[21:42:42] <awight>	 that isn't striking me as a big problem
[21:42:57] <cwd>	 yeah this is the siren song of class inheritance alright
[21:43:01] <awight>	 When we do https://phabricator.wikimedia.org/T130311, we'll have a helper object that can tell us all about the gateway subclass.
[21:43:21] <cwd>	 yeah, that works
[21:43:29] <cwd>	 i'll just move on
[21:43:39] <awight>	 I don't think there's any PHP reflection which tells you things about the filesystem
[21:45:00] <cwd>	 well what you can do is
[21:45:16] <cwd>	 $rc = new reflectionclass( get_class( $this ) )
[21:45:23] <awight>	 the reason I'm pushing so hard for config files to contain info about what they contain is to make it simple to convert arbitrary reference data, e.g. WorldPay iso currency codes.
[21:45:28] <cwd>	 dirname( $rc->getFilename() )
[21:45:33] <awight>	 grooos!
[21:45:38] <awight>	 but also sort of neat.
[21:45:51] <cwd>	 but yeah when $this is a test adapter
[21:45:56] <cwd>	 wrong directory
[21:46:31] <awight>	 gotcha, now
[21:46:54] <awight>	 The whole test adapter inheritance thing is a thousand locusts.
[21:47:18] <awight>	 I have this waiting for the apocalypse: https://gerrit.wikimedia.org/r/#/c/133508/
[21:47:26] <awight>	 +146, -477
[21:48:01] <cwd>	 yep i believe traits would fix this
[21:48:15] <cwd>	 but anyway the cost/benefit ratio has expired
[21:48:41] <awight>	 I'd rather have the test adapters inject poison using reflection, honestly.
[21:49:02] <AndyRussG|souper>	 Hmmm poison in a mirror
[21:49:12] <awight>	 screw this patriarchal inheritance hierarchy.
[21:49:14] <awight>	 ;)
[21:49:37] <grrrit-wm>	 (PS6) Cdentinger: WIP: pull payment methods out of adapters into yaml config [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277706 (https://phabricator.wikimedia.org/T130056)
[21:50:09] <cwd>	 yep
[21:50:15] <cwd>	 awight: hmm i hadn't thought of that...
[21:51:37] <awight>	 looks like globalcollect_gateway/config/payment_submethods.yaml may have regressed.
[21:51:55] <awight>	 it's missing the new keys
[21:52:01] <cwd>	 awight: yep sorry lemme fix that
[21:52:32] <grrrit-wm>	 (PS7) Cdentinger: WIP: pull payment methods out of adapters into yaml config [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277706 (https://phabricator.wikimedia.org/T130056)
[21:52:34] <awight>	 I'm gonna go home, might pop in to merge your patch later...  Thanks again!
[21:52:38] <cwd>	 that should do it
[21:52:47] <cwd>	 np!  i'll check out more of yours
[21:52:53] <cwd>	 thanks for the help
[21:54:00] <awight>	 likewise, I've been hoping this would happen for years, it's gonna make a big difference I hope
[21:54:03] <awight>	 hopefully
[21:54:06] <cwd>	 :)
[21:54:06] <awight>	 one can wish
[21:54:08] <awight>	 gtg
[22:02:49] <grrrit-wm>	 (PS4) Cdentinger: Encapsulate Ingenico staging functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277936 (https://phabricator.wikimedia.org/T130075) (owner: Awight)
[22:36:37] <grrrit-wm>	 (CR) Cdentinger: [C: 2] "A big step for cleanliness." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277936 (https://phabricator.wikimedia.org/T130075) (owner: Awight)
[22:37:32] <grrrit-wm>	 (PS7) Cdentinger: Encapsulate AstroPay staging methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277705 (https://phabricator.wikimedia.org/T130075) (owner: Awight)
[22:42:11] <grrrit-wm>	 (CR) Cdentinger: [C: 2] Encapsulate AstroPay staging methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277705 (https://phabricator.wikimedia.org/T130075) (owner: Awight)
[22:54:43] <grrrit-wm>	 (Merged) jenkins-bot: Encapsulate AstroPay staging methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277705 (https://phabricator.wikimedia.org/T130075) (owner: Awight)
[23:05:38] <grrrit-wm>	 (PS2) AndyRussG: Prevent notice in logs for custom hide cookie reasons [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/257811 (https://phabricator.wikimedia.org/T120890)
[23:05:53] <AndyRussG>	 Caminando por el campo, una vaca me encontré
[23:06:21] <grrrit-wm>	 (PS4) Cdentinger: Generalize data transformations [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277845 (https://phabricator.wikimedia.org/T130075) (owner: Awight)
[23:06:25] <AndyRussG>	 Como no tenía nombre, CentralNotice le pondré
[23:06:38] <AndyRussG>	 Oh, CentralNotice, ¡la vaca eres tú!
[23:06:46] <AndyRussG>	 Si te jalo de la cola, ¿qué dices tú?
[23:09:14] <grrrit-wm>	 (CR) Cdentinger: [C: 2] Generalize data transformations [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277845 (https://phabricator.wikimedia.org/T130075) (owner: Awight)
[23:10:24] <grrrit-wm>	 (Merged) jenkins-bot: Generalize data transformations [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277845 (https://phabricator.wikimedia.org/T130075) (owner: Awight)
[23:12:13] <grrrit-wm>	 (CR) Cdentinger: Encapsulate Ingenico staging functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277936 (https://phabricator.wikimedia.org/T130075) (owner: Awight)
[23:12:22] <grrrit-wm>	 (CR) Cdentinger: [C: 2] Encapsulate Ingenico staging functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277936 (https://phabricator.wikimedia.org/T130075) (owner: Awight)
[23:13:13] <cwd>	 doh, merge commit incoming
[23:14:31] <grrrit-wm>	 (PS5) Cdentinger: Encapsulate Ingenico staging functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277936 (https://phabricator.wikimedia.org/T130075) (owner: Awight)
[23:17:07] <grrrit-wm>	 (CR) Cdentinger: Encapsulate Ingenico staging functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277936 (https://phabricator.wikimedia.org/T130075) (owner: Awight)
[23:17:19] <grrrit-wm>	 (CR) Cdentinger: [C: 2] Encapsulate Ingenico staging functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277936 (https://phabricator.wikimedia.org/T130075) (owner: Awight)
[23:18:31] <grrrit-wm>	 (Merged) jenkins-bot: Encapsulate Ingenico staging functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277936 (https://phabricator.wikimedia.org/T130075) (owner: Awight)
[23:23:49] <wikibugs>	 Fundraising Sprint Freshmaking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Civi Prospect Field - Saving Error - https://phabricator.wikimedia.org/T107087#2132919 (CaitVirtue) Testing:  1. Added an Activity: Type: Meeting to record 96103.  In the description copy-pas...
[23:24:16] <wikibugs>	 Fundraising Sprint Freshmaking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Civi Prospect Field - Saving Error - https://phabricator.wikimedia.org/T107087#2132920 (CaitVirtue) Open>Resolved Based on my testing, I think this is fixed.  Marking it resolved.
[23:27:06] <wikibugs>	 Fundraising Sprint Freshmaking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Civi Prospect Field - Saving Error - https://phabricator.wikimedia.org/T107087#2132923 (atgo) Wahoo!
[23:34:58] <grrrit-wm>	 (PS8) Cdentinger: WIP: pull payment methods out of adapters into yaml config [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277706 (https://phabricator.wikimedia.org/T130056)
[23:53:31] <grrrit-wm>	 (PS1) Cdentinger: use config array in gateway_common [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278201
[23:53:40] <grrrit-wm>	 (PS9) Cdentinger: pull payment methods out of adapters into yaml config [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277706 (https://phabricator.wikimedia.org/T130056)
[23:54:41] <grrrit-wm>	 (PS2) Cdentinger: use config array in gateway_common [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278201
[23:54:54] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] use config array in gateway_common [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278201 (owner: Cdentinger)
[23:55:43] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] use config array in gateway_common [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278201 (owner: Cdentinger)
[23:58:02] <wikibugs>	 Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Performance: Move CentralNotice stuff out of cookies - https://phabricator.wikimedia.org/T108849#2132995 (ori) @AndyRussG, @awight, ping.