[00:00:17] (Abandoned) Cdentinger: use config array in gateway_common [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278201 (owner: Cdentinger) [00:16:49] (PS1) Cdentinger: move adyen payment methods to config [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278211 [00:41:52] (PS1) Cdentinger: move amazon payment methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278215 [00:45:08] (PS1) Cdentinger: move paypal payment methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278217 [01:52:54] (PS3) AndyRussG: Prevent notice in logs for custom hide cookie reasons [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/257811 (https://phabricator.wikimedia.org/T120890) [02:43:34] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Performance: Move CentralNotice stuff out of cookies - https://phabricator.wikimedia.org/T108849#2133233 (AndyRussG) @ori thx for the ping! It's not currently programmed for the near future, but I think we should be... [02:52:48] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Performance: Move CentralNotice stuff out of cookies - https://phabricator.wikimedia.org/T108849#2133234 (ori) >>! In T108849#2133233, @AndyRussG wrote: > @ori thx for the ping! It's not currently programmed for the... [03:43:23] (CR) Awight: [C: -1] "I would merge if not for the leakage from a staging_helpers patch. Other comments are all TODOs for a later iteration." (4 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277706 (https://phabricator.wikimedia.org/T130056) (owner: Cdentinger) [03:44:19] (CR) Awight: [C: 2] move adyen payment methods to config [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278211 (owner: Cdentinger) [03:45:11] (PS10) Awight: pull payment methods out of adapters into yaml config [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277706 (https://phabricator.wikimedia.org/T130056) (owner: Cdentinger) [03:46:18] (CR) Awight: "PS10: fix up rebase leakage. Hopefully this wasn't holding the house up." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277706 (https://phabricator.wikimedia.org/T130056) (owner: Cdentinger) [03:46:26] (CR) Awight: [C: 2] pull payment methods out of adapters into yaml config [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277706 (https://phabricator.wikimedia.org/T130056) (owner: Cdentinger) [03:47:28] (PS2) Awight: move adyen payment methods to config [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278211 (owner: Cdentinger) [03:47:53] (Merged) jenkins-bot: pull payment methods out of adapters into yaml config [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277706 (https://phabricator.wikimedia.org/T130056) (owner: Cdentinger) [03:48:10] (PS2) Awight: move amazon payment methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278215 (owner: Cdentinger) [03:48:34] (CR) Awight: [C: 2] move amazon payment methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278215 (owner: Cdentinger) [03:48:42] (PS2) Awight: move paypal payment methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278217 (owner: Cdentinger) [03:48:54] (CR) Awight: [C: 2] move paypal payment methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278217 (owner: Cdentinger) [03:50:09] (Merged) jenkins-bot: move adyen payment methods to config [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278211 (owner: Cdentinger) [03:50:16] (Merged) jenkins-bot: move amazon payment methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278215 (owner: Cdentinger) [03:51:27] (Merged) jenkins-bot: move paypal payment methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278217 (owner: Cdentinger) [14:22:28] (CR) Cdentinger: "@awight thanks for fixing and merging this! i will move everything to a loadConfig function once Worldpay (the last adapter) is updated, " [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277706 (https://phabricator.wikimedia.org/T130056) (owner: Cdentinger) [15:50:18] (PS1) Cdentinger: move worldpay payment methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278292 [15:56:15] (PS2) Ejegg: Revert "Thank You letters for executive director transition" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277900 (https://phabricator.wikimedia.org/T129373) [15:56:32] (CR) Ejegg: [C: 2 V: 2] "Self-merging own revert" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277900 (https://phabricator.wikimedia.org/T129373) (owner: Ejegg) [16:01:42] (PS1) Ejegg: Thank you letters for exec director transition [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/278293 (https://phabricator.wikimedia.org/T129373) [16:15:15] ejegg: how did getting the hardware out go? [16:15:45] That doc is swift! I was out of the hospital by 2:30 pm [16:15:58] pain's not too bad, either [16:16:26] good to hear [16:37:21] (PS1) Cdentinger: gateway_adapter&loadConfig() [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278298 [16:38:52] (CR) jenkins-bot: [V: -1] gateway_adapter&loadConfig() [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278298 (owner: Cdentinger) [16:47:23] (PS1) Ejegg: Fiscal numbers are not just for BR [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278305 (https://phabricator.wikimedia.org/T129552) [16:47:25] (PS1) Ejegg: Temporary measure: placeholder fiscal number for MX [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278306 (https://phabricator.wikimedia.org/T129552) [16:47:58] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising-Backlog, FR-Astropay, and 2 others: Remove fiscal number for Mexico form - https://phabricator.wikimedia.org/T129552#2134419 (Ejegg) [16:49:22] (CR) jenkins-bot: [V: -1] Temporary measure: placeholder fiscal number for MX [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278306 (https://phabricator.wikimedia.org/T129552) (owner: Ejegg) [16:51:44] (PS2) Ejegg: Temporary measure: placeholder fiscal number for MX [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278306 (https://phabricator.wikimedia.org/T129552) [16:54:45] Fundraising Sprint Freshmaking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work, Patch-For-Review: Fix up core logging spec - https://phabricator.wikimedia.org/T130161#2127955 (DStrine) [16:54:55] Fundraising Sprint Freshmaking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Improve the change log report - https://phabricator.wikimedia.org/T130164#2128006 (DStrine) [16:55:04] Fundraising Sprint Freshmaking, Fundraising-Backlog, Unplanned-Sprint-Work: Apply CRM-18120 potential deadlock fix - https://phabricator.wikimedia.org/T130173#2128377 (DStrine) [16:56:37] dunno why the heck this one doesn't blow up locally [17:03:49] XenoRyet, ejegg... awight seems to be offline... but: Meeting time? [17:03:58] Check your calendars. [17:04:11] oops, let me get set up! [17:04:22] sorry k4, dunno why i didn't get a phone alert [17:04:32] AndyRussG: You too. :p [17:04:52] K4-713: hi! [17:06:23] (PS2) Cdentinger: gateway_adapter&loadConfig() [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278298 [18:07:12] cwd / XenoRyet: couple tiny patches for astropay if either of you have a minute for CR: https://gerrit.wikimedia.org/r/278305 https://gerrit.wikimedia.org/r/278306 [18:07:22] Sure, I can take a look [18:07:28] thanks! [18:09:20] (CR) Ejegg: Enable fail page without adapter instance (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276218 (https://phabricator.wikimedia.org/T129376) (owner: Ejegg) [18:19:43] (CR) XenoRyet: [C: 2] Fiscal numbers are not just for BR [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278305 (https://phabricator.wikimedia.org/T129552) (owner: Ejegg) [18:20:43] (CR) XenoRyet: [C: 2] "Yea, do want to revert this as soon as they get the fix in, but this will do the job for now." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278306 (https://phabricator.wikimedia.org/T129552) (owner: Ejegg) [18:21:42] (Merged) jenkins-bot: Fiscal numbers are not just for BR [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278305 (https://phabricator.wikimedia.org/T129552) (owner: Ejegg) [18:22:04] (Merged) jenkins-bot: Temporary measure: placeholder fiscal number for MX [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278306 (https://phabricator.wikimedia.org/T129552) (owner: Ejegg) [18:23:44] Thanks XenoRyet [18:23:52] No worries [19:07:19] (PS2) Ejegg: Enable fail page without adapter instance [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276218 (https://phabricator.wikimedia.org/T129376) [19:07:21] (PS1) Ejegg: Get a better logger without adapter instance [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278335 (https://phabricator.wikimedia.org/T129376) [19:09:09] (CR) Ejegg: "PS2: redone from scratch on more recent commits" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276218 (https://phabricator.wikimedia.org/T129376) (owner: Ejegg) [19:24:46] (PS2) Ejegg: Get a better logger without adapter instance [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278335 (https://phabricator.wikimedia.org/T129376) [19:24:48] (PS6) Ejegg: Catch errors in adapter constructors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276222 (https://phabricator.wikimedia.org/T129376) [19:24:50] (PS3) Ejegg: Enable fail page without adapter instance [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276218 (https://phabricator.wikimedia.org/T129376) [19:26:04] (CR) Ejegg: "PS6: rebased onto new fail page logic, adapted to use new fallback logger retrieval" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276222 (https://phabricator.wikimedia.org/T129376) (owner: Ejegg) [19:29:09] (CR) Ejegg: "Superceded by I87b0e883b8933815334872a1dc94568c2243810f?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277980 (https://phabricator.wikimedia.org/T130075) (owner: Awight) [19:37:42] Fundraising Sprint Bloodletting 2016, Fundraising Sprint Freshmaking, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice impressions beacon corrupts 'mixins' property - https://phabricator.wikimedia.org/T120082#2135077 (AndyRussG) [19:50:11] qq [19:50:13] : [19:50:15] :q [19:50:29] derp, sorry [19:54:29] Fundraising-Backlog, Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Epic, and 3 others: Redo /beacon/impression system (formerly Special:RecordImpression) to remove extra round trips on all FR impressions (title was: S:RI should pyroperish... - https://phabricator.wikimedia.org/T45250#2135131 [19:58:00] Fundraising Sprint Freshmaking, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Summary of campaign settings changes is not logged in CentralNotice logs when modified using Special:CentralNotice main page table - https://phabricator.wikimedia.org/T110315#2135135 (AndyRuss... [20:00:21] Fundraising Sprint Freshmaking, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: Summary of campaign settings changes is not logged in CentralNotice logs when modified using Special:CentralNotice main page table - https://phabricator.wikimedia.org/T110315#1574836 (AndyRuss... [20:31:45] http://denver.craigslist.org/ctd/5487065872.html [20:32:44] nice [20:51:24] Wikimedia-Fundraising-CiviCRM: Override "Thank you already sent" notice when resending thank yous - https://phabricator.wikimedia.org/T28408#2135377 (DStrine) a:Awjrichards>None [20:52:31] Blocked-on-Fundraising-Tech, Wikimedia-Fundraising, Operations, Traffic, HTTPS: links.email.donate.wikimedia.org should offer HTTPS - https://phabricator.wikimedia.org/T74514#2135383 (Dzahn) https://links.email.donate.wikimedia.org/ links.email.donate.wikimedia.org uses an invalid security cert... [20:53:18] Fundraising Sprint Freshmaking, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Unplanned-Sprint-Work, Patch-For-Review: Summary of campaign settings changes is not logged in CentralNotice logs when modified using Special:CentralNotice m... - https://phabricator.wikimedia.org/T110315#2135384 [20:53:40] Blocked-on-Fundraising-Tech, Wikimedia-Fundraising, Operations, Traffic, HTTPS: links.email.donate.wikimedia.org should offer HTTPS - https://phabricator.wikimedia.org/T74514#2135385 (Dzahn) >>! In T74514#2054126, @CCogdill_WMF wrote: > It will be in use for another couple of weeks, until the Sw... [20:54:42] Blocked-on-Fundraising-Tech, Wikimedia-Fundraising, Operations, Traffic, HTTPS: links.email.donate.wikimedia.org should offer HTTPS - https://phabricator.wikimedia.org/T74514#2135386 (CCogdill_WMF) Apologies @Dzahn, you're totally right. We don't use the links.email.donate.wikimedia.org domain a... [20:55:35] Blocked-on-Fundraising-Tech, Wikimedia-Fundraising, Operations, Traffic, HTTPS: delete links.email.donate.wikimedia.org from DNS - https://phabricator.wikimedia.org/T130414#2135390 (Dzahn) [20:56:26] Blocked-on-Fundraising-Tech, Wikimedia-Fundraising, Operations, Traffic, HTTPS: links.email.donate.wikimedia.org should offer HTTPS - https://phabricator.wikimedia.org/T74514#758165 (Dzahn) @CCogdill_WMF thank you, that is good news. i was just going through that old wiki page [20:56:36] Blocked-on-Fundraising-Tech, Wikimedia-Fundraising, Operations, Traffic, HTTPS: delete links.email.donate.wikimedia.org from DNS - https://phabricator.wikimedia.org/T130414#2135421 (CCogdill_WMF) My comment was incorrect, this domain is no longer in use. Feel free to delete the DNS record! [20:57:59] Wikimedia-Fundraising, Operations, Traffic, HTTPS: delete links.email.donate.wikimedia.org from DNS - https://phabricator.wikimedia.org/T130414#2135422 (greg) [21:02:01] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Smashpig, FR-Worldpay: Add 'Cancelled' type for refund messages - https://phabricator.wikimedia.org/T129714#2135433 (cwdent) [21:02:03] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising-Backlog, Unplanned-Sprint-Work, FR-Worldpay: Worldpay refunds not reaching Civi - https://phabricator.wikimedia.org/T129265#2135432 (cwdent) [21:15:38] Wikimedia-Fundraising, Operations, Traffic, HTTPS: delete links.email.donate.wikimedia.org from DNS - https://phabricator.wikimedia.org/T130414#2135450 (Dzahn) How about this one: open.email.donate.wikimedia.org When i look at DNS i see these 2 lines, related to mkt41 links.email.donate 1H... [21:21:13] Fundraising-Backlog, FR-Adyen: Updates to Adyen form so that it matches Ingenico - https://phabricator.wikimedia.org/T128541#2135453 (Ejegg) Changing the content of the 'PAY' button is possible - I just wish Adyen let you download/upload language files instead of making the change for every language via t... [21:41:25] Wikimedia-Fundraising, Operations, Traffic, HTTPS, Patch-For-Review: delete links.email.donate.wikimedia.org from DNS - https://phabricator.wikimedia.org/T130414#2135502 (CCogdill_WMF) Would it be possible to get a full list of DNS entries you want to remove? I’m seeing A, MX, CNAME and TXT re... [21:49:34] Wikimedia-Fundraising, Operations, Traffic, HTTPS, Patch-For-Review: delete links.email.donate.wikimedia.org from DNS - https://phabricator.wikimedia.org/T130414#2135531 (Dzahn) So far i just wanted to deleted links.email.donate.wikimedia.org (because it was listed on https://wikitech.wikimedia... [21:50:28] Wikimedia-Fundraising, Operations, Traffic, HTTPS, Patch-For-Review: delete links.email.donate.wikimedia.org (and all other email.donate.*?) from DNS - https://phabricator.wikimedia.org/T130414#2135544 (Dzahn) [21:56:43] Fundraising-Backlog, FR-Adyen: Updates to Adyen form so that it matches Ingenico - https://phabricator.wikimedia.org/T128541#2135583 (Ppena) @Ejegg have we asked them? Maybe it is a possibility? [22:02:33] Wikimedia-Fundraising, Operations, Traffic, HTTPS, Patch-For-Review: delete links.email.donate.wikimedia.org (and all other email.donate.*?) from DNS - https://phabricator.wikimedia.org/T130414#2135591 (CCogdill_WMF) Great, thanks @Dzahn. We're double checking this list with IBM to be extra ca... [22:10:23] Wikimedia-Fundraising, Operations, Traffic, HTTPS, Patch-For-Review: delete links.email.donate.wikimedia.org (and all other email.donate.*?) from DNS - https://phabricator.wikimedia.org/T130414#2135644 (Dzahn) @CCogdill_WMF Sounds great. thank you. They should be all. this is the full list i f... [22:22:46] (CR) Ejegg: "Replicates existing behavior fine, but we could improve on it." (5 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278292 (owner: Cdentinger) [22:29:26] (PS3) Cdentinger: Get a better logger without adapter instance [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278335 (https://phabricator.wikimedia.org/T129376) (owner: Ejegg) [22:34:46] (CR) Cdentinger: [C: 2] "1 comment, but looks good generally" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278335 (https://phabricator.wikimedia.org/T129376) (owner: Ejegg) [22:35:22] (PS1) Ejegg: Dump queue to file, leaving messages [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/278409 [22:36:12] (Merged) jenkins-bot: Get a better logger without adapter instance [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278335 (https://phabricator.wikimedia.org/T129376) (owner: Ejegg) [22:42:46] (PS4) Cdentinger: Enable fail page without adapter instance [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276218 (https://phabricator.wikimedia.org/T129376) (owner: Ejegg) [22:57:31] (CR) Cdentinger: move worldpay payment methods (5 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278292 (owner: Cdentinger) [23:00:45] Wikimedia-Fundraising, Operations, Traffic, HTTPS, Patch-For-Review: delete links.email.donate.wikimedia.org (and all other email.donate.*?) from DNS - https://phabricator.wikimedia.org/T130414#2135390 (Reedy) https://github.com/EFForg/https-everywhere/blob/master/src/chrome/content/rules/Wiki... [23:10:22] thanks cwd! [23:10:36] calling it quits for the evening [23:10:46] you bet! have a good one [23:10:47] see everybody Tuesday! [23:21:57] (PS2) Cdentinger: move worldpay payment methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278292 [23:23:31] (CR) jenkins-bot: [V: -1] move worldpay payment methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278292 (owner: Cdentinger) [23:27:14] (PS3) Cdentinger: move worldpay payment methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278292 [23:35:06] (CR) Krinkle: [C: -1] "Waiting for I9721fab9e89c561e in core so we can do this right." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/254326 (https://phabricator.wikimedia.org/T111456) (owner: Krinkle)