[00:00:05] (Abandoned) Awight: Use late static binding to get gateway base dir [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278086 (https://phabricator.wikimedia.org/T130056) (owner: Awight) [00:03:52] (PS6) Awight: Enable fail page without adapter instance [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276218 (https://phabricator.wikimedia.org/T129376) (owner: Ejegg) [00:13:09] hrm, how to use setMwGlobals to set an undefined variable... [00:18:56] (PS1) Awight: Tests for new ResultPages functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/279078 (https://phabricator.wikimedia.org/T129376) [00:19:55] (CR) Awight: [C: 2] "I wrote some tests for extra convincing, in the following patch." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276218 (https://phabricator.wikimedia.org/T129376) (owner: Ejegg) [00:20:18] (PS7) Awight: Catch errors in adapter constructors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276222 (https://phabricator.wikimedia.org/T129376) (owner: Ejegg) [00:21:13] (Merged) jenkins-bot: Enable fail page without adapter instance [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276218 (https://phabricator.wikimedia.org/T129376) (owner: Ejegg) [00:29:48] (CR) Awight: "I have to look at this more, it smells like additional debt, I think we would benefit from yielding control to a dumber page, if not even " (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276222 (https://phabricator.wikimedia.org/T129376) (owner: Ejegg) [00:29:56] milk run. [00:33:14] sorry for being useless this afternoon [00:33:19] https://phabricator.wikimedia.org/T130684 [00:33:27] gotta go but i'll check in later [01:17:13] cwd|afk: aww, I don't have permissions to view that. [01:17:30] Wondering if you made that using our custom link... [02:27:58] (CR) Ejegg: "Hmm, dunno if it's really much additional debt, but it's definitely a workaround for excessive logic in the adapter constructor." (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/276222 (https://phabricator.wikimedia.org/T129376) (owner: Ejegg) [15:16:21] (PS1) Ejegg: Add tools to calculate whitelist for Amazon [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/279124 (https://phabricator.wikimedia.org/T119002) [15:41:45] (PS2) Ejegg: Add tools to calculate whitelist for Amazon [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/279124 (https://phabricator.wikimedia.org/T119002) [15:56:55] Fundraising-Backlog, FR-Amazon: Clear up Amazon donations that got disconnected from CT ID - https://phabricator.wikimedia.org/T118296#2144608 (Ejegg) These are all so old (Oct 2015) it would be weird to capture the funds now. There's only $58 at stake - let's cancel the open payments or just let them ex... [16:01:41] (PS3) Ejegg: sync with 4.7 [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277910 (https://phabricator.wikimedia.org/T130161) (owner: Eileen) [16:08:31] (CR) Ejegg: [C: 2] "Code looks good, checks out with upstream!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277910 (https://phabricator.wikimedia.org/T130161) (owner: Eileen) [16:18:18] (PS3) Ejegg: CRM-18104 Hook for defining log tables. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277911 (https://phabricator.wikimedia.org/T130161) (owner: Eileen) [17:03:06] (CR) Ejegg: [C: 2] "Looks good!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277911 (https://phabricator.wikimedia.org/T130161) (owner: Eileen) [17:05:46] (PS4) Ejegg: CRM-18180 allow non-standard table names in logging reports [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277443 (https://phabricator.wikimedia.org/T130161) (owner: Eileen) [17:23:23] awight: cwd|shovel XenoRyet K4-713 - anything for Scrum of Scrums? [17:23:32] Na, I'm good. [17:23:47] pass! [17:24:34] atgomez: I see you exist today? Want to dash out to food between meetings? [17:26:02] ejegg: Nothing here. [17:27:46] (CR) Awight: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277983 (https://phabricator.wikimedia.org/T130075) (owner: Awight) [17:28:05] cool, thanks [17:29:12] ejegg: On second thought, you might put out feelers wrt. our investigation into aligning more closely with the WMF deployment train, https://phabricator.wikimedia.org/T130658 [17:29:38] awight: sure, I'll mention that! [17:30:04] I think we'd benefit from an Ops volunteer attending our meeting [17:30:14] or err "RelEng" maybe [17:31:32] awight i'm here! i could go on the early side but need ot be here a bit before noon [17:31:39] same here [17:31:46] hungry. [17:31:57] * awight mutters about noon meetings [17:33:18] mmk.. let's go in a little while [17:33:27] copy that [17:37:03] (PS4) Awight: Finish encapsulating Ingenico staging logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277983 (https://phabricator.wikimedia.org/T130075) [17:37:08] (PS3) Awight: Encapsulate PayPal staging logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277985 (https://phabricator.wikimedia.org/T130075) [17:37:14] (PS3) Awight: Encapsulate Worldpay staging logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277988 [17:37:34] yuck. Those patches failed due to some transient npm thing. Should be ready for review again! [17:37:50] i'd say 6 more inches since first shoveling this morning [17:37:54] still coming down hard [17:38:06] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Freshmaking, Fundraising Sprint Zapp, and 3 others: Spike: Split out ActiveMQ replacement tasks for making code changes - https://phabricator.wikimedia.org/T123247#2145152 (awight) a:awight [17:38:10] wow! [17:38:26] this strengthens my belief that the big ones come out of nowhere [17:38:46] when people are prepping for a storm for a week and then nothing happens [17:38:54] So... I just took the family to the East Coast to see great-grandparents and some snow... it snowed the day before we arrived and a few days after we left, but was 65 deg during our visit! [17:39:03] which plays into your crazy beliefs [17:39:03] as of last night they were predicting an inch [17:39:09] there's over a foot outside now [17:39:42] yesterday at noon it was 75 [17:39:50] weather is weird [17:40:02] I blame coal [17:40:34] heh [17:46:05] * awight dodges a lawsuit asteroid [18:01:24] awight: leave in 5? i'll come find you downstairs.. i'm on 5 right meow [18:01:30] perfect [18:01:53] Fundraising-Backlog, fundraising-tech-ops: Spike: Investigate suitability of Kafka instead of Redis - https://phabricator.wikimedia.org/T130304#2145277 (awight) Kafka is specialized for one-way log capture [[ https://engineering.linkedin.com/distributed-systems/log-what-every-software-engineer-should-kno... [18:02:53] cwd: ejegg|mtg: XenoRyet: Jeff_Green: ^ I hate to say it, but I'm nearly swayed by the argument for Kafka. Anyone want to offer contrary opinions? I'll try to give this another pass later today, fwiw. [18:03:21] huh, i will do some reading, not familiar with kafka [18:03:35] but this is the best time to make the call! [18:03:36] awight: no opinion yet from me, I need to talk to the analytics folks about what it looks like to run it [18:03:46] awight: really? I'll take a look, but I thought some of our key-value use cases were better suited to redis [18:04:54] ejegg: They are--but we can do all that key-valuey stuff in MySQL like we do now. [18:05:13] I realized that payments is truly write-only, which is exactly the use case that Kafka is specialized for. [18:05:33] e.g., we aren't allowed to pull something from the "queue" by key, from a payments box. [18:05:40] awight: even the queue abuse I've been adding to SmashPig for Amazon and Adyen? [18:06:15] I'd have to look at that... I assume it's just consumption and requeuing? [18:06:36] yeah,mostly. a lot of grabbing stuff by key though [18:07:11] That could be done in MySQL or Redis, true, but getting off of payments is the time- and robustness- sensitive step [18:07:49] i.e. we can consume the payments Kafka stream and store in MySQL or Redis if it's just a small set of jobs to process, or extra fields we need access to. [18:08:00] and go back to antimessages for orphan message deletion? [18:08:01] there's no "selector" in Kafka AFAICT [18:08:05] hrm. [18:08:19] good point, payments does a "delete" operation huh [18:08:24] grumble [18:08:35] what does it delete? [18:08:42] after orphanslaying? [18:08:45] Isn't orphan stuff all on a payments-only Redis? [18:08:57] Jeff_Green: exactly. [18:09:02] I think that can stay on payments-Redis [18:09:07] gotta get fud, brb [18:09:42] Jeff_Green: also, the front end boxes delete the orphan message when the donor gets back and we deal with the donation [18:10:18] oic [18:10:38] now I understand the antimessage thing [18:17:13] Fundraising-Backlog, fundraising-tech-ops: Spike: Investigate suitability of Kafka instead of Redis - https://phabricator.wikimedia.org/T130304#2132042 (Ejegg) Per IRC discussion, maybe Kafka for the queues that get info off of payments, but Redis where we need key-value stuff: - limbo messages - loc... [18:21:13] (CR) Ejegg: [C: 2] "This works! Could construct a big IN clause with all standard + nonstandard log tables in case some joker defines a custom table 'log_civi" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277443 (https://phabricator.wikimedia.org/T130161) (owner: Eileen) [18:28:16] (CR) Ejegg: [C: -1] "Thanks for the to_keep_id / to_remove_id parameter clarification! Still needs updating in Merger though." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277448 (owner: Eileen) [18:35:58] (CR) Ejegg: [C: -1] "I also prefer LEFT JOIN ... WHERE id IS NULL, but a couple of those conditions look fishy" (1 comment) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277439 (https://phabricator.wikimedia.org/T130173) (owner: Eileen) [18:51:02] (CR) Ejegg: "Looks good! Deployment note: depends on I2d8b027568e1f02ec8c69bd4f5329c1b367cf617 . Curious how you figured out KEY_BLOCK_SIZE=4 - docs o" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277934 (https://phabricator.wikimedia.org/T130161) (owner: Eileen) [18:58:14] Fundraising-Backlog, fundraising-tech-ops: Spike: Talk about moving payments to WMF production MediaWiki - https://phabricator.wikimedia.org/T130658#2145572 (mmodell) please loop in #releng on this discussion. We will be changing some of the process around train deployments in the somewhat near future so... [18:59:47] If anybody's got time for some trivial code review, here are a few things: [18:59:56] https://gerrit.wikimedia.org/r/276583 [19:00:08] https://gerrit.wikimedia.org/r/277428 [19:00:17] https://gerrit.wikimedia.org/r/274544 [19:00:40] and the TY letters: https://gerrit.wikimedia.org/r/278293 [19:00:45] Sure, I'll take a look. [19:00:54] Thanks XenoRyet ! [19:03:10] (CR) XenoRyet: [C: 2] Fix duplicate class name [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/276583 (owner: Ejegg) [19:03:58] (Merged) jenkins-bot: Fix duplicate class name [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/276583 (owner: Ejegg) [19:15:22] (CR) XenoRyet: [C: 2] Fix undefined variable in logging [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274544 (owner: Ejegg) [19:26:33] (CR) XenoRyet: [C: 2] Add Adyen Cancellation IPN message class [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/277428 (owner: Ejegg) [19:41:32] i just saw a giant tree fall over into the street [19:48:12] (Merged) jenkins-bot: Fix undefined variable in logging [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/274544 (owner: Ejegg) [19:48:49] Fundraising-Backlog: Chart data fields for data retention purposes - https://phabricator.wikimedia.org/T130763#2145760 (awight) [19:51:22] cwd: ohno! [19:51:44] cwd: on other topics, did you ever get DI tests running under vagrant? [19:52:04] AndyRussG: heh, yeah mostly [19:52:17] there is one that never passes, i haven't dug into it too much [19:52:41] https://www.mediawiki.org/wiki/Fundraising_tech#Running_PHPUnit_tests_under_vagrant [19:53:27] AndyRussG: it took a few patches to the vagrant repo, you might wanna update that [19:53:30] and reprovision [19:53:38] (CR) XenoRyet: [C: -1] "Japan's letter is still referencing Lila. Comment inline." (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/278293 (https://phabricator.wikimedia.org/T129373) (owner: Ejegg) [19:55:46] http://photos.timescall.com/2016/03/23/photos-longmont-blizzard-2016/#22 [19:57:36] Hey! fame calls! [19:57:56] Newsworthy snowman. That's cool. [19:58:00] (PS2) Ejegg: WIP mock Adyen API for tests [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/277554 [19:58:41] now *they* know where you live! [19:58:44] (Merged) jenkins-bot: Add Adyen Cancellation IPN message class [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/277428 (owner: Ejegg) [19:59:00] awight: ah so vagrant patches all merg'd? [19:59:04] cwd: awight: thx! [19:59:24] AndyRussG: looks like it [20:00:21] awight: the issue I was getting (not yet updated vagrant) was no tests executed, FWIW [20:00:45] I had that one, too, seems to be better now [20:02:43] d'oh! Kafka is not supported by PHP-Queue yet, of course. [20:03:17] awight: AndyRussG XenoRyet cwd ejegg standup? [20:03:21] Fundraising Sprint Freshmaking, Fundraising-Backlog, fundraising-tech-ops: Spike: Investigate suitability of Kafka instead of Redis - https://phabricator.wikimedia.org/T130304#2145810 (awight) [20:03:29] Oh hey, it's that time. BRT [20:03:30] omw [20:03:53] dstrine: yep [20:23:28] Sorry all. my internet connection is pretty spotty. [20:24:09] I haven't had this problem before [20:29:47] aww [20:29:55] maybe a tree also got to your tubes [20:35:04] the ISP up here is not awesome. [20:35:57] dstrine: business opportunity [20:37:36] i know a guy on top of the mountain who recently got a line of sight wireless setup to the plains [20:37:55] gets a super reliable low latency gigabit from it and resells [20:38:43] initial costs were high [20:42:33] * awight faints. Cannot run vagrant unit tests, again. [20:43:09] deployment branch? [20:44:53] hehehehe [20:44:54] thanks [20:45:04] AndyRussG: ^ that might be getting you, too [20:45:58] :) [20:57:33] awight: what error/message were did u get? [20:57:50] awight: was about to ping u with this, when trying to to ./setup.sh on the updated vagrant repo: [20:57:51] Installing plugin mediawiki-vagrant-0.13.0.gem [20:57:51] - Installing the 'mediawiki-vagrant-0.13.0.gem' plugin. This can take a few minutes... [20:57:51] - /usr/lib/ruby/2.3.0/rubygems/specification.rb:946:in `all=': undefined method `group_by' for nil:NilClass (NoMethodError) [20:58:00] wat. [20:58:14] Heh yeah that's what I said [20:58:17] Maybe I need a different ruby? [20:58:22] your ruby is oddly new, fwiw [20:58:24] Or update gem repos or something [20:58:44] Heh well experimental can do that to a person [20:59:33] http://sadbastard.org/images/out2.gif [21:00:13] AndyRussG: https://github.com/mitchellh/vagrant/issues/6911 [21:00:19] This says, upgrade vagrant [21:02:18] awight Hmm, I'm already on 1.8.1 [21:02:38] Just did gem update and it's going to town doing... stuff [21:21:04] Nope that didn't help... [21:23:26] fwiw, /opt/vagrant/embedded/bin/ruby -v [21:23:26] ruby 2.2.3p173 (2015-08-18 revision 51636) [x86_64-linux] [21:23:51] setup.sh should be using that version of ruby [21:24:05] I'm not sure why it's dipping into the system's ruby 2.3 gems [21:49:32] awight: fixed it by installing the vagrant dpkg from the vagrant site, and saying "rvm use system" [21:49:47] * AndyRussG bounces head off hard surfaces [21:56:11] omg [21:56:30] Hmmm ran vagrant provision twice, first time it said there was some error and to look at the logs, second time all good [21:56:38] * AndyRussG avoids looking at logs [21:56:44] the rvm part really throws me for a loop, since setup.sh uses an explicit path to find its ruby [21:57:03] AndyRussG: yeah... apparently the fss.so thing regressed and bd808 is afraid to fix it :p [21:57:20] * awight has great sympathy for bd808 [21:57:38] AndyRussG: i think there is actually a known thing where you have to provision twice [21:57:47] with the fundraising role [21:57:50] huh [21:57:53] OK interesting [21:57:58] because reasons [21:58:05] I think everyone gets hit by it, it's a race condition with provisioning hhvm [21:58:14] Usually I haven't provisioned manually, since it's just always told me it's already provisioned [21:58:20] Just thought I'd try it for kicks [21:58:23] pretty sure bd808 said it will be fixable once everyone using mw-vagrant is on a newer version of hhvm [21:58:52] https://phabricator.wikimedia.org/rMWVAe06c524583c71c582a864bcc706aa78c181c3c23 and stuff [21:59:02] * Seddon wakes up to the ping of the word fundraising and then goes back to sleep when it tech talk that goes several miles over my head [21:59:17] lol, that's a risky regex [21:59:31] I do love learning which buttons to press to annoy my beloved coworkers :) [21:59:55] * cwd adds to the list of words to avoid [22:00:18] the v4grant fundrai$ing role... [22:00:24] fundr4151N6