[12:02:40] Fundraising Sprint Freshmaking, Fundraising-Backlog, fundraising-tech-ops: Spike: Investigate suitability of Kafka instead of Redis - https://phabricator.wikimedia.org/T130304#2150744 (Jgreen) Rather than provisioning more systems, could we add a database on fundraisingdb cluster? [12:09:51] Fundraising Sprint Freshmaking, Fundraising-Backlog, fundraising-tech-ops: Put faulkner database on ice - https://phabricator.wikimedia.org/T130039#2150752 (Jgreen) >>! In T130039#2149679, @awight wrote: > @Jgreen > Well, I'm sure that we want anything still querying that data to break. > > One of S... [12:10:01] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: [epic] Make deduping reversible - https://phabricator.wikimedia.org/T111704#2150754 (Jgreen) [12:10:03] Fundraising Sprint Freshmaking, Fundraising-Backlog, fundraising-tech-ops: Put faulkner database on ice - https://phabricator.wikimedia.org/T130039#2150753 (Jgreen) Open>Resolved [14:44:07] Fundraising Sprint Freshmaking, Fundraising-Backlog, fundraising-tech-ops: Spike: Investigate suitability of Kafka instead of Redis - https://phabricator.wikimedia.org/T130304#2151110 (awight) That works for me! [16:30:25] (PS2) Zfilipin: WIP Simplify creating of Jenkins jobs for running browser tests daily [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/279342 (https://phabricator.wikimedia.org/T128190) [16:33:06] (PS3) Zfilipin: WIP Simplify creating of Jenkins jobs for running browser tests daily [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/279342 (https://phabricator.wikimedia.org/T128190) [16:34:33] (PS4) Zfilipin: WIP Simplify creating of Jenkins jobs for running browser tests daily [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/279342 (https://phabricator.wikimedia.org/T128190) [16:36:46] (PS5) Zfilipin: WIP Simplify creating of Jenkins jobs for running browser tests daily [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/279342 (https://phabricator.wikimedia.org/T128190) [16:39:47] (PS6) Zfilipin: WIP Simplify creating of Jenkins jobs for running browser tests daily [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/279342 (https://phabricator.wikimedia.org/T128190) [16:41:06] (CR) jenkins-bot: [V: -1] WIP Simplify creating of Jenkins jobs for running browser tests daily [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/279342 (https://phabricator.wikimedia.org/T128190) (owner: Zfilipin) [16:43:43] (PS7) Zfilipin: WIP Simplify creating of Jenkins jobs for running browser tests daily [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/279342 (https://phabricator.wikimedia.org/T128190) [17:21:04] Fundraising-Backlog, fundraising-tech-ops: New Ops request: updating DNS for Major Gifts domain Inbox x 24 hours x - https://phabricator.wikimedia.org/T130937#2151449 (DStrine) [17:23:35] Fundraising-Backlog, fundraising-tech-ops: New Ops request: updating DNS for Major Gifts domain Inbox x 24 hours x - https://phabricator.wikimedia.org/T130937#2151469 (CCogdill_WMF) [17:28:05] Fundraising Sprint Freshmaking, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Unplanned-Sprint-Work: Use consistent parameter and variable names in DI - https://phabricator.wikimedia.org/T130939#2151499 (Ejegg) [17:54:13] (PS1) Ejegg: Prefer canonical parameter names in form chooser [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/279641 (https://phabricator.wikimedia.org/T130939) [17:55:02] XenoRyet: ^^ has been bugging me for a while [17:55:24] and I just noticed that all the test links I made for AstroPay are using the standard names [17:55:42] instead of the non-standard names that the form chooser has been looking for [17:56:08] (CR) jenkins-bot: [V: -1] Prefer canonical parameter names in form chooser [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/279641 (https://phabricator.wikimedia.org/T130939) (owner: Ejegg) [17:56:09] so we're getting dumb errors in the logs and I'm not as confident about the tests [17:56:13] grr [17:56:34] let's see what 5.3 feature busted that [17:57:05] oops, incomplete workaround [17:58:46] (PS2) Ejegg: Prefer canonical parameter names in form chooser [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/279641 (https://phabricator.wikimedia.org/T130939) [18:11:22] ejegg: I'm in civi land at the moment, but I can take a look at that patch a little later today. [18:11:47] cool, thanks! [18:12:13] How's Civi treating you? Want to collaborate on anything? [18:14:10] It's going mostly ok. This bug with the Engague importer is pretty straighforward. [18:14:45] It's just wanting 1 instead of 'yes' for the op-out feilds. [18:14:54] ah, word [18:15:07] Trying to decide if I want to fix that just for Engague or if that's something we'd want for all of the importers. [18:15:13] I'm leaning toward the latter. [18:15:52] let it take any reasonable truth value? [18:15:54] Oooh... opt-out. [18:16:03] Yea, that's what I'm thinking. [18:16:08] There's a story of great heartache there. [18:16:08] 1, yes, true [18:16:20] Something I should know about? [18:16:25] Oh, probably. [18:16:31] Otherwise you'll find out the hard way. [18:16:49] lay it on me [18:16:49] At that point we could all be pretty sad together. [18:17:01] So... HTML forms are a problem. [18:17:31] Particularly when, historically, they have waffled several times between presenting a checkbox that either said "opt-out" or "opt-in"... [18:17:48] And, of course, the thing with checkboxes is that an unchecked checkbox isn't even there. [18:17:51] In the data. [18:18:11] Reminds me of that weird tri-state opt-out we had at Overnite [18:18:11] So... _you can't even tell_ what was on the form, or what people agreed to. Not for real. [18:19:00] Anyway.... I know standardizing these seems like a great idea. But it might cause you to get a rash. [18:19:37] Just be prepared with enough oatmeal bath for everybody. [18:20:06] I think we'll be ok here. I'm only mucking with the offline2civicrm importers. Should just all be csv and the like. [18:20:27] Yeah. So long as you're not touching shared components for other stuff... [18:20:38] I don't think I am, but I'll double check that. [18:20:46] ...and if there are things that seem stranded in csv-import-only-land, this is probably why. [18:21:00] Yea, makes sense. [18:28:10] (PS1) Ejegg: Fix fiscal number error messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/279647 (https://phabricator.wikimedia.org/T124329) [18:29:14] Fundraising-Backlog, FR-Astropay, Patch-For-Review, WMF-deploy-2016-03-29_(1.27.0-wmf.19): [epic] Processing via Astropay for Spanish-speaking LATAM countries - https://phabricator.wikimedia.org/T102143#2151767 (Ejegg) [18:29:16] Fundraising Sprint Bloodletting 2016, Fundraising Sprint Freshmaking, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 2 others: Verify which fiscal numbers we need to collect for AstroPay in each new LATAM country, update l10n files - https://phabricator.wikimedia.org/T124329#2151765... [18:29:25] (CR) jenkins-bot: [V: -1] Fix fiscal number error messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/279647 (https://phabricator.wikimedia.org/T124329) (owner: Ejegg) [18:29:35] que? [18:30:05] dstrine: be there in a sec! [18:30:06] man, mysql sure is crashy on the integration slaves lately [18:30:23] That sounds ominous. [18:30:52] AndyRussG: kk [18:31:06] (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/279647 (https://phabricator.wikimedia.org/T124329) (owner: Ejegg) [18:31:41] yeah, i'll mention it in releng [18:59:42] (PS1) Ejegg: Fix AstroPay submethod unstaging [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/279652 [19:01:15] (CR) jenkins-bot: [V: -1] Fix AstroPay submethod unstaging [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/279652 (owner: Ejegg) [19:07:22] (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/279652 (owner: Ejegg) [19:19:26] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising-Backlog, Patch-For-Review: Deploy Thank you letters to remove Lila's signature - https://phabricator.wikimedia.org/T129373#2151925 (Ejegg) Hi @jrobell , @XenoRyet found one issue with the Japanese letter - ap... [19:25:19] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising-Backlog, Patch-For-Review: Deploy Thank you letters to remove Lila's signature - https://phabricator.wikimedia.org/T129373#2151932 (Ejegg) a:Ejegg>jrobell [19:57:18] ejegg: hi! so these CI failures for DI are a CI issue I guess? https://integration.wikimedia.org/ci/job/mwext-DonationInterface-testextension-php55/330/console [19:58:15] AndyRussG: There must have been a change to language stuff in core [19:58:48] not immediately obvious what would break just that test though [19:59:59] Hmmmm [20:00:22] ejegg: and it's different from the error I'm getting locally (vagrantly) on a lot of those patches... [20:00:42] Fatal error: Undefined interface: GatewayType in /vagrant/mediawiki-fr/extensions/DonationInterface/gateway_common/gateway.adapter.php on line 31 [20:00:42] [Fri Mar 25 19:54:36 2016] [hphp] [26503:7efe1c513100:0:000002] [] Destructor threw an object exception: exception 'MWException' with message 'DonationInterface_Adapter_Adyen_Test::tearDown() must call parent::tearDown()' in /vagrant/mediawiki-fr/tests/phpunit/MediaWikiTestCase.php:95 [20:01:06] AndyRussG: that seems like a cascading failure [20:01:11] Hmmm [20:01:22] pretty sure all the teardowns call parent [20:03:49] Don't actually see an explicit teardown in that file, just parent from DonationInterfaceTestCase [20:04:33] AndyRussG: XenoRyet standup? [20:04:40] BRT, camera issue [20:05:18] dstrine: one sec :) [20:36:38] Fundraising Sprint Dirt Farming, Fundraising Sprint Elevator Maintenance 2016, Fundraising-Backlog, Wikimedia-Fundraising, FR-Ingenico: Store and update list of currenly working IDEAL banks - https://phabricator.wikimedia.org/T128692#2152124 (DStrine) from an email with ingenico: Dear all,... [21:02:03] (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/279078 (https://phabricator.wikimedia.org/T129376) (owner: Awight) [21:07:43] (CR) Ejegg: [C: 2] Tests for new ResultPages functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/279078 (https://phabricator.wikimedia.org/T129376) (owner: Awight) [21:12:01] (PS2) Ejegg: CRM-18213 remove hard-coding of DAO names [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277355 (owner: Eileen) [21:12:55] (CR) Ejegg: [C: 2] "Replacement function looks good, doesn't seem to be anything depending on the smaller table to filter." [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277355 (owner: Eileen) [21:22:02] (PS2) Ejegg: CRM-18213 remove hard-coded DAO names [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277356 (owner: Eileen) [21:22:49] (Merged) jenkins-bot: Tests for new ResultPages functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/279078 (https://phabricator.wikimedia.org/T129376) (owner: Awight) [21:25:46] (PS6) Ejegg: Finish encapsulating Ingenico staging logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277983 (https://phabricator.wikimedia.org/T130075) (owner: Awight) [21:26:18] (CR) Ejegg: [C: 2] "Also looks good" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277356 (owner: Eileen) [21:27:31] (PS2) Ejegg: Remove old fork of DonationInterface code [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/279270 (owner: Awight) [21:28:22] (CR) Ejegg: [C: 2 V: 2] "Did a sweep through the projects, couldn't find anything using it. Thanks for the de-crufting!" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/279270 (owner: Awight) [21:29:38] (CR) Ejegg: [C: 2] "you put your +2 in, you put your +2 out, put your +2 in and shake it all about" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277983 (https://phabricator.wikimedia.org/T130075) (owner: Awight) [21:31:30] (Merged) jenkins-bot: Finish encapsulating Ingenico staging logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277983 (https://phabricator.wikimedia.org/T130075) (owner: Awight) [21:34:01] (PS5) Ejegg: Encapsulate PayPal staging logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277985 (https://phabricator.wikimedia.org/T130075) (owner: Awight) [21:35:52] (PS2) Ejegg: Add tests for logging functionality to ensure the tables are still creating well [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277923 (https://phabricator.wikimedia.org/T130161) (owner: Eileen) [21:37:54] (CR) Ejegg: [C: 2] "doin the jenkins hokey pokey" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277985 (https://phabricator.wikimedia.org/T130075) (owner: Awight) [21:38:46] (CR) Ejegg: [C: 2] "Gotta keep those files *NSYNC !" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277923 (https://phabricator.wikimedia.org/T130161) (owner: Eileen) [21:39:45] (Merged) jenkins-bot: Encapsulate PayPal staging logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277985 (https://phabricator.wikimedia.org/T130075) (owner: Awight) [22:02:00] Fundraising-Backlog: Weird CIVI result for FIND CONTRIB - https://phabricator.wikimedia.org/T130965#2152288 (Ppena)