[13:21:16] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising-Backlog, Patch-For-Review: Deploy Thank you letters to remove Lila's signature - https://phabricator.wikimedia.org/T129373#2154548 (jrobell) Thank you for catching that @XenoRyet and sorry for the hassle @Eje... [16:12:09] Happy Monday fr-tech! I need CR on a few AstroPay fixes: [16:12:36] Fix AstroPay submethod unstaging https://gerrit.wikimedia.org/r/279652 [16:12:47] Fix fiscal number error messages https://gerrit.wikimedia.org/r/279647 [16:13:40] (not specific to AP, but will make the demo links I provided for AP work better: Prefer canonical parameter names in form chooser https://gerrit.wikimedia.org/r/279641 [16:17:10] ejegg: are these last changes relevant to all countries? are there some countries that are more stable than others? I'm wondering if we want to do 1-hour tests on countries which are at that stage while fixing others [16:17:27] but I don't want to complicate things if that is not easy or wise at this point [16:17:43] dstrine: the unstaging is currently breaking thank you page redirects for all countries :( [16:17:58] ok gotcha [16:17:58] (for AstroPay) [16:37:36] ejegg: happy Monday to u too :) Am I correct in assuming the red CI lights on phpunit are for ignoring still? [16:37:51] oh phooey, I should figure that out [16:38:02] but for now, yeah, we can ignore [16:38:18] K cool! thx :) [16:38:37] Finally got my kernel to update, and also got my vagrant CPU usage back to normal ;p [16:39:26] nice! [16:39:39] * AndyRussG looks gazes proudly but tiredly at new connections between neurons representing knowledge about raid and initramfs 8p [16:41:36] yeah! would have been worse if it didn't have a happy ending... Hate it when one spends hours trying to fix a problem just to end up saying, screw it.... [17:14:13] (PS1) Ejegg: Fix language setup for AstroPay test [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/279969 [17:17:21] AndyRussG: ^^ seemed to fix the 1.27/hhvm test [17:18:06] I can rebase the others on top of it if that'll give you more confidence in 'em [17:20:59] (PS2) Ejegg: Thank you letters for exec director transition [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/278293 (https://phabricator.wikimedia.org/T129373) [17:21:57] (CR) Ejegg: "OK XenoRyet, got the Japanese letter updated" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/278293 (https://phabricator.wikimedia.org/T129373) (owner: Ejegg) [17:25:34] (CR) XenoRyet: [C: 2] "Yep, looks good now." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/278293 (https://phabricator.wikimedia.org/T129373) (owner: Ejegg) [17:27:14] (Merged) jenkins-bot: Thank you letters for exec director transition [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/278293 (https://phabricator.wikimedia.org/T129373) (owner: Ejegg) [17:27:15] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising-Backlog, Patch-For-Review: Deploy Thank you letters to remove Lila's signature - https://phabricator.wikimedia.org/T129373#2155147 (Ejegg) Fixes are reviewed and merged. I'll deploy them this afternoon! [18:01:09] heading to an appointment, be back on in an hr! [19:09:31] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/279986 [19:09:56] (CR) Ejegg: [C: 2 V: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/279986 (owner: Ejegg) [19:11:21] !log disabled thank you mail job [19:11:25] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [19:12:42] Looks fun! [19:16:20] Hi awight ! [19:16:38] got a few astropay fixes waiting for CR if you have a minute... [19:16:50] Fix AstroPay submethod unstaging https://gerrit.wikimedia.org/r/279652 [19:17:00] Fix fiscal number error messages https://gerrit.wikimedia.org/r/279647 [19:17:13] (not specific to AP, but will make the demo links I provided for AP work better: Prefer canonical parameter names in form chooser https://gerrit.wikimedia.org/r/279641 [19:17:29] thanks! [19:17:42] (PS2) Awight: Fix AstroPay submethod unstaging [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/279652 (owner: Ejegg) [19:18:39] (CR) Awight: [C: 2] "Ouch! I'm concerned that the test didn't pick this up..." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/279652 (owner: Ejegg) [19:19:12] (CR) Awight: [C: 2] Fix fiscal number error messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/279647 (https://phabricator.wikimedia.org/T124329) (owner: Ejegg) [19:19:16] (PS2) Awight: Fix fiscal number error messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/279647 (https://phabricator.wikimedia.org/T124329) (owner: Ejegg) [19:19:28] d'oh, that crm merge totally didn't work [19:19:45] ah, it put the revert after the new ty patch... [19:20:37] (PS1) Ejegg: Thank you letters for exec director transition [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/279992 (https://phabricator.wikimedia.org/T129373) [19:20:49] Hey, if anyone is interested in this problem... I'm playing with the idea of consolidating down to just one or two queues as part of sunsetting ActiveMQ. There's no particular reason to do this, other than reducing cognitive load. [19:21:13] The only blocker so far is that it would be difficult to estimate how many donations remain unprocessed if we do that, however. [19:21:14] (CR) Ejegg: [C: 2 V: 2] "cherry-picked to master" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/279992 (https://phabricator.wikimedia.org/T129373) (owner: Ejegg) [19:21:51] hmm, there are some obvious candidates for consolidation, like the gateway-specific queues [19:22:16] what else would be easy to get rid of? [19:22:17] The first one I would kill is the pending queue... [19:22:32] oh? [19:22:35] there's a megasprawl there, and it only needs to be a single thing [19:22:39] https://docs.google.com/spreadsheets/d/1lkle5RJNG33z6c3u1czQS_0scnyLX-X57Sh4W3dyCl4/edit#gid=0 [19:22:40] (Merged) jenkins-bot: Fix AstroPay submethod unstaging [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/279652 (owner: Ejegg) [19:23:08] limbo x 2, pending, cc-limbo, globalcollect-cc-limbo, inflight, pending_paypal_recurring [19:23:48] awight: so move pending to redis, write-only from payments-wiki? [19:23:49] Yeah, I suppose consolidating the rest of 'em is just a fetishistic thing, and can wait for a later stage. [19:24:10] Actually, I'm on a whole 'nother trip now. Looking at Kafka for our buffer layer. [19:24:41] Pending would go through Kafka, then be stored in a new MySQL db within frack but outside of the payments cluster. [19:24:48] ah, word [19:25:06] the storage wouldn't need to be high-availability, cos we'd be decoupled through Kafka. [19:25:23] sure, that makes sense [19:25:38] awight: hi! r u reviewing https://gerrit.wikimedia.org/r/#/c/279641/ ? (just don't want to duplicate efforts) [19:25:41] then the IPN and Civi can read from that db [19:25:59] AndyRussG: All yours! [19:26:09] Ah ok......thx [19:26:16] ejegg: yep. And indexes are easy, if MySQL [19:27:06] Column F describes how I'm currently imagining migrating each queue. [19:27:09] sort of. [19:27:11] !log updated civiCRM from 18431eec74de251066deb77d5b63607e06f6f135 to d95c93f73a9329d6367403ac3e7d60c97987e61f [19:27:16] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [19:35:04] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising-Backlog, Patch-For-Review: Deploy Thank you letters to remove Lila's signature - https://phabricator.wikimedia.org/T129373#2155673 (Ejegg) Oops, just noticed the PL letter isn't updated. Could you make sure... [19:36:01] weird... looks like it is [19:39:29] hmm? [19:39:44] translation snafu? [19:40:02] pl isn't in the list returned by get_translated_languages [19:40:14] dear oh dear [19:40:37] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising-Backlog, Patch-For-Review: Deploy Thank you letters to remove Lila's signature - https://phabricator.wikimedia.org/T129373#2155686 (Ejegg) Sorry @jrobell, looks like it's published and we have a code issue.... [19:41:15] ejegg: that's pulling straight from a MW api... I wonder [19:41:48] Meta pages still link here, https://meta.wikimedia.org/wiki/Fundraising/Translation/Thank_you_email_20150904 [19:41:51] is that the one? [19:42:23] ooh, pl is an older title! [19:42:28] aah [19:42:34] I hate that fallback logic [19:42:49] I thought we decided to pull that out and just serve English rather than an outdated letter? [19:43:22] looks like they updated 20140606 to remove Lila's name too [19:43:22] omg. "including Antarctica" [19:43:41] might be worth asking about the desired fallback behavior again. [19:45:27] eileen: Good morning! [19:46:23] eileen: I had a crazy thought for you. Do you think that Civi would be interested in serving contents of a new type of audit log, which contained e.g. all interactions our system has ever had with a donor's transactions? [19:46:52] Would that complement the Activity feed in a meaningful way? [19:50:40] awight: hey!! [19:51:23] awight: sounds like a souped up version of the original intent of the civicrm_log table? [19:51:36] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising-Backlog, Patch-For-Review: Deploy Thank you letters to remove Lila's signature - https://phabricator.wikimedia.org/T129373#2155720 (Ejegg) Ok, not a code issue. Arabic and Polish are still using the Thank_yo... [19:52:24] A point Chris made was that the activity entity is used to represent both actual activities by a contact and a kind of change log [19:52:57] eileen: I don't know what civicrm_log is yet, but it sounds similar. [19:53:22] well - it doesn't hold much - just entity links really [19:53:24] I'm thinking, logs captured by any system, so the same sort of thing we would currently find by logging into our log aggregator and grepping for Order ID [19:53:38] !log rolled civicrm back to 18431eec74de251066deb77d5b63607e06f6f135 [19:53:43] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [19:53:52] ouch rollback? [19:54:13] eileen: just the thank you letter templates again [19:54:18] ah ok [19:55:00] I'll fix the deploy branch before end of day [19:55:05] thanks! [19:55:11] * awight applies more tin foil [19:55:20] I guess CiviCRM has 3 kinds of logs - civicrm_log table = very limited, custom data fields + logging = very complete, activity log = kinda detailed but a bit erratic [19:55:26] :-) [19:55:43] hmm, none of those sounds like a good place to plug in a huge additional stream of data. [19:56:36] There is also the civicrm_system_log table - but that's more like the drupal watchdog [19:57:29] This is just an idle thought, and can wait. But I'm imaginine a UI where Donor Services can pull up a very detailed history, see status changes on the payment processor, etc. [19:58:05] yeah - that would be nice [19:59:00] * awight strokes shorn chin [20:00:39] shorn? [20:00:39] What set me off on this, is that using Kafka for our buffer would allow us to do fancy things like have secondary queue consumers, which just copy the raw data to an archive somewhere, optionally on a new OLAP DB where we can index by contribution_tracking ID and stuff. [20:00:39] shorn like a summer sheep [20:03:47] bah, gtalk plugin crashing [20:09:19] !log restarted thank you email job [20:09:23] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [20:13:58] (PS1) Ejegg: Revert "Thank you letters for exec director transition" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280000 (https://phabricator.wikimedia.org/T129373) [20:18:16] (PS3) Ejegg: Fix fiscal number error messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/279647 (https://phabricator.wikimedia.org/T124329) [20:25:30] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: fix 'recurring donations by payment method + date range' search - https://phabricator.wikimedia.org/T131094#2155849 (MBeat33) [20:50:41] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: New Civi User Login for Engage - https://phabricator.wikimedia.org/T131098#2155958 (LeanneS) [20:53:11] (PS3) Ejegg: Prefer canonical parameter names in form chooser [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/279641 (https://phabricator.wikimedia.org/T130939) [20:56:09] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: New Civi User Login for Engage - https://phabricator.wikimedia.org/T131098#2155958 (Eileenmcnaughton) @LeanneS I might be a bit blind but I can't spot her on the staff page - but I might be looking at the wrong page! What is her surname? I was looking... [20:56:09] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: New Civi User Login for Engage - https://phabricator.wikimedia.org/T131098#2155973 (DStrine) a:Jgreen [20:56:09] AndyRussG: PS3 has comments, only one fn [20:56:09] ejegg: cool thx! K git review -d'ing [20:56:09] thanks! [20:56:09] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: New Civi User Login for Engage - https://phabricator.wikimedia.org/T131098#2155976 (LeanneS) @Eileenmcnaughton Sorry, she's at the bottom of this page! https://collab.wikimedia.org/wiki/Fundraising [21:03:05] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: New Civi User Login for Engage - https://phabricator.wikimedia.org/T131098#2155994 (Eileenmcnaughton) She should have the login email by now ... but will need the certificate from Jeff before she can use it [21:07:44] (PS4) Ejegg: move worldpay payment methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278292 (owner: Cdentinger) [21:08:38] (CR) Ejegg: "awight, mind jiggling the handle on this one?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/279647 (https://phabricator.wikimedia.org/T124329) (owner: Ejegg) [21:11:22] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Engage User's Civi Certificate Not Working - https://phabricator.wikimedia.org/T131102#2156036 (LeanneS) [21:12:27] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising-Backlog, Patch-For-Review: Deploy Thank you letters to remove Lila's signature - https://phabricator.wikimedia.org/T129373#2156048 (Ejegg) One more language with an outdated template: Bengali (BN) [21:15:03] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: New Civi User Login for Engage - https://phabricator.wikimedia.org/T131098#2156052 (LeanneS) Thanks, @Eileenmcnaughton ! [21:18:50] ejegg: I don't understand why the function passed in $assertNodes talks about ffname and sez 'Wrong form' [21:19:31] AndyRussG: so, the form chooser looks at the donation parameters and decides which form is best suited [21:19:32] Probably my ignorance, just thought I'd mention in case it's a mistake [21:19:46] Ahh OK gotcha [21:19:52] it redirects to the correct gateway, with the form on the querystring as 'ffname' [21:20:32] ejegg: Ah OK, right paymentmethod is determining that.... [21:20:33] so i could have checked for redirecting to the PaypalGateway page, but I thought ffname was simpler [21:21:06] Yeah more unit-y [21:25:45] (PS4) AndyRussG: Prefer canonical parameter names in form chooser [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/279641 (https://phabricator.wikimedia.org/T130939) (owner: Ejegg) [21:27:06] ejegg: k just waiting for CI to I [21:27:23] heh, thx! [21:27:47] Ah heh thought the fix for those tests was merged.... [21:27:53] K np [21:28:32] nope, still waiting for cr! [21:29:37] (CR) AndyRussG: [C: 2] Prefer canonical parameter names in form chooser [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/279641 (https://phabricator.wikimedia.org/T130939) (owner: Ejegg) [21:29:54] d'oh! [21:30:33] (PS4) Awight: Fix fiscal number error messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/279647 (https://phabricator.wikimedia.org/T124329) (owner: Ejegg) [21:30:35] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: [EPIC] redupe post release UX tweaks - https://phabricator.wikimedia.org/T131104#2156105 (DStrine) [21:30:51] (Merged) jenkins-bot: Prefer canonical parameter names in form chooser [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/279641 (https://phabricator.wikimedia.org/T130939) (owner: Ejegg) [21:31:00] ejegg: What should I CR now? There's 279647, anything else? [21:31:11] &, I'm happy to do the payments deployment. [21:31:23] awight: there are a couple of SmashPig things if you want to look at those [21:32:02] great, looking [21:32:10] tiny patch https://gerrit.wikimedia.org/r/279969 gets the 1.27/hhvm tests green again [21:32:36] (PS2) Awight: Fix language setup for AstroPay test [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/279969 (owner: Ejegg) [21:32:46] (PS5) Awight: Fix fiscal number error messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/279647 (https://phabricator.wikimedia.org/T124329) (owner: Ejegg) [21:33:02] (CR) Awight: [C: 2] Fix language setup for AstroPay test [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/279969 (owner: Ejegg) [21:33:09] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Engage User's Civi Certificate Not Working - https://phabricator.wikimedia.org/T131102#2156138 (Eileenmcnaughton) a:Jgreen [21:33:11] (CR) Ejegg: [C: 2 V: 2] "self-merging reversion of own patch to make CRM deployable" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280000 (https://phabricator.wikimedia.org/T129373) (owner: Ejegg) [21:34:43] (Merged) jenkins-bot: Fix language setup for AstroPay test [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/279969 (owner: Ejegg) [21:34:54] (PS6) Awight: Fix fiscal number error messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/279647 (https://phabricator.wikimedia.org/T124329) (owner: Ejegg) [21:35:30] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: redupe UX: change "insert" link to give more context - https://phabricator.wikimedia.org/T131106#2156159 (DStrine) [21:35:55] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: redupe UX: change "insert" link to give more context - https://phabricator.wikimedia.org/T131106#2156144 (DStrine) [21:37:44] (CR) Awight: Fix fiscal number error messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/279647 (https://phabricator.wikimedia.org/T124329) (owner: Ejegg) [21:37:50] (CR) Awight: [C: 2] Fix fiscal number error messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/279647 (https://phabricator.wikimedia.org/T124329) (owner: Ejegg) [21:38:22] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Redupe UX: better confirmation after reverting a merge - https://phabricator.wikimedia.org/T131107#2156171 (DStrine) [21:38:32] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Redupe UX: better confirmation after reverting a merge - https://phabricator.wikimedia.org/T131107#2156184 (DStrine) [21:38:34] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: [EPIC] redupe post release UX tweaks - https://phabricator.wikimedia.org/T131104#2156183 (DStrine) [21:39:17] (Merged) jenkins-bot: Fix fiscal number error messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/279647 (https://phabricator.wikimedia.org/T124329) (owner: Ejegg) [21:39:50] (CR) Awight: [C: 2] "I feel futuristic just seeing that patch!" (3 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/277554 (https://phabricator.wikimedia.org/T127880) (owner: Ejegg) [21:40:03] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Engage User's Civi Certificate Not Working - https://phabricator.wikimedia.org/T131102#2156190 (DStrine) [21:40:34] (Merged) jenkins-bot: Mock Adyen API and queue, test capture job [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/277554 (https://phabricator.wikimedia.org/T127880) (owner: Ejegg) [21:43:37] (CR) Ejegg: "Souping up the old Rube Goldberg machine!" (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/277554 (https://phabricator.wikimedia.org/T127880) (owner: Ejegg) [21:46:09] (PS1) Ejegg: Remove obsolete Northern Frisian TY letter [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280085 (https://phabricator.wikimedia.org/T129373) [21:46:52] (CR) Awight: [C: 2] "Nice test coverage!" (1 comment) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/277427 (https://phabricator.wikimedia.org/T129935) (owner: Ejegg) [21:47:24] (Merged) jenkins-bot: Cancel duplicate authorizations for a single order ID [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/277427 (https://phabricator.wikimedia.org/T129935) (owner: Ejegg) [21:47:58] thanks awight ! [21:48:26] I've got to relocate, but I'll be ready to do the DI deploy (or watch you do it) in 15 min. [21:48:38] (PS4) Awight: Encapsulate Worldpay staging logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277988 [21:49:05] ejegg|afk: actually, I needa commute as well. And I want to test the new staging code pretty thoroughly [21:49:09] so how about 1 hr? [21:50:00] awight: just got this trying tests under vagrant as per https://www.mediawiki.org/wiki/Fundraising_tech#Running_PHPUnit_tests_under_vagrant [21:50:13] Cannot redeclare class LogPrefixProvider in /vagrant/mediawiki-fr/extensions/DonationInterface/gateway_common/gateway.adapter.php on line 23 [21:50:26] I feel like I've been here before... [21:50:33] Hmmmm why am I school? [21:51:23] AndyRussG: uh. [21:51:33] DI is definitely up to date? [21:51:41] that sounds like an autoload.php problem [21:51:42] I just pulled on master [21:51:48] try "composer install" [21:51:50] :( [21:52:12] Hum [21:52:25] Just got some moar patches, maybe it didn't pull when I thought it did [21:52:46] the composer thing should recreate autoload.php [21:53:24] I think I recognize this as an issue caused by moving a class definition out of a common file and into its own file [21:54:04] I did composer update for mediawiki-fr [21:54:25] try in the DI directory... [21:54:31] Hum I thought I remembered it being some multiwiki thing [21:54:39] not... that particular one [21:54:42] oh! now it's running :) [21:54:48] there was a similar error, about MWMultiWikiSomething [21:54:51] Composer update from extensions/DonationInterface [21:55:07] awesome! sorry gtg, I'll be back in an hour. [21:55:20] (Brought the bike to work and it's horrible to take on the train at rush hour) [21:55:41] awight: thx! cya [22:01:27] dstrine: that issue around the activity type not existing & giving an error on staging is fixed now [22:01:51] dstrine: one sec! [22:01:53] @eileen cool I'll check it out [22:02:04] If anyone can code review this one https://gerrit.wikimedia.org/r/#/c/277447/ it would help ensure we get the order of deploy right as that has to happen before the submodule commit [22:02:17] (& I think that dependency is hard to manage in gerrit) [22:04:43] Oh, I thought I'd already done that. Must've forgotten to actually push the button. [22:05:39] (CR) XenoRyet: [C: 2] Add CiviCRM activity to put against the deleted contact [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277447 (https://phabricator.wikimedia.org/T119246) (owner: Eileen) [22:06:07] XenoRyet: Thanks! [22:06:12] No worries [22:08:05] (Merged) jenkins-bot: Add CiviCRM activity to put against the deleted contact [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/277447 (https://phabricator.wikimedia.org/T119246) (owner: Eileen) [22:44:19] ejegg: are you going to deploy those letters again today? [22:44:36] eileen: nope! [22:44:46] I merged the revert into master [22:44:51] but not into deployment yet [22:45:23] ejegg: ok I have a patch to go out - but not in a hurry [22:48:34] (PS1) XenoRyet: Fix opt out fields for Civi imports [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280113 (https://phabricator.wikimedia.org/T130768) [22:50:09] (CR) Ejegg: [C: -1] "One field name got mutated, but the rest looks good!" (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277988 (owner: Awight) [22:55:28] (CR) Ejegg: "Would it make sense to include 'y' as well?" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280113 (https://phabricator.wikimedia.org/T130768) (owner: XenoRyet) [22:56:22] (CR) Ejegg: Fix opt out fields for Civi imports (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280113 (https://phabricator.wikimedia.org/T130768) (owner: XenoRyet) [22:56:30] (CR) XenoRyet: "Yes, yes it would. Any other values you can think of that I'm forgetting?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280113 (https://phabricator.wikimedia.org/T130768) (owner: XenoRyet) [22:57:46] (CR) Ejegg: "I suppose someone might even use true/false or t/f" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280113 (https://phabricator.wikimedia.org/T130768) (owner: XenoRyet) [23:00:02] ejegg: Just situating for a moment. No deployment yet, right? [23:00:15] awight: right, none yet [23:02:09] Looks like an exciting lineup. Anything else you want to get in there, or shall I go for it? [23:03:46] (PS1) Awight: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/280121 [23:05:59] (CR) Ejegg: [C: -1] "I don't like the separate api_names config (plus it'll conflict with Icb3bc8e1f7b909ecf790efae3514e7af5763198a). Also, let's at least add " (7 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278292 (owner: Cdentinger) [23:06:11] awight: let 'er rip! [23:06:43] (PS1) Awight: Update packages [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/280124 [23:06:54] (CR) Awight: [C: 2] Update packages [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/280124 (owner: Awight) [23:07:12] what needed updating in vendor? [23:07:58] wow, was the Amazon stuff that old? [23:08:02] (PS1) Awight: Update package pointers [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280125 [23:08:51] (PS1) Awight: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/280127 [23:08:57] This is a jive jig. [23:09:07] awight: let me test Amazon locally if we're doing that big an SDK change [23:09:22] Thanks! [23:09:37] I'm gonna test staging things locally... [23:10:22] (CR) jenkins-bot: [V: -1] Update package pointers [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280125 (owner: Awight) [23:11:08] blarg! [23:11:13] .git dir missing... [23:11:25] jive indeed [23:15:05] that one. newer composers do the rm -r invisibly, I just discovered [23:15:37] awight: amazon adapter needs code updates to deal with the lib update [23:16:27] Let's leave vendor/ out of this entirely, then. [23:16:34] i concur [23:16:44] The only other worthwhile thing was to get that error checking in PHP-queue [23:16:51] ah, word [23:17:01] that would be nice [23:19:35] (CR) Ejegg: [C: -1] "Requires Amazon adapter code updates" [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/280124 (owner: Awight) [23:29:20] Errors -> Correcting currency example form doesn't alert, this must have regressed earlier. [23:29:32] oh? [23:29:58] I think that's got a task in phab [23:29:59] http://payments.dev/index.php?title=Special:PayPalGateway&appeal=JimmyQuote&ffname=paypal&recurring=&uselang=en&language=en¤cy=INR&country=US&amount=200.01 [23:30:14] ah, thanks! [23:30:46] hmm, not seeing it [23:30:47] (PS5) Krinkle: kvStoreMaintenance: Refactor to use requestIdleCallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/254326 (https://phabricator.wikimedia.org/T111456) [23:31:15] (CR) Krinkle: "Haven't tested yet." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/254326 (https://phabricator.wikimedia.org/T111456) (owner: Krinkle) [23:31:20] https://phabricator.wikimedia.org/T98447 [23:31:29] ahh, i see it now [23:32:46] what are your settings for wgDonationInterfaceFallbackCurrency and wgDonationInterfaceNotifyOnConvert ? [23:33:57] Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Assisted currency conversion for PayPal is broken again - https://phabricator.wikimedia.org/T98447#2156565 (awight) [23:34:11] $wgPaypalGatewayFallbackCurrency = 'USD'; [23:34:22] and nothing for NotifyOnConvert, aha [23:34:45] dang, default is true for that one... [23:34:52] (PS2) XenoRyet: Fix opt out fields for Civi imports [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280113 (https://phabricator.wikimedia.org/T130768) [23:35:07] https://payments.wikimedia.org/index.php?title=Special:PayPalGateway&appeal=JimmyQuote&ffname=paypal&recurring=&uselang=en&language=en¤cy=INR&country=US&amount=200.01 [23:35:22] yeah, it no sirve on production, neither [23:35:39] phooey [23:35:49] (CR) XenoRyet: Fix opt out fields for Civi imports (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280113 (https://phabricator.wikimedia.org/T130768) (owner: XenoRyet) [23:36:56] (PS3) XenoRyet: Fix opt out fields for Civi imports [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280113 (https://phabricator.wikimedia.org/T130768) [23:38:24] array (\n 'general' => 'Your currency was unsupported. Processing will take place using USD, if you decide to continue.',\n) [23:38:39] but the error isn't preventing the redirect [23:38:46] Ohh, I see [23:38:58] So maybe that never quite worked? [23:39:07] Or... errors should prevent redirect. [23:39:54] I think it worked exactly once [23:41:39] GatewayPage.php line 390, we make a big switch statement, and PaymentResult::getRedirect is tested before getErrors. [23:41:45] How could this have been so wrong? [23:41:48] ooh, damn! [23:42:11] ejegg: I'm not sure I understood your comment on https://gerrit.wikimedia.org/r/#/c/277448/1 [23:42:48] eileen: lemme refresh my memory... [23:47:55] Wikimedia-Fundraising, Operations, Traffic, HTTPS, Patch-For-Review: delete links.email.donate.wikimedia.org (and all other email.donate.*?) from DNS - https://phabricator.wikimedia.org/T130414#2156614 (CCogdill_WMF) @Dzahn I've confirmed it's fine on our side to delete all the subdomains you... [23:50:13] (CR) Ejegg: "Oops, I saw main_id and other_id in Merger.php lines 668 and 671 and assumed they needed to change as well. But it looks like those are r" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277448 (owner: Eileen) [23:51:33] (CR) Eileen: "Yeah - I don't think they are transposed there either - it was the fact they seemed to be incorrect that drove me to do something about th" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277448 (owner: Eileen) [23:52:27] (CR) Eileen: "(ie. the api was transposing the names from what I could tell - so I added some new params that clarified it)" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277448 (owner: Eileen) [23:52:53] Okay, this is a fascinatingly deep rabbit hole but I'm gonna stop looking at this old bug and keep testing... [23:53:33] sometimes all you find in rabbit holes is … rabbbits [23:54:09] (triple b was a mistake but it you drink enough coffee you will be able to try to find meaning in it …) [23:59:32] :) I would love to have a flock of rabbbits dwelling beneath my yard