[00:02:06] ejegg: huh. What do you think about GatewayAdapter::validatedOK? [00:02:24] Shouldn't that return !getAllErrors? [00:02:38] looking [00:03:51] hmm, technically it's asking about validation... [00:04:07] but let's see [00:04:16] I'm not sure how to categorize "manual" errors, maybe. [00:05:04] that currency correction error is pretty solidly a validation issue [00:05:27] ahh [00:05:42] so, we should probably add that to the correct error array [00:05:52] if that's possible [00:06:09] good fix. I'll do it [00:06:17] thanks! [00:06:45] awight: you wouldn't - rabbits ate my fledgline orchard. My blueberry bush never recovered :-( [00:07:18] awight: ah, I think we had to use manual_errors before because the fallback code wasn't in DonationData [00:07:28] ooh [00:07:53] Probably I missed something in transposing the code too [00:09:27] token-mismatch is being set as a manual error, that seems very validationy to me [00:09:32] yep, 973123e447c06846cbdd4836dc9830e2b342cedb [00:10:04] There was code in gateway_page to set validated_ok to false when adding the notice [00:10:16] getTransactionResponse()->getErrors() is not validationy, so that's interesting [00:10:29] good find! [00:10:34] those get added to validation_errors? [00:10:47] no, to manual_errors [00:10:55] ah, ok [00:10:59] maybe we should rename "transaction_errors". [00:11:27] definitely more descriptive! [00:11:58] but addManualError needs to to either array? gross. [00:12:02] *add [00:13:49] testFallbackWithNotification is too unity [00:14:40] yah, guess it needs to run the whole circus and check for redirect [00:14:47] or, I could just test for this specific regression, that manual validation errors stop processing. [00:16:32] horrendously out of place, previously flagged chunk at GatewayPage.php line 432 has got to go... [00:20:58] the iframe bit? [00:21:19] ooh, yep [00:21:26] oops, my file was patched. the FIXME about errors. [00:21:45] we should not be adding manual errors in gatewaypage... [00:22:11] ack, nope, we sure shouldn't [00:24:12] should pass the result into getForm, probably [00:31:38] (PS1) Awight: [WIP] Change meaning of validation variables [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280141 (https://phabricator.wikimedia.org/T98447) [00:32:49] (CR) jenkins-bot: [V: -1] [WIP] Change meaning of validation variables [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280141 (https://phabricator.wikimedia.org/T98447) (owner: Awight) [00:33:19] ejegg: awight: XenoRyet: earlier chatting w/ dstrine, was wondering what CR specifically might be most useful for me to jump on, or if I should pull in a new CN task...... any thoughts? [00:33:36] ejegg: Thank you ten more times for those extra test URLs in Main_Page.wiki [00:33:36] eileen: ^ [00:33:46] hehe, interception! [00:34:08] AndyRussG: all my CR wishes have been granted (thanks everyone!) [00:34:38] ejegg: no stragglers here? https://phabricator.wikimedia.org/T130075 [00:35:40] AndyRussG: I have quite a few things queued - but I'm not sure any of them are easy to get your head into if you haven't done much CiviCRM - I suspect it might be better not to grab a new CN ticket [00:36:13] (PS2) Awight: Dump queue to file, leaving messages [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/278409 (owner: Ejegg) [00:36:37] (CR) Awight: [C: 2] "Nice hack!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/278409 (owner: Ejegg) [00:36:55] AndyRussG: not that I know of - I haven't got anything for that ticket, and I already reviewed awight's worldpay patch [00:37:42] ejegg: ah oops, I thought I'd seen some patches of urs on that one... awight? [00:38:01] eileen: K thanks! .... mmm any particularly easy ones, maybe? [00:39:15] AndyRussG: Is that pending deployment one deployed? https://phabricator.wikimedia.org/T120082 [00:39:56] awight: no it's not but it's unurgent enuf that I thought I might wait until there's a bit more to deploy [00:40:10] phew, getting pretty late here... Think I'm going to sign off for now [00:40:17] ejegg: cya! [00:40:18] AndyRussG: or you could put it on the train. [00:40:25] ejegg: bye! [00:40:25] awight: true [00:40:33] K [00:41:49] AndyRussG: I've got a relatively small Civi patch in review. ejegg took a first pass at it, but more eyes are always welcome. https://phabricator.wikimedia.org/T130768 [00:42:00] XenoRyet: K! [00:42:18] AndyRussG: There's also trudging through the queue quagmire with me, if that sounds interesting [00:42:56] awight: sure also happy to do so... I've once or twice run 1/2 a Kafka command or so [00:43:03] AndyRussG: you might have some ideas how to get past the test env related issues on this one https://gerrit.wikimedia.org/r/#/c/277947/ - it can't find exchange rates in the test scenario... [00:43:22] (looks like you have lots of work ideas now :-) [00:43:43] eileen: cool thx! [00:45:44] awight: at least I could stand in for a rubber duck [00:45:56] * AndyRussG takes notes on all the above [00:46:02] thx much all! [00:47:15] (Merged) jenkins-bot: Dump queue to file, leaving messages [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/278409 (owner: Ejegg) [00:48:26] AndyRussG: thanks! did you happen to see the spreadsheet of impending doom? https://docs.google.com/spreadsheets/d/1lkle5RJNG33z6c3u1czQS_0scnyLX-X57Sh4W3dyCl4/edit#gid=0 [00:49:22] hmmm no not yet [00:49:31] AndyRussG: https://www.youtube.com/watch?v=B8IfCSnYPYo [00:52:42] eileen: nice! [00:53:20] :-) [00:54:25] D'oh! I don't have the Adyen test creds [00:55:30] awight: Hmmm I think I have what u need, I could OTR'em to you [00:56:28] AndyRussG: sure, thanks! [01:10:01] supermarket run! [01:10:10] bye 4 now [05:39:43] (CR) Awight: "I really like it! glacially more incremental suggestion inline." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278298 (owner: Cdentinger) [05:46:25] (CR) Awight: [C: -2] [WIP] looking at direct kafka integration. (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/279745 (https://phabricator.wikimedia.org/T130304) (owner: Awight) [05:49:13] (PS1) Eileen: CRM-18310 add tests for debug logging and option to specify log format, fix caching error [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280156 (https://phabricator.wikimedia.org/T127133) [05:49:15] (PS1) Eileen: CRM-18212 allow triggers to be managed offline. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280157 (https://phabricator.wikimedia.org/T128133) [05:51:15] (CR) jenkins-bot: [V: -1] CRM-18212 allow triggers to be managed offline. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280157 (https://phabricator.wikimedia.org/T128133) (owner: Eileen) [06:36:20] (PS1) Awight: [WIP] Kafka backend [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/280158 [07:00:21] (PS1) Eileen: Remove commenting [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280160 [07:01:57] (CR) jenkins-bot: [V: -1] Remove commenting [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280160 (owner: Eileen) [07:11:23] (PS2) Eileen: CRM-18310 add tests for debug logging and option to specify log format, fix caching error. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280156 (https://phabricator.wikimedia.org/T127133) [07:12:08] (PS2) Eileen: CRM-18212 allow triggers to be managed offline. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280157 (https://phabricator.wikimedia.org/T127133) [07:12:29] (PS2) Eileen: Remove commenting [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280160 (https://phabricator.wikimedia.org/T127133) [07:13:39] (CR) jenkins-bot: [V: -1] CRM-18212 allow triggers to be managed offline. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280157 (https://phabricator.wikimedia.org/T127133) (owner: Eileen) [07:14:56] (CR) jenkins-bot: [V: -1] Remove commenting [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280160 (https://phabricator.wikimedia.org/T127133) (owner: Eileen) [07:25:50] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising-Backlog, Patch-For-Review: Deploy Thank you letters to remove Lila's signature - https://phabricator.wikimedia.org/T129373#2157176 (jrobell) @Ejegg Let's delete Arabic and Polish from civi and use English for... [13:49:34] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: how was Ingenico chargeback already present as a refund? - https://phabricator.wikimedia.org/T131154#2157585 (MBeat33) [14:07:33] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: are Ingenico chargebacks creating errors in Civi? - https://phabricator.wikimedia.org/T131154#2157605 (MBeat33) [16:22:16] Fundraising-Backlog: SPRINT G (3/30 - 4/13) GOAL: - https://phabricator.wikimedia.org/T131160#2157866 (DStrine) [16:22:53] Fundraising-Backlog: SPRINT H (4/13-4/27) GOAL: - https://phabricator.wikimedia.org/T131161#2157879 (DStrine) [16:23:28] Fundraising-Backlog: SPRINT I (4/27-5/11) GOAL: - https://phabricator.wikimedia.org/T131162#2157904 (DStrine) [16:27:15] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 4 others: Some Ingenico donations not in Civi - https://phabricator.wikimedia.org/T122730#2157908 (cwdent) @MBeat33 they finally posted the right fi... [16:27:42] welcome back cwd! [16:27:56] ty :) [16:27:57] how'd the weather work out? [16:28:12] perfectly [16:28:18] we danced around a bunch of storms [16:28:18] sweet! [16:28:21] but really lucked out [16:28:52] so glad to hear it [16:33:55] welcome back cwd ! [16:34:08] glad to hear things went well [16:34:27] thanks! it was splendid all around [16:34:44] cool! [16:38:08] (PS2) Ejegg: Remove obsolete TY letters [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280085 (https://phabricator.wikimedia.org/T129373) [16:38:29] (PS3) Ejegg: Remove obsolete TY letters [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280085 (https://phabricator.wikimedia.org/T129373) [16:39:11] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 4 others: Some Ingenico donations not in Civi - https://phabricator.wikimedia.org/T122730#2157946 (MBeat33) thanks, @cwdent. Some of them have arriv... [16:43:14] (PS4) Ejegg: Remove obsolete TY letters [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280085 (https://phabricator.wikimedia.org/T129373) [16:43:15] hey cwd! Way to go!!!!! [16:43:32] pics? [16:43:48] (if u feel like it... no pressure of course :) ) [16:44:24] :) thanks AndyRussG -- will have some soon, my dad was the photographer and he takes awhile to get them on the computer [16:44:35] Ah cool! [16:45:11] Actually I think the album of low-res photos a friend took of our wedding were the first photos someone shared w/ me over the net [16:45:18] Some Yahoo service, it was [16:45:29] nice [16:45:30] 2004 [16:45:31] nostalgia [16:45:43] fer sure [16:46:10] (PS5) Ejegg: Remove obsolete TY letters [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280085 (https://phabricator.wikimedia.org/T129373) [16:47:20] (PS1) Ejegg: New TY letters for executive director transition [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280252 (https://phabricator.wikimedia.org/T129373) [16:48:07] OK, for real this time, new TY letters ready for review + deployment ^^ [16:49:56] but for now I'm going to deploy SmashPig [16:53:58] i still can't get in to gerrit [16:54:03] * cwd beats head on keyboard [16:58:42] Hmmm man that's rough [17:00:53] !log updated SmashPig from 9f08f6a1891b0a2bb70eacf460c2f9a8153c3b4e to 5cadcf3abcfcda4552b068c783337d82b743e2e5 [17:00:57] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [17:07:39] Fundraising Sprint Freshmaking, Fundraising-Backlog, Unplanned-Sprint-Work, FR-Smashpig, and 2 others: SmashPig should mock queues for tests - https://phabricator.wikimedia.org/T127880#2057293 (Ejegg) Open>Resolved [17:10:25] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising-Backlog, Unplanned-Sprint-Work, and 2 others: Only capture a single payment against any order ID - https://phabricator.wikimedia.org/T129935#2158062 (Ejegg) Open>Resolved [17:19:36] (PS2) Ejegg: Update package pointers, Amazon class names [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280125 (owner: Awight) [17:21:51] (CR) Awight: [C: 2] "Ratified!" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280125 (owner: Awight) [17:22:36] (CR) jenkins-bot: [V: -1] Update package pointers, Amazon class names [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280125 (owner: Awight) [17:23:01] Does this look like the right order? https://www.mediawiki.org/wiki/Fundraising_tech/Message_queues#Overhaul_2016 [17:23:07] Maybe contribution_tracking is #2? [17:23:54] awight: Think that job needs https://gerrit.wikimedia.org/r/280261 [17:24:12] will live-hack it for now [17:24:33] * awight blinks [17:24:49] Whew, for a moment I thought I had left the DI deployment branch stale all night [17:24:51] oh, let me get that use statement in there too [17:25:13] (CR) jenkins-bot: [V: -1] Update package pointers, Amazon class names [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280125 (owner: Awight) [17:25:35] ejegg: Is that JJB patch enough? [17:25:52] I don't see the part which calls the composer install macro [17:26:00] (PS3) Ejegg: Update package pointers, Amazon class names [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280125 (owner: Awight) [17:26:11] awight: that bit was already there! [17:27:36] ah jeez, breaks the standard hhvm/1.27 tests now [17:27:44] grr [17:28:03] (CR) jenkins-bot: [V: -1] Update package pointers, Amazon class names [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280125 (owner: Awight) [17:29:50] (PS4) Ejegg: Update package pointers, Amazon class names [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280125 (owner: Awight) [17:30:51] (CR) jenkins-bot: [V: -1] Update package pointers, Amazon class names [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280125 (owner: Awight) [17:30:53] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 4 others: Some Ingenico donations not in Civi - https://phabricator.wikimedia.org/T122730#2158267 (cwdent) Sigh, yeah those are all in the CSV file... [17:33:31] (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280125 (owner: Awight) [17:35:44] ejegg: This isn't a blocker, but I need you to walk me through Adyen testing at some point... [17:36:06] We should seriously have some sort of biannual retraining program [17:36:20] (CR) Ejegg: "want to put the strtolower back in?" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280113 (https://phabricator.wikimedia.org/T130768) (owner: XenoRyet) [17:36:30] I'll also use my rediscovered ignorance to update the docs ;) [17:36:49] awight: should be pretty straightforward - just use test credentials and url [17:36:53] (CR) XenoRyet: "whoops, yea." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280113 (https://phabricator.wikimedia.org/T130768) (owner: XenoRyet) [17:37:00] ejegg: Is the VPN needed? [17:38:33] (PS4) XenoRyet: Fix opt out fields for Civi imports [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280113 (https://phabricator.wikimedia.org/T130768) [17:49:28] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising-Backlog, Unplanned-Sprint-Work, WMF FR: Ingenico ePayments Partners with Trustwave for PCI Compliance - https://phabricator.wikimedia.org/T129596#2158307 (Ppena) @awight and @DStrine Hey guys- if this is... [17:51:25] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising-Backlog, Unplanned-Sprint-Work, WMF FR: Ingenico ePayments Partners with Trustwave for PCI Compliance - https://phabricator.wikimedia.org/T129596#2158311 (awight) @Ppena I completely misunderstood your re... [17:52:29] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 6 others: Civi exports timing out - https://phabricator.wikimedia.org/T120892#1864231 (DStrine) @Eileenmcnaughton and @MBeat33 can this be resolve... [17:52:54] dstrine: Just a heads-up, this is suddenly an emergency, deadline is Mar 31. https://phabricator.wikimedia.org/T129596 [17:53:28] I mysteriously thought it was related to the other PCI task, and missed the request to fill out a new SAQ form. [17:55:27] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 6 others: Civi exports timing out - https://phabricator.wikimedia.org/T120892#2158330 (MBeat33) Open>Resolved I'm fine with marking this Resol... [17:56:06] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 4 others: LYBUNT related: Fiscal Year report does not work - https://phabricator.wikimedia.org/T123671#2158333 (DStrine) @Eileenmcnaughton did you... [17:58:36] (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280125 (owner: Awight) [18:07:00] Fundraising-Backlog: Civi merge unsubscribe no longer working - https://phabricator.wikimedia.org/T130660#2158378 (CCogdill_WMF) p:Triage>High [18:07:18] (CR) XenoRyet: [C: 2] Remove obsolete TY letters [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280085 (https://phabricator.wikimedia.org/T129373) (owner: Ejegg) [18:08:51] (Merged) jenkins-bot: Remove obsolete TY letters [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280085 (https://phabricator.wikimedia.org/T129373) (owner: Ejegg) [18:10:28] (CR) AndyRussG: Fix opt out fields for Civi imports (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280113 (https://phabricator.wikimedia.org/T130768) (owner: XenoRyet) [18:18:22] (PS1) Ejegg: Currency selector should exist, even if hidden [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280266 [18:19:37] awight / cwd / XenoRyet: ^^^ just realized I messed up that last currency selector patch pretty bad, but that should fix it [18:20:08] if only i could log in to gerrit [18:20:24] aw man, still locked out... [18:21:29] (Abandoned) Awight: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/280127 (owner: Awight) [18:21:30] yeah, going back and forth about it [18:21:42] ejegg: https://gerrit.wikimedia.org/r/#/c/280121/1 [18:21:49] is 5fac [18:22:16] cwd: like, "is this even worth fixing"? :p [18:22:25] oh, gotcha. lemme try [18:22:46] haha...back and forth with external parties [18:22:55] I'd like to deploy https://gerrit.wikimedia.org/r/280266 today too if possible [18:23:04] "should i stay or should i go now" [18:24:29] (CR) Awight: [C: 2] Currency selector should exist, even if hidden (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280266 (owner: Ejegg) [18:24:35] awight: still working for me on that patch [18:24:44] ok, great! [18:24:52] The last one (?) i didn't test was Amazon... [18:25:19] They have both of my accounts locked uggggh [18:25:49] (Merged) jenkins-bot: Currency selector should exist, even if hidden [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280266 (owner: Ejegg) [18:25:57] awight I tested Amazon with the sandbox creds, let me try one more time [18:26:24] wheee! [18:26:45] I think we're good to go, then. lemme merge that last patch [18:27:27] (CR) Ejegg: Currency selector should exist, even if hidden (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280266 (owner: Ejegg) [18:29:03] (CR) Awight: Currency selector should exist, even if hidden (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280266 (owner: Ejegg) [18:31:18] (PS1) Awight: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/280269 [18:32:40] (CR) XenoRyet: Fix opt out fields for Civi imports (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280113 (https://phabricator.wikimedia.org/T130768) (owner: XenoRyet) [18:33:03] (PS1) Ejegg: Shorter selector for .hidden [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280270 [18:33:05] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 4 others: Some Ingenico donations not in Civi - https://phabricator.wikimedia.org/T122730#2158547 (cwdent) Scratch that, I was searching by ID rathe... [18:33:10] eileen: hi! By chance do u have on hand a pointer to some doc on how to run civi tests? So far only found https://wiki.civicrm.org/confluence/display/CRMDOC/Testing [18:34:10] AndyRussG: n.b. there are a few suites of core Civi tests, but the PHPUnit tests for our custom modules are a separate thing... [18:34:32] awight: ahh hrrmm yeah I was wondering.... [18:34:39] (CR) Ejegg: "good call awight, done in Ibe7905fb9a719c907800e932822f51a01029246f" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/280266 (owner: Ejegg) [18:36:00] How should they run? [18:36:23] The WMF tests should just be a "phpunit" at the top level of the crm/ project [18:37:34] * awight has that totally not work [18:39:27] every time i phpunit [18:40:13] I've heard some otherwise very level people go way off into ragespace talking about that software and author [18:40:50] Hmm [18:41:02] it's pretty hard to separate the two when it prints his name every time you run it [18:41:30] It's not even printing His name for me [18:41:38] so you know it's gotta be badly damaged [18:42:09] Hilarious place to attempt self-promotion. [18:42:17] Hahah [18:42:21] It's like making a pinyata with your own face on it [18:42:34] * awight apologizes for enyay [18:43:06] kids, scramble for my candy vomit! [18:43:11] (PS5) XenoRyet: Fix opt out fields for Civi imports [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280113 (https://phabricator.wikimedia.org/T130768) [18:43:11] or brains [18:43:17] hehehe [18:43:30] that tradition freaks me out [18:43:41] of course it was all I wanted to do as a kid, though [18:44:00] ... and they wouldn't let me! All i wanted was a Pep$i... [18:44:09] heh [18:44:56] (CR) jenkins-bot: [V: -1] Fix opt out fields for Civi imports [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280113 (https://phabricator.wikimedia.org/T130768) (owner: XenoRyet) [18:45:41] My main beef with it is not with the hitting of some cartoon character or something, but what you're doing by making a ritual of a melee of kids pushing each other and grabbing for candies [18:46:06] It's interesting, because the work of actually breaking it open is collective, everyone takes a turn hitting the thing [18:46:25] But the fruits of the labour? not so much [18:47:00] * awight calms myself down with a video... https://www.youtube.com/watch?v=LoF_a0-7xVQ [18:47:07] Ha I have some family that I can't say that around, however [18:47:33] Interesting! I hadn't gotten that far in my thought process, I was still marveling at "Hit him in the belly button!!!" [18:48:28] (PS6) XenoRyet: Fix opt out fields for Civi imports [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280113 (https://phabricator.wikimedia.org/T130768) [18:49:23] hmmm [18:49:32] I bet there are studies of that [18:50:51] :D [18:51:38] It would be funny if barn raisings ended like that... everyone just steals your chickens and runs away to a corner to prepare and gnaw [18:51:54] Hmm 30 seconds of googling didn't find anything [18:52:15] Hahah [18:53:07] Fundraising-Backlog: Ingenico: iDEAL 'no valid providers' error - https://phabricator.wikimedia.org/T131181#2158572 (Krenair) [18:53:10] (There are of course collective work practices akin to barn raising in a lot of communities in Mex...) [18:53:51] https://es.wikipedia.org/wiki/Tequio [18:55:55] /vagrant/srv/org.wikimedia.civicrm$ phpunit [18:55:55] CiviCRM does not have permission to write temp files in /vagrant/srv/org.wikimedia.civicrm/drupal/sites/default/files/civicrm/templates_c/en_US/, Exiting [18:56:16] AndyRussG: ah, that's annoying [18:56:50] gotta make the files dir writable by both the www user and your user if you want to run tests [18:58:13] ejegg: ah K thx... so sites/default/files and recursive I guess? [18:58:21] yarp [19:00:05] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 6 others: Civi exports timing out - https://phabricator.wikimedia.org/T120892#2158580 (JCuriel) Thanks for fixing this! [19:00:20] dstrine: be there in 1 or 2 min [19:02:24] eileen: and awight meeting? [19:11:30] Fundraising Tech Backlog, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Performance: Move CentralNotice stuff out of cookies - https://phabricator.wikimedia.org/T108849#2158599 (DStrine) [19:14:06] awight: and eileen are you around? [19:14:44] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: are Ingenico chargebacks creating errors in Civi? - https://phabricator.wikimedia.org/T131154#2157585 (DStrine) p:Triage>Normal [19:16:08] dstrine: hi! [19:16:19] awight: want to join a meeting? [19:16:20] wat. sorry [19:16:24] we are in backlog grooming [19:17:59] Fundraising-Backlog, fundraising-tech-ops, DNS, Operations, Traffic: Updating DNS records for Major Gifts subdomain (benefactors.wikimedia.org) - https://phabricator.wikimedia.org/T130937#2158625 (DStrine) a:Jgreen [19:19:25] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, MediaWiki-extensions-DonationInterface, Epic, and 3 others: [EPIC] Clean up "pending" queue usages - https://phabricator.wikimedia.org/T130897#2158638 (DStrine) [19:22:32] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: fix 'recurring donations by payment method + date range' search - https://phabricator.wikimedia.org/T131094#2155849 (DStrine) p:Triage>Normal [19:24:21] Fundraising-Backlog: Weird CIVI result for FIND CONTRIB - https://phabricator.wikimedia.org/T130965#2158656 (DStrine) p:Triage>Normal [19:29:11] Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, and 3 others: Pull profiling code out of gateway adapter - https://phabricator.wikimedia.org/T130055#2123918 (Ejegg) Open>Resolved [19:35:44] Fundraising-Backlog: Ingenico: iDEAL 'no valid providers' error - https://phabricator.wikimedia.org/T131181#2158697 (MBeat33) p:Normal>High So it turns out that one of the banks, Knab, yields this error - donors get an unresponsive form and I'm able to replicate it. Can we remove this bank from the opt... [19:49:34] awight: you need some headphones dude [19:52:55] badly. [19:55:28] Fundraising-Backlog: Ingenico: iDEAL 'no valid providers' error from one unavailable bank - https://phabricator.wikimedia.org/T131181#2158757 (MBeat33) [19:57:52] wow, I wish I'd realized it was an issue earlier! [19:59:08] that's the rub of the echo thing, there's no way to know when it's happening to you [19:59:37] we need the app for throwing recalcitrant participants onto a pyre [20:00:02] AndyRussG: I'd be thrilled to get queue feedback any time, you name it [20:01:03] awight: K! I'm gonna take a few minutes to organize my afternoon, kids just got back during the meating... I'll get back to u shortly then? [20:01:17] sure! [20:02:23] (CR) XenoRyet: [C: 2] New TY letters for executive director transition [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280252 (https://phabricator.wikimedia.org/T129373) (owner: Ejegg) [20:05:21] (Merged) jenkins-bot: New TY letters for executive director transition [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280252 (https://phabricator.wikimedia.org/T129373) (owner: Ejegg) [20:06:54] fundraising-tech-ops, Mail, Operations: (re)move problemsdonating aliases - https://phabricator.wikimedia.org/T127488#2045104 (Nemo_bis) problemsdonating@ was recently mentioned as being active and recommended https://meta.wikimedia.org/w/index.php?title=Fundraising&diff=15151567&oldid=15148573 [20:08:12] (CR) Awight: [C: 2] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/280121 (owner: Awight) [20:08:22] (CR) Awight: [C: 2] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/280269 (owner: Awight) [20:09:39] (Merged) jenkins-bot: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/280121 (owner: Awight) [20:09:58] fundraising-tech-ops, Mail, Operations: (re)move problemsdonating aliases - https://phabricator.wikimedia.org/T127488#2158803 (CCogdill_WMF) Hey @Dzahn, sorry I missed the ping on this. Nemo is right, problemsdonating@ is even referenced on our donation form on donate.wikimedia.org. This is a high tra... [20:10:42] (Merged) jenkins-bot: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/280269 (owner: Awight) [20:11:48] looks like payments deploy is a go... [20:13:09] (PS1) Awight: update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/280280 [20:13:45] (CR) Awight: [C: 2] update DonationInterface submodule [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/280280 (owner: Awight) [20:21:42] (PS1) Ejegg: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/280282 [20:22:29] (CR) Ejegg: [C: 2 V: 2] "This time for sure!" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/280282 (owner: Ejegg) [20:23:24] MBeat: warning, I'm deploying a risky payments patch in a few minutes. [20:23:41] ty for heads-up, awight [20:24:37] !log disabled thank you mail send [20:24:40] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [20:26:25] !log update payments from 5a1996bc21fe694b99556bc1b501e484075dabe2 to a9659965d8b55b11518680a1170242f311c7f1d2 [20:26:29] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [20:26:46] rolling back. [20:26:56] damn [20:27:07] fundraising-tech-ops, Mail, Operations: (re)move problemsdonating aliases - https://phabricator.wikimedia.org/T127488#2158821 (Dzahn) Hi! thank you. In that case i would just like to move them over to be controlled by OIT, like we did with other group aliases. It's not even about problemsdonating@,... [20:27:11] I killed the form chooser, huh? [20:27:23] !log rolled back payments to 5a1996bc21fe694b99556bc1b501e484075dabe2 [20:27:27] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [20:27:50] MBeat: A handful of people failed to get a form for NL, doesn't seem like anything more serious though. [20:28:12] so... there are links with payment_method=rtbt.rtbt_ideal [20:28:23] that's what I was wondering, too... [20:28:30] can we retreive email addresses to contact them, awight? [20:28:33] damn, is that a standard thing? lemme see [20:28:46] MBeat: they didn't get an email entry even, sorry [20:28:47] or did they not get that far? [20:28:51] thx [20:29:15] fundraising-tech-ops, Mail, Operations: (re)move problemsdonating aliases - https://phabricator.wikimedia.org/T127488#2158824 (Dzahn) @bbogaert could we add "problems.donating@ , problemdonating@ and problem.donating@" as variants / aliases of the existing problemsdonating@ address? [20:29:30] ejegg: The two instances of that string pre-deployment were different errors, though... [20:29:50] oh? [20:30:12] yeah, fwiw grep rtbt.rtbt_ideal payments.error [20:32:41] maybe payment_method has junkier junk than paymentmethod [20:33:06] testing that banner now [20:34:42] yep, something's adding payment_method to the formchooser POST [20:36:06] devious! [20:36:33] if( paymentSubMethod != '' ) { [20:36:33] form.payment_method.value = form.payment_method.value + '.' + paymentSubMethod; [20:36:36] } [20:36:42] wow, good find [20:37:13] wishful thinking... perhaps we should be liberal about inputs? [20:37:31] https://meta.wikimedia.org/wiki/MediaWiki:FR2013/Resources/BannerFormCore.js [20:37:38] but... more bang for the money to fix the calling code [20:38:00] awight liberal sounds good, especially since you want to move to a unified payment method [20:38:03] * awight grinds out cigarrette on "2013" [20:38:13] split on '.' is an easy fix [20:38:25] PaymentMethod should already have that... [20:38:57] gah. it splits on "_" [20:39:29] i ran into this the other day [20:39:46] Nope, I misread. [20:40:08] cwd: Where did it come up as an issue? [20:40:40] it was when i was adding the submethod input to mustache i think [20:40:54] and found the method.submethod syntax [20:41:16] This has got to stop ;) [20:41:31] which thing in particular? [20:42:02] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 4 others: LYBUNT related: Fiscal Year report does not work - https://phabricator.wikimedia.org/T123671#2158865 (Eileenmcnaughton) I didn't get a rep... [20:42:09] obscure pseudoconventions around the payment method stuff... [20:42:21] it doesn't strike me as a bad thing to support but it'd be nice if they were all described in a central place [20:42:22] awight: how is around 2 pm PST for chatting about queues? [20:43:01] the-wub: Mind if we hack on MediaWiki:FR2013/Resources/BannerFormCore.js ? [20:43:23] AndyRussG: sure! I might have to keep an eye on these deployment logs, but if things go well that won't be a big deal. [20:43:37] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 6 others: Civi exports timing out - https://phabricator.wikimedia.org/T120892#2158866 (Eileenmcnaughton) happy exporting [20:43:50] the-wub small change: set payment_method and payment_submethod to the same things as paymentmethod and submethod [20:43:59] instead of the dotted syntax [20:44:31] then later get rid of paymentmethod and submethod [20:45:47] awight d'oh, DonationData does split on '.' [20:47:04] aargh, but the order of preference is reversed [20:47:15] yah, gotta stanch this at the source [20:47:19] brutal [20:47:48] Well, that's a big old TODO [20:47:49] https://meta.wikimedia.org/w/index.php?title=MediaWiki:FR2013/Resources/BannerFormCore.js&diff=15484967&oldid=15070860 [20:48:51] * ejegg twitches at global js var [20:49:17] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Stop proliferation of payment_method syntaxes - https://phabricator.wikimedia.org/T131194#2158877 (awight) [20:49:39] seems like the config refactor is a step in the direction of having an explicit list of inputs and outputs for payment method [20:50:10] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Stop proliferation of payment_method syntaxes - https://phabricator.wikimedia.org/T131194#2158890 (awight) Brainstorm how to get this into source control: https://meta.wikimedia.org/w/index.php?title=MediaWiki:FR2013/Resources/BannerFormCore.js [20:50:32] cwd: yeah, plus actual runtime configuration admin and display. [20:50:55] and generalized logic to do stuff about country, currency, language and method support... [20:51:03] awight still editing that? going to add 'var' before full_dotted... [20:51:11] ah please do [20:51:46] awight: or also around 5pm PST is cool [20:52:06] !log update payments from 5a1996bc21fe694b99556bc1b501e484075dabe2 to a9659965d8b55b11518680a1170242f311c7f1d2 [20:52:11] MBeat: going for a second try [20:52:13] (PS1) Eileen: Add debug on phone create api call [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280325 [20:52:28] AndyRussG: I'll know in a second whether there'll be anything smoldering... [20:52:39] Ah K :) [20:53:21] hey ejegg I see you just pushed out that patch - did you run drush updb or do I need to? [20:53:35] eileen: i haven't actually rsynced yet [20:53:38] !log rollback payments [20:53:41] ah OK [20:53:42] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [20:53:44] cached js. [20:53:48] how long the... [20:54:27] ah dang, depends how long ppl leave the page open before they click the banner [20:54:49] ok. I'll wait another hour... [20:55:07] AndyRussG: 2 PDT suddenly works very well :) [20:55:25] awight: great! K just reading the doc now :) maybe 2:05? [20:55:35] If anyone wants to do a quick QA - this one should be v straight forward https://gerrit.wikimedia.org/r/#/c/280325/ [20:55:51] word. I'll finish the TY deploy as soon as I get out of K4 1:1 [20:56:10] ejegg: I did see a few good ones from that same campaign, so it looks like a safe deployment once that file is purged. [20:56:21] actually... lemme see if I can purge explicitly [20:56:21] oh good [20:56:46] DOnno if that worked. [20:56:59] AndyRussG: perfect [20:57:17] :) [21:06:58] awight: netime [21:11:49] (CR) Cdentinger: move worldpay payment methods (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278292 (owner: Cdentinger) [21:17:53] AndyRussG: https://phabricator.wikimedia.org/T130304 [21:29:07] (CR) Ejegg: move worldpay payment methods (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278292 (owner: Cdentinger) [21:32:37] !log updated CiviCRM from 18431eec74de251066deb77d5b63607e06f6f135 to bfe563f2451725e734d6ddbddb3be716463a3512 [21:32:42] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:35:36] ejegg: with the amount of array_* functions in php isn't it annoying that there's not a quick way to say "give me the key for the first instance of this value" [21:35:52] re: api names [21:35:53] doesn't array_search do that? [21:35:55] right? [21:36:01] oh, does it? [21:36:11] eileen: i'll be damned! [21:36:17] ty [21:36:32] :-) [21:36:58] i remember being surprised this one wasn't in core: https://github.com/sparkfun/SparkLib/blob/master/lib/SparkRecord.php#L12 [21:37:01] Fundraising-Backlog: Require email on iDEAL form - https://phabricator.wikimedia.org/T96074#2159042 (MBeat33) p:Normal>High We are still seeing issues from not requiring any personal info from iDEAL donors. In addition to losing donor email addresses for future appeals, it points the privacy-oriented t... [21:37:05] one gotcha with it is that people use it instead of in_array - but if the key is 0 that looks like a false [21:37:19] ejegg awight : sorry was away. that change to the banner code looks okay to me [21:38:17] thanks the-wub [21:38:53] eileen: it has a "strict" flag, in which php attempts to check types [21:38:57] * cwd gets popcorn [21:40:15] !log enabled thank you mail send job [21:40:19] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:42:56] oh hell, recurring thank yous have been failing silently [21:42:57] Fundraising Sprint Dirt Farming, Fundraising Sprint Elevator Maintenance 2016, Fundraising Sprint Freshmaking, Fundraising-Backlog, and 2 others: Make dedupe reversible step 1 of 5 test turning on logging on Staging to see how it performs. - https://phabricator.wikimedia.org/T127133#2033668 (Eileen... [21:43:07] gah! [21:44:03] (CR) Eileen: "Note that review comments on the upstream PR will help it get merged" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280156 (https://phabricator.wikimedia.org/T127133) (owner: Eileen) [21:44:44] cwd: Too bad PHP's flag for super confusing ambiguities is always enabled. [21:44:53] :-) [21:45:29] Fundraising Sprint Freshmaking, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: TY mails failing silently for recurring donations - https://phabricator.wikimedia.org/T131200#2159076 (Ejegg) p:Triage>High [21:45:45] MBeat: Trying the deployment again, we might jilt a few more NL donors. [21:47:23] Is anyone able to do a quick review on this - it's super straightforward https://gerrit.wikimedia.org/r/#/c/280325/ [21:47:36] looking [21:47:37] !log updating payments from 5a1996bc21fe694b99556bc1b501e484075dabe2 to a9659965d8b55b11518680a1170242f311c7f1d2 [21:47:40] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [21:48:04] ejegg: payments deploy looks good now! [21:48:10] eileen: erk, I totally forgot to updatedb after that deploy [21:48:35] awight: awesome! [21:49:09] (PS2) Ejegg: Add debug on phone create api call [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280325 (owner: Eileen) [21:52:04] ty awight [21:53:38] (CR) Ejegg: [C: 2] "Input... Need more input!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280325 (owner: Eileen) [21:56:08] (CR) Eileen: "Thanks!!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280325 (owner: Eileen) [21:56:25] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/280157 (https://phabricator.wikimedia.org/T127133) (owner: Eileen) [21:56:41] ejegg: should I go on & updb? [21:56:45] ok, ran the update, the activity for merge deletion should exist now [21:56:50] cool! [21:57:56] yep, just checked the db and it's there [21:58:10] ok, I gotta relocate. Be back in a bit [21:58:24] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: are Ingenico chargebacks creating errors in Civi? - https://phabricator.wikimedia.org/T131154#2159144 (MBeat33) [21:58:48] MBeat: This CTID tried and failed to donate using a mastercard 3 times in a row... [21:59:11] let me have a look [21:59:14] 34621690 [21:59:22] I think mc is working in general, though [22:00:25] is that a gc transaction ID, awight? [22:00:51] nvrmnd, found it as a merch ref [22:02:50] yes! contribution_tracking id. [22:02:58] we need a decoder ring somewhere... [22:03:11] ^^^ [22:03:28] i use zgrep [22:03:48] it's not elegant [22:04:07] (PS2) Eileen: CRM-18193 adapt reports to expect a 17 char string rather than 24 char varchar for log_conn_id [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/277924 (https://phabricator.wikimedia.org/T130161) [22:07:58] off on an errand, back in not too long! [22:21:08] MBeat:... PPena_ and I just tried to use ideal in the Netherlands form and IDEAL doesn't seem to be working [22:21:25] https://www.google.com/url?q=https%3A%2F%2Fdonate.wikimedia.org%2Fw%2Findex.php%3Ftitle%3DSpecial%3AFundraiserLandingPage%26country%3DNL%26uselang%3Den%26utm_medium%3Dspontaneous%26utm_source%3Dfr-redir%26utm_campaign%3Dspontaneous&sa=D&sntz=1&usg=AFQjCNHUT6_cnGURBht1pbt-pX2qxFG7PA [22:21:39] ah dang... [22:21:51] wow, thaks dstrine - that’s new [22:21:52] cwd: and awight|ft ^^ [22:21:58] immediate 'error processing request' ? [22:22:08] PPena_: found it [22:22:25] checking logs [22:22:30] eek [22:22:30] I'm going to make a totally separate task for this [22:22:41] ty for catching that [22:22:58] oh wow, and we're running in NL [22:23:07] Let me roll back the deployment and see if it helps. [22:23:11] MBeat: have you seen anything coming in lately that would give us a time frame for when it started? [22:23:32] I was testing the form like 2 hours ago and not getting that [22:23:38] dstrine: that's something to do with the deploy just now [22:23:46] We fixed the incoming links from banners [22:23:47] !log update payments to experimentally rollback [22:23:51] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [22:23:59] but the donation form needs it too [22:24:08] dstrine: PPena_: Please try donating using iDEAL again... [22:24:32] its back [22:24:34] magic? [22:24:38] removing currency fixed it for me [22:24:42] :P [22:24:45] mmm [22:24:49] nope, rolled back our deployment [22:24:51] cwd: it might have been my rollback [22:24:55] oh, heh [22:25:08] I made a change that checks some other qs params for payment method and submethod [22:25:11] I can test that localle... [22:25:19] ejegg: need CR? [22:25:21] and didn't realize those were being set with weird data in a lot of links [22:25:34] awight: I mean that change that got deployed [22:25:39] yes [22:25:48] gotcha [22:26:25] I can get to the billing information screen for ideal but I don't have an account with a bank. I've never gone further in the flow [22:26:47] its a fully hosted. its being director to the correct banks so its good [22:27:16] only KNAB (as reported my Michael) gets into a loop and dont get redirected [22:27:26] reports By* michael [22:28:00] PPena_: I'm not sure I understand that comment. the page I landed on is in dutch. I haven't tested this before [22:28:18] dstrine hangout? [22:28:33] will be easier [22:28:53] dstrine: How exactly was the page failing? [22:29:17] awight: FormChooserNot able to find a valid form [22:29:21] ah, thx [22:29:36] cwd: what was the URL that gave you that? [22:29:58] Testing locally, I'm seeing a different failure, where it won't redirect at all, with no errors. [22:30:06] awight: the one dstrine posted above [22:30:07] like, http://payments.dev/index.php/Special:GlobalCollectGateway?ffname=rtbt-ideal&language=en&country=NL&amountGiven=&frequency=onetime&uselang=en [22:30:12] :) k [22:30:27] https://payments.wikimedia.org/index.php?title=Special:GlobalCollectGateway&appeal=JimmyQuote&ffname=rtbt-ideal-noadd&recurring=&payment_method=rtbt.rtbt_ideal&utm_source=fr-redir.default%7Edefault%7Edefault%7Edefault%7Econtrol.rtbt.rtbt_ideal&utm_medium=spontaneous&utm_campaign=spontaneous&utm_key=&referrer=https%3A%2F%2Fwww.google.com%2Furl%3Fq%3Dhttps%253A%252F%252Fdonate.wikimedia.org%252Fw [22:30:29] %252Findex.php%253Ftitle%253DSpecial%253AFundraiserLandingPage%2526country%253DNL%2526uselang%253Den%2526utm_medium%253Dspontaneous%2526utm_source%253Dfr-redir%2526utm_campaign%253Dspontaneous%26sa%3DD%26sntz%3D1%26usg%3DAFQjCNHUT6_cnGURBht1pbt-pX2qxFG7PA&language=en&country=NL&returnto=Thank_You%2Fen&amountGiven=¤cy_code=EUR&frequency=onetime&amount=3&uselang=en [22:30:32] jeebus [22:31:14] aah, that wouldn't be right anyway [22:31:16] post rollback [22:31:33] oh no! account config? [22:31:34] NO VALID PROVIDERS FOUND FOR COMBINATION MERCHANTID: 6570, PAYMENTPRODUCT: 809, COUNTRYCODE: NL, CURRENCYCODE: EUR [22:32:51] Things look ok post rollback [22:32:58] thanks to PPena_ for catching that [22:33:32] awight: is the currency selector thing the only commit getting pushed and pulled? [22:34:09] no, it's the last two merges. [22:34:17] Down to 5a1996bc21fe694b99556bc1b501e484075dabe2 [22:34:20] gotcha [22:34:22] (mw-core repo) [22:34:25] the biggun [22:34:30] awight: ok, found the place in donatewiki that needs fixing [22:34:39] !! [22:41:02] (PS1) Eileen: Enable setting to specify logging is handled offline [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280336 (https://phabricator.wikimedia.org/T127133) [22:42:09] (PS1) Eileen: Also add 'Contact Deleted by Merge' on new installs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/280337 (https://phabricator.wikimedia.org/T119246) [22:47:19] dstrine: We changed some donatewiki javascript to be compatible with the new deployment, but I need to wait a few minutes before trying to deploy again, to let caches empty. [22:47:45] I think I'll be fine testing on my own, but wanted to give you a heads-up anyway. [22:47:45] i did action=purge, but just as well to wait for ppl dithering on the page [22:47:53] thanks! [22:48:03] awight: cool.. as long as IDEAL stays up for NL [22:48:26] yah, purge seems to have taken, got the new src in a different browser [22:48:39] ejegg: hehe, we should have a setTimeout(120) on donatewiki: alert("you are dithering!") [22:49:25] hand over the cash! [22:49:31] run them jewels! [22:50:56] moral for me: think harder about f'ing with legacy code... [22:57:38] Wow, this is some cathartic documentation to start: https://www.mediawiki.org/wiki/Fundraising_tech/Transaction_IDs?venotify=created [22:57:58] There are so many mines. [22:58:36] oh ya, that stuff sure needs explaining [22:59:39] nice awight [23:00:36] i have spent most of the afternoon grepping for txn IDs so i can grep for merchant refs [23:05:04] anybody think it would be dangerous to list titles for donatewiki templates? [23:05:13] ejegg: I think it's too late ;) [23:05:47] oh, are they documented some place already? [23:06:07] cwd: omg, now expanded with more ID types [23:06:21] ejegg: I meant, we're whitelisting all kinds of api.php already [23:06:34] You can get a list of valid users... [23:06:36] <_< [23:06:37] >_> [23:06:41] whoa... [23:09:50] ready to flush the deployment again. [23:10:57] !log update payments from 5a1996bc21fe694b99556bc1b501e484075dabe2 to a9659965d8b55b11518680a1170242f311c7f1d2 [23:11:01] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log, Master [23:12:04] cool, donate form works for ideal [23:12:33] dstrine: ppena: We suspect that the payments deployment works now... Feel free to test again if you care to! [23:12:35] + paypal [23:12:49] * awight is blown away by futuristic payments page [23:12:53] also amazon [23:13:32] checked the ways to give page, only links to form chooser are paypal [23:13:35] and they still work [23:14:44] (CR) Awight: move worldpay payment methods (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278292 (owner: Cdentinger) [23:15:19] awight looks like ideal, CC and paypal work for me [23:15:36] dstrine: Thanks! [23:16:05] and to be clear, I was using the NL link I first sent at 3:30 PDT [23:16:30] should we need to test any other link? [23:16:38] ooh, emails? [23:16:42] let me see [23:16:55] oh right, they all go to donatewiki [23:17:04] none link straight to formchooser afaik [23:17:08] cwd: Is there some gain from normalization in that patch? I think you successfully killed off all the references to CARD_INFO, so I'm leaning towards agreement with ejegg that this is just another property on payment submethod. [23:17:43] This is me just learning and asking a noob questions about links [23:17:44] dstrine: nah. The deployed changes affect every method, and in lots of different ways. [23:17:46] I want to merge the astropay name and unstaging, actually [23:17:47] Exciting stuff! [23:18:01] awight: ok cool [23:18:13] just the normal reasons people normalize i suppose [23:18:36] but for instance it's going to be ugly to do the wmf->api api->wmf thing if it's nested [23:19:52] cwd: oh. This needs to be rebased on the worldpay staging patch [23:19:59] yeah [23:20:28] i mean we could nest submethods under methods too [23:20:42] i just think nested arrays are clunky to work with [23:20:47] d'oh! which is not merged, so don't worry [23:20:48] https://gerrit.wikimedia.org/r/#/c/277988/ [23:21:20] cwd: I'm fully onboard now that i see the unstaging function needs to do a lookup [23:21:56] just found 2 CTIDs with the same merchant ref... [23:22:01] hmm, having this in an unstaging helper is suddenly difficult [23:22:08] cwd: oh dear. [23:22:20] cwd eek [23:23:03] cwd: Is it recent? I could have caused that with the deployment. [23:23:03] damn, how did we not regenerate the order id? [23:23:16] not that recent...it's in those missing GC things [23:23:27] ohh, GC collision [23:24:02] Our little craps game is starting to feel cramped [23:25:23] (PS5) Awight: Encapsulate Worldpay staging logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277988 [23:25:34] they are the same person though [23:25:36] weird [23:27:08] (PS6) Awight: Encapsulate Worldpay staging logic [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277988 [23:27:53] cwd: That's very bugworthy, fwiw [23:28:16] word, will file [23:28:39] cwd / awight, I just think it makes sense to use the same convention to associate our submethod code + their API name across gateways [23:28:51] and in AstroPay, we have to map both ways [23:28:54] Fundraising Sprint Rowlf the Dog, Fundraising Sprint Snoop (Dogg|Lion), Fundraising Sprint Tom Waits, Fundraising Sprint UB40, and 5 others: Spike: Lots of 21000050 errors for Globalcollect, since July - https://phabricator.wikimedia.org/T107845#2159489 (awight) Saw another one of these on March... [23:29:14] ejegg: yep i definitely agree it should be standardized [23:29:20] so if we just had the payment_method_api_names, we'd have to do the loop / array search to map forward [23:29:26] but isn't it harder to go both ways if it's in a nested array? [23:29:46] ah, i get it [23:29:48] ejegg: but it's almost not a property of the submethod, it really is its own reference table, and the mangling is entirely handled by staging/unstaging transformers [23:30:34] the logo fields are almost a good candidate to be calculated by the gateway rather than properties on method... all in good time. [23:30:42] ah right, so array_search is only possible with simple string => string [23:31:01] we'd have to do array_map or something crazy [23:31:08] get all Pascal on it. [23:31:33] ok, guess i'm just about convinced [23:31:46] (CR) Awight: "PS 5: wp_acctname fixup" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/277988 (owner: Awight) [23:31:57] need to hit two files to add/remove a submethod, but that's not too crazy [23:32:15] good point. hmm [23:32:30] We could also build the reference table in the initializer. [23:32:36] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 4 others: Some Ingenico donations not in Civi - https://phabricator.wikimedia.org/T122730#2159501 (cwdent) @MBeat33 here's what I found after combin... [23:32:39] yuck [23:34:22] Fundraising-Backlog, FR-Ingenico: Multiple gateway transaction IDs with the same merchant ref - https://phabricator.wikimedia.org/T131212#2159511 (cwdent) [23:34:27] everything that tests for equality should take a callable... [23:35:20] so the loadConfig method will slurp up any files and place them in the config based on filename [23:35:38] I think 'group' is probably the craziest key in submethod [23:35:41] so splitting into more files is pretty transparent [23:35:52] maybe we really should build the ref tables after load [23:35:53] ejegg: +1 [23:35:55] ejegg: totally...it's bass ackwards [23:36:02] to "group" being insane [23:37:55] find_submethod_by_subkey_value [23:38:32] takes an array, of course, in case you want to match on multiple subkeys [23:38:43] :P [23:38:46] I still think we need to flatten method vs submethod... [23:39:26] the processors support... methods. These each have some kind of family membership that we keep track of for bookkeeping purposes. [23:39:35] group still has meaning, if only to select certain ones for forms [23:41:26] yeah it's just weird to have the key dictating the outer group...or something [23:41:38] could put them in another config file [23:41:42] time_to_database-- [23:42:39] i do think a bunch of little arrays are easier to deal with than a couple big ones [23:44:20] I think I agree in this case, but not sure that's generally a rule [23:45:11] Data like this config is in its new form primarily for human-readability and writability [23:45:17] same problem as with db normalization [23:45:33] that's a good point [23:45:36] if it's overnormalized, everything reads like spaghetti and is overly magical [23:45:43] yeah [23:46:12] we can always computer up new reference tables after parsing the quaint human files [23:46:26] Fundraising Sprint Asbestos Removal 2016, Fundraising Sprint Bloodletting 2016, Fundraising Sprint Cat Herding, Fundraising Sprint Dirt Farming, and 4 others: Some Ingenico donations not in Civi - https://phabricator.wikimedia.org/T122730#2159551 (MBeat33) Thanks, @cwdent that's quite the bouquet... [23:47:04] yeah...maybe that is a better idea [23:47:19] I donno! [23:48:31] a payment method class with getters and setters might be pretty clean [23:48:48] (CR) Awight: move worldpay payment methods (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/278292 (owner: Cdentinger) [23:49:18] cwd: Just realized your code was correct, I was thrown off by an ambiguous var name [23:49:34] i definitely still prefer a single file [23:50:01] ejegg: well, it's not a regression, this table was already in a weird place. [23:51:18] hm? api_name was a property of the settings array, and the submodule array was generated [23:51:26] i would love to deprecate submethod [23:52:05] i have to run, but i'll be thinking about it [23:56:35] ejegg: It's a cool idea, but unlike any of the other adapters... [23:58:24] ah right [23:58:49] ejegg so does that mean that our Astro release got reversed today? [23:59:09] PPena_: nope, looks like it's up for real! Will send an email out [23:59:17] oh cooool, thanks :D [23:59:18] Hmm, I should test a couple things [23:59:27] ejegg yes pls do ;)